Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
On Thu, Feb 19, 2009 at 12:22:50PM +0100, Bernie Innocenti wrote:
if dimensions is not None:
cmd.append('-screen')
cmd.append(dimensions)
-elif gtk.gdk.screen_width() 1200 or gtk.gdk.screen_height()
900:
+elif gtk.gdk.screen_width() DEFAULT_WIDTH or \
+gtk.gdk.screen_height() DEFAULT_HEIGHT:
cmd.append('-fullscreen')
else:
cmd.append('-screen')
-cmd.append('%dx%d' % (1200, 900))
+cmd.append('%dx%d' % (DEFAULT_WIDTH, DEFAULT_HEIGHT))
Is it on purpose that non-default dimensions can be set (see first three
lines) but for determining whether fullscreen will be used the default
dimensions get examined instead?
Yes, that part isn't changed by the patch and I've wondered about it
before, but not bothered to ask. :)
CU Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
signature.asc
Description: Digital signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Feb 19, 2009 at 12:22:50PM +0100, Bernie Innocenti wrote: This patch seems controversial enough to deserve a public flam^Wreview before hitting gitorious. One possible counterargument for this could be that destabilizing changes should wait until after 0.84. But changing the resolution only affects our test environment, not the production environments. A few of those are *already* using a wide range of display resolutions. The sooner we shake these bugs out of activities, the better experience we provide to our users. +DEFAULT_WIDTH = 1024 +DEFAULT_HEIGHT = 768 How about adjusting that patch to keep old values by default, but provide commandline arguments and perhaps let environment variables overrid default too)? That would avoid surprises, while still allow testing alternate sizes without hacking the code. - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmdRtwACgkQn7DbMsAkQLj32gCfUzsdCq8EbqwJoobgxzeI2XT9 GxsAoJM8poCYQWWVVfYY6pnn3cdZVDhz =JlK3 -END PGP SIGNATURE- ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
Jonas Smedegaard wrote: +DEFAULT_WIDTH = 1024 +DEFAULT_HEIGHT = 768 How about adjusting that patch to keep old values by default, but provide commandline arguments and perhaps let environment variables overrid default too)? That would avoid surprises, while still allow testing alternate sizes without hacking the code. We already have a command line argument to change the default size, and few activity authors seem to test with anything but the default. The intention of this change is to surprise them a little. We might even change it every once in a while to catch those who have hard-coded or special-cased the new default in their code. -- // Bernie Innocenti - http://www.codewiz.org/ \X/ Sugar Labs - http://www.sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
On 19.02.2009, at 15:53, Bernie Innocenti wrote: Jonas Smedegaard wrote: +DEFAULT_WIDTH = 1024 +DEFAULT_HEIGHT = 768 How about adjusting that patch to keep old values by default, but provide commandline arguments and perhaps let environment variables overrid default too)? That would avoid surprises, while still allow testing alternate sizes without hacking the code. We already have a command line argument to change the default size, and few activity authors seem to test with anything but the default. The intention of this change is to surprise them a little. We might even change it every once in a while to catch those who have hard-coded or special-cased the new default in their code. No, make it run at a random resolution between 800x600 and the screen resolution. In particular, not only 4x3 ratios. - Bert - ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Feb 19, 2009 at 03:53:41PM +0100, Bernie Innocenti wrote: Jonas Smedegaard wrote: +DEFAULT_WIDTH = 1024 +DEFAULT_HEIGHT = 768 How about adjusting that patch to keep old values by default, but provide commandline arguments and perhaps let environment variables overrid default too)? That would avoid surprises, while still allow testing alternate sizes without hacking the code. We already have a command line argument to change the default size, and few activity authors seem to test with anything but the default. The intention of this change is to surprise them a little. We might even change it every once in a while to catch those who have hard-coded or special-cased the new default in their code. Ok. I understood the surprise provocation part, but was not aware that it was already possible to set size at commandline (stupid me - I see now that it is right there in the non-changed parts of your diff!). I have no strong opinion on your intention to provoke. Sounds like fun to change default size of the environment - you could even switch to a radical new size with each new (unstable) release. :-) Anyway, I would like to try again, hopefully more clear this time, with this related thought of mine: It would be nice if the default - whatever it is, was expressed not inside the code but in a way that it could be changed per machine. I mentioned environment, but even better would be to put it in a config file. Then XOs could adjust from the default 200x4 to their odd default of theirs, Debian could have a complex debconf question at install time asking the admins preferred size for this installation, and whatever. Does it make sense? Do you see the benefit of this? Do you see anything bad about this? Kind regards, - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmdenEACgkQn7DbMsAkQLiKlQCfRUYi3Z0Sd7BnnFy73rfv9g4P PaMAoJFSTIeh7+KnW2TJaxlF+JRzqR2o =9G9e -END PGP SIGNATURE- ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
On Thu, Feb 19, 2009 at 03:59:22PM +0100, Bernie Innocenti wrote: Since using Sugar in a window does not actually make sense for users, we might as well change the default of sugar-emulator to go full-screen by default, and make sugar-jhbuild invoke it with the 1024x768 window for developers. Sounds fine, though I'm wondering why regular users would want the extra indirection of Xephyr in the first place. But that's actually a different topic. CU Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: Digital signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thu, Feb 19, 2009 at 03:59:22PM +0100, Bernie Innocenti wrote:
Sascha Silbe wrote:
On Thu, Feb 19, 2009 at 12:22:50PM +0100, Bernie Innocenti wrote:
if dimensions is not None:
cmd.append('-screen')
cmd.append(dimensions)
-elif gtk.gdk.screen_width() 1200 or gtk.gdk.screen_height() 900:
+elif gtk.gdk.screen_width() DEFAULT_WIDTH or \
+gtk.gdk.screen_height() DEFAULT_HEIGHT:
cmd.append('-fullscreen')
else:
cmd.append('-screen')
-cmd.append('%dx%d' % (1200, 900))
+cmd.append('%dx%d' % (DEFAULT_WIDTH, DEFAULT_HEIGHT))
Is it on purpose that non-default dimensions can be set (see first three
lines) but for determining whether fullscreen will be used the default
dimensions get examined instead?
Yes, that part isn't changed by the patch and I've wondered about it
before, but not bothered to ask. :)
Looks like a bug, indeed.
After discussing a little with Tomeu on IRC, it seems that we have two
kind of users for sugar-emulator:
- developers who run it from jhbuild
- very few end users who run it from the desktop menu item
Those we want to bother with this change is of course the developers.
It turns out that some users might actually have been relying on the
implicit switch to full-screen that happens if their desktop is
narrower than 1200 or shorter than 900 pixels.
Since using Sugar in a window does not actually make sense for users,
we might as well change the default of sugar-emulator to go
full-screen by default, and make sugar-jhbuild invoke it with the
1024x768 window for developers.
If it seems likea better strategy, I'll come up with a patch to do this.
Suggestion:
1) Extend size logic to support 0 (fullscreen) and -1 (random)
2) Add configfile parsing (gconf?) of (at least) width and height
3) Set internal defaults (both width and height) to -1
4) Provide sample configfile with defaults set to 0
- Jonas
- --
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkmdfaoACgkQn7DbMsAkQLhKEACbB+0It8WMBdEEOlbjUAAPegs8
/y8AoIzTB91lQVg7VcXXL6MjRIRbPp+t
=GTcd
-END PGP SIGNATURE-
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Feb 19, 2009 at 11:21:03AM -0500, Luke Faraone wrote: div class=gmail_quoteblockquote class=gmail_quote style=border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;Anyway, I would like to try again, hopefully more clear this time, withbr this related thought of mine: It would be nice if the default - whateverbr it is, was expressed not inside the code but in a way that it could bebr changed per machine. I mentioned environment, but even better would bebr to put it in a config file. Then XOs could adjust from the defaultbr 200x4 to their odd default of theirs, Debian could have a complexbr debconf question at install time asking the admins preferred size forbr this installation, and whatever./blockquotedivbrKeep in mind that we were talking about changing the defaults in sugar-jhbuild, which is used by developers; users (and debian, which uses sugar-emulator) would see no effect.nbsp; br/div/divbr-- brLuke Faraonebrhttp://luke.faraone.ccbr No. We are talking about patching the script bin/sugar-emulator itself! (please change the setup of your MUA, it is a pain to read) - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmdjQcACgkQn7DbMsAkQLjsEgCfcPNjxkyrmdE+eYWdUz1CQb+S PQIAnR15Gl5AUjYnPLgGOuNKWTbUGC76 =dO37 -END PGP SIGNATURE- ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
On 19.02.2009, at 17:21, Luke Faraone wrote: Anyway, I would like to try again, hopefully more clear this time, with this related thought of mine: It would be nice if the default - whatever it is, was expressed not inside the code but in a way that it could be changed per machine. I mentioned environment, but even better would be to put it in a config file. Then XOs could adjust from the default 200x4 to their odd default of theirs, Debian could have a complex debconf question at install time asking the admins preferred size for this installation, and whatever. Keep in mind that we were talking about changing the defaults in sugar-jhbuild, which is used by developers; users (and debian, which uses sugar-emulator) would see no effect. Not quite, jhbuild uses sugar-emulator too. - Bert - ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
On Thu, Feb 19, 2009 at 17:47, Bert Freudenberg b...@freudenbergs.de wrote: On 19.02.2009, at 17:21, Luke Faraone wrote: Anyway, I would like to try again, hopefully more clear this time, with this related thought of mine: It would be nice if the default - whatever it is, was expressed not inside the code but in a way that it could be changed per machine. I mentioned environment, but even better would be to put it in a config file. Then XOs could adjust from the default 200x4 to their odd default of theirs, Debian could have a complex debconf question at install time asking the admins preferred size for this installation, and whatever. Keep in mind that we were talking about changing the defaults in sugar-jhbuild, which is used by developers; users (and debian, which uses sugar-emulator) would see no effect. Not quite, jhbuild uses sugar-emulator too. Wasn't at some point proposed to only modify ./sugar-jhbuild run to call sugar-emulator with a smaller resolution? Regards, Tomeu ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
Is it possible to just make the Sugar emulator resizable during runtime? I know I spend a lot of time fixing my activities for the XO's Rotate Screen key which is a bit different than just starting up in a different resolution. Best, Wade On Thu, Feb 19, 2009 at 12:21 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Thu, Feb 19, 2009 at 17:47, Bert Freudenberg b...@freudenbergs.de wrote: On 19.02.2009, at 17:21, Luke Faraone wrote: Anyway, I would like to try again, hopefully more clear this time, with this related thought of mine: It would be nice if the default - whatever it is, was expressed not inside the code but in a way that it could be changed per machine. I mentioned environment, but even better would be to put it in a config file. Then XOs could adjust from the default 200x4 to their odd default of theirs, Debian could have a complex debconf question at install time asking the admins preferred size for this installation, and whatever. Keep in mind that we were talking about changing the defaults in sugar-jhbuild, which is used by developers; users (and debian, which uses sugar-emulator) would see no effect. Not quite, jhbuild uses sugar-emulator too. Wasn't at some point proposed to only modify ./sugar-jhbuild run to call sugar-emulator with a smaller resolution? Regards, Tomeu ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Feb 19, 2009 at 12:36:26PM -0500, Wade Brainerd wrote: Is it possible to just make the Sugar emulator resizable during runtime? I know I spend a lot of time fixing my activities for the XO's Rotate Screen key which is a bit different than just starting up in a different resolution. Don't know, but it seems Xephyr supports xrandr. This related discussion might be relevant: http://butterfeet.org/?p=26 - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmdpyQACgkQn7DbMsAkQLg31QCaAseUiEUEp4E4tqGeNF4JHeER i7kAoJbj8t4VYbVEvdsno/lnOzB4TAvK =Xjn9 -END PGP SIGNATURE- ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
