Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell

2012-08-14 Thread Simon Schampijer

On 08/13/2012 11:23 PM, Simon Schampijer wrote:

On 08/06/2012 12:04 PM, Simon Schampijer wrote:

This is a patch series to make the Sugar shell hippo free. Based on the
work that has been done in [1] and [2]. It incorporates the patch from
Sascha to move the EventIcon into the shell temporary.


I merged those patches now with the suggestions made in the review. The
work has been gone through several eyes, never less if you find any
issues please report them so we can fix them.

Regards,
Simon


If you find issues regarding the 'nohippo' changes please add the 
'nohippo' keyword. I created an rpm (from current master) to test on the 
XO [1] with the latest 12.1.0 build [2].


Just found one regression, only visible on the XO, regarding displaying 
of thumbnails in the Journal [3].


So please test and keep the bug reports coming. If we are stable in 
regards to the hippo changes next Monday I will make an official 
no-hippo release.


Regards,
   Simon

[1] 
http://dev.laptop.org/~erikos/nohippo/sugar-0.97.1-1.fc17.olpc.noarch.rpm

[2] http://wiki.laptop.org/go/Release_notes/12.1.0
[3] http://bugs.sugarlabs.org/ticket/3804

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell

2012-08-13 Thread Simon Schampijer

On 08/06/2012 12:04 PM, Simon Schampijer wrote:

This is a patch series to make the Sugar shell hippo free. Based on the
work that has been done in [1] and [2]. It incorporates the patch from
Sascha to move the EventIcon into the shell temporary.


I merged those patches now with the suggestions made in the review. The 
work has been gone through several eyes, never less if you find any 
issues please report them so we can fix them.


Regards,
   Simon

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell

2012-08-06 Thread Sascha Silbe
Simon Schampijer si...@schampijer.de writes:

 This is a patch series to make the Sugar shell hippo free. Based on the
 work that has been done in [1] and [2]. It incorporates the patch from
 Sascha to move the EventIcon into the shell temporary. 
[...]

Thanks for the patch series and especially for the detailed
descriptions, they are rather helpful!

One thing I noticed while working on the UI tests (or rather the
prerequisite, making Sugar accessible): The Owner Icon is the _last_
entry in the list, at least for the Home View. Can we make it the first
one instead (without going to great lengths)?

With the version I tested, there was also some issue with positioning;
IIRC the Owner Icon was off-center. Has this been fixed? Are there any
(other) known bugs?

I've discussed the approach for both the hippo removal series and the
GTK3 port with a couple of community members over the past few weeks and
we agreed that we should focus on the architecture (i.e. external API,
internal API, interactions with other components / APIs) and work
towards merging the patches sooner rather than later. We fully expect
there to be major bugs, but by merging early we enable a) widespread
manual testing and b) development of automated UI tests that can verify
the GTK3 port against the current behaviour of the GTK2 version. Unless
we can't solve a number of technical issues [1] with accessibility
support, my plan would be to do things in this order:

1. Merge hippo removal patch series.
2. Finish and merge accessibility patch series. It should be complete
   enough to test all major parts of the UI. Accessibility support for
   humans (e.g. using screen readers) is only a side effect at this
   stage, not a goal. Help with this effort (especially fixing the
   current blockers [1]) would be quite appreciated.
3a. Develop a UI test suite based on the latest GTK2 version of Sugar.
3b. Finish and merge GTK3 port.

3a. and 3b. can happen in parallel.

Caspar and me would still review the patches and make a couple of
suggestions where the patches can be _easily_ improved, but in general
we'd focus on the interfaces rather than the implementation.

Would that work for you?

Sascha

[1] message-id:toeehnrlhad@twin.sascha.silbe.org

https://mail.gnome.org/archives/gnome-accessibility-list/2012-July/msg00029.html
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/


pgpU3QHJvpLsY.pgp
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel