Re: svn commit: r367066 - head/sys/compat/linux

[Ronald Klop]

On Mon, 26 Oct 2020 19:03:51 +0100, Mateusz Guzik  wrote:


Author: mjg
Date: Mon Oct 26 18:03:50 2020
New Revision: 367066
URL: https://svnweb.freebsd.org/changeset/base/367066

Log:
  linux: silence renameat2 flags warning
 Hogs the console while building the Linux kernel in a Ubuntu Focal jail.



Is ratelimiting possible here?

Ronald.




Modified:
  head/sys/compat/linux/linux_file.c

Modified: head/sys/compat/linux/linux_file.c
==
--- head/sys/compat/linux/linux_file.c  Mon Oct 26 18:02:52 2020
(r367065)
+++ head/sys/compat/linux/linux_file.c  Mon Oct 26 18:03:50 2020
(r367066)
@@ -816,8 +816,16 @@ linux_renameat2(struct thread *td, struct  
linux_rename

args->flags & (LINUX_RENAME_NOREPLACE |
LINUX_RENAME_WHITEOUT))
return (EINVAL);
+#if 0
+   /*
+* This spams the console on Ubuntu Focal.
+*
+* What's needed here is a general mechanism to let users know
+* about missing features without hogging the system.
+*/
linux_msg(td, "renameat2 unsupported flags 0x%x",
args->flags);
+#endif
return (EINVAL);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366431 - head/sys/dev/usb/serial

[Ronald Klop]

Hi,

I was interested by this commit. But the commit and commit message don't have much 
information. I was surprised that the "Differential Revision" link contains a 
lot of info about this. How permanent is this review.freebsd.org server? Wil it stay 
after the git migration?

Ronald.

Van: Hans Petter Selasky 
Datum: zondag, 4 oktober 2020 19:17
Aan: src-committ...@freebsd.org, svn-src-all@freebsd.org, 
svn-src-h...@freebsd.org
Onderwerp: svn commit: r366431 - head/sys/dev/usb/serial


Author: hselasky
Date: Sun Oct  4 17:17:16 2020
New Revision: 366431
URL: https://svnweb.freebsd.org/changeset/base/366431

Log:
  Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces to
  the USB generic serial port driver, ugensa.
  
  MFC after:1 week

  Differential Revision:https://reviews.freebsd.org/D21863
  Submitted by: greg_unrelenting.technology (Greg V)
  Sponsored by: Mellanox Technologies // NVIDIA Networking

Modified:
  head/sys/dev/usb/serial/ugensa.c

Modified: head/sys/dev/usb/serial/ugensa.c
==
--- head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:07:13 2020(r366430)
+++ head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:17:16 2020(r366431)
@@ -161,6 +161,8 @@ static const STRUCT_USB_HOST_ID ugensa_devs[] = {
{USB_VPI(USB_VENDOR_KYOCERA2, USB_PRODUCT_KYOCERA2_CDMA_MSM_K, 1)},
{USB_VPI(USB_VENDOR_HP, USB_PRODUCT_HP_49GPLUS, 1)},
{USB_VPI(USB_VENDOR_NOVATEL2, USB_PRODUCT_NOVATEL2_FLEXPACKGPS, 3)},
+   {USB_VENDOR(USB_VENDOR_GOOGLE), USB_IFACE_CLASS(UICLASS_VENDOR),
+   USB_IFACE_SUBCLASS(0x50), USB_IFACE_PROTOCOL(0x01), 
USB_DRIVER_INFO(10)},
 };
 
 DRIVER_MODULE(ugensa, uhub, ugensa_driver, ugensa_devclass, NULL, 0);

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"




___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r365449 - head/sbin/rcorder

[Ronald Klop]

Van: John Baldwin 
Datum: vrijdag, 18 september 2020 00:50
Aan: "Olivier Cochard-Labbé" 
CC: "Andrey V. Elsukov" , src-committers , 
svn-src-all , svn-src-head 
Onderwerp: Re: svn commit: r365449 - head/sbin/rcorder


On 9/17/20 3:44 PM, Olivier Cochard-Labbé wrote:
> On Thu, Sep 17, 2020 at 10:21 PM John Baldwin  wrote:
>> I think long term we want OCF's notions of sessions to be a bit more
>> fluid such that "client" sessions for things like GELI and IPSec can
>> be backed by one or more "driver" sessions (including "driver" sessions
>> coming and going as devices come and go).  That's a fair bit more work
>> however.
>>
>>
> And why not simply add 'kld' into the REQUIRE part of /etc/rc.d/ipsec ?
> But this will fix only IPsec: What about other crypto consumers ?

The problem is that kld_list can be used to load all sorts of modules.
Perhaps some of them need to be loaded after the network is configured,
for example, but ipsec is probably before NETWORKING, so moving kld
earlier would break those modules.  The problem with 'kld' is that it is
super generic so there isn't a "right" place to put it.

I'm not sure of an easy solution.  In your case, if you put aesni_load=YES
in loader.conf instead of putting aesni in kld_list you would be fine
though.  I'm not sure it's really safe to assume that things loaded by
kld_list are available for any boot-time services.

--
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"






Another solution could be to create a /etc/rc.d/aesni script which loads the 
aesni module and use that for dependencies instead of the generic kld_list.
Or a more generic /etc/rc.d/cryptostuff.

Regards,
Ronald.

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r365662 - in stable: 11/contrib/jemalloc 11/contrib/jemalloc/doc 11/lib/libc/stdlib/jemalloc 11/share/man/man5 11/share/mk 11/tools/build/options 12/contrib/jemalloc 12/contrib/jemallo

[Ronald Klop]

Hi,

Isn't this important enough for a note in UPDATING? Or a message in the  
backwards compatibility code to point the user to the new setting?


Regards,
Ronald.


On Sat, 12 Sep 2020 18:50:05 +0200, Dimitry Andric  wrote:


Author: dim
Date: Sat Sep 12 16:50:04 2020
New Revision: 365662
URL: https://svnweb.freebsd.org/changeset/base/365662

Log:
  MFC r365371:
 Turn MALLOC_PRODUCTION into a regular src.conf(5) option
 For historical reasons, defining MALLOC_PRODUCTION in /etc/make.conf has
  been used to turn off potentially expensive debug checks and statistics
  gathering in the implementation of malloc(3).
 It seems more consistent to turn this into a regular src.conf(5) option,
  e.g. WITH_MALLOC_PRODUCTION / WITHOUT_MALLOC_PRODUCTION. This can then
  be toggled similar to any other source build option, and turned on or
  off by default for e.g. stable branches.
 Reviewed by:   imp, #manpages
  Differential Revision: https://reviews.freebsd.org/D26337
 MFC r365373:
 Follow-up r365371 by removing sentences which indicate the state of the
  MK_MALLOC_PRODUCTION option on -CURRENT.
 Also, for the sake of backwards compatibility, support the old way of
  enabling 'production malloc', e.g. by adding a define in make.conf(5).

Added:
  stable/12/tools/build/options/WITHOUT_MALLOC_PRODUCTION
 - copied, changed from r365371,  
head/tools/build/options/WITHOUT_MALLOC_PRODUCTION

  stable/12/tools/build/options/WITH_MALLOC_PRODUCTION
 - copied, changed from r365371,  
head/tools/build/options/WITH_MALLOC_PRODUCTION

Modified:
  stable/12/contrib/jemalloc/FREEBSD-diffs
  stable/12/contrib/jemalloc/doc/jemalloc.3
  stable/12/lib/libc/stdlib/jemalloc/Makefile.inc
  stable/12/share/man/man5/make.conf.5
  stable/12/share/man/man5/src.conf.5
  stable/12/share/mk/src.opts.mk
Directory Properties:
  stable/12/   (props changed)

Changes in other areas also in this revision:
Added:
  stable/11/tools/build/options/WITHOUT_MALLOC_PRODUCTION
 - copied, changed from r365371,  
head/tools/build/options/WITHOUT_MALLOC_PRODUCTION

  stable/11/tools/build/options/WITH_MALLOC_PRODUCTION
 - copied, changed from r365371,  
head/tools/build/options/WITH_MALLOC_PRODUCTION

Modified:
  stable/11/contrib/jemalloc/FREEBSD-diffs
  stable/11/contrib/jemalloc/doc/jemalloc.3
  stable/11/lib/libc/stdlib/jemalloc/Makefile.inc
  stable/11/share/man/man5/make.conf.5
  stable/11/share/man/man5/src.conf.5
  stable/11/share/mk/src.opts.mk
Directory Properties:
  stable/11/   (props changed)

Modified: stable/12/contrib/jemalloc/FREEBSD-diffs
==
--- stable/12/contrib/jemalloc/FREEBSD-diffs	Sat Sep 12 16:33:05  
2020	(r365661)
+++ stable/12/contrib/jemalloc/FREEBSD-diffs	Sat Sep 12 16:50:04  
2020	(r365662)

@@ -14,7 +14,7 @@ index 1e12fd3a..c42a7e10 100644
 +--with-malloc-conf=abort_conf:false.
 +Additionally, --enable-debug is enabled in  
development

 +versions of FreeBSD (controlled by the
-+MALLOC_PRODUCTION make variable).
++MK_MALLOC_PRODUCTION make variable).
 +



Modified: stable/12/contrib/jemalloc/doc/jemalloc.3
==
--- stable/12/contrib/jemalloc/doc/jemalloc.3	Sat Sep 12 16:33:05  
2020	(r365661)
+++ stable/12/contrib/jemalloc/doc/jemalloc.3	Sat Sep 12 16:50:04  
2020	(r365662)

@@ -43,7 +43,7 @@ The following configuration options are enabled in lib
 \fB\-\-with\-malloc\-conf=abort_conf:false\fR\&. Additionally,
 \fB\-\-enable\-debug\fR
 is enabled in development versions of FreeBSD (controlled by the
-\fBMALLOC_PRODUCTION\fR
+\fBMK_MALLOC_PRODUCTION\fR
 make variable)\&.
 .SH "SYNOPSIS"
 .sp

Modified: stable/12/lib/libc/stdlib/jemalloc/Makefile.inc
==
--- stable/12/lib/libc/stdlib/jemalloc/Makefile.inc	Sat Sep 12 16:33:05  
2020	(r365661)
+++ stable/12/lib/libc/stdlib/jemalloc/Makefile.inc	Sat Sep 12 16:50:04  
2020	(r365662)

@@ -44,6 +44,6 @@ MLINKS+= \
jemalloc.3 nallocx.3 \
jemalloc.3 malloc.conf.5
-.if defined(MALLOC_PRODUCTION)
+.if ${MK_MALLOC_PRODUCTION} != "no" || defined(MALLOC_PRODUCTION)
 CFLAGS+=   -DMALLOC_PRODUCTION
 .endif

Modified: stable/12/share/man/man5/make.conf.5
==
--- stable/12/share/man/man5/make.conf.5	Sat Sep 12 16:33:05  
2020	(r365661)
+++ stable/12/share/man/man5/make.conf.5	Sat Sep 12 16:50:04  
2020	(r365662)

@@ -401,12 +401,6 @@ console driver to
 and allow access over FireWire(IEEE1394) using
 .Xr dconschat 8 .
 Currently, only i386 and amd64 are supported.
-.It Va MALLOC_PRODUCTION
-.Pq Vt bool
-Set this to disable assertions and statistics gathering in
-.Xr malloc 3 .
-It also defaults the A and J runtime options to off.
-Disabled by default on -CURRENT.
 .It Va MAN_ARCH
 .Pq Vt str
 Space-delimited list of one or more MACHINE 

Re: svn commit: r363595 - head/sys/kern

[Ronald Klop]

Hi,

Helpful addition. Might it help people more to make the message point to the 
replacement of the deprecated functionality?

Regards,
Ronald.


Van: Kyle Evans 
Datum: maandag, 27 juli 2020 05:13
Aan: src-committ...@freebsd.org, svn-src-all@freebsd.org, 
svn-src-h...@freebsd.org
Onderwerp: svn commit: r363595 - head/sys/kern


Author: kevans
Date: Mon Jul 27 03:13:23 2020
New Revision: 363595
URL: https://svnweb.freebsd.org/changeset/base/363595

Log:
  makesyscalls.sh: spit out a deprecation notice to stderr
  
  This has for a while been replaced by makesyscalls.lua in the stock FreeBSD

  build.  Ensure downstreams get some notice that it'a going away if they're
  reliant on it, maybe.

Modified:
  head/sys/kern/makesyscalls.sh

Modified: head/sys/kern/makesyscalls.sh
==
--- head/sys/kern/makesyscalls.sh   Mon Jul 27 01:53:27 2020(r363594)
+++ head/sys/kern/makesyscalls.sh   Mon Jul 27 03:13:23 2020(r363595)
@@ -60,6 +60,8 @@ case $# in
;;
 esac
 
+1>&2 echo "$0: This script is deprecated and will be removed before FreeBSD 13."

+
 if [ -n "$2" ]; then
. "$2"
 fi
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"




___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r360836 - head/stand/libsa/zfs

[Ronald Klop]

On Sat, 09 May 2020 09:25:29 +0200, Toomas Soome  wrote:





On 9. May 2020, at 09:57, Ronald Klop  wrote:

Hi Toomas,

Could this fix this issue  
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=144234 ?


Regards,
Ronald.



I doubt a bit unless you have GELI encryption or 4kn disk (which we can  
not boot with BIOS, only with UEFI). That issue was reported 2010 agains  
9.0? is it still the case?


rgds,
toomas



Clear answer. I don't use the computer I had this problem with anymore.  
(It is in the attic somewhere,) And the problem disappeared for me in 2017  
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=144234#c33). But the  
issue apparently happens for other people in 12.1 still as I read in the  
replies to the issue.


Because of the bogus LBA numbers I suspected some memory corruption. But  
never found further evidence for this.


Regards,
Ronald.





On Sat, 09 May 2020 08:25:21 +0200, Toomas Soome   
wrote:



Author: tsoome
Date: Sat May  9 06:25:20 2020
New Revision: 360836
URL: https://svnweb.freebsd.org/changeset/base/360836

Log:
 loader: vdev_read() can corrupt memory
When reading less than sector size but from sector boundary,
 the vdev_read() will read full sector into the provided buffer
 and therefore corrupting memory past buffer end.
MFC after:  2 days

Modified:
 head/stand/libsa/zfs/zfs.c

Modified: head/stand/libsa/zfs/zfs.c
==
--- head/stand/libsa/zfs/zfs.c  Sat May  9 05:04:02 2020(r360835)
+++ head/stand/libsa/zfs/zfs.c  Sat May  9 06:25:20 2020(r360836)
@@ -418,7 +418,7 @@ vdev_read(vdev_t *vdev, void *priv, off_t offset,  
void

full_sec_size -= secsz;
/* Return of partial sector data requires a bounce buffer. */
-   if ((head > 0) || do_tail_read) {
+   if ((head > 0) || do_tail_read || bytes < secsz) {
bouncebuf = malloc(secsz);
if (bouncebuf == NULL) {
printf("vdev_read: out of memory\n");
@@ -442,14 +442,28 @@ vdev_read(vdev_t *vdev, void *priv, off_t  
offset, void

outbuf += min(secsz - head, bytes);
}
-   /* Full data return from read sectors */
+   /*
+* Full data return from read sectors.
+* Note, there is still corner case where we read
+* from sector boundary, but less than sector size, e.g. reading 512B
+* from 4k sector.
+*/
if (full_sec_size > 0) {
-   res = read(fd, outbuf, full_sec_size);
-   if (res != full_sec_size) {
-   ret = EIO;
-   goto error;
+   if (bytes < full_sec_size) {
+   res = read(fd, bouncebuf, secsz);
+   if (res != secsz) {
+   ret = EIO;
+   goto error;
+   }
+   memcpy(outbuf, bouncebuf, bytes);
+   } else {
+   res = read(fd, outbuf, full_sec_size);
+   if (res != full_sec_size) {
+   ret = EIO;
+   goto error;
+   }
+   outbuf += full_sec_size;
}
-   outbuf += full_sec_size;
}
/* Partial data return from last sector */
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r360836 - head/stand/libsa/zfs

[Ronald Klop]

Hi Toomas,

Could this fix this issue  
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=144234 ?


Regards,
Ronald.


On Sat, 09 May 2020 08:25:21 +0200, Toomas Soome   
wrote:



Author: tsoome
Date: Sat May  9 06:25:20 2020
New Revision: 360836
URL: https://svnweb.freebsd.org/changeset/base/360836

Log:
  loader: vdev_read() can corrupt memory
 When reading less than sector size but from sector boundary,
  the vdev_read() will read full sector into the provided buffer
  and therefore corrupting memory past buffer end.
 MFC after: 2 days

Modified:
  head/stand/libsa/zfs/zfs.c

Modified: head/stand/libsa/zfs/zfs.c
==
--- head/stand/libsa/zfs/zfs.c  Sat May  9 05:04:02 2020(r360835)
+++ head/stand/libsa/zfs/zfs.c  Sat May  9 06:25:20 2020(r360836)
@@ -418,7 +418,7 @@ vdev_read(vdev_t *vdev, void *priv, off_t offset,  
void

full_sec_size -= secsz;
/* Return of partial sector data requires a bounce buffer. */
-   if ((head > 0) || do_tail_read) {
+   if ((head > 0) || do_tail_read || bytes < secsz) {
bouncebuf = malloc(secsz);
if (bouncebuf == NULL) {
printf("vdev_read: out of memory\n");
@@ -442,14 +442,28 @@ vdev_read(vdev_t *vdev, void *priv, off_t offset,  
void

outbuf += min(secsz - head, bytes);
}
-   /* Full data return from read sectors */
+   /*
+* Full data return from read sectors.
+* Note, there is still corner case where we read
+* from sector boundary, but less than sector size, e.g. reading 512B
+* from 4k sector.
+*/
if (full_sec_size > 0) {
-   res = read(fd, outbuf, full_sec_size);
-   if (res != full_sec_size) {
-   ret = EIO;
-   goto error;
+   if (bytes < full_sec_size) {
+   res = read(fd, bouncebuf, secsz);
+   if (res != secsz) {
+   ret = EIO;
+   goto error;
+   }
+   memcpy(outbuf, bouncebuf, bytes);
+   } else {
+   res = read(fd, outbuf, full_sec_size);
+   if (res != full_sec_size) {
+   ret = EIO;
+   goto error;
+   }
+   outbuf += full_sec_size;
}
-   outbuf += full_sec_size;
}
/* Partial data return from last sector */
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r360068 - in head/sys: kern net sys

[Ronald Klop]

Nice feature. A question below.


On Sat, 18 Apr 2020 09:50:30 +0200, Kristof Provost  wrote:


Author: kp
Date: Sat Apr 18 07:50:30 2020
New Revision: 360068
URL: https://svnweb.freebsd.org/changeset/base/360068

Log:
  ethersubr: Make the mac address generation more robust
 If we create two (vnet) jails and create a bridge interface in each we  
end up

  with the same mac address on both bridge interfaces.
  These very often conflicts, resulting in same mac address in both  
jails.

 Mitigate this problem by including the jail name in the mac address.
 Reviewed by:   kevans, melifaro
  MFC after:1 week
  Differential Revision:https://reviews.freebsd.org/D24383

Modified:
  head/sys/kern/kern_jail.c
  head/sys/net/if_ethersubr.c
  head/sys/sys/jail.h

Modified: head/sys/kern/kern_jail.c
==
--- head/sys/kern/kern_jail.c   Sat Apr 18 03:14:16 2020(r360067)
+++ head/sys/kern/kern_jail.c   Sat Apr 18 07:50:30 2020(r360068)
@@ -2920,6 +2920,15 @@ getcredhostid(struct ucred *cred, unsigned long  
*hosti

mtx_unlock(>cr_prison->pr_mtx);
 }
+void
+getjailname(struct ucred *cred, char *name, size_t len)
+{
+
+   mtx_lock(>cr_prison->pr_mtx);
+   strlcpy(name, cred->cr_prison->pr_name, len);
+   mtx_unlock(>cr_prison->pr_mtx);
+}
+
 #ifdef VIMAGE
 /*
  * Determine whether the prison represented by cred owns

Modified: head/sys/net/if_ethersubr.c
==
--- head/sys/net/if_ethersubr.c Sat Apr 18 03:14:16 2020(r360067)
+++ head/sys/net/if_ethersubr.c Sat Apr 18 07:50:30 2020(r360068)
@@ -1419,27 +1419,39 @@ ether_8021q_frame(struct mbuf **mp, struct ifnet  
*ife,

/*
  * Allocate an address from the FreeBSD Foundation OUI.  This uses a
- * cryptographic hash function on the containing jail's UUID and the  
interface
- * name to attempt to provide a unique but stable address.   
Pseudo-interfaces

- * which require a MAC address should use this function to allocate
- * non-locally-administered addresses.
+ * cryptographic hash function on the containing jail's name, UUID and  
the

+ * interface name to attempt to provide a unique but stable address.
+ * Pseudo-interfaces which require a MAC address should use this  
function to

+ * allocate non-locally-administered addresses.
  */
 void
 ether_gen_addr(struct ifnet *ifp, struct ether_addr *hwaddr)
 {
-#defineETHER_GEN_ADDR_BUFSIZ   HOSTUUIDLEN + IFNAMSIZ + 2
SHA1_CTX ctx;
-   char buf[ETHER_GEN_ADDR_BUFSIZ];
+   char *buf;
char uuid[HOSTUUIDLEN + 1];
uint64_t addr;
int i, sz;
char digest[SHA1_RESULTLEN];
+   char jailname[MAXHOSTNAMELEN];
getcredhostuuid(curthread->td_ucred, uuid, sizeof(uuid));
-	sz = snprintf(buf, ETHER_GEN_ADDR_BUFSIZ, "%s-%s", uuid,  
ifp->if_xname);

+   /* If each (vnet) jail would also have a unique hostuuid this would not
+* be necessary. */
+   getjailname(curthread->td_ucred, jailname, sizeof(jailname));
+   sz = asprintf(, M_TEMP, "%s-%s-%s", uuid, if_name(ifp),
+   jailname);
+   if (sz < 0) {
+   /* Fall back to a random mac address. */



I was wondering if it would be valuable to give this fall back something  
like:


   printf("%s: unable to create fixed mac address; using random  
mac address", if_name(ifp));


This will only be printed in rare circumstances. But in that case will  
provide valuable information.


Regards,

Ronald.



+   arc4rand(hwaddr, sizeof(*hwaddr), 0);
+   hwaddr->octet[0] = 0x02;
+   return;
+   }
+
SHA1Init();
SHA1Update(, buf, sz);
SHA1Final(digest, );
+   free(buf, M_TEMP);
addr = ((digest[0] << 16) | (digest[1] << 8) | digest[2]) &
OUI_FREEBSD_GENERATED_MASK;

Modified: head/sys/sys/jail.h
==
--- head/sys/sys/jail.h Sat Apr 18 03:14:16 2020(r360067)
+++ head/sys/sys/jail.h Sat Apr 18 07:50:30 2020(r360068)
@@ -382,6 +382,7 @@ void getcredhostname(struct ucred *, char *, size_t);
 void getcreddomainname(struct ucred *, char *, size_t);
 void getcredhostuuid(struct ucred *, char *, size_t);
 void getcredhostid(struct ucred *, unsigned long *);
+void getjailname(struct ucred *cred, char *name, size_t len);
 void prison0_init(void);
 int prison_allow(struct ucred *, unsigned);
 int prison_check(struct ucred *cred1, struct ucred *cred2);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send 

Re: svn commit: r356725 - head/usr.bin/diff

[Ronald Klop]

Van: Baptiste Daroussin 
Datum: dinsdag, 14 januari 2020 18:10
Aan: Ian Lepore 
CC: svn-src-h...@freebsd.org, svn-src-all@freebsd.org, 
src-committ...@freebsd.org
Onderwerp: Re: svn commit: r356725 - head/usr.bin/diff


On Tue, Jan 14, 2020 at 08:44:29AM -0700, Ian Lepore wrote:
> On Tue, 2020-01-14 at 08:22 +, Baptiste Daroussin wrote:
> > Author: bapt
> > Date: Tue Jan 14 08:22:28 2020
> > New Revision: 356725
> > URL: https://svnweb.freebsd.org/changeset/base/356725
> >
> > Log:
> >   When system calls indicate an error they return -1, not some
> > arbitrary
> >   value < 0.  errno is only updated in this case.
> >   
>

> What's the point of these changes, other than almost certainly leading
> to worse code generation?
>
> In most instruction sets, you can test for a value < 0 without using
> any instructions, you only need to examine the condition flags after
> loading the value.  To compare equal to -1 typically requires at least
> 1 extra instruction, and on risc architectures typically at least two
> extra (load -1 to a register then compare).
>
our diff has forked from the OpenBSD one. The goal of those patches is to keep
in sync code that is still close to the original OpenBSD one as much as
possible.

Best regards,
Bapt


This is a nice example that it is valuable to describe in the commit message *why* a 
commit is made. Or "the goal" of the patches.

Regards,
Ronald.

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r356120 - head/sys/security/mac

[Ronald Klop]

On Fri, 27 Dec 2019 12:23:32 +0100, Mateusz Guzik  wrote:


Author: mjg
Date: Fri Dec 27 11:23:32 2019
New Revision: 356120
URL: https://svnweb.freebsd.org/changeset/base/356120

Log:
  mac: use a sleepable rmlock instead of an sx lock
 If any non-static modules are loaded (and mac_ntpd tends to be), the  
lock is
  taken all the time al over the kernel. On platforms like arm64 this  
results in
  an avoidable significant performance degradation. Since write-locking  
is almost

  never needed, use a primitive optimized towards read-locking.
 Sample result of building the kernel on tmpfs 11 times:
  stock   11142.80s user 6704.44s system 4924% cpu 6:02.42 total
  patched 8.95s user 2374.94s system 4547% cpu 4:56.71 total



Wow, this looks like a winner.

Ronald.




Modified:
  head/sys/security/mac/mac_framework.c

Modified: head/sys/security/mac/mac_framework.c
==
--- head/sys/security/mac/mac_framework.c	Fri Dec 27 11:19:57  
2019	(r356119)
+++ head/sys/security/mac/mac_framework.c	Fri Dec 27 11:23:32  
2019	(r356120)
@@ -176,6 +176,7 @@ MALLOC_DEFINE(M_MACTEMP, "mactemp", "MAC temporary  
lab

 #ifndef MAC_STATIC
 static struct rmlock mac_policy_rm;/* Non-sleeping entry points. */
 static struct sx mac_policy_sx;/* Sleeping entry points. */
+static struct rmslock mac_policy_rms;
 #endif
struct mac_policy_list_head mac_policy_list;
@@ -209,7 +210,7 @@ mac_policy_slock_sleep(void)
if (!mac_late)
return;
-   sx_slock(_policy_sx);
+   rms_rlock(_policy_rms);
 #endif
 }
@@ -233,7 +234,7 @@ mac_policy_sunlock_sleep(void)
if (!mac_late)
return;
-   sx_sunlock(_policy_sx);
+   rms_runlock(_policy_rms);
 #endif
 }
@@ -249,6 +250,7 @@ mac_policy_xlock(void)
return;
sx_xlock(_policy_sx);
+   rms_wlock(_policy_rms);
rm_wlock(_policy_rm);
 #endif
 }
@@ -262,6 +264,7 @@ mac_policy_xunlock(void)
return;
rm_wunlock(_policy_rm);
+   rms_wunlock(_policy_rms);
sx_xunlock(_policy_sx);
 #endif
 }
@@ -294,6 +297,7 @@ mac_init(void)
rm_init_flags(_policy_rm, "mac_policy_rm", RM_NOWITNESS |
RM_RECURSE);
sx_init_flags(_policy_sx, "mac_policy_sx", SX_NOWITNESS);
+   rms_init(_policy_rms, "mac_policy_rms");
 #endif
 }
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r356116 - head

[Ronald Klop]

Do powerpc people need to do something special while updating?
Like a clean buildkernel/buildworld. Or is this just a note for historical  
bookkeeping?


Regards,
Ronald.


On Fri, 27 Dec 2019 05:42:04 +0100, Justin Hibbits   
wrote:



Author: jhibbits
Date: Fri Dec 27 04:42:03 2019
New Revision: 356116
URL: https://svnweb.freebsd.org/changeset/base/356116

Log:
  Add a note to UPDATING on the move to clang for powerpc*

Modified:
  head/UPDATING

Modified: head/UPDATING
==
--- head/UPDATING   Fri Dec 27 04:11:14 2019(r356115)
+++ head/UPDATING   Fri Dec 27 04:42:03 2019(r356116)
@@ -27,6 +27,12 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW:
"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
20191226:
+   Clang/LLVM is now the default compiler for all powerpc architectures.
+   LLD is now the default linker for powerpc64.  The change for powerpc64
+   also includes a change to the ELFv2 ABI, incompatible with the existing
+   ABI.
+
+20191226:
Kernel-loadable random(4) modules are no longer unloadable.
20191222:
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r355978 - head/usr.bin/top

[Ronald Klop]

nice addition

On Sat, 21 Dec 2019 06:03:21 +0100, Philip Paeps   
wrote:



Author: philip
Date: Sat Dec 21 05:03:21 2019
New Revision: 355978
URL: https://svnweb.freebsd.org/changeset/base/355978

Log:
  top: display battery capacity remaining
 Submitted by: Antranig Vartanian 
  Reviewed by:  imp, philip
  Differential Revision:https://reviews.freebsd.org/D22871

Modified:
  head/usr.bin/top/display.c
  head/usr.bin/top/display.h
  head/usr.bin/top/machine.c
  head/usr.bin/top/machine.h
  head/usr.bin/top/top.c

Modified: head/usr.bin/top/display.c
==
--- head/usr.bin/top/display.c  Sat Dec 21 04:44:17 2019(r355977)
+++ head/usr.bin/top/display.c  Sat Dec 21 05:03:21 2019(r355978)
@@ -1322,6 +1322,15 @@ i_uptime(struct timeval *bt, time_t *tod)
 }
 }
+void
+i_battery(int nbat, int batt)
+{
+
+   if (nbat > 0) {
+   printf("; battery: %d%%", batt);
+   }
+}
+
 #define SETUPBUFFER_MIN_SCREENWIDTH 80
 #define SETUPBUFFER_REQUIRED_ADDBUFSIZ 2

Modified: head/usr.bin/top/display.h
==
--- head/usr.bin/top/display.h  Sat Dec 21 04:44:17 2019(r355977)
+++ head/usr.bin/top/display.h  Sat Dec 21 05:03:21 2019(r355978)
@@ -14,6 +14,7 @@ void   i_header(const char *text);
 voiddisplay_header(int t);
 int display_init(struct statics *statics);
 voidi_arc(int *stats);
+voidi_battery(int nbat, int batt);
 voidi_carc(int *stats);
 voidi_cpustates(int *states);
 voidi_loadave(int mpid, double *avenrun);

Modified: head/usr.bin/top/machine.c
==
--- head/usr.bin/top/machine.c  Sat Dec 21 04:44:17 2019(r355977)
+++ head/usr.bin/top/machine.c  Sat Dec 21 05:03:21 2019(r355978)
@@ -211,6 +211,10 @@ static long *pcpu_cp_old;
 static long *pcpu_cp_diff;
 static int *pcpu_cpu_states;
+/* Battery units and states */
+static int battery_units;
+static int battery_life;
+
 static int compare_swap(const void *a, const void *b);
 static int compare_jid(const void *a, const void *b);
 static int compare_pid(const void *a, const void *b);
@@ -373,6 +377,12 @@ machine_init(struct statics *statics)
pcpu_cpu_states = calloc(ncpus * CPUSTATES, sizeof(int));
statics->ncpus = ncpus;
+   /* Allocate state of battery units reported via ACPI. */
+   battery_units = 0;
+   size = sizeof(int);
+   sysctlbyname("hw.acpi.battery.units", _units, , NULL, 0);
+   statics->nbatteries = battery_units;
+
update_layout();
/* all done! */
@@ -579,6 +589,12 @@ get_system_info(struct system_info *si)
} else {
si->boottime.tv_sec = -1;
}
+
+   battery_life = 0;
+   if (battery_units > 0) {
+   GETSYSCTL("hw.acpi.battery.life", battery_life);
+   }
+   si->battery = battery_life;
 }
#define NOPROC  ((void *)-1)

Modified: head/usr.bin/top/machine.h
==
--- head/usr.bin/top/machine.h  Sat Dec 21 04:44:17 2019(r355977)
+++ head/usr.bin/top/machine.h  Sat Dec 21 05:03:21 2019(r355978)
@@ -30,6 +30,7 @@ struct statics
 const char * const *carc_names;
 const char * const *swap_names;
 const char * const *order_names;
+int nbatteries;
 int ncpus;
 };
@@ -50,6 +51,7 @@ struct system_info
 int*carc;
 int*swap;
 struct timeval boottime;
+intbattery;
 intncpus;
 };

Modified: head/usr.bin/top/top.c
==
--- head/usr.bin/top/top.c  Sat Dec 21 04:44:17 2019(r355977)
+++ head/usr.bin/top/top.c  Sat Dec 21 05:03:21 2019(r355978)
@@ -619,6 +619,9 @@ restart:
(*d_loadave)(system_info.last_pid,
 system_info.load_avg);
+   /* display the battery info (if any) */
+   i_battery(statics.nbatteries, system_info.battery);
+
/* display the current time */
/* this method of getting the time SHOULD be fairly portable */
time(_time);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r354803 - in stable: 11/contrib/llvm/lib/Transforms/InstCombine 12/contrib/llvm/lib/Transforms/InstCombine

[Ronald Klop]

On Thu, 21 Nov 2019 20:07:46 +0100, Dimitry Andric  wrote:


On 21 Nov 2019, at 16:06, Ronald Klop  wrote:


On Mon, 18 Nov 2019 08:04:59 +0100, Dimitry Andric   
wrote:

Author: dim
Date: Mon Nov 18 07:04:59 2019
New Revision: 354803
URL: https://svnweb.freebsd.org/changeset/base/354803

Log:
 MFC r354724:
Merge commit 5bbb604bb from llvm git (by Craig Topper):
  [InstCombine] Disable some portions of foldGEPICmp for GEPs that
   return a vector of pointers. Fix other portions.
  llvm-svn: 370114
This should fix instances of 'Assertion failed: (isa(Val) &&
 "cast() argument of incompatible type!"), function cast, file
 /usr/src/contrib/llvm/include/llvm/Support/Casting.h, line 255', when
 building openjdk8 for aarch64 and armv7.
Reported by:jbeich
 PR:236566




Are there plans for an errata notice for releng-12.1 with this fix?  
That would keep Openjdk8 as a pkg on aarch64 after 12.0 goes EOL and  
pkgs will be build on 12.1.


There should be no need for this, as release versions (and stable
branches) have their copies of clang compiled with assertions disabled.

Hence, the assertion reported in PR 236566 cannot occur, unless you have
explicitly turned them on again and recompiled the toolchain components.

I have tried compiling the original test case from the PR on both
12.0-RELEASE and 12.1-RELEASE.

On 12.0-RELEASE, which has clang version 6.0.1 (tags/RELEASE_601/final
335540), it complains that the -fno-delete-null-pointer-checks and
-faddrsig options are unknown, but this is to be expected.  The former
was important to get the original assertion.  If I remove both those
options, the test case compiles just fine.

On 12.1-RELEASE, which has clang version 8.0.1 (tags/RELEASE_801/final
366581), the test case compiles just fine, out of the box.

-Dimitry



Dimitry,

Thank you for testing and your quick answer.

Regards,
Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r354803 - in stable: 11/contrib/llvm/lib/Transforms/InstCombine 12/contrib/llvm/lib/Transforms/InstCombine

[Ronald Klop]

On Mon, 18 Nov 2019 08:04:59 +0100, Dimitry Andric  wrote:


Author: dim
Date: Mon Nov 18 07:04:59 2019
New Revision: 354803
URL: https://svnweb.freebsd.org/changeset/base/354803

Log:
  MFC r354724:
 Merge commit 5bbb604bb from llvm git (by Craig Topper):
   [InstCombine] Disable some portions of foldGEPICmp for GEPs that
return a vector of pointers. Fix other portions.
   llvm-svn: 370114
 This should fix instances of 'Assertion failed: (isa(Val) &&
  "cast() argument of incompatible type!"), function cast, file
  /usr/src/contrib/llvm/include/llvm/Support/Casting.h, line 255', when
  building openjdk8 for aarch64 and armv7.
 Reported by:   jbeich
  PR:   236566




Are there plans for an errata notice for releng-12.1 with this fix? That  
would keep Openjdk8 as a pkg on aarch64 after 12.0 goes EOL and pkgs will  
be build on 12.1.


If no plans exist how do I request this formally?

Regards,
Ronald.



Modified:
  stable/11/contrib/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
Directory Properties:
  stable/11/   (props changed)

Changes in other areas also in this revision:
Modified:
  stable/12/contrib/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
Directory Properties:
  stable/12/   (props changed)

Modified:  
stable/11/contrib/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

==
---  
stable/11/contrib/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp	Mon  
Nov 18 04:22:04 2019	(r354802)
+++  
stable/11/contrib/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp	Mon  
Nov 18 07:04:59 2019	(r354803)
@@ -830,6 +830,10 @@ getAsConstantIndexedAddress(Value *V, const  
DataLayout
 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS,  
Value *RHS,

   ICmpInst::Predicate Cond,
   const DataLayout ) {
+  // FIXME: Support vector of pointers.
+  if (GEPLHS->getType()->isVectorTy())
+return nullptr;
+
   if (!GEPLHS->hasAllConstantIndices())
 return nullptr;
@@ -880,7 +884,9 @@ Instruction *InstCombiner::foldGEPICmp(GEPOperator  
*GE

 RHS = RHS->stripPointerCasts();
  Value *PtrBase = GEPLHS->getOperand(0);
-  if (PtrBase == RHS && GEPLHS->isInBounds()) {
+  // FIXME: Support vector pointer GEPs.
+  if (PtrBase == RHS && GEPLHS->isInBounds() &&
+  !GEPLHS->getType()->isVectorTy()) {
 // ((gep Ptr, OFFSET) cmp Ptr)   ---> (OFFSET cmp 0).
 // This transformation (ignoring the base and scales) is valid  
because we
 // know pointers can't overflow since the gep is inbounds.  See if  
we can
@@ -914,11 +920,13 @@ Instruction *InstCombiner::foldGEPICmp(GEPOperator  
*GE
   // If we're comparing GEPs with two base pointers that only  
differ in type
   // and both GEPs have only constant indices or just one use, then  
fold

   // the compare with the adjusted indices.
+  // FIXME: Support vector of pointers.
   if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
   (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
   (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
   PtrBase->stripPointerCasts() ==
-  GEPRHS->getOperand(0)->stripPointerCasts()) {
+  GEPRHS->getOperand(0)->stripPointerCasts() &&
+  !GEPLHS->getType()->isVectorTy()) {
 Value *LOffset = EmitGEPOffset(GEPLHS);
 Value *ROffset = EmitGEPOffset(GEPRHS);
@@ -962,15 +970,20 @@ Instruction *InstCombiner::foldGEPICmp(GEPOperator  
*GE

   unsigned DiffOperand = 0; // The operand that differs.
   for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
-  if  
(GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
-
GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {

+  Type *LHSType = GEPLHS->getOperand(i)->getType();
+  Type *RHSType = GEPRHS->getOperand(i)->getType();
+  // FIXME: Better support for vector of pointers.
+  if (LHSType->getPrimitiveSizeInBits() !=
+   RHSType->getPrimitiveSizeInBits() ||
+  (GEPLHS->getType()->isVectorTy() &&
+   (!LHSType->isVectorTy() || !RHSType->isVectorTy( {
 // Irreconcilable differences.
 NumDifferences = 2;
 break;
-  } else {
-if (NumDifferences++) break;
-DiffOperand = i;
   }
+
+  if (NumDifferences++) break;
+  DiffOperand = i;
 }
  if (NumDifferences == 0)   // SAME GEP?
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___

Re: svn commit: r345159 - head

[Ronald Klop]

Thanks! A very welcome user friendlyness.


On Thu, 14 Mar 2019 23:08:10 +0100, Emmanuel Vadot   
wrote:



Author: manu
Date: Thu Mar 14 22:08:09 2019
New Revision: 345159
URL: https://svnweb.freebsd.org/changeset/base/345159

Log:
  pkgbase: Use uname as ABI_FILE
 uname is always rebuild on FreeBSD so use this as ABI_FILE for pkg when
  building pkg for pkgbase.
  pkg uses uname too as default ABI_FILE as of commit  
d8bbf980b7f6f424fb7cc672c23ab2dfc82b6599

  https://github.com/freebsd/pkg/commit/d8bbf980b7f6f424fb7cc672c23ab2dfc82b6599
 Discussed with:bapt
  MFC after:1 week

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==
--- head/Makefile.inc1  Thu Mar 14 21:08:48 2019(r345158)
+++ head/Makefile.inc1  Thu Mar 14 22:08:09 2019(r345159)
@@ -1864,11 +1864,11 @@ create-world-package-${pkgname}: .PHONY
@if [ "${pkgname}" == "runtime" ]; then \
 		sed -i '' -e "s/%VCS_REVISION%/${VCS_REVISION}/"  
${WSTAGEDIR}/${pkgname}.ucl ; \

fi
-   ${PKG_CMD} -o ABI_FILE=${WSTAGEDIR}/bin/sh -o ALLOW_BASE_SHLIBS=yes \
+	${PKG_CMD} -o ABI_FILE=${WSTAGEDIR}/usr/bin/uname -o  
ALLOW_BASE_SHLIBS=yes \

create -M ${WSTAGEDIR}/${pkgname}.ucl \
-p ${WSTAGEDIR}/${pkgname}.plist \
-r ${WSTAGEDIR} \
-		-o ${REPODIR}/$$(${PKG_CMD} -o ABI_FILE=${WSTAGEDIR}/bin/sh config  
ABI)/${PKG_VERSION}
+		-o ${REPODIR}/$$(${PKG_CMD} -o ABI_FILE=${WSTAGEDIR}/usr/bin/uname  
config ABI)/${PKG_VERSION}

 .endfor
_default_flavor=-default
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r336562 - head

[Ronald Klop]

On Fri, 20 Jul 2018 20:02:53 +0200, Ian Lepore  wrote:


Author: ian
Date: Fri Jul 20 18:02:52 2018
New Revision: 336562
URL: https://svnweb.freebsd.org/changeset/base/336562

Log:
  Add a note about the new 'ntpd' userid, and the fact that rc.d/ntpd now
  automatically runs the daemon as that user if it can.



Like the work you do hardening the system out-of-the-box.

Regards,
Ronald.





Modified:
  head/UPDATING

Modified: head/UPDATING
==
--- head/UPDATING   Fri Jul 20 17:46:55 2018(r336561)
+++ head/UPDATING   Fri Jul 20 18:02:52 2018(r336562)
@@ -38,6 +38,17 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW:
in place from zfsloader to loader to allow a smooth transition
until the boot blocks can be updated.
+20180719:
+   New uid:gid added, ntpd:ntpd (123:123).  Be sure to run mergemaster
+   or take steps to update /etc/passwd before doing installworld on
+   existing systems.  Also, rc.d/ntpd now starts ntpd(8) as user ntpd
+   if the new mac_ntpd(4) policy is available, unless ntpd_flags or
+   the ntp config file contain options that change file/dir locations.
+   When such options (e.g., "statsdir" or "crypto") are used, ntpd can
+   still be run as non-root by setting ntpd_user=ntpd in rc.conf, after
+   taking steps to ensure that all required files/dirs are accessible
+   by the ntpd user.
+
 20180717:
Big endian arm support has been removed.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334474 - head/usr.bin/top

[Ronald Klop]

On Sun, 03 Jun 2018 19:19:47 +0200, Florian Smeets via svn-src-all  
 wrote:



On 01.06.18 07:51, Eitan Adler wrote:

Author: eadler
Date: Fri Jun  1 05:51:40 2018
New Revision: 334474
URL: https://svnweb.freebsd.org/changeset/base/334474

Log:
  top(1): Display of TID when using 'H' flag

  Some users prefer seeing the TID when viewing individual threads. This
  makes sense as the PID will be the same for multiple entries. An  
attempt
  was made to include both, but there is insufficient room. As such,  
using

  the TID.

  While here, rename the header variables to be more understandable.

  Discussed with:   mmacy
  Reported on:  2009-10-07



Hi,

I think this is a mistake. The 'H' flag should keep the PID, AFAIK you
cannot use the TID anywhere in top in contrast to the PID. I usually
start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a
process in that view, as I don't see the PID. IMHO showing TIDs should
be a separate flag, 'h' maybe, as this commit changes current/expected
behavior (POLA?).

Also, this is not documented in the man page.

Florian



+1 for Florian

I also like the PIDs to see which threads belong to the same process.

Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333713 - in head/sys: dev/usb/net modules/usb/muge

[Ronald Klop]

The addition of this driver made me finally buy a RPI3B+.

Thanks a lot!

Regards,
Ronald.


On Thu, 17 May 2018 16:05:00 +0200, Ed Maste  wrote:


Author: emaste
Date: Thu May 17 14:04:59 2018
New Revision: 333713
URL: https://svnweb.freebsd.org/changeset/base/333713

Log:
  Add driver for Microchip LAN78xx USB3-GigE controller
 This driver supports two Microchip USB-Ethernet controllers:
 LAN7800 USB 3.1 to 10/100/1000 Mbps Ethernet
  LAN7515 USB 2 to 10/100/1000 Mbps Ethernet with built-in USB hub
 The LAN7515 is the Ethernet controller on the Raspberry Pi 3B+.
  At present there is no datasheet for the LAN7515, but it is effectively
  a USB 2 hub combined with a LAN7800 controller.  A comprehensive  
LAN7800

  datasheet is at http://www.microchip.com/wwwproducts/en/LAN7800.
 This driver is based on the structure of the smsc(4) driver which
  supports Microchip/SMSC's LAN95xx family.  (Microchip acquired SMSC
  in May 2012.)  The Linux lan78xx driver served as a reference for some
  functionality and registers.
 The 'muge' driver name comes from "Microchip USB Gigabit Ethernet".
  I made some style adjustments and minor edits to Arshan's submission.
  It will be connected to the build after additional review and testing.
 Thanks to Microchip for providing a number of Evaluation Boards (EVBs)
  for development and testing.
 Submitted by:  Arshan Khanifar
  Reviewed by:  hselasky (earlier)
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D15168

Added:
  head/sys/dev/usb/net/if_muge.c   (contents, props changed)
  head/sys/dev/usb/net/if_mugereg.h   (contents, props changed)
  head/sys/modules/usb/muge/
  head/sys/modules/usb/muge/Makefile   (contents, props changed)

Added: head/sys/dev/usb/net/if_muge.c
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/sys/dev/usb/net/if_muge.c  Thu May 17 14:04:59 2018
(r333713)
@@ -0,0 +1,2199 @@
+/*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
+ * Copyright (C) 2012 Ben Gray .
+ * Copyright (C) 2018 The FreeBSD Foundation.
+ *
+ * This software was developed by Arshan Khanifar  


+ * under sponsorship from the FreeBSD Foundation.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in  
the
+ *documentation and/or other materials provided with the  
distribution.

+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS''  
AND

+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR  
PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE  
LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR  
CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE  
GOODS

+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,  
STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN  
ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY  
OF

+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include 
+__FBSDID("$FreeBSD$");
+
+/*
+ * USB-To-Ethernet adapter driver for Microchip's LAN78XX and related  
families.

+ *
+ * USB 3.1 to 10/100/1000 Mbps Ethernet
+ * LAN7800 http://www.microchip.com/wwwproducts/en/LAN7800
+ *
+ * USB 2 to 10/100/1000 Mbps Ethernet with built-in USB hub
+ * LAN7515 (no datasheet available, but probes and functions as LAN7800)
+ *
+ * This driver is based on the if_smsc driver, with lan78xx-specific
+ * functionality modelled on Microchip's Linux lan78xx driver.
+ *
+ * UNIMPLEMENTED FEATURES
+ * --
+ * A number of features supported by the lan78xx are not yet  
implemented in

+ * this driver:
+ *
+ * 1. RX/TX checksum offloading: Nothing has been implemented yet for
+ *TX checksumming. RX checksumming works with ICMP messages, but is  
broken

+ *for TCP/UDP packets.
+ * 2. Direct address translation filtering: Implemented but untested.
+ * 3. VLAN tag removal.
+ * 4. Reading MAC address from the device tree: Specific to the RPi 3B+.
+ *Currently, the driver assigns a random MAC address itself.
+ * 5. Support for USB interrupt endpoints.
+ * 6. Latency Tolerance Messaging (LTM) support.
+ * 7. TCP LSO support.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 

Re: svn commit: r333351 - head/usr.bin/grep

[Ronald Klop]

On Tue, 08 May 2018 16:49:12 +0200, Alexey Dokuchaev   
wrote:



On Tue, May 08, 2018 at 09:36:21AM -0500, Kyle Evans wrote:
On Tue, May 8, 2018 at 5:58 AM, Alexey Dokuchaev   
wrote:

>>
>> - if ((f = fopen(fn, "r")) == NULL)
>> + if (strcmp(fn, "-") == 0)
>> + f = stdin;
>
> This makes sense: when `fn' is "-", `f' is stdin.
>
>> - fclose(f);
>> + if (strcmp(fn, "-") != 0)
>> + fclose(f);
>
> But not this one: why are you checking `fn' again?  Shouldn't you
> fclose(f) if it's not stdin?
>
> if (f != stdin)
> fclose(f);
>

You say potato, I say potato. =) In this case, it's low overhead in a
not particularly performance critical bit and drawing a connection
between this and the opening of 'f' above in an extremely obvious way.


Well, I'm not worried about the overhead or performance issues, they are
negligible.  I just find second strcmp(fn, "-") to be semantically wrong
(and that's why you need implicit "there's only one way to get stdin  
here"

assert).  You assign `f' to stdin based on `fn' being "-", but you
fclose(f) when it's not stdin; the value of `fn' is irrelevant this time.
As a nice bonus, you only spell strcmp(fn, "-") once and do not need to
implicitly assert that there's only one way to get stdin here.


This also might get ripped out soon -- we'll see how things go.


I see, understood.

./danfe


What is the result of "-f /dev/stdin"? Of does that fopen return a  
different filedesc?


Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r330277 - in head: bin/stty libexec/getty

[Ronald Klop]

On Fri, 02 Mar 2018 15:16:19 +0100, Edward Tomasz Napierala  
 wrote:



Author: trasz
Date: Fri Mar  2 14:16:19 2018
New Revision: 330277
URL: https://svnweb.freebsd.org/changeset/base/330277

Log:
  .Xr pstat(8), so that people have a chance to learn how to get a list
  of terminal devices using "pstat -t".



Nice tip. Never seen pstat -t before. I have a feeling it will be useful  
to me some day. :-)

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r330236 - head/sys/compat/linuxkpi/common/src

[Ronald Klop]

On Sun, 04 Mar 2018 02:25:17 +0100, Colin Percival   
wrote:



On 03/01/18 02:31, Hans Petter Selasky wrote:

New Revision: 330236
  Correct the return value from flush_work() and flush_delayed_work()  
in the
  LinuxKPI to comply more with Linux. This fixes an issue when these  
functions

  are used in waiting loops.

  MFC after:1 week
  Sponsored by: Mellanox Technologies


In case the data point is useful: Merging this to stable/11 unbroke S3
suspend/resume on my laptop (system76 Galago Pro, kabylake, using the
drm-next-kmod port).




These data points are much more useful than commit messages that describe  
what the patch already shows and talk about 'an issue'. Every patch solves  
'an issue' (or creates some :-) ).


No personal pun intended. Just taking this example as general thoughts  
about commit messages.


Regards,
Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r326036 - head/sys/cam/scsi

[Ronald Klop]

Out of curiosity, What is the use case which this improves? Does happen in  
daily usage or mostly in testing?


Regards,
Ronald.


On Mon, 20 Nov 2017 23:27:34 +0100, Alan Somers   
wrote:



Author: asomers
Date: Mon Nov 20 22:27:33 2017
New Revision: 326036
URL: https://svnweb.freebsd.org/changeset/base/326036

Log:
  da(4): Short-circuit unnecessary BIO_FLUSH commands
 sys/cam/scsi/scsi_da.c
Complete BIO_FLUSH commands immediately if the da(4) device hasn't
been written to since the last flush. If we haven't written to the
device, there is no reason to send a flush.
 Submitted by:  gibbs
  Reviewed by:  imp
  MFC after:3 weeks
  Sponsored by: Spectra Logic Corp
  Differential Revision:https://reviews.freebsd.org/D13106

Modified:
  head/sys/cam/scsi/scsi_da.c

Modified: head/sys/cam/scsi/scsi_da.c
==
--- head/sys/cam/scsi/scsi_da.c Mon Nov 20 22:18:24 2017(r326035)
+++ head/sys/cam/scsi/scsi_da.c Mon Nov 20 22:27:33 2017(r326036)
@@ -3038,6 +3038,18 @@ more:
}
case BIO_FLUSH:
/*
+* If we don't support sync cache, or the disk
+* isn't dirty, FLUSH is a no-op.  Use the
+* allocated * CCB for the next bio if one is
+* available.
+*/
+   if ((softc->quirks & DA_Q_NO_SYNC_CACHE) != 0 ||
+   (softc->flags & DA_FLAG_DIRTY) == 0) {
+   biodone(bp);
+   goto skipstate;
+   }
+
+   /*
 * BIO_FLUSH doesn't currently communicate
 * range data, so we synchronize the cache
 * over the whole disk.  We also force
@@ -3052,6 +3064,15 @@ more:
   /*lb_count*/0,
   SSD_FULL_SIZE,
   da_default_timeout*1000);
+   /*
+* Clear the dirty flag before sending the command.
+* Either this sync cache will be successful, or it
+* will fail after a retry.  If it fails, it is
+* unlikely to be successful if retried later, so
+* we'll save ourselves time by just marking the
+* device clean.
+*/
+   softc->flags &= ~DA_FLAG_DIRTY;
break;
case BIO_ZONE: {
int error, queue_ccb;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325785 - in head: sys/kern tools/tools/sysdoc

[Ronald Klop]

Just out of curiosity. What happens if you enable both?

Regards,
Ronald.


On Tue, 14 Nov 2017 01:29:14 +0100, Warner Losh  wrote:


Author: imp
Date: Tue Nov 14 00:29:14 2017
New Revision: 325785
URL: https://svnweb.freebsd.org/changeset/base/325785

Log:
  Add two new tunables / sysctls to controll reboot after panic:
 kern.poweroff_on_panic which, when enabled, instructs a system to
  power off on a panic instead of a reboot.
 kern.powercyle_on_panic which, when enabled, instructs a system to
  power cycle, if possible, on a panic instead of a reboot.
 Sponsored by: Netflix
  Differential Revision: https://reviews.freebsd.org/D13042

Modified:
  head/sys/kern/kern_shutdown.c
  head/tools/tools/sysdoc/tunables.mdoc

Modified: head/sys/kern/kern_shutdown.c
==
--- head/sys/kern/kern_shutdown.c   Mon Nov 13 23:33:07 2017
(r325784)
+++ head/sys/kern/kern_shutdown.c   Tue Nov 14 00:29:14 2017
(r325785)
@@ -134,6 +134,14 @@ static int sync_on_panic = 0;
 SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RWTUN,
_on_panic, 0, "Do a sync before rebooting from a panic");
+static bool poweroff_on_panic = 0;
+SYSCTL_BOOL(_kern, OID_AUTO, poweroff_on_panic, CTLFLAG_RWTUN,
+	_on_panic, 0, "Do a power off instead of a reboot on a  
panic");

+
+static bool powercycle_on_panic = 0;
+SYSCTL_BOOL(_kern, OID_AUTO, powercycle_on_panic, CTLFLAG_RWTUN,
+	_on_panic, 0, "Do a power cycle instead of a reboot on a  
panic");

+
 static SYSCTL_NODE(_kern, OID_AUTO, shutdown, CTLFLAG_RW, 0,
 "Shutdown environment");
@@ -797,6 +805,10 @@ vpanic(const char *fmt, va_list ap)
/* thread_unlock(td); */
if (!sync_on_panic)
bootopt |= RB_NOSYNC;
+   if (poweroff_on_panic)
+   bootopt |= RB_POWEROFF;
+   if (powercycle_on_panic)
+   bootopt |= RB_POWERCYCLE;
kern_reboot(bootopt);
 }

Modified: head/tools/tools/sysdoc/tunables.mdoc
==
--- head/tools/tools/sysdoc/tunables.mdoc	Mon Nov 13 23:33:07  
2017	(r325784)
+++ head/tools/tools/sysdoc/tunables.mdoc	Tue Nov 14 00:29:14  
2017	(r325785)

@@ -1035,6 +1035,20 @@ is attempting to comply with.
 This is a read-only variable.
---
+kern.powercycle_on_panic
+bool
+
+In the event of a panic, this variable controls whether or not the
+system should try to power cycle instead of rebooting.
+
+---
+kern.poweroff_on_panic
+bool
+
+In the event of a panic, this variable controls whether or not the
+system should try to power off instead of rebooting.
+
+---
 kern.proc.all
---
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r319897 - head/usr.bin/yes

[Ronald Klop]

On Wed, 14 Jun 2017 16:27:52 +0200, Bryan Drewery   
wrote:



On 6/14/2017 7:26 AM, Justin Hibbits wrote:
On Wed, Jun 14, 2017 at 9:19 AM, Bryan Drewery   
wrote:

On 6/13/2017 5:35 AM, Pietro Cerutti wrote:

Author: gahr (ports committer)
Date: Tue Jun 13 12:35:01 2017
New Revision: 319897
URL: https://svnweb.freebsd.org/changeset/base/319897

Log:
  Improve yes' throughput

  On my system, this brings up the throughput from ~20 to ~600 MiB/s.

  Inspired by:  
https://www.reddit.com/r/unix/comments/6gxduc/how_is_gnu_yes_so_fast/


  Reviewed by:cognet
  Approved by:cognet

Modified:
  head/usr.bin/yes/yes.c



While here we should add libxo support.

--
Regards,
Bryan Drewery



I think before we add libxo, we need to capsicumize it.  After all, it
does accept arbitrary arguments.


The code has become more complex.  I think capsicum does make sense now
in case there is an unseen overflow in the new optimized code.




It already has capsicum...
https://svnweb.freebsd.org/base?view=revision=308432

:-)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libm

[Ronald Klop]

On Tue, 23 May 2017 16:00:46 +0200, Ed Maste  wrote:


On 23 May 2017 at 05:29, Konstantin Belousov  wrote:

Author: kib
Date: Tue May 23 09:29:05 2017
New Revision: 318736
URL: https://svnweb.freebsd.org/changeset/base/318736

  Update note: strictly follow the instructions in UPDATING.  Build
  and install the new kernel with COMPAT_FREEBSD11 option enabled,
  then reboot, and only then install new world.


There's been some confusion over this point, so let me clarify: this
note refers to the regular upgrade procedure documented in UPDATING
under the heading "To rebuild everything and install it on the current
system". Following the regular, documented procedure is both necessary
and sufficient for the ino64 change.

It's mentioned explicitly here because folks often take shortcuts with
updating (e.g. not rebooting), and such a shortcut will fail with the
ino64 change.



I read this in the commit log and my first thought was that it would help  
a lot of people if there was an extra entry in UPDATING mentioning the  
explicit need of the 'installkernel, reboot, installworld' order of the  
official procedure.


A lot of people do not read the commits, but do follow UPDATING.

BTW: The content of the commit is great work and I'm sure it will benefit  
future of FreeBSD!


Cheers,
Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r313343 - head/sys/arm/arm

[Ronald Klop]

With this change merged to 11-CURRENT my SHEEVAPLUG/arm displays different  
information in dmesg:


messages:Apr 15 00:53:07 sheeva2 kernel: Little-endian DC enabled IC  
enabled WA disabled DC streaming enabled
messages:Apr 15 00:53:07 sheeva2 kernel: WB enabled LABT branch prediction  
enabled
messages.0.bz2:Apr 11 20:02:06 sheeva2 kernel: Little-endian DC enabled IC  
disabled WA disabled DC streaming enabled
messages.0.bz2:Apr 11 20:02:06 sheeva2 kernel: WB enabled LABT branch  
prediction disabled


IC changed from disabled to enabled and LABT branch prediction is  
displayed as enabled also.


Is this only cosmetically? Or does it really change behaviour?

Anybody willing to MFC this 11?

Regards,
Ronald.


On Mon, 06 Feb 2017 15:58:24 +0100, Stanislav Galabov  
 wrote:



Author: sgalabov
Date: Mon Feb  6 14:58:24 2017
New Revision: 313343
URL: https://svnweb.freebsd.org/changeset/base/313343

Log:
  sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu()
 identify_arm_cpu() in sys/arm/arm/identcpu-v4.c incorrectly uses a
  u_int8_t variable to store the result of cpu_get_control().
  It should really use a u_int variable, the same way as done for  
cpu_ident()

  in the same function, as both cpuid and control registers are 32-bit..
  This issue causes users of identcpu-v4 to incorrectly report things  
such as

  icache status (bit 12 in cpu control register) and basically anything
  defined in bits above bit 7 :-)
 Reviewed by:   manu
  Sponsored by: Smartcom - Bulgaria AD
  Differential Revision:https://reviews.freebsd.org/D9460

Modified:
  head/sys/arm/arm/identcpu-v4.c

Modified: head/sys/arm/arm/identcpu-v4.c
==
--- head/sys/arm/arm/identcpu-v4.c  Mon Feb  6 14:41:34 2017
(r313342)
+++ head/sys/arm/arm/identcpu-v4.c  Mon Feb  6 14:58:24 2017
(r313343)
@@ -294,8 +294,7 @@ u_int cpu_pfr(int num)
 void
 identify_arm_cpu(void)
 {
-   u_int cpuid;
-   u_int8_t ctrl;
+   u_int cpuid, ctrl;
int i;
ctrl = cpu_get_control();
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r316938 - head/sbin/savecore

[Ronald Klop]

On Fri, 14 Apr 2017 22:29:18 +0200, Mark Johnston   
wrote:



On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote:

On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper  wrote:
> Author: ngie
> Date: Fri Apr 14 19:41:48 2017
> New Revision: 316938
> URL: https://svnweb.freebsd.org/changeset/base/316938
>
> Log:
>   savecore: fix space calculation with respect to `minfree` in  
check_space(..)

>
>   - Use strtoll(3) instead of atoi(3), because atoi(3) limits the
> representable data to INT_MAX. Check the values received from
> strtoll(3), trimming trailing whitespace off the end to maintain
> POLA.
>   - Use `KiB` instead of `kB` when describing free space, total space,
> etc. I am now fully aware of `KiB` being the IEC standard for 1024
> bytes and `kB` being the IEC standard for 1000 bytes.
>   - Store available number of KiB in `available` so it can be more
> easily queried and compared to ensure that there are enough KiB to
> store the dump image on disk.
>   - Print out the reserved space on disk, per `minfree`, so end-users
> can troubleshoot why check_space(..) is reporting that there isn't
> enough free space.
>
>   MFC after:7 weeks
>   Reviewed by:  Anton Rang  (earlier diff), cem  
(earlier diff)

>   Tested with:  positive/negative cases (see review); make tinderbox
>   Sponsored by: Dell EMC Isilon
>   Differential Revision:D10379

The free space calculation is still uselessly conservative, because it
doesn't account for the fact that core dumps will always be either
spare or compressed.  The result is that savecore will frequently
refuse to save corefiles even when there's plenty of space.  I
proposed removing the space check altogether in
https://reviews.freebsd.org/D2587.  However, I agreed to wait until
after the compressed core dump feature was merged, because then mostly
accurate space checks will be possible.  AFAIK the compressed core
dump feature still hasn't been finished.


I had held off on it for a while because it was going to conflict with
the work to add encrypted dump support, which of course has finished.

The patch to add compression support is here and should largely still
work:
https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff

I've been hesitant about pushing it forward:
- The dump_write* APIs need some simplification after the addition of
  encrypted dump support and support for dumping to 4Kn drives.
- I'm not sure how encryption should compose with compression. It seems
  intuitively obvious that we should compress before encrypting if the
  compression is to be of any use, but I don't know enough to know
  whether the compression might somehow compromise the effectiveness of
  the encryption.

If anyone has some insight on the second of these two points, I'd
appreciate hearing it.


About compression before encryption there is some information. For  
example: https://en.wikipedia.org/wiki/CRIME
Openssh removed compression in pre-authentication in  
http://www.openssh.com/txt/release-7.4


Regards,
Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt

[Ronald Klop]

On Tue, 21 Mar 2017 10:19:24 +0100, Mathieu Arnold  wrote:


Le 21/03/2017 à 08:27, Gleb Smirnoff a écrit :

On Tue, Mar 21, 2017 at 08:22:19AM +0100, Baptiste Daroussin wrote:
B> On Mon, Mar 20, 2017 at 11:54:33PM -0700, Gleb Smirnoff wrote:
B> > On Tue, Mar 21, 2017 at 07:50:32AM +0100, Antoine Brodin wrote:
B> > A> >   This change is known to break a ton of ports. More than 100  
if
B> > A> > counting depends. I'm sorry for that and I already started to  
fix

B> > A> > them.
B> > A> >
B> > A> > Please send all new breakages to me.
B> > A>
B> > A> Hi,
B> > A>
B> > A> Exp-runs should happen before breakage happens, not after.
B> > A> If you already know that it breaks hundreds of ports, please  
revert

B> > A> and request an exp-run.
B> >
B> > The exp-run has already been made:
B> >
B> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210673
B> >
B> > Wasn't very helpful.
B> >
B>
B> I disagree it was useful it showed you some ports that were breaking  
given there
B> was some high level one you were expected to provide patches to fix  
them.


I'm working on them right now.


You should have worked on it *before* the patch breaking everything
landed, providing patches for the ports that were reported as broken,
and repeat until all the ports that were building before were building
again.

You should **not** have committed the patch to the src tree before all
those patches were created, and you should have committed all the
patches at once, preferably before committing the patch to the src tree.






People should...
No ports are broken on released version of FreeBSD. The broken ones are  
being fixed.
And a very good improvement of code has happened. Maybe a notice in  
UPDATING helps third-party people.

I don't see a real problem. Only progress.

Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315660 - stable/11/tools/build/mk

[Ronald Klop]

On Tue, 21 Mar 2017 06:13:15 +0100, Ngie Cooper  wrote:


Author: ngie
Date: Tue Mar 21 05:13:14 2017
New Revision: 315660
URL: https://svnweb.freebsd.org/changeset/base/315660

Log:
  MFC r314241,r315228:
 r314241:
 Fill in MK_RESCUE by finding paths in ${DESTDIR}/rescue and adding
  them to OLD_FILES/OLD_DIRS, as necessary.
 r315228:
 Redirect standard error from find /rescue to /dev/null
 This mutes noise from find when /rescue doesn't exist.


IMHO it is better to check the existence in an if before the find. My  
experience is that other errors will show up in the future which are then  
ignored by piping to /dev/null.


Ronald.




Modified:
  stable/11/tools/build/mk/OptionalObsoleteFiles.inc
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/tools/build/mk/OptionalObsoleteFiles.inc
==
--- stable/11/tools/build/mk/OptionalObsoleteFiles.inc	Tue Mar 21  
03:42:28 2017	(r315659)
+++ stable/11/tools/build/mk/OptionalObsoleteFiles.inc	Tue Mar 21  
05:13:14 2017	(r315660)

@@ -7131,9 +7131,14 @@ OLD_FILES+=usr/share/man/man1/rlog.1.gz
 OLD_FILES+=usr/share/man/man5/rcsfile.5.gz
 .endif
-#.if ${MK_RESCUE} == no
-# to be filled in or replaced with a special target
-#.endif
+.if ${MK_RESCUE} == no
+. if exists(${DESTDIR}${TESTSBASE})
+RESCUE_DIRS!=find ${DESTDIR}/rescue -type d 2>/dev/null | sed -e  
's,^${DESTDIR}/,,'; echo

+OLD_DIRS+=${RESCUE_DIRS}
+RESCUE_FILES!=find ${DESTDIR}/rescue \! -type d 2>/dev/null | sed -e  
's,^${DESTDIR}/,,'; echo

+OLD_FILES+=${RESCUE_FILES}
+. endif
+.endif
.if ${MK_ROUTED} == no
 OLD_FILES+=rescue/routed
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315141 - head/sys/mips/conf

[Ronald Klop]

Hi,

Your commit message shows in English what the diff already shows: the  
'what changed'. IMHO it would add more value to the commit message to  
describe the 'why it changed'. What are your ideas about that?


Regards,
Ronald.


On Sun, 12 Mar 2017 08:09:51 +0100, Emmanuel Vadot   
wrote:



Author: manu
Date: Sun Mar 12 07:09:50 2017
New Revision: 315141
URL: https://svnweb.freebsd.org/changeset/base/315141

Log:
  Use 'options EXT_RESOURCES' instead of 'device ext_resources' for FDT  
enabled

  MIPS kernel config.

Modified:
  head/sys/mips/conf/JZ4780
  head/sys/mips/conf/MT7620A_FDT
  head/sys/mips/conf/MT7620N_FDT
  head/sys/mips/conf/MT7621_FDT
  head/sys/mips/conf/MT7628_FDT
  head/sys/mips/conf/RT3050_FDT
  head/sys/mips/conf/RT3352_FDT
  head/sys/mips/conf/RT3883_FDT
  head/sys/mips/conf/RT5350_FDT
  head/sys/mips/conf/X1000

Modified: head/sys/mips/conf/JZ4780
==
--- head/sys/mips/conf/JZ4780   Sun Mar 12 06:20:28 2017(r315140)
+++ head/sys/mips/conf/JZ4780   Sun Mar 12 07:09:50 2017(r315141)
@@ -71,7 +71,7 @@ devicefdt_pinctrl
device  clk
 device regulator
-device ext_resources
+optionsEXT_RESOURCES
device  gpio

Modified: head/sys/mips/conf/MT7620A_FDT
==
--- head/sys/mips/conf/MT7620A_FDT  Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/MT7620A_FDT  Sun Mar 12 07:09:50 2017
(r315141)
@@ -73,5 +73,5 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk

Modified: head/sys/mips/conf/MT7620N_FDT
==
--- head/sys/mips/conf/MT7620N_FDT  Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/MT7620N_FDT  Sun Mar 12 07:09:50 2017
(r315141)
@@ -70,5 +70,5 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk

Modified: head/sys/mips/conf/MT7621_FDT
==
--- head/sys/mips/conf/MT7621_FDT   Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/MT7621_FDT   Sun Mar 12 07:09:50 2017
(r315141)
@@ -69,5 +69,5 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk

Modified: head/sys/mips/conf/MT7628_FDT
==
--- head/sys/mips/conf/MT7628_FDT   Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/MT7628_FDT   Sun Mar 12 07:09:50 2017
(r315141)
@@ -72,5 +72,5 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk

Modified: head/sys/mips/conf/RT3050_FDT
==
--- head/sys/mips/conf/RT3050_FDT   Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/RT3050_FDT   Sun Mar 12 07:09:50 2017
(r315141)
@@ -74,5 +74,5 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk

Modified: head/sys/mips/conf/RT3352_FDT
==
--- head/sys/mips/conf/RT3352_FDT   Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/RT3352_FDT   Sun Mar 12 07:09:50 2017
(r315141)
@@ -70,5 +70,5 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk

Modified: head/sys/mips/conf/RT3883_FDT
==
--- head/sys/mips/conf/RT3883_FDT   Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/RT3883_FDT   Sun Mar 12 07:09:50 2017
(r315141)
@@ -74,7 +74,7 @@ devicebpf
 device if_bridge
# Extres
-device ext_resources
+optionsEXT_RESOURCES
 device clk
# For now there's no etherswitch support for RT3662/RT3883

Modified: head/sys/mips/conf/RT5350_FDT
==
--- head/sys/mips/conf/RT5350_FDT   Sun Mar 12 06:20:28 2017
(r315140)
+++ head/sys/mips/conf/RT5350_FDT   Sun Mar 12 07:09:50 2017

Re: svn commit: r313343 - head/sys/arm/arm

[Ronald Klop]

Hello,

Is this applicable to 11-CURRENT also?

That version (sys/arm/arm/identcpu.c) has:
void
identify_arm_cpu(void)
{
u_int cpuid, reg, size, sets, ways;
u_int8_t type, linesize, ctrl;
int i;

Regards,
Ronald.


On Mon, 06 Feb 2017 15:58:24 +0100, Stanislav Galabov  
 wrote:



Author: sgalabov
Date: Mon Feb  6 14:58:24 2017
New Revision: 313343
URL: https://svnweb.freebsd.org/changeset/base/313343

Log:
  sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu()
 identify_arm_cpu() in sys/arm/arm/identcpu-v4.c incorrectly uses a
  u_int8_t variable to store the result of cpu_get_control().
  It should really use a u_int variable, the same way as done for  
cpu_ident()

  in the same function, as both cpuid and control registers are 32-bit..
  This issue causes users of identcpu-v4 to incorrectly report things  
such as

  icache status (bit 12 in cpu control register) and basically anything
  defined in bits above bit 7 :-)
 Reviewed by:   manu
  Sponsored by: Smartcom - Bulgaria AD
  Differential Revision:https://reviews.freebsd.org/D9460

Modified:
  head/sys/arm/arm/identcpu-v4.c

Modified: head/sys/arm/arm/identcpu-v4.c
==
--- head/sys/arm/arm/identcpu-v4.c  Mon Feb  6 14:41:34 2017
(r313342)
+++ head/sys/arm/arm/identcpu-v4.c  Mon Feb  6 14:58:24 2017
(r313343)
@@ -294,8 +294,7 @@ u_int cpu_pfr(int num)
 void
 identify_arm_cpu(void)
 {
-   u_int cpuid;
-   u_int8_t ctrl;
+   u_int cpuid, ctrl;
int i;
ctrl = cpu_get_control();
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r313169 - head/tools/build/options

[Ronald Klop]

On Fri, 03 Feb 2017 20:09:46 +0100, Warren Block   
wrote:



Modified: head/tools/build/options/WITHOUT_INSTALLLIB
==
--- head/tools/build/options/WITHOUT_INSTALLLIB	Fri Feb  3 17:02:57  
2017	(r313168)
+++ head/tools/build/options/WITHOUT_INSTALLLIB	Fri Feb  3 19:09:46  
2017	(r313169)

@@ -1,6 +1,6 @@
 .\" $FreeBSD$
-Set this if you do not want to install optional libraries.
-For example when creating a
+Set this if to not install optional libraries.
+For example, when creating a
 .Xr nanobsd 8
 image.
 .Bf -symbolic


I think this sentence did not become what you meant it to be.

Cheers,
Ronald.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r311993 - head/sys/dev/nand

[Ronald Klop]

Should this be merged to 11-stable also?
I got a build failure on this with 11/arm.

Ronald.


On Thu, 12 Jan 2017 19:05:12 +0100, Alexander Kabaev   
wrote:



Author: kan
Date: Thu Jan 12 18:05:12 2017
New Revision: 311993
URL: https://svnweb.freebsd.org/changeset/base/311993

Log:
  Fix typo in r311971.
 Reported by:   ohartmann at walstatt.org

Modified:
  head/sys/dev/nand/nand_geom.c

Modified: head/sys/dev/nand/nand_geom.c
==
--- head/sys/dev/nand/nand_geom.c   Thu Jan 12 17:54:55 2017
(r311992)
+++ head/sys/dev/nand/nand_geom.c   Thu Jan 12 18:05:12 2017
(r311993)
@@ -416,7 +416,7 @@ create_geom_disk(struct nand_chip *chip)
snprintf(rdisk->d_ident, sizeof(rdisk->d_ident),
"nand_raw: Man:0x%02x Dev:0x%02x", chip->id.man_id,
chip->id.dev_id);
-   disk->d_rotation_rate = DISK_RR_NON_ROTATING;
+   rdisk->d_rotation_rate = DISK_RR_NON_ROTATING;
disk_create(rdisk, DISK_VERSION);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r310124 - head/sys/boot/arm/uboot

[Ronald Klop]

Hello,

Is this 12-CURRENT only or also applicable to 11-STABLE?

Regards,
Ronald.


On Thu, 15 Dec 2016 18:36:55 +0100, Andrew Turner   
wrote:



Author: andrew
Date: Thu Dec 15 17:36:54 2016
New Revision: 310124
URL: https://svnweb.freebsd.org/changeset/base/310124

Log:
  Add -fPIC to the ubldr build. Without this the self relocation code  
will
  try to use an absolute address in a switch statement, jumping to an  
invalid

  memory location.
 Sponsored by:  ABT Systems Ltd

Modified:
  head/sys/boot/arm/uboot/Makefile

Modified: head/sys/boot/arm/uboot/Makefile
==
--- head/sys/boot/arm/uboot/MakefileThu Dec 15 17:34:18 2016
(r310123)
+++ head/sys/boot/arm/uboot/MakefileThu Dec 15 17:36:54 2016
(r310124)
@@ -109,6 +109,8 @@ CFLAGS+=-I${.OBJDIR}/../../uboot/lib
 # where to get libstand from
 CFLAGS+=   -I${.CURDIR}/../../../../lib/libstand/
+CFLAGS+=   -fPIC
+
 # clang doesn't understand %D as a specifier to printf
 NO_WERROR.clang=
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305968 - head/etc/autofs

[Ronald Klop]

Hi,

Your commit message says in words exactly what the diff says in code.  
Would you like to elaborate on why the change is made? I'm curious   
because this could cause severe damage to the filesystem on unclean eject  
of the media.


Regards,
Ronald.


On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala  
 wrote:



Author: trasz
Date: Mon Sep 19 08:51:27 2016
New Revision: 305968
URL: https://svnweb.freebsd.org/changeset/base/305968

Log:
  Make autofs use the "async" flag for msdosfs and ufs filesystems  
mounted

  on /media.
 MFC after: 1 month

Modified:
  head/etc/autofs/special_media

Modified: head/etc/autofs/special_media
==
--- head/etc/autofs/special_media   Mon Sep 19 07:47:56 2016
(r305967)
+++ head/etc/autofs/special_media   Mon Sep 19 08:51:27 2016
(r305968)
@@ -46,6 +46,8 @@ print_map_entry() {
 			"Cannot mount ${_fstype} formatted device /dev/${_p}: Install  
sysutils/fusefs-ntfs first"

exit 1
fi
+   elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then
+   echo "-fstype=${_fstype},nosuid,async  :/dev/${_p}"
else
echo "-fstype=${_fstype},nosuid:/dev/${_p}"
fi
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r303027 - in stable/11/release: . scripts

[Ronald Klop]

Hi, I made this PR for the issue.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211029

Ronald.



On Tue, 19 Jul 2016 18:22:50 +0200, Glen Barber  wrote:


Author: gjb
Date: Tue Jul 19 16:22:50 2016
New Revision: 303027
URL: https://svnweb.freebsd.org/changeset/base/303027

Log:
  Reduce the disc1.iso size from 850+M to just over 650M.
 As a result of this change, the 'kernel-dbg.txz' distribution
  is no longer provided on disc1.iso, and deselected by default
  in bsdinstall(8).  When 'kernel-dbg.txz' is selected, network
  configuration happens before the installer proceeds, to fetch
  the distribution from the mirrors.
 This is a direct commit to stable/11, as there is intention
  to solve this differently for 12.0-RELEASE.
 Reviewed by:   nwhitehorn (glanced at)
  Approved by:  re (hrs)
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/11/release/Makefile
  stable/11/release/scripts/make-manifest.sh

Modified: stable/11/release/Makefile
==
--- stable/11/release/Makefile  Tue Jul 19 16:02:07 2016(r303026)
+++ stable/11/release/Makefile  Tue Jul 19 16:22:50 2016(r303027)
@@ -172,11 +172,12 @@ disc1: packagesystem
mkdir -p ${.TARGET}
cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \
DESTDIR=${.OBJDIR}/${.TARGET} MK_RESCUE=no MK_KERNEL_SYMBOLS=no 
\
-   MK_PROFILE=no MK_SENDMAIL=no MK_TESTS=no MK_LIB32=no \
-   MK_DEBUG_FILES=no
+   MK_PROFILE=no MK_MAIL=no MK_TESTS=no MK_LIB32=no \
+   MK_DEBUG_FILES=no MK_LLDB=no \
+   MK_TOOLCHAIN=no
 # Copy distfiles
mkdir -p ${.TARGET}/usr/freebsd-dist
-   for dist in MANIFEST $$(ls *.txz | grep -vE -- '(base|lib32)-dbg'); \
+	for dist in MANIFEST $$(ls *.txz | grep -vE --  
'(base|lib32|kernel)-dbg'); \

do cp $${dist} ${.TARGET}/usr/freebsd-dist; \
done
 # Copy documentation, if generated

Modified: stable/11/release/scripts/make-manifest.sh
==
--- stable/11/release/scripts/make-manifest.sh	Tue Jul 19 16:02:07  
2016	(r303026)
+++ stable/11/release/scripts/make-manifest.sh	Tue Jul 19 16:22:50  
2016	(r303027)

@@ -36,7 +36,7 @@ default_tests=off
 default_base_dbg=off
 default_lib32_dbg=off
 default_kernel_alt=off
-default_kernel_dbg=on
+default_kernel_dbg=off
 default_kernel_alt_dbg=off
for i in ${*}; do
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r298011 - head/sys/cam/ata

[Ronald Klop]

Hello,

Out of curiosity, what are these big problems? Broken device or other  
things (timeouts/triggers/full queues) going on in the kernel?


Regards,
Ronald.


On Fri, 15 Apr 2016 00:13:46 +0200, Warner Losh  wrote:


Author: imp
Date: Thu Apr 14 22:13:46 2016
New Revision: 298011
URL: https://svnweb.freebsd.org/changeset/base/298011
erLog:
  Add a comment about why the timeout for flush was lowered to 5s.

Modified:
  head/sys/cam/ata/ata_da.c

Modified: head/sys/cam/ata/ata_da.c
==
--- head/sys/cam/ata/ata_da.c   Thu Apr 14 22:13:44 2016(r298010)
+++ head/sys/cam/ata/ata_da.c   Thu Apr 14 22:13:46 2016(r298011)
@@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off
if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) {
xpt_setup_ccb(_h, periph->path, CAM_PRIORITY_NORMAL);
+   /*
+* Tell the drive to flush its intenral cache. if we
+* can't flush in 5s we have big problems. No need to
+* wait the default 60s to detect problems.
+*/
ccb.ccb_h.ccb_state = ADA_CCB_DUMP;
cam_fill_ataio(,
0,
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r296109 - head/libexec/rlogind

[Ronald Klop]

Hi,

I'm not a FreeBSD commiter, but read these commits to stay informed about  
what is happening.
This commit (and the one for talk) mentions _what_ is changed, but not  
_why_ it is changed. I'm curious why this is better. Mind to share any  
comments on this?


Regards,
Ronald.


On Fri, 26 Feb 2016 21:02:02 +0100, Pedro F. Giffuni   
wrote:



Author: pfg
Date: Fri Feb 26 20:02:01 2016
New Revision: 296109
URL: https://svnweb.freebsd.org/changeset/base/296109

Log:
  rlogin(1): Replace select(2) with poll(2).
 Obtanied from: NetBSD (CVS Rev. 1.27 - 1.28)

Modified:
  head/libexec/rlogind/rlogind.c

Modified: head/libexec/rlogind/rlogind.c
==
--- head/libexec/rlogind/rlogind.c  Fri Feb 26 19:49:04 2016
(r296108)
+++ head/libexec/rlogind/rlogind.c  Fri Feb 26 20:02:01 2016
(r296109)
@@ -76,6 +76,7 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -350,34 +351,27 @@ protocol(int f, int p)
nfd = f + 1;
else
nfd = p + 1;
-   if (nfd > FD_SETSIZE) {
-   syslog(LOG_ERR, "select mask too small, increase FD_SETSIZE");
-   fatal(f, "internal error (select mask too small)", 0);
-   }
for (;;) {
-   fd_set ibits, obits, ebits, *omask;
+   struct pollfd set[2];
-   FD_ZERO();
-   FD_ZERO();
-   FD_ZERO();
-   omask = (fd_set *)NULL;
-   if (fcc) {
-   FD_SET(p, );
-   omask = 
-   } else
-   FD_SET(f, );
+   set[0].fd = p;
+   set[0].events = POLLPRI;
+   set[1].fd = f;
+   set[1].events = 0;
+   if (fcc)
+   set[0].events |= POLLOUT;
+   else
+   set[1].events |= POLLIN;
if (pcc >= 0) {
-   if (pcc) {
-   FD_SET(f, );
-   omask = 
-   } else
-   FD_SET(p, );
+   if (pcc)
+   set[1].events |= POLLOUT;
+   else
+   set[0].events |= POLLIN;
}
-   FD_SET(p, );
-   if ((n = select(nfd, , omask, , 0)) < 0) {
+   if ((n = poll(set, 2, INFTIM)) < 0) {
if (errno == EINTR)
continue;
-   fatal(f, "select", 1);
+   fatal(f, "poll", 1);
}
if (n == 0) {
/* shouldn't happen... */
@@ -385,18 +379,16 @@ protocol(int f, int p)
continue;
}
 #definepkcontrol(c)
((c)&(TIOCPKT_FLUSHWRITE|TIOCPKT_NOSTOP|TIOCPKT_DOSTOP))
-   if (FD_ISSET(p, )) {
+   if (set[0].revents & POLLPRI) {
cc = read(p, , 1);
if (cc == 1 && pkcontrol(cntl)) {
cntl |= oobdata[0];
send(f, , 1, MSG_OOB);
-   if (cntl & TIOCPKT_FLUSHWRITE) {
+   if (cntl & TIOCPKT_FLUSHWRITE)
pcc = 0;
-   FD_CLR(p, );
-   }
}
}
-   if (FD_ISSET(f, )) {
+   if (set[1].revents & POLLIN) {
fcc = read(f, fibuf, sizeof(fibuf));
if (fcc < 0 && errno == EWOULDBLOCK)
fcc = 0;
@@ -422,11 +414,10 @@ protocol(int f, int p)
goto top; /* n^2 */
}
}
-   FD_SET(p, );  /* try write */
}
}
-   if (FD_ISSET(p, ) && fcc > 0) {
+   if (set[0].revents & POLLOUT && fcc > 0) {
cc = write(p, fbp, fcc);
if (cc > 0) {
fcc -= cc;
@@ -434,7 +425,7 @@ protocol(int f, int p)
}
}
-   if (FD_ISSET(p, )) {
+   if (set[0].revents & POLLIN) {
pcc = read(p, pibuf, sizeof (pibuf));
pbp = pibuf;
if (pcc < 0 && errno == EWOULDBLOCK)
@@ -443,7 +434,6 @@ protocol(int f, int p)
break;
else if (pibuf[0] == 0) {
pbp++, pcc--;
-   

Re: svn commit: r295471 - in head/etc: defaults rc.d

[Ronald Klop]

On Wed, 10 Feb 2016 17:13:59 +0100, Mark Felder  wrote:


Author: feld (ports committer)
Date: Wed Feb 10 16:13:59 2016
New Revision: 295471
URL: https://svnweb.freebsd.org/changeset/base/295471

Log:
  Add new rc.conf parameter "jail_reverse_stop"
 When a user defines "jail_list" in rc.conf the jails are started in the
  order defined. Currently the jails are not are stopped in reverse order
  which may break dependencies between jails/services and prevent a clean
  shutdown. The new parameter "jail_reverse_stop" will shutdown jails in
  "jail_list" in reverse order when set to "YES".
 Please note that this does not affect manual invocation of the jail rc
  script. If a user runs the command
   # service jail stop jail1 jail2 jail3
 the jails will be stopped in exactly the order specified regardless of
  jail_reverse_stop being defined in rc.conf.
 PR:196152



Good feature. I know POLA is always very important in FreeBSD development,  
but having this setting on by default seems very reasonable to me.


Regards,
Ronald.




  Approved by:  jamie
  MFC after:1 week
  Relnotes: yes
  Differential Revision:https://reviews.freebsd.org/D5233

Modified:
  head/etc/defaults/rc.conf
  head/etc/rc.d/jail

Modified: head/etc/defaults/rc.conf
==
--- head/etc/defaults/rc.conf   Wed Feb 10 15:56:52 2016(r295470)
+++ head/etc/defaults/rc.conf   Wed Feb 10 16:13:59 2016(r295471)
@@ -694,6 +694,7 @@ iovctl_files=""   # Config files for iovc
 jail_enable="NO" # Set to NO to disable starting of any jails
 jail_parallel_start="NO" # Start jails in the background
 jail_list="" # Space separated list of names of jails
+jail_reverse_stop="NO"   # Stop jails in reverse order
##
 ### Define source_rc_confs, the mechanism used by /etc/rc.* ##

Modified: head/etc/rc.d/jail
==
--- head/etc/rc.d/jail  Wed Feb 10 15:56:52 2016(r295470)
+++ head/etc/rc.d/jail  Wed Feb 10 16:13:59 2016(r295471)
@@ -521,7 +521,11 @@ jail_stop()
command=$jail_program
rc_flags=$jail_flags
command_args="-f $jail_conf -r"
-   $jail_jls name | while read _j; do
+   if checkyesno jail_reverse_stop; then
+   $jail_jls name | tail -r
+   else
+   $jail_jls name
+   fi | while read _j; do
echo -n " $_j"
_tmp=`mktemp -t jail` || exit 3
$command $rc_flags $command_args $_j >> $_tmp 2>&1
@@ -536,6 +540,7 @@ jail_stop()
return
;;
esac
+   checkyesno jail_reverse_stop && set -- $(reverse_list $@)
for _j in $@; do
_j=$(echo $_j | tr /. _)
_jv=$(echo -n $_j | tr -c '[:alnum:]' _)
@@ -571,5 +576,6 @@ jail_warn()
 load_rc_config $name
 case $# in
 1) run_rc_command $@ ${jail_list:-_ALL} ;;
-*) run_rc_command $@ ;;
+*) jail_reverse_stop="no"
+   run_rc_command $@ ;;
 esac
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r295465 - head/usr.sbin/services_mkdb

[Ronald Klop]

On Wed, 10 Feb 2016 10:40:45 +0100, Stefan Esser  wrote:


Author: se
Date: Wed Feb 10 09:40:45 2016
New Revision: 295465
URL: https://svnweb.freebsd.org/changeset/base/295465

Log:
  Remove O_SYNC from the options passed to dbmopen().
 The services db is created as a temporary file that is moved over the
  existing file after completion. Thus there is no need to immediately
  flush all created db records to the temporary file.
 This speeds up creation of the services db by a factor of 500 on my
  ZFS based /var/db filesytem (from 110 seconds to 0.235 seconds).
 MFC after: 1 week


Nice! My ARM installation on an USB stick was so slow I stopped waiting  
for this and started to do tricks of running a tmp dir on the building  
host.


Regards,
Ronald.



Modified:
  head/usr.sbin/services_mkdb/services_mkdb.c

Modified: head/usr.sbin/services_mkdb/services_mkdb.c
==
--- head/usr.sbin/services_mkdb/services_mkdb.c	Wed Feb 10 09:19:29  
2016	(r295464)
+++ head/usr.sbin/services_mkdb/services_mkdb.c	Wed Feb 10 09:40:45  
2016	(r295465)

@@ -141,7 +141,7 @@ main(int argc, char *argv[])
err(1, "Cannot install exit handler");
(void)snprintf(tname, sizeof(tname), "%s.tmp", dbname);
-   db = dbopen(tname, O_RDWR | O_CREAT | O_EXCL | O_SYNC,
+   db = dbopen(tname, O_RDWR | O_CREAT | O_EXCL,
(S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH), DB_HASH, );
if (!db)
err(1, "Error opening temporary database `%s'", tname);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r280040 - head/usr.sbin/bhyve

[Ronald Klop]

On Sun, 15 Mar 2015 16:29:04 +0100, Alexander Motin m...@freebsd.org  
wrote:



Author: mav
Date: Sun Mar 15 15:29:03 2015
New Revision: 280040
URL: https://svnweb.freebsd.org/changeset/base/280040

Log:
  Give AHCI disk serial based on backing file path same as for virtio  
block.
 It is still not good that they may intersect on different hosts, but  
that

  is better then intersecting on the same host.



Hi,

Maybe you can mix sysctl 'kern.hostid: 3674800361' into it.

Regards,
Ronald.




 MFC after: 2 weeks

Modified:
  head/usr.sbin/bhyve/pci_ahci.c

Modified: head/usr.sbin/bhyve/pci_ahci.c
==
--- head/usr.sbin/bhyve/pci_ahci.c  Sun Mar 15 15:19:02 2015
(r280039)
+++ head/usr.sbin/bhyve/pci_ahci.c  Sun Mar 15 15:29:03 2015
(r280040)
@@ -50,6 +50,7 @@ __FBSDID($FreeBSD$);
 #include pthread.h
 #include pthread_np.h
 #include inttypes.h
+#include md5.h
#include bhyverun.h
 #include pci_emul.h
@@ -131,6 +132,7 @@ struct ahci_port {
struct pci_ahci_softc *pr_sc;
uint8_t *cmd_lst;
uint8_t *rfis;
+   char ident[20 + 1];
int atapi;
int reset;
int mult_sectors;
@@ -855,8 +857,7 @@ handle_identify(struct ahci_port *p, int
buf[1] = cyl;
buf[3] = heads;
buf[6] = sech;
-   /* TODO emulate different serial? */
-   ata_string((uint8_t *)(buf+10), 123456, 20);
+   ata_string((uint8_t *)(buf+10), p-ident, 20);
ata_string((uint8_t *)(buf+23), 001, 8);
ata_string((uint8_t *)(buf+27), BHYVE SATA DISK, 40);
buf[47] = (0x8000 | 128);
@@ -946,8 +947,7 @@ handle_atapi_identify(struct ahci_port *
memset(buf, 0, sizeof(buf));
buf[0] = (2  14 | 5  8 | 1  7 | 2  5);
-   /* TODO emulate different serial? */
-   ata_string((uint8_t *)(buf+10), 123456, 20);
+   ata_string((uint8_t *)(buf+10), p-ident, 20);
ata_string((uint8_t *)(buf+23), 001, 8);
ata_string((uint8_t *)(buf+27), BHYVE SATA DVD ROM, 40);
buf[49] = (1  9 | 1  8);
@@ -2167,6 +2167,8 @@ pci_ahci_init(struct vmctx *ctx, struct
struct blockif_ctxt *bctxt;
struct pci_ahci_softc *sc;
int ret, slots;
+   MD5_CTX mdctx;
+   u_char digest[16];
ret = 0;
@@ -2204,6 +2206,16 @@ pci_ahci_init(struct vmctx *ctx, struct
sc-port[0].pr_sc = sc;
/*
+* Create an identifier for the backing file. Use parts of the
+* md5 sum of the filename
+*/
+   MD5Init(mdctx);
+   MD5Update(mdctx, opts, strlen(opts));
+   MD5Final(digest, mdctx);   
+   sprintf(sc-port[0].ident, BHYVE-%02X%02X-%02X%02X-%02X%02X,
+   digest[0], digest[1], digest[2], digest[3], digest[4], digest[5]);
+
+   /*
 * Allocate blockif request structures and add them
 * to the free list
 */
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r279837 - head/sys/arm/conf

[Ronald Klop]

Hi,

Does this make sense on arm4/arm5 like SHEEVAPLUG also?

Ronald.


On Tue, 10 Mar 2015 03:33:52 +0100, Ian Lepore i...@freebsd.org wrote:


Author: ian
Date: Tue Mar 10 02:33:51 2015
New Revision: 279837
URL: https://svnweb.freebsd.org/changeset/base/279837

Log:
  Remove MODULES_OVERRIDE= and WITHOUT_MODULES=ahc from armv6  
configs.

 These are left over from long ago when there was no way to load modules
  on early armv6 platforms, and when there was a build problem with ahc
  that has long since been fixed, and they just keep getting copy-pasted
  into new configs.

Modified:
  head/sys/arm/conf/ARMADAXP
  head/sys/arm/conf/CUBIEBOARD
  head/sys/arm/conf/CUBIEBOARD2
  head/sys/arm/conf/EXYNOS5.common
  head/sys/arm/conf/PANDABOARD
  head/sys/arm/conf/TS7800
  head/sys/arm/conf/VYBRID
  head/sys/arm/conf/ZEDBOARD

Modified: head/sys/arm/conf/ARMADAXP
==
--- head/sys/arm/conf/ARMADAXP  Tue Mar 10 01:24:16 2015(r279836)
+++ head/sys/arm/conf/ARMADAXP  Tue Mar 10 02:33:51 2015(r279837)
@@ -22,7 +22,6 @@ ident MV-88F78XX0
 include../mv/armadaxp/std.mv78x60
options SOC_MV_ARMADAXP
-makeoptionsMODULES_OVERRIDE=
makeoptions WERROR=-Werror

Modified: head/sys/arm/conf/CUBIEBOARD
==
--- head/sys/arm/conf/CUBIEBOARDTue Mar 10 01:24:16 2015
(r279836)
+++ head/sys/arm/conf/CUBIEBOARDTue Mar 10 02:33:51 2015
(r279837)
@@ -23,9 +23,6 @@ ident CUBIEBOARD
include ../allwinner/std.a10
-makeoptionsMODULES_OVERRIDE=
-makeoptionsWITHOUT_MODULES=ahc
-
 optionsHZ=100
 optionsSCHED_4BSD  # 4BSD scheduler
 optionsPREEMPTION  # Enable kernel thread preemption

Modified: head/sys/arm/conf/CUBIEBOARD2
==
--- head/sys/arm/conf/CUBIEBOARD2   Tue Mar 10 01:24:16 2015
(r279836)
+++ head/sys/arm/conf/CUBIEBOARD2   Tue Mar 10 02:33:51 2015
(r279837)
@@ -23,9 +23,6 @@ ident CUBIEBOARD2
include ../allwinner/a20/std.a20
-makeoptionsMODULES_OVERRIDE=
-makeoptionsWITHOUT_MODULES=ahc
-
 optionsHZ=100
 optionsSCHED_ULE   # ULE scheduler
 optionsPREEMPTION  # Enable kernel thread preemption

Modified: head/sys/arm/conf/EXYNOS5.common
==
--- head/sys/arm/conf/EXYNOS5.commonTue Mar 10 01:24:16 2015
(r279836)
+++ head/sys/arm/conf/EXYNOS5.commonTue Mar 10 02:33:51 2015
(r279837)
@@ -18,9 +18,6 @@
 #
 # $FreeBSD$
-makeoptionsMODULES_OVERRIDE=
-makeoptionsWITHOUT_MODULES=ahc
-
 makeoptionsWERROR=-Werror
options HZ=100

Modified: head/sys/arm/conf/PANDABOARD
==
--- head/sys/arm/conf/PANDABOARDTue Mar 10 01:24:16 2015
(r279836)
+++ head/sys/arm/conf/PANDABOARDTue Mar 10 02:33:51 2015
(r279837)
@@ -29,9 +29,6 @@ hints PANDABOARD.hints
include ../ti/omap4/pandaboard/std.pandaboard
-makeoptionsMODULES_OVERRIDE=
-makeoptionsWITHOUT_MODULES=ahc
-
 optionsHZ=100
 optionsSCHED_ULE   # ULE scheduler
 optionsPREEMPTION  # Enable kernel thread preemption

Modified: head/sys/arm/conf/TS7800
==
--- head/sys/arm/conf/TS7800Tue Mar 10 01:24:16 2015(r279836)
+++ head/sys/arm/conf/TS7800Tue Mar 10 02:33:51 2015(r279837)
@@ -8,7 +8,6 @@ ident   TS7800
 include../mv/orion/std.ts7800
options SOC_MV_ORION
-makeoptionsMODULES_OVERRIDE=
#makeoptionsDEBUG=-g# Build kernel with gdb(1) debug symbols
 makeoptionsWERROR=-Werror

Modified: head/sys/arm/conf/VYBRID
==
--- head/sys/arm/conf/VYBRIDTue Mar 10 01:24:16 2015(r279836)
+++ head/sys/arm/conf/VYBRIDTue Mar 10 02:33:51 2015(r279837)
@@ -21,9 +21,6 @@
 ident  VYBRID
 include../freescale/vybrid/std.vybrid
-makeoptionsMODULES_OVERRIDE=
-makeoptionsWITHOUT_MODULES=ahc
-
 makeoptionsWERROR=-Werror
options HZ=100

Modified: head/sys/arm/conf/ZEDBOARD
==
--- head/sys/arm/conf/ZEDBOARD  Tue Mar 10 01:24:16 2015(r279836)
+++ head/sys/arm/conf/ZEDBOARD  Tue Mar 10 02:33:51 2015(r279837)
@@ -23,9 +23,6 @@ ident ZEDBOARD
include ../xilinx/zedboard/std.zedboard
-makeoptionsMODULES_OVERRIDE=
-makeoptionsWITHOUT_MODULES=ahc
-
 options

Re: svn commit: r277828 - in head/sys: fs/tmpfs vm

[Ronald Klop]

On Wed, 28 Jan 2015 11:37:23 +0100, Konstantin Belousov k...@freebsd.org  
wrote:



Author: kib
Date: Wed Jan 28 10:37:23 2015
New Revision: 277828
URL: https://svnweb.freebsd.org/changeset/base/277828

Log:
  Update mtime for tmpfs files modified through memory mapping.  Similar



Thanks a lot. It runs now and seems to work pretty well.

FreeBSD 11.0-CURRENT #3 r277829M: Wed Jan 28 14:54:24 CET 2015
root@**:/usr/obj-arm/arm.arm/usr/src-arm/sys/SHEEVAPLUG arm

Regards,
Ronald.



  to UFS, perform updates during syncer scans, which in particular means
  that tmpfs now performs scan on sync.  Also, this means that a mtime
  update may be delayed up to 30 seconds after the write.
 The vm_object' OBJ_TMPFS_DIRTY flag for tmpfs swap object is similar
  to the OBJ_MIGHTBEDIRTY flag for the vnode object, it indicates that
  object could have been dirtied.  Adapt fast page fault handler and
  vm_object_set_writeable_dirty() to handle OBJ_TMPFS_NODE same as
  OBJT_VNODE.
 Reported by:   Ronald Klop ronald-li...@klop.ws
  Tested by:pho
  Sponsored by: The FreeBSD Foundation
  MFC after:2 weeks

Modified:
  head/sys/fs/tmpfs/tmpfs.h
  head/sys/fs/tmpfs/tmpfs_subr.c
  head/sys/fs/tmpfs/tmpfs_vfsops.c
  head/sys/fs/tmpfs/tmpfs_vnops.c
  head/sys/vm/vm_fault.c
  head/sys/vm/vm_object.c
  head/sys/vm/vm_object.h

Modified: head/sys/fs/tmpfs/tmpfs.h
==
--- head/sys/fs/tmpfs/tmpfs.h   Wed Jan 28 10:25:35 2015(r277827)
+++ head/sys/fs/tmpfs/tmpfs.h   Wed Jan 28 10:37:23 2015(r277828)
@@ -398,6 +398,7 @@ int tmpfs_alloc_vp(struct mount *, struc
 void   tmpfs_free_vp(struct vnode *);
 inttmpfs_alloc_file(struct vnode *, struct vnode **, struct vattr *,
struct componentname *, char *);
+void   tmpfs_check_mtime(struct vnode *);
 void   tmpfs_dir_attach(struct vnode *, struct tmpfs_dirent *);
 void   tmpfs_dir_detach(struct vnode *, struct tmpfs_dirent *);
 void   tmpfs_dir_destroy(struct tmpfs_mount *, struct tmpfs_node *);

Modified: head/sys/fs/tmpfs/tmpfs_subr.c
==
--- head/sys/fs/tmpfs/tmpfs_subr.c  Wed Jan 28 10:25:35 2015
(r277827)
+++ head/sys/fs/tmpfs/tmpfs_subr.c  Wed Jan 28 10:37:23 2015
(r277828)
@@ -1415,6 +1415,31 @@ retry:
return (0);
 }
+void
+tmpfs_check_mtime(struct vnode *vp)
+{
+   struct tmpfs_node *node;
+   struct vm_object *obj;
+
+   ASSERT_VOP_ELOCKED(vp, check_mtime);
+   if (vp-v_type != VREG)
+   return;
+   node = VP_TO_TMPFS_NODE(vp);
+   obj = vp-v_object;
+   KASSERT((obj-flags  (OBJ_TMPFS_NODE | OBJ_TMPFS)) ==
+   (OBJ_TMPFS_NODE | OBJ_TMPFS), (non-tmpfs obj));
+   /* unlocked read */
+   if ((obj-flags  OBJ_TMPFS_DIRTY) != 0) {
+   VM_OBJECT_WLOCK(obj);
+   if ((obj-flags  OBJ_TMPFS_DIRTY) != 0) {
+   obj-flags = ~OBJ_TMPFS_DIRTY;
+   node = VP_TO_TMPFS_NODE(vp);
+   node-tn_status |= TMPFS_NODE_MODIFIED;
+   }
+   VM_OBJECT_WUNLOCK(obj);
+   }
+}
+
 /*
  * Change flags of the given vnode.
  * Caller should execute tmpfs_update on vp after a successful  
execution.


Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c
==
--- head/sys/fs/tmpfs/tmpfs_vfsops.cWed Jan 28 10:25:35 2015
(r277827)
+++ head/sys/fs/tmpfs/tmpfs_vfsops.cWed Jan 28 10:37:23 2015
(r277828)
@@ -50,6 +50,7 @@ __FBSDID($FreeBSD$);
 #include sys/proc.h
 #include sys/jail.h
 #include sys/kernel.h
+#include sys/rwlock.h
 #include sys/stat.h
 #include sys/systm.h
 #include sys/sysctl.h
@@ -418,11 +419,45 @@ tmpfs_statfs(struct mount *mp, struct st
 static int
 tmpfs_sync(struct mount *mp, int waitfor)
 {
+   struct vnode *vp, *mvp;
+   struct vm_object *obj;
if (waitfor == MNT_SUSPEND) {
MNT_ILOCK(mp);
mp-mnt_kern_flag |= MNTK_SUSPEND2 | MNTK_SUSPENDED;
MNT_IUNLOCK(mp);
+   } else if (waitfor == MNT_LAZY) {
+   /*
+* Handle lazy updates of mtime from writes to mmaped
+* regions.  Use MNT_VNODE_FOREACH_ALL instead of
+* MNT_VNODE_FOREACH_ACTIVE, since unmap of the
+* tmpfs-backed vnode does not call vinactive(), due
+* to vm object type is OBJT_SWAP.
+*/
+   MNT_VNODE_FOREACH_ALL(vp, mp, mvp) {
+   if (vp-v_type != VREG) {
+   VI_UNLOCK(vp);
+   continue;
+   }
+   obj = vp-v_object;
+   KASSERT((obj-flags  (OBJ_TMPFS_NODE | OBJ_TMPFS)) ==
+   (OBJ_TMPFS_NODE | OBJ_TMPFS), (non-tmpfs obj

Re: svn commit: r274925 - in head: lib/libc/sys lib/libdpv sbin/ipfw share/man/man4 share/man/man4/man4.arm share/man/man9 sys/boot/common sys/boot/i386/gptzfsboot usr.bin/dpv

[Ronald Klop]

On Mon, 24 Nov 2014 08:23:17 +0100, Joel Dahl j...@vnode.se wrote:


On Sun, Nov 23, 2014 at 10:04:12PM +0100, Baptiste Daroussin wrote:

On Sun, Nov 23, 2014 at 09:00:00PM +, Joel Dahl wrote:
 Author: joel (doc committer)
 Date: Sun Nov 23 21:00:00 2014
 New Revision: 274925
 URL: https://svnweb.freebsd.org/changeset/base/274925

 Log:
   Misc mdoc fixes:

   - Remove superfluous paragraph macros.
   - Remove/fix empty or incorrect macros.
   - Sort sections into conventional order.
   - Terminate quoted strings properly.
   - Remove EOL whitespace.

 Modified:
   head/lib/libc/sys/poll.2
   head/lib/libdpv/dpv.3
   head/sbin/ipfw/ipfw.8
   head/share/man/man4/gre.4
   head/share/man/man4/man4.arm/cgem.4
   head/share/man/man4/me.4
   head/share/man/man4/netmap.4
   head/share/man/man9/get_cyclecount.9
   head/share/man/man9/malloc.9
   head/share/man/man9/sleepqueue.9
   head/sys/boot/common/zfsloader.8
   head/sys/boot/i386/gptzfsboot/gptzfsboot.8
   head/usr.bin/dpv/dpv.1


[...]

 +.Sh AUTHORS
 +This manual page was written by
 +.An Andriy Gapon Aq a...@freebsd.org .
   ^ There should be a Mt here to properly render  
in html


I just picked one in the middle of this commit. In general every mail  
on any

manpage Mt should be used.


Sure. Feel free to go over our manpages and fix them. It's a minor issue.

And while we're on the subject, there's a bit of background to this  
commit.

Back in 2012 I started fixing mandoc lint errors/warnings in our manpage
collection (excluding stuff from contrib/ and gnu/ etc.). I think I got  
them

down from around ~4000 issues to almost zero. Quite a few manpages didn't
even work with mandoc at the time, due to how many syntactical mdoc  
errors
they had. The situation is still good, but I re-ran my scripts yesterday  
and
found a slew of new warnings. I fixed a few obvious ones, but if someone  
with
more time on his hands wants to help, please go ahead. A good starting  
point

would probably the netmap.4 or ctl.conf.5 manpages, they seem to generate
quite a few warnings.

I'd also be grateful if everyone ran mandoc -Tlint on their manpages  
before

committing. :-)



A commit hook does magic for these kind of things. ;-)
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r274925 - in head: lib/libc/sys lib/libdpv sbin/ipfw share/man/man4 share/man/man4/man4.arm share/man/man9 sys/boot/common sys/boot/i386/gptzfsboot usr.bin/dpv

[Ronald Klop]

On Mon, 24 Nov 2014 10:38:14 +0100, Baptiste Daroussin b...@freebsd.org  
wrote:



On Mon, Nov 24, 2014 at 10:19:08AM +0100, Ronald Klop wrote:

On Mon, 24 Nov 2014 08:23:17 +0100, Joel Dahl j...@vnode.se wrote:

 On Sun, Nov 23, 2014 at 10:04:12PM +0100, Baptiste Daroussin wrote:
 On Sun, Nov 23, 2014 at 09:00:00PM +, Joel Dahl wrote:
  Author: joel (doc committer)
  Date: Sun Nov 23 21:00:00 2014
  New Revision: 274925
  URL: https://svnweb.freebsd.org/changeset/base/274925
 
  Log:
Misc mdoc fixes:
 
- Remove superfluous paragraph macros.
- Remove/fix empty or incorrect macros.
- Sort sections into conventional order.
- Terminate quoted strings properly.
- Remove EOL whitespace.
 
  Modified:
head/lib/libc/sys/poll.2
head/lib/libdpv/dpv.3
head/sbin/ipfw/ipfw.8
head/share/man/man4/gre.4
head/share/man/man4/man4.arm/cgem.4
head/share/man/man4/me.4
head/share/man/man4/netmap.4
head/share/man/man9/get_cyclecount.9
head/share/man/man9/malloc.9
head/share/man/man9/sleepqueue.9
head/sys/boot/common/zfsloader.8
head/sys/boot/i386/gptzfsboot/gptzfsboot.8
head/usr.bin/dpv/dpv.1
 

 [...]

  +.Sh AUTHORS
  +This manual page was written by
  +.An Andriy Gapon Aq a...@freebsd.org .
^ There should be a Mt here to properly render
 in html

 I just picked one in the middle of this commit. In general every mail
 on any
 manpage Mt should be used.

 Sure. Feel free to go over our manpages and fix them. It's a minor  
issue.


 And while we're on the subject, there's a bit of background to this
 commit.
 Back in 2012 I started fixing mandoc lint errors/warnings in our  
manpage
 collection (excluding stuff from contrib/ and gnu/ etc.). I think I  
got

 them
 down from around ~4000 issues to almost zero. Quite a few manpages  
didn't

 even work with mandoc at the time, due to how many syntactical mdoc
 errors
 they had. The situation is still good, but I re-ran my scripts  
yesterday

 and
 found a slew of new warnings. I fixed a few obvious ones, but if  
someone

 with
 more time on his hands wants to help, please go ahead. A good starting
 point
 would probably the netmap.4 or ctl.conf.5 manpages, they seem to  
generate

 quite a few warnings.

 I'd also be grateful if everyone ran mandoc -Tlint on their manpages
 before
 committing. :-)


A commit hook does magic for these kind of things. ;-)


Except that such commit hook will prevent updating openssl and/or  
kerberos :)


Regards,
Bapt


Yes, at work people can commit does things by adding a line in the commit  
message. Like 'Allowed by: vendor code commit'. Otherwise major style  
errors just prevent the commit. It helps raising the awareness of what  
they are doing.


Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r271023 - stable/10/sys/dev/vt

[Ronald Klop]

On Wed, 03 Sep 2014 16:57:53 +0200, Alexey Dokuchaev da...@freebsd.org  
wrote:



On Wed, Sep 03, 2014 at 10:34:21AM -0400, Ed Maste wrote:

On 3 September 2014 10:07, Alexey Dokuchaev da...@freebsd.org wrote:
 I'm also wondering why on PowerPC vt(4) behaves much better  
(switching is

 instant, no artifacts at all).

The VGA vt(4) issues all stem from the relatively complex and arcane
VGA hardware and a somewhat limited vt_vga implementation.


Can you elaborate a bit on the technical side of things?  Particularly,  
it

looks strange that syscons(4) was able to work just fine on relatively
complex and arcane VGA hardware, while more modern vt(4) is fighting  
with

problems.


AFAIK syscons works in the text mode of the BIOS. Not on VGA graphics mode.
See the vt man page for textmode in vt_vga.
http://www.freebsd.org/cgi/man.cgi?query=vtmanpath=FreeBSD+10.0-stable

Regards.
Ronald.



Don't get me wrong, I greatly appreciate all of you guys' work, just want
to understand better what are the challenges you're facing.  Thank you,

./danfe
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r266822 - head/sys/netipsec

[Ronald Klop]

On Thu, 29 May 2014 05:44:42 +0200, Gleb Smirnoff gleb...@freebsd.org  
wrote:



On Wed, May 28, 2014 at 11:01:20PM +, Bjoern A. Zeeb wrote:
B Author: bz
B Date: Wed May 28 23:01:20 2014
B New Revision: 266822
B URL: http://svnweb.freebsd.org/changeset/base/266822
B
B Log:
B   Use IPv4 statistics in ipsec4_process_packet() rather than the IPv6
B   version.  This also unbreaks the NOINET6 builds after r266800.
B
B Modified:
B   head/sys/netipsec/ipsec_output.c
B
B Modified: head/sys/netipsec/ipsec_output.c
B  
==
B --- head/sys/netipsec/ipsec_output.c	Wed May 28 19:59:27  
2014	(r266821)
B +++ head/sys/netipsec/ipsec_output.c	Wed May 28 23:01:20  
2014	(r266822)

B @@ -576,7 +576,7 @@ ipsec4_process_packet(
B   DPRINTF((%s: unsupported protocol family %u\n,
B__func__, dst-sa.sa_family));
B   error = EPFNOSUPPORT;
B - IPSEC6STAT_INC(ips_out_inval);
B + IPSECSTAT_INC(ips_out_inval);
B   goto bad;
B   }
B   error = (*sav-tdb_xform-xf_output)(m, isr, NULL, i, off);
B @@ -739,4 +739,4 @@ bad:
B   m_freem(m);
B   return error;
B  }
B -#endif /*INET6*/
B \ No newline at end of file
B +#endif /*INET6*/

Is there any reason to keep the line '\ No newline at end of file' when
it is no longer at the end of the file?



The '\ No newline at end of file' is part of the output of svn diff. It is  
not actual text in the file.


I hope... :-)

NB: editors on Windows very often forget the last newline, so I see this  
message a lot at my work.


Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r261547 - head/sys/teken

[Ronald Klop]

On Thu, 06 Feb 2014 12:38:40 +0100, Aleksandr Rybalko r...@freebsd.org  
wrote:



Author: ray
Date: Thu Feb  6 11:38:39 2014
New Revision: 261547
URL: http://svnweb.freebsd.org/changeset/base/261547

Log:
  Fix crash on load of bigger font. It reduce width and height of  
terminal, but
  current cursor position stay bigger that terminal window size, so next  
input

  triggers assert.
 Reported by:   emaste
 Sponsored by:  The FreeBSD Foundation

Modified:
  head/sys/teken/teken.c

Modified: head/sys/teken/teken.c
==
--- head/sys/teken/teken.c  Thu Feb  6 10:52:51 2014(r261546)
+++ head/sys/teken/teken.c  Thu Feb  6 11:38:39 2014(r261547)
@@ -338,10 +338,26 @@ teken_get_winsize(teken_t *t)
return (t-t_winsize);
 }
+static void
+taken_trim_cursor_pos(teken_t *t, const teken_pos_t *new)


Was teken... already taken?


Ronald.



+{
+   const teken_pos_t *cur;
+
+   cur = t-t_winsize;
+
+   if (cur-tp_row  new-tp_row || cur-tp_col  new-tp_col)
+   return;
+   if (t-t_cursor.tp_row = new-tp_row)
+   t-t_cursor.tp_row = new-tp_row - 1;
+   if (t-t_cursor.tp_col = new-tp_col)
+   t-t_cursor.tp_col = new-tp_col - 1;
+}
+
 void
 teken_set_winsize(teken_t *t, const teken_pos_t *p)
 {
+   taken_trim_cursor_pos(t, p);
t-t_winsize = *p;
teken_subr_do_reset(t);
 }
@@ -350,6 +366,7 @@ void
 teken_set_winsize_noreset(teken_t *t, const teken_pos_t *p)
 {
+   taken_trim_cursor_pos(t, p);
t-t_winsize = *p;
teken_subr_do_resize(t);
 }
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r260939 - head/release/doc/en_US.ISO8859-1/relnotes

[Ronald Klop]

On Mon, 20 Jan 2014 23:25:50 +0100, Glen Barber g...@freebsd.org wrote:


Author: gjb
Date: Mon Jan 20 22:25:50 2014
New Revision: 260939
URL: http://svnweb.freebsd.org/changeset/base/260939

Log:
  Document r260888.
 Sponsored by:  The FreeBSD Foundation

Modified:
  head/release/doc/en_US.ISO8859-1/relnotes/article.xml

Modified: head/release/doc/en_US.ISO8859-1/relnotes/article.xml
==
--- head/release/doc/en_US.ISO8859-1/relnotes/article.xml	Mon Jan 20  
22:08:11 2014	(r260938)
+++ head/release/doc/en_US.ISO8859-1/relnotes/article.xml	Mon Jan 20  
22:25:50 2014	(r260939)

@@ -104,7 +104,9 @@
   sect2 xml:id=kernel
 titleKernel Changes/title
-paranbsp;/para
+para revision=260888Add a filenameVT/filename kernel
+  configuration file, which enables the new literalvt/literal
+  console driver./para
sect3 xml:id=kernel-virtualization
   titleVirtualization support/title



Isn't this configuration file temporary to increase testing instead of  
something which stays for a future release?


http://svnweb.freebsd.org/base?view=revisionrevision=260888

Regards,
Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r258328 - head/sys/net

[Ronald Klop]

On Tue, 19 Nov 2013 22:08:21 +0100, Luigi Rizzo ri...@iet.unipi.it wrote:


On Mon, Nov 18, 2013 at 10:58:14PM +, George V. Neville-Neil wrote:

Author: gnn
Date: Mon Nov 18 22:58:14 2013
New Revision: 258328
URL: http://svnweb.freebsd.org/changeset/base/258328

Log:
  Allow ethernet drivers to pass in packets connected via the nextpkt  
pointer.
  Handling packets in this way allows drivers to amortize work during  
packet reception.


yes.

This is only a first step and eventually we should pass the entire
batch to the netisr handler to further reduce overhead.

Some of the followup emails suggested to change the argument from
struct mbuf * to something else.
I do think we should change it, but what we need is a struct with
head and tail pointers _and_ a counter, because sometimes the code
downstream may have to append the mbuf/batch to a queue,
and these extra fields would save iterating through the chain.

Related to this: at some point we should also address batching
in the transmit path, and for that we will eventually need to
introduce a 'more packets to come' flag to the API/mbuf so that
intermediate functions in the path will build batches before passing
them down.

cheers
luigi


The Apache webserver works like this also. It has a 'bucket'-list which  
chains all data of a request and can also contain flush-commands in  
between. Probably nice to look what they do and in what ways.


Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r252016 - svnadmin/hooks/scripts

[Ronald Klop]

On Thu, 20 Jun 2013 05:55:42 +0200, Peter Wemm pe...@freebsd.org wrote:


Author: peter
Date: Thu Jun 20 03:55:41 2013
New Revision: 252016
URL: http://svnweb.freebsd.org/changeset/base/252016

Log:
  Move /usr/local/bin in front of /usr/bin, just to be sure.


And remove /usr/local/sbin. Is this a typo or intended?

Ronald.



Modified:
  svnadmin/hooks/scripts/env.sh

Modified: svnadmin/hooks/scripts/env.sh
==
--- svnadmin/hooks/scripts/env.sh   Thu Jun 20 02:29:49 2013
(r252015)
+++ svnadmin/hooks/scripts/env.sh   Thu Jun 20 03:55:41 2013
(r252016)
@@ -1,6 +1,6 @@
 # source this file
 # $FreeBSD$
-PATH=/s/svn/base/hooks/scripts:/usr/bin:/bin:/usr/local/bin:/usr/sbin:/sbin:/usr/local/sbin
+PATH=/s/svn/base/hooks/scripts:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
 export PATH
 cd /s/svn/base
 umask 002
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r249849 - in head/sys/dev: hptmv mpt

[Ronald Klop]

Hi,

Maybe I need more coffee, but I don't see a difference between the if and  
the else statements in the hptmv file.


Regards,
Ronald.

On Wed, 24 Apr 2013 21:00:45 +0200, Alexander Motin m...@freebsd.org  
wrote:



Author: mav
Date: Wed Apr 24 19:00:45 2013
New Revision: 249849
URL: http://svnweb.freebsd.org/changeset/base/249849

Log:
  Move hptmv and mpt drivers shutdown a bit later to the  
SHUTDOWN_PRI_LAST
  stage of shutdown_post_sync.  That should allow CAM to do final cache  
flush

  at the SHUTDOWN_PRI_DEFAULT without using polling magic.
 MFC after: 3 days

Modified:
  head/sys/dev/hptmv/entry.c
  head/sys/dev/mpt/mpt_pci.c

Modified: head/sys/dev/hptmv/entry.c
==
--- head/sys/dev/hptmv/entry.c  Wed Apr 24 18:30:32 2013(r249848)
+++ head/sys/dev/hptmv/entry.c  Wed Apr 24 19:00:45 2013(r249849)
@@ -2605,9 +2605,11 @@ launch_worker_thread(void)
 	 * hpt_worker_thread needs to be suspended after shutdown sync, when  
fs sync finished.

 */
 #if (__FreeBSD_version  500043)
-	EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc,  
hptdaemonproc, SHUTDOWN_PRI_FIRST);
+	EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc,  
hptdaemonproc,

+   SHUTDOWN_PRI_LAST);
 #else
-	EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown,  
hptdaemonproc, SHUTDOWN_PRI_FIRST);
+	EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown,  
hptdaemonproc,

+   SHUTDOWN_PRI_LAST);
 #endif
 }
 /*

Modified: head/sys/dev/mpt/mpt_pci.c
==
--- head/sys/dev/mpt/mpt_pci.c  Wed Apr 24 18:30:32 2013(r249848)
+++ head/sys/dev/mpt/mpt_pci.c  Wed Apr 24 19:00:45 2013(r249849)
@@ -563,7 +563,7 @@ mpt_pci_attach(device_t dev)
}
mpt-eh = EVENTHANDLER_REGISTER(shutdown_post_sync, mpt_pci_shutdown,
-   dev, SHUTDOWN_PRI_DEFAULT);
+   dev, SHUTDOWN_PRI_LAST);
if (mpt-eh == NULL) {
mpt_prt(mpt, shutdown event registration failed\n);
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r249462 - head/usr.bin/calendar/calendars

[Ronald Klop]

Than you still miss a 's' at the end.

Ronald.

On Sun, 14 Apr 2013 10:40:24 +0200, Joel Dahl j...@freebsd.org wrote:


Author: joel (doc committer)
Date: Sun Apr 14 08:40:24 2013
New Revision: 249462
URL: http://svnweb.freebsd.org/changeset/base/249462

Log:
  Correct spelling is Christiaan Huygens.
 Submitted by:  James J. Lippard
  Obtained from:OpenBSD

Modified:
  head/usr.bin/calendar/calendars/calendar.birthday

Modified: head/usr.bin/calendar/calendars/calendar.birthday
==
--- head/usr.bin/calendar/calendars/calendar.birthday	Sun Apr 14  
02:42:40 2013	(r249461)
+++ head/usr.bin/calendar/calendars/calendar.birthday	Sun Apr 14  
08:40:24 2013	(r249462)

@@ -120,7 +120,7 @@
 04/10  William Booth born, 1829, founder of the Salvation Army
 04/13	Thomas Jefferson, 3rd President of the United States, born  
Shadwell

Plantation, Albemarle County, Virginia, 1743
-04/14  Christian Huygen born, 1629, physicist  astronomer;
+04/14  Christiaan Huygen born, 1629, physicist  astronomer;
discovered Saturn's rings
 04/15  Leonardo da Vinci born, 1452
 04/16  Charles (Charlie) Chaplin (Sir) born in London, 1889
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r247835 - in head/sys: dev/drm2 dev/drm2/ttm modules/drm2/drm2

[Ronald Klop]

I know this is not done yet, but I appreciate the work very much.

Regards,
Ronald.

On Tue, 05 Mar 2013 10:49:34 +0100, Konstantin Belousov k...@freebsd.org  
wrote:



Author: kib
Date: Tue Mar  5 09:49:34 2013
New Revision: 247835
URL: http://svnweb.freebsd.org/changeset/base/247835

Log:
  Import the preliminary port of the TTM.
 The early commit is done to facilitate the off-tree work on the
  porting of the Radeon driver.
 Sponsored by:  The FreeBSD Foundation
  Debugged and tested by:   dumbbell
  MFC after:1 month

Added:
  head/sys/dev/drm2/ttm/
  head/sys/dev/drm2/ttm/ttm_agp_backend.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_bo.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_bo_api.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_bo_driver.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_bo_manager.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_bo_util.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_bo_vm.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_execbuf_util.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_execbuf_util.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_lock.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_lock.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_memory.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_memory.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_module.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_object.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_object.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_page_alloc.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_page_alloc.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_page_alloc_dma.c   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_placement.h   (contents, props changed)
  head/sys/dev/drm2/ttm/ttm_tt.c   (contents, props changed)
Modified:
  head/sys/dev/drm2/drmP.h
  head/sys/dev/drm2/drm_drv.c
  head/sys/dev/drm2/drm_gem.c
  head/sys/modules/drm2/drm2/Makefile

Modified: head/sys/dev/drm2/drmP.h
==
--- head/sys/dev/drm2/drmP.hTue Mar  5 09:27:21 2013(r247834)
+++ head/sys/dev/drm2/drmP.hTue Mar  5 09:49:34 2013(r247835)
@@ -906,6 +906,7 @@ struct drm_device {
struct drm_minor *control;  /** Control node for card */
struct drm_minor *primary;  /** render type primary screen 
head */
+   void  *drm_ttm_bo;
struct unrhdr *drw_unrhdr;
/* RB tree of drawable infos */
RB_HEAD(drawable_tree, bsd_drm_drawable_info) drw_head;
@@ -1302,10 +1303,14 @@ void drm_gem_release(struct drm_device *
int drm_gem_create_mmap_offset(struct drm_gem_object *obj);
 void drm_gem_free_mmap_offset(struct drm_gem_object *obj);
-int drm_gem_mmap_single(struct cdev *kdev, vm_ooffset_t *offset,  
vm_size_t size,

-struct vm_object **obj_res, int nprot);
+int drm_gem_mmap_single(struct drm_device *dev, vm_ooffset_t *offset,
+vm_size_t size, struct vm_object **obj_res, int nprot);
 void drm_gem_pager_dtr(void *obj);
+struct ttm_bo_device;
+int ttm_bo_mmap_single(struct ttm_bo_device *bdev, vm_ooffset_t *offset,
+vm_size_t size, struct vm_object **obj_res, int nprot);
+
 void drm_device_lock_mtx(struct drm_device *dev);
 void drm_device_unlock_mtx(struct drm_device *dev);
 int drm_device_sleep_mtx(struct drm_device *dev, void *chan, int flags,

Modified: head/sys/dev/drm2/drm_drv.c
==
--- head/sys/dev/drm2/drm_drv.c Tue Mar  5 09:27:21 2013(r247834)
+++ head/sys/dev/drm2/drm_drv.c Tue Mar  5 09:49:34 2013(r247835)
@@ -58,6 +58,8 @@ static int drm_load(struct drm_device *d
 static void drm_unload(struct drm_device *dev);
 static drm_pci_id_list_t *drm_find_description(int vendor, int device,
 drm_pci_id_list_t *idlist);
+static int drm_mmap_single(struct cdev *kdev, vm_ooffset_t *offset,
+vm_size_t size, struct vm_object **obj_res, int nprot);
static int
 drm_modevent(module_t mod, int type, void *data)
@@ -187,7 +189,7 @@ static struct cdevsw drm_cdevsw = {
.d_ioctl =  drm_ioctl,
.d_poll =   drm_poll,
.d_mmap =   drm_mmap,
-   .d_mmap_single = drm_gem_mmap_single,
+   .d_mmap_single = drm_mmap_single,
.d_name =   drm,
.d_flags =  D_TRACKCLOSE
 };
@@ -955,6 +957,23 @@ drm_add_busid_modesetting(struct drm_dev
return (0);
 }
+static int
+drm_mmap_single(struct cdev *kdev, vm_ooffset_t *offset, vm_size_t size,
+struct vm_object **obj_res, int nprot)
+{
+   struct drm_device *dev;
+
+   dev = drm_get_device_from_kdev(kdev);
+   if ((dev-driver-driver_features  DRIVER_GEM) != 0) {
+   return (drm_gem_mmap_single(dev, offset, size, obj_res, 

Re: svn commit: r246032 - in head/sys: sys vm

[Ronald Klop]

On Mon, 28 Jan 2013 13:54:53 +0100, Andrey Zonov z...@freebsd.org wrote:


Author: zont
Date: Mon Jan 28 12:54:53 2013
New Revision: 246032
URL: http://svnweb.freebsd.org/changeset/base/246032

Log:
  - Add system wide page faults requiring I/O counter.
 Reviewed by:   alc
  MFC after:2 weeks


Sounds very useful!

Ronald.




Modified:
  head/sys/sys/vmmeter.h
  head/sys/vm/vm_fault.c
  head/sys/vm/vm_meter.c

Modified: head/sys/sys/vmmeter.h
==
--- head/sys/sys/vmmeter.h  Mon Jan 28 12:50:16 2013(r246031)
+++ head/sys/sys/vmmeter.h  Mon Jan 28 12:54:53 2013(r246032)
@@ -61,6 +61,7 @@ struct vmmeter {
 * Virtual memory activity.
 */
u_int v_vm_faults;  /* (p) address memory faults */
+   u_int v_io_faults;  /* (p) page faults requiring I/O */
u_int v_cow_faults; /* (p) copy-on-writes faults */
u_int v_cow_optim;  /* (p) optimized copy-on-writes faults */
u_int v_zfod;   /* (p) pages zero filled on demand */

Modified: head/sys/vm/vm_fault.c
==
--- head/sys/vm/vm_fault.c  Mon Jan 28 12:50:16 2013(r246031)
+++ head/sys/vm/vm_fault.c  Mon Jan 28 12:54:53 2013(r246032)
@@ -939,9 +939,10 @@ vnode_locked:
 * Unlock everything, and return
 */
unlock_and_deallocate(fs);
-   if (hardfault)
+   if (hardfault) {
+   PCPU_INC(cnt.v_io_faults);
curthread-td_ru.ru_majflt++;
-   else
+   } else
curthread-td_ru.ru_minflt++;
return (KERN_SUCCESS);

Modified: head/sys/vm/vm_meter.c
==
--- head/sys/vm/vm_meter.c  Mon Jan 28 12:50:16 2013(r246031)
+++ head/sys/vm/vm_meter.c  Mon Jan 28 12:54:53 2013(r246032)
@@ -283,6 +283,7 @@ VM_STATS_SYS(v_syscall, System calls);
 VM_STATS_SYS(v_intr, Device interrupts);
 VM_STATS_SYS(v_soft, Software interrupts);
 VM_STATS_VM(v_vm_faults, Address memory faults);
+VM_STATS_VM(v_io_faults, Page faults requiring I/O);
 VM_STATS_VM(v_cow_faults, Copy-on-write faults);
 VM_STATS_VM(v_cow_optim, Optimized COW faults);
 VM_STATS_VM(v_zfod, Pages zero-filled on demand);
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r246016 - head/sys/dev/uart

[Ronald Klop]

On Mon, 28 Jan 2013 00:33:43 +0100, Colin Percival cperc...@freebsd.org  
wrote:



Author: cperciva
Date: Sun Jan 27 23:33:42 2013
New Revision: 246016
URL: http://svnweb.freebsd.org/changeset/base/246016

Log:
  Add a loader tunable hw.broken_txfifo which enables a workaround for  
a
  bug in old versions of QEMU (and Xen, and other places using QEMU  
code).

  On those buggy emulated UARTs, the TX idle interrupt gets lost; with
  this workaround, we spinwait for the TX to happen and then send  
ourselves

  the interrupt.  It's ugly but it works, while minimizing the impact on
  the code for the !broken_txfifo case.
 MFC after: 2 weeks


Would hw.uart.broken_txfifo not be a better name?
It looks more in line with the other devices under hw.* and avoids naming  
collisions.


Regards,
Ronald.




Modified:
  head/sys/dev/uart/uart_dev_ns8250.c

Modified: head/sys/dev/uart/uart_dev_ns8250.c
==
--- head/sys/dev/uart/uart_dev_ns8250.c	Sun Jan 27 23:21:51  
2013	(r246015)
+++ head/sys/dev/uart/uart_dev_ns8250.c	Sun Jan 27 23:33:42  
2013	(r246016)

@@ -31,6 +31,8 @@ __FBSDID($FreeBSD$);
 #include sys/systm.h
 #include sys/bus.h
 #include sys/conf.h
+#include sys/kernel.h
+#include sys/sysctl.h
 #include machine/bus.h
#include dev/uart/uart.h
@@ -845,6 +847,11 @@ ns8250_bus_setsig(struct uart_softc *sc,
return (0);
 }
+static int broken_txfifo = 0;
+SYSCTL_INT(_hw, OID_AUTO, broken_txfifo, CTLFLAG_RW | CTLFLAG_TUN,
+   broken_txfifo, 0, UART FIFO has QEMU emulation bug);
+TUNABLE_INT(hw.broken_txfifo, broken_txfifo);
+
 static int
 ns8250_bus_transmit(struct uart_softc *sc)
 {
@@ -862,7 +869,12 @@ ns8250_bus_transmit(struct uart_softc *s
uart_setreg(bas, REG_DATA, sc-sc_txbuf[i]);
uart_barrier(bas);
}
-   sc-sc_txbusy = 1;
+   if (broken_txfifo)
+   ns8250_drain(bas, UART_DRAIN_TRANSMITTER);
+   else
+   sc-sc_txbusy = 1;
uart_unlock(sc-sc_hwmtx);
+   if (broken_txfifo)
+   uart_sched_softih(sc, SER_INT_TXIDLE);
return (0);
 }
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r243524 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

[Ronald Klop]

On Sun, 25 Nov 2012 17:39:24 +0100, Pawel Jakub Dawidek p...@freebsd.org  
wrote:



On Sun, Nov 25, 2012 at 04:32:08PM +, Martin Matuska wrote:

Author: mm
Date: Sun Nov 25 16:32:07 2012
New Revision: 243524
URL: http://svnweb.freebsd.org/changeset/base/243524

Log:
  MFV r243013 and r243267:

  Import the zio nop-write improvement from Illumos. To reduce I/O,
  nop-write omits overwriting data if the checksum (cryptographically
  secure) of new data matches the checksum of existing data.
  It also saves space if snapshots are in use.

  It currently works only on datasets with enabled compression, disabled
  deduplication and sha256 checksums.

  IllumOS 13887:196932ec9e6a and 13888:7204b3392a58
  3236 zio nop-write


This is a nice change, although I don't understand why it depends on
compression being turned on. It won't save any space.



This question is also discussed here.
http://comments.gmane.org/gmane.os.illumos.zfs/200
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r242109 - stable/9/games/fortune/datfiles

[Ronald Klop]

Will sysinstall also be removed on stable/9? Although I don't really care  
about sysinstall I'm curious.


Ronald.

On Fri, 26 Oct 2012 02:34:27 +0200, Eitan Adler ead...@freebsd.org wrote:


Author: eadler
Date: Fri Oct 26 00:34:27 2012
New Revision: 242109
URL: http://svn.freebsd.org/changeset/base/242109

Log:
  MFC r241845,r241934:
Sysinstall has been removed from base.
 Approved by:   cperciva (implicit)

Modified:
  stable/9/games/fortune/datfiles/freebsd-tips
Directory Properties:
  stable/9/games/fortune/   (props changed)

Modified: stable/9/games/fortune/datfiles/freebsd-tips
==
--- stable/9/games/fortune/datfiles/freebsd-tips	Fri Oct 26 00:32:28  
2012	(r242108)
+++ stable/9/games/fortune/datfiles/freebsd-tips	Fri Oct 26 00:34:27  
2012	(r242109)

@@ -40,7 +40,7 @@ Having trouble using fetch through a fir
 variable FTP_PASSIVE_MODE to yes, and see fetch(3) for more details.
 %
 If other operating systems have damaged your Master Boot Record, you can
-reinstall it either with /usr/sbin/sysinstall or with boot0cfg(8). See
+reinstall it with boot0cfg(8). See
 man boot0cfg for details.
 %
 If you accidentally end up inside vi, you can quit it by pressing  
Escape, colon

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r229466 - head/usr.sbin/mptable

[Ronald Klop]

I don't know much about this code, but is chmod 0666 really wat is wanted  
here (and in the commits following this one)? It makes the file world  
writable. And that smells funny. :-)


Ronald.

On Wed, 04 Jan 2012 08:04:44 +0100, Pawel Jakub Dawidek p...@freebsd.org  
wrote:



Author: pjd
Date: Wed Jan  4 07:04:43 2012
New Revision: 229466
URL: http://svn.freebsd.org/changeset/base/229466

Log:
  Add an missing argument to open(2). If O_CREAT flag is specified,
  file permission has to be specified as well.

Modified:
  head/usr.sbin/mptable/mptable.c

Modified: head/usr.sbin/mptable/mptable.c
==
--- head/usr.sbin/mptable/mptable.c Wed Jan  4 07:01:23 2012
(r229465)
+++ head/usr.sbin/mptable/mptable.c Wed Jan  4 07:04:43 2012
(r229466)
@@ -828,7 +828,7 @@ MPConfigTableHeader( u_int32_t pap )
 intofd;
 u_char dumpbuf[ 4096 ];
-ofd = open( /tmp/mpdump, O_CREAT | O_RDWR );
+ofd = open( /tmp/mpdump, O_CREAT | O_RDWR, 0666 );
 seekEntry( paddr );
 readEntry( dumpbuf, 1024 );
 write( ofd, dumpbuf, 1024 );
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r226775 - in head: etc sbin/devd

[Ronald Klop]

Hi,

I like this. Do you have plans the commit it on stable/9?

Ronald.

On Wed, 26 Oct 2011 04:11:28 +0200, Hiroki Sato h...@freebsd.org wrote:


Author: hrs
Date: Wed Oct 26 02:11:28 2011
New Revision: 226775
URL: http://svn.freebsd.org/changeset/base/226775

Log:
  - Add support for a ! character in regex matching in devd(8).  It  
inverts

the logic (true/false) of the matching.
 - Add !usbus[0-9]+ to IFNET ATTACH notification handler in the default
devd.conf to prevent rc.d/netif from running when usbus[0-9]+ is  
attached.

 Reviewed by:   imp

Modified:
  head/etc/devd.conf
  head/sbin/devd/devd.cc
  head/sbin/devd/devd.conf.5
  head/sbin/devd/devd.hh

Modified: head/etc/devd.conf
==
--- head/etc/devd.conf  Wed Oct 26 01:58:36 2011(r226774)
+++ head/etc/devd.conf  Wed Oct 26 02:11:28 2011(r226775)
@@ -38,6 +38,7 @@ options {
 #
 notify 0 {
match systemIFNET;
+   match subsystem !usbus[0-9]+;
match type  ATTACH;
action /etc/pccard_ether $subsystem start;
 };

Modified: head/sbin/devd/devd.cc
==
--- head/sbin/devd/devd.cc  Wed Oct 26 01:58:36 2011(r226774)
+++ head/sbin/devd/devd.cc  Wed Oct 26 02:11:28 2011(r226775)
@@ -251,7 +251,14 @@ match::match(config c, const char *var,
: _var(var)
 {
_re = ^;
-   _re.append(c.expand_string(string(re)));
+   if (!c.expand_string(string(re)).empty() 
+   c.expand_string(string(re)).at(0) == '!') {
+   _re.append(c.expand_string(string(re)).substr(1));
+   _inv = 1;
+   } else {
+   _re.append(c.expand_string(string(re)));
+   _inv = 0;
+   }
_re.append($);
regcomp(_regex, _re.c_str(), REG_EXTENDED | REG_NOSUB | REG_ICASE);
 }
@@ -268,10 +275,13 @@ match::do_match(config c)
bool retval;
if (Dflag)
-   fprintf(stderr, Testing %s=%s against %s\n, _var.c_str(),
-   value.c_str(), _re.c_str());
+   fprintf(stderr, Testing %s=%s against %s, invert=%d\n,
+   _var.c_str(), value.c_str(), _re.c_str(), _inv);
retval = (regexec(_regex, value.c_str(), 0, NULL, 0) == 0);
+   if (_inv == 1)
+   retval = (retval == 0) ? 1 : 0;
+
return retval;
 }

Modified: head/sbin/devd/devd.conf.5
==
--- head/sbin/devd/devd.conf.5  Wed Oct 26 01:58:36 2011(r226774)
+++ head/sbin/devd/devd.conf.5  Wed Oct 26 02:11:28 2011(r226775)
@@ -41,7 +41,7 @@
 .\ ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE  
OF THIS

 .\ SOFTWARE.
 .\
-.Dd March 8, 2009
+.Dd October 25, 2011
 .Dt DEVD.CONF 5
 .Os
 .Sh NAME
@@ -121,6 +121,10 @@ Creates a regular expression and assigns
 .Ar regexp-name .
 The variable is available throughout the rest of
 the configuration file.
+If the string begins with
+.Ql \! ,
+it matches if the regular expression formed by the rest of the string
+does not match.
 All regular expressions have an implicit
 .Ql ^$
 around them.

Modified: head/sbin/devd/devd.hh
==
--- head/sbin/devd/devd.hh  Wed Oct 26 01:58:36 2011(r226774)
+++ head/sbin/devd/devd.hh  Wed Oct 26 02:11:28 2011(r226775)
@@ -92,6 +92,7 @@ public:
 private:
std::string _var;
std::string _re;
+   bool _inv;
regex_t _regex;
 };
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r225730 - svnadmin/tools

[Ronald Klop]

I'm not authoritative in this. But why does the freebsd project not end  
cvs support? It is not that the world stopped after cvs and it only takes  
time from other tasks IMHO.


Ronald.

On Fri, 23 Sep 2011 17:43:32 +0200, Dmitry Morozovsky ma...@rinet.ru  
wrote:



Dear Simon/colleagues,

it seems CVS exporter has missed quite a bit of files when creating  
fictious

RELENG_9:


head /FreeBSD/ncvs/src/Makefile,v

head1.392;
access;
symbols
RELENG_7_4_0_RELEASE:1.341.2.8.2.1
RELENG_8_2_0_RELEASE:1.358.2.3.4.1
RELENG_7_4:1.341.2.8.0.2
RELENG_7_4_BP:1.341.2.8
RELENG_8_2:1.358.2.3.0.4
RELENG_8_2_BP:1.358.2.3
RELENG_8_1_0_RELEASE:1.358.2.3.2.1

And, naturally, at the root level of RELENG_9 CVS checkout, there is only
Makefile.mips, no Makefile and Makefile.inc1


On Thu, 22 Sep 2011, Simon L. Nielsen wrote:


Author: simon
Date: Thu Sep 22 17:51:09 2011
New Revision: 225730
URL: http://svn.freebsd.org/changeset/base/225730

Log:
  - Add 9.0 (stable and releng) branches to svn2cvs mapping. [1]
  - Checkpoint current list of hacks mainly to handle support for
'Replaced' files.

  Requested by: kensmith

Modified:
  svnadmin/tools/export.py

Modified: svnadmin/tools/export.py
==
--- svnadmin/tools/export.pyThu Sep 22 12:53:27 2011(r225729)
+++ svnadmin/tools/export.pyThu Sep 22 17:51:09 2011(r225730)
@@ -175,6 +175,7 @@ maptable = [
   ( 'stable/6/', 'RELENG_6' ),
   ( 'stable/7/', 'RELENG_7' ),
   ( 'stable/8/', 'RELENG_8' ),
+  ( 'stable/9/', 'RELENG_9' ),
   # errata / security / releng branches
   ( 'releng/ALPHA_2_0/','ALPHA_2_0' ),
   ( 'releng/BETA_2_0/', 'BETA_2_0' ),
@@ -209,6 +210,7 @@ maptable = [
   ( 'releng/8.1/',   'RELENG_8_1' ),
   ( 'releng/8.2/',   'RELENG_8_2' ),
   ( 'releng/8.3/',   'RELENG_8_3' ),
+  ( 'releng/9.0/',   'RELENG_9_0' ),
 ]

 def map2cvs(svnpath):
@@ -336,6 +338,54 @@ def exportrev(pool, fs_ptr, rev, cvspath
 #  continue
 #if p == 'stable/8/release/picobsd/floppy.tree/sbin' and k == 'D':
 #  continue
+#if p == 'head/contrib/llvm/tools/clang/www/demo/what is this  
directory.txt.' and k == 'A':

+#  continue
+#if p ==  
'head/contrib/llvm/lib/ExecutionEngine/JIT/JITDebugRegisterer.cpp' and  
k == 'D' and rev == 210299:

+#  continue
+#if p ==  
'head/contrib/llvm/lib/ExecutionEngine/JIT/JITDebugRegisterer.h' and k  
== 'D' and rev == 210299:

+#  continue
+#if p == 'head/sys/contrib/octeon-sdk/cvmx-interrupt-handler.S'  
and k == 'D' and rev == 215990:

+#  continue
+#if p == 'head/sys/contrib/octeon-sdk/cvmx-log-arc.S' and k == 'D'  
and rev == 215990:

+#  continue
+#if p == 'head/contrib/binutils/ld/emultempl/mipself.em' and k ==  
'D' and rev == 218822:

+#  continue
+#if p == 'head/contrib/binutils/libiberty/pexecute.c' and k == 'D'  
and rev == 218822:

+#  continue
+#if p == 'head/sys/modules/cxgbe/Makefile' and k == 'D' and rev ==  
220231:

+#  continue
+if p == 'head/share/man/man4/geom_map.4' and k == 'D' and rev ==  
222813:

+  continue
+if p == 'head/sys/dev/iicbus/ad7417.c' and k == 'D' and rev ==  
222813:

+  continue
+if p == 'head/sys/nfs/nfs_kdtrace.h' and k == 'D' and rev ==  
222813:

+  continue
+if p == 'head/sys/sys/_stdint.h' and k == 'D' and rev == 222813:
+  continue
+if p == 'head/tools/build/options/WITHOUT_GPIO' and k == 'D' and  
rev == 222813:

+  continue
+if p == 'head/tools/build/options/WITH_OFED' and k == 'D' and rev  
== 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/builtins/set1.0' and k ==  
'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote1.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote2.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote3.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote4.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote5.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote6.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote7.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote8.0' and  
k == 'D' and rev == 222813:

+  continue
+if p == 'head/tools/regression/bin/sh/parser/dollar-quote9.0' and  
k == 'D' and rev == 222813:

+  continue
 makedirs(workpath, _dirname(path), 'src')
 # Now the directory for the files must exist, and branch tag will  
be sticky

 assert 

Re: svn commit: r223519 - head/etc/devd

[Ronald Klop]

Is this part of the auto-detect hardware discussion I read on one of the  
mailinglists lately? About having less drivers in GENERIC and more  
auto-loaded?

If it is... Looks like a nice feature.

Ronald.

On Fri, 24 Jun 2011 23:32:03 +0200, Hans Petter Selasky  
hsela...@freebsd.org wrote:



Author: hselasky
Date: Fri Jun 24 21:32:03 2011
New Revision: 223519
URL: http://svn.freebsd.org/changeset/base/223519

Log:
  - Add auto-load devd config file for USB kernel modules.
 MFC after: 14 days

Added:
  head/etc/devd/bus_auto.conf   (contents, props changed)

Added: head/etc/devd/bus_auto.conf
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/etc/devd/bus_auto.conf Fri Jun 24 21:32:03 2011(r223519)
@@ -0,0 +1,2347 @@
+#
+# $FreeBSD$
+#
+# This file was automatically generated by tools/bus_autoconf.sh.
+# Please do not edit!
+#
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode (host|device);
+   match intclass 0x02;
+   match intsubclass 0x06;
+   action kldload if_cdce;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode (host|device);
+   match intclass 0x02;
+   match intsubclass 0x0a;
+   action kldload if_cdce;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode (host|device);
+   match intclass 0x02;
+   match intsubclass 0x0d;
+   action kldload if_cdce;
+};
+
+# 3 usb_dual entries processed
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x05ac;
+   match product 0x1290;
+   match intclass 0xff;
+   match intsubclass 0xfd;
+   match intprotocol 0x01;
+   action kldload if_ipheth;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x05ac;
+   match product 0x1292;
+   match intclass 0xff;
+   match intsubclass 0xfd;
+   match intprotocol 0x01;
+   action kldload if_ipheth;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x05ac;
+   match product 0x1294;
+   match intclass 0xff;
+   match intsubclass 0xfd;
+   match intprotocol 0x01;
+   action kldload if_ipheth;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x05ac;
+   match product 0x1297;
+   match intclass 0xff;
+   match intsubclass 0xfd;
+   match intprotocol 0x01;
+   action kldload if_ipheth;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0104;
+   match product 0x00be;
+   action kldload uipaq;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x03e8;
+   match product 0x0008;
+   action kldload if_kue;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x03eb;
+   match product 0x2109;
+   action kldload uftdi;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x03f0;
+	match product  
(0x0121|0x1016|0x1116|0x1216|0x1b1d|0x1e1d|0x2016|0x2116|0x2216|0x3016|0x3116|0x3216|0x3524|0x4016|0x4116|0x4216|0x5016|0x5116|0x5216|0x811c|0xca02);

+   action kldload ugensa;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0402;
+   match product 0x5632;
+   action kldload if_cdce;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0403;
+	match product  
(0x6001|0x6004|0x6010|0x6011|0x8372|0x9e90|0xcc48|0xcc49|0xcc4a|0xd678|0xe6c8|0xe888|0xe889|0xe88a|0xe88b|0xe88c|0xee18|0xf608|0xf60b|0xf850|0xfa00|0xfa01|0xfa02|0xfa03|0xfa04|0xfc08|0xfc09|0xfc0b|0xfc0c|0xfc0d|0xfc82);

+   action kldload uftdi;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0408;
+   match product (0x0304|0x1000|0xea02|0xea03|0xea04|0xea05|0xea06);
+   action kldload if_run;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0409;
+   match product (0x00d5|0x00d6|0x00d7|0x8024|0x8025);
+   action kldload uipaq;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0411;
+	match product  
(0x0001|0x0005|0x0009|0x0012|0x003d|0x005e|0x0066|0x0067|0x006e|0x008b|0x00b3|0x00d8|0x00d9|0x00da|0x00e8|0x0116|0x0119|0x012e|0x0137|0x0148|0x0150|0x015d|0x016f);

+   action kldload if_aue;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0413;
+   match product 0x2101;
+   action kldload uplcom;
+};
+
+nomatch 32 {
+   match bus uhub[0-9]+;
+   match mode host;
+   match vendor 0x0423;
+   match product (0x000a|0x000c);
+   action kldload if_cue;
+};
+
+nomatch 32 {
+   match bus 

Re: svn commit: r218745 - head/sys/boot/i386/boot2

[Ronald Klop]

On Wed, 16 Feb 2011 23:41:26 +0100, Alexander Best arun...@freebsd.org  
wrote:



On Wed Feb 16 11, Alexander Best wrote:

On Wed Feb 16 11, Alexander Best wrote:
 On Wed Feb 16 11, Warner Losh wrote:
  Author: imp
  Date: Wed Feb 16 18:05:10 2011
  New Revision: 218745
  URL: http://svn.freebsd.org/changeset/base/218745
 
  Log:
Remove reading of symbols from a.out loaded files.  Since we are  
tight
on space for clang and a.out support is only needed for  
/boot/loader,

they are excess bytes that serve no useful purpose other than to
support really old kernels (FreeBSD  3.2 or so).  Prefer clang
support over support for these old kernels and remove this code.   
We

gain about 100 bytes of space this way.

 i think without this code uint32_t x serves no purpose any longer:

 /usr/git-freebsd-head/sys/boot/i386/boot2/boot2.c:322:20: warning:  
unused variable 'x' [-Wunused-variable]

 uint32_t addr, x;
^

also due to

/usr/git-freebsd-head/sys/boot/i386/boot2/boot2.c:631:8: warning: cast  
from 'caddr_t' (aka 'char *') to 'uint32_t *' (aka 'unsigned int *')  
increases required alignment from 1 to 4 [-Wcast-align]

t1 = *(uint32_t *)PTOV(0x46c);
  ^~~

i think t0 and t1 can be turned into uint8_t's and PTOV(0x46c); can be  
casted

to (uint8_t *), instead of (uint32_t *).


with this additional change the code fits when compiled with clang:

diff --git a/sys/boot/i386/boot2/sio.S b/sys/boot/i386/boot2/sio.S
index 7b8e9eb..d745129 100644
--- a/sys/boot/i386/boot2/sio.S
+++ b/sys/boot/i386/boot2/sio.S
@@ -29,11 +29,11 @@
 sio_init:  movw $SIO_PRT+0x3,%dx   # Data format reg
movb $SIO_FMT|0x80,%al  # Set format
outb %al,(%dx)  #  and DLAB
-   pushl %edx  # Save
+   pushb %dl   # Save
subb $0x3,%dl   # Divisor latch reg
movl 0x8(%esp),%eax # Set
outw %ax,(%dx)  #  BPS
-   popl %edx   # Restore
+   popb %dl# Restore
movb $SIO_FMT,%al   # Clear
outb %al,(%dx)  #  DLAB
incl %edx   # Modem control reg

...since we're only modifying %dl in subb $0x3,%dl, we don't need to  
push/pop

a 32 bit value, but only 8 bits.



You guys are kings. :-) I heard they don't even teach assembly anymore at  
a lot of universities.













cheers.
alex



cheers.
alex


 cheers.
 alex

 
Reviewed by:rdivacky@
 
  Modified:
head/sys/boot/i386/boot2/boot2.c
 
  Modified: head/sys/boot/i386/boot2/boot2.c
   
==
  --- head/sys/boot/i386/boot2/boot2.c	Wed Feb 16 17:50:21  
2011	(r218744)
  +++ head/sys/boot/i386/boot2/boot2.c	Wed Feb 16 18:05:10  
2011	(r218745)

  @@ -347,23 +347,6 @@ load(void)
p += roundup2(hdr.ex.a_text, PAGE_SIZE);
if (xfsread(ino, p, hdr.ex.a_data))
return;
  - p += hdr.ex.a_data + roundup2(hdr.ex.a_bss, PAGE_SIZE);
  - bootinfo.bi_symtab = VTOP(p);
  - *(uint32_t*)p = hdr.ex.a_syms;
  - p += sizeof(hdr.ex.a_syms);
  - if (hdr.ex.a_syms) {
  - if (xfsread(ino, p, hdr.ex.a_syms))
  - return;
  - p += hdr.ex.a_syms;
  - if (xfsread(ino, p, sizeof(int)))
  - return;
  - x = *(uint32_t *)p;
  - p += sizeof(int);
  - x -= sizeof(int);
  - if (xfsread(ino, p, x))
  - return;
  - p += x;
  - }
   } else {
fs_off = hdr.eh.e_phoff;
for (j = i = 0; i  hdr.eh.e_phnum  j  2; i++) {
  @@ -395,8 +378,8 @@ load(void)
}
}
addr = hdr.eh.e_entry  0xff;
  + bootinfo.bi_esymtab = VTOP(p);
   }
  -bootinfo.bi_esymtab = VTOP(p);
   bootinfo.bi_kernelname = VTOP(kname);
   bootinfo.bi_bios_dev = dsk.drive;
   __exec((caddr_t)addr, RB_BOOTINFO | (opts  RBX_MASK),

 --
 a13x

--
a13x

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r214199 - stable/8

[Ronald Klop]

On Sat, 23 Oct 2010 12:05:00 +0200, Robert Watson rwat...@freebsd.org  
wrote:




On Fri, 22 Oct 2010, Andriy Gapon wrote:


+20101022:
+   A workaround for a fixed ld bug has been removed in kernel code,
+   so make sure that your system ld is built from sources after
+   revision 211583 (r210245 if building stable/8 kernel on head,
+   r211584 for stable/7).  A symptom of incorrect ld version is
+   different addresses for set_pcpu section and __start_set_pcpu
+   symbol in kernel and/or modules.


Since many of our users still rely on cvsup to update FreeBSD source, it  
might be useful to provide rough date thresholds for the branches in  
addition to the Subversion changeset numbers (which are less easy to  
deal with when checking out with cvsup/cvs).


Thanks!

Robert


As a non-freebsd developer is there an advantage to do svn checkout in  
stead of c(v)sup?


Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r213167 - head/tools/regression/geom_eli

[Ronald Klop]

On Sat, 25 Sep 2010 12:34:11 +0200, Pawel Jakub Dawidek p...@freebsd.org  
wrote:



Author: pjd
Date: Sat Sep 25 10:34:11 2010
New Revision: 213167
URL: http://svn.freebsd.org/changeset/base/213167

Log:
  - Use $md instead of md0, which fixes tests when md(4) device is  
already

present.
  - Correct message - we create GPT, not MBR.
 MFC after: 2 weeks

Modified:
  head/tools/regression/geom_eli/resize.t

Modified: head/tools/regression/geom_eli/resize.t
==
--- head/tools/regression/geom_eli/resize.t	Sat Sep 25 10:32:52  
2010	(r213166)
+++ head/tools/regression/geom_eli/resize.t	Sat Sep 25 10:34:11  
2010	(r213167)

@@ -124,8 +124,8 @@ geli detach ${md}a.eli
 # 1g to 20m, 2g to 30m and keyfile to tmp.key, and adding -B none
 # to geli init.
-gpart create -s GPT md0 || echo -n not 
-echo ok $i - Installed an MBR on md0
+gpart create -s GPT $md || echo -n not 
+echo ok $i - Installed an GPT on md0
 i=$((i + 1))
 gpart add -s 20m -t freebsd-ufs -i 1 $md || echo -n not 
 echo ok $i - Added a 20m partition in slot 1


Hi,

You still use md0 in the message in stead of $md.

Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r207933 - head/sys/cam/scsi

[Ronald Klop]

On Wed, 12 May 2010 16:20:49 +0200, Matthew Jacob m...@feral.com wrote:


  Ow. No need to be rude :-).

No, I didn't, why do you ask?


Oh never mind, I just liked the use of alphabetical characters to indicate  
disk devices and I always wondered what DOS/Windows would do if you had  
more than 26 disks.


Cheers,

Ronald.


Wow, did you copy this from windows? :-)


___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r207933 - head/sys/cam/scsi

[Ronald Klop]

On Wed, 12 May 2010 00:22:01 +0200, Matt Jacob mja...@freebsd.org wrote:


Author: mjacob
Date: Tue May 11 22:22:01 2010
New Revision: 207933
URL: http://svn.freebsd.org/changeset/base/207933

Log:
  Deal sensibly with more than 26 sg devices. It isn't a complete
  solution.
 Sponsored by:   Panasas
  MFC after:1 week

Modified:
  head/sys/cam/scsi/scsi_sg.c

Modified: head/sys/cam/scsi/scsi_sg.c
==
--- head/sys/cam/scsi/scsi_sg.c Tue May 11 21:07:47 2010(r207932)
+++ head/sys/cam/scsi/scsi_sg.c Tue May 11 22:22:01 2010(r207933)
@@ -303,7 +303,12 @@ sgregister(struct cam_periph *periph, vo
softc-dev = make_dev(sg_cdevsw, periph-unit_number,
  UID_ROOT, GID_OPERATOR, 0600, %s%d,
  periph-periph_name, periph-unit_number);
-   (void)make_dev_alias(softc-dev, sg%c, 'a' + periph-unit_number);
+   if (periph-unit_number  26) {
+   (void)make_dev_alias(softc-dev, sg%c, periph-unit_number + 
'a');
+   } else {
+   (void)make_dev_alias(softc-dev, sg%c%c,
+		((periph-unit_number / 26) - 1) + 'a', periph-unit_number +  
'a');

+   }
cam_periph_lock(periph);
softc-dev-si_drv1 = periph;


Wow, did you copy this from windows? :-)
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r202708 - head/sys/fs/tmpfs

[Ronald Klop]

On Wed, 20 Jan 2010 18:34:37 +0100, Ivan Voras ivo...@freebsd.org wrote:


2010/1/20 Jaakko Heinonen j...@freebsd.org:

Author: jh
Date: Wed Jan 20 16:56:20 2010
New Revision: 202708
URL: http://svn.freebsd.org/changeset/base/202708



Modified:
 head/sys/fs/tmpfs/tmpfs_subr.c
 head/sys/fs/tmpfs/tmpfs_vfsops.c


Any chance of downgrading the considered highly experimental status
message of tmpfs to something less scary? Like will probably not set
your hamster on fire? :)

I admit I haven't used it for any really demanding work but it looks
ok enough for /tmp on some busy systems.


And since this list is shrinking.
http://www.freebsd.org/cgi/query-pr-summary.cgi?category=severity=priority=class=state=sort=nonetext=tmpfsresponsible=multitext=originator=release=

Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r200369 - in head: etc share/termcap

[Ronald Klop]

On Sat, 12 Dec 2009 10:36:03 +0100, Doug Barton do...@freebsd.org wrote:


Christoph Mallon wrote:

Doug Barton wrote:

Garrett Wollman wrote:

On Sat, 12 Dec 2009 03:20:07 +0900, Hajimu UMEMOTO
u...@freebsd.org said:


It's great, thank!!
I believe that our xterm entry was modified not to clear screen when
applications such as less(1) are terminated.  Are there any chance to
back to the behavior?

aol/

I don't understand why people put up with the unspeakably obnoxious
alternate screen behavior.  Please don't tell me someone actually
thinks it's *useful*.


I actually liked having the remnants of whatever I was looking at in
$PAGER left behind on the screen, and would appreciate it if someone
could tell me how to restore that locally.


%echo $LESS
-X


Yeah, I should have been more clear. I am aware of that solution for
less, but I also dislike this behavior for vi, etc. Basically, I want
to know what to twiddle to get the old behavior back.


Doug (but thanks anyway ...) :)



Maybe this?
http://lists.freebsd.org/pipermail/svn-src-head/2009-July/009102.html

Ronald.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org