Re: svn commit: r284409 - in head/cddl/lib: libzfs libzfs_core
On 15/06/2015 21:06, Warner Losh wrote: On Jun 15, 2015, at 8:37 AM, Matthew Ahrens m...@mahrens.org wrote: On Mon, Jun 15, 2015 at 7:53 AM, Andriy Gapon a...@freebsd.org wrote: P.S. My personal preference would be to drop that compat code and to convince ZFS/FreeBSD users to always use boot environments, so that their kernel and userland never fall out of sync :) Me too :-) Sadly, there are a number of upgrade scenarios where this simply isn’t possible. Curious what are those... The only scenario I can think of is one where there is not enough space to hold the previous OS bits and the new ones. But in such a constrained system there is probably not much use for ZFS anyway. But looking at the file, it appears to be full of stuff to do the 8.x - 9.x upgrade of ZFS to format 28. Perhaps that can now be removed? I would expect that every user of ZFS/FreeBSD has moved past that line by now, but who knows... These libraries appear to be versioned, rather than symbol versioned otherwise Baptiste’s commit would have been bad… but I wonder if maybe a version bump is in order… I think we should be okay without a version bump, because the symbol is moved from a library to its dependency. So, libzfs_core interface is extended and that should not be a problem for its users. And libzfs users should not notice that the symbol migrated from libzfs to libfzs_core because the users have to link to both libraries (or load both of them). -- Andriy Gapon ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r284409 - in head/cddl/lib: libzfs libzfs_core
On 15/06/2015 13:48, Baptiste Daroussin wrote:
Author: bapt
Date: Mon Jun 15 10:48:48 2015
New Revision: 284409
URL: https://svnweb.freebsd.org/changeset/base/284409
Log:
Fix circular dependency between libzfs and libzfs_core
libzfs_core is the wrapper around kernel ioctls, the ioctl compat code
belongs
to it
This is not 100% correct description.
libzfs_core provides a stable, committed interface, so it has a number of
functions that wrap ioctls, but libzfs calls many ioctls directly as well.
So that compat code is needed equally by both, but given that libzfs uses
libzfs_core your change moves things in the right direction.
P.S.
My personal preference would be to drop that compat code and to convince
ZFS/FreeBSD users to always use boot environments, so that their kernel and
userland never fall out of sync :)
Modified:
head/cddl/lib/libzfs/Makefile
head/cddl/lib/libzfs_core/Makefile
Modified: head/cddl/lib/libzfs/Makefile
==
--- head/cddl/lib/libzfs/Makefile Mon Jun 15 07:13:23 2015
(r284408)
+++ head/cddl/lib/libzfs/Makefile Mon Jun 15 10:48:48 2015
(r284409)
@@ -37,7 +37,6 @@ SRCS+= libzfs_changelist.c \
zfs_comutil.c \
zfs_deleg.c \
zfs_fletcher.c \
- zfs_ioctl_compat.c \
zfs_namecheck.c \
zfs_prop.c \
zpool_prop.c \
Modified: head/cddl/lib/libzfs_core/Makefile
==
--- head/cddl/lib/libzfs_core/MakefileMon Jun 15 07:13:23 2015
(r284408)
+++ head/cddl/lib/libzfs_core/MakefileMon Jun 15 10:48:48 2015
(r284409)
@@ -11,7 +11,8 @@ DPADD= ${LIBNVPAIR}
LDADD= -lnvpair
SRCS=libzfs_core.c \
- libzfs_core_compat.c
+ libzfs_core_compat.c \
+ zfs_ioctl_compat.c
SRCS+= libzfs_compat.c
--
Andriy Gapon
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r284409 - in head/cddl/lib: libzfs libzfs_core
On Mon, Jun 15, 2015 at 7:53 AM, Andriy Gapon a...@freebsd.org wrote: P.S. My personal preference would be to drop that compat code and to convince ZFS/FreeBSD users to always use boot environments, so that their kernel and userland never fall out of sync :) Me too :-) --matt ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r284409 - in head/cddl/lib: libzfs libzfs_core
On Jun 15, 2015, at 8:37 AM, Matthew Ahrens m...@mahrens.org wrote: On Mon, Jun 15, 2015 at 7:53 AM, Andriy Gapon a...@freebsd.org wrote: P.S. My personal preference would be to drop that compat code and to convince ZFS/FreeBSD users to always use boot environments, so that their kernel and userland never fall out of sync :) Me too :-) Sadly, there are a number of upgrade scenarios where this simply isn’t possible. But looking at the file, it appears to be full of stuff to do the 8.x - 9.x upgrade of ZFS to format 28. Perhaps that can now be removed? These libraries appear to be versioned, rather than symbol versioned otherwise Baptiste’s commit would have been bad… but I wonder if maybe a version bump is in order… Warner signature.asc Description: Message signed with OpenPGP using GPGMail
