[Swan-commit] Changes to ref refs/heads/master
New commits: commit ad67c45e0b69f1b39e3f89c558dd142f0519bbbd Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Dec 15 17:53:51 2013 -0500 tidy safe_socket (remove gotos) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 87747f2772f1a7c08bec94419cf526be50996787 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Dec 16 01:10:08 2013 -0500 Simplify and tidy starter_iface_find. Still some mysteries. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 8300275fca0087b36c33a37a42fbe47365e98a6d Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Dec 16 14:15:35 2013 -0500 More gotos gone. Some typing improvements too. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 108229229145ef72618f5bbadab3073ed8cc06bc Merge: 0907c2f 7933f85 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jan 9 16:46:15 2014 -0500 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 0907c2f8a0634e498eda19f1a02dc71551fb2edc Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jan 9 16:35:26 2014 -0500 Tidy: - don't test bool's against TRUE or FALSE, use them directly - testing st-st_clonedfrom != SOS_NOBODY is what IS_CHILD_SA(st) does - send_notification's type parameter should be notification_t. So too for send_notification_from_state and send_notification_from_md - no caller of send_notification used SPI parameters, so ditch them. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 31fb415c3f45bbf333457be7aa4bbd5ae84539ae Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 09:33:27 2014 -0500 tidy certificate handling commit 8e653227426ecc0eb3d272c98ef7306f115f212c Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 09:30:45 2014 -0500 make storage class of definition and declaration match commit c43d6e0194bf420340684759e7cbae17b3a683ec Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:38:50 2014 -0500 load_cert: elimiinate unused support for forcedtype, a significant simplification commit 80026eb758e319c348cfcf6281d0b5d8a8f173ad Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:29:13 2014 -0500 handle file I/O errors in load_cert commit 893c45ed3b3358f9c14b309f58bae5831b0461f4 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:27:16 2014 -0500 fix memory leak in alg_info_ah_create_from_str() error case commit 50b934fe6f48d090a7a4eb94674116564794cdb6 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:25:59 2014 -0500 Simplify alloc.c code. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 28bacb320e269ce5385af4d469d66a37e8bc29c2 Merge: fc72cb6 262ac3a Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 21:28:37 2014 -0500 Merge branch 'master' into xauth_2014jan12 Conflicts: include/constants.h Unnoticed conflict: programs/pluto/defs.h commit fc72cb620772c105aa4fa0cc024ff23ebb367e38 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 21:11:39 2014 -0500 delete misleading leftovers commit 0e402c916f2cd60f6610534cb75f66d6fdc2dd15 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 21:10:48 2014 -0500 make memeq macro safer commit 92d7f586df864e9f60e4e9bc1e27543a9a405b8b Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 15:51:55 2014 -0500 Get rid of pointless volatile (Coverity scan). Redo some of the variables that were volatile commit bf1cb7db10892ffec23f8baaa488c778bdc8cc7f Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 15:35:57 2014 -0500 Extended jam_str and add_str to inform the caller of truncation. This would allow callers to handle that case (but none of the 50 do). Inspired by OpenBSD's strlcpy(3) and strlcat(3). commit 7cd53e92abcc09e6a9540f8c31e3b1eea24e18dc Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 09:33:27 2014 -0500 tidy certificate handling commit 11ef11546719a64d6889b85bc3d060a22b2dd87f Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 09:30:45 2014 -0500 make storage class of definition and declaration match commit 1684db1d347040ce17f2cf96271f67788925db66 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:38:50 2014 -0500 load_cert: elimiinate unused support for forcedtype, a significant simplification commit c3bd0f721b9e588dde3df6ec974555d93a183a2e Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:29:13 2014 -0500 handle file I/O errors in load_cert commit 1127e4ccd5dfe24025672243194abed0c0ea284a Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:27:16 2014 -0500 fix memory leak in alg_info_ah_create_from_str() error case commit 782c053cd756adf49f6fe135f26349437163b7b0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jan 18 08:25:59 2014 -0500 Simplify alloc.c code. commit 786b0b433c09198ac4b49e26f7c811ace20e26e6 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jan 17 21:20:35 2014 -0500 - introduced add_str() to do what coders mistakenly think strncat() does - replaced many uses of strncat(), often bogus, with add_str() - replaced a few of the remaining uses of strcpy() with jam_str() - fix many questionable uses of st_xauth_username many uses of strncat were bogus; so too with a couple of remaining uses of strncp commit d4c0ccdeeebada66210908a9cbcc610075e2e4fb Author: Paul Wouters pwout...@redhat.com Date: Fri Jan 17 11:44:26 2014 -0800 testing: updated testing/pluto/ikev2-12-transport-psk commit b5513657dad6cc6e6c7497809027e94d1626b1df Author: Paul Wouters pwout...@redhat.com Date: Fri Jan 17 11:43:06 2014 -0800 testing: WIP update for nat-transport-02 commit b725e555e9ff623bfb24e39342876f1a5f97 Author: Paul Wouters pwout...@redhat.com Date: Fri Jan 17 10:56:12 2014 -0800 testing: add netcat to kickstart files commit 9d44cdf21d725cf3907b996ad7089d68db3ba74b Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jan 17 02:22:45 2014 -0500 fix misuse of strncat (odd function that) commit c8f1afe3c44ad8b22ab069fdf053cb1ba18c9827 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jan 16 23:29:29 2014 -0500 alg_info.c: - fix bug introduced in 8ca36783dd35b6ce7575a36dfa59e9ccb4deab9a - get rid of gotos - tidy commit b1a7fb3ef16b297ce58dfbe90ebb1cf888f40ef9 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jan 16 22:44:51 2014 -0500 - Unify alg_enum_search_prefix and alg_enum_search_ppfix as alg_enum_search - tidy alg_enum_search - fix incorrect comments in programs/pluto/plutoalg.c - get rid of some more gotos commit 17f64e6347ca1493a6702402d4b6da702f772261 Author: Paul Wouters pwout...@redhat.com Date: Wed Jan 15 23:46:24 2014 -0800 testing: updated interop-ikev2-strongswan-09-psk-aes-gcm commit eefb60f94f8a9f066135f53c8a9d53910b5472f1 Author: Paul Wouters pwout...@redhat.com Date: Wed Jan 15 23:46:07 2014 -0800 testing: updated interop-ikev2-strongswan-09-psk-aes-ccm commit 38a9fd28a0a62d106212b41dea6978ada41271eb Author: Paul Wouters pwout...@redhat.com Date: Wed Jan 15 23:45:47 2014 -0800 testing: update interop-ikev2-strongswan-07-strongswan commit db2a192b2baa65d08defc9bb6d54f71aa74d62ce Author: Paul Wouters pwout...@redhat.com Date: Wed Jan 15 23:44:51 2014 -0800 testing: fixup interop-ikev2-strongswan-08-nonat commit 6f60dcabc0af6b7e7a5445099eb6eb65a0fd700b Author: Paul Wouters pwout...@redhat.com Date: Wed Jan 15 23:44:19 2014 -0800 testing: fixup interop-ikev2
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 546d36a76ad23e8ee65084ee8108065f4d327809 Merge: 210c8e4 8f85e4c Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jan 19 14:13:43 2014 -0500 Merge branch 'master' of vault.libreswan.fi:/srv/src/libreswan commit 210c8e434edf594bdd56b115a860471dbb101e02 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jan 19 14:10:11 2014 -0500 Tidy lib/libipsecconf/confread.c: - fix NULL defererence found by Coverity - convert ints that were really bools - reduce scope of some variables ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit c940cfec4c74c201efa4649742bf638867ad3316 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jan 20 00:34:53 2014 -0500 add flags to whack for exiting features commit ec189ee5fdc9c4b9a46e7cfc3bc7854d36c146e7 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jan 20 00:32:40 2014 -0500 remove reference to passert: not available ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 26cba7175b4724a58a7adc1026687cab438eae3c Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Feb 4 01:34:45 2014 -0500 comment blocks should end with a line with only */ ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 11e18ed6fc5e302fa780b1afa0811feb7a4d6e41 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Feb 8 22:44:11 2014 -0500 avoid fixed-length buffer in rsasigkey.c ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 89c581fed10c9f71cbc289f6ec69d7b4e40c1632 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Feb 17 14:15:07 2014 -0500 - each case body should start on a new line - delete nss_hmac_mech (it was unused and commented out) - tidy debugging code in calc_dh_shared ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 957101b6961805ec739d432aac569ceb2e1629bb Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Mar 21 01:52:28 2014 -0400 Followup to 6a8e3b1a8114c09901b80ef374c436c503986b47 - reintroduce private buffers for packet marshalling (instead of reply_buffer) for functions that might be called during the creation of a packet. send_notification, ikev1_delete_out, send_v2_notification, ikev2_send_informational Not sure this is necessary in each case, but is safe. Any others? - every use of reply_buffer should only use it to initialize reply_stream. commit da5bb367c118bf98d95d17c664029ca6cb307f2d Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Mar 21 01:05:17 2014 -0400 zero(array) will silently fail: it will only zero the first element of the array. Use zero(array). - added comment to definition to make this clear - fixed many instances of zero(reply_buffer) - fixed one instance that affects CISCO_SPLIT_INC processing. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit e6d5697fe9cf063c471f1832af4e67432b81d6ab Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Mar 23 14:36:13 2014 -0400 fix up some comments ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 048ef1c5b1e961af18d988dd430521bb9a4f35b3 Merge: 74a636f 84da1c3 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Mar 23 14:40:56 2014 -0400 Merge branch 'master' of vault.libreswan.fi:/srv/src/libreswan commit 74a636f21fff327af468c39550611bcb1045dcd3 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Mar 23 14:38:04 2014 -0400 complete_v[12]_state_transition and the state transition functions handled STF_TOOMUCHCRYPTO by deleting state. This patch leaves the job to complete_v[12]_state_transition. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 8cbec5ab3ec06961102aeb9ffe35a4f754833629 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Mar 24 12:54:50 2014 -0400 use local macro to simplify ipsec_rcv.c's inbound checking commit d4dd1ded66eb784f753b8f5382fe6c1733e01378 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Mar 24 12:22:59 2014 -0400 use boolean value directly in tests, don't compare commit 5bda4fcbc86a644eec1b56df8ca569bfce33080f Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Mar 24 12:16:09 2014 -0400 make LHAS slightly easier to read ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 92eb4c7b16db595d11590303cdd9327f1b4767da Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Mar 24 14:46:22 2014 -0400 more tidying of timer.c ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 6e2ca35fdec72ca90f862a7ee99013d6f38332ec Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Mar 24 17:46:50 2014 -0400 adjust formatting of timer.c ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 3d9fac66c0a21ecf5443e1ca872e8ea9a0e8125b Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Mar 25 00:04:02 2014 -0400 scratch surface of extension type handling commit d29e3ffbd02aff4e3c07f2bf9aed9ed62e879636 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Mar 24 22:59:49 2014 -0400 PF_Key: clarify comment on limit on extension types ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit ae9b06c4dcb3c94c5ee33d99777314f43cd3dc4c Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 3 12:16:48 2014 -0400 Don't use a pointer as a boolean. LEMPTY is more appropriate than 0 as an empty set. commit 4db549bed5ec429e320a1e30cef57e96156332c1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 3 12:14:15 2014 -0400 get rid of local len in sanitize_string() -- no longer used ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 5ce3dab211129d479a8bf518191b1c237a1957a0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Apr 4 18:47:39 2014 -0400 do-while is clearer with braces ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 213722695f354722214582206257913b49a9eacf Merge: ff3295f f58b43e Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 5 03:28:03 2014 -0400 Merge branch 'master' of vault.libreswan.fi:/srv/src/libreswan Paul and I chewed on the same code. Conflicts: include/certs.h lib/libswan/certload.c programs/pluto/ikev2_x509.c programs/pluto/x509.c commit ff3295f953695d2baf83276060c1768c13f122c1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 5 03:19:46 2014 -0400 Eliminate moribund *sendcert=forcedtype feature. - simplify use of certificate types (internally we only have CERT_NONE and CERT_X509_SIGNATURE) - renamed cert_t's type field to ty -- easier to egrep - various bits of tidying that falls out of this ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 8dc4800cba11002275ac61e048210e0c247797cf Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 5 14:44:19 2014 -0400 Eliminate same_cert() (was not used). ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 0e291188b09e7c4a8fbce99171e566c0b5247b7f Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 5 15:54:11 2014 -0400 is_asn1(): - handle empty blob gracefully (avoid potential crash) - structure for clarity - make logging talk about cert blob rather than file since blob may not be from a file ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits:
commit d0f21098ee0dd6dcd64c33fd1c8727f78169b984
Author: D. Hugh Redelmeier h...@mimosa.com
Date: Sun Apr 6 00:03:26 2014 -0400
Some formatting improvements:
- ); terminating DBG call need not be on its own line
- ( and ) should generally be ( and )
- removed some redundant brackets for legibility
- added some redundant braces for legibility
- type* thing should be type *thing
- adjacent DBG invocations with identical conditions can be combined.
- } else { should be on one line
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit e5ae10c6f8907deb837cd20ea1fefacc78f1baf0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 6 00:22:55 2014 -0400 slight tidy: reduce scope of some locals, and const attribute commit 4e055812766ad9d4eb4f679035f9965ca2f3b557 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 6 00:17:24 2014 -0400 Add comment to parse_x509cert to describe memory ownership regime ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit a71bdc2a3cb7f854649201ab780ed51a0fe4a8a8 Merge: 0e98b8d 147d9a2 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Apr 7 01:04:43 2014 -0400 Merge branch 'master' of vault.libreswan.fi:/srv/src/libreswan commit 0e98b8d17e24c7222c5fe9cad1a13c7896f6ec3c Merge: 352c7ec d2acb91 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 6 21:33:23 2014 -0400 Merge branch 'master' of vault.libreswan.fi:/srv/src/libreswan commit 352c7ec0d9e4474853d223795048f8006967710c Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 6 15:49:14 2014 -0400 pick nits ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit ec941017943560c9f22f3e9b201081eb1d50b37d Merge: b8ab6bc 1d643b5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 12 22:07:00 2014 -0400 Merge branch 'master' into crypt-helper-simplify Conflicts: programs/pluto/ikev2_parent.c commit b8ab6bca5ffc5197c187336e224540d1242e25cd Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 12 21:46:36 2014 -0400 Improve v2's setting of cur_state. More work needed. commit 9f32986f3c979e304ee58a4bce0b034059f58da2 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 3 12:28:30 2014 -0400 More work on crypto helper code. - move struct qke_continuation definition from ikev1_continuations.h to pluto_crypt.h (where its brothers live). - remove unnecessary #include timer.h from some files - add prefix to names of fields in structs specializing struct pluto_crypto_req_cont - (transitional) make sure that pcrc_serialno is set before calls to Make sure that saved reference to state object is consistent. These redundancies should be eliminated by refactoring. - change quick_inI1_outR1_cryptotail so quick_inI1_outR1_cryptocontinue1 didn't have to fake a struct dh_continuation. - improve descriptions in pluto_cryptoop_strings - systematically refer to crypto helpers in logging: crypto helper %d Also crypto backlog queue and crypto request IDs. Fix some format typing too. - share code for two STF_SUSPEND cases in send_crypto_helper_request (fixing a bug with timer events). - added some explanatory comments. commit 05b44efc56024633ef83db32cc79f9e632189844 Merge: 2eb1efe a467000 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Mar 26 01:53:21 2014 -0400 Merge branch 'master' into crypt-helper-simplify Catch crypt-helper-simplify up to master commit 2eb1efeae93436e022e210f30f0d8ae579818867 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Mar 18 17:57:58 2014 -0400 Advance pluto crypto helper code. - Change send_crypto_helper_request to eliminate boilerplate in callers. - simplify send_crypto_helper_request - Clarify ownership of struct pluto_crypto_req_cont object passed in. This might avoid leaks or double-freeing. More auditing would be wise. - Removed struct pluto_crypto_worker's field pcw_reaped because it was alwaysFALSE. Simplified scattered code that referenced this. cleanup_crypto_helper is deleted. - eliminated the abuse of struct pluto_crypto_worker's pcw_pid: it is now correctly declared pthread_t and used as such (an opaque type). - simplify several functions. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 18e981d202303341176cb2dad92b1df2d27aba19 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 12 22:21:41 2014 -0400 undo obvious bugs introduced by 9540729f069ec4974ede8660fe20f7489a486bb2 ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit cb4d1316deebdec292bb94999def4c05c4cdb2bf Merge: aedad65 268c264 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 13 17:12:43 2014 -0400 Merge branch 'master' of vault.libreswan.fi:/srv/src/libreswan commit aedad650b78d3c2846bc426a84b0a8910b74d0f1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 13 02:50:44 2014 -0400 tidy lsw_process_rsa_secret ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 62a7226c10c34315be344164cddc15d4090a41a8 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Apr 15 16:14:55 2014 -0400 reduce scope of a local; ditch blank lines commit ca3b74a291e8779736a210d7834770e627922264 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Apr 15 16:13:50 2014 -0400 force alignment of allocation with unsigned long long; was unsigned long commit a285567384bdef568fd4429f717516be9d60fca5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Apr 15 16:11:36 2014 -0400 programs/pluto/plutomain.c: slight simplification ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 78a9ee43bdb1643e6b49d55dd653d6d1589dc45a Merge: c48cab1 b5f76e5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 17 00:00:22 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit c48cab195881cdee12516821fcb76f1206aebdbe Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 16 23:58:22 2014 -0400 Remove/replace references to the no-longer-implemented --force_keepalive option. (Leave its entry to point to the replacement.) commit 4969e65307e2ee1c8f1bfced5fe70b658f434fd3 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 16 17:06:21 2014 -0400 spelling fixes for ipsec.conf(5) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 03a36afbafbb1b7a97509ad78da507cee1419869 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 17 00:04:01 2014 -0400 Replace description of disable_port_floating with OBSOLETE (it's gone). commit ff4974897da3b98d193b5bea0a56d5b8603c8fab Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 17 00:02:01 2014 -0400 reduce jargon ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit bf45497f339afdfadc89a807a133e8662373f1b6 Merge: 2cc 96d89e1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 02:09:30 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 2cc2906aff99c5699840bff5cb2eaa6ca58b Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 02:07:32 2014 -0400 formatting: join most lines with just ); with the line above commit a06326708c8ee505df6dc8f4d6524c07e9597245 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 02:00:37 2014 -0400 tidy programs/pluto/virtual.c: - improve diagnostics - prevent string overflow in show_virtual_private - slightly safer deallocation of private_net_ok and private_net_ko - eliminate incomplete support for %dhcp and %ike commit e05a979212221188cfae4c7ec4efecc68b60efb8 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Apr 18 21:42:48 2014 -0400 slight improvements to pfkey code commit 5ec7042c9732b523b8e6792d4277ee9a0ee5a000 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Apr 18 20:53:07 2014 -0400 improve formatting ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 1b5c88d62da25f926a901350724f7ed4d83dd62d Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 12:20:19 2014 -0400 programs/pluto/virtual.c: ditch %4: kludge ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 1fdf522dbe229737a4d79c2810176c9628cd747b Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 16:09:35 2014 -0400 xauth: reweave conditional code with preprocessor condition ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit ef2716f518e4011cb2a0a88da7404fa8e9c8ee63 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 23:53:13 2014 -0400 minor tidy prompted by 96d89e162ea2ef24e45869749a10ce4e5d862f67 commit 2158b617be4382d7e07a72103bc6d3038681e4b5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Apr 19 22:26:57 2014 -0400 ttoaddr, tnatoaddr, ttosubnet can discover the address family based on the string If the af parameter is 0, each routine will accept either v4 or v6. This feature existed and was used, but was not documented. - added documentation to ipsec_ttoaddr(3) - replaced 0 with AF_UNSPEC to make this more evident. - modest tidying - virtual-private now uses this feature if %v4: and %v6: are missing ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit eef4698e8cb622ae3cc6167fae7760f139349751 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 20 00:49:54 2014 -0400 prevent writeconf from emitting obsolete spellings of keywords. Mark spellings with '_' as kv_alias in keyword table. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 539394fa1d5fe85d7b7acc6cd5369d73fcdccc8d Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Apr 20 22:44:24 2014 -0400 - simplify sign_hash. Improve aptness of diagnostics. - add comment to RSA_sign_hash to say it returns 0 on failure - check the result of sign_hash to make sure it is correct (0 for error, or expected length). Untested. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 31b802fcd78656eb0ce6cbd5d829c94b4f093b1d Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Apr 22 16:29:42 2014 -0400 ditch whitespace at ends of lines ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit c7166ca63417d3e8af3694b7bd707a8ee3fe2119 Merge: 57ba631 0c213e5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Apr 22 22:23:58 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 57ba631c2974f2a8b92c2833bd5765bade8fa9be Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Apr 22 17:28:19 2014 -0400 fix syntax error ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 734615e902a1b0770f551033cf0779b3e9102251 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 23 03:52:41 2014 -0400 addresspool: - simplify overlap test + no need for overlaprangev4 + will work with IPv6 (not important now) + delete useless unitize (test using it was defective) - added and exploited rangetot and RANGETOT_BUF to simplify formatting ranges - in struct ip_pool: represent range with ip_range type - added some ??? questions to code. These ought to get answered. - unified code for linger_lease_entry and free_lease_for_index as end_lease - turned several internal errors from logging to passerts. When these things go wrong, something needs fixing. - renamed find_lingering_lease to revive_lingering_lease (because that's what it does) - in revive_lingering_lease: simplify ID_NONE handling - reduce scope of buffers for formatting for DBG message components ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 3cc38bbc908fc76a0edbda4eb58fafd0613bdcc2 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 23 14:52:58 2014 -0400 - Add ip_address_eq macro to compare two ip_address values for equality - revise ip_address_cmp to correctly produce the three-way result. - clarify with comments (should there be a man page?) - replace calls to ip_address_cmp with calls to ip_address_eq where appropriate. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 0aaca3b0abc8eeec87f973a663201e4da16c727b Merge: 1eac0bb ad34d4f Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 23 18:41:33 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan Conflicts: linux/include/libreswan.h programs/pluto/addresspool.c commit 1eac0bbe7efc09ae80c6ac58d2030778b840d977 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 23 18:36:49 2014 -0400 - addrcmp now treats Address Family as most significant component - ip_address_family is for kernel code; use addrtypeof in userland - ip_address_eq is for kernel code; use sameaddr in userland - ip_address_isany is for kernel code; use isanyaddr in userland ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 642549c694fdd467d65e6dbd8094f01ae06411e7 Merge: 3ddc74a 1155519 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 24 15:51:50 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 3ddc74a9ae3aeced14a470d10df00a72e293ccac Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 24 15:48:11 2014 -0400 simplify memset to zero() where appropriate commit 39bfe3a8f30ef31c4642678d452529498bed0ea1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 24 15:46:18 2014 -0400 simplify out_raw to out_chunk where appropriate commit 26b70dda955ad5e22dad329df56fbe37395f30ea Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 24 15:45:18 2014 -0400 simplify memcmp to memeq where appropriate commit 8a4c818c76889b6af8dac196807d3a77d882e8de Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Apr 24 13:37:25 2014 -0400 Use #if 0 instead of comment to suppress code. Use tabs instead of spaces for indentation (a few places). ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits:
commit 96aaa307e17f24f7d8a4cce7f67b7b76cc307693
Author: D. Hugh Redelmeier h...@mimosa.com
Date: Thu Apr 24 16:36:27 2014 -0400
starting from an issue in ikev2_out_nat_v2n, I got a lot of places:
- ikev2_natd_lookup:
+ don't zero st-hidden_variables.st_natd after setting it
+ reorganize for clarity
- natd_hash: change port parameter to be passed in host order
(simplification)
- for V2 natd hashing, define and use IKEV2_NATD_HASH_SIZE
- ship_v2N: make spi and n_data parameters const
- use empty_chunk instead of custom constructed equivalents for ship_v2N
calls
- all calls to ship_v2N should handle failure
- all calls to ikev2_out_nat_v2n should handle failure
- in calls to ship_v2N for parent, protoid should be 0 and SPI should be
empty:
clarified calls and fixed some incorrect ones
- send_v2_notification: remove #if 0 code
/* Empty notification data section should be fine? */
- chunk_t values must not be initialized by zero() (The C standard allows
a null pointer representation to have non-zero bytes.)
- style: keep auto variables as local as possible
- style: some formatting changes:
+ in a block, declarations should come before statements
and be separated by a blank line
+ no spaces after '(' or before ')'
- style: some calls to out_raw are better done by calls to out_chunk
- style: some calls to memset are better done by calls to zero()
- style: don't use pointers in a boolean context: compare them with NULL
- style: don't use an lset_t value as an operand of !: compare it with
LEMPTY
- style: try to avoid double-negatives, they are hard to read.
It sometimes helps to flip then and else parts.
- style: almost all calls to memcmp can be simplified to calls of memeq
- style: comma is almost always followed by newline, space, or tab
Not tested.
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 85d57465024644151156cae6bae6cb2abfddc1ee Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Apr 25 03:01:35 2014 -0400 Exploit GCC's attribute warn_unused_result - wrap the attribute in a macro MUST_USE_RESULT - apply the attribute to all the packet.h functions that can return a failure indication. - Fix up the fallout. Sometimes it causes new functions to be marked with the attribute. Failures will no longer be ignored. - minor tidying when adjacent problems were noted - logging change: when padding is suppressed for CheckPoint, continue logging that, but suppress a second message. See close_message(). There are other functions that should have this attribute. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit d863ef9ae6a7bea3bda61f747611b428d045814f Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 11:52:09 2014 -0400 fix code to replace lingering lease. (time_t) -1 is not far in the future. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit be77c0ffc2046c136d8bd88cee28b3344cc6a28a Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 14:38:40 2014 -0400 Delete whacky unused macro NAT_TRAVERSAL_METHOD commit 3737a1b9dfaac6e75f7755bc6aa7f36f9ccc7ef2 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 14:35:03 2014 -0400 change uses of XAUTHLELEM to make non-overflow evident ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 63f15a89aa1981b9b01247dc9d33274d5af1156b Merge: d56e9ad 935bfe5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 17:03:38 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit d56e9adcfcdd2ac0fec46c0882bcac8752f7aa63 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 17:02:40 2014 -0400 - create enums time_t_minute, time_t_hour, time_t_day and use them - #if 0 around declarations in pluto_constants.h that duplicate ietf_constants.h We should figure out which place these belong. - add comment to point out that check_expiry is not re-entrant - improve list_public_keys() commit df7f83ee306ebe1162632a172839e547b96fbe76 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 15:07:33 2014 -0400 don't overdefine PrivateKeyKind - no need for DSS until there is a need. - let C assign the enum values (but avoid 0) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 9855e621b5caff783a01284a89b1098ec145587a Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Apr 30 17:34:28 2014 -0400 excise log_mark_time: didn't do anything (due to a bug), so we must not need it. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit d9cfa5ba0cf2e6ebcdac1102b04d5435f08278a7 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu May 1 10:53:13 2014 -0400 rename time_t_* to secs_per_* (type-agnostic) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 6b60a9866f26f101df9d87b72fa82e92d111b533 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun May 11 00:09:44 2014 -0400 fix mysterious error in ike_idtype_name by adding a comma ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 63fdefad72e55b4782b187a08e6f548a521c9039 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri May 16 15:20:21 2014 -0400 fix syntax error ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 7facd26c35399499b239cf396d8bf705652c922c Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 17 00:14:05 2014 -0400 ditch // ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 2779630fe7c02e618207de6b183adde4bfd0ece1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 17 01:51:30 2014 -0400 tidy pluto flag parsing: - use ttoul for number decoding (does better checking) - for a diagnostic, print a concise message, not full useage - centralize fatal diagnostic printing ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 03cfc1b8a5e0605c6c933b48149fa02c87e9385a Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 17 13:01:41 2014 -0400 some more improvements to pluto flag parsing ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 6b15b8d4f189b17526b74b34bc6475a55f3bb4ff Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed May 21 13:50:16 2014 -0400 fix some whitespace commit d15ddc19c12782f85ed59fb4c82a6222b1b1b5d1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed May 21 13:49:30 2014 -0400 fixes for compiler warnings ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 4e88d5716054ea0be91d5d7c61d2ed8db81e5c4f Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri May 23 02:01:23 2014 -0400 alg_info.c: slight tidy ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit c3d23ab4eea56d598d970ffade9e0afaa11c42a4 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri May 23 02:12:54 2014 -0400 simplify, in Functional Programming style ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit d8e33352f288b8a92f82bb5631608553abd04139 Merge: 1ea0d1b 24ea740 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon May 26 12:39:51 2014 -0400 Merge branch 'master' into hugh-2014may commit 1ea0d1b9cc723ad11d776d66cd8208a971a2ab19 Merge: 0b4773b 02bbc6f Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon May 26 03:09:40 2014 -0400 Merge branch 'master' into hugh-2014may commit 0b4773bc91fa92151d4dbb734b2ab4777e58e70f Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon May 26 03:06:57 2014 -0400 Superficial Tidy of NAT Traversal code - enum clarify natt_method + don't assign numbers + make clear the split in values - make st_nat_traversal officially lset_t and treat if appropriately - introduce ikev1_natd_init to remove four copies of a chunk of code. The name may be inappropriate. - replace the magic number 31 with a more robust sizeof (four places) commit a85ca04bb78c491743baa278562fd8f1152e19b5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon May 26 02:22:58 2014 -0400 simplify linux/include/libreswan/passert.h commit cb528a1fb95725a5644f72bb547ba75a310579a1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun May 25 23:00:57 2014 -0400 delete a misplaced space commit 2c7caa8147446b8f77715288c0f45d4c9ca79bfc Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 24 22:21:59 2014 -0400 delete dangling comment commit 2007c87095f4565a0ee5c4bba352673dac73b6c8 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 24 22:16:48 2014 -0400 get rid of obsolere atoul and ultoa functions commit e34731eaf9e0803ec23424530c2fb0625ab51a39 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 24 21:49:55 2014 -0400 get rid of obsolete and unused atoaddr and atosubnet (keep manpage since it documents obsolete functions still in use) commit 99b5fe89caa53cd2d12c462bc8d6c2d7f3d63fd8 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 24 21:01:31 2014 -0400 atoasr and rangetoa are obsolete and unused: delete them commit 174b02ff51d4f1b51113c7307b5ef287d757d71d Merge: 5059d59 85ee98b Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 24 20:38:55 2014 -0400 Merge branch 'master' into hugh-2014may Conflicts: include/certs.h include/secrets.h commit 5059d59e340094ae1ca4535308d2403391ec0e80 Merge: ab8a7ba 9023f55 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 24 13:48:48 2014 -0400 Merge branch 'master' into hugh-2014may commit ab8a7baa73562e25441e13501fb8fbd40967814f Merge: 72687d0 f93920d Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri May 23 15:44:14 2014 -0400 Merge branch 'master' into hugh-2014may commit 72687d00bfc2bae64551e5782117bd7089621128 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri May 23 15:02:43 2014 -0400 replace calls to *cmp functions with clearer calls to *eq functions. commit 030a33f59ca5b3806084d98abac6d33b23b73a20 Merge: 34deeaa 0a70f0d Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri May 23 14:07:14 2014 -0400 Merge branch 'master' into hugh-2014may commit 34deeaaa0887272df420aa6a89cf2585d486610e Merge: 725eeff 513ded6 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed May 21 19:51:25 2014 -0400 Merge branch 'master' into hugh-2014may Conflicts: programs/pluto/ikev1_dpd.c commit 725eeff44ab6ef2ccc9ca5c909aa8cd7de048286 Merge: 05dc0b0 cd89649 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue May 20 23:22:36 2014 -0400 Merge branch 'master' into hugh-2014may commit 05dc0b01e9c21dd80c82703a988f6473d7c48a58 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue May 20 02:06:35 2014 -0400 - get rid of obsolete atobytes, atodata (use ttodatav instead) - get rid of obsolete bytestoa, datatoa - replace many uses of atoi and strtoul with ttoul or ttoulb This results in superior error detection and reporting. - tidy eroute.c and spi.c commit 7a8218f748f4e313e6c3d0ef42ad023643e005d6 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon May 19 20:46:37 2014 -0400 - define and use ttoulb (text to unsigned long, with an upper bound) - define and use TIME_T_MAX - describe the kludge that is UNDEFINED_TIME commit 106e322adae41557c7b29fd64748d559fb33558f Merge: 3ff9f4d 2a6a185 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon May 19 20:16:59 2014 -0400 Merge branch 'master' into hugh-2014may commit 3ff9f4d175921f570901ccfc961e69780f3b7faf Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 17 16:09:31 2014 -0400 Pluto option parsing: Add information to long_opts[] and systematically use it to: - print --help (eliminating the hard-to-maintain separate table) - systematically warn about obsolete spellings - declare all but one spelling of an option obsolete Synonyms obsoleted: noklips, use-none, useklips, use
[Swan-commit] Changes to ref refs/heads/master
New commits: commit f0067c9fde6abe1b1cbd356c9c75a130360114a2 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jun 5 21:59:36 2014 -0400 ikev2_delete_desc: use ft_enum for protocol ID for better checking ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 7011601e0d28d38be05aa9adb51faf4f56332622 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 9 16:16:11 2014 -0400 simplify ikev2_parent_inR1outI2_tail ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 38297e9c7585c2c3df125b3987292d5e56cf8333 Merge: 4bb0f02 e97e1ca Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 9 17:49:08 2014 -0400 Merge branch 'master' into hugh-2014may commit 4bb0f023ffa246f29dbcc21fb231e57675a31d97 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 9 15:32:44 2014 -0400 - create and use a distinct microcode entry and state transition function for v2's DoS-mitigating (anti-spoofing) cookie - eliminate dangling pointers to struct msg_digest: add and use release_any_md - rename MAINMODE_MSGID = v1_MAINMODE_MSGID - renameINVALID_MSGID = v2_INVALID_MSGID - add and use v2_INITIAL_MSGID commit e9cbe4099fbbaa4320701869014d8ef4ce552f33 Merge: 031dc7c 82f9a78 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 9 02:36:34 2014 -0400 Merge branch 'master' into hugh-2014may commit 031dc7c7d1e645eebb432013c76bb693aca45aaa Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 9 01:47:14 2014 -0400 tweak enum event_type commit 015af87a2df8556b3daf2245500695857cb3fdd5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jun 5 16:26:57 2014 -0400 clarify comments on IKEv2 states, payloads, and protocol commit cfb1fae5beb8bd469de6fb5a247e9a6ceaf6e21c Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 2 17:55:38 2014 -0400 start tidying up events commit b47e78868c18b602d20577bc99be682caaba3b60 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 31 18:34:40 2014 -0400 fix dpd_action_names commit 2e586b2c37ca7eae5e50613f1e68aff52b7fea63 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat May 31 18:20:41 2014 -0400 henceforth = hence: use the right archaic word ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit b3af86e0f7723be25177debc736207981751fbea Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Jun 9 22:19:31 2014 -0400 tidy some more ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit b93baec07d971ed44d600a312a7c9eebdcdfeb92 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Jun 10 01:59:37 2014 -0400 whack.c: accept DPD_ACTION_uninitialized as a value of msg.dpd_action (wise?) whack.c, whackinit.c: mark diag as NEVER_RETURNS libreswan_exit_log_errno_routine: remove second NEVER_RETURNS diag(): remove statement after a call since it is unreachable and misleading diag(): remove second blank lines after calls ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit fab4ba45738b1fa2a049f5d612c143a4bfe181a0 Merge: 6200206 85f040d Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 10 17:08:50 2014 -0400 Merge branch 'master' into hugh-2014may Conflicts: programs/pluto/ikev1_main.c commit 6200206ecebd4fa267f27327894d226793ebbab0 Merge: 6fc7d34 0902f69 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 10 01:06:24 2014 -0400 Merge branch 'master' into hugh-2014may commit 6fc7d3415fb010be9ba4801f70c2a647fc472d7c Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 10 01:05:06 2014 -0400 fixes / tidying inspired by LLVM commit 9934b4c0ae32b6388046234ff9054ac6e8a9b757 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Jul 9 15:53:30 2014 -0400 obvious fixes provoked by LLVM warnings commit 42e9750ccc7bd09298001c892ec1896a7e4e553e Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Jul 9 15:27:33 2014 -0400 parser.l: simplify use of GNU glob(3) extensions commit 7f10addaf599aba7c315aa4e719c2ae056494f1e Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Jul 9 15:12:55 2014 -0400 adns.c: clearer whitespace commit 9519bdf1f8b8a6b316d9d951800090f62b5c721f Merge: 6b4d538 69fbb75 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Jul 9 15:06:29 2014 -0400 Merge branch 'master' into hugh-2014may commit 6b4d53857cd6d33d1232c3ab788f62849a772d8f Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Jul 8 13:44:20 2014 -0400 parse_ipsec_transform: clarify by replacing parameter is_ipcomp with parameter proto commit 99e98cbb5729fbef22d5ae9f8eaa4b9362778716 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jul 6 01:12:46 2014 -0400 Make crypto_req_keysize's ksproto arg an enum. Tidy. commit 485bcf0ec446135f3fbb1455bff50958f920c0ee Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jul 6 01:06:23 2014 -0400 test wrong for SA_LIFE_DURATION IPsec attribute not preceded by SA_LIFE_TYPE attribute commit d3d3df6562c91bba3abb4f454e9104b44e6c6d6a Merge: 0643ed3 3b3fe8f Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jul 6 00:07:50 2014 -0400 Merge branch 'master' into hugh-2014may commit 0643ed3e2034aaadd8acede4dd9f0685e6552ea2 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 4 20:12:19 2014 -0400 _stackmanager.in awk script: - fix indentation broken in d5a917623ce2fb58ca254dd9013c7c7a5532aa70 - slight simplification commit 4002d5a49a9d3d573e4bde85149c7913b949074e Merge: 24fefa4 42abf27 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 4 19:05:39 2014 -0400 Merge branch 'master' into hugh-2014may commit 24fefa4a9612a25b946f4a1b6279ad084f6a5ff5 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 4 19:04:19 2014 -0400 ikev2_evaluate_connection_fit: add a reference to the RFC commit 71b8ddbfe3a20c01520a2f0bad4f8e4a765fc828 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 4 02:12:40 2014 -0400 define and use startswith() and eat() for idiomatic uses of strncmp commit c8def649154a1b5ac22610e169ef24664657c338 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 4 02:09:36 2014 -0400 fix aalg_getbyname_ike bug: n, nu, and nul would spuriously match null. commit b2218df990f7a6006a45849e0e18d3828c18c1e3 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 4 01:08:00 2014 -0400 eliminate more strtoul(3) calls; make others more careful commit 7832f812f5ea273f8881463b2467204032ad1be9 Merge: c37e60a a16cb63 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 3 18:01:11 2014 -0400 Merge branch 'master' into hugh-2014may commit c37e60ab0ee46f697e14b65383cfa19996a74692 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 3 18:00:11 2014 -0400 improve comment commit 0a4d35ce598faf3cdb7d0bed91a5a012428b5f50 Merge: fd0a5f2 6dd4892 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Jun 24 21:05:16 2014 -0400 Merge branch 'master' into hugh-2014may commit fd0a5f26df7a9620d92c0afdba87a7852873b159 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Jun 24 14:05:59 2014 -0400 Fix misplaced zero() in nat_traversal_natd_lookup. Renamed nat_traversal_natd_lookup to ikev1_natd_lookup. Add natd_lookup_common with common code from nat_ikev1_natd_lookup and ikev2_natd_lookup so bugs only have to get fixed once. commit 74ccd49b412b1c621818f4ce47b01f7d0acc2df1 Merge: 8e31dd9 d6d5301 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Jun 24 13:27:46 2014 -0400 Merge branch 'master' into hugh-2014may commit 8e31dd997af4eb1ad94953f3ea657a9fee3283bb Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jun 22 17:59:52 2014 -0400 minor tidying commit 7a93d85957429c4aa3df402a2ff1f5202c8625b0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jun 22 17:59:39 2014 -0400 simplify nat_traversal_natd_lookup commit 376708f61e68964034a86ac82a8e65a9bf8f2e80 Author: D. Hugh Redelmeier h...@mimosa.com Date
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 040bb66a307fc866179e719088baa7db41f6f793 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jul 13 22:52:18 2014 -0400 add strneq(); get rid of most remaining strncmp calls ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 2546d6b363445eb5c1d044c3c9a1c20801167a35 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Jul 13 22:23:20 2014 -0400 don't call startswith() from module code: constants.h not #included Reverses part of 71b8ddbfe3a20c01520a2f0bad4f8e4a765fc828. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit e4ea8abbff565f62191cf3fbd4c24284bae85b0c Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jul 12 16:55:27 2014 -0400 Crasher: fix two free(3) calls that should have been pfree() calls. Add explanatory comment to each legitimate call to free(3) in Pluto. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 32956ea801b57e746c10a0b5d7c9b4aec45dea48 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 18 10:13:35 2014 -0400 on short read from crypto-helper: print errno if interesting ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 85f040d0a513cf13ce9de3965dce15568bc5ced5 Merge: ad6edf3 0353741 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 10 17:06:51 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit ad6edf30f493fed56466dac13d6ef3c02cd13d37 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Jul 10 16:49:43 2014 -0400 print distinct message for each reserved bit ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 59477b24f83f6c04aeb7ba9a174cbe9ffd56f73b Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Aug 7 01:32:59 2014 -0400 replace can not with clearer and idiomatic cannot commit 3c3d9844ad24f6abbe800b6c55273d36d9b83c13 Merge: 922bb6a ab0ce3f Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Aug 7 01:23:50 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 922bb6ad61418aa96248237a247aafc6c775904e Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Jul 26 10:55:16 2014 -0400 remove commented-out declarations ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 941619f6c1b66c7ec79e7cdb43efeb203d50c9ef Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Aug 18 12:08:38 2014 -0400 Each crypto continuation now logs its start if DBG_CRYPT | DBG_CONTROL. Log includes corresponding state number. Added a few elucidating comments. passert is a kind of comment, right? ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 36b3da661deed0a02ec20b4f56b6d367f0d48ab9 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Aug 3 15:43:13 2014 -0400 Improve ikev2_parse_parent_sa_body and ikev2_parse_child_sa_body - reject responder SA with multiple proposals - enforce proposal numbering rules - eliminate vestigial support for conjunction of proposals (not in RFC) - parse proposals after the winner - simplify and clarify - to do: deduplicate ikev2_parse_parent_sa_body and ikev2_parse_child_sa_body ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 70f6e844ee456a420b96138d2fb9533f247f2e9e Merge: 2067db0 1984098 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Aug 5 03:25:05 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 2067db098d8b412fc63e53595dd1740cac3ba433 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Aug 5 03:24:15 2014 -0400 Fix latent bug exposed by commit 2a45ba9ebeb85a2e7905d259c66ceb13f5a79beb selection parameter to ikev2_parse_child_sa_body had never before been TRUE so bad code for that case had never been exercised. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 600c8091cee26b73add4ce78ae44839c138e49d6 Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Jul 18 22:53:03 2014 -0400 log crypto helper queues the first time we get too busy ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 7f1a41440b5b1b54802550c5e840325c2e0e10d9 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Aug 11 21:47:51 2014 -0400 ikev2: discard packets for a state that is busy (doing crypto or DNS) Add unset_suspend macro to catch more mistakes. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 832d862e81158cd2226e19be755b0f5876751b18 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Aug 12 01:37:51 2014 -0400 pluto: clarify comment in definition of struct packet_byte_stream commit 208e71651463f5d3faeb4b4f1b078db09bdb042a Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Aug 12 01:35:46 2014 -0400 struct msg_digest: clarify which fields are specific to v1 or v2 ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit f3579ca732ea66671e1c13e6d8437ce6dc7937e4 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Aug 21 03:45:41 2014 -0400 Pluto: quick fix to compute_proto_keymat: had sense of kernel_alg_ah_auth_ok wrong ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 284e7dfabc431c982f09fd4f8d5b574a739bbbc0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Aug 13 02:34:02 2014 -0400 pluto: change some tests to explicitly compare with NULL ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 1a6cad3188041250c9d0b8326ccd18dcacc03268 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Aug 31 22:15:00 2014 -0400 pluto: slight tidy ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit ad6ad1fabda2b90f3db724be3794fb87a3b445e4 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Aug 28 01:18:17 2014 -0400 pluto: improve wording of too-tricky state comment ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 550d056ea02cfaaa7e4ffc7c1f8a33e3566e899f Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Sep 8 11:58:39 2014 -0400 pluto: kill unused functions update_ipsec_sa and update_nat_t_ipsec_esp_sa ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit cdc383d43f6a4d323617a7e088d1eed83e085c6a Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Sep 8 14:14:16 2014 -0400 fix two typos in a comment ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 86c443496857af3738b41cb47d7f65f7f98f42bf Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Sep 16 17:28:34 2014 -0400 pluto: slight simplification of ikev2_derive_child_keys ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit aa5a372670b7fc1f20e132f478507616b704e827 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Oct 5 23:32:16 2014 -0400 pluto: ikev2_spdb_struct.c get rid of redundant and confusing itl Used identically in ikev2_parse_parent_sa_body and ikev2_parse_child_sa_body commit cb1c6979f424efad215137d48a207311ed4e9a3f Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Oct 5 23:22:39 2014 -0400 pluto: replace ikev1_verify_phase2 with ikev1_verify_esp and ikev1_verify_ah commit 736b32e7b1ddbe8383d7cfbc146cc387e212ad41 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Oct 5 23:19:59 2014 -0400 pluto: fix bug in kernel_alg_show_connection commit 436139abec62f4c2ca5ff8e1788e74851c9c6c19 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Oct 5 22:24:39 2014 -0400 pluto: don't use a pointer in a boolean context ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 01e07ebb3e8bbeb4ee529c3da0e8695e7e589271 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Oct 8 01:41:11 2014 -0400 pluto: refine 2da54521cab52f4fe532d2f024e947b61661fdda ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit f13abb0ab5eb9602a1692250b2035e25ad521637 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Oct 16 17:32:53 2014 -0400 use AES_BLOCK_SIZE not AES_CBC_BLOCK_SIZE when not doing CBC commit 2cfd0a24a9c865cae0a52311e02c1b7c737831b2 Merge: 1171aef fc54783 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Oct 16 17:32:43 2014 -0400 Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan commit 1171aeff22c77e4b3d3703f480dea499fd9d94f9 Author: D. Hugh Redelmeier h...@mimosa.com Date: Thu Oct 16 17:10:50 2014 -0400 pluto: array bounds should be constant expressions. (see a9e5a65844604ac2a26bcb2d6b8526dda00273d1) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit be4fa0248db9ea354a4e38b28112464a594e2384 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Oct 21 13:37:31 2014 -0400 linux/include/klips-crypto/aes.h: fix dangerous definitions ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 083470ac01c86fa77fc81d88770913bfa305b6a1 Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Oct 28 17:46:21 2014 -0400 inspired by clang warnings: - add comments noting warnings for things we do not change For example, a redundant assignment that makes the logic clearer. - remove redundant assignments - add const a few places - remove unused status parameter from adns_reapchild - bug fix: when processing delete notification, don't delete the current state until after all notification payloads are processed. (This took a little restructuring.) - bug fix: avoid NULL deref in initiate_ondemand_body when bound_outgoing_opportunistic_connection failed - replace call to obsolete wait3(2) function with call to waitpid(2) - systematize handle_next_timer_event - properly NUL-terminate log_vid in handle_vendorid - redoo loops in get_x509crl and get_authcert so clang understands them - spi.c: TRUE is proper bool constant - tidy ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 97de0aa33182c21e40331181634a97c2a9e4d564 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Oct 29 00:38:36 2014 -0400 spi command: warn about the break added in a2791fda77a5cfcc6bc992fbc5019f4448112f88 ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 9e12d617b418ba044686ae8b97f410b4aa81f8ef Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Oct 29 00:44:14 2014 -0400 pluto: tidy some x509 code ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 4249b1af02ab6b27408179188a4c6b48bcb251d0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Oct 29 01:21:45 2014 -0400 pluto: the moredebug parameter of initiate_connection should be an lset_t ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 695af25112cdd1561e71b75cf6f054b76c66907a Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Oct 29 03:12:06 2014 -0400 pluto: clean up things associated with struct connection's dnsname field - whack.c's decoding was awkward. Borrow logic from confread.c Still not ideal: the diagostics for bad syntax are not humane in either place. - connection.c's update_host_pairs has some mysteries. - initiate.c's ISAKMP_SA_established looks wrong (asymmetry) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit db2f56ba10185976b9ba592c5e1a8325a59c6333 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Nov 15 03:59:32 2014 -0500 pluto: improve foreach_states_by_connection_func_delete debug log message - guard with DBG - format connection name and instance according to Pluto convention commit 3b2142b38c5eb9040c9dc65770822d23b50786b0 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Nov 15 03:50:25 2014 -0500 Pluto: clean up calls to fmt_conn_instance and adjacent code ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 0b02970b724d939cc804edb09bc8ea62ff9d3302 Merge: 37a7917 08fac47 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Nov 19 01:14:31 2014 -0500 Merge branch 'master' into hugh-2014oct commit 37a791774359feec6360b931822defe36405dd5f Author: D. Hugh Redelmeier h...@mimosa.com Date: Tue Nov 11 16:48:43 2014 -0500 fallout from renaming secctx-attr-value = secctx-attr-type (Mostly fixing testing reference files and sanitizer scripts) commit 73686063d3b69b21f1620bd1ce2354623f35bf83 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 10 02:15:09 2014 -0500 pluto: add new file programs/pluto/labeled_ipsec.h commit e1ee0607635f280943107cde8f96e8245e5eaca4 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 10 00:45:48 2014 -0500 pluto: major tidy of labeled ipsec code - rename secctx_attr_value = secctx_attr_type because that is more accurate - rename conf keyword secctx-attr-value = secctx-attr-type for same reason Updated documentation. Old names still work. - remodularize: move include/packet.h to programs/pluto/packet.h but break out the part used by ikeping.c into a new header, include/isakmp_hdr.h - add const attribute to many parameters carrying labels - use in_struct and out_struct for Security Context Labels in IKE packets. Much more concise and careful than hand-marshalling. - in netlink Acquire handling, accept more general structure of the message. Fix a leak too. - extensively check Security Context Labels on their way in via IKE and netlink. - add clarifying comments and comments noting puzzles - fix formatting and grammar commit 6ab2f6da4d25702560a6eea112bc69cb54661d5a Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 3 01:26:48 2014 -0500 pluto: improve parsing of SECCTX attribute commit d89a6b46882d92523480b5502a80e7f5c8a2889e Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 3 00:46:29 2014 -0500 pluto: improve whitespace in HAVE_LABELED_IPSEC code commit 0afee0b7c6f1a4df14aebc10007e7181f4ac1dcd Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Nov 2 23:13:19 2014 -0500 pluto: fix fixes for reference to uninitialized fields in output struct The was fixed in 459757b3e33a2e73454575fb2cee389414f02e87 zeroing the structs. Unfortunately, this just hides bugs. This patch fixes the two cases (bugs!) where uninitialized fields were used: out_attr and its clone ikev2_out_attr. These were actual bugs and the zero just hid them. The length member of an output struct need not be initialized. This is made more plain by the recent change to out_struct. Improve or add a few comments. commit 9504fc60e4483abe022894ce5f7681a2d3d6f8ba Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Nov 2 23:02:34 2014 -0500 pluto: rejig out_struct so length fields of the struct are never referenced (They are to be computed, but the code fetched and ignored the value in the struct.) commit 5ba0845ceec81b3cd0fea9b6387664649a3f563b Author: D. Hugh Redelmeier h...@mimosa.com Date: Sun Nov 2 22:54:28 2014 -0500 pluto: remove scary union trick from reference counting of struct alg_info commit 51d2c045b07a377febf6224e1197efefc14830f0 Merge: 696c90d 84a94a8 Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 10 01:24:37 2014 -0500 Merge branch 'master' into hugh-2014oct commit 696c90d033b16147a31f0642a467b6690b5743e6 Merge: c2dc2cf 8f48b8c Author: Antony Antony ant...@phenome.org Date: Sat Nov 1 05:44:04 2014 -0400 Merge branch 'master' into hugh-2014oct ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 4c2054a549097543c9f243bb8f29e51cd31e8283 Author: D. Hugh Redelmeier h...@mimosa.com Date: Wed Nov 26 01:46:46 2014 -0500 testing/scripts: work at making readwriteconf-* tests runable ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 42676c0eeb039ffe6fecd996809dce755d108e7f Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 24 16:40:58 2014 -0500 config parser grammar: make empty version rule clear commit 6586a985cd73ceafc980a09c8ee78d72bffb Author: D. Hugh Redelmeier h...@mimosa.com Date: Mon Nov 24 16:33:15 2014 -0500 conf file lexer: clean up formatting ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit b892803c3ef1a0ed62526d25099d21f61a1b8a45 Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Dec 6 18:26:01 2014 -0500 lib/libipsecconf: poke and prod parser.l: - Improve include processing and diagnostics. - simplify lexical grammar - correct signed/unsigned mixup in formats - sprinkle static - use bool where appropriate - partialy tidy parser.y: - simplify grammar - Get rid of a shift/reduce and a reduce/reduce conflict - fix problem with EOF based on patch by lkundrak https://github.com/lkundrak/libreswan/commit/9be0e2ab88b2573b742b24c404bc889f01c40a55 Handling of FIRST_SPACES EOL is still a bit kludgy - detect overflow on numeric scaling - properly bound snprintf output buffers - sprinkle static - partialy tidy confread.c: - slightly improve on message starter: case KH_NOTSET: empty - partialy tidy starterlog.c: - simplify commit a25e2026804edf5947fb2c2b03a481058fb5549c Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Dec 6 17:59:59 2014 -0500 readwriteconf: improve error handling - include invocation name in usage and error messages - treat an unexpected argument as an error - send error messages to stdout - exit after errors in usage commit cd549eb9b1d4ace9a72bc6b1c3871fa9abf6ab9f Author: D. Hugh Redelmeier h...@mimosa.com Date: Fri Dec 5 01:56:44 2014 -0500 libipsecconf: formats for starter_log() should not end with \n ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
[Swan-commit] Changes to ref refs/heads/master
New commits: commit 6bb5109f46b673c813062edf841733614cf52dfc Author: D. Hugh Redelmeier h...@mimosa.com Date: Sat Dec 6 18:50:30 2014 -0500 pluto: make /* FALL THROUGH */ comments consistent ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-commit
