[Synfig-devl] Synfig instability since 47fce282611fbba1044921d22ca887f9b53ad91a
Hi! Last time we're working with synfig very intensively and noticed a huge difference in stability between a75d39ae6509cd7b24e8924ffab41e8014591a8f and 47fce282611fbba1044921d22ca887f9b53ad91a commits. To be more specific: starting from 47fce282611fbba1044921d22ca887f9b53ad91a Synfig Studio is crashes often alot. It's hard to reproduce crashes, they happen randomly, but in most cases symptoms are: - crash when moving time cursor on a timeline - freezing or crashing when manipulating waypoints - freezing at closing applications I experience this issues when working on shot 20 - that means working with imported bitmaps, canvas switches and stickman, manipulating waypoints and keyframes. Also there's a reports of crashes during tracing bitmaps with blines. I can't offer recipe to reproduce crashes, because I repeat - they happen at random basis. But we always switching packages corresponding to those commits and the statistic is significant. I want to ask - if someone who work intensively last time with synfig experiencing something similar with latest revisions? Could someone confirm that by making some tests? I could offer a packages we use for that commits, but the experiment will be more fair if person willing to test will build synfig for himself. My proposal is: 1. revert commits 2fde73ebec7ee1bcb147abc19d16b1bc0deb17bf and 47fce282611fbba1044921d22ca887f9b53ad91a in master branch 2. put mentioned commits in separate branch so they will not lost and maybe someone will fix them in the future. Cheers! Konstantin. -- http://morevnaproject.org/ -- ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
Re: [Synfig-devl] Review Request: Add FPS preferences to the Setup Dialog
On 2009-06-24 01:02:18.740623, Gerco Ballintijn wrote: Unfortunately, I cannot view the patch using this site. It complaints about the use of control characters. I'm not sure whether its about the i18n characters in your name. So, I cannot comment in place. In general the patch is good enough, but I have two issues. I prefer a bit more whitespace. In particular a space after commas and before and after infix operations. I would like that to become part of the Synfig styleguide. Also, have you investigated why Gtk uses the comma instead of the dot in the combo box widget? Does it have to do with i18n/l10n? Carlos Lopez Gonzalez wrote: It is not a good new to hear that you cannot properly use this patch tracker to comment in place. I have not idea what's the reason. If it is needed I'll remove all my accented letters from the diffs and from any information I have in my account. I hope it would help. Regarding the more whitespace (I guess you are talking on the code style) it is not a problem to me. I prefer it too. Also a white space after a comma and infix operations is a good idea. I'll try to fix it in this patch and keep in mind in the future. Regarding to the dot in the combo box widgets it is due to when I use atof with a 24.976 string I obtain 24 and when I do it with a 24,976 string I obtain the correct value. As you can check there are lots of dot comma inconsistence in the .synfig/setup file. Many values are dots and many are commas. I have for example several different formats for the saved settings of the wacom device. Maybe i can just to it reverse: create the strings to show based on a formatted printf operation using double variables. Let's see what I obtain. Do you think I can commit it, anyway? Carlos Lopez Gonzalez wrote: I have found that the format shown in the widgets depends on what's the local preferences you use. I have the comma for decimal preference (I hate it but it is Spanish standard). When I run synfigstudio I see comma separator for the brush size for example. When I run LANG=C synfigstudio I see dot decimal separator. So I've modified the patch to insert the strings according the current decimal separator used when the program runs. Doing that it will be consistent always and don't produce a bug when you run the program in other language than Spanish. Thanks for pointing it out. I'll attach a new patch. I keep the same base for the branch. Issues with diff view are fixed now. - Konstantin --- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/30/#review81 --- On 2009-06-24 11:37:47.735809, Carlos Lopez Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/30/ --- (Updated 2009-06-24 11:37:47.735809) Review request for Synfig. Summary --- Include predefined and preferred FPS in the Setup Dialog. Also modify the behavior of the spin buttons for preferred x and y canvas size for new documents to be sensitive only if Custom size is selected. Diffs - synfig-studio/trunk/src/gtkmm/app.h 507bc75 synfig-studio/trunk/src/gtkmm/app.cpp 3099c44 synfig-studio/trunk/src/gtkmm/dialog_setup.h e0d8fcd synfig-studio/trunk/src/gtkmm/dialog_setup.cpp 9f849b0 Diff: http://patches.synfig.org/r/30/diff Testing --- Compile, runs and save and load preferences fine. Preferences are properly reflected on new created documents. Screenshots --- Modified SetUp Dialog - Document tab http://patches.synfig.org/r/30/s/5/ Thanks, Carlos -- ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
[Synfig-devl] Synfig Irregular News
We are glad to inform you that another digest of the Synfig irregular news are out. This digest is about things happening around synfig (SVN, IRC, Lists, wiki) since the last news update. Please visit the news item on our website: http://synfig.org/News/2009-03-22 . Thanks, Konstantin Dmitriev -- ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
Re: [Synfig-devl] Review Request: Add FPS preferences to the Setup Dialog
Konstantin Dmitriev wrote: On 2009-06-24 01:02:18.740623, Gerco Ballintijn wrote: Unfortunately, I cannot view the patch using this site. It complaints about the use of control characters. I'm not sure whether its about the i18n characters in your name. So, I cannot comment in place. In general the patch is good enough, but I have two issues. I prefer a bit more whitespace. In particular a space after commas and before and after infix operations. I would like that to become part of the Synfig styleguide. Also, have you investigated why Gtk uses the comma instead of the dot in the combo box widget? Does it have to do with i18n/l10n? Carlos Lopez Gonzalez wrote: It is not a good new to hear that you cannot properly use this patch tracker to comment in place. I have not idea what's the reason. If it is needed I'll remove all my accented letters from the diffs and from any information I have in my account. I hope it would help. Regarding the more whitespace (I guess you are talking on the code style) it is not a problem to me. I prefer it too. Also a white space after a comma and infix operations is a good idea. I'll try to fix it in this patch and keep in mind in the future. Regarding to the dot in the combo box widgets it is due to when I use atof with a 24.976 string I obtain 24 and when I do it with a 24,976 string I obtain the correct value. As you can check there are lots of dot comma inconsistence in the .synfig/setup file. Many values are dots and many are commas. I have for example several different formats for the saved settings of the wacom device. Maybe i can just to it reverse: create the strings to show based on a formatted printf operation using double variables. Let's see what I obtain. Do you think I can commit it, anyway? Carlos Lopez Gonzalez wrote: I have found that the format shown in the widgets depends on what's the local preferences you use. I have the comma for decimal preference (I hate it but it is Spanish standard). When I run synfigstudio I see comma separator for the brush size for example. When I run LANG=C synfigstudio I see dot decimal separator. So I've modified the patch to insert the strings according the current decimal separator used when the program runs. Doing that it will be consistent always and don't produce a bug when you run the program in other language than Spanish. Thanks for pointing it out. I'll attach a new patch. I keep the same base for the branch. Issues with diff view are fixed now. Yes, indeed, and the screenshot preview now also seems to work! Well done! Gerco. -- ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
[Synfig-devl] Chris Norman : Fixing user name...
Module: synfig Branch: master Commit: 9b193ca30b3f4912d45fa8c4a55ad8fc6cff1e25 URL: http://synfig.git.sourceforge.net/git/gitweb.cgi?p=synfig;a=commit;h=9b193ca30b3f4912d45fa8c4a55ad8fc6cff1e25 Author: Chris Norman pxe.g...@gmail.com Date: Fri Jul 3 19:56:18 2009 -0700 Fixing user name... Signed-off-by: Chris Norman pxe.geek_s...@gmail.com --- synfig-studio/trunk/test.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/synfig-studio/trunk/test.txt b/synfig-studio/trunk/test.txt index 1c999d2..d52c75c 100644 --- a/synfig-studio/trunk/test.txt +++ b/synfig-studio/trunk/test.txt @@ -1 +1 @@ -Deleteme... Just checking Git commit \ No newline at end of file +Deleteme... Just checking Git commit... fixing username \ No newline at end of file -- ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
