Re: [Tails-dev] #5594: tails-greeter: better administration password UI
hi, intrigeri wrote (11 Dec 2014 17:19:37 GMT) : anonym wrote (08 Dec 2014 09:16:06 GMT) : I guess what you want is that whenever one of the password fields are modified we do something like: if len(auth_password) == 0 and len(test_password) == 0: self.warning_area_pw_mismatch.hide() self.warning_area_pw_match.hide() elif auth_password == test_password: self.warning_area_pw_mismatch.hide() self.warning_area_pw_match.show() elif auth_password != test_password: self.warning_area_pw_mismatch.show() self.warning_area_pw_match.hide() Ok? ENOTIME to check this right now, but the example implementation I've been refering to lives in the update_passphrase_ui sub, in lib/Tails/Persistence/Step/Bootstrap.pm, in our persistence-setup repo. I'm calling this a UX design issue, and flagged the ticket as such. In the revamped Greeter mockups, I see a green checked/valid icon, and a red cancel/invalid one, so I'll assume that the people working on that front have this topic in mind, and have reparented this ticket to be on their radar. Same for the caps lock thing (#5917). Cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
anonym wrote (08 Dec 2014 09:16:06 GMT) : I guess what you want is that whenever one of the password fields are modified we do something like: if len(auth_password) == 0 and len(test_password) == 0: self.warning_area_pw_mismatch.hide() self.warning_area_pw_match.hide() elif auth_password == test_password: self.warning_area_pw_mismatch.hide() self.warning_area_pw_match.show() elif auth_password != test_password: self.warning_area_pw_mismatch.show() self.warning_area_pw_match.hide() Ok? ENOTIME to check this right now, but the example implementation I've been refering to lives in the update_passphrase_ui sub, in lib/Tails/Persistence/Step/Bootstrap.pm, in our persistence-setup repo. Cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
On 06/12/14 12:33, intrigeri wrote: Given that the semantics of the fields are pretty different in the Greeter compared to in t-p-s, please provide a detailed description of how you think the Greeter should be changed in case you still think it's desirable. What I had in mind is: a. I click More options b. I see the more options screen c. I type an admin password d. I type it again in the Confirm field e. while I'm typing it, and then while I'm wondering whether I want to select other options, I'm told if I didn't type the same password twice Yeah this much was pretty obvious; I need details for exactly how e works. I guess what you want is that whenever one of the password fields are modified we do something like: if len(auth_password) == 0 and len(test_password) == 0: self.warning_area_pw_mismatch.hide() self.warning_area_pw_match.hide() elif auth_password == test_password: self.warning_area_pw_mismatch.hide() self.warning_area_pw_match.show() elif auth_password != test_password: self.warning_area_pw_mismatch.show() self.warning_area_pw_match.hide() Ok? Cheers! ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
Hi, [sorry it took me so long to come back to this..] anonym wrote (13 May 2014 09:45:43 GMT) : 12/05/14 17:41, intrigeri wrote: The rest of the suggested changes make sense to me. The t-p-s UI is way nicer, with a nice little warning dynamically updated as long as entered password confirmation does not match. And I stole it from GNOME Disks, iirc, which makes the UX more consistent. Note that we have some form of dynamic behaviour for the error (from commit c96200f [1]) but that it's not exactly the same as in t-p-s; the mis-match error is only shown after trying to login when the fields differ, and the error is immediately removed when one of the fields change. That's not what I call dynamic: the idea behind this ticket was indeed to provide feedback *before* clicking on the Log in button, just like many forms on the web these days validate input with JS as they're being filled. IMHO this is a better behaviour than always showing it, at least in the Greeter's context where we do not have a default error to show (like passphrase can't be empty in t-p-s). I'm curious why :) Given that the semantics of the fields are pretty different in the Greeter compared to in t-p-s, please provide a detailed description of how you think the Greeter should be changed in case you still think it's desirable. What I had in mind is: a. I click More options b. I see the more options screen c. I type an admin password d. I type it again in the Confirm field e. while I'm typing it, and then while I'm wondering whether I want to select other options, I'm told if I didn't type the same password twice I'll add this discussion's conclusions to the ticket once we reach any. Cheers! -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
14/05/14 11:00, Andres Gomez Ramirez wrote: But the patch is compound of two parts: one for obligatory password and other that checks for admin password matching. I think this last part could be keep. Sorry, but I don't get it. I've looked as best I can on the patch, and the only other thing it does is to renaming the old warning stuff to warning_match, to be more consistent with the new warning_empty. No new functionality as far as I can see. Am I mistaken? Cheers! ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
oh yes you are right, ok drop it all. cheers. From: Tails-dev [tails-dev-boun...@boum.org] on behalf of anonym [ano...@riseup.net] Sent: 14 May 2014 13:01 To: The Tails public development discussion list Subject: Re: [Tails-dev] #5594: tails-greeter: better administration password UI 14/05/14 11:00, Andres Gomez Ramirez wrote: But the patch is compound of two parts: one for obligatory password and other that checks for admin password matching. I think this last part could be keep. Sorry, but I don't get it. I've looked as best I can on the patch, and the only other thing it does is to renaming the old warning stuff to warning_match, to be more consistent with the new warning_empty. No new functionality as far as I can see. Am I mistaken? Cheers! ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
anonym wrote (13 May 2014 09:45:43 GMT) : Given that the semantics of the fields are pretty different in the Greeter compared to in t-p-s, please provide a detailed description of how you think the Greeter should be changed in case you still think it's desirable. I'll do this when I'm back, around May 24. So, I've dropped the 1.1 milestone from the ticket, reassigned to me, and marked as needing more info. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
30/03/14 19:22, Andres Gomez Ramirez wrote: Hi, Do you think you could rebase your patch on top of the wheezy branch of the greeter, and test it in an (experimental) Wheezy-based ISO? You can download such an ISO on http://nightly.tails.boum.org/build_Tails_ISO_feature-wheezy/ yes, done. I've reviewed and tested the patch, and it implements what we have asked for in the ticket, but I leaves the following now false statement in the `password_header` label: Otherwise it will be disabled for better security. That part should be removed, since your patch makes it impossible to leave these fields empty. However, after actually testing that new behaviour, I'm not so sure what we ask for in the ticket is anything good. Let me quote the ticket: Hook tails-persistence-setup's update_passphrase_ui dynamic warning system in. That is, add to the greeter's admin password and confirmation entry process the same kind of UX than the one used in t-p-s to choose a passphrase: can't be empty, must enter twice the same passphrase, etc. Comparing t-p-s' update_passphrase_ui with what we currently have in the Greeter (before Andres' patch), we see the only missing thing is the [password] can't be empty check. (As for the etc part, there's a TODO about checking the password's strength, nothing more.) That makes a lot of sense in t-p-s since we *force* the persistent container to be encrypted with a password. But for the Greeter's *optional* admin password I'm note sure it makes sense. Previously, leaving the fields empty meant that the admin password was left as-is, i.e. disabled. What we (perhaps unknowingly) ask for in the ticket is to instead *force* the user to set an admin password whenever s/he clicks more options, even if s/he is only interested in some of the *other* options, or just wanted to look at what's available and actually would like to boot with the defaults. IMHO this change is a severe loss of functionality, and either: 1. we have to admit that requesting this was a mistake, and keep the current behaviour. 2. we have to add a checkbox (Enable an administration password), and show the password fields if and only if it's checked. Then the [password] can't be empty check makes sense. 3. I've completely misunderstand what the ticket asks for. I believe it was you, intrigeri, who filed the ticket (before it was imported to redmine). Could you please elaborate on the purpose and arguments for this change, if this is what you actually intended? As an argument for 1, overloading the fields' semantics with empty = disabled is a pretty convenient and elegant solution. As an argument for 2, having the fields hidden unclutters the UI a bit and perhaps makes it clearer that entering a password is not mandatory (for users that don't read or understand the text above the fields). Using a checkbox also makes it more consistent with the other options, FWIW. I personally think I'm in favour of going with 1. Does any one have any other good arguments for 2? Does any one with user testing experience have anything to say about the arguments for 2 I proposed (I've seen no evidence that there's much confusion with the current UI)? If we end up going with 2 I'd be happy to implement it on top of Andres' patch. I for one at least admit that I've made a huge mistake in not realising this earlier... I guess my brain shut off when it saw [password] can't be empty since that generally is a great idea, and I just accepted it uncritically. No matter the outcome, I'm really sorry about all this, Andres! Cheers! ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
anonym wrote (12 May 2014 15:02:45 GMT) : That makes a lot of sense in t-p-s since we *force* the persistent container to be encrypted with a password. But for the Greeter's *optional* admin password I'm note sure it makes sense. I don't think it makes any sense. Sorry, I'm probably the one who wrote a misleading (not to say: stupid) description on this ticket. IMHO this change is a severe loss of functionality, and either: 1. we have to admit that requesting this was a mistake, and keep the current behaviour. As far as can't be empty is concerned, right, we should keep the current behaviour. 3. I've completely misunderstand what the ticket asks for. I believe it was you, intrigeri, who filed the ticket (before it was imported to redmine). Could you please elaborate on the purpose and arguments for this change, if this is what you actually intended? The rest of the suggested changes make sense to me. The t-p-s UI is way nicer, with a nice little warning dynamically updated as long as entered password confirmation does not match. And I stole it from GNOME Disks, iirc, which makes the UX more consistent. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
Hi, I attached a new patch for Feature #5594 tails-greeter: better administration password UI. Sorry for the huge delay, i had some days off. Cheers. From: tails-dev [tails-dev-boun...@boum.org] on behalf of intrigeri [intrig...@boum.org] Sent: 04 March 2014 12:05 To: The Tails public development discussion list Subject: Re: [Tails-dev] #5594: tails-greeter: better administration password UI Andres Gomez Ramirez wrote (22 Feb 2014 18:10:41 GMT) : In the patch you use at least one untranslated string in +self.warning_label.set_markup(iPassword must not be empty./i) but possibly also in +self.warning_label.set_markup(iPasswords do not match./i) In the latter case you actually set it to the default text for `warning_label` as defined in the glade file, so maybe it works. I'm no glade expert, but I think the way you'll have to go is to create two `warning_label`, one for each warning, and `show()`/`hide()` them appropriately. I'd be glad if someone more familiar with glade could chime in if there's a better approach. so the idea is to add translatable string to the labels, ok. Any news on this? The feature freeze for Tails 0.23 is coming real soon now. btw I'm having problems to access labs.riseup.net with firefox 27.0.1, there is an error with the certificate (?): labs.riseup.net uses a commercial certificate again, so this should be fixed. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org. From 8d6d0a20f37f463172b10f039aa60f7450ab91e2 Mon Sep 17 00:00:00 2001 From: kurono andres.go...@cern.ch Date: Sun, 30 Mar 2014 14:57:55 +0200 Subject: [PATCH] Fix for 5594: tails-greeter: better administration password UI --- GdmGreeter/optionswindow.py | 21 +++ glade/optionswindow.glade | 47 --- 2 files changed, 57 insertions(+), 11 deletions(-) diff --git a/GdmGreeter/optionswindow.py b/GdmGreeter/optionswindow.py index 5a2459b..15eec80 100644 --- a/GdmGreeter/optionswindow.py +++ b/GdmGreeter/optionswindow.py @@ -20,7 +20,8 @@ -import logging, gtk, os +import logging, gtk, gettext, os +_ = gettext.gettext import GdmGreeter from GdmGreeter.language import TranslatableWindow from helpwindow import HelpWindow @@ -37,8 +38,8 @@ class OptionsWindow(TranslatableWindow): builder.connect_signals(self) self.entry_password = builder.get_object(password_entry) self.entry_password2 = builder.get_object(password_entry2) -self.warning_label = builder.get_object(warning_label) -self.warning_area = builder.get_object(warning_area) +self.warning_area_empty = builder.get_object(warning_area_empty) +self.warning_area_match = builder.get_object(warning_area_match) self.camouflage_checkbox = builder.get_object(camouflage_checkbox) self.macspoof_checkbox = builder.get_object(macspoof_checkbox) self.macspoof_checkbox.set_active(True) @@ -53,7 +54,8 @@ class OptionsWindow(TranslatableWindow): self.entry_password2.set_visibility(False) def cb_pw_changed(*args): -self.warning_area.hide() +self.warning_area_empty.hide() +self.warning_area_match.hide() # compact the window self.window.resize(1, 1) @@ -114,10 +116,13 @@ class OptionsWindow(TranslatableWindow): Validate the selected options auth_password = self.entry_password.get_text() test_password = self.entry_password2.get_text() -passwords_match = test_password == auth_password -if not passwords_match: -self.warning_area.show() -return passwords_match +if len(auth_password) == 0 or len(test_password) == 0: +self.warning_area_empty.show() +return False +elif not auth_password == test_password: +self.warning_area_match.show() +return False +return True def set_options_and_login(self): Activate the selected options if they are valid diff --git a/glade/optionswindow.glade b/glade/optionswindow.glade index 1632b62..a3ad0ea 100644 --- a/glade/optionswindow.glade +++ b/glade/optionswindow.glade @@ -227,12 +227,12 @@ Otherwise it will be disabled for better security./property /packing /child child - object class=GtkHBox id=warning_area + object class=GtkHBox id=warning_area_empty property name
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
Hi, Andres Gomez Ramirez wrote (30 Mar 2014 13:26:46 GMT) : Hi, I attached a new patch for Feature #5594 tails-greeter: better administration password UI. Thanks! The next release (1.0) will be a point-release, and I don't think this qualifies as a bugfix worth including in it, so I'll assume this is targetted at 1.1, based on Wheezy. Do you think you could rebase your patch on top of the wheezy branch of the greeter, and test it in an (experimental) Wheezy-based ISO? You can download such an ISO on http://nightly.tails.boum.org/build_Tails_ISO_feature-wheezy/ Once this is done, please reassign to anonym (acting as the release manager for 1.1) and set the milestone field to 1.1. Thanks in advance! Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
Andres Gomez Ramirez wrote (22 Feb 2014 18:10:41 GMT) : In the patch you use at least one untranslated string in +self.warning_label.set_markup(iPassword must not be empty./i) but possibly also in +self.warning_label.set_markup(iPasswords do not match./i) In the latter case you actually set it to the default text for `warning_label` as defined in the glade file, so maybe it works. I'm no glade expert, but I think the way you'll have to go is to create two `warning_label`, one for each warning, and `show()`/`hide()` them appropriately. I'd be glad if someone more familiar with glade could chime in if there's a better approach. so the idea is to add translatable string to the labels, ok. Any news on this? The feature freeze for Tails 0.23 is coming real soon now. btw I'm having problems to access labs.riseup.net with firefox 27.0.1, there is an error with the certificate (?): labs.riseup.net uses a commercial certificate again, so this should be fixed. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] #5594: tails-greeter: better administration password UI
06/02/14 00:31, Andres Gomez Ramirez wrote: I attached a patch for #5594: tails-greeter: better administration password UI https://labs.riseup.net/code/issues/5594 Thanks for the patch! In the patch you use at least one untranslated string in +self.warning_label.set_markup(iPassword must not be empty./i) but possibly also in +self.warning_label.set_markup(iPasswords do not match./i) In the latter case you actually set it to the default text for `warning_label` as defined in the glade file, so maybe it works. I'm no glade expert, but I think the way you'll have to go is to create two `warning_label`, one for each warning, and `show()`/`hide()` them appropriately. I'd be glad if someone more familiar with glade could chime in if there's a better approach. Cheers! ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
[Tails-dev] #5594: tails-greeter: better administration password UI
Hello, I attached a patch for #5594: tails-greeter: better administration password UI https://labs.riseup.net/code/issues/5594 Cheers, AndresFrom 21a3920dda03d0f6048aaca5ffd07da1248e843b Mon Sep 17 00:00:00 2001 From: kurono andres.go...@cern.ch Date: Wed, 5 Feb 2014 18:26:35 -0500 Subject: [PATCH] tails-greeter: better administration password UI --- GdmGreeter/optionswindow.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/GdmGreeter/optionswindow.py b/GdmGreeter/optionswindow.py index 9042cb9..f8d7633 100644 --- a/GdmGreeter/optionswindow.py +++ b/GdmGreeter/optionswindow.py @@ -62,10 +62,16 @@ class OptionsWindow(TranslatableWindow): Validate the selected options auth_password = self.entry_password.get_text() test_password = self.entry_password2.get_text() -passwords_match = test_password == auth_password -if not passwords_match: + +if len(auth_password) == 0 or len(test_password) == 0: +self.warning_label.set_markup(iPassword must not be empty./i) +self.warning_area.show() +return False +elif not auth_password == test_password: +self.warning_label.set_markup(iPasswords do not match./i) self.warning_area.show() -return passwords_match +return False +return True def set_options_and_login(self): Activate the selected options if they are valid -- 1.7.9.5 ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
