Re: [Tails-dev] Iceweasel backports experiments
24/10/12 08:08, intrigeri wrote: anonym wrote (23 Oct 2012 22:43:40 GMT) : That's not good for the Unsafe Browser, so I made a branch feature/unsafe_browser_name in which the title is set to Unsafe Browser (gettext:ized). I think I got the detection of which Iceweasel translation that will be used (depending on $LANG) right, which arguably is the most complex part of this procedure. Even if this turns out to not be necessary this name change is a general improvement IMHO. This is great. Given this is not necessary eventually, I suggest that either someone reviews and merges into *devel* right now, or you file a todo/qa ticket so that we don't forget about it at post-0.14 times. I tested starting the Unsafe Browser in a current experimental build for every locale that can be selected in the menu in Tails Greeter, plus a few Other locales, and all of them displayed Unsafe Browser in the title as expected. Could someone that trusts my tests or want to replicate them (it took only a few minutes by running in a VM and saving/restoring state to Tails Greeter) please merge this into devel? It this isn't done before Friday I suppose I create that reminder ticket... *grumble* :) Cheers! ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Iceweasel backports experiments
intrigeri: berta...@ptitcanardnoir.org wrote (20 Sep 2012 17:30:51 GMT) : On Thu, Sep 20, 2012 at 01:26:23PM -0400, Robert Ransom wrote: On 9/20/12, berta...@ptitcanardnoir.org berta...@ptitcanardnoir.org wrote: I've imported all of them but four that I felt weren't necessary: * 0007-Make-Tor-Browser-exit-when-not-launched-from-Vidalia.patch Do not omit this patch. But in Tails, the browser isn't started by vidalia. Is there another reason I don't get? Yes, but I only understand it now. Or at least, I think I do. This patch prevents us from running a torbrowser-like Firefox (in our case, iceweasel + torbrowser patches) without the torbrowser.version variable set. That combination does not make sense, and probably never got any serious exposure to testing = we do want to have the torbrowser.version variable set, and this patch will be our safeguard, making sure we don't drop the variable by mistake some day. Did you have specific ideas for the Unsafe browser while writing that? If I understood correctly, having that patch applied in our binary means we will need to set 'torbrowser.version' even for the Unsafe browser. This might not be a problem in itself, but this would be quite confusing, wouldn't it? -- Ague pgpuc0DGumB6k.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Iceweasel backports experiments
Hi, berta...@ptitcanardnoir.org wrote (20 Sep 2012 17:30:51 GMT) : On Thu, Sep 20, 2012 at 01:26:23PM -0400, Robert Ransom wrote: On 9/20/12, berta...@ptitcanardnoir.org berta...@ptitcanardnoir.org wrote: I've imported all of them but four that I felt weren't necessary: * 0007-Make-Tor-Browser-exit-when-not-launched-from-Vidalia.patch Do not omit this patch. But in Tails, the browser isn't started by vidalia. Is there another reason I don't get? Yes, but I only understand it now. Or at least, I think I do. This patch prevents us from running a torbrowser-like Firefox (in our case, iceweasel + torbrowser patches) without the torbrowser.version variable set. That combination does not make sense, and probably never got any serious exposure to testing = we do want to have the torbrowser.version variable set, and this patch will be our safeguard, making sure we don't drop the variable by mistake some day. Robert, if there's another reason we did not guess alone, please clarify what you meant with Do not omit this patch. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Iceweasel backports experiments
On 9/20/12, berta...@ptitcanardnoir.org berta...@ptitcanardnoir.org wrote: Then by curiosity, I tried to see if Torbrowser's patches apply in Iceweasel source tree, starting from the current squeeze-backports version. And it appears they are. I've imported all of them but four that I felt weren't necessary: * 0007-Make-Tor-Browser-exit-when-not-launched-from-Vidalia.patch Do not omit this patch. * 0012-Rebrand-Firefox-to-TorBrowser.patch * 0014-Add-DDG-and-StartPage-to-Omnibox.patch * 0019-Adapt-Steven-Michaud-s-Mac-crashfix-patch.patch (related to OSX) This patch appears to be required on all OSes. Robert Ransom ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Iceweasel backports experiments
On Thu, Sep 20, 2012 at 01:26:23PM -0400, Robert Ransom wrote: On 9/20/12, berta...@ptitcanardnoir.org berta...@ptitcanardnoir.org wrote: Then by curiosity, I tried to see if Torbrowser's patches apply in Iceweasel source tree, starting from the current squeeze-backports version. And it appears they are. I've imported all of them but four that I felt weren't necessary: * 0007-Make-Tor-Browser-exit-when-not-launched-from-Vidalia.patch Do not omit this patch. But in Tails, the browser isn't started by vidalia. Is there another reason I don't get? * 0012-Rebrand-Firefox-to-TorBrowser.patch * 0014-Add-DDG-and-StartPage-to-Omnibox.patch * 0019-Adapt-Steven-Michaud-s-Mac-crashfix-patch.patch (related to OSX) This patch appears to be required on all OSes. Ah, the header was quite specific about OSX, will investigate this, thanks. bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Iceweasel backports experiments
Hi, berta...@ptitcanardnoir.org wrote (10 Sep 2012 21:13:20 GMT) : The build went almost fine appart from a few tests that failed. I don't know if they are green in the iceweasel from wheezy. FWIW, I tried running grep -w -c TEST-UNEXPECTED-FAIL on both your backport log and the current wheezy one [0], and the result is: - 190 for the build of the package that's currently in Wheezy - 666 (no kidding) for your backport [0] https://buildd.debian.org/status/logs.php?pkg=iceweaselver=10.0.7esr-2arch=i386 ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
