Re: [tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr
--- Begin Message --- On Jul 17, 2022, at 3:39 PM, Bill Fenner wrote: > IMO it is safe to drop support for OSes lacking native IPv6 support. Yeah. Back when IPv6 support was added to tcpdump, it was an experimental new technology and the configure script had to figure out which of several add-on IPv6 packages you had installed. Now a significant amount of Wikipedia vandalism comes from IPv6 addresses rather than IPv4 addresses. :-)--- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr
--- Begin Message --- On Sun, Jul 17, 2022 at 3:30 PM Guy Harris via tcpdump-workers < tcpdump-workers@lists.tcpdump.org> wrote: > > Should we care about it, or should we just drop support for OSes lacking > native IPv6 support in 5.0? IMO it is safe to drop support for OSes lacking native IPv6 support. Bill --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr
--- Begin Message --- On Jul 17, 2022, at 11:09 AM, Francois-Xavier Le Bail wrote: > Remain some stuff about 'struct in6_addr'. Any need to keep them? > > $ git grep -l 'struct in6_addr' > CMakeLists.txt > cmakeconfig.h.in > config.h.in > configure > configure.ac > netdissect-stdinc.h That's there for the benefit of OSes whose APIs don't have standard IPv6 support; if there are any left that we care about (or if there are old non-IPv6 versions we care about for any OSes we support), then it might be useful, but I'm not sure it would build (we use gethostbyaddr(), so *maybe* it'll compile, and maybe gethostbyaddr() will fail when passed AF_INET6 and the code will just show the IPv6 address rather than a name). Should we care about it, or should we just drop support for OSes lacking native IPv6 support in 5.0? --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr
--- Begin Message --- On 17/07/2022 19:57, Guy Harris wrote: > On Jul 17, 2022, at 10:10 AM, Francois-Xavier Le Bail via tcpdump-workers > wrote: > >> The current nd_ipv4 and nd_ipv6 types were added in 2017 for alignment >> reasons. >> >> Since then, >> most of the 'struct in_addr' were replaced by 'nd_ipv4', >> most of the 'struct in6_addr' were replaced by 'nd_ipv6'. >> >> Remain: >> pflog.h:110:struct in_addr v4; >> pflog.h:111:struct in6_addr v6; >> >> Should they be replaced also? > > Yes. Dne in 71da7b139eb418ac91f1169c550e8a4dc970a692. OK, thank you. Remain some stuff about 'struct in6_addr'. Any need to keep them? $ git grep -l 'struct in6_addr' CMakeLists.txt cmakeconfig.h.in config.h.in configure configure.ac netdissect-stdinc.h --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr
--- Begin Message --- On Jul 17, 2022, at 10:10 AM, Francois-Xavier Le Bail via tcpdump-workers wrote: > The current nd_ipv4 and nd_ipv6 types were added in 2017 for alignment > reasons. > > Since then, > most of the 'struct in_addr' were replaced by 'nd_ipv4', > most of the 'struct in6_addr' were replaced by 'nd_ipv6'. > > Remain: > pflog.h:110:struct in_addr v4; > pflog.h:111:struct in6_addr v6; > > Should they be replaced also? Yes. Dne in 71da7b139eb418ac91f1169c550e8a4dc970a692.--- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
[tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr
--- Begin Message --- Hi, The current nd_ipv4 and nd_ipv6 types were added in 2017 for alignment reasons. Since then, most of the 'struct in_addr' were replaced by 'nd_ipv4', most of the 'struct in6_addr' were replaced by 'nd_ipv6'. Remain: pflog.h:110:struct in_addr v4; pflog.h:111:struct in6_addr v6; Should they be replaced also? -- Francois-Xavier --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
