[tcpdump-workers] Re: Sharing code between print-icmp.c and print-icmp6.c
On Feb 5, 2024, at 9:38 AM, Bill Fenner wrote: > Is this a reasonable way to proceed? Yes. Perhaps have a file icmp-common.c or print-icmp-common.c with code and data structures common to ICMP(v4) and ICMPv6? ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[tcpdump-workers] Re: Test
Guy Harris wrote: > Is the list working? It was not. I finally found the web process hanging onto a database lock, and cleared that. ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[tcpdump-workers] Sharing code between print-icmp.c and print-icmp6.c
Hi, I'm working on RFC8335 (PROBE) support for tcpdump - I've already submitted the pull request for IPv4. I'm working on IPv6 support, and it looks like this is the first case that the packet format is identical between ICMP and ICMPv6 but complex enough that it's worth reusing code. My commit https://github.com/fenner/tcpdump/commit/8590ce9d7c06f3db88f27a63a608484f9b2c04ae is a first try at reusing code appropriately: it makes some "struct tok"'s global, as well as the ICMP Extension Object parser, and puts them in a new "icmp.h" (for which I took the "print-icmp.c" copyright statement, since the code came from print-icmp.c). Is this a reasonable way to proceed? Thanks, Bill ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[tcpdump-workers] Re: Pcap debug at runtime
[Send, second try] On 02/03/2023 09:22, Francois-Xavier Le Bail wrote: > On 01/03/2023 20:28, Denis Ovsienko wrote: >> On Tue, 28 Feb 2023 17:01:51 +0100 >> Francois-Xavier Le Bail wrote: >> >>> In addition to printf()/fprintf(), here is a brand new way to help >>> debugging a program using libpcap, currently only tested on Debian >>> Linux (stable). >>> >>> (Similar method to the one available with tcpdump and tcpslice.) >>> >>> The goal is to generate instrumentation calls for entry and exit to >>> functions. Just after function entry and just before function exit, >>> the profiling functions are called and print the function names with >>> indentation and call level. If entering in a function, print also the >>> calling function name with file name and line number. There may be a >>> small shift in the line number. >>> >>> To use it: >>> (There will be a doc entry based on this topic later.) >> >> Thank you for putting this together. Does the FAQ look the best place >> for such documentation? > > The documentation could be added to the FAQ indeed. The documentation has been added: https://www.tcpdump.org/faq.html#q17 ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[tcpdump-workers] Test
Is the list working? ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[tcpdump-workers] Re: Pcap debug at runtime
On 02/03/2023 09:22, Francois-Xavier Le Bail wrote: > On 01/03/2023 20:28, Denis Ovsienko wrote: >> On Tue, 28 Feb 2023 17:01:51 +0100 >> Francois-Xavier Le Bail wrote: >> >>> In addition to printf()/fprintf(), here is a brand new way to help >>> debugging a program using libpcap, currently only tested on Debian >>> Linux (stable). >>> >>> (Similar method to the one available with tcpdump and tcpslice.) >>> >>> The goal is to generate instrumentation calls for entry and exit to >>> functions. Just after function entry and just before function exit, >>> the profiling functions are called and print the function names with >>> indentation and call level. If entering in a function, print also the >>> calling function name with file name and line number. There may be a >>> small shift in the line number. >>> >>> To use it: >>> (There will be a doc entry based on this topic later.) >> >> Thank you for putting this together. Does the FAQ look the best place >> for such documentation? > > The documentation could be added to the FAQ indeed. The documentation has been added: https://www.tcpdump.org/faq.html#q17 ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
