I'm working on RFC8335 (PROBE) support for tcpdump - I've already submitted
the pull request for IPv4.  I'm working on IPv6 support, and it looks like
this is the first case that the packet format is identical between ICMP and
ICMPv6 but complex enough that it's worth reusing code.

My commit
is a first try at reusing code appropriately: it makes some "struct tok"'s
global, as well as the ICMP Extension Object parser, and puts them in a new
"icmp.h" (for which I took the "print-icmp.c" copyright statement, since
the code came from print-icmp.c).

Is this a reasonable way to proceed?

tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org
To unsubscribe send an email to tcpdump-workers-le...@lists.tcpdump.org

Reply via email to