Re: [PATCH] [src] etc/etc.*/login.conf, share/man/man5/login.conf.5, libexec/login_radius/login_radius.8

2022-01-04 Thread Jason McIntyre
On Tue, Dec 28, 2021 at 06:46:03PM +, Raf Czlonka wrote:
> Hello,
> 
> Most changes touch the same files hence a single email and diff:
> 
> - login_ldap(8) is missing from login.conf(5)
> - capitalise 'radius' where talking about the protocol, and use an
>   indefinite article where relevant
> - remove 'tis' style - moved to the attic a while ago[0]
> 
> I was also thinking of normalising 'snk' as it is described as:
> 
>   "Digital Pathways SecureNet Key authentication"
> 
> in login.conf(5), but:
> 
>   "SNK-004 authentication"
> 
> in all of its manual pages - login_snk(8), snkadm(8), and snkinit(8).
> Also, the other token authentication styles in login.conf(5) file
> mention (ANSI) X9.9 and the 'snk' line does not. Either way, I wasn't
> sure which way around to go.
> 
> [0] https://marc.info/?l=openbsd-cvs=144805192217767=2
> 
> Regards,
> 
> Raf
> 

fixed, thanks.
jmc

> cvs server: Diffing etc/etc.alpha
> Index: etc/etc.alpha/login.conf
> ===
> RCS file: /cvs/src/etc/etc.alpha/login.conf,v
> retrieving revision 1.10
> diff -u -p -r1.10 login.conf
> --- etc/etc.alpha/login.conf  25 Apr 2021 16:36:56 -  1.10
> +++ etc/etc.alpha/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS authentication
>  # reject Use rejected authentication
>  # skey   Use S/Key authentication
>  # activ  ActivCard X9.9 token authentication
>  # crypto CRYPTOCard X9.9 token authentication
>  # snkDigital Pathways SecureNet Key authentication
> -# tisTIS Firewall Toolkit authentication
>  # token  Generic X9.9 token authentication
>  # yubikeyYubiKey authentication
>  #
> cvs server: Diffing etc/etc.amd64
> Index: etc/etc.amd64/login.conf
> ===
> RCS file: /cvs/src/etc/etc.amd64/login.conf,v
> retrieving revision 1.20
> diff -u -p -r1.20 login.conf
> --- etc/etc.amd64/login.conf  12 Nov 2021 15:40:19 -  1.20
> +++ etc/etc.amd64/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS authentication
>  # reject Use rejected authentication
>  # skey   Use S/Key authentication
>  # activ  ActivCard X9.9 token authentication
>  # crypto CRYPTOCard X9.9 token authentication
>  # snkDigital Pathways SecureNet Key authentication
> -# tisTIS Firewall Toolkit authentication
>  # token  Generic X9.9 token authentication
>  # yubikeyYubiKey authentication
>  #
> cvs server: Diffing etc/etc.arm64
> Index: etc/etc.arm64/login.conf
> ===
> RCS file: /cvs/src/etc/etc.arm64/login.conf,v
> retrieving revision 1.11
> diff -u -p -r1.11 login.conf
> --- etc/etc.arm64/login.conf  12 Nov 2021 15:40:20 -  1.11
> +++ etc/etc.arm64/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS authentication
>  # reject Use rejected authentication
>  # skey   Use S/Key authentication
>  # activ  ActivCard X9.9 token authentication
>  # crypto CRYPTOCard X9.9 token authentication
>  # snkDigital Pathways SecureNet Key authentication
> -# tisTIS Firewall Toolkit authentication
>  # token  Generic X9.9 token authentication
>  # yubikeyYubiKey authentication
>  #
> cvs server: Diffing etc/etc.armv7
> Index: etc/etc.armv7/login.conf
> ===
> RCS file: /cvs/src/etc/etc.armv7/login.conf,v
> retrieving revision 1.11
> diff -u -p -r1.11 login.conf
> --- etc/etc.armv7/login.conf  25 Apr 2021 16:36:56 -  1.11
> +++ etc/etc.armv7/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS 

Re: [PATCH] [src] etc/etc.*/login.conf, share/man/man5/login.conf.5, libexec/login_radius/login_radius.8

2022-01-04 Thread Stuart Henderson
On 2021/12/28 18:46, Raf Czlonka wrote:
> I was also thinking of normalising 'snk' as it is described as:
> 
>   "Digital Pathways SecureNet Key authentication"
> 
> in login.conf(5), but:
> 
>   "SNK-004 authentication"
> 
> in all of its manual pages - login_snk(8), snkadm(8), and snkinit(8).
> 
> Also, the other token authentication styles in login.conf(5) file
> mention (ANSI) X9.9 and the 'snk' line does not. Either way, I wasn't
> sure which way around to go.

Digital Pathways SecureNet produces much better search results than
SNK-004 for someone trying to figure out whether this is any use.
Though adding X9.9 would also make it more obvious that it can be ignored ;)



Re: [PATCH] [src] etc/etc.*/login.conf, share/man/man5/login.conf.5, libexec/login_radius/login_radius.8

2021-12-29 Thread Jason McIntyre
On Tue, Dec 28, 2021 at 06:46:03PM +, Raf Czlonka wrote:
> Hello,
> 
> Most changes touch the same files hence a single email and diff:
> 
> - login_ldap(8) is missing from login.conf(5)
> - capitalise 'radius' where talking about the protocol, and use an
>   indefinite article where relevant
> - remove 'tis' style - moved to the attic a while ago[0]
> 
> I was also thinking of normalising 'snk' as it is described as:
> 
>   "Digital Pathways SecureNet Key authentication"
> 
> in login.conf(5), but:
> 
>   "SNK-004 authentication"
> 
> in all of its manual pages - login_snk(8), snkadm(8), and snkinit(8).
> Also, the other token authentication styles in login.conf(5) file
> mention (ANSI) X9.9 and the 'snk' line does not. Either way, I wasn't
> sure which way around to go.
> 
> [0] https://marc.info/?l=openbsd-cvs=144805192217767=2
> 
> Regards,
> 
> Raf
> 

hi.

this all looks fine to me, but maybe another developer could add a
second ok?

jmc

> cvs server: Diffing etc/etc.alpha
> Index: etc/etc.alpha/login.conf
> ===
> RCS file: /cvs/src/etc/etc.alpha/login.conf,v
> retrieving revision 1.10
> diff -u -p -r1.10 login.conf
> --- etc/etc.alpha/login.conf  25 Apr 2021 16:36:56 -  1.10
> +++ etc/etc.alpha/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS authentication
>  # reject Use rejected authentication
>  # skey   Use S/Key authentication
>  # activ  ActivCard X9.9 token authentication
>  # crypto CRYPTOCard X9.9 token authentication
>  # snkDigital Pathways SecureNet Key authentication
> -# tisTIS Firewall Toolkit authentication
>  # token  Generic X9.9 token authentication
>  # yubikeyYubiKey authentication
>  #
> cvs server: Diffing etc/etc.amd64
> Index: etc/etc.amd64/login.conf
> ===
> RCS file: /cvs/src/etc/etc.amd64/login.conf,v
> retrieving revision 1.20
> diff -u -p -r1.20 login.conf
> --- etc/etc.amd64/login.conf  12 Nov 2021 15:40:19 -  1.20
> +++ etc/etc.amd64/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS authentication
>  # reject Use rejected authentication
>  # skey   Use S/Key authentication
>  # activ  ActivCard X9.9 token authentication
>  # crypto CRYPTOCard X9.9 token authentication
>  # snkDigital Pathways SecureNet Key authentication
> -# tisTIS Firewall Toolkit authentication
>  # token  Generic X9.9 token authentication
>  # yubikeyYubiKey authentication
>  #
> cvs server: Diffing etc/etc.arm64
> Index: etc/etc.arm64/login.conf
> ===
> RCS file: /cvs/src/etc/etc.arm64/login.conf,v
> retrieving revision 1.11
> diff -u -p -r1.11 login.conf
> --- etc/etc.arm64/login.conf  12 Nov 2021 15:40:20 -  1.11
> +++ etc/etc.arm64/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   Use LDAP authentication
> +# radius Use RADIUS authentication
>  # reject Use rejected authentication
>  # skey   Use S/Key authentication
>  # activ  ActivCard X9.9 token authentication
>  # crypto CRYPTOCard X9.9 token authentication
>  # snkDigital Pathways SecureNet Key authentication
> -# tisTIS Firewall Toolkit authentication
>  # token  Generic X9.9 token authentication
>  # yubikeyYubiKey authentication
>  #
> cvs server: Diffing etc/etc.armv7
> Index: etc/etc.armv7/login.conf
> ===
> RCS file: /cvs/src/etc/etc.armv7/login.conf,v
> retrieving revision 1.11
> diff -u -p -r1.11 login.conf
> --- etc/etc.armv7/login.conf  25 Apr 2021 16:36:56 -  1.11
> +++ etc/etc.armv7/login.conf  28 Dec 2021 17:39:42 -
> @@ -12,13 +12,13 @@
>  #the YP password if the user has one, else change the
>  #local password)
>  # lchpassDo not login; change user's local password instead
> -# radius Use radius authentication
> +# ldap   

[PATCH] [src] etc/etc.*/login.conf, share/man/man5/login.conf.5, libexec/login_radius/login_radius.8

2021-12-28 Thread Raf Czlonka
Hello,

Most changes touch the same files hence a single email and diff:

- login_ldap(8) is missing from login.conf(5)
- capitalise 'radius' where talking about the protocol, and use an
  indefinite article where relevant
- remove 'tis' style - moved to the attic a while ago[0]

I was also thinking of normalising 'snk' as it is described as:

"Digital Pathways SecureNet Key authentication"

in login.conf(5), but:

"SNK-004 authentication"

in all of its manual pages - login_snk(8), snkadm(8), and snkinit(8).
Also, the other token authentication styles in login.conf(5) file
mention (ANSI) X9.9 and the 'snk' line does not. Either way, I wasn't
sure which way around to go.

[0] https://marc.info/?l=openbsd-cvs=144805192217767=2

Regards,

Raf

cvs server: Diffing etc/etc.alpha
Index: etc/etc.alpha/login.conf
===
RCS file: /cvs/src/etc/etc.alpha/login.conf,v
retrieving revision 1.10
diff -u -p -r1.10 login.conf
--- etc/etc.alpha/login.conf25 Apr 2021 16:36:56 -  1.10
+++ etc/etc.alpha/login.conf28 Dec 2021 17:39:42 -
@@ -12,13 +12,13 @@
 #  the YP password if the user has one, else change the
 #  local password)
 # lchpass  Do not login; change user's local password instead
-# radius   Use radius authentication
+# ldap Use LDAP authentication
+# radius   Use RADIUS authentication
 # reject   Use rejected authentication
 # skey Use S/Key authentication
 # activActivCard X9.9 token authentication
 # crypto   CRYPTOCard X9.9 token authentication
 # snk  Digital Pathways SecureNet Key authentication
-# tis  TIS Firewall Toolkit authentication
 # tokenGeneric X9.9 token authentication
 # yubikey  YubiKey authentication
 #
cvs server: Diffing etc/etc.amd64
Index: etc/etc.amd64/login.conf
===
RCS file: /cvs/src/etc/etc.amd64/login.conf,v
retrieving revision 1.20
diff -u -p -r1.20 login.conf
--- etc/etc.amd64/login.conf12 Nov 2021 15:40:19 -  1.20
+++ etc/etc.amd64/login.conf28 Dec 2021 17:39:42 -
@@ -12,13 +12,13 @@
 #  the YP password if the user has one, else change the
 #  local password)
 # lchpass  Do not login; change user's local password instead
-# radius   Use radius authentication
+# ldap Use LDAP authentication
+# radius   Use RADIUS authentication
 # reject   Use rejected authentication
 # skey Use S/Key authentication
 # activActivCard X9.9 token authentication
 # crypto   CRYPTOCard X9.9 token authentication
 # snk  Digital Pathways SecureNet Key authentication
-# tis  TIS Firewall Toolkit authentication
 # tokenGeneric X9.9 token authentication
 # yubikey  YubiKey authentication
 #
cvs server: Diffing etc/etc.arm64
Index: etc/etc.arm64/login.conf
===
RCS file: /cvs/src/etc/etc.arm64/login.conf,v
retrieving revision 1.11
diff -u -p -r1.11 login.conf
--- etc/etc.arm64/login.conf12 Nov 2021 15:40:20 -  1.11
+++ etc/etc.arm64/login.conf28 Dec 2021 17:39:42 -
@@ -12,13 +12,13 @@
 #  the YP password if the user has one, else change the
 #  local password)
 # lchpass  Do not login; change user's local password instead
-# radius   Use radius authentication
+# ldap Use LDAP authentication
+# radius   Use RADIUS authentication
 # reject   Use rejected authentication
 # skey Use S/Key authentication
 # activActivCard X9.9 token authentication
 # crypto   CRYPTOCard X9.9 token authentication
 # snk  Digital Pathways SecureNet Key authentication
-# tis  TIS Firewall Toolkit authentication
 # tokenGeneric X9.9 token authentication
 # yubikey  YubiKey authentication
 #
cvs server: Diffing etc/etc.armv7
Index: etc/etc.armv7/login.conf
===
RCS file: /cvs/src/etc/etc.armv7/login.conf,v
retrieving revision 1.11
diff -u -p -r1.11 login.conf
--- etc/etc.armv7/login.conf25 Apr 2021 16:36:56 -  1.11
+++ etc/etc.armv7/login.conf28 Dec 2021 17:39:42 -
@@ -12,13 +12,13 @@
 #  the YP password if the user has one, else change the
 #  local password)
 # lchpass  Do not login; change user's local password instead
-# radius   Use radius authentication
+# ldap Use LDAP authentication
+# radius   Use RADIUS authentication
 # reject   Use rejected authentication
 # skey Use S/Key authentication
 # activActivCard X9.9 token authentication
 # crypto   CRYPTOCard X9.9 token authentication
 # snk  Digital Pathways SecureNet Key authentication
-# tis  TIS Firewall Toolkit