Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On Mon, May 24, 2021 at 05:07:50PM BST, Theo de Raadt wrote: > Raf Czlonka wrote: > > > On Mon, May 24, 2021 at 04:10:00PM BST, Theo de Raadt wrote: > > > But does it matter? > > > > Did this[0] matter? > > If you aren't curious enough to read the Makefile, devlist2h.awk, > usbdevs.h, and usbdevs_data.h to recognize the full production > of your changes (to wit, #defines AND structured strings in every > kernel), then I don't understand what you are doing. Hi Theo, All I was trying to do is to have the vendor ID "pretty"-printed - I thought that part was obvious. Did I realise what the full impact of such change would be? Of course not - otherwise, I would not have emailed the patch in the first place. Errare humanum est. Raf
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
Raf Czlonka wrote: > On Mon, May 24, 2021 at 04:10:00PM BST, Theo de Raadt wrote: > > But does it matter? > > Did this[0] matter? If you aren't curious enough to read the Makefile, devlist2h.awk, usbdevs.h, and usbdevs_data.h to recognize the full production of your changes (to wit, #defines AND structured strings in every kernel), then I don't understand what you are doing.
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On Mon, May 24, 2021 at 04:37:57PM BST, Stuart Henderson wrote: > On 2021/05/24 16:27, Raf Czlonka wrote: > > On Mon, May 24, 2021 at 04:10:00PM BST, Theo de Raadt wrote: > > > But does it matter? > > > > Did this[0] matter? > > > [0] > > https://cvsweb.openbsd.org/src/sys/dev/usb/usbdevs.diff?r1=1.698=1.699=date=h > > Yes, that one is used in a driver. Thanks! R.
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On Mon, May 24, 2021 at 04:28:36PM BST, Jonathan Gray wrote: > On Mon, May 24, 2021 at 03:52:44PM +0100, Raf Czlonka wrote: > > Hello, > > > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. > > 0x1ea7 / 7847 is 'SEMITEK INTERNATIONAL (HK) HOLDING LTD.' in > https://usb.org/sites/default/files/vendor_ids033021.pdf Hi Jonathan, Elsewhere[0][1][2], this mouse shows up as what's below but it's most likely due to the fact that it's several years old. Now I see that there's been an update[3] - vendor renamed or sold? Either way, thanks for the link! [0] https://devicehunt.com/view/type/usb/vendor/1EA7 [1] https://www.devicekb.com/en/hardware/usb-vendors/vid_1ea7 [2] http://www.linux-usb.org/usb.ids [3] https://usb-ids.gowdy.us/read/UD/1ea7 Cheers, Raf > > > > Regards, > > > > Raf > > > > Index: sys/dev/usb/usbdevs > > === > > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > > retrieving revision 1.740 > > diff -u -p -r1.740 usbdevs > > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > > @@ -618,6 +618,7 @@ vendor SELUXIT 0x1d6f Seluxit > > vendor METAGEEK0x1dd5 MetaGeek > > vendor SIMCOM 0x1e0e SIMCom Wireless Solutions Co., Ltd. > > vendor FESTO 0x1e29 Festo > > +vendor SHARKOON0x1ea7 SHARKOON Technologies GmbH > > vendor MODACOM 0x1eb8 Modacom > > vendor AIRTIES 0x1eda AirTies > > vendor LAKESHORE 0x1fb9 Lake Shore > > > >
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On 2021/05/24 16:27, Raf Czlonka wrote: > On Mon, May 24, 2021 at 04:10:00PM BST, Theo de Raadt wrote: > > But does it matter? > > Did this[0] matter? > [0] > https://cvsweb.openbsd.org/src/sys/dev/usb/usbdevs.diff?r1=1.698=1.699=date=h Yes, that one is used in a driver.
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On Mon, May 24, 2021 at 03:52:44PM +0100, Raf Czlonka wrote: > Hello, > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. 0x1ea7 / 7847 is 'SEMITEK INTERNATIONAL (HK) HOLDING LTD.' in https://usb.org/sites/default/files/vendor_ids033021.pdf > > Regards, > > Raf > > Index: sys/dev/usb/usbdevs > === > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > retrieving revision 1.740 > diff -u -p -r1.740 usbdevs > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > @@ -618,6 +618,7 @@ vendor SELUXIT0x1d6f Seluxit > vendor METAGEEK 0x1dd5 MetaGeek > vendor SIMCOM0x1e0e SIMCom Wireless Solutions Co., Ltd. > vendor FESTO 0x1e29 Festo > +vendor SHARKOON 0x1ea7 SHARKOON Technologies GmbH > vendor MODACOM 0x1eb8 Modacom > vendor AIRTIES 0x1eda AirTies > vendor LAKESHORE 0x1fb9 Lake Shore > >
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On Mon, May 24, 2021 at 04:10:00PM BST, Theo de Raadt wrote: > But does it matter? Did this[0] matter? Well, in the grand scheme of things, not many things do, really. Or is it just about the length of the vendor ID? If the latter, then yes - a bit unfortunate that it's on the longer side... I didn't come up with the name. Maybe remove all without any product IDs? Your call. [0] https://cvsweb.openbsd.org/src/sys/dev/usb/usbdevs.diff?r1=1.698=1.699=date=h R. > It adds sizeof pointer + 28 bytes to every OpenBSD kernel. > > I have seriously considered deleting usbdevs device-naming support, > because the cost keeps growing without bound. > > Raf Czlonka wrote: > > > On Mon, May 24, 2021 at 04:00:20PM BST, Theo de Raadt wrote: > > > Without proof it is required, no. > > > > Sure - hope this will suffice. > > > > Before: > > > > uhidev1 at uhub3 port 2 configuration 1 interface 0 "vendor 0x1ea7 2.4G > > Mouse" rev 1.10/2.00 addr 4 > > > > After: > > > > uhidev1 at uhub3 port 2 configuration 1 interface 0 "SHARKOON > > Technologies GmbH 2.4G Mouse" rev 1.10/2.00 addr 4 > > > > Cheers, > > > > Raf > > > > > Raf Czlonka wrote: > > > > > > > Hello, > > > > > > > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. > > > > > > > > Regards, > > > > > > > > Raf > > > > > > > > Index: sys/dev/usb/usbdevs > > > > === > > > > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > > > > retrieving revision 1.740 > > > > diff -u -p -r1.740 usbdevs > > > > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > > > > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > > > > @@ -618,6 +618,7 @@ vendor SELUXIT 0x1d6f Seluxit > > > > vendor METAGEEK0x1dd5 MetaGeek > > > > vendor SIMCOM 0x1e0e SIMCom Wireless Solutions Co., Ltd. > > > > vendor FESTO 0x1e29 Festo > > > > +vendor SHARKOON0x1ea7 SHARKOON Technologies GmbH > > > > vendor MODACOM 0x1eb8 Modacom > > > > vendor AIRTIES 0x1eda AirTies > > > > vendor LAKESHORE 0x1fb9 Lake Shore > > > >
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
> Date: Mon, 24 May 2021 15:52:44 +0100 > From: Raf Czlonka > > Hello, > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. Not really self-explanatory. Why do you need this? We typically don't add strings for devices unless we need the vendor ID or device ID in a driver. > Index: sys/dev/usb/usbdevs > === > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > retrieving revision 1.740 > diff -u -p -r1.740 usbdevs > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > @@ -618,6 +618,7 @@ vendor SELUXIT0x1d6f Seluxit > vendor METAGEEK 0x1dd5 MetaGeek > vendor SIMCOM0x1e0e SIMCom Wireless Solutions Co., Ltd. > vendor FESTO 0x1e29 Festo > +vendor SHARKOON 0x1ea7 SHARKOON Technologies GmbH > vendor MODACOM 0x1eb8 Modacom > vendor AIRTIES 0x1eda AirTies > vendor LAKESHORE 0x1fb9 Lake Shore > >
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
But does it matter? It adds sizeof pointer + 28 bytes to every OpenBSD kernel. I have seriously considered deleting usbdevs device-naming support, because the cost keeps growing without bound. Raf Czlonka wrote: > On Mon, May 24, 2021 at 04:00:20PM BST, Theo de Raadt wrote: > > Without proof it is required, no. > > Sure - hope this will suffice. > > Before: > > uhidev1 at uhub3 port 2 configuration 1 interface 0 "vendor 0x1ea7 2.4G > Mouse" rev 1.10/2.00 addr 4 > > After: > > uhidev1 at uhub3 port 2 configuration 1 interface 0 "SHARKOON > Technologies GmbH 2.4G Mouse" rev 1.10/2.00 addr 4 > > Cheers, > > Raf > > > Raf Czlonka wrote: > > > > > Hello, > > > > > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. > > > > > > Regards, > > > > > > Raf > > > > > > Index: sys/dev/usb/usbdevs > > > === > > > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > > > retrieving revision 1.740 > > > diff -u -p -r1.740 usbdevs > > > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > > > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > > > @@ -618,6 +618,7 @@ vendor SELUXIT0x1d6f Seluxit > > > vendor METAGEEK 0x1dd5 MetaGeek > > > vendor SIMCOM0x1e0e SIMCom Wireless Solutions Co., Ltd. > > > vendor FESTO 0x1e29 Festo > > > +vendor SHARKOON 0x1ea7 SHARKOON Technologies GmbH > > > vendor MODACOM 0x1eb8 Modacom > > > vendor AIRTIES 0x1eda AirTies > > > vendor LAKESHORE 0x1fb9 Lake Shore > > >
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
On Mon, May 24, 2021 at 04:00:20PM BST, Theo de Raadt wrote: > Without proof it is required, no. Sure - hope this will suffice. Before: uhidev1 at uhub3 port 2 configuration 1 interface 0 "vendor 0x1ea7 2.4G Mouse" rev 1.10/2.00 addr 4 After: uhidev1 at uhub3 port 2 configuration 1 interface 0 "SHARKOON Technologies GmbH 2.4G Mouse" rev 1.10/2.00 addr 4 Cheers, Raf > Raf Czlonka wrote: > > > Hello, > > > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. > > > > Regards, > > > > Raf > > > > Index: sys/dev/usb/usbdevs > > === > > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > > retrieving revision 1.740 > > diff -u -p -r1.740 usbdevs > > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > > @@ -618,6 +618,7 @@ vendor SELUXIT 0x1d6f Seluxit > > vendor METAGEEK0x1dd5 MetaGeek > > vendor SIMCOM 0x1e0e SIMCom Wireless Solutions Co., Ltd. > > vendor FESTO 0x1e29 Festo > > +vendor SHARKOON0x1ea7 SHARKOON Technologies GmbH > > vendor MODACOM 0x1eb8 Modacom > > vendor AIRTIES 0x1eda AirTies > > vendor LAKESHORE 0x1fb9 Lake Shore > >
Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
Without proof it is required, no. Raf Czlonka wrote: > Hello, > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. > > Regards, > > Raf > > Index: sys/dev/usb/usbdevs > === > RCS file: /cvs/src/sys/dev/usb/usbdevs,v > retrieving revision 1.740 > diff -u -p -r1.740 usbdevs > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - > @@ -618,6 +618,7 @@ vendor SELUXIT0x1d6f Seluxit > vendor METAGEEK 0x1dd5 MetaGeek > vendor SIMCOM0x1e0e SIMCom Wireless Solutions Co., Ltd. > vendor FESTO 0x1e29 Festo > +vendor SHARKOON 0x1ea7 SHARKOON Technologies GmbH > vendor MODACOM 0x1eb8 Modacom > vendor AIRTIES 0x1eda AirTies > vendor LAKESHORE 0x1fb9 Lake Shore >
[PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID
Hello, Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. Regards, Raf Index: sys/dev/usb/usbdevs === RCS file: /cvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.740 diff -u -p -r1.740 usbdevs --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 - 1.740 +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 - @@ -618,6 +618,7 @@ vendor SELUXIT 0x1d6f Seluxit vendor METAGEEK0x1dd5 MetaGeek vendor SIMCOM 0x1e0e SIMCom Wireless Solutions Co., Ltd. vendor FESTO 0x1e29 Festo +vendor SHARKOON0x1ea7 SHARKOON Technologies GmbH vendor MODACOM 0x1eb8 Modacom vendor AIRTIES 0x1eda AirTies vendor LAKESHORE 0x1fb9 Lake Shore
