subject:"add missing PCI ID for Intel NVMe"

Re: add missing PCI ID for Intel NVMe

2021-03-13 Thread Jan Klemkow

On Fri, Mar 12, 2021 at 11:56:00AM +0100, Mark Kettenis wrote:
> I believe this is what ark.intel.com calls a "Intel SSD DC P4510
> Series" part.  Is that correct?

Yes, that is correct.

On Fri, Mar 12, 2021 at 10:00:54PM +1100, Jonathan Gray wrote:
> On Fri, Mar 12, 2021 at 11:30:04AM +0100, Jan Klemkow wrote:
> So it is a 'SSD DC P4510'
> 
> A driver downloaded from Intel has
> ...
> PCI\VEN_8086&DEV_0A54.DeviceDesc = "Intel(R) SSD DC 
> P4500/4600/4501/4601/4608/4510/4610/4511 Series"
> ...
> 
> perhaps just
> product INTEL NVME_5  0x0a54  SSD DC

You are right, that's a better name.  Also the sticker on the disk just
says "Intel SSD DC".

OK?

Thanks,
Jan

Index: pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1959
diff -u -p -r1.1959 pcidevs
--- pcidevs 27 Feb 2021 03:00:54 -  1.1959
+++ pcidevs 13 Mar 2021 20:22:04 -
@@ -3465,6 +3465,7 @@ product INTEL CORE4G_M_ULT_GT30x0a26  HD
 product INTEL CORE4G_S_ULT_GT3 0x0a2a  HD Graphics
 product INTEL CORE4G_R_ULT_GT3_1 0x0a2bHD Graphics
 product INTEL CORE4G_R_ULT_GT3_2 0x0a2eIris Graphics 5100
+product INTEL NVME_5   0x0a54  SSD DC
 product INTEL GMA3600_00x0be0  GMA 3600
 product INTEL D2000_IGD0x0be1  Atom D2000/N2000 Video
 product INTEL GMA3600_20x0be2  GMA 3600
Index: pcidevs.h
===
RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
retrieving revision 1.1953
diff -u -p -r1.1953 pcidevs.h
--- pcidevs.h   27 Feb 2021 03:01:25 -  1.1953
+++ pcidevs.h   13 Mar 2021 20:22:06 -
@@ -3470,6 +3470,7 @@
 #definePCI_PRODUCT_INTEL_CORE4G_S_ULT_GT3  0x0a2a  /* HD 
Graphics */
 #definePCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_10x0a2b  /* HD 
Graphics */
 #definePCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_20x0a2e  /* Iris 
Graphics 5100 */
+#definePCI_PRODUCT_INTEL_NVME_50x0a54  /* SSD DC */
 #definePCI_PRODUCT_INTEL_GMA3600_0 0x0be0  /* GMA 3600 */
 #definePCI_PRODUCT_INTEL_D2000_IGD 0x0be1  /* Atom 
D2000/N2000 Video */
 #definePCI_PRODUCT_INTEL_GMA3600_2 0x0be2  /* GMA 3600 */
Index: pcidevs_data.h
===
RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
retrieving revision 1.1948
diff -u -p -r1.1948 pcidevs_data.h
--- pcidevs_data.h  27 Feb 2021 03:01:25 -  1.1948
+++ pcidevs_data.h  13 Mar 2021 20:22:06 -
@@ -11304,6 +11304,10 @@ static const struct pci_known_product pc
"Iris Graphics 5100",
},
{
+   PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_NVME_5,
+   "SSD DC",
+   },
+   {
PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_GMA3600_0,
"GMA 3600",
},

Re: add missing PCI ID for Intel NVMe

2021-03-13 Thread Jonathan Gray

On Sat, Mar 13, 2021 at 09:51:30PM +0100, Jan Klemkow wrote:
> On Fri, Mar 12, 2021 at 11:56:00AM +0100, Mark Kettenis wrote:
> > I believe this is what ark.intel.com calls a "Intel SSD DC P4510
> > Series" part.  Is that correct?
> 
> Yes, that is correct.
> 
> On Fri, Mar 12, 2021 at 10:00:54PM +1100, Jonathan Gray wrote:
> > On Fri, Mar 12, 2021 at 11:30:04AM +0100, Jan Klemkow wrote:
> > So it is a 'SSD DC P4510'
> > 
> > A driver downloaded from Intel has
> > ...
> > PCI\VEN_8086&DEV_0A54.DeviceDesc = "Intel(R) SSD DC 
> > P4500/4600/4501/4601/4608/4510/4610/4511 Series"
> > ...
> > 
> > perhaps just
> > product INTEL NVME_50x0a54  SSD DC
> 
> You are right, that's a better name.  Also the sticker on the disk just
> says "Intel SSD DC".
> 
> OK?

ok jsg@

> 
> Thanks,
> Jan
> 
> Index: pcidevs
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1959
> diff -u -p -r1.1959 pcidevs
> --- pcidevs   27 Feb 2021 03:00:54 -  1.1959
> +++ pcidevs   13 Mar 2021 20:22:04 -
> @@ -3465,6 +3465,7 @@ product INTEL CORE4G_M_ULT_GT3  0x0a26  HD
>  product INTEL CORE4G_S_ULT_GT3   0x0a2a  HD Graphics
>  product INTEL CORE4G_R_ULT_GT3_1 0x0a2b  HD Graphics
>  product INTEL CORE4G_R_ULT_GT3_2 0x0a2e  Iris Graphics 5100
> +product INTEL NVME_5 0x0a54  SSD DC
>  product INTEL GMA3600_0  0x0be0  GMA 3600
>  product INTEL D2000_IGD  0x0be1  Atom D2000/N2000 Video
>  product INTEL GMA3600_2  0x0be2  GMA 3600
> Index: pcidevs.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
> retrieving revision 1.1953
> diff -u -p -r1.1953 pcidevs.h
> --- pcidevs.h 27 Feb 2021 03:01:25 -  1.1953
> +++ pcidevs.h 13 Mar 2021 20:22:06 -
> @@ -3470,6 +3470,7 @@
>  #define  PCI_PRODUCT_INTEL_CORE4G_S_ULT_GT3  0x0a2a  /* HD 
> Graphics */
>  #define  PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_10x0a2b  /* HD 
> Graphics */
>  #define  PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_20x0a2e  /* Iris 
> Graphics 5100 */
> +#define  PCI_PRODUCT_INTEL_NVME_50x0a54  /* SSD DC */
>  #define  PCI_PRODUCT_INTEL_GMA3600_0 0x0be0  /* GMA 3600 */
>  #define  PCI_PRODUCT_INTEL_D2000_IGD 0x0be1  /* Atom 
> D2000/N2000 Video */
>  #define  PCI_PRODUCT_INTEL_GMA3600_2 0x0be2  /* GMA 3600 */
> Index: pcidevs_data.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
> retrieving revision 1.1948
> diff -u -p -r1.1948 pcidevs_data.h
> --- pcidevs_data.h27 Feb 2021 03:01:25 -  1.1948
> +++ pcidevs_data.h13 Mar 2021 20:22:06 -
> @@ -11304,6 +11304,10 @@ static const struct pci_known_product pc
>   "Iris Graphics 5100",
>   },
>   {
> + PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_NVME_5,
> + "SSD DC",
> + },
> + {
>   PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_GMA3600_0,
>   "GMA 3600",
>   },
>

add missing PCI ID for Intel NVMe

2021-03-12 Thread Jan Klemkow

Hi,

This diff add a missing PCI ID of an Intel NVMe disk.  The disk works
after my last fix [1].

OK?

bye,
Jan

[1]: https://marc.info/?l=openbsd-tech&m=161418460303831

Index: pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1959
diff -u -p -r1.1959 pcidevs
--- pcidevs 27 Feb 2021 03:00:54 -  1.1959
+++ pcidevs 12 Mar 2021 10:16:44 -
@@ -3465,6 +3465,7 @@ product INTEL CORE4G_M_ULT_GT30x0a26  HD
 product INTEL CORE4G_S_ULT_GT3 0x0a2a  HD Graphics
 product INTEL CORE4G_R_ULT_GT3_1 0x0a2bHD Graphics
 product INTEL CORE4G_R_ULT_GT3_2 0x0a2eIris Graphics 5100
+product INTEL NVME_1   0x0a54  NVMe Datacenter SSD
 product INTEL GMA3600_00x0be0  GMA 3600
 product INTEL D2000_IGD0x0be1  Atom D2000/N2000 Video
 product INTEL GMA3600_20x0be2  GMA 3600
Index: pcidevs.h
===
RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
retrieving revision 1.1953
diff -u -p -r1.1953 pcidevs.h
--- pcidevs.h   27 Feb 2021 03:01:25 -  1.1953
+++ pcidevs.h   12 Mar 2021 10:16:46 -
@@ -3470,6 +3470,7 @@
 #definePCI_PRODUCT_INTEL_CORE4G_S_ULT_GT3  0x0a2a  /* HD 
Graphics */
 #definePCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_10x0a2b  /* HD 
Graphics */
 #definePCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_20x0a2e  /* Iris 
Graphics 5100 */
+#definePCI_PRODUCT_INTEL_NVME_10x0a54  /* NVMe 
Datacenter SSD */
 #definePCI_PRODUCT_INTEL_GMA3600_0 0x0be0  /* GMA 3600 */
 #definePCI_PRODUCT_INTEL_D2000_IGD 0x0be1  /* Atom 
D2000/N2000 Video */
 #definePCI_PRODUCT_INTEL_GMA3600_2 0x0be2  /* GMA 3600 */
Index: pcidevs_data.h
===
RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
retrieving revision 1.1948
diff -u -p -r1.1948 pcidevs_data.h
--- pcidevs_data.h  27 Feb 2021 03:01:25 -  1.1948
+++ pcidevs_data.h  12 Mar 2021 10:16:46 -
@@ -11304,6 +11304,10 @@ static const struct pci_known_product pc
"Iris Graphics 5100",
},
{
+   PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_NVME_1,
+   "NVMe Datacenter SSD",
+   },
+   {
PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_GMA3600_0,
"GMA 3600",
},

Re: add missing PCI ID for Intel NVMe

2021-03-12 Thread Jonathan Gray

On Fri, Mar 12, 2021 at 11:30:04AM +0100, Jan Klemkow wrote:
> Hi,
> 
> This diff add a missing PCI ID of an Intel NVMe disk.  The disk works
> after my last fix [1].
> 
> OK?
> 
> bye,
> Jan
> 
> [1]: https://marc.info/?l=openbsd-tech&m=161418460303831

So it is a 'SSD DC P4510'

A driver downloaded from Intel has
PCI\VEN_8086&DEV_F1A6.DeviceDesc = "Intel(R) SSD Pro 7600p/760p/E 6100p Series"
PCI\VEN_8086&DEV_F1A8.DeviceDesc = "Intel(R) SSD 660p Series"
PCI\VEN_8086&DEV_FAF0.DeviceDesc = "Intel(R) SSD 665p Series"
PCI\VEN_8086&DEV_0953.DeviceDesc = "Intel(R) Solid-State Drive 
P3700/P3600/P3500/P3520/750 Series"
PCI\VEN_8086&DEV_0A53.DeviceDesc = "Intel(R) Solid-State Drive DC P3520 Series"
PCI\VEN_8086&DEV_0A54.DeviceDesc = "Intel(R) SSD DC 
P4500/4600/4501/4601/4608/4510/4610/4511 Series"
PCI\VEN_8086&DEV_0A55.DeviceDesc = "Intel(R) SSD DC P4600 Series"
PCI\VEN_8086&DEV_2700.DeviceDesc = "Intel(R) Optane(tm) SSD 900P/905P Series"
PCI\VEN_8086&DEV_2701.DeviceDesc = "Intel(R) Optane(tm) SSD DC P4800X Series"
PCI\VEN_8086&DEV_0B60.DeviceDesc = "Intel(R) SSD D7-P5500/P5600 Series"
PCI\VEN_8086&DEV_4140.DeviceDesc = "Intel(R) Optane(tm) SSD DC P5800X Series"

perhaps just
product INTEL NVME_50x0a54  SSD DC

> 
> Index: pcidevs
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1959
> diff -u -p -r1.1959 pcidevs
> --- pcidevs   27 Feb 2021 03:00:54 -  1.1959
> +++ pcidevs   12 Mar 2021 10:16:44 -
> @@ -3465,6 +3465,7 @@ product INTEL CORE4G_M_ULT_GT3  0x0a26  HD
>  product INTEL CORE4G_S_ULT_GT3   0x0a2a  HD Graphics
>  product INTEL CORE4G_R_ULT_GT3_1 0x0a2b  HD Graphics
>  product INTEL CORE4G_R_ULT_GT3_2 0x0a2e  Iris Graphics 5100
> +product INTEL NVME_1 0x0a54  NVMe Datacenter SSD
>  product INTEL GMA3600_0  0x0be0  GMA 3600
>  product INTEL D2000_IGD  0x0be1  Atom D2000/N2000 Video
>  product INTEL GMA3600_2  0x0be2  GMA 3600
> Index: pcidevs.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
> retrieving revision 1.1953
> diff -u -p -r1.1953 pcidevs.h
> --- pcidevs.h 27 Feb 2021 03:01:25 -  1.1953
> +++ pcidevs.h 12 Mar 2021 10:16:46 -
> @@ -3470,6 +3470,7 @@
>  #define  PCI_PRODUCT_INTEL_CORE4G_S_ULT_GT3  0x0a2a  /* HD 
> Graphics */
>  #define  PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_10x0a2b  /* HD 
> Graphics */
>  #define  PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_20x0a2e  /* Iris 
> Graphics 5100 */
> +#define  PCI_PRODUCT_INTEL_NVME_10x0a54  /* NVMe 
> Datacenter SSD */
>  #define  PCI_PRODUCT_INTEL_GMA3600_0 0x0be0  /* GMA 3600 */
>  #define  PCI_PRODUCT_INTEL_D2000_IGD 0x0be1  /* Atom 
> D2000/N2000 Video */
>  #define  PCI_PRODUCT_INTEL_GMA3600_2 0x0be2  /* GMA 3600 */
> Index: pcidevs_data.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
> retrieving revision 1.1948
> diff -u -p -r1.1948 pcidevs_data.h
> --- pcidevs_data.h27 Feb 2021 03:01:25 -  1.1948
> +++ pcidevs_data.h12 Mar 2021 10:16:46 -
> @@ -11304,6 +11304,10 @@ static const struct pci_known_product pc
>   "Iris Graphics 5100",
>   },
>   {
> + PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_NVME_1,
> + "NVMe Datacenter SSD",
> + },
> + {
>   PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_GMA3600_0,
>   "GMA 3600",
>   },
> 
>

Re: add missing PCI ID for Intel NVMe

2021-03-12 Thread Mark Kettenis

> Date: Fri, 12 Mar 2021 11:30:04 +0100
> From: Jan Klemkow 
> 
> Hi,
> 
> This diff add a missing PCI ID of an Intel NVMe disk.  The disk works
> after my last fix [1].
> 
> OK?

That seems to be a poorly chosen name.

I believe this is what ark.intel.com calls a "Intel SSD DC P4510
Series" part.  Is that correct?

In that case I would suggest "DC P4510 NVMe" as the name.

> [1]: https://marc.info/?l=openbsd-tech&m=161418460303831
> 
> Index: pcidevs
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1959
> diff -u -p -r1.1959 pcidevs
> --- pcidevs   27 Feb 2021 03:00:54 -  1.1959
> +++ pcidevs   12 Mar 2021 10:16:44 -
> @@ -3465,6 +3465,7 @@ product INTEL CORE4G_M_ULT_GT3  0x0a26  HD
>  product INTEL CORE4G_S_ULT_GT3   0x0a2a  HD Graphics
>  product INTEL CORE4G_R_ULT_GT3_1 0x0a2b  HD Graphics
>  product INTEL CORE4G_R_ULT_GT3_2 0x0a2e  Iris Graphics 5100
> +product INTEL NVME_1 0x0a54  NVMe Datacenter SSD
>  product INTEL GMA3600_0  0x0be0  GMA 3600
>  product INTEL D2000_IGD  0x0be1  Atom D2000/N2000 Video
>  product INTEL GMA3600_2  0x0be2  GMA 3600
> Index: pcidevs.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
> retrieving revision 1.1953
> diff -u -p -r1.1953 pcidevs.h
> --- pcidevs.h 27 Feb 2021 03:01:25 -  1.1953
> +++ pcidevs.h 12 Mar 2021 10:16:46 -
> @@ -3470,6 +3470,7 @@
>  #define  PCI_PRODUCT_INTEL_CORE4G_S_ULT_GT3  0x0a2a  /* HD 
> Graphics */
>  #define  PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_10x0a2b  /* HD 
> Graphics */
>  #define  PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_20x0a2e  /* Iris 
> Graphics 5100 */
> +#define  PCI_PRODUCT_INTEL_NVME_10x0a54  /* NVMe 
> Datacenter SSD */
>  #define  PCI_PRODUCT_INTEL_GMA3600_0 0x0be0  /* GMA 3600 */
>  #define  PCI_PRODUCT_INTEL_D2000_IGD 0x0be1  /* Atom 
> D2000/N2000 Video */
>  #define  PCI_PRODUCT_INTEL_GMA3600_2 0x0be2  /* GMA 3600 */
> Index: pcidevs_data.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
> retrieving revision 1.1948
> diff -u -p -r1.1948 pcidevs_data.h
> --- pcidevs_data.h27 Feb 2021 03:01:25 -  1.1948
> +++ pcidevs_data.h12 Mar 2021 10:16:46 -
> @@ -11304,6 +11304,10 @@ static const struct pci_known_product pc
>   "Iris Graphics 5100",
>   },
>   {
> + PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_NVME_1,
> + "NVMe Datacenter SSD",
> + },
> + {
>   PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_GMA3600_0,
>   "GMA 3600",
>   },
> 
>

Re: add missing PCI ID for Intel NVMe

Re: add missing PCI ID for Intel NVMe

add missing PCI ID for Intel NVMe

Re: add missing PCI ID for Intel NVMe

Re: add missing PCI ID for Intel NVMe

5 matches

Site Navigation

Mail list logo

Footer information