Re: [Thunar-dev] B1 weirdness
On Sun, 2006-04-30 at 23:55 +0200, Benedikt Meurer wrote: Sure. Thunar B1 .desktop is an example. I also noticed (but it requires more testing) that clicking on another label (!Launcher) and then moving to Launcher with cursors doesn't seem to make it crash. Maybe it's a gtk problem? Only the dialog closes, right? This does not crash Thunar? Can you reproduce it with xfdesktop? With the patch you pointed me to, I can right clic on the Thunar.desktop (on /usr/share/applications), go to properties, clicking on launcher. Everything work. Thunar 0.3.0beta1 + patch you provided. Regards, -- Yves-Alexis Perez ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Yves-Alexis Perez wrote: On Sun, 2006-04-30 at 23:55 +0200, Benedikt Meurer wrote: Sure. Thunar B1 .desktop is an example. I also noticed (but it requires more testing) that clicking on another label (!Launcher) and then moving to Launcher with cursors doesn't seem to make it crash. Maybe it's a gtk problem? Only the dialog closes, right? This does not crash Thunar? Can you reproduce it with xfdesktop? With the patch you pointed me to, I can right clic on the Thunar.desktop (on /usr/share/applications), go to properties, clicking on launcher. Everything work. Thunar 0.3.0beta1 + patch you provided. As I said in a previous email, this works for me (in svn trunk) as long as I haven't got write permissions to the .desktop file. So the root owned files under /usr don't exhibit the bug for me. Try copying the file somewhere (so that you get ownership and write permissions) and then checking the launcher tab in the properties dialog. - Jari ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
On Mon, 2006-05-01 at 14:18 +0300, Jari Rahkonen wrote: As I said in a previous email, this works for me (in svn trunk) as long as I haven't got write permissions to the .desktop file. So the root owned files under /usr don't exhibit the bug for me. Try copying the file somewhere (so that you get ownership and write permissions) and then checking the launcher tab in the properties dialog. Ok, you're right. Copying Thunar.desktop to my desktop, opening properties in Thunar, clicking on launcher tab, window disappear (only properties, no thunar). Switching tabs with keyboard works. Opening properties with xfdesktop works, I can go to launcher, but as soon as I open the Launcher tab, it creates another .desktop file on the desktop. Then, when I close the properties, it creates another one. Regards, -- Yves-Alexis Perez ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Howdy Benny, Benedikt Meurer wrote: Only the dialog closes, right? This does not crash Thunar? Can you reproduce it with xfdesktop? Right, Thunar doesn't crash, only dialog closes. Unfortunately, I am still using Xfce 4.2 but with Thunar B1 (as in Debian Sid). Please rely on Yves-Alexis Perez who is in the Debian Xfce Team and is packaging 4.4 already. Happy hacking, Roberto PS: Jari: what write permissions do you need? -rw-r--r--? Because if I have those nothing is changing for me. PPS: is the /usr/share/applications bug and the .desktop bug the same bug or it's two unrelated things? ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Roberto Pariset wrote: Howdy Benny, Benedikt Meurer wrote: Only the dialog closes, right? This does not crash Thunar? Can you reproduce it with xfdesktop? Right, Thunar doesn't crash, only dialog closes. Unfortunately, I am still using Xfce 4.2 but with Thunar B1 (as in Debian Sid). Please rely on Yves-Alexis Perez who is in the Debian Xfce Team and is packaging 4.4 already. Happy hacking, Roberto PS: Jari: what write permissions do you need? -rw-r--r--? Because if I have those nothing is changing for me. It seems like the bug is triggered as long as I can write to the file. Everything's fine if I don't have those permissions (e.g. if I set the file permissions to something like -r--r--r-- or the file is owned and only writable by root). That way the widgets in the Launcher tab are insensitive but then the dialog doesn't close unexpectedly. PPS: is the /usr/share/applications bug and the .desktop bug the same bug or it's two unrelated things? I don't see the crash when entering /usr/share/applications in the svn trunk version of Thunar, so this might already have been fixed after the beta. Assuming that's the bug you're referring to. - Jari ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Jari Rahkonen wrote:
It seems like the bug is triggered as long as I can write to the file.
Everything's fine if I don't have those permissions (e.g. if I set the
file permissions to something like -r--r--r-- or the file is owned and
only writable by root). That way the widgets in the Launcher tab are
insensitive but then the dialog doesn't close unexpectedly.
Seems to be a race condition between g_file_set_content() and inotify.
Please try the attached patch.
- Jari
Benedikt
Index: plugins/thunar-apr/thunar-apr-desktop-page.c
===
--- plugins/thunar-apr/thunar-apr-desktop-page.c (revision 21419)
+++ plugins/thunar-apr/thunar-apr-desktop-page.c (working copy)
@@ -496,9 +496,7 @@
gchar *data;
gchar *uri;
gsize data_length;
-#if !GLIB_CHECK_VERSION(2,8,0)
FILE *fp;
-#endif
/* verify that we still have a valid file */
if (THUNAR_APR_ABSTRACT_PAGE (desktop_page)-file == NULL)
@@ -527,20 +525,17 @@
if (G_LIKELY (data != NULL))
{
/* try to save the key file content to disk */
-#if GLIB_CHECK_VERSION(2,8,0)
- g_file_set_contents (filename, data, data_length, error);
-#else
fp = fopen (filename, w);
if (G_LIKELY (fp != NULL))
{
- fwrite (data, data_length, 1, fp);
+ if (fwrite (data, data_length, 1, fp) != 1)
+error = g_error_new_literal (G_FILE_ERROR, g_file_error_from_errno (errno), g_strerror (errno));
fclose (fp);
}
else
{
error = g_error_new_literal (G_FILE_ERROR, g_file_error_from_errno (errno), g_strerror (errno));
}
-#endif
/* cleanup */
g_free (data);
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
On Mon, 2006-05-01 at 16:22 +0200, Benedikt Meurer wrote: Please try the attached patch. it works here, thanks :) -- Yves-Alexis Perez ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Benedikt Meurer wrote: Jari Rahkonen wrote: It seems like the bug is triggered as long as I can write to the file. Everything's fine if I don't have those permissions (e.g. if I set the file permissions to something like -r--r--r-- or the file is owned and only writable by root). That way the widgets in the Launcher tab are insensitive but then the dialog doesn't close unexpectedly. Seems to be a race condition between g_file_set_content() and inotify. Please try the attached patch. Works here! Thanks :) Roberto ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Yves-Alexis Perez wrote: On Sat, 2006-04-29 at 22:04 +0200, Stefan Stuhr wrote: It happens for me too, with latest libexo and Thunar SVN. It happens with _any_ desktop file I can read and write to. And most often, after a while is almost instantly. Trying to reproduce that bug I found another weirdness. Trying to open /usr/share/applications makes thunar crash instantly (well, even when I type the path in the pathbar and it tries to complete, it crash) The error is: (thunar:30504): thunar-vfs-CRITICAL **: thunar_vfs_mime_database_get_info_for_name: assertion `strchr (name, '/') == NULL' failed Strace and gdb backtrace: http://heracles.corsac.net/~corsac/thunar.strace http://heracles.corsac.net/~corsac/thunar.gdb Looks like #1696 [1], you can check the patch attached to the bug. Regards, Benedikt [1] http://bugzilla.xfce.org/show_bug.cgi?id=1696 -- Xfce -- small, stable, fast -- http://www.xfce.org/ (__) (oo) /--\/ / ||| * /\---/\ ~~ ~~ Have you mooed today?... ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
On Sun, 2006-04-30 at 09:58 +0200, Benedikt Meurer wrote: Looks like #1696 [1], you can check the patch attached to the bug. Ah yes, sorry I didn't check the bugzilla. That patch works, and will be applied to debian sources. Thanks :) -- Yves-Alexis Perez ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Roberto Pariset wrote: Hi Benny, Hey Roberto, I noticed that if I right-clic on Proprieties on the context menu of a .desktop file and then select Launcher, the Proprieties windows closes unexpectedly after a while, while Thunar is sill there working. Can you send me that .desktop file? Sure. Thunar B1 .desktop is an example. I also noticed (but it requires more testing) that clicking on another label (!Launcher) and then moving to Launcher with cursors doesn't seem to make it crash. Maybe it's a gtk problem? Only the dialog closes, right? This does not crash Thunar? Can you reproduce it with xfdesktop? Rob Benedikt ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Benedikt Meurer wrote: Roberto Pariset wrote: Hi Benny, Hey Roberto, I noticed that if I right-clic on Proprieties on the context menu of a .desktop file and then select Launcher, the Proprieties windows closes unexpectedly after a while, while Thunar is sill there working. Can you send me that .desktop file? Sure. Thunar B1 .desktop is an example. I also noticed (but it requires more testing) that clicking on another label (!Launcher) and then moving to Launcher with cursors doesn't seem to make it crash. Maybe it's a gtk problem? Only the dialog closes, right? This does not crash Thunar? Can you reproduce it with xfdesktop? I can confirm the bug and Thunar indeed does not crash. The dialog just closes unexpectedly. This doesn't seem to happen if I haven't got write permissions to the .desktop file. As described in bug #1701 (and #1702 I guess), in xfdesktop the dialog doesn't close like it does in Thunar, but it produces (non-responsive) duplicates of the icon when you open the Launcher tab and when you fiddle with the widgets in it. I can confirm that no extra icons appear if I navigate to the Launcher tab using the keyboard instead of the mouse. However, using the down arrow or tab to focus one of the entry or checkbutton widgets still triggers the bug. I don't pretend to understand anything here, but wouldn't it be possible that this was a side-effect (read: bug) of the way .desktop file icons are named according to their Name field instead of the actual filename? Maybe there's some part of the code that doesn't take this into account properly? And maybe the difference in Thunar and xfdesktop behavior has something to do with the way xfdesktop moves file icons around when they are renamed. Or maybe I should just go to bed already... Rob Benedikt - Jari PS. Who killed foo-projects.org? I haven't been able to access the mailing list archives for several days. ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Roberto Pariset wrote: Hi again :) Hey Roberto, I noticed that if I right-clic on Proprieties on the context menu of a .desktop file and then select Launcher, the Proprieties windows closes unexpectedly after a while, while Thunar is sill there working. Can you send me that .desktop file? Another thing: if I use the Tree Pane it's slower to access directories, because for each click on the right pane it has to do an in-depth research and load the tree on the left (or so I believe). Loading is done in parallel and the tree view is pretty fast once the folders are loaded. But of course parallel means that it still depends on the I/O performance of your system. There's not much one can do to further speed up the tree view. Just wanted to point things out :) Thanks, Roberto Benedikt ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
lør, 29 04 2006 kl. 14:35 +0200, skrev Benedikt Meurer: Roberto Pariset wrote: I noticed that if I right-clic on Proprieties on the context menu of a .desktop file and then select Launcher, the Proprieties windows closes unexpectedly after a while, while Thunar is sill there working. Can you send me that .desktop file? It happens for me too, with latest libexo and Thunar SVN. It happens with _any_ desktop file I can read and write to. And most often, after a while is almost instantly. Benedikt Stefan ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
On Sat, 2006-04-29 at 22:04 +0200, Stefan Stuhr wrote: It happens for me too, with latest libexo and Thunar SVN. It happens with _any_ desktop file I can read and write to. And most often, after a while is almost instantly. Trying to reproduce that bug I found another weirdness. Trying to open /usr/share/applications makes thunar crash instantly (well, even when I type the path in the pathbar and it tries to complete, it crash) The error is: (thunar:30504): thunar-vfs-CRITICAL **: thunar_vfs_mime_database_get_info_for_name: assertion `strchr (name, '/') == NULL' failed Strace and gdb backtrace: http://heracles.corsac.net/~corsac/thunar.strace http://heracles.corsac.net/~corsac/thunar.gdb Regards, -- Yves-Alexis Perez ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Yves-Alexis Perez wrote: On Sat, 2006-04-29 at 22:04 +0200, Stefan Stuhr wrote: It happens for me too, with latest libexo and Thunar SVN. It happens with _any_ desktop file I can read and write to. And most often, after a while is almost instantly. Trying to reproduce that bug I found another weirdness. Trying to open /usr/share/applications makes thunar crash instantly (well, even when I type the path in the pathbar and it tries to complete, it crash) The error is: (thunar:30504): thunar-vfs-CRITICAL **: thunar_vfs_mime_database_get_info_for_name: assertion `strchr (name, '/') == NULL' failed Strace and gdb backtrace: http://heracles.corsac.net/~corsac/thunar.strace http://heracles.corsac.net/~corsac/thunar.gdb Regards, I can reproduce it (with B1), and it happens after hitting enter, i.e. when it actually reads the contents of the directory. Same happens if I access that path using clicks. .desktop files seem problematic :-S rob ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] B1 weirdness
Trying to reproduce that bug I found another weirdness. Trying to open /usr/share/applications makes thunar crash instantly (well, even when I type the path in the pathbar and it tries to complete, it crash) The error is: (thunar:30504): thunar-vfs-CRITICAL **: thunar_vfs_mime_database_get_info_for_name: assertion `strchr (name, '/') == NULL' failed I saw this too with beta1, but current svn fixes it (or just makes is harder to trigger) Jani ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
