jk,jni and tomca4.1.18
Hi all, we write to you because we have a great problem and we have not seen any information about it in all the mailing lists we have checked. We have our own Web Server and we are trying to integrate with Tomcat. We are developing a connector via JNI, and jk ( not jk2 ) Our Tomcat version is 4.1.18 and jk is 1.2.2 When we call wc_open() from our connector, we receive this message: Can't find class org/apache/tomcat/modules/server/JNIEndpoint We have seen this class is part of Tomcat 3.X If we include in worker.properties: worker.inprocess.bridge=tomcat41 we get Bridge type 41 not supported Is our configuration not supported ??? If the solution is jk2, where can we find documentation about how constructing our connector ? We have seen in the mailing-lists that there are problems with jk2 and JNI: is that correct? Thanks in advance for your help Jorge Alonso de Armiño Escudero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: RequestDispatcher and WEB-INF
Hi This is with reference to my query in the thread: http://marc.theaimsgroup.com/?l=tomcat-userm=104574185420433w=2 Can somebody here tell me why I cannot use RequestDispatcher to get the resource /WEB-INF/my.exe? Thanks ~rf --- Erik Price [EMAIL PROTECTED] wrote: rf wrote: It is strange that RequestDispatcher considers only jsp and html, why not other extns like jpg/gif or why not just any other resource - is this because of any security concern? I don't think it's security, but I looked at the Servlet spec (page 55) and couldn't find a specific reason. It looks like it was originally intended that a RequestDispatcher should represent only a servlet, and that you could forward to that servlet to continue processing the request, but there is also the include method of RequestDispatcher for when you wish to output /some/ data and then allow the included resource to continue processing. Perhaps the very fact that HTML files are allowed to be the target resources of RequestDispatchers at all was added on at some later point for developer convenience. Certainly there is more [programmatic] flexibility if you are forwarding to or including a servlet (or JSP, which is really a servlet). Erik - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Tax Center - forms, calculators, tips, more http://taxes.yahoo.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP] Build Failure - jakarta-tomcat-5
This email is autogenerated from the output from: http://cvs.apache.org/builds/gump/2003-02-27/jakarta-tomcat-5.html Buildfile: build.xml prepare-release: [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release/v5.0 [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release/v5.0/bin [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release/v5.0/src init: [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build/classes [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build/server/lib [mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib deploy-static: deploy: [echo] Target: Servlet API - Dist ... prepare: static: compile: examples: javadoc: jar: [copy] Copying 1 file to /home/rubys/jakarta/jakarta-servletapi-5/jsr154/build dist: [echo] Target: JSP API - Dist ... prepare: static: compile: examples: javadoc: jar: [copy] Copying 1 file to /home/rubys/jakarta/jakarta-servletapi-5/jsr152/build dist: [echo] Target: Modeler - Dist ... BUILD FAILED file:///home/rubys/jakarta/jakarta-tomcat-5/build.xml:570: Basedir /usr/local/commons-modeler-1.1dev does not exist Total time: 7 seconds - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Maybe a new addon for TomCat?!
Federico wrote: For everyone who want to test our software and tell us how it is: 1)We require a JVM 1.4.0 because we use regular expression and something else Why not use jakartas regexp/oro instead, it will make your code 1.3.1 ready. 2) Yes it's a stand alone application, maybe we can do a module of TomCat if someone told us This is the link where you can download it to test it, http://irc.dis.uniroma1.it/~nous/puff.zip . When you unzip you must start the server proxy with the class starter (java starter) and then you have to set the port and the other feature with the GUI that is in the subdirectory GUI, from which you have to start the class PuffConf (java PuffConf). Here you have to insert login (administrator), pass(dragon),server(your ip). Then in the second dialog you have to select the port where you want to bind the proxy and the max slot number (SLOT MASSIMI IN CACHE). Then you can test the proxy with the two feature that are black and white (in the version that i give you gif are not implemented but i have'nt now the last copy) selecting BIANCO E NERO ATTIVATO and then the spider that prefetch the web selecting SPIDER ATTIVATO. Now you can start the proxy turning back in the first dialog and selecting AVVIA PROXY radiobutton then click ESEGUI. Now the proxy is started. Set it in your browser with the port you have selected and then start browsing internet and tell us what you think about it. (Sorry for the GUI in italian and not in English ;)) I'll take a look at the just grabbed code - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
Sven Köhler wrote:
void processConnection(MsgContext ep) {
try {
MsgAjp recv=new MsgAjp();
while( running ) {
int status= this.receive( recv, ep );
i looked into these sources, and i am shocked!!!
this.receive() uses this.read(), and this method finally calls the
InputStream.read(). as everybody should know, InputStrean.read() returns
-1 if the end of the inputstream is reached.
this case is checked, but instead of doing something useful, the case is
not really handled.
It's handled, the connection is closed.
i suggest throwing an EOSException (EOS=EndOfStream) which is derived
from IOException.
as this.read() is supposed to read exactly len bytes, it should only
throw the EOSException, if the first call of InputStream.read() in the
loop returns -1.
I'd prefer avoid generation too many exceptions in real-time
environnement. After all if read return something 0, the loop
is exited and the connection closed in the finally block.
FYI, Apache close ajp13 connections each time it recycle/kill a child
and under heavy load on webserver, it happen very often.
If the webserver has closed a connection, tomcat detect it has close the
connection silently
This exception can be catched down below, to more gracefully handle a
connection-close.
BTW: there's also a comment that this improvement should be in AJP14.
This has nothing to do with AJP14 (which is a protocol) but it's just
bad programmed.
May be.
Usually I'd rather like see patches instead of coding style critics.
You're welcome to provide us your solution.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
Sven Köhler wrote: Could you give us more information : - jk version you're using (jk or jk2) mod_jk (not mod_jk 2) version 1.2.2 - Apache webserver (1.3/2.0) apache 1.3.27 - Operating system hosting tomcat and apache it's suse linux 7.3 with kernel 2.4.20 with sun jdk 1.4.1_01 This message appears in tomcat in wait for ajp message, since Operating system return Read timed out instead of Read error. read-error should not happen, as mod_jk could send a quit-paket or something (analog to the ftp-protocol) read-error happen BECAUSE APACHE HTTPD server close client when it recycle them. In such case, the connection is dropped and when tomcat see the connection close, it close it's own side of the connection and free the thread. How many times we discussed this on tomcat-user and tomcat-dev lists. Did you take a look at mailing list archives before ? if mod_jk doesn't do that, it's a design-error. Again, you're welcome to provide a better design. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17481] New: - HotSpot VM Error 11 When Tomcat is load tested.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17481. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17481 HotSpot VM Error 11 When Tomcat is load tested. Summary: HotSpot VM Error 11 When Tomcat is load tested. Product: Tomcat 4 Version: 4.0.6 Final Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Critical Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In completing our performance testing of our web-application running under Tomcat we are experiencing the following error: Unexpected Signal : 11 occurred at PC=0x401bf49a Function name=scavenge_oop_with_check__8ScavengePP7oopDesc Library=/usr/local/j2sdk1.3.1/jre/lib/i386/client/libjvm.so # # HotSpot Virtual Machine Error : 11 # Error ID : 4F530E43505002C4 # Please report this error at # http://java.sun.com/cgi-bin/bugreport.cgi # # Java VM: Java HotSpot(TM) Client VM (Blackdown-1.3.1_02b-FCS mixed mode) After this error all Tomcat processes are terminated. The first time this happened I reported the bug to both Blackdown and Sun who have suggested that it is an application or tomcat problem. As it has now happened again and I can find no trace of a problem in our application I am raising it here. I cannot re-produce (at will) this error but it seems to happen when Tomcat is busy - the latest occurence was when we were load testing the system with 40 users continuously hitting the server (a stress test). Reading various forums and posts on the internet this seems to be a common problem with people pointing to system resource issues as the root cause but I do think this is the case here as we have loads of spare disk and 2Gb of RAM - also at the time of occurence the system was not doing anything other than the load testing described above. Has anyone seen this ? Is this is a bug in Tomcat ? Is it a resource issue ? Whatever I would appreciate some help as this is causing us serious problems. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
read-error should not happen, as mod_jk could send a quit-paket or something (analog to the ftp-protocol) read-error happen BECAUSE APACHE HTTPD server close client when it recycle them. i hoped, you would react on this one. i'm not very much into apache httpd's internals, but i guess, that a child isn't just killed, but notified to terminate itself (OK, perhaps a kill-signal is used), but the question is, if mod_jk is called when a child exits/gets killed. if mod_jk can catch this case, it should gracefully close the connection (like quit-command in FTP-protocol), so tomcat knows, that everything is OK. i know, that apache kills and spawns new child every now and than, but as this is normal, this should be handled more gracefully. i cannot supply you with a patch, because i'm not that good in writing apache-modules (in fact, i never did that before, and i didn't write any C/C++ for some years now) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
i looked into these sources, and i am shocked!!! this.receive() uses this.read(), and this method finally calls the InputStream.read(). as everybody should know, InputStrean.read() returns -1 if the end of the inputstream is reached. this case is checked, but instead of doing something useful, the case is not really handled. It's handled, the connection is closed. yes, but it's important to be abled to differ between a normal connection shutdown, and a erroneous connection shutdown. i don't see such a difference in the code right now. i suggest throwing an EOSException (EOS=EndOfStream) which is derived from IOException. as this.read() is supposed to read exactly len bytes, it should only throw the EOSException, if the first call of InputStream.read() in the loop returns -1. I'd prefer avoid generation too many exceptions in real-time environnement. After all if read return something 0, the loop is exited and the connection closed in the finally block. return special values is quite C-stylish. using exception is the OOP way. i don't know, if throwing an exception is that slow, although a new object has to be created every time :-( which might make things slow. on the other hand, exceptions don't occur very often (that's why they're called exceptions) and they shouldn't make it that slow. FYI, Apache close ajp13 connections each time it recycle/kill a child and under heavy load on webserver, it happen very often. that makes it even worse. If the webserver has closed a connection, tomcat detect it has close the connection silently ... except writing those messages to the log. Usually I'd rather like see patches instead of coding style critics. You're welcome to provide us your solution. I'm currently trying to compile tomcat (checked out from cvs) and i will supply you with a patch as soon as i've solved the problem. cu Sven - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17492] New: - If the omit-xml-declaration attribute of jsp:output is 'true' or 'yes' in the context of a JSP document, the xml declaration is still generated.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17492. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17492 If the omit-xml-declaration attribute of jsp:output is 'true' or 'yes' in the context of a JSP document, the xml declaration is still generated. Summary: If the omit-xml-declaration attribute of jsp:output is 'true' or 'yes' in the context of a JSP document, the xml declaration is still generated. Product: Tomcat 5 Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Jasper2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Interestingly enough, if the same situation occurs within a Tag file in XML syntax, the behavior is as expected and no declaration is generated. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: commons-modeler in jtc and catalina
Costin Manolache wrote: Jeanfrancois Arcand wrote: Costin, are you planning to tag the modeler workspace to reflect all you recent changes (once they are completed of course)? Something like MODELER_2_0_alpha (I'm not good for name) will be helpfull. Also, is this module supposed to build by itself? Right now the build.xml has a dependency on jakarta-commons. Bundling Tomcat 5 source creates huge zip file (50mg) mostly due to jakarta-commons source dependency. If the dependency is not required, I would be happy to help fixing the build.xml.. It wouldn't be bad if the source zip would include the commons code that we use - modeler, logging, digester, beanutils, collections. But you can fix it to include only tomcat-specific code, since commons has its own src distribution. Actually, this is what I'm doing, except I also include all the jakarta-commons. I guess I should change my script to only include the required one. I don't know if you follow the discussion on the repository - it'll probably affect us a lot. If things settle down and an agreement is reached - we should modify our build acordingly. That may mean we'll have to include version numbers in jars ( if this is voted ), start downloading and uploading to the repository, etc. Yes I'm following the discussion (read you post :-) ) Probably the some of the download script could be replaced with ruper or some other task ( I hope Ant1.6 will include such a thing by default ). Regarding the tag - I think it would be a good idea to tag it with each milestone of tomcat5. OK. BTW - in order to release modeler we need at least 3 +1 votes - so far I feel a bit alone :-) Is anyone else interested in this piece ? I am :-) If I can collaborate, guide me to what we need to do for releasing it :-) -- Jeanfrancois Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
Sven Köhler wrote: read-error should not happen, as mod_jk could send a quit-paket or something (analog to the ftp-protocol) read-error happen BECAUSE APACHE HTTPD server close client when it recycle them. i hoped, you would react on this one. What's the problem with this connection closing handling ? tomcat detect a closed connection, and close its own socket side then free the thread. i'm not very much into apache httpd's internals, but i guess, that a child isn't just killed, but notified to terminate itself (OK, perhaps a kill-signal is used), but the question is, if mod_jk is called when a child exits/gets killed. if mod_jk can catch this case, it should gracefully close the connection (like quit-command in FTP-protocol), so tomcat knows, that everything is OK. As I said previously, Apache kill childs under heavy load, and you want add extra delays by sending a message to warn tomcat that the connection will be closed ? Another point is that adding new message to protocol make it incompatible with olders java implementations or with alternate implementations (like jetty). That was one of the reason why I started to think about an ajp13++ or ajp14. i know, that apache kills and spawns new child every now and than, but as this is normal, this should be handled more gracefully. i cannot supply you with a patch, because i'm not that good in writing apache-modules (in fact, i never did that before, and i didn't write any C/C++ for some years now) I don't see, for now, much need for Tomcat to know that the connection has been dropped gracefully or abnormally, since it will make us : - update the protocol paper (easy) - update java side implementations (easy for JTC, dunno for Jetty, may be impossible for Tomcat 3.2.x). - add native side code to trap child/thread handle the shutdown more gracefully. Updating the protocol may create problems with old implementations and as such will great unnecessary questions/problems reports from users... I'd rather like to see such energy invested in jk2 and ajp13 extensions. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16598] - request causing jk exception
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16598. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16598 request causing jk exception --- Additional Comments From [EMAIL PROTECTED] 2003-02-27 15:53 --- I just tried this with tomcat-4.1.20 and the problem persists please can someone fix this and not just close the bug. FYI I noticed the pust included '.' at the end of each line, this is put out by the packet sniffer and causes a 400 error if you past this into the connection. The below post will cause tomcat to stack trace with no output from the webserver. POST /_vti_bin/shtml.exe/_vti_rpc HTTP/1.1 Date: Tue, 28 Jan 2003 16:30:01 GMT MIME-Version: 1.0 User-Agent: MSFrontPage/4.0 Host: newprnj.eu.prnews.net Accept: auth/sicily Content-Length: 41 Content-Type: application/x-www-form-urlencoded X-Vermeer-Content-Type: application/x-www-form-urlencoded Connection: Keep-Alive Cache-Control: no-cache method=server+version%3a4%2e0%2e2%2e4715 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
Sven Köhler wrote: i looked into these sources, and i am shocked!!! this.receive() uses this.read(), and this method finally calls the InputStream.read(). as everybody should know, InputStrean.read() returns -1 if the end of the inputstream is reached. this case is checked, but instead of doing something useful, the case is not really handled. It's handled, the connection is closed. yes, but it's important to be abled to differ between a normal connection shutdown, and a erroneous connection shutdown. i don't see such a difference in the code right now. There is no difference... i suggest throwing an EOSException (EOS=EndOfStream) which is derived from IOException. as this.read() is supposed to read exactly len bytes, it should only throw the EOSException, if the first call of InputStream.read() in the loop returns -1. I'd prefer avoid generation too many exceptions in real-time environnement. After all if read return something 0, the loop is exited and the connection closed in the finally block. return special values is quite C-stylish. If you want to have quick java programs, you shouldn't be too OOPist. using exception is the OOP way. i don't know, if throwing an exception is that slow, although a new object has to be created every time :-( which might make things slow. Yes, Exception is a special object which is costly to create and costly to trap. on the other hand, exceptions don't occur very often (that's why they're called exceptions) and they shouldn't make it that slow. When Apache will be closing connections at a high rate, you make Tomcat spend precious cycle to catch exceptions, and so you'll slow tomcat also. FYI, Apache close ajp13 connections each time it recycle/kill a child and under heavy load on webserver, it happen very often. that makes it even worse. Contact new-httpd team ;) If the webserver has closed a connection, tomcat detect it has close the connection silently ... except writing those messages to the log. Usually I'd rather like see patches instead of coding style critics. You're welcome to provide us your solution. I'm currently trying to compile tomcat (checked out from cvs) and i will supply you with a patch as soon as i've solved the problem. I'll study your patch at this time. BTW, you should also consider that Windows TCP implementation differs a little from the one in Unix (see the catch code) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Default context as a war archive (bug?)
hi, I notice a weird behavior in tomcat 4.1.18 on W2k. when the default Context is in a unexpanded war file, the context cannot be initialized in startup. for example: 1. in server.xml: Context path= docBase=ROOT1 debug=0/ 2. under webapps/ dir: ROOT1.war if ROOT1.war is extracted, it works perfectly. but if it is in a war file, then the default context is not initialized and is unaccessible. is it a bug? should I report it to bugzilla? Regards, mingfai - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[4.1.21] Stability rating
ballot [ ] Alpha [ ] Beta [ ] Stable (GA) /ballot Please vote (after testing the release, if possible ;). Thanks, Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [4.1.21] Stability rating
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 10:52 AM To: Tomcat Developers List Subject: [4.1.21] Stability rating ballot [ ] Alpha [ ] Beta [X] Stable (GA) /ballot Please vote (after testing the release, if possible ;). Thanks, Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
Yes, Exception is a special object which is costly to create and costly to trap. i hope, that catching Exception is optimized by the Java, because it happens quite often in java-programs. creating on exception object, throwing it etc. should happen quite seldom. When Apache will be closing connections at a high rate, you make Tomcat spend precious cycle to catch exceptions, and so you'll slow tomcat also. i respect that within my patch. I'll study your patch at this time. BTW, you should also consider that Windows TCP implementation differs a little from the one in Unix (see the catch code) I will do tests on both platforms. Where should i send my patch? I think i'll have something ready within the next two weeks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: ant and jtc
Henri Gomez wrote: From what I see, it seems we also need ant HEAD to compile parts of JTC (JndiProperties). Did this stuff will be in ant 1.5.2 release ? JndiProperties is not required for anything - it's part of a refactoring of naming, but we don't use it in any way. It shouldn't be included in tomcat (since it's not even close to ready ). I hope ant1.6 will be released by the time jtc/naming is done. Dynamic properties will not be included in 1.5.2 ( it's a new feature, like import ). It is easy to add conditional compilation for that (I'll probably do that for modeler, if I check in the jmx dynamic properties ), but since naming is experimental I didn't do it yet. BTW, there are many good reasons to move to ant1.6 - it is a bit faster ( startup time ), uses SAX2 ( so namespaces are possible ), import, dynamic properties, etc. I hope it'll eventually include an improved download task ( like the one discussed on community ). Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: commons-modeler in jtc and catalina
Jeanfrancois Arcand wrote: BTW - in order to release modeler we need at least 3 +1 votes - so far I feel a bit alone :-) Is anyone else interested in this piece ? I am :-) If I can collaborate, guide me to what we need to do for releasing it :-) I don't know :-) I'm just fixing itches as I discover them. The thing I miss the most is feedback - has anyone tried the embed target ? Was anyone able to run tomcat using the JMX ant tasks ? Some time ago I checked in a feature that allow people to add/remove/restart Contexts using exclusively JMX. Has anyone used this ? Is it worth doing the same for connectors and other components ? Modeler is mostly driven by tomcat JMX-ification. The code is as stable as it allways was - I don't think I broke any existing API. The new features to support beans that are not explicitely declared in the descriptors.xml file seem to work fine and seems stable. The main issue is the new APIs - since they evolved based on the various needs in tomcat. A release would froze them - and they had almost no external feedback. In general - I have the feeling I'm the only user of the new features - and that is really bad and it slows everything down. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17503] New: - If jsp:output is specified in a Tag file in XML syntax without the omit-xml-declaration attribute, jasper incorrectly generates a declaration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17503. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17503 If jsp:output is specified in a Tag file in XML syntax without the omit-xml-declaration attribute, jasper incorrectly generates a declaration Summary: If jsp:output is specified in a Tag file in XML syntax without the omit-xml-declaration attribute, jasper incorrectly generates a declaration Product: Tomcat 5 Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Jasper2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] According to JSP.5.16 The default value for a tag file in XML syntax is always 'yes' Give a Tag file in XML syntax simiar to: ?xml version=1.0? root xmlns:jsp=http://java.sun.com/JSP/Page; jsp:output / /root The following output is generated by a JSP page that does nothing but invoke the tag: ?xml version=1.0 encoding=UTF-8? root/root - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17504] New: - JDBCRealm start() opens but does not close connection.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504
JDBCRealm start() opens but does not close connection.
Summary: JDBCRealm start() opens but does not close connection.
Product: Tomcat 4
Version: 4.1.18
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The start method in JDBCRealm.java opens a connection to make sure that
everyting is ok, but it never closes that connection. This method should call
close(connection).
This is the offending code:
public void start() throws LifecycleException {
// Validate that we can open our connection
try {
open();
} catch (SQLException e) {
throw new LifecycleException(sm.getString(jdbcRealm.open), e);
}
// Perform normal superclass initialization
super.start();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
craigmcc2003/02/27 11:14:14
Modified:.build.xml
Log:
Local build.properties settings should win over ${user.home}/build.properties
settings.
Revision ChangesPath
1.90 +1 -1 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.89
retrieving revision 1.90
diff -u -r1.89 -r1.90
--- build.xml 26 Feb 2003 19:40:33 - 1.89
+++ build.xml 27 Feb 2003 19:14:14 - 1.90
@@ -5,8 +5,8 @@
!-- See build.properties.sample in the top level directory for all --
!-- property values you must customize for successful building!!!--
- property file=${user.home}/build.properties/
property file=build.properties/
+ property file=${user.home}/build.properties/
property file=build.properties.default/
!-- Project Properties --
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17505] New: - JspC misplaces java files if Jsp directory has a '.' in the name
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17505. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17505 JspC misplaces java files if Jsp directory has a '.' in the name Summary: JspC misplaces java files if Jsp directory has a '.' in the name Product: Tomcat 4 Version: 4.1.21 Platform: Other OS/Version: Other Status: NEW Severity: Blocker Priority: Other Component: Jasper 2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] e.g. /somedir/customize/test.netfolio.com/shell.jsp The packagage name is generated correctly, that is the '.' is mangled so that it is a legit package name. However, the generated java file is still put into a directory named test.netfolio.com, rather than test_0002enetfolio_0002ecom. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17492] - If the omit-xml-declaration attribute of jsp:output is 'true' or 'yes' in the context of a JSP document, the xml declaration is still generated.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17492. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17492 If the omit-xml-declaration attribute of jsp:output is 'true' or 'yes' in the context of a JSP document, the xml declaration is still generated. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
luehe 2003/02/27 12:10:13
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Log:
Fixed 17492: If the omit-xml-declaration attribute of jsp:output is
'true' or 'yes' in the context of a JSP document, the xml declaration
is still generated.
Revision ChangesPath
1.170 +8 -7
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.169
retrieving revision 1.170
diff -u -r1.169 -r1.170
--- Generator.java26 Feb 2003 22:58:15 - 1.169
+++ Generator.java27 Feb 2003 20:10:13 - 1.170
@@ -601,10 +601,11 @@
* - JSP document without a jsp:root
*/
private void generateXmlDeclaration(Node.Nodes page) {
- if (pageInfo.getOmitXmlDecl() != null
- !JspUtil.booleanValue(pageInfo.getOmitXmlDecl())
- || (page.getRoot().isXmlSyntax() !pageInfo.hasJspRoot()
- !ctxt.isTagFile())) {
+
+ String omitXmlDecl = pageInfo.getOmitXmlDecl();
+ if ((omitXmlDecl != null !JspUtil.booleanValue(omitXmlDecl))
+ || (omitXmlDecl == null page.getRoot().isXmlSyntax()
+ !pageInfo.hasJspRoot() !ctxt.isTagFile())) {
String cType = pageInfo.getContentType();
String charSet = cType.substring(cType.indexOf(charset=)+8);
out.printil(out.write(\?xml version=\\\1.0\\\ encoding=\\\ +
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Default context as a war archive (bug?)
1. in server.xml: Context path= docBase=ROOT1 debug=0/ ^ ROOT1.war should work - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [4.1.21] Stability rating
I tested my application on it and everything seems OK. FWIW, though, because I am not a committer. George Sexton MH Software, Inc. Home of Connect Daily Web Calendar Software http://www.mhsoftware.com/connectdaily.htm Voice: 303 438 9585 -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 8:52 AM To: Tomcat Developers List Subject: [4.1.21] Stability rating ballot [ ] Alpha [ ] Beta [X] Stable (GA) /ballot Please vote (after testing the release, if possible ;). Thanks, Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
Henri Gomez wrote: Sven Köhler wrote: When Apache will be closing connections at a high rate, you make Tomcat spend precious cycle to catch exceptions, and so you'll slow tomcat also. FYI, Apache close ajp13 connections each time it recycle/kill a child and under heavy load on webserver, it happen very often. I also dislike how mod_jk handles ajp socket connections. There is another problem with how mod_jk handles the ajp connetor sockets. That is the one to one mapping of apache child process to an ajp connector. On an apache server that serves normal http requests you can end up with many idle socket connections to Tomcat, and Tomcat will spawn many more Connector threads than it needs to handle the request volume. I have been toying with the idea of implementing a global worker socket connection pool using APR for the Apache 2 version of mod_jk 1.2. A global pool would allow the sockets to survive a child exit so they don't have to be closed/reopened. This would also reduce the number of socket connections and Tomcat Connectors to the bare miniumum needed to handle the request volume. This would get rid of the normal operation exceptions and would not require changing the AJP protocol. This could also be done with mod_jk for Apache 1.3 if a dependency on the APR were added. In the end, I think this is the best solution. Regards, Glenn that makes it even worse. Contact new-httpd team ;) If the webserver has closed a connection, tomcat detect it has close the connection silently - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat 302 Redirect Issue
A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17503] - If jsp:output is specified in a Tag file in XML syntax without the omit-xml-declaration attribute, jasper incorrectly generates a declaration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17503. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17503 If jsp:output is specified in a Tag file in XML syntax without the omit-xml-declaration attribute, jasper incorrectly generates a declaration [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-02-27 22:19 --- Seems to be build related as after a complete clean it works. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: socket errors in catalina.out and mod_jk.log
There is another problem with how mod_jk handles the ajp connetor sockets. That is the one to one mapping of apache child process to an ajp connector. On an apache server that serves normal http requests you can end up with many idle socket connections to Tomcat, and Tomcat will spawn many more Connector threads than it needs to handle the request volume. Changing this, is much work, and it might get better with Apache 2.0 as it uses Threads. I took a short look at the ajp13 protocol draft, and the design of the protocol is really simple, too simple. I can't see any possibility to send idle-packets to prevent a connection from timing out. That's a basic requirement, but it seems, that nobody thought of it. It also doens't include a quit-command (quits the connection), but a shutdown-command (shuts down the servlet container, i think it's unused at the moment). so tomcat's connections will keep timing out, and i see no sollution for this with the current protocl design. I cannot find a describtion of some kind of simple handshake in the draft i've found. so mod_jk is totally unaware of the server it's talking too. I think, AJP needs a better design than AJP13. all i found about AJP14 shows, that it comes with more features, but doesn't give a damn on the basic-problems. But AJP was flamed enough now! If we have enough ideas, we could write our own connector for Tomcat and a module for Apache HTTPD. Any volunteers ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17509] New: - Jasper erroneously optimises BodyTag instances with no body
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17509. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17509 Jasper erroneously optimises BodyTag instances with no body Summary: Jasper erroneously optimises BodyTag instances with no body Product: Tomcat 4 Version: 4.1.18 Platform: Macintosh OS/Version: MacOS X Status: NEW Severity: Critical Priority: Other Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Starting with Tomcat 4.0, Jasper is checking to see whether or not a BodyTag's body is empty before emitting the code to call doInitBody(), setBodyContent(), and doAfterBody(). If it is, it skips the call, ignores the result of doStartTag(), and simply emits a call to doEndTag(). The problem occurs for tags which contain logic in doAfterBody() which might emit results even if the body is empty. Our project contains several tags which, for reuse purposes, may either take their parameter(s) as subelements or as attributes. If the body is empty, the attribute value will be used in its stead. When I attempted to install our application using Tomcat 4.1.18, none of these tags actually did anything. :-) A simple removal of the check for a null body fixed the problem for me. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Tomcat 302 Redirect Issue
Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Re: socket errors in catalina.out and mod_jk.log
Why not restart work on mod_webapp? I still wonder why it got dropped. Travis Original Message From: =?ISO-8859-1?Q?Sven_K=F6hler?= [EMAIL PROTECTED] Sent: 2003-02-27 To: [EMAIL PROTECTED] Subject: Re: socket errors in catalina.out and mod_jk.log There is another problem with how mod_jk handles the ajp connetor sockets. That is the one to one mapping of apache child process to an ajp connector. On an apache server that serves normal http requests you can end up with many idle socket connections to Tomcat, and Tomcat will spawn many more Connector threads than it needs to handle the request volume. Changing this, is much work, and it might get better with Apache 2.0 as it uses Threads. I took a short look at the ajp13 protocol draft, and the design of the protocol is really simple, too simple. I can't see any possibility to send idle-packets to prevent a connection from timing out. That's a basic requirement, but it seems, that nobody thought of it. It also doens't include a quit-command (quits the connection), but a shutdown-command (shuts down the servlet container, i think it's unused at the moment). so tomcat's connections will keep timing out, and i see no sollution for this with the current protocl design. I cannot find a describtion of some kind of simple handshake in the draft i've found. so mod_jk is totally unaware of the server it's talking too. I think, AJP needs a better design than AJP13. all i found about AJP14 shows, that it comes with more features, but doesn't give a damn on the basic-problems. But AJP was flamed enough now! If we have enough ideas, we could write our own connector for Tomcat and a module for Apache HTTPD. Any volunteers ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Tomcat 302 Redirect Issue
really? Do I need to do any recompilations or I simply replace the class? Yes, PLEASE send it to me! :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:22 PM To: Tomcat Developers List Subject: RE: Tomcat 302 Redirect Issue Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: RE: Tomcat 302 Redirect Issue
No recompilations, you using 4.1.18? Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: Tomcat 302 Redirect Issue really? Do I need to do any recompilations or I simply replace the class? Yes, PLEASE send it to me! :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:22 PM To: Tomcat Developers List Subject: RE: Tomcat 302 Redirect Issue Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JasperLoader.java
kinman 2003/02/27 14:51:38
Modified:jasper2/src/share/org/apache/jasper JspC.java
JspCompilationContext.java
jasper2/src/share/org/apache/jasper/compiler Compiler.java
jasper2/src/share/org/apache/jasper/servlet
JasperLoader.java
Log:
- Fixes to make Jspc work:
* Make sure the correct classloader is used.
* Mangle package names if they contain Java keywords.
Revision ChangesPath
1.35 +46 -15
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
Index: JspC.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- JspC.java 26 Feb 2003 16:36:13 - 1.34
+++ JspC.java 27 Feb 2003 22:51:38 - 1.35
@@ -573,17 +573,12 @@
Compiler clc = clctxt.createCompiler();
this.setOutputDir( baseDir );
-if( compile ) {
-// Generate both .class and .java
-if( clc.isOutDated() ) {
-clc.compile();
-}
-} else {
-// Only generate .java, compilation is separated
-// Don't compile if the .class file is newer than the .jsp file
-if( clc.isOutDated(false) ) {
-clc.generateJava();
-}
+// If compile is set, generate both .java and .class, if
+// .jsp file is newer than .class file;
+// Otherwise only generate .java, if .jsp file is newer than
+// the .java file
+if( clc.isOutDated(compile) ) {
+clc.compile(compile);
}
// Generate mapping
@@ -983,17 +978,25 @@
StringBuffer modifiedPackageName = new StringBuffer();
int iSep = jspUri.lastIndexOf('/');
// Start after the first slash
+int nameStart = 1;
for (int i = 1; i iSep; i++) {
char ch = jspUri.charAt(i);
if (Character.isJavaIdentifierPart(ch)) {
modifiedPackageName.append(ch);
}
else if (ch == '/') {
+if (isJavaKeyword(jspUri.substring(nameStart, i))) {
+modifiedPackageName.append('_');
+}
+nameStart = i+1;
modifiedPackageName.append('.');
} else {
modifiedPackageName.append(mangleChar(ch));
}
}
+if (nameStart iSep isJavaKeyword(jspUri.substring(nameStart, iSep))) {
+modifiedPackageName.append('_');
+}
return modifiedPackageName.toString();
}
@@ -1018,6 +1021,34 @@
return new String(result);
}
-
+static final String javaKeywords[] = {
+ abstract, boolean, break, byte, case,
+ catch, char, class, const, continue,
+ default, do, double, else, extends,
+ final, finally, float, for, goto,
+ if, implements, import, instanceof, int,
+ interface, long, native, new, package,
+ private, protected, public, return, short,
+ static, strictfp, super, switch, synchronized,
+ this, throws, transient, try, void,
+ volatile, while };
+
+static private boolean isJavaKeyword(String key) {
+ int i = 0;
+ int j = javaKeywords.length;
+ while (i j) {
+ int k = (i+j)/2;
+ int result = javaKeywords[k].compareTo(key);
+ if (result == 0) {
+ return true;
+ }
+ if (result 0) {
+ i = k+1;
+ } else {
+ j = k;
+ }
+ }
+ return false;
+}
}
1.35 +4 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java
Index: JspCompilationContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- JspCompilationContext.java21 Feb 2003 18:23:14 - 1.34
+++ JspCompilationContext.java27 Feb 2003 22:51:38 - 1.35
@@ -589,7 +589,7 @@
jspLoader = new JasperLoader
(outUrls,
getServletPackageName() + . + getServletClassName(),
- rctxt.getParentClassLoader(),
+ getClassLoader(),
rctxt.getPermissionCollection(),
rctxt.getCodeSource());
1.58 +15 -4
RE: RE: RE: Tomcat 302 Redirect Issue
Ok, I'll do that. How can I get that class from you though? (please, please) :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:45 PM To: Tomcat Developers List Subject: RE: RE: RE: Tomcat 302 Redirect Issue I'm pretty sure you will need 4.1.X at least to use, there were some changes between the two in the DefaultServlet Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: RE: Tomcat 302 Redirect Issue No, I'm on 4.0.4 ... though I suppose I could get 4.1.8 if needed. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:34 PM To: Tomcat Developers List Subject: RE: RE: Tomcat 302 Redirect Issue No recompilations, you using 4.1.18? Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: Tomcat 302 Redirect Issue really? Do I need to do any recompilations or I simply replace the class? Yes, PLEASE send it to me! :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:22 PM To: Tomcat Developers List Subject: RE: Tomcat 302 Redirect Issue Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties messages_es.properties messages_fr.properties messages_ja.properties
kinman 2003/02/27 16:12:42
Modified:jasper2/src/share/org/apache/jasper/compiler Parser.java
jasper2/src/share/org/apache/jasper/resources
messages.properties messages_es.properties
messages_fr.properties messages_ja.properties
Log:
- Fix 17387: Bad error message for illegal content in jsp:text
Revision ChangesPath
1.66 +6 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Parser.java
Index: Parser.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Parser.java,v
retrieving revision 1.65
retrieving revision 1.66
diff -u -r1.65 -r1.66
--- Parser.java 26 Feb 2003 17:58:07 - 1.65
+++ Parser.java 28 Feb 2003 00:12:41 - 1.66
@@ -1501,9 +1501,11 @@
new Node.TemplateText( ttext.toString(), start, parent );
-if( !reader.matchesETagWithoutLessThan( jsp:text ) ) {
+ if (! reader.hasMoreInput()) {
err.jspError( start, jsp.error.unterminated,
lt;jsp:textgt; );
+ } else if( !reader.matchesETagWithoutLessThan( jsp:text ) ) {
+err.jspError( start, jsp.error.jsptext.badcontent);
}
}
}
1.102 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
Index: messages.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
retrieving revision 1.101
retrieving revision 1.102
diff -u -r1.101 -r1.102
--- messages.properties 26 Feb 2003 17:10:48 - 1.101
+++ messages.properties 28 Feb 2003 00:12:41 - 1.102
@@ -370,3 +370,4 @@
jsp.error.prelude.xml=The JSP document {0} has a prelude ({1}) associated with it
jsp.error.coda.xml=The JSP document {0} has a coda ({1}) associated with it
jsp.error.attribute.null_name=Null attribute name
+jsp.error.jsptext.badcontent=\'lt;\', when appears in the body of
lt;jsp:textgt;, must be encapsulated within a CDATA
1.36 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_es.properties
Index: messages_es.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_es.properties,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- messages_es.properties24 Feb 2003 23:44:00 - 1.35
+++ messages_es.properties28 Feb 2003 00:12:41 - 1.36
@@ -265,3 +265,4 @@
jsp.error.variable.alias=
jsp.error.prelude.xml=
jsp.error.coda.xml=
+jsp.error.jsptext.badcontent=
1.20 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_fr.properties
Index: messages_fr.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_fr.properties,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- messages_fr.properties24 Feb 2003 23:44:00 - 1.19
+++ messages_fr.properties28 Feb 2003 00:12:41 - 1.20
@@ -303,4 +303,5 @@
jsp.error.variable.alias=
jsp.error.prelude.xml=
jsp.error.coda.xml=
+jsp.error.jsptext.badcontent=
1.36 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_ja.properties
Index: messages_ja.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages_ja.properties,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- messages_ja.properties24 Feb 2003 23:44:00 - 1.35
+++ messages_ja.properties28 Feb 2003 00:12:41 - 1.36
@@ -296,4 +296,5 @@
jsp.error.variable.alias=
jsp.error.prelude.xml=
jsp.error.coda.xml=
+jsp.error.jsptext.badcontent=
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17387] - A misleading error message is generated when providing an invalid body to jsp:text
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17387. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17387 A misleading error message is generated when providing an invalid body to jsp:text [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
ISAPI connector and logging to IIS log file (Patch)
When I was using Tomcat 3.2.x, an year back, I found that the Jakarta ISAPI connector (IIS) doesn't log requests coming into the filter to Native IIS Log file properly. In otherwords, IIS log show the requests as /jakarta/isapi_redirect for all requests. I added that functionality by making some minor changes to jk_isapi_plugin.c and has been working fine for me so far. Today, when I wanted to switch over to Tomcat 4.1.x, I realized that the new version of the connector (isapi_redirect2.dll) still doesn't log the requests correctly. I would like to see this patch in isapi_redirect2.dll as I am sure anyone who logs the requests will find it useful. Can I post the patch to this list ? regards Ramesh - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: RE: RE: Tomcat 302 Redirect Issue
Thanks for the file. Quick question. I replaced the server/lib/* files and was hoping everythign would work fine. But my init servlet which parses an XML file now fails and gives me this odd exception. Any idea why tomcat 4.1.18 would be involving itself in matters such as TraX? Here's the error: Thanks! Neal . Error parsing pageMap.xml: javax.xml.transform.TransformerConfigurationException: javax.xml.transform.TransformerException: javax.xml.transform.TransformerException: org.apache.xml.utils.URI$MalformedURIException: No scheme found in URI -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:45 PM To: Tomcat Developers List Subject: RE: RE: RE: Tomcat 302 Redirect Issue I'm pretty sure you will need 4.1.X at least to use, there were some changes between the two in the DefaultServlet Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: RE: Tomcat 302 Redirect Issue No, I'm on 4.0.4 ... though I suppose I could get 4.1.8 if needed. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:34 PM To: Tomcat Developers List Subject: RE: RE: Tomcat 302 Redirect Issue No recompilations, you using 4.1.18? Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: Tomcat 302 Redirect Issue really? Do I need to do any recompilations or I simply replace the class? Yes, PLEASE send it to me! :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:22 PM To: Tomcat Developers List Subject: RE: Tomcat 302 Redirect Issue Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: RE: RE: RE: Tomcat 302 Redirect Issue
You'll probably want to do a full install. Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: RE: RE: Tomcat 302 Redirect Issue Thanks for the file. Quick question. I replaced the server/lib/* files and was hoping everythign would work fine. But my init servlet which parses an XML file now fails and gives me this odd exception. Any idea why tomcat 4.1.18 would be involving itself in matters such as TraX? Here's the error: Thanks! Neal . Error parsing pageMap.xml: javax.xml.transform.TransformerConfigurationException: javax.xml.transform.TransformerException: javax.xml.transform.TransformerException: org.apache.xml.utils.URI$MalformedURIException: No scheme found in URI -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:45 PM To: Tomcat Developers List Subject: RE: RE: RE: Tomcat 302 Redirect Issue I'm pretty sure you will need 4.1.X at least to use, there were some changes between the two in the DefaultServlet Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: RE: Tomcat 302 Redirect Issue No, I'm on 4.0.4 ... though I suppose I could get 4.1.8 if needed. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:34 PM To: Tomcat Developers List Subject: RE: RE: Tomcat 302 Redirect Issue No recompilations, you using 4.1.18? Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: Tomcat 302 Redirect Issue really? Do I need to do any recompilations or I simply replace the class? Yes, PLEASE send it to me! :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:22 PM To: Tomcat Developers List Subject: RE: Tomcat 302 Redirect Issue Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: RE: RE: RE: Tomcat 302 Redirect Issue
Actually, I just did that on a seperate computer. Clean install of 4.1.18. Installed these classes in tomcat/server/classes and inserted that init-param in the default servlet node of tomcat/config/web.xml. Its still doing the redirect. :( Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 6:59 PM To: Tomcat Developers List Subject: RE: RE: RE: RE: Tomcat 302 Redirect Issue You'll probably want to do a full install. Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: RE: RE: Tomcat 302 Redirect Issue Thanks for the file. Quick question. I replaced the server/lib/* files and was hoping everythign would work fine. But my init servlet which parses an XML file now fails and gives me this odd exception. Any idea why tomcat 4.1.18 would be involving itself in matters such as TraX? Here's the error: Thanks! Neal . Error parsing pageMap.xml: javax.xml.transform.TransformerConfigurationException: javax.xml.transform.TransformerException: javax.xml.transform.TransformerException: org.apache.xml.utils.URI$MalformedURIException: No scheme found in URI -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:45 PM To: Tomcat Developers List Subject: RE: RE: RE: Tomcat 302 Redirect Issue I'm pretty sure you will need 4.1.X at least to use, there were some changes between the two in the DefaultServlet Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: RE: Tomcat 302 Redirect Issue No, I'm on 4.0.4 ... though I suppose I could get 4.1.8 if needed. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:34 PM To: Tomcat Developers List Subject: RE: RE: Tomcat 302 Redirect Issue No recompilations, you using 4.1.18? Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: RE: Tomcat 302 Redirect Issue really? Do I need to do any recompilations or I simply replace the class? Yes, PLEASE send it to me! :) Neal -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 2:22 PM To: Tomcat Developers List Subject: RE: Tomcat 302 Redirect Issue Hi Neal, I don't know what's going on here, i've been asking too. If you want the patched class, I can send you it and all you have to do is place it in TOMCAT_HOME/server/classes and it will work. Travis Original Message From: neal [EMAIL PROTECTED] Sent: 2003-02-27 To: Tomcat Developers List [EMAIL PROTECTED] Subject: Tomcat 302 Redirect Issue A conversation began a couple of weeks ago about making the the patch for the welcome page forward action (rather than redirect) available for tomcat 4.x. Did this happen? Is it available as a 4.x patch? If so, how do I get it and how can I apply it? If not, is there a plan to do this? If not, any new news on when Tomcat 5 will be out? Thanks. Neal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17517] New: - Embedded Catalina does not use context classloader
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17517. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17517 Embedded Catalina does not use context classloader Summary: Embedded Catalina does not use context classloader Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Windows 9x Status: NEW Severity: Blocker Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Catalina begins its chain of classloaders starting with the system classloader instead of the initial thread's context classloader. When embedding Catalina from a thread that uses a classloader that is not the system classloader but instead a descendant, a jsp class cannot be found by the WebAppClassLoader. The missing class is loaded in the initial thread's context classloader. After taking a cursory look at the code, it appears that Catalina does not assure that the initial context classloader is an ancestor to the classloaders it creates. The end result is that the embedded Catalina serves static html pages but not jsp pages. The application needs to be shielded from the components that Catalina uses, which contain different versions of classes used by the application, so it cannot simply load the Catalina components in the system classloader. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17517] - Embedded Catalina does not use context classloader
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17517. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17517 Embedded Catalina does not use context classloader [EMAIL PROTECTED] changed: What|Removed |Added OS/Version|Windows 9x |Windows NT/2K - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5/resources/mbeans tomcat5-ant.xml
costin 2003/02/27 20:56:54
Modified:resources/mbeans tomcat5-ant.xml
Log:
Update to the new syntax in modeler.
Revision ChangesPath
1.2 +44 -36jakarta-tomcat-5/resources/mbeans/tomcat5-ant.xml
Index: tomcat5-ant.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/resources/mbeans/tomcat5-ant.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- tomcat5-ant.xml 26 Feb 2003 19:22:05 - 1.1
+++ tomcat5-ant.xml 28 Feb 2003 04:56:54 - 1.2
@@ -29,54 +29,62 @@
--
target name=jmx-console-ri depends=init description=Enable JMX-RI console (
web interface )
-mbean code=com.sun.jdmk.comm.HtmlAdaptorServer
- name=jmx-console:type=HtmlAdaptorServer,port=9998
-/mbean
-jmx-attribute objectName=jmx-console:type=HtmlAdaptorServer,port=9998
- attribute=Port type=int value=9998/
-jmx-operation objectName=jmx-console:type=HtmlAdaptorServer,port=9998
- operation=start /
+jmx-service
+ mbean code=com.sun.jdmk.comm.HtmlAdaptorServer
+ name=jmx-console:type=HtmlAdaptorServer,port=9998
+ attribute name=Port value=9998/
+ /mbean
+/jmx-service
+
+ /target
+
+ target name=jmx-console-mx4j depends=init description=Enable JMX console (
mx4j )
+
+jmx-service
+ mbean code=mx4j.adaptor.http.XSLTProcessor
+ name=Http:name=XSLTProcessor
+ /mbean
+ mbean code=mx4j.adaptor.http.HttpAdaptor
+ name=Http:name=HttpAdaptor
+ attribute name=Port value=9998/
+ attribute name=ProcessorName value=Http:name=XSLTProcessor/
+ /mbean
+/jmx-service
+
/target
!-- === Server.xml based --
+ property name=domain value=Catalina /
target name=run depends=init
description=Start tomcat as an mbean using server.xml config and returns
-property name=domain value=Catalina /
-
-modeler code=org.apache.catalina.startup.Catalina
- name=${domain}:type=server /
-jmxSet objectName=${domain}:type=server
-attribute=catalinaHome
-value=${tomcat.home}/
-
-!-- We could also call init and set other properties -
- init should load the modules --
-
-jmx objectName=${domain}:type=server
- operation=start /
+jmx-service
+ mbean code=org.apache.catalina.startup.Catalina
+ name=${domain}:type=server
+ modeler=true
+ attribute name=catalinaHome
+value=${tomcat.home}/
+ /mbean
+/jmx-service
echo message=Tomcat5 running/
-!-- let's add a context - using JMX
-property name=admin1Name
-
value=${domain}:j2eeType=WebModule,name=//localhost/admin1,J2EEApplication=none,J2EEServer=none
/
-
-modeler code=org.apache.catalina.core.StandardContext
- name=${admin1Name} /
-
-jmxSet objectName=${admin1Name}
-attribute=docBase
-value=${tomcat.home}/server/webapps/admin /
-
-jmx objectName=${admin1Name}
- operation=init /
---
-
+!-- let's add a context - using JMX.
+ That will fail with class loader problems... XXX
+ --
+
+jmx-service
+ mbean
name=${domain}:j2eeType=WebModule,name=//localhost/servlet-examples,J2EEApplication=none,J2EEServer=none
+ code=org.apache.catalina.core.StandardContext
+ modeler=true
+ attribute name=docBase
+value=/ws/50/build/webapps/servlet-examples /
+ /mbean
+/jmx-service
/target
@@ -87,7 +95,7 @@
target name=await depends=init
description=Wait for tomcat stop. Call this target after run
-jmx objectName=Catalina:type=server
+jmx objectName=${domain}:type=server
operation=await /
/target
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_status.c
costin 2003/02/27 21:02:24
Modified:jk/native2/common jk_worker_status.c
Log:
Few more improvements to allow easier parsing on the java side.
jkstatus now supports 4 new operations:
lst - will list all the beans ( well - C beans ) and the attributes ( get and set )
dmp - will display all attributes for one or more beans ( using a prefix )
get - returns exactly one attribute value
set - set one attribute. Some attributes have side effect - so this is also used
as invoke()
( like in SNMP world )
Revision ChangesPath
1.34 +224 -107 jakarta-tomcat-connectors/jk/native2/common/jk_worker_status.c
Index: jk_worker_status.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_status.c,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- jk_worker_status.c17 Feb 2003 02:09:58 - 1.33
+++ jk_worker_status.c28 Feb 2003 05:02:24 - 1.34
@@ -414,7 +414,196 @@
}
s-jkprintf( env,s , /table\n );
}
-
+
+static int JK_METHOD jk2_worker_status_list(jk_env_t *env,
+jk_worker_t *w,
+jk_ws_service_t *s)
+{
+char *cName=s-query_string + 4;
+int i;
+int qryLen=0;
+int exact=1;
+
+/* Dump all attributes for the beans */
+if( strcmp( cName, * )==0 ) {
+*cName='\0';
+qryLen=0;
+} else {
+qryLen=strlen( cName );
+}
+if( qryLen 0 ) {
+if( cName[strlen(cName)] == '*' ) {
+printf(Exact match off %s\n, cName );
+cName[strlen(cName)]='\0';
+exact=0;
+}
+}
+for( i=0; i env-_objects-size( env, env-_objects ); i++ ) {
+char *name=env-_objects-nameAt( env, env-_objects, i );
+jk_bean_t *mbean=env-_objects-valueAt( env, env-_objects, i );
+char **getAtt=mbean-getAttributeInfo;
+char **setAtt=mbean-setAttributeInfo;
+
+/* That's a bad name, created for backward compat. It should be
deprecated.. */
+if( strchr( name, ':' )==NULL )
+continue;
+
+/* Prefix */
+if( ! exact qryLen != 0 strncmp( name, cName, qryLen )!= 0 )
+continue;
+
+/* Exact */
+if( exact qryLen != 0 strcmp( name, cName )!= 0 )
+continue;
+
+if( mbean==NULL )
+continue;
+s-jkprintf(env, s, N:%s:%s\n, mbean-type, name);
+
+while( getAtt != NULL *getAtt != NULL **getAtt!='\0' ) {
+s-jkprintf(env, s, G:%s:%s\n, name, *getAtt);
+getAtt++;
+}
+
+while( setAtt != NULL *setAtt != NULL **setAtt!='\0' ) {
+s-jkprintf(env, s, S:%s:%s\n, name, *setAtt);
+setAtt++;
+}
+
+}
+return JK_OK;
+}
+
+static int JK_METHOD jk2_worker_status_dmp(jk_env_t *env,
+ jk_worker_t *w,
+ jk_ws_service_t *s)
+{
+char *cName=s-query_string + 4;
+int i;
+int qryLen=0;
+int exact=1;
+
+/* Dump all attributes for the beans */
+if( strcmp( cName, * )==0 ) {
+*cName='\0';
+qryLen=0;
+} else {
+qryLen=strlen( cName );
+}
+if( qryLen 0 ) {
+if( cName[strlen(cName)] == '*' ) {
+printf(Exact match off %s\n, cName );
+cName[strlen(cName)]='\0';
+exact=0;
+}
+}
+for( i=0; i env-_objects-size( env, env-_objects ); i++ ) {
+char *name=env-_objects-nameAt( env, env-_objects, i );
+jk_bean_t *mbean=env-_objects-valueAt( env, env-_objects, i );
+char **getAtt=mbean-getAttributeInfo;
+char **setAtt=mbean-setAttributeInfo;
+
+/* That's a bad name, created for backward compat. It should be
deprecated.. */
+if( strchr( name, ':' )==NULL )
+continue;
+
+/* Prefix */
+if( ! exact qryLen != 0 strncmp( name, cName, qryLen )!= 0 )
+continue;
+
+/* Exact */
+if( exact qryLen != 0 strcmp( name, cName )!= 0 )
+continue;
+
+if( mbean==NULL )
+continue;
+s-jkprintf(env, s, P:%s:%s:%lp\n, mbean-type, name, mbean-object );
+
+while( getAtt != NULL *getAtt != NULL **getAtt!='\0' ) {
+char *attName=*getAtt;
+char *val=mbean-getAttribute(env, mbean, *getAtt );
+s-jkprintf(env, s, G:%s:%s:%s\n, name, *getAtt, (val==NULL)? NULL:
val);
+
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_config_file.c jk_channel_socket.c
costin 2003/02/27 21:05:03
Modified:jk/native2/common jk_config_file.c jk_channel_socket.c
Log:
Added few more getters and setters.
I'll go over all the components and add more after I finish the java side
( that will query and represent the Apache-side as regular mbeans )
( I had some of this on my computer for a while - I want to get it off my
list )
Revision ChangesPath
1.8 +21 -0 jakarta-tomcat-connectors/jk/native2/common/jk_config_file.c
Index: jk_config_file.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_config_file.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- jk_config_file.c 4 Feb 2003 07:39:59 - 1.7
+++ jk_config_file.c 28 Feb 2003 05:05:03 - 1.8
@@ -381,6 +381,24 @@
return JK_OK;
}
+/** Get a property for this config object
+ */
+static void * JK_METHOD jk2_config_file_getAttribute( struct jk_env *env, struct
jk_bean *mbean,
+ char *name)
+{
+jk_config_t *cfg=mbean-object;
+
+if( strcmp( name, file )==0 ) {
+return cfg-file;
+} else if( strcmp( name, ver )==0 ) {
+return 0;
+} else {
+return ;
+}
+}
+
+static char *myGetAttInfo[]={ ver, file, NULL };
+static char *mySetAttInfo[]={ ver, file, save, NULL };
int JK_METHOD jk2_config_file_factory( jk_env_t *env, jk_pool_t *pool,
jk_bean_t *result,
@@ -393,6 +411,8 @@
return JK_ERR;
_this-pool = pool;
+result-getAttributeInfo = myGetAttInfo;
+result-setAttributeInfo = mySetAttInfo;
_this-ver=0;
_this-setPropertyString=jk2_config_setPropertyString;
@@ -406,6 +426,7 @@
result-object=_this;
result-setAttribute=jk2_config_file_setAttribute;
+result-getAttribute=jk2_config_file_getAttribute;
_this-mbean=result;
return JK_OK;
1.48 +18 -3 jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c
Index: jk_channel_socket.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -r1.47 -r1.48
--- jk_channel_socket.c 4 Feb 2003 07:39:59 - 1.47
+++ jk_channel_socket.c 28 Feb 2003 05:05:03 - 1.48
@@ -114,6 +114,7 @@
jk_endpoint_t *endpoint);
static char *jk2_channel_socket_multiValueInfo[]={group, NULL };
+static char *jk2_channel_socket_getAttributeInfo[]={name, NULL };
static char *jk2_channel_socket_setAttributeInfo[]={host, port, route,
lb_factor,
level, NULL };
@@ -124,10 +125,10 @@
jk_channel_t *ch=(jk_channel_t *)mbean-object;
char *value=(char *)valueP;
jk_channel_socket_private_t *socketInfo=
-(jk_channel_socket_private_t *)(ch-_privatePtr);
+(jk_channel_socket_private_t *)(ch-_privatePtr);
if( strcmp( host, name ) == 0 ) {
-socketInfo-host=value;
+socketInfo-host=value;
} else if( strcmp( port, name ) == 0 ) {
socketInfo-port=atoi( value );
} else if( strcmp( keepalive, name ) == 0 ) {
@@ -142,6 +143,19 @@
return JK_OK;
}
+static void * JK_METHOD jk2_channel_socket_getAttribute(jk_env_t *env, jk_bean_t
*bean,
+char *name )
+{
+jk_channel_t *ch=(jk_channel_t *)bean-object;
+jk_channel_socket_private_t *socketInfo=
+(jk_channel_socket_private_t *)(ch-_privatePtr);
+
+if( strcmp( name, name )==0 ) {
+return bean-name;
+}
+return NULL;
+}
+
/** resolve the host IP ( jk_resolve ) and initialize the channel.
*/
static int JK_METHOD jk2_channel_socket_init(jk_env_t *env,
@@ -652,9 +666,10 @@
ch-is_stream=JK_TRUE;
result-setAttribute= jk2_channel_socket_setAttribute;
+result-getAttribute= jk2_channel_socket_getAttribute;
result-init= jk2_channel_socket_init;
-/*result-getAttributeInfo=jk2_channel_socket_getAttributeInfo;*/
+result-getAttributeInfo=jk2_channel_socket_getAttributeInfo;
result-multiValueInfo=jk2_channel_socket_multiValueInfo;
result-setAttributeInfo=jk2_channel_socket_setAttributeInfo;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: Default context as a war archive (bug?)
yes, that's exactly my point. it doesn't work. 1. ROOT1.war does extracted automatically to ROOT1/, so, it works in the ROOT1 context, but not the default context. 2. I used a fresh copy of Tomcat 4.1.18 to try, if i delete the ROOT1/ directory, and deploy a ROOT1.war which is set as the default context, the default context is not initialized. (notice that ROOT1.war is a zip of the default ROOT/ and is renamed) the problem can be repeated easily by the following steps: i. extract tomcat from zip or install by other means ii. war the default ROOT/ directory, rename the war iii.configure in server.xml to use the renamed war's filename without extension as default context docbase iv. start tomcat, go to html manager, the root context should be not started, and cannot be started Regards, mingfai -Original Message- From: jakarta-pipon [mailto:[EMAIL PROTECTED] Sent: Friday, February 28, 2003 4:31 AM To: Tomcat Developers List Subject: Re: Default context as a war archive (bug?) 1. in server.xml: Context path= docBase=ROOT1 debug=0/ ^ ROOT1.war should work - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
