DO NOT REPLY [Bug 17948] - error reported with Tomcat 4.1.18
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17948. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17948 error reported with Tomcat 4.1.18 --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 11:02 --- Created an attachment (id=5337) Soryy. It is program bug only. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17992] New: - Shutdown problems
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17992. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17992 Shutdown problems Summary: Shutdown problems Product: Tomcat 4 Version: 4.1.12 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When we stop tomcat 4.1.12 in linux, the processes of tomcat won´t die. If we do start/stop n times, we will get n*m processes running. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: A tomcat SSL question
Hi Mark, you can start the vm with -Djavax.net.debug=all to get under the hood of jsse and see why the handshake is failing. You may also need to do some conversion as described here: http://www.comu.de/docs/tomcat_ssl.htm. Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] | Sent: Thursday, March 13, 2003 9:53 PM | To: [EMAIL PROTECTED] | Subject: A tomcat SSL question | | | So, would you please give me a hint, how can I use the certificate generated by my little Java program to run tomcat with SSL? | | Thanks a lot in advance. | | Mark (Choreson) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[REPOST] [VOTE] [4.1.22] Stability rating
ballot [ ] Alpha [ ] Beta [ ] Stable (GA) /ballot Ok this is a nag ;-) The idea is that there's a (rather minor) security issue in 4.1.18, and we should have a release to fix it sooner than later (and I've been saying that for weeks now :-( ). I can release yet another build if needed. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Catalina shutdown port as command line param?
Hi, I was wondering if we can add the '-shutdown portnumber' to the catalina's command line parameters. The usage would be to enable multiple TC instances using the same server.xml file. If present the param would override the config's Server port=8005 MT. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_ajp_common.h
glenn 2003/03/14 05:36:35
Modified:jk/native CHANGES.txt
jk/native/apache-2.0 mod_jk.c
jk/native/common jk_ajp_common.c jk_ajp_common.h
Log:
Traced through the code to clean up error handling for when a client
aborts a request.
* The retry loop would continue to retry processing the request even
if the client aborted. Fixed this.
* If the client aborts set the aborted flag in the conn_rec
* If the handler is invoked and the conn_rec aborted flag is set
return an HTTP_INTERNAL_SERVER_ERROR instead of processing a
request for an aborted client.
* Setting the conn_rec aborted flag and checking it prevents mod_jk
from passing on a request to Tomcat for processing when the
client has aborted the connection. An HTML page could use SSI to
invoke multiple servlet's or JSP pages during a single request.
There is no need to continue processing these if the client has
aborted the connection.
There was a bug in get_content_length() which would cause a SSI of
a page which gets procesed by Tomcat to fail if the original client
request was a POST.
Cleaned up and reformatted code to 80 columns in source code files
I worked on.
Revision ChangesPath
1.11 +8 -2 jakarta-tomcat-connectors/jk/native/CHANGES.txt
Index: CHANGES.txt
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/CHANGES.txt,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- CHANGES.txt 28 Feb 2003 21:55:21 - 1.10
+++ CHANGES.txt 14 Mar 2003 13:36:35 - 1.11
@@ -11,7 +11,13 @@
let Apache handle processing the error returned by Tomcat.
* Added the load balancer sticky_session property. If set to 0
requests with servlet SESSION ID's can be routed to any Tomcat
- worker. Default is 1, sessions are sticky.
+ worker. Default is 1, sessions are sticky. [glenn]
+* Cleaned up detection and reporting of aborted client connections.
+ This cleanup also makes sure that mod_jk does not pass any requests
+ on to Tomcat if the remote client aborted its connection. [glenn]
+* Fixed a bug in Apache 2.0 which caused a POST request forwarded to
+ Tomcat to fail if it generated SSI directives which were post
+ processed by mod_include. [glenn]
Changes with JK 1.2.2:
* tomcat_trend.pl updated script to support changed logging of
1.67 +105 -105 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -r1.66 -r1.67
--- mod_jk.c 28 Feb 2003 17:58:39 - 1.66
+++ mod_jk.c 14 Mar 2003 13:36:35 - 1.67
@@ -103,14 +103,16 @@
#define __arpa_inet_h__
#define __sys_timeval_h__
#endif
+
+#include jk_ajp13.h
#include jk_global.h
-#include jk_util.h
+#include jk_logger.h
#include jk_map.h
#include jk_pool.h
#include jk_service.h
-#include jk_worker.h
#include jk_uri_worker_map.h
-#include jk_logger.h
+#include jk_util.h
+#include jk_worker.h
#define JK_WORKER_ID(jakarta.worker)
#define JK_HANDLER (jakarta-servlet)
@@ -233,59 +235,57 @@
const char * const *header_values,
unsigned num_of_headers)
{
-if(s s-ws_private) {
-unsigned h;
-apache_private_data_t *p = s-ws_private;
-request_rec *r = p-r;
-
-if(!reason) {
-reason = ;
-}
-r-status = status;
-r-status_line = apr_psprintf(r-pool, %d %s, status, reason);
+unsigned h;
+apache_private_data_t *p = s-ws_private;
+request_rec *r = p-r;
+
+if(!reason) {
+reason = ;
+}
+r-status = status;
+r-status_line = apr_psprintf(r-pool, %d %s, status, reason);
-for(h = 0 ; h num_of_headers ; h++) {
-if(!strcasecmp(header_names[h], Content-type)) {
-char *tmp = apr_pstrdup(r-pool, header_values[h]);
-ap_content_type_tolower(tmp);
-/* It should be done like this in Apache 2.0 */
-/* This way, Apache 2.0 will be able to set the output filter */
-/* and it make jk useable with deflate using AddOutputFilterByType
DEFLATE text/html */
-ap_set_content_type(r, tmp);
-} else if(!strcasecmp(header_names[h], Location)) {
+for(h = 0 ; h num_of_headers ; h++) {
+if(!strcasecmp(header_names[h], Content-type)) {
+char *tmp =
cvs commit: jakarta-tomcat-connectors/jk/tools/reports tomcat_trend.pl
glenn 2003/03/14 05:36:58
Modified:jk/tools/reports tomcat_trend.pl
Log:
Update script for mod_jk changes
Revision ChangesPath
1.4 +4 -4 jakarta-tomcat-connectors/jk/tools/reports/tomcat_trend.pl
Index: tomcat_trend.pl
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/tools/reports/tomcat_trend.pl,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- tomcat_trend.pl 31 Dec 2002 04:19:31 - 1.3
+++ tomcat_trend.pl 14 Mar 2003 13:36:58 - 1.4
@@ -232,7 +232,7 @@
if( $line =~ /(jk_tcp_socket_recvfull failed|ERROR: Receiving from
tomcat failed)/ ) {
$Global{tomcat_full}++;
$Interval{tomcat_full}++;
-} elsif( $line =~ /(ajp_process_callback - write failed|ERROR sending
data to client. Connection aborted or network problems)/ ) {
+} elsif( $line =~ /(ajp_process_callback - write failed|ERROR sending
data to client. Connection aborted or network problems|Client connection aborted or
network problems)/ ) {
$Global{client_gone}++;
$Interval{client_gone}++;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: memory leak on context reload or stop/start? [was Re: tracking memory usage over time]
Howdy, Can you elaborate on your findings regarding log4j's memory leak? A new thread might be better for this. Thanks, Yoav Shapira Millennium ChemInformatics -Original Message- From: Aditya [mailto:[EMAIL PROTECTED] Sent: Thursday, March 13, 2003 11:58 PM To: Tomcat Developers List Subject: memory leak on context reload or stop/start? [was Re: tracking memory usage over time] Just to followup, we have found a few things that were causing this leak, two that were particular to our setup, but the third seems to be a Tomcat problem (4.1.20 with Jasper2): 1) log4j was eating up a lot of memory and there was a slow leak. Since it wasn't strictly required, we've stopped using it and the largest leak stopped. 2) we are using jdbcpool from http://www.bitmechanic.com/projects/jdbcpool/ (it is the only connection pool we could find that can be instantiated programmatically from within a context without having to define a pool in advance via JDNI -- we give each context it's own database and therefore it's own pool) which doesn't seem to have a clean way to stop the pool manager thread when a context is stopped/reloaded. We've worked around this, however the memory leak remains and is due to context reloads / stops-starts 3) there seems to be a leak caused by reloading or stopping/starting a context (we have an automatic httpunit test that builds a jar file periodically and makes sure it is working in a context). We don't see the memory leak unless one or more JSPs are compiled before the context is reloaded or stopped/started. Is there some particular section of the code we should be examining to track this further? Adi On Tue, 25 Feb 2003 22:08:41 -0600, Glenn Nielsen [EMAIL PROTECTED] said: Aditya wrote: Glenn, several months ago you had posted a URL to a document (at kinetic.more.net if I remember correctly) where you talked about having to restart your production Tomcat(s) every 4 weeks or so due to Heap exhaustion. Is that still the case? If so what causes the heap exhaustion? I think that part of the heap problem for me was the recent bug in Jasper which I fixed where a number of resources such as Node trees from a JSP page compile were not dereferenced between compiles. This was fixed in Jasper before the 4.1.20 release. We've looked high and low, with JProbe etc, and we still can't find where the leak is. We're having to restart a Tomcat (4.1.20) with -Xms and -Xmx both set to 256M every 4 days or so. Does the increase in memory usage correlate with an increased number of connectors due to a spike in request volume? Perhaps you should try increasing the heap size. Regards, Glenn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [GUMP] Build Failure - jakarta-tomcat-5
Here's my own failure, trying to run ant download: [echo] == Building: commons-el init: [echo] el 1.0 prepare: static: build-servletapi: [echo] == Building: L:\home\tomcat-5\repository\servlet-api-2.4\lib\servlet-api.jar prepare: static: compile: jar: [copy] Copying 1 file to L:\home\tomcat-5\jakarta-servletapi-5\jsr154\build [jar] Building jar: L:\home\tomcat-5\repository\servlet-api-2.4\lib\servlet-api.jar BUILD FAILED file:L:/home/tomcat-5/jakarta-servletapi-5/jsr154/build.xml:140: Problem creating jar: L:\home\tomcat-5\repository\servl et-api-2.4\lib\servlet-api.jar (The system cannot find the path specified) (and the archive is probably corrupt but I co uld not delete it) I agree that consistency is good, but breaking the build for days is not good ;-) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17997] New: - JspC's webapp switch does not expand package names
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17997.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17997
JspC's webapp switch does not expand package names
Summary: JspC's webapp switch does not expand package names
Product: Tomcat 4
Version: 4.1.18
Platform: All
OS/Version: All
Status: NEW
Severity: Minor
Priority: Other
Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
I've noticed that when using JspC with the -webapp
switch with a web application containing code in
subdirectories, JspC places the generated java files
in the correct subdirectory beneath the given output
directory.
For example:
If I run:
JspC -p com.company.myapp
-d ./src/com/company/myapp
-webapp ./jsp/myapp
For file:
myapp/mysubdir/myfile.jsp
this file is generated:
./src/com/company/myapp/mysubdir/myfile_jsp.java
but the package name is still:
com.company.myapp
rather than what I expected:
com.company.myapp.musubdir
This is fine and dandy so long as I don't also have a
file named myfile.jsp in the myapp directory or the
myapp/myothersubdir directory.
Is there a reason that I'm overlooking as to why this
should work this way?
I've applied the following changes to my copy of
JspC.java to discover whether the package name needs
extending similarly to the output directory.
Let me know what you guys think about this change.
thanks,
Stephen Aument
This refers to the JspC in 4.1.12.
522,532d521
public static String getPackageSuffix( String
jspUri ) {
StringBuffer suffix = new StringBuffer();
int lastIndex = jspUri.lastIndexOf( '/' );
if ( lastIndex 0 ) {
suffix.append( . );
suffix.append( jspUri.substring( 1,
lastIndex ) );
}
return suffix.toString();
}
539,540c528
this.setOutputDir( baseDir
+ jspUri.substring( 0,
jspUri.lastIndexOf( '/' ) ) );
---
this.setOutputDir( baseDir +
jspUri.substring( 0, jspUri.lastIndexOf( '/' ) ) );
549,564c537,539
/*
* Here's what's different from the base
class. We generate a
* tmpTargetPackage name from the
targetPackage and the uri of the
* jsp page and set that as the servlet
package name.
*/
String tmpTargetPackage
= targetPackage +
getPackageSuffix( jspUri );
if (tmpTargetPackage != null) {
clctxt.setServletPackageName(tmpTargetPackage);
}
/*
* End of changes.
*/
---
if (targetPackage != null) {
clctxt.setServletPackageName(targetPackage);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Catalina shutdown port as command line param?
Mladen Turk wrote: Hi, I was wondering if we can add the '-shutdown portnumber' to the catalina's command line parameters. The usage would be to enable multiple TC instances using the same server.xml file. If present the param would override the config's Server port=8005 For 4.1.x or 5.0 ? In 5.0 I would like to use ajp13 for shutdown, like in 3.3 - there is no need for a second port and all support is there, including the generation of a random password at startup and selection of the first free port. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
costin 2003/03/14 07:28:06
Modified:.build.xml
Log:
Trying to guess what's wrong on Remy's machine.
The APIs are built in download as dependencies, no need to build
them twice.
Revision ChangesPath
1.107 +1 -3 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.106
retrieving revision 1.107
diff -u -r1.106 -r1.107
--- build.xml 13 Mar 2003 22:48:00 - 1.106
+++ build.xml 14 Mar 2003 15:28:06 - 1.107
@@ -144,7 +144,7 @@
!-- == Build all components === --
target name=build-servletapi unless=servletapi.build.notrequired
echo== Building: ${servlet-api.jar}/echo
-
+mkdir dir=${servlet-api.dist} /
ant dir=${api.home}/jsr154 target=dist
property name=servlet-api.dist value=${servlet-api.home} /
/ant
@@ -425,8 +425,6 @@
copy file=${commons-beanutils.jar} todir=${tomcat.build}/common/lib/
copy file=${jmx.jar} todir=${tomcat.build}/common/lib/
-antcall target=build-servletapi/
-antcall target=build-jspapi/
antcall target=build-tomcatutil/
antcall target=build-catalina/
antcall target=build-tomcatcoyote/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Catalina shutdown port as command line param?
Costin Manolache wrote: Mladen Turk wrote: Hi, I was wondering if we can add the '-shutdown portnumber' to the catalina's command line parameters. The usage would be to enable multiple TC instances using the same server.xml file. If present the param would override the config's Server port=8005 For 4.1.x or 5.0 ? In 5.0 I would like to use ajp13 for shutdown, like in 3.3 - there is no need for a second port and all support is there, including the generation of a random password at startup and selection of the first free port. Since you're speaking about start/stop, did there is plan to use a service wrapper (may be using JNI) to ensure start/stop works. For instance I've got some applications here, embedded in TC 3.3.1, which take time to stop properly and the problem when using start/stop from command line, is that you're never sure the application has finished, which is problematic when you want to make a restart for instance. The patch I commited in start scripts for TC 3.3.1/4.1/5.0 help us to know the PID of the first java process, but having something more bullet proof will be welcomed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [GUMP] Build Failure - jakarta-tomcat-5
Remy Maucherat wrote: Here's my own failure, trying to run ant download: jar: [copy] Copying 1 file to L:\home\tomcat-5\jakarta-servletapi-5\jsr154\build [jar] Building jar: L:\home\tomcat-5\repository\servlet-api-2.4\lib\servlet-api.jar BUILD FAILED file:L:/home/tomcat-5/jakarta-servletapi-5/jsr154/build.xml:140: Problem creating jar: L:\home\tomcat-5\repository\servl et-api-2.4\lib\servlet-api.jar (The system cannot find the path specified) (and the archive is probably corrupt but I co uld not delete it) I agree that consistency is good, but breaking the build for days is not good ;-) Do you have any setting overrides in build.properties ? It worked for me, clean build and all. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-5 build.xml
[EMAIL PROTECTED] wrote: costin 2003/03/14 07:28:06 Modified:.build.xml Log: Trying to guess what's wrong on Remy's machine. The APIs are built in download as dependencies, no need to build them twice. I don't know what's wrong. I only tried ant clean, then ant download followed by ant. The base.path is set to your ../repository. That's it :) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [GUMP] Build Failure - jakarta-tomcat-5
Costin Manolache wrote: Remy Maucherat wrote: Here's my own failure, trying to run ant download: jar: [copy] Copying 1 file to L:\home\tomcat-5\jakarta-servletapi-5\jsr154\build [jar] Building jar: L:\home\tomcat-5\repository\servlet-api-2.4\lib\servlet-api.jar BUILD FAILED file:L:/home/tomcat-5/jakarta-servletapi-5/jsr154/build.xml:140: Problem creating jar: L:\home\tomcat-5\repository\servl et-api-2.4\lib\servlet-api.jar (The system cannot find the path specified) (and the archive is probably corrupt but I co uld not delete it) I agree that consistency is good, but breaking the build for days is not good ;-) Do you have any setting overrides in build.properties ? It worked for me, clean build and all. My build.properties is: # - Compile Control Flags - compile.debug=on compile.deprecation=off compile.optimize=on # - Build Control Flags #Build all components full.dist=on #Hide configuration flags display #flags.hide=on #Version number version=5.0.2 Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! Glenn Remy Maucherat wrote: ballot [ ] Alpha [X] Beta [ ] Stable (GA) /ballot Ok this is a nag ;-) The idea is that there's a (rather minor) security issue in 4.1.18, and we should have a release to fix it sooner than later (and I've been saying that for weeks now :-( ). I can release yet another build if needed. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
mod_jk 1.2.3 release
It has been a while since a mod_jk 1.2 release was done. There have been a number of bug fixes and a few minor feature enhancements. I just did some commits to fix some bugs I was seeing with mod_jk 1.2 and Apache 2.0. Some of these will also improve the connector for other web servers. (Better handling of aborted clients) I just upgraded one of our production sites from Apache 1.3 mod_jk 1.2.2 to Apache 2.0 mod_jk 1.2.3-dev. So far everything is looking good. I really wanted to add support for using the APR to implement a global tomcat socket connector pool. There just doesn't seem to be any easy way to do it without major code refactoring. Argh! Perhaps we could do a mod_jk 1.2.3 release in two weeks or so? That should give adequate time for testing. Regards, GLenn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? Thanks, Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-5 build.xml
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: costin 2003/03/14 07:28:06 Modified:.build.xml Log: Trying to guess what's wrong on Remy's machine. The APIs are built in download as dependencies, no need to build them twice. I don't know what's wrong. I only tried ant clean, then ant download followed by ant. The base.path is set to your ../repository. That's it :) Ant clean; ant update; ant download should work fine. It's just calling ant dist with dist-dir set to repository/servlet-api-2.4, like the other packages. Ok, I'll remove my repository and try again. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Remy Maucherat wrote: Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? Big +1 ! Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: mod_jk 1.2.3 release
Glenn Nielsen wrote: It has been a while since a mod_jk 1.2 release was done. There have been a number of bug fixes and a few minor feature enhancements. I just did some commits to fix some bugs I was seeing with mod_jk 1.2 and Apache 2.0. Some of these will also improve the connector for other web servers. (Better handling of aborted clients) I just upgraded one of our production sites from Apache 1.3 mod_jk 1.2.2 to Apache 2.0 mod_jk 1.2.3-dev. So far everything is looking good. I really wanted to add support for using the APR to implement a global tomcat socket connector pool. There just doesn't seem to be any easy way to do it without major code refactoring. Argh! JK2 is our target, with APR +/- mandatory. Perhaps we could do a mod_jk 1.2.3 release in two weeks or so? That should give adequate time for testing. +0 Good idea but don't have time to do the RI. Would you like doing it ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java ServerLifecycleListener.java
remm2003/03/14 08:04:09
Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanFactory.java ServerLifecycleListener.java
Log:
- Revert all changes to 4.1.22.
- Development should occur in the 5.0 branch, esp since 4.1.23 will happen
sooner rather than later.
- Please verify to check that I'm not making any mistakes.
Revision ChangesPath
1.43 +237 -175
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
Index: MBeanFactory.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- MBeanFactory.java 11 Mar 2003 14:12:47 - 1.42
+++ MBeanFactory.java 14 Mar 2003 16:04:08 - 1.43
@@ -184,129 +184,6 @@
/**
- * Add Logger.
- *
- * @logger logger to be added
- * @parent parent object name
- * @host hostname object name for context logger
- *
- * @exception Exception if an MBean cannot be created or registered
- */
-private void addLogger(Logger logger, String parent, String hostname)
-throws Exception {
-
-// Add the new instance to its parent component
-ObjectName pname = new ObjectName(parent);
-String type = pname.getKeyProperty(type);
-Server server = ServerFactory.getServer();
-if (type == null) {
-ObjectName hname = new ObjectName(hostname);
-String serviceName = hname.getKeyProperty(service);
-Service service = server.findService(serviceName);
-Engine engine = (Engine) service.getContainer();
-Host host = (Host) engine.findChild(hname.getKeyProperty(host));
-String name = pname.getKeyProperty(name);
-String path = name.substring(name.lastIndexOf('/'));
-String pathStr = getPathStr(path);
-Context context = (Context) host.findChild(pathStr);
-context.setLogger(logger);
-} else {
-String serviceName = pname.getKeyProperty(service);
-Service service = server.findService(serviceName);
-Engine engine = (Engine) service.getContainer();
-if (type.equals(Engine)) {
-engine.setLogger(logger);
-} else if (type.equals(Host)) {
-Host host = (Host) engine.findChild(pname.getKeyProperty(host));
-host.setLogger(logger);
-}
-}
-}
-
-
-/**
- * Add Realm.
- *
- * @logger realm to be added
- * @parent parent object name
- * @host hostname object name for context realm
- *
- * @exception Exception if an MBean cannot be created or registered
- */
-private void addRealm(Realm realm, String parent, String hostname)
-throws Exception {
-
-// Add the new instance to its parent component
-ObjectName pname = new ObjectName(parent);
-String type = pname.getKeyProperty(type);
-Server server = ServerFactory.getServer();
-if (type == null) {
-ObjectName hname = new ObjectName(hostname);
-String serviceName = hname.getKeyProperty(service);
-Service service = server.findService(serviceName);
-Engine engine = (Engine) service.getContainer();
-Host host = (Host) engine.findChild(hname.getKeyProperty(host));
-String name = pname.getKeyProperty(name);
-String path = name.substring(name.lastIndexOf('/'));
-String pathStr = getPathStr(path);
-Context context = (Context) host.findChild(pathStr);
-context.setRealm(realm);
-} else {
-String serviceName = pname.getKeyProperty(service);
-Service service = server.findService(serviceName);
-Engine engine = (Engine) service.getContainer();
-if (type.equals(Engine)) {
-engine.setRealm(realm);
-} else if (type.equals(Host)) {
-Host host = (Host) engine.findChild(pname.getKeyProperty(host));
-host.setRealm(realm);
-}
-}
-}
-
-
-/**
- * Add Valve.
- *
- * @valve valve to be added
- * @parent parent object name
- * @host hostname object name for context realm
- *
- * @exception Exception if an MBean cannot be created or registered
- */
-private void addValve(Valve valve, String parent, String hostname)
-throws Exception {
-
-// Add the new instance to its parent component
-ObjectName pname
Re: mod_jk 1.2.3 release
Glenn Nielsen wrote: It has been a while since a mod_jk 1.2 release was done. There have been a number of bug fixes and a few minor feature enhancements. I just did some commits to fix some bugs I was seeing with mod_jk 1.2 and Apache 2.0. Some of these will also improve the connector for other web servers. (Better handling of aborted clients) I just upgraded one of our production sites from Apache 1.3 mod_jk 1.2.2 to Apache 2.0 mod_jk 1.2.3-dev. So far everything is looking good. I really wanted to add support for using the APR to implement a global tomcat socket connector pool. There just doesn't seem to be any easy way to do it without major code refactoring. Argh! Perhaps we could do a mod_jk 1.2.3 release in two weeks or so? +1 on 1.2.3. I started to close bugs on 2.0 - and did some extra testing on the loadbalancing, I would like to move it closer to a release state. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [REPOST] [VOTE] [4.1.22] Stability rating
Howdy, Not a committer, but I'll throw it my 2cents (US) as long as it doesn't offend anyone: +1 on dropping fileupload [X] Stable on 4.1.22 stability. Been using it without a problem, but then again we don't use the JDBC store/realm functionality. Yoav Shapira Millennium ChemInformatics -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 10:51 AM To: [EMAIL PROTECTED] Subject: Re: [REPOST] [VOTE] [4.1.22] Stability rating Remy Maucherat wrote: Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? Big +1 ! Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Catalina shutdown port as command line param?
Howdy, The usage would be to enable multiple TC instances using the same server.xml file. But what about the real connector ports, used by apps, defined inside server.xml? Would you need to change those as well? In 5.0 I would like to use ajp13 for shutdown, like in 3.3 - there is no Would this require an actual AJP13 connector to be running on the shutdown port? Yoav Shapira Millennium ChemInformatics This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Catalina shutdown port as command line param?
Shapira, Yoav wrote: Howdy, The usage would be to enable multiple TC instances using the same server.xml file. But what about the real connector ports, used by apps, defined inside server.xml? Would you need to change those as well? In 5.0 I would like to use ajp13 for shutdown, like in 3.3 - there is no Would this require an actual AJP13 connector to be running on the shutdown port? Yep and there is potential security flaw if you didn't use more advanced login/pwd - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.cjk_ajp_common.h
[EMAIL PROTECTED] wrote: glenn 2003/03/14 05:36:35 Modified:jk/native CHANGES.txt jk/native/apache-2.0 mod_jk.c jk/native/common jk_ajp_common.c jk_ajp_common.h Log: Traced through the code to clean up error handling for when a client aborts a request. * The retry loop would continue to retry processing the request even if the client aborted. Fixed this. * If the client aborts set the aborted flag in the conn_rec * If the handler is invoked and the conn_rec aborted flag is set return an HTTP_INTERNAL_SERVER_ERROR instead of processing a request for an aborted client. * Setting the conn_rec aborted flag and checking it prevents mod_jk from passing on a request to Tomcat for processing when the client has aborted the connection. An HTML page could use SSI to invoke multiple servlet's or JSP pages during a single request. There is no need to continue processing these if the client has aborted the connection. There was a bug in get_content_length() which would cause a SSI of a page which gets procesed by Tomcat to fail if the original client request was a POST. Cleaned up and reformatted code to 80 columns in source code files I worked on. Great work (applause) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Remy Maucherat wrote: Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? If this is only because of the released state of commons-fileupload, then no. fileupload Beta 1 was released Feb 15, 2003. The HTMLManager is in synch with it and works. Besides, those features of the HTMLManager which use fileupload have already been included in a stable release. Kind of late to remove them now. Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: mod_jk 1.2.3 release
Henri Gomez wrote: Glenn Nielsen wrote: It has been a while since a mod_jk 1.2 release was done. There have been a number of bug fixes and a few minor feature enhancements. I just did some commits to fix some bugs I was seeing with mod_jk 1.2 and Apache 2.0. Some of these will also improve the connector for other web servers. (Better handling of aborted clients) I just upgraded one of our production sites from Apache 1.3 mod_jk 1.2.2 to Apache 2.0 mod_jk 1.2.3-dev. So far everything is looking good. I really wanted to add support for using the APR to implement a global tomcat socket connector pool. There just doesn't seem to be any easy way to do it without major code refactoring. Argh! JK2 is our target, with APR +/- mandatory. Perhaps we could do a mod_jk 1.2.3 release in two weeks or so? That should give adequate time for testing. +0 Good idea but don't have time to do the RI. Would you like doing it ? What is required to do the release? Do you have any notes on how to do connector releases? The only platforms I could build binaries for is Solaris 7/8 x86/sparc. Regards, Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.cjk_ajp_common.h
Henri Gomez wrote: [EMAIL PROTECTED] wrote: glenn 2003/03/14 05:36:35 Modified:jk/native CHANGES.txt jk/native/apache-2.0 mod_jk.c jk/native/common jk_ajp_common.c jk_ajp_common.h Log: Traced through the code to clean up error handling for when a client aborts a request. * The retry loop would continue to retry processing the request even if the client aborted. Fixed this. * If the client aborts set the aborted flag in the conn_rec * If the handler is invoked and the conn_rec aborted flag is set return an HTTP_INTERNAL_SERVER_ERROR instead of processing a request for an aborted client. * Setting the conn_rec aborted flag and checking it prevents mod_jk from passing on a request to Tomcat for processing when the client has aborted the connection. An HTML page could use SSI to invoke multiple servlet's or JSP pages during a single request. There is no need to continue processing these if the client has aborted the connection. There was a bug in get_content_length() which would cause a SSI of a page which gets procesed by Tomcat to fail if the original client request was a POST. Cleaned up and reformatted code to 80 columns in source code files I worked on. Great work (applause) Thanks. :-) Kind of had to if I wanted to start upgrading our production systems to Apache 2.0. Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Glenn Nielsen wrote: Remy Maucherat wrote: Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? If this is only because of the released state of commons-fileupload, then no. fileupload Beta 1 was released Feb 15, 2003. The HTMLManager is in synch with it and works. Besides, those features of the HTMLManager which use fileupload have already been included in a stable release. Kind of late to remove them now. This is not true. 4.1.18 included version 1.12 of the HTML manager, which had no dependencies on commons-fileupload. As people have expressed desire to remove that dependency, I would be grateful if you did actually remove it. Or release a final version of fileupload. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18004] New: - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not Summary: JDBCRealm.authenticate() eats SQLExceptions and should not Product: Tomcat 4 Version: 4.1.18 Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] It is extremely frustrating for the end-user when he attempts to login by using a CORRECT user name and password, only to be notified that the login failed, and with no further explanation (this occurs when an SQLException is thrown during the authenticate process). The exception is being hidden from the user, giving the false impression that the wrong username and/or password was entered, when in actuality there was a database problem. The JDBCRealm.authenticate(String, String) method cannot declare itself to throw SQLExceptions since it implements the Realm interface, so I propose the SQLException be wrapped and re-thrown as a RuntimeException. This is not an elegant solution, but is vastly superior to the current behavior, which greatly frustrates the end-user. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 10057] - banner.jsp form should not link to absolute path
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10057. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10057 banner.jsp form should not link to absolute path [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 17:46 --- *** This bug has been marked as a duplicate of 17744 *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17744] - Broken functionality when not rooted under /admin
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17744. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17744 Broken functionality when not rooted under /admin [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 17:46 --- *** Bug 10057 has been marked as a duplicate of this bug. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Glenn Nielsen wrote: Remy Maucherat wrote: Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? If this is only because of the released state of commons-fileupload, then no. fileupload Beta 1 was released Feb 15, 2003. The HTMLManager is in synch with it and works. Beta != release. And no, that's not the main reason. If you need the manager to include fileupload - than place it in WEB-INF/lib, don't bloat server/lib. The /admin doesn't place struts.jar in server/lib. I'm not comfortable with making HTMLManager too complex - but if you really need that, fine - but do it right. You could easily have a separate webapp that supports uploading - there is no need to have one kitchen-sink servlet that does everything. Costin Besides, those features of the HTMLManager which use fileupload have already been included in a stable release. Kind of late to remove them now. Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve AddValveAction.java
amyroh 2003/03/14 09:53:50
Modified:webapps/admin banner.jsp
webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
AddConnectorAction.java
webapps/admin/WEB-INF/classes/org/apache/webapp/admin/logger
AddLoggerAction.java
webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm
AddRealmAction.java
webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve
AddValveAction.java
Log:
Fix bugzilla 17744. Remove /admin part of URLs to make them relative.
When the admin webapp isn't rooted under /admin, a number of links didn't
work because they were hardcoded as /admin/rest_of_link.
Patch submitted by [EMAIL PROTECTED] (Rich J).
Revision ChangesPath
1.12 +2 -2 jakarta-tomcat-4.0/webapps/admin/banner.jsp
Index: banner.jsp
===
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/banner.jsp,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- banner.jsp14 Mar 2003 16:00:15 - 1.11
+++ banner.jsp14 Mar 2003 17:53:50 - 1.12
@@ -20,7 +20,7 @@
td align=left valign=middle
div class=masthead-title-text align=leftimg
src=images/TomcatBanner.jpg alt=Tomcat Web Server Administration Tool
height=120/div
/td
- form method='post' action='/admin/commitChanges.do' target='_self'
+ form method='post' action='commitChanges.do' target='_self'
td align=right valign=middle
html:submit
bean:message key=button.commit/
@@ -30,7 +30,7 @@
td width=1%
div class=table-normal-text align=leftnbsp /div
/td
-form method='post' action='/admin/logOut.do' target='_top'
+form method='post' action='logOut.do' target='_top'
td align=right valign=middle
html:submit
bean:message key=button.logout/
1.9 +6 -6
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java
Index: AddConnectorAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- AddConnectorAction.java 14 Mar 2003 16:00:16 - 1.8
+++ AddConnectorAction.java 14 Mar 2003 17:53:50 - 1.9
@@ -174,12 +174,12 @@
ArrayList types = new ArrayList();
// the first element in the select list should be the type selected
types.add(new LabelValueBean(type,
-/admin/AddConnector.do?serviceName= +
URLEncoder.encode(serviceName)
+AddConnector.do?serviceName= + URLEncoder.encode(serviceName)
+ type= + type));
for (int i=0; i schemeTypes.length; i++) {
if (!type.equalsIgnoreCase(schemeTypes[i])) {
types.add(new LabelValueBean(schemeTypes[i],
-/admin/AddConnector.do?serviceName= +
URLEncoder.encode(serviceName)
+AddConnector.do?serviceName= + URLEncoder.encode(serviceName)
+ type= + schemeTypes[i]));
}
}
1.4 +6 -6
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/logger/AddLoggerAction.java
Index: AddLoggerAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/logger/AddLoggerAction.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- AddLoggerAction.java 14 Mar 2003 16:00:16 - 1.3
+++ AddLoggerAction.java 14 Mar 2003 17:53:50 - 1.4
@@ -147,12 +147,12 @@
ArrayList types = new ArrayList();
// the first element in the select list should be the type selected
types.add(new LabelValueBean(type,
-/admin/AddLogger.do?parent= + URLEncoder.encode(parent)
+AddLogger.do?parent= + URLEncoder.encode(parent)
+ type= + type));
for (int i=0; i loggerTypes.length; i++) {
if (!type.equalsIgnoreCase(loggerTypes[i])) {
types.add(new LabelValueBean(loggerTypes[i],
-/admin/AddLogger.do?parent= + URLEncoder.encode(parent)
+AddLogger.do?parent= + URLEncoder.encode(parent)
+ type= + loggerTypes[i]));
}
}
1.8 +6 -6
DO NOT REPLY [Bug 18005] New: - Realm authentication forgets requested URL
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18005. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18005 Realm authentication forgets requested URL Summary: Realm authentication forgets requested URL Product: Tomcat 4 Version: 4.1.18 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] To recreate this problem: - Request a page that is protected by realm authentication. You should see the login page. - Allow enough time to elapse that the session expires (usually 30 minutes) - Now try logging in with a valid username and password. You will see an error page with a message to the effect Direct reference to the login page. Because the session expired, the originally requested URL was lost by the container. This should never happen as it is very frustrating and confusing to the end-user. The obvious solution is to save the URL as a request parameter, rather than saving it in the user's session. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm SaveJDBCRealmAction.java
amyroh 2003/03/14 10:05:59
Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm
SaveJDBCRealmAction.java
Log:
Fix bugzilla 15982. Don't set JDBCRealm digest when it's an empty string.
Revision ChangesPath
1.8 +9 -6
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJDBCRealmAction.java
Index: SaveJDBCRealmAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJDBCRealmAction.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- SaveJDBCRealmAction.java 14 Mar 2003 16:00:17 - 1.7
+++ SaveJDBCRealmAction.java 14 Mar 2003 18:05:58 - 1.8
@@ -283,8 +283,11 @@
new Attribute(debug, new Integer(debug)));
attribute = digest;
-mBServer.setAttribute(roname,
- new Attribute(digest, rform.getDigest()));
+String digest = rform.getDigest();
+if ((digest != null) (digest.length()0)) {
+mBServer.setAttribute(roname,
+ new Attribute(digest, digest));
+}
attribute = driverName;
mBServer.setAttribute(roname,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: Catalina shutdown port as command line param?
-Original Message- From: Henri Gomez [mailto:[EMAIL PROTECTED] Sent: 14. oujak 2003 17:44 To: Tomcat Developers List Subject: Re: Catalina shutdown port as command line param? The usage would be to enable multiple TC instances using the same server.xml file. But what about the real connector ports, used by apps, defined inside server.xml? Would you need to change those as well? No problem, the connector will increment if the port is used, although those connector are unused. In 5.0 I would like to use ajp13 for shutdown, like in 3.3 - there is Well the entire problem is two fold: 1. Server with multiple childs (I even have an experimental NT mpm with multiple childs), each of them wishing to start it's own JVM and TC instance. The inprocess TC is completely useless in that case cause each consecutive TC instance is aborted due to the shutdown port collision. IMHO in that case (inprocess) the shutdown port isn't needed at all, but seems that catalina wasn't designed to be _embedded_, and that is what we need. All the Socket connectors should be disabled in that case from the http connector to the each AJP connector, no matter what the server.xml states. 2. Starting TC from the 'dirty' JVM could not be accomplished right now. I'm working on a solution based on LauncherBootsrap, that is single independent class file and can be injected using DefineClass (from bytes) in the VM. That of course implicates the usage of commons-launcher. So perhaps instead of '-port shudownport' we should introduce '-embedded' where the catalina will wait for some sort of a signal from it's parent class. It can be AJP message, but allowed only from JNI channel (that will be the only one enabled in that mode), to skip the need for complicated authorization schemes. MT. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17867] - new virtual host doesn't work after restart
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17867. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17867 new virtual host doesn't work after restart [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 18:14 --- Cannot reproduce. Make sure you have saved your current the newly added host and context information using commit before restarting. Otherwise they will be lost after restart. Please reopen if you can still reproduce the error. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 15982] - jdbc realm - digest for cleartext pw does not work
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15982. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15982 jdbc realm - digest for cleartext pw does not work [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 18:16 --- Fixed to not set digest to an empty string when it's not entered in the input. Should be available in the next release 4.1.23. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17581] - Servlet loading twice on startup
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17581. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17581 Servlet loading twice on startup [EMAIL PROTECTED] changed: What|Removed |Added Component|Webapps:Administration |Catalina - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 13894] - The 'Install' button on Tomcat Web Application Server fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13894. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13894 The 'Install' button on Tomcat Web Application Server fails [EMAIL PROTECTED] changed: What|Removed |Added Severity|Minor |Enhancement Status|NEW |RESOLVED Resolution||LATER --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 18:26 --- Use manager webapp for deploy/undeploy. Admin webapp doesn't have the feature. Maybe we can add GUI version someday. It's an enhancement rather than a bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.1.txt
remm2003/03/14 10:35:22 Modified:.RELEASE-NOTES-4.1.txt Log: - Status update. Revision ChangesPath 1.65 +9 -1 jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt Index: RELEASE-NOTES-4.1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- RELEASE-NOTES-4.1.txt 12 Mar 2003 14:48:12 - 1.64 +++ RELEASE-NOTES-4.1.txt 14 Mar 2003 18:35:22 - 1.65 @@ -266,6 +266,14 @@ [4.1.21] Administration Webapp: Remove groups and roles tables on user and group page. +[4.1.23] #17744 + Administration Webapp: + Remove /admin part of URLs to make them relative. + +[4.1.23] #15982 + Administration Webapp: + Don't set JDBCRealm digest when it's an empty string. + -- Catalina Bug Fixes: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDBCRealm CLIENT-CERT Authentication
Hi,
i tried the following:
+ Add the mehtod authenticate(...) to the File JDBCRealm.java
+ build a Tomcat distribution
+ replace the catalina.jar with the new version (on an other machine)
+ add role-namefull DN/role-name to the web.xml
+ insert into table users ('DN','DN')
+ insert into table user_roles ('DN','DN')
Then i try to connect with a browser to the protected ressource and the
browser requests login and password.
Any suggestions?
thanks
Patrick
jazorin wrote:
Hi.
You can to implement a JDBCRealm with client certificates modifying the
org.apache.catalina.realm.JDBCRealm class. You need add the public
Principal authenticate(X509Certificate[] cert) method. Inside, you have
to include the following lines:
import java.security.cert.X509Certificate;
Connection dbConnection = null;
try {
// Obtain DN from client certificate.
String dn = cert[0].getSubjectDN().getName();
// Ensure that we have an open database connection
dbConnection = open();
// Acquire a Principal object for this user
Principal principal = authenticate(dbConnection,
dn, dn);
// Release the database connection we just used
release(dbConnection);
// Return the Principal (if any)
return (principal);
} catch (SQLException e) {
// Log the problem for posterity
log(sm.getString(jdbcRealm.exception), e);
// Close the connection so that it gets reopened next time
if (dbConnection != null)
close(dbConnection);
// Return not authenticated for this request
return (null);
}
In authenticate(dbConnection,dn,dn); - first dn = name of user (login)
and second dn = credentials. These credentials can to be the OU of the
certificate, etc.
With the previous example you have to put in role-name of web.xml the
full DN, and you need to create a user in BD with username = DN full
and credentials = DN full.
Luck!!
-
At 16:44 13/03/2003 +0100, you wrote:
Hello,
is it correct that only Memory- and JNDIRealm can perform the mapping
between the DN included in a certificate and a users role?
Because of the lack of dynamic changes in MemoryRealm, i want to replace
it with a JDBCRealm. Is there any information available how to implement
a JDBCRealm that authenticates users by CLIENT-CERT.
thanks in advance
Patrick
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.properties.default build.xml
remm2003/03/14 10:39:50
Modified:.build.properties.default build.xml
Log:
- Remove logkit. What was that used for ?
Revision ChangesPath
1.78 +1 -8 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.77
retrieving revision 1.78
diff -u -r1.77 -r1.78
--- build.properties.default 13 Mar 2003 22:56:37 - 1.77
+++ build.properties.default 14 Mar 2003 18:39:50 - 1.78
@@ -137,13 +137,6 @@
log4j.loc=http://jakarta.apache.org/log4j/jakarta-log4j-1.2.7.tar.gz
-# - LogKit -
-logkit.home=${base.path}/LogKit-1.1
-logkit.lib=${logkit.home}
-logkit.jar=${logkit.lib}/logkit-1.1.jar
-logkit.loc=http://jakarta.apache.org/builds/jakarta-avalon/release/logkit/latest/LogKit-1.2-bin.tar.gz
-
-
# - Commons DBCP, version 1.0 or later -
commons-dbcp.home=${base.path}/commons-dbcp-1.0
commons-dbcp.lib=${commons-dbcp.home}
1.108 +0 -5 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.107
retrieving revision 1.108
diff -u -r1.107 -r1.108
--- build.xml 14 Mar 2003 15:28:06 - 1.107
+++ build.xml 14 Mar 2003 18:39:50 - 1.108
@@ -1275,11 +1275,6 @@
/antcall
antcall target=downloadgz
- param name=sourcefile value=${logkit.loc}/
- param name=destfile value=${logkit.jar}/
-/antcall
-
-antcall target=downloadgz
param name=sourcefile value=${commons-digester.loc}/
param name=destfile value=${commons-digester.jar}/
/antcall
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
remm2003/03/14 10:44:03 Modified:.build.xml Log: - Add back precompilation as part of the build. Revision ChangesPath 1.109 +2 -0 jakarta-tomcat-5/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v retrieving revision 1.108 retrieving revision 1.109 diff -u -r1.108 -r1.109 --- build.xml 14 Mar 2003 18:39:50 - 1.108 +++ build.xml 14 Mar 2003 18:44:03 - 1.109 @@ -540,6 +540,8 @@ antcall target=fix-webapps / +antcall target=build-webapps-precompile / + /target target name=fix-webapps depends=init - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.1.txt
you're fast. ;-) [EMAIL PROTECTED] wrote: remm2003/03/14 10:35:22 Modified:.RELEASE-NOTES-4.1.txt Log: - Status update. Revision ChangesPath 1.65 +9 -1 jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt Index: RELEASE-NOTES-4.1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- RELEASE-NOTES-4.1.txt 12 Mar 2003 14:48:12 - 1.64 +++ RELEASE-NOTES-4.1.txt 14 Mar 2003 18:35:22 - 1.65 @@ -266,6 +266,14 @@ [4.1.21] Administration Webapp: Remove groups and roles tables on user and group page. +[4.1.23] #17744 + Administration Webapp: + Remove /admin part of URLs to make them relative. + +[4.1.23] #15982 + Administration Webapp: + Don't set JDBCRealm digest when it's an empty string. + -- Catalina Bug Fixes: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat 5 build failing,
Is the regular ant dist command failing only for me, or are the build scripts broken or the properties updated somewhere? Filip -Original Message- From: Amy Roh [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 10:45 AM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.1.txt you're fast. ;-) [EMAIL PROTECTED] wrote: remm2003/03/14 10:35:22 Modified:.RELEASE-NOTES-4.1.txt Log: - Status update. Revision ChangesPath 1.65 +9 -1 jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt Index: RELEASE-NOTES-4.1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- RELEASE-NOTES-4.1.txt 12 Mar 2003 14:48:12 - 1.64 +++ RELEASE-NOTES-4.1.txt 14 Mar 2003 18:35:22 - 1.65 @@ -266,6 +266,14 @@ [4.1.21] Administration Webapp: Remove groups and roles tables on user and group page. +[4.1.23] #17744 + Administration Webapp: + Remove /admin part of URLs to make them relative. + +[4.1.23] #15982 + Administration Webapp: + Don't set JDBCRealm digest when it's an empty string. + -- Catalina Bug Fixes: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 11929] - JDBC Realm rejects user at first login
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929 JDBC Realm rejects user at first login --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 19:41 --- This is almost certainly caused by an SQLException being thrown in the JDBCRealm.authenticate() method. I hate that this exception is hidden from the user. Check your tomcat logs and I suspect you'll see an exception there; your DB Connection is probably going stale. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18004] - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 20:01 --- The only place that the actual cause of such a problem should show up is in the log files -- telling the user what the actual problem was just opens your app up to security attacks. Good security design says that the result of an are you authenticated question is a yes or no, with no further information available to potential attackers. I'm not an active Tomcat committer at the moment, but I strongly argue for a WONTFIX resolution on this one. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Tomcat 5 build failing,
oops, I just deleted everything to start from a clean build, I will let you know if I still see problems Filip -Original Message- From: Jean-Francois Arcand [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 12:02 PM To: Tomcat Developers List Subject: Re: Tomcat 5 build failing, That stangethe nightly build script that start at 11:59pm each day doesn't break. The scripts starts from a clean workspace.What is the error you are seeing? -- Jeanfrancois Filip Hanik wrote: Is the regular ant dist command failing only for me, or are the build scripts broken or the properties updated somewhere? Filip -Original Message- From: Amy Roh [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 10:45 AM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.1.txt you're fast. ;-) [EMAIL PROTECTED] wrote: remm2003/03/14 10:35:22 Modified:.RELEASE-NOTES-4.1.txt Log: - Status update. Revision ChangesPath 1.65 +9 -1 jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt Index: RELEASE-NOTES-4.1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- RELEASE-NOTES-4.1.txt12 Mar 2003 14:48:12 - 1.64 +++ RELEASE-NOTES-4.1.txt14 Mar 2003 18:35:22 - 1.65 @@ -266,6 +266,14 @@ [4.1.21] Administration Webapp: Remove groups and roles tables on user and group page. +[4.1.23] #17744 + Administration Webapp: + Remove /admin part of URLs to make them relative. + +[4.1.23] #15982 + Administration Webapp: + Don't set JDBCRealm digest when it's an empty string. + -- Catalina Bug Fixes: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: memory leak on context reload or stop/start? [was Re: trackingmemory usage over time]
We are using 4.1.20 where this particular leak (and another one in Jasper) is supposed to be fixed and we use jikes in any case. Thanks, Adi On Fri, 14 Mar 2003 10:51:57 +0530, Uddhav Shirname [EMAIL PROTECTED] said: The release note of Tomcat 4.1.18 talks about a known memory leak with JSPs. I am not aware of its status with Tomcat 4.1.20. This is what it has to say, JAVAC leaking memory: The Java compiler leaks memory each time a class is compiled. Web applications containing hundreds of JSP files may as a result trigger out of memory errors once a significant number of pages have been accessed. The memory can only be freed by stopping Tomcat and then restarting it. The JSP command line compiler (JSPC) can also be used to precompile the JSPs. -- Uddhav - Original Message - From: Aditya [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, March 14, 2003 10:27 AM Subject: memory leak on context reload or stop/start? [was Re: tracking memory usage over time] Just to followup, we have found a few things that were causing this leak, two that were particular to our setup, but the third seems to be a Tomcat problem (4.1.20 with Jasper2): 1) log4j was eating up a lot of memory and there was a slow leak. Since it wasn't strictly required, we've stopped using it and the largest leak stopped. 2) we are using jdbcpool from http://www.bitmechanic.com/projects/jdbcpool/ (it is the only connection pool we could find that can be instantiated programmatically from within a context without having to define a pool in advance via JDNI -- we give each context it's own database and therefore it's own pool) which doesn't seem to have a clean way to stop the pool manager thread when a context is stopped/reloaded. We've worked around this, however the memory leak remains and is due to context reloads / stops-starts 3) there seems to be a leak caused by reloading or stopping/starting a context (we have an automatic httpunit test that builds a jar file periodically and makes sure it is working in a context). We don't see the memory leak unless one or more JSPs are compiled before the context is reloaded or stopped/started. Is there some particular section of the code we should be examining to track this further? Adi On Tue, 25 Feb 2003 22:08:41 -0600, Glenn Nielsen [EMAIL PROTECTED] said: Aditya wrote: Glenn, several months ago you had posted a URL to a document (at kinetic.more.net if I remember correctly) where you talked about having to restart your production Tomcat(s) every 4 weeks or so due to Heap exhaustion. Is that still the case? If so what causes the heap exhaustion? I think that part of the heap problem for me was the recent bug in Jasper which I fixed where a number of resources such as Node trees from a JSP page compile were not dereferenced between compiles. This was fixed in Jasper before the 4.1.20 release. We've looked high and low, with JProbe etc, and we still can't find where the leak is. We're having to restart a Tomcat (4.1.20) with -Xms and -Xmx both set to 256M every 4 days or so. Does the increase in memory usage correlate with an increased number of connectors due to a spike in request volume? Perhaps you should try increasing the heap size. Regards, Glenn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18004] - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 20:27 --- Craig, I really wish you had to eat your own cooking on this one. I don't think you realize how many support requests, how much confusion, and how much frustration are generated because of this feature. The only information that needs to be communicated to the user is We cannot log you in at this time due to a system error. Please try back later. Many large websites do this, and it is a flaw in Tomcat that it cannot. A simple error message like the one I just mentioned is not going to reduce security in any significant way. The benefits outweigh the costs, big time. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 8363] - Out of memory error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8363. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8363 Out of memory error --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 20:45 --- Remy, when you say that the problems come from having too many active sessions. A more efficient session manager is a necessity for high availability scenarios when web applications are making heavy use of them. is this something documented with the session manager as is in TC 4.1? Any more pointers/bugids? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Costin Manolache wrote: Glenn Nielsen wrote: Remy Maucherat wrote: Glenn Nielsen wrote: There was a bug fix to JDBCStore after 4.1.22 was built. I think we need a 4.1.23 build for stable. Sorry! No problem. Since you're at it, could you remove the fileupload related functionality from 4.1.x ? If this is only because of the released state of commons-fileupload, then no. fileupload Beta 1 was released Feb 15, 2003. The HTMLManager is in synch with it and works. Beta != release. And no, that's not the main reason. If you need the manager to include fileupload - than place it in WEB-INF/lib, don't bloat server/lib. The /admin doesn't place struts.jar in server/lib. That can be done. But I will also have to move the /server/lib/servlets-manager.jar into /manager/WEB-INF/lib and add additional permissioins to the catalina.policy. I'm not comfortable with making HTMLManager too complex - but if you really need that, fine - but do it right. You could easily have a separate webapp that supports uploading - there is no need to have one kitchen-sink servlet that does everything. fileupload is used as part of the HTML anager so that you can upload a war file to install. It makes no sense to split it out to a separate webapp. Costin Besides, those features of the HTMLManager which use fileupload have already been included in a stable release. Kind of late to remove them now. Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18016] New: - multiple Logger components in server.xml do not work
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18016. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18016 multiple Logger components in server.xml do not work Summary: multiple Logger components in server.xml do not work Product: Tomcat 4 Version: 4.1.20 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Having multiple Logger components (each one using a class that extends o.a.c.logger.LoggerBase) in a container (ie. within Host) results in only the last one being used. This means I cannot log logfile output to two different files. If this is not meant to work, it should be documented. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17743] - enhancements to allow automatic login for web apps
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17743. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17743 enhancements to allow automatic login for web apps [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 21:12 --- Please delete this RFE. There's no need to do this as long as Tomcat5 uses the same Catalina container as Tomcat4. I was able to figure out how to do it using Tomcat4's Catalina container by creating my own authenticator. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Tomcat 5 build failing,
BUILD FAILED
file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72: Compile failed; see the
compiler error output for details.
compile:
[javac] Compiling 42 source files to C:\Development\jakarta-servletapi-5\jsr
152\build\classes
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:59: package javax.servlet.http does not exist
[javac] import javax.servlet.http.*;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspPage.java:102: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: interface javax.servlet.jsp.JspPage
[javac] public interface JspPage extends Servlet {
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:93: cannot resolve symbol
[javac] symbol : class HttpServletRequest
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] public void _jspService(HttpServletRequest request,
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:94: cannot resolve symbol
[javac] symbol : class HttpServletResponse
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] HttpServletResponse response)
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:95: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac]throws ServletException, IOException;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:58: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:59: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: package servlet
[javac] import javax.servlet.ServletRequest;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:60: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: package servlet
[javac] import javax.servlet.ServletResponse;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:152: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: class javax.servlet.jsp.JspFactory
[javac] public abstract PageContext getPageContext(Servlet s
ervlet,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:153: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletRequest request,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:154: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletResponse response,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:60: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:61: cannot resolve symbol
[javac] symbol : class ServletConfig
[javac] location: package servlet
[javac] import javax.servlet.ServletConfig;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:62: cannot resolve symbol
[javac] symbol : class ServletContext
[javac] location: package servlet
[javac] import javax.servlet.ServletContext;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:63: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: package servlet
[javac] import javax.servlet.ServletException;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
RE: Tomcat 5 build failing,
ant download
BUILD FAILED
file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72: Compile failed; see the
compiler error output for details.
compile:
[javac] Compiling 42 source files to C:\Development\jakarta-servletapi-5\jsr
152\build\classes
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:59: package javax.servlet.http does not exist
[javac] import javax.servlet.http.*;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspPage.java:102: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: interface javax.servlet.jsp.JspPage
[javac] public interface JspPage extends Servlet {
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:93: cannot resolve symbol
[javac] symbol : class HttpServletRequest
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] public void _jspService(HttpServletRequest request,
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:94: cannot resolve symbol
[javac] symbol : class HttpServletResponse
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] HttpServletResponse response)
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:95: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac]throws ServletException, IOException;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:58: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:59: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: package servlet
[javac] import javax.servlet.ServletRequest;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:60: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: package servlet
[javac] import javax.servlet.ServletResponse;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:152: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: class javax.servlet.jsp.JspFactory
[javac] public abstract PageContext getPageContext(Servlet s
ervlet,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:153: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletRequest request,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:154: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletResponse response,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:60: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:61: cannot resolve symbol
[javac] symbol : class ServletConfig
[javac] location: package servlet
[javac] import javax.servlet.ServletConfig;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:62: cannot resolve symbol
[javac] symbol : class ServletContext
[javac] location: package servlet
[javac] import javax.servlet.ServletContext;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:63: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: package servlet
[javac] import javax.servlet.ServletException;
[javac] ^
[javac]
RE: Tomcat 5 build failing,
the error is in
jsr152/build.xml
and the correct value is
property name=servlet-api.jar
value=../jsr154/servlet-api-2.4/lib/servlet-api.jar/
this link is wrong in the existing CVS, but I'm not gonna fix it, because I will
probably break something else
Filip
-Original Message-
From: Filip Hanik
Sent: Friday, March 14, 2003 1:12 PM
To: Tomcat Developers List
Subject: RE: Tomcat 5 build failing,
ant download
BUILD FAILED
file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72:
Compile failed; see the compiler error output for details.
compile:
[javac] Compiling 42 source files to
C:\Development\jakarta-servletapi-5\jsr
152\build\classes
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:59: package javax.servlet.http does not exist
[javac] import javax.servlet.http.*;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspPage.java:102: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: interface javax.servlet.jsp.JspPage
[javac] public interface JspPage extends Servlet {
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:93: cannot resolve symbol
[javac] symbol : class HttpServletRequest
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] public void _jspService(HttpServletRequest request,
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:94: cannot resolve symbol
[javac] symbol : class HttpServletResponse
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] HttpServletResponse response)
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:95: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac]throws ServletException, IOException;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:58: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:59: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: package servlet
[javac] import javax.servlet.ServletRequest;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:60: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: package servlet
[javac] import javax.servlet.ServletResponse;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:152: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: class javax.servlet.jsp.JspFactory
[javac] public abstract PageContext
getPageContext(Servlet s
ervlet,
[javac]^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:153: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: class javax.servlet.jsp.JspFactory
[javac]
ServletRequest request,
[javac]^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:154: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: class javax.servlet.jsp.JspFactory
[javac]
ServletResponse response,
[javac]^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:60: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:61: cannot resolve symbol
[javac] symbol : class ServletConfig
[javac] location: package servlet
[javac] import javax.servlet.ServletConfig;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:62: cannot
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Glenn Nielsen wrote: Beta != release. And no, that's not the main reason. If you need the manager to include fileupload - than place it in WEB-INF/lib, don't bloat server/lib. The /admin doesn't place struts.jar in server/lib. That can be done. But I will also have to move the /server/lib/servlets-manager.jar into /manager/WEB-INF/lib and add additional permissioins to the catalina.policy. I'm not comfortable with making HTMLManager too complex - but if you really need that, fine - but do it right. You could easily have a separate webapp that supports uploading - there is no need to have one kitchen-sink servlet that does everything. fileupload is used as part of the HTML anager so that you can upload a war file to install. It makes no sense to split it out to a separate webapp. I understand what fileupload is doing - but HTML Manager doesn't have to get into content management, it is wrong design. Create another servlet that supports upload functionality. Or use webdav. We just can't keep adding features to HTMLManager - it is already too big for one servlet. And certainly not in 4.1.22. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18004] - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 21:25 --- Been there (dealt with user support issues) ... done that (tried to make error messages more helpful) ... and I've seen server containers that behave the way you propose get themselves published on CERT advisories for having security vulnerabilities (what you want is *totally* against basic Security 101 design principles). I'm not interested in seeing that happen to Tomcat. If you deploy an app that throws a JDBC exception in the authenticate method (say, because you mis-typed the name of one of the columns in the config), that is first and foremost a flaw in your application testing and deployment practices, which needs to be addressed before you even start thinking about how the server might be more responsive to reporting these problems to the ultimate end user. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REPOST] [VOTE] [4.1.22] Stability rating
Costin Manolache wrote: Glenn Nielsen wrote: Beta != release. And no, that's not the main reason. If you need the manager to include fileupload - than place it in WEB-INF/lib, don't bloat server/lib. The /admin doesn't place struts.jar in server/lib. That can be done. But I will also have to move the /server/lib/servlets-manager.jar into /manager/WEB-INF/lib and add additional permissioins to the catalina.policy. I'm not comfortable with making HTMLManager too complex - but if you really need that, fine - but do it right. You could easily have a separate webapp that supports uploading - there is no need to have one kitchen-sink servlet that does everything. fileupload is used as part of the HTML anager so that you can upload a war file to install. It makes no sense to split it out to a separate webapp. I understand what fileupload is doing - but HTML Manager doesn't have to get into content management, it is wrong design. Create another servlet that supports upload functionality. Or use webdav. We just can't keep adding features to HTMLManager - it is already too big for one servlet. NO, NO, NO. This doesn't have anything to do with content management. It allows you to upload a WAR file and have it installed as a web application context. i.e. One of the tasks the manager is supposed to do. Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Tomcat 5 build failing,
actually, it could all be associated with the base.path variable not being set in the
build.properties.default file
Filip
-Original Message-
From: Filip Hanik
Sent: Friday, March 14, 2003 1:20 PM
To: Tomcat Developers List
Subject: RE: Tomcat 5 build failing,
the error is in
jsr152/build.xml
and the correct value is
property name=servlet-api.jar
value=../jsr154/servlet-api-2.4/lib/servlet-api.jar/
this link is wrong in the existing CVS, but I'm not gonna fix
it, because I will probably break something else
Filip
-Original Message-
From: Filip Hanik
Sent: Friday, March 14, 2003 1:12 PM
To: Tomcat Developers List
Subject: RE: Tomcat 5 build failing,
ant download
BUILD FAILED
file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72:
Compile failed; see the compiler error output for details.
compile:
[javac] Compiling 42 source files to
C:\Development\jakarta-servletapi-5\jsr
152\build\classes
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:59: package javax.servlet.http does not exist
[javac] import javax.servlet.http.*;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspPage.java:102: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: interface javax.servlet.jsp.JspPage
[javac] public interface JspPage extends Servlet {
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:93: cannot resolve symbol
[javac] symbol : class HttpServletRequest
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] public void _jspService(HttpServletRequest request,
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:94: cannot resolve symbol
[javac] symbol : class HttpServletResponse
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] HttpServletResponse
response)
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:95: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac]throws ServletException, IOException;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:58: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:59: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: package servlet
[javac] import javax.servlet.ServletRequest;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:60: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: package servlet
[javac] import javax.servlet.ServletResponse;
[javac] ^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:152: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: class javax.servlet.jsp.JspFactory
[javac] public abstract PageContext
getPageContext(Servlet s
ervlet,
[javac]^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:153: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: class javax.servlet.jsp.JspFactory
[javac]
ServletRequest request,
[javac]^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:154: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: class javax.servlet.jsp.JspFactory
[javac]
ServletResponse response,
[javac]^
[javac]
C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:60: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac]
Re: Tomcat 5 build failing,
Filip Hanik wrote: actually, it could all be associated with the base.path variable not being set in the build.properties.default file Yes, base.path isn't set anymore. I suggest setting it back to /usr/local (ducking to avoid the flames). Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Tomcat 5 build failing,
Was jsr154 compiled correctly ?
Do you have it in your repository ?
Can you include the full build log - it's impossible to guess from a
fragment.
Costin
Filip Hanik wrote:
ant download
BUILD FAILED
file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72: Compile
failed; see the compiler error output for details.
compile:
[javac] Compiling 42 source files to
[C:\Development\jakarta-servletapi-5\jsr
152\build\classes
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:59: package javax.servlet.http does not exist
[javac] import javax.servlet.http.*;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspPage.java:102: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: interface javax.servlet.jsp.JspPage
[javac] public interface JspPage extends Servlet {
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:93: cannot resolve symbol
[javac] symbol : class HttpServletRequest
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] public void _jspService(HttpServletRequest request,
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:94: cannot resolve symbol
[javac] symbol : class HttpServletResponse
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] HttpServletResponse response)
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:95: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac]throws ServletException, IOException;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:58: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:59: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: package servlet
[javac] import javax.servlet.ServletRequest;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:60: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: package servlet
[javac] import javax.servlet.ServletResponse;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:152: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: class javax.servlet.jsp.JspFactory
[javac] public abstract PageContext getPageContext(Servlet
[s
ervlet,
[javac]^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:153: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletRequest
[request,
[javac]^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:154: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletResponse
[response,
[javac]^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:60: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:61: cannot resolve symbol
[javac] symbol : class ServletConfig
[javac] location: package servlet
[javac] import javax.servlet.ServletConfig;
[javac] ^
[javac]
[C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:62: cannot resolve symbol
[javac] symbol : class ServletContext
[javac] location: package servlet
[javac] import javax.servlet.ServletContext;
[javac]
DO NOT REPLY [Bug 18004] - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 21:35 --- Is Yahoo Mail listed on one of these CERT advisories? Because Yahoo Mail has the functionality for which I am asking. And if Yahoo Mail is on a CERT advisory, I would have to question the practicality of these advisories. I agree with you about the mis-typed column name; this is something that should come out in testing. What I am most concerned about is database downtime. As hard as we try to keep it from happening, databases do go down from time to time. This kind of problem really is a RuntimeException, and I don't see the harm in telling the user You can't log in right now. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18004] - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not --- Additional Comments From [EMAIL PROTECTED] 2003-03-14 21:45 --- One more thing on this topic and then I'll shut up: Making the change I am asking for does not preclude anyone from keeping the end- user experience exactly the same as it is now; anyone can eat the exception anywhere down the line. But implementing my suggestion will give people a CHOICE about how they want their site to behave, a choice we do not have now. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Loadbuild Problem
Filip Hanik wrote: ok, I think I got it working I did four things: 1. and then in jakarta-tomcat-5 build.properties.default I set the property base.path=c:/development/tomcat-base this can be set to anything, as long as it is a absolute directory, 2. in jakarta-servletapi-5/jsr152 build.xml I changed the property to property name=servlet-api.jar value=../jsr154/servlet-api-2.4/lib/servlet-api.jar/ 3. I built jsr154 cd \jakarta-servletapi-5\jsr154 ant 4. I copied one library \jakarta-servletapi-5\jsr154\servlet-api-2.4\lib\servlet-api.jar to \jakarta-servletapi-5\jsr152\servlet-api-2.4\lib\servlet-api.jar based on this, I think you can figure out what went wrong, I no longer have the full build error, just check out jakarta-tomcat-5 clean and you will reproduce it. Remy, setting it to /usr/local will not work :(, I'm working on windows, I'm sure I get flamed for that alone LOL I'm cheating, I'm using Cygwin. In theory, on straight Windows, /usr/local should translate to C:\usr\local Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java
jfarcand2003/03/14 14:07:33
Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
Log:
Add a do privileged block used when jsps are precompiled.
Revision ChangesPath
1.17 +39 -8
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- StandardWrapper.java 8 Mar 2003 06:58:11 - 1.16
+++ StandardWrapper.java 14 Mar 2003 22:07:33 - 1.17
@@ -70,6 +70,9 @@
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Stack;
+import java.security.AccessController;
+import java.security.PrivilegedActionException;
+import java.security.PrivilegedExceptionAction;
import javax.servlet.Servlet;
import javax.servlet.ServletConfig;
import javax.servlet.ServletContext;
@@ -926,18 +929,46 @@
// Load the specified servlet class from the appropriate class loader
Class classClass = null;
try {
-if (classLoader != null) {
-classClass = classLoader.loadClass(actualClass);
-} else {
-classClass = Class.forName(actualClass);
+if (System.getSecurityManager() != null){
+final ClassLoader fclassLoader = classLoader;
+final String factualClass = actualClass;
+try{
+classClass = (Class)AccessController.doPrivileged(
+new PrivilegedExceptionAction(){
+public Object run() throws Exception{
+if (fclassLoader != null) {
+return
fclassLoader.loadClass(factualClass);
+} else {
+return Class.forName(factualClass);
+}
+}
+});
+} catch(PrivilegedActionException pax){
+Exception ex = pax.getException();
+if (ex instanceof ClassNotFoundException){
+throw (ClassNotFoundException)ex;
+} else {
+log.error( Error loading
++ fclassLoader + + factualClass, ex );
+}
+}
+} else {
+if (classLoader != null) {
+classClass = classLoader.loadClass(actualClass);
+} else {
+classClass = Class.forName(actualClass);
+}
}
} catch (ClassNotFoundException e) {
unavailable(null);
+
+
log.error( Error loading + classLoader + + actualClass, e );
throw new ServletException
(sm.getString(standardWrapper.missingClass, actualClass),
e);
}
+
if (classClass == null) {
unavailable(null);
throw new ServletException
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tomcat 5 build failing,
I get the same error trying to build it and I do have jsr154 and jsr152
repositories. I'm checking to see if ***api.homes are set correctly.
Also, someone complained that he can't bring up admin and manager
webapps due to admin.xml and manager.xml location change. The
admin.xml and manager.xml files used to be installed in the top-level
webapps directory. Now they are installed in .../server/webapps/admin
and .../server/manager. So when Tomcat is started, the Manager and
Admintool do not start. I can't check that out right now since I can't
build it currently. I'll update if I resolve anything.
Amy
Filip Hanik wrote:
ant download
BUILD FAILED
file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72: Compile failed; see the
compiler error output for details.
compile:
[javac] Compiling 42 source files to C:\Development\jakarta-servletapi-5\jsr
152\build\classes
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:59: package javax.servlet.http does not exist
[javac] import javax.servlet.http.*;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspPage.java:102: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: interface javax.servlet.jsp.JspPage
[javac] public interface JspPage extends Servlet {
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:93: cannot resolve symbol
[javac] symbol : class HttpServletRequest
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] public void _jspService(HttpServletRequest request,
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:94: cannot resolve symbol
[javac] symbol : class HttpServletResponse
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac] HttpServletResponse response)
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\HttpJspPage.java:95: cannot resolve symbol
[javac] symbol : class ServletException
[javac] location: interface javax.servlet.jsp.HttpJspPage
[javac]throws ServletException, IOException;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:58: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:59: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: package servlet
[javac] import javax.servlet.ServletRequest;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:60: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: package servlet
[javac] import javax.servlet.ServletResponse;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:152: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: class javax.servlet.jsp.JspFactory
[javac] public abstract PageContext getPageContext(Servlet s
ervlet,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:153: cannot resolve symbol
[javac] symbol : class ServletRequest
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletRequest request,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\JspFactory.java:154: cannot resolve symbol
[javac] symbol : class ServletResponse
[javac] location: class javax.servlet.jsp.JspFactory
[javac]ServletResponse response,
[javac]^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:60: cannot resolve symbol
[javac] symbol : class Servlet
[javac] location: package servlet
[javac] import javax.servlet.Servlet;
[javac] ^
[javac] C:\Development\jakarta-servletapi-5\jsr152\src\share\javax\servlet\j
sp\PageContext.java:61: cannot resolve symbol
[javac] symbol : class ServletConfig
[javac] location: package servlet
[javac] import javax.servlet.ServletConfig;
[javac] ^
[javac]
RE: Loadbuild Problem
just out of curiousity, what IDE are you using? and what kind of environment do you set up when developing this? I use jbuilder just so that I can do step through debugging, and so on. but it is commercial (alot cheaper if you have student id :), which I do ) Filip -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 1:51 PM To: Tomcat Developers List Subject: Re: Loadbuild Problem Filip Hanik wrote: ok, I think I got it working I did four things: 1. and then in jakarta-tomcat-5 build.properties.default I set the property base.path=c:/development/tomcat-base this can be set to anything, as long as it is a absolute directory, 2. in jakarta-servletapi-5/jsr152 build.xml I changed the property to property name=servlet-api.jar value=../jsr154/servlet-api-2.4/lib/servlet-api.jar/ 3. I built jsr154 cd \jakarta-servletapi-5\jsr154 ant 4. I copied one library \jakarta-servletapi-5\jsr154\servlet-api-2.4\lib\servlet-api.jar to \jakarta-servletapi-5\jsr152\servlet-api-2.4\lib\servlet-api.jar based on this, I think you can figure out what went wrong, I no longer have the full build error, just check out jakarta-tomcat-5 clean and you will reproduce it. Remy, setting it to /usr/local will not work :(, I'm working on windows, I'm sure I get flamed for that alone LOL I'm cheating, I'm using Cygwin. In theory, on straight Windows, /usr/local should translate to C:\usr\local Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tomcat 5 build failing,
Amy Roh wrote: I get the same error trying to build it and I do have jsr154 and jsr152 repositories. I'm checking to see if ***api.homes are set correctly. Also, someone complained that he can't bring up admin and manager webapps due to admin.xml and manager.xml location change. The admin.xml and manager.xml files used to be installed in the top-level webapps directory. Now they are installed in .../server/webapps/admin and .../server/manager. So when Tomcat is started, the Manager and Admintool do not start. I can't check that out right now since I can't build it currently. I'll update if I resolve anything. I fixed that one already for the happy few who can build. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
costin 2003/03/14 14:42:43
Modified:.build.xml
Log:
Fix Filip's build.
It seems my clean workspace wasn't that clean after all.
This whole thing is unbelievable. I have no idea how we end up with this
mess.
( the fix is obviously a workaround that hides the real problem ).
Revision ChangesPath
1.111 +6 -1 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.110
retrieving revision 1.111
diff -u -r1.110 -r1.111
--- build.xml 14 Mar 2003 20:21:04 - 1.110
+++ build.xml 14 Mar 2003 22:42:43 - 1.111
@@ -144,8 +144,13 @@
target name=build-servletapi unless=servletapi.build.notrequired
echo== Building: ${servlet-api.jar}/echo
ant dir=${api.home}/jsr154 target=dist
-property name=servlet-api.dist value=${servlet-api.home} /
+!--property name=servlet-api.dist value=${servlet-api.home} /
+ --
/ant
+mkdir dir=${servlet-api.home}
+copy todir=${servlet-api.home}
+ fileset dir=${api.home}/jsr154/dist includes=** /
+/copy
/target
target name=build-jspapi unless=jspapi.build.notrequired
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18019] New: - DbcpDataSourceFactory and getConnection(String, String)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18019. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18019 DbcpDataSourceFactory and getConnection(String, String) Summary: DbcpDataSourceFactory and getConnection(String, String) Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Blocker Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I'm trying to convert code from Oracle's OC4J to run under Tomcat 4.1.18. As part of this, I'm trying to configure a DataSource that will let me use pooled connections with heavyweight users (each user has a unique username and password to access the database.) I can configure a database resource and open a pooled connection using DataSource.getConnection(), but this only lets me open a connection using the user/pass that was specified in the ResourceParams setup for JNDI. What I want to do is call DataSource.getConnection(String, String), but this throws an UnsupportedOperationException exception on the call to getConnection () (Note: see below for full stack trace.) Also, it seems this issues is not addressed in the docs, so I'm not really clear if there is something more I need to do, such as alter the way the database resource is defined, to make it work, or if this is just something that is not yet implemented Note: I've tried removing the user/password defintions from the ResourceParams definition, but this just seems to produce a message telling me I need to define them. So, I'm stuck. Wayne Stack Trace: java.lang.UnsupportedOperationException at org.apache.commons.dbcp.PoolingDataSource.getConnection (PoolingDataSource.java:125) at org.apache.commons.dbcp.BasicDataSource.getConnection (BasicDataSource.java:329) at com.nglm.webfh.DoRequest.getConnection(DoRequest.java:457) at com.nglm.webfh.Login.doLogin(Login.java:123) at com.nglm.webfh.Login.doPost(Login.java:104) at com.nglm.webfh.DoRequest.post(DoRequest.java:394) at com.nglm.webfh.DispatchServlet.invokeModule(DispatchServlet.java:155) at com.nglm.webfh.DispatchServlet.doPost(DispatchServlet.java:217) at javax.servlet.http.HttpServlet.service(HttpServlet.java:760) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:260) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:191) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContext.invoke (StandardContext.java:2415) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:180) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java:170) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:172) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardEngineValve.invoke (StandardEngineValve.java:174) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.coyote.tomcat4.CoyoteAdapter.service
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java
fhanik 2003/03/14 15:49:23
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
Log:
small change to allow the cluster to throw an exception when it decides not to
cluster enable
a context, and at that point, we simply fallback on the StandardManager
Revision ChangesPath
1.27 +20 -15
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- StandardContext.java 12 Mar 2003 21:32:49 - 1.26
+++ StandardContext.java 14 Mar 2003 23:49:22 - 1.27
@@ -158,10 +158,10 @@
/**
* The alternate deployment descriptor name.
- */
+ */
private String altDDName = null;
-
+
/**
* The set of application listener class names configured for this
* application, in the order they were encountered in the web.xml file.
@@ -791,15 +791,15 @@
}
-
+
/**
* Return the alternate Deployment Descriptor name.
*/
public String getAltDDName(){
return altDDName;
}
-
-
+
+
/**
* Set an alternate Deployment Descriptor name.
*/
@@ -1145,7 +1145,7 @@
if (context == null) {
context = new ApplicationContext(getBasePath(), this);
-if (altDDName != null)
+if (altDDName != null)
context.setAttribute(Globals.ALT_DD_ATTR,altDDName);
}
return (context.getFacade());
@@ -1261,7 +1261,7 @@
// The proxied resources will be refreshed on start
this.resources = null;
-support.firePropertyChange(resources, oldResources,
+support.firePropertyChange(resources, oldResources,
this.webappResources);
}
@@ -1634,19 +1634,19 @@
* property group, we only care about the URL pattern here. The
* JSP container will parse the rest.
*
- * @param pattern URL pattern to be mapped
+ * @param pattern URL pattern to be mapped
*/
public void addJspMapping(String pattern) {
String servletName = findServletMapping(*.jsp);
if (servletName == null) {
servletName = jsp;
}
-
+
// Properly handle file that are considered to be a jsp.
if (pattern.indexOf(*.) 0){
pattern = pattern.substring(pattern.lastIndexOf(*));
servletName = jsp;
-}
+}
addServletMapping(pattern, servletName);
}
@@ -3625,7 +3625,7 @@
env.put(ProxyDirContext.CONTEXT, getName());
try {
-ProxyDirContext proxyDirContext =
+ProxyDirContext proxyDirContext =
new ProxyDirContext(env, webappResources);
if (webappResources instanceof BaseDirContext) {
((BaseDirContext) webappResources).setDocBase(getBasePath());
@@ -3751,7 +3751,7 @@
// Set config file name
String appBase = getAppBase();
if (getConfigFile() == null appBase != null) {
-
+
String name = getName();
if (name.equals()) {
name = ROOT;
@@ -3798,7 +3798,12 @@
if (log.isDebugEnabled())
log.debug(Configuring default Manager);
if (getCluster() != null) {
-setManager(getCluster().createManager(getName()));
+try {
+setManager(getCluster().createManager(getName()));
+} catch ( Exception x ) {
+log.warn(Clustering disabled for context:+getName()+
reason:+x.getMessage());
+setManager(new StandardManager());
+}
} else {
setManager(new StandardManager());
}
@@ -4464,7 +4469,7 @@
Class.forName(org.apache.catalina.valves.RequestListenerValve);
requestListener = (Valve) clazz.newInstance();
} catch (Throwable t) {
-return false;
+return false;
}
// Add this Valve to our Pipeline
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp SimpleTcpCluster.java
fhanik 2003/03/14 16:20:56
Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
SimpleTcpReplicationManager.java
modules/cluster/src/share/org/apache/catalina/cluster/tcp
SimpleTcpCluster.java
Log:
okey dokey, let the managers notify the cluster when they are ready to receive data
from other nodes, instead of waiting for an event from the server
Revision ChangesPath
1.3 +20 -12
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SimpleTcpReplicationManager.java
Index: SimpleTcpReplicationManager.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SimpleTcpReplicationManager.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- SimpleTcpReplicationManager.java 20 Feb 2003 17:54:15 - 1.2
+++ SimpleTcpReplicationManager.java 15 Mar 2003 00:20:56 - 1.3
@@ -387,6 +387,10 @@
}
return null;
}
+
+public String getName() {
+return this.name;
+}
/**
* Prepare for the beginning of active use of the public methods of this
* component. This method should be called after codeconfigure()/code,
@@ -398,21 +402,25 @@
* @exception LifecycleException if this component detects a fatal error
* that prevents this component from being used
*/
-public void start() throws LifecycleException
-{
+public void start() throws LifecycleException {
mManagerRunning = true;
super.start();
//start the javagroups channel
-try
-{
+try {
//the channel is already running
if ( mChannelStarted ) return;
+if (cluster.getMembers().length 0) {
+SessionMessage msg =
+new SessionMessage(this.getName(),
+ SessionMessage.EVT_GET_ALL_SESSIONS,
+ null,
+ null);
+cluster.send(msg, cluster.getMembers()[0]);
+}//end if
+mChannelStarted = true;
+} catch ( Exception x ) {
+log(Unable to start SimpleTcpReplicationManager,x,1);
}
-catch ( Exception x )
-{
-log(Unable to start javagroups channel,x,1);
-}
-
}
/**
1.6 +26 -21
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java
Index: SimpleTcpCluster.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- SimpleTcpCluster.java 5 Mar 2003 23:54:47 - 1.5
+++ SimpleTcpCluster.java 15 Mar 2003 00:20:56 - 1.6
@@ -272,10 +272,10 @@
log.error(In SimpleTcpCluster.constructor(),x);
}
-if ( ServerFactory.getServer() instanceof StandardServer ) {
-StandardServer server = (StandardServer) ServerFactory.getServer();
-server.addLifecycleListener(this);
-}
+//if ( ServerFactory.getServer() instanceof StandardServer ) {
+//StandardServer server = (StandardServer) ServerFactory.getServer();
+//server.addLifecycleListener(this);
+//}
}
/**
@@ -381,6 +381,11 @@
return (this.protocol);
}
+public Member[] getMembers() {
+return service.getMembers();
+}
+
+
// - Public Methods
@@ -650,19 +655,19 @@
}
public void lifecycleEvent(LifecycleEvent lifecycleEvent){
-if (
lifecycleEvent.getLifecycle().AFTER_START_EVENT.equals(lifecycleEvent.getType()) ) {
-//The server has started
-SessionMessage msg =
-new SessionMessage(null,
- SessionMessage.EVT_GET_ALL_SESSIONS,
- null,
- null);
-if (service.getMembers().length 0) {
-Member mbr = service.getMembers()[0];
-send(msg, mbr);
-}
-
-}//end if
+//if (
lifecycleEvent.getLifecycle().AFTER_START_EVENT.equals(lifecycleEvent.getType()) ) {
+////The server has started
+//SessionMessage msg =
+//new SessionMessage(null,
+//
cvs commit: jakarta-tomcat-catalina/modules/cluster build.xml
fhanik 2003/03/14 16:57:36
Modified:modules/cluster build.xml
Log:
pain in the booty, some of the libraries have moved around, need to create a better
build script that reuses some of the info from the main one
Revision ChangesPath
1.2 +2 -2 jakarta-tomcat-catalina/modules/cluster/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/build.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- build.xml 19 Feb 2003 21:49:13 - 1.1
+++ build.xml 15 Mar 2003 00:57:36 - 1.2
@@ -19,9 +19,8 @@
path id=catalina.classpath
pathelement location=${cluster.lib}/server/lib/catalina.jar/
pathelement location=${cluster.lib}/server/lib/commons-logging.jar/
-pathelement location=${cluster.lib}/server/lib/mx4j-jmx.jar/
+pathelement location=${cluster.lib}/common/lib/mx4j-jmx.jar/
pathelement location=${cluster.lib}/common/lib/servlet-api.jar/
-
/path
!-- Source path --
@@ -120,6 +119,7 @@
!-- DIST: Create Distribution = --
target name=dist depends=build-catalina-cluster
+
jar destfile=${cluster.dist}/tomcat-replication.jar
basedir=${cluster.build}/classes/
/target
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17948] - error reported with Tomcat 4.1.18
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17948. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17948 error reported with Tomcat 4.1.18 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Strange logging error for 4.1.18
I'm running Tomcat 4.1.18 on Solaris 8 and Sun's JRE 1.3.x. I tried
searching for the list but I couldn't seem to find anything that'll
describe this problem.
Usually, I can start tomcat fine. However, it seems like once in a
while I got this error from stdout:
org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Log4JCategoryLog does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.newInstance(LogFactoryImpl.java:567)
at
org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:291)
at
org.apache.commons.logging.LogFactory.getLog(LogFactory.java:415)
at
org.apache.tomcat.util.log.CommonLogHandler.log(CommonLogHandler.java:97)
at org.apache.tomcat.util.log.Log.log(Log.java:198)
at org.apache.tomcat.util.log.Log.log(Log.java:192)
at org.apache.tomcat.util.log.Log.log(Log.java:174)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:533)
at java.lang.Thread.run(Thread.java:484)
Then Tomcat stops accepting connection and just hung there. Looking at
the ThreadPool.java code I see around line 522:
/* Check if should execute a runnable. */
try {
if(noThData) {
if(p.debug0) p.log( Getting new thread
data);
thData=toRun.getInitData();
noThData = false;
}
if(shouldRun) {
toRun.runIt(thData);
}
} catch(Throwable t) {
loghelper.log(Caught exception executing +
toRun.toString() + , terminating thread, t);
loghelper.flush();
/*
* The runnable throw an exception (can be even
a ThreadDeath),
* signalling that the thread die.
*
* The meaning is that we should release the thread from
* the pool.
*/
It seems to throw another exception on the loghelper.log() call inside
the catch(Throwable t) block. From here I suspect class loading issues,
but I couldn't figure out what is wrong. Note that I'm compiling
Tomcat from source using common-logging 1.0.2 and log4j 1.2.6. I
didn't include log4j in the tomcat distribution (not in server/lib) but
I do have a servlet that uses log4j1.2.6 and have the jar in the
WEB-INF/lib directory.
Does somebody experience anything like this before?
--
William Lee (Will)| Sendmail Inc.
Email: [EMAIL PROTECTED] | http://www.sendmail.com
Tel:(510) 594-5505|
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18004] - JDBCRealm.authenticate() eats SQLExceptions and should not
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18004 JDBCRealm.authenticate() eats SQLExceptions and should not --- Additional Comments From [EMAIL PROTECTED] 2003-03-15 06:23 --- *THANK YOU* for this warning! If Yahoo has shown you a database exception at login time, that's the last security straw in my book -- there have now been enough security-related problems reported against Yahoo that I will never ever use them again. I've just stopped using my last Yahoo id because of this. (If you have a clue who I am, and what my involement with Tomcat has been, you might want to take this seriously for yourself.) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java JSSEImplementation.java JSSESocketFactory.java
billbarker2003/03/14 22:55:21
Modified:util/java/org/apache/tomcat/util/net/jsse
JSSEImplementation.java JSSESocketFactory.java
Added: util/java/org/apache/tomcat/util/net/jsse
JSSE14SocketFactory.java
Log:
First part of refactoring for JSSE 1.1.x. There is still more to do, (especially
for Client-Auth), but now bug #17323 is a works-for-me.
Revision ChangesPath
1.2 +15 -1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
Index: JSSEImplementation.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JSSEImplementation.java 4 Oct 2002 20:03:10 - 1.1
+++ JSSEImplementation.java 15 Mar 2003 06:55:21 - 1.2
@@ -59,6 +59,7 @@
package org.apache.tomcat.util.net.jsse;
+import org.apache.tomcat.util.compat.JdkCompat;
import org.apache.tomcat.util.net.SSLImplementation;
import org.apache.tomcat.util.net.SSLSupport;
import org.apache.tomcat.util.net.ServerSocketFactory;
@@ -75,6 +76,8 @@
public class JSSEImplementation extends SSLImplementation
{
+static final String JSSE14SocketFactory =
+ org.apache.tomcat.net.jsse.JSSE11SocketFactory;
public JSSEImplementation() throws ClassNotFoundException {
// Check to see if JSSE is floating around somewhere
Class.forName(javax.net.ssl.SSLServerSocketFactory);
@@ -87,7 +90,18 @@
public ServerSocketFactory getServerSocketFactory()
{
- return new JSSESocketFactory();
+ ServerSocketFactory ssf = null;
+ if( JdkCompat.isJava14() ) {
+ try {
+ Class ssfCl = Class.forName(JSSE14SocketFactory);
+ ssf =(ServerSocketFactory)ssfCl.newInstance();
+ } catch(Exception ex) {
+ ssf = new JSSESocketFactory();
+ }
+ } else {
+ ssf = new JSSESocketFactory();
+ }
+ return ssf;
}
public SSLSupport getSSLSupport(Socket s)
1.2 +6 -6
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Index: JSSESocketFactory.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JSSESocketFactory.java4 Oct 2002 20:03:10 - 1.1
+++ JSSESocketFactory.java15 Mar 2003 06:55:21 - 1.2
@@ -92,15 +92,15 @@
public class JSSESocketFactory
extends org.apache.tomcat.util.net.ServerSocketFactory
{
-private String keystoreType;
+String keystoreType;
static String defaultKeystoreType = JKS;
static String defaultProtocol = TLS;
static String defaultAlgorithm = SunX509;
static boolean defaultClientAuth = false;
-private boolean clientAuth = false;
-private SSLServerSocketFactory sslProxy = null;
+boolean clientAuth = false;
+SSLServerSocketFactory sslProxy = null;
// defaults
static String defaultKeystoreFile=System.getProperty(user.home) +
@@ -146,7 +146,7 @@
// Internal methods
/** Read the keystore, init the SSL socket factory
*/
-private void initProxy() throws IOException {
+void initProxy() throws IOException {
try {
Security.addProvider (new sun.security.provider.Sun());
Security.addProvider (new com.sun.net.ssl.internal.ssl.Provider());
@@ -247,7 +247,7 @@
/** Set server socket properties ( accepted cipher suites, etc)
*/
-private void initServerSocket(ServerSocket ssocket) {
+void initServerSocket(ServerSocket ssocket) {
SSLServerSocket socket=(SSLServerSocket)ssocket;
// We enable all cipher suites when the socket is
@@ -260,7 +260,7 @@
socket.setNeedClientAuth(clientAuth);
}
-private KeyStore initKeyStore( String keystoreFile,
+KeyStore initKeyStore( String keystoreFile,
String keyPass)
throws IOException
{
1.1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java
Index: JSSE14SocketFactory.java
===
/*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
* reserved.
*
*
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java JSSEImplementation.java
billbarker2003/03/14 23:00:07
Modified:util/java/org/apache/tomcat/util/net/jsse
JSSE14SocketFactory.java JSSEImplementation.java
Log:
catch the tabs before the tab police nab me ;-).
Revision ChangesPath
1.2 +75 -75
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java
Index: JSSE14SocketFactory.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JSSE14SocketFactory.java 15 Mar 2003 06:55:21 - 1.1
+++ JSSE14SocketFactory.java 15 Mar 2003 07:00:07 - 1.2
@@ -96,90 +96,90 @@
public class JSSE14SocketFactory extends JSSESocketFactory {
public JSSE14SocketFactory () {
- super();
+super();
}
// Internal methods
/** Read the keystore, init the SSL socket factory
*/
void initProxy() throws IOException {
- try {
+try {
- // Please don't change the name of the attribute - other
- // software may depend on it ( j2ee for sure )
- String keystoreFile=(String)attributes.get(keystore);
- if( keystoreFile==null) keystoreFile=defaultKeystoreFile;
-
- keystoreType=(String)attributes.get(keystoreType);
- if( keystoreType==null) keystoreType=defaultKeystoreType;
-
- //determine whether we want client authentication
- // the presence of the attribute enables client auth
- String clientAuthStr=(String)attributes.get(clientauth);
- if(clientAuthStr != null){
- if(clientAuthStr.equals(true)){
- clientAuth=true;
- } else if(clientAuthStr.equals(false)) {
- clientAuth=false;
- } else {
- throw new IOException(Invalid value ' +
- clientAuthStr +
- ' for 'clientauth' parameter:);
- }
- }
-
- String keyPass=(String)attributes.get(keypass);
- if( keyPass==null) keyPass=defaultKeyPass;
-
- String keystorePass=(String)attributes.get(keystorePass);
- if( keystorePass==null) keystorePass=keyPass;
-
- //protocol for the SSL ie - TLS, SSL v3 etc.
- String protocol = (String)attributes.get(protocol);
- if(protocol == null) protocol = defaultProtocol;
-
- //Algorithm used to encode the certificate ie - SunX509
- String algorithm = (String)attributes.get(algorithm);
- if(algorithm == null) algorithm = defaultAlgorithm;
-
- // You can't use ssl without a server certificate.
- // Create a KeyStore ( to get server certs )
- KeyStore kstore = initKeyStore( keystoreFile, keystorePass );
-
- SSLContext context = SSLContext.getInstance(protocol); //SSL
-
- // Key manager will extract the server key
- KeyManagerFactory kmf = KeyManagerFactory.getInstance(algorithm);
- kmf.init( kstore, keyPass.toCharArray());
-
- // set up TrustManager
- TrustManager[] tm = null;
- String trustStoreFile = System.getProperty(javax.net.ssl.trustStore);
- String trustStorePassword =
- System.getProperty(javax.net.ssl.trustStorePassword);
- if ( trustStoreFile != null trustStorePassword != null ){
- KeyStore trustStore =
- initKeyStore( trustStoreFile, trustStorePassword);
+// Please don't change the name of the attribute - other
+// software may depend on it ( j2ee for sure )
+String keystoreFile=(String)attributes.get(keystore);
+if( keystoreFile==null) keystoreFile=defaultKeystoreFile;
+
+keystoreType=(String)attributes.get(keystoreType);
+if( keystoreType==null) keystoreType=defaultKeystoreType;
+
+//determine whether we want client authentication
+// the presence of the attribute enables client auth
+String clientAuthStr=(String)attributes.get(clientauth);
+if(clientAuthStr != null){
+if(clientAuthStr.equals(true)){
+clientAuth=true;
+} else if(clientAuthStr.equals(false)) {
+clientAuth=false;
+} else {
+throw new IOException(Invalid value ' +
+ clientAuthStr +
+ ' for 'clientauth' parameter:);
+}
+}
+
+String
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSEImplementation.java
billbarker2003/03/14 23:29:03
Modified:util/java/org/apache/tomcat/util/net/jsse
JSSEImplementation.java
Log:
Fixing major typo.
I'm now really having problems seeing what Ceki was complaining about in the first
place, since the fall-back to the old code was working just as well as the new code.
Revision ChangesPath
1.4 +1 -1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
Index: JSSEImplementation.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- JSSEImplementation.java 15 Mar 2003 07:00:07 - 1.3
+++ JSSEImplementation.java 15 Mar 2003 07:29:03 - 1.4
@@ -77,7 +77,7 @@
public class JSSEImplementation extends SSLImplementation
{
static final String JSSE14SocketFactory =
-org.apache.tomcat.net.jsse.JSSE11SocketFactory;
+org.apache.tomcat.net.jsse.JSSE14SocketFactory;
public JSSEImplementation() throws ClassNotFoundException {
// Check to see if JSSE is floating around somewhere
Class.forName(javax.net.ssl.SSLServerSocketFactory);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: Loadbuild Problem
ok, I think I got it working I did four things: 1. and then in jakarta-tomcat-5 build.properties.default I set the property base.path=c:/development/tomcat-base this can be set to anything, as long as it is a absolute directory, 2. in jakarta-servletapi-5/jsr152 build.xml I changed the property to property name=servlet-api.jar value=../jsr154/servlet-api-2.4/lib/servlet-api.jar/ 3. I built jsr154 cd \jakarta-servletapi-5\jsr154 ant 4. I copied one library \jakarta-servletapi-5\jsr154\servlet-api-2.4\lib\servlet-api.jar to \jakarta-servletapi-5\jsr152\servlet-api-2.4\lib\servlet-api.jar based on this, I think you can figure out what went wrong, I no longer have the full build error, just check out jakarta-tomcat-5 clean and you will reproduce it. Remy, setting it to /usr/local will not work :(, I'm working on windows, I'm sure I get flamed for that alone LOL Filip -Original Message- From: Filip Hanik Sent: Friday, March 14, 2003 1:24 PM To: Tomcat Users List Subject: RE: Loadbuild Problem and there are more problems, I will let you know if I get it working FIlip -Original Message- From: Filip Hanik Sent: Friday, March 14, 2003 1:21 PM To: Tomcat Users List Subject: RE: Loadbuild Problem the error is in jsr152/build.xml and the correct value is property name=servlet-api.jar value=../jsr154/servlet-api-2.4/lib/servlet-api.jar/ Filip -Original Message- From: kevin carey [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 1:10 PM To: [EMAIL PROTECTED] Subject: Loadbuild Problem Hi, I'm building Tomcat from scratch using directions from http://jakarta.apache.org/tomcat/building.html I'm running JDK 1.4 on Linux. After about 3 hours, build fails with message: BUILD FAILED file:/home/kevin/apps/tomcat/src/jakarta-tomcat-5/build.xml:465: Basedir /home/kevin/apps/tomcat/src/jakarta-commons/el does not exist Any thoughts? newbie. __ Do you Yahoo!? Yahoo! Web Hosting - establish your business online http://webhosting.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: JNDI realm - recursive group/role matching (Tomcat 4.1.18)
Hello.
I know it's not trivial, but it could be done. Below, a quicly done test
class that overrides the JNDIRealm to retrieve groups from groups. As i
explained in another mail i posted in the developer mailing list, the main
problem is not the code to do it, but how integrate it within Tomcat : the
JNDIRealm uses 'package scoped' classes, and if you want to change it you
must either create your new class with few overriden methods in the same
package, and it's not very elegant, or rewrite a full implementation. For
that, as this new feature is probably as common as to be integrated in the
Tomcat delivery, i hope one of the apache's members takes it into account in
a future version of the JNDIRealm.
Regards.
NEW getRoles() CODE
package org.apache.catalina.realm;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Set;
import javax.naming.NamingEnumeration;
import javax.naming.NamingException;
import javax.naming.directory.Attribute;
import javax.naming.directory.Attributes;
import javax.naming.directory.DirContext;
import javax.naming.directory.SearchControls;
import javax.naming.directory.SearchResult;
public class SmartJNDIRealm extends JNDIRealm {
protected List getRoles(final DirContext dirContext, final User user)
throws NamingException {
List plainList = super.getRoles(dirContext, user);
if (plainList == null)
return plainList;
HashSet recursiveSet = new HashSet();
for (Iterator i = plainList.iterator(); i.hasNext();) {
String groupName = (String) i.next();
recursiveGroupSearch(dirContext, recursiveSet, groupName);
}
if (debug = 2) {
log( * Returning set with + recursiveSet.size() +
roles);
for (Iterator i = recursiveSet.iterator(); i.hasNext();)
log( * - Recursively found role + i.next());
}
return new ArrayList(recursiveSet);
}
protected void recursiveGroupSearch(final DirContext dirContext, Set
recursiveSet, String groupname) throws NamingException {
if (debug = 3)
log( *** Recursive search for group ' + groupname + ');
// Adding the given group to the result set if not already found
if (!recursiveSet.contains(groupname)) {
recursiveSet.add(groupname);
// Prepare the parameters for searching groups
String filter = roleFormat.format(new String[] { roleName +
= +
groupname + , + roleBase });
SearchControls controls = new SearchControls();
controls.setSearchScope(roleSubtree ?
SearchControls.SUBTREE_SCOPE :
SearchControls.ONELEVEL_SCOPE);
controls.setReturningAttributes(new String[] { roleName });
if (debug = 3) {
log( * Searching recursively role base ' + roleBase
+ ' for
attribute ' + roleName + ');
log( * With filter expression ' + filter + ');
}
// Searching groups that assign the given group
NamingEnumeration gne = context.search(roleBase, filter,
controls);
if (gne != null) {
// Iterate over the resulting groups
while (gne.hasMore()) {
SearchResult sr = (SearchResult) gne.next();
Attributes attributes = sr.getAttributes();
if (attributes != null) {
Attribute attribute =
attributes.get(roleName);
if (attribute != null)
recursiveGroupSearch(dirContext, recursiveSet, (String)
attribute.get());
}
}
}
}
}
public String getInfo() {
return org.apache.catalina.realm.SmartJNDIRealm/1.0;
}
protected String getName() {
return SmartJNDIRealm;
}
}
Philippe Maseres
Philippe -Message d'origine-
Philippe De : Jon Roberts [mailto:[EMAIL PROTECTED]
Philippe Envoye : jeudi 13 mars 2003 20:21
Philippe A : Tomcat Users List
Philippe Objet : Re: JNDI realm - recursive group/role
Philippe matching (Tomcat 4.1.18)
Philippe
Philippe
Philippe I can't speak for tomcat, but I can say that what
Philippe you are asking is not
Philippe trivial. LDAP was not designed to support multi-join
