DO NOT REPLY [Bug 15278] - [PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=15278.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=15278

[PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 08:51 ---
this bug is still available in cvs

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Email account utilization warning.

2004-03-08 Thread administration
Dear user, the  management  of Apache.org  mailing system wants to let  you know that,

Your e-mail  account will be  disabled  because  of improper  using in  next
three days, if you are still wishing to  use it,  please, resign your
account  information.

For  more information see the attached file.

Attached file  protected with the password for  security  reasons. Password is 46855.

Kind regards,
The Apache.org  team http://www.apache.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Email account utilization warning.

2004-03-08 Thread ax
This account does not exist



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15278] - [PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=15278.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=15278

[PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 10:00 ---
Is the bug available or the current CVS HEAD still misbehaves?
As I said, unless you provide the test case, do not reopen the bug.
I have heavily tested the new implementation, and it works for me.
Please provide at least your environment specs like OS, Tomcat, etc...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27513] New: - When ThreadPool is shutdown one idle thread is left behind

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27513.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27513

When ThreadPool is shutdown one idle thread is left behind

   Summary: When ThreadPool is shutdown one idle thread is left
behind
   Product: Tomcat 5
   Version: 5.0.19
  Platform: All
OS/Version: All
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When org.apache.tomcat.util.threads.ThreadPool.shutdown() is called it
terminates all the idle threads except one (the last one that became idle). The
problem is that the mentioned method explicitly leaves that thread behind. That
can be easily seen (using a debugger) when tomcat is shutting down. In order to
solve the problem a very small correction is needed. In the mentioned method the
line:

for(int i = 0 ; i  (currentThreadCount - currentThreadsBusy - 1) ; i++) {

should become:

for(int i = 0 ; i  (currentThreadCount - currentThreadsBusy) ; i++) {

so that the loop would iterate over all the idle thread without exception.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27514] New: - Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in the request.getAttribute(xxx) but not in request.getAttributeNames().

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27514.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27514

Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in the 
request.getAttribute(xxx) but not in request.getAttributeNames().

   Summary: Environment variables mapped through the JkEnvVar
(mod_jk 1.2) are present in the
request.getAttribute(xxx) but not in
request.getAttributeNames().
   Product: Tomcat 5
   Version: 5.0.19
  Platform: All
OS/Version: All
Status: NEW
  Severity: Major
  Priority: Other
 Component: Connector:Coyote
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in 
the request.getAttribute(xxx) but not in request.getAttributeNames(). 
 
As it turns out in 
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java
 
getAttribute method is properly implemented but in the getAttributeNames the 
attributes comming from the coyoteRequest are not taken into consideration 
(the same might happen in Tomcat 4 too, didn't tested) 
 
I made a patch to correct the behavior, however not being very familiar with 
the tomcat sources the patch corrects the above described behavior but might 
not be in line with your way of doing things so feel free to adjust on it. 
 
Best regards, 
Remus 
 
--- CoyoteRequest.java  2004-02-14 12:26:50.0 +0200 
+++ CoyoteRequest.java  2004-03-08 14:17:13.661831128 +0200 
@@ -163,6 +163,7 @@ 
  */ 
 public void setCoyoteRequest(Request coyoteRequest) { 
 this.coyoteRequest = coyoteRequest; 
+if(coyoteRequest.getAttributes().size() == 0) copyOriginalAttributes 
= false; 
 inputBuffer.setRequest(coyoteRequest); 
 } 
  
@@ -403,6 +404,14 @@ 
  */  
 protected Log log=null; 
  
+ 
+/** 
+* We can have attributes comming from JK (JkEnvVar) so before serving 
them 
+* trough getAttributeNames we have to be sure that the local attributes  
+* contains the ones from the coyoteRequest. 
+*/ 
+protected boolean copyOriginalAttributes = true; 
+ 
 // - Public 
Methods 
  
 /** 
@@ -436,6 +445,7 @@ 
 localName = null; 
  
 attributes.clear(); 
+copyOriginalAttributes = true; 
 notes.clear(); 
 cookies = null; 
  
@@ -990,6 +1000,7 @@ 
 if (isSecure()) { 
 getAttribute(Globals.CERTIFICATES_ATTR); 
 } 
+if( copyOriginalAttributes) 
attributes.putAll(coyoteRequest.getAttributes()); 
 return new Enumerator(attributes.keySet(), true); 
 }

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27514] - Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in the request.getAttribute(xxx) but not in request.getAttributeNames().

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27514.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27514

Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in the 
request.getAttribute(xxx) but not in request.getAttributeNames().





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 12:37 ---
Created an attachment (id=10704)
The patch.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27514] - Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in the request.getAttribute(xxx) but not in request.getAttributeNames().

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27514.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27514

Environment variables mapped through the JkEnvVar (mod_jk 1.2) are present in the 
request.getAttribute(xxx) but not in request.getAttributeNames().

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 12:49 ---


*** This bug has been marked as a duplicate of 25363 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 25363] - request.getAttributeNames() not working properly

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=25363.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=25363

request.getAttributeNames() not working properly

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 12:49 ---
*** Bug 27514 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java

2004-03-08 Thread remm
remm2004/03/08 06:48:28

  Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java
  Log:
  - 27513, submitted by Sergei Zhirikov.
  
  Revision  ChangesPath
  1.24  +1 -1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java
  
  Index: ThreadPool.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -r1.23 -r1.24
  --- ThreadPool.java   24 Feb 2004 08:50:05 -  1.23
  +++ ThreadPool.java   8 Mar 2004 14:48:28 -   1.24
  @@ -349,7 +349,7 @@
   monitor.terminate();
   monitor = null;
   }
  -for(int i = 0 ; i  (currentThreadCount - currentThreadsBusy - 1) ; 
i++) {
  +for(int i = 0; i  currentThreadCount - currentThreadsBusy; i++) {
   try {
   pool[i].terminate();
   } catch(Throwable t) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27513] - When ThreadPool is shutdown one idle thread is left behind

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27513.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27513

When ThreadPool is shutdown one idle thread is left behind

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 14:49 ---
Fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26890] - Multipart/Form-Data Unexpected End Of Part

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=26890.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26890

Multipart/Form-Data Unexpected End Of Part





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 15:08 ---
I have found that the bug does not occur with SSL.  So what I did was run all 
uploading through https for now, until the JK2 Connector goes through a new 
version release.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] New: - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

   Summary: The pageEncoding attribute is not used, when charset
value is set.
   Product: Tomcat 5
   Version: 5.0.19
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Major
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When you have jsp page saved in encoding UTF-8:

[EMAIL PROTECTED] contentType=text/html;charset=ISO-8859-2%
[EMAIL PROTECTED] pageEncoding=UTF-8%
html
headtitleJSP Page/title/head
body
ěššěřčžřžřýýáýžýí
brhr
/body
/html

then the jsp file is read with ISO-8859-2 encoding. There are wrong Czech
characters in the generated servlet.  But according to the JSP 2.0 specification
the file should be read with encoding from pageEncodintg (UTF-8 in my case) and
the responds has to be in charset value encoding ( ISO-8859-2).

We used the jasper-compiler.jar as jsp parser in NetBeans and we use the result
of the parsing for saving and loading jsp files into the editor, where the wrong
value of encoding causes problems.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 15:24 ---
I don't agree with that interpretation.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 15:33 ---
What do you exectly think?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 15:42 ---
There is part of the specification:

JSP.4.1
...
For JSP pages in standard syntax, the page character encoding is determined from
the following sources:
-A JSP configuration element page-encoding value whose URL pattern matches the page.
-The pageEncoding attribute of the page directive of the page. It is a
translation- time error to name different encodings in the pageEncoding
attribute of the page directive of a JSP page and in a JSP configuration element
whose URL pattern matches the page.
- The charset value of the contentType attribute of the page directive. This is
used to determine the page character encoding if neither a JSP configuration
element page-encoding nor the pageEncoding attribute are provided.
- If none of the above is provided, ISO-8859-1 is used as the default character
encoding.




Appendix JSP.D
Page Encoding Detection


3. If the file is a JSP page in standard syntax, use these steps. 

a. Check whether there is a JSP configuration element page-encoding whose URL
pattern matches this file. 

b. Read the file using the initial encoding and search for a pageEncoding
attribute in a page declaration. The specification requires the attribute to be
found only if it is not preceded by non-ASCII characters, so simplified
implementations are allowed. 

c. Report an error if there are a page-encoding configuration element whose
URL pattern matches this file and a pageEncoding attribute, and the two name
different encodings. 

d. If there is a page-encoding configuration element whose URL pattern matches
this file, the page character encoding is the one named in this element. 

e. Otherwise, if there is a pageEncoding attribute, the page character encoding
is the one named in this attribute. 

f. Otherwise, read the file using the initial encoding and search for a charset
value within a contentType attribute in a page declaration. If it exists, the
page character encoding is the one named in this charset value. The
specification requires the attribute to be found only if it is not preceded by
non-ASCII characters, so simplified implementations are allowed. 

g. Otherwise, the page character encoding is ISO-8859-1.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Minor



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 16:05 ---
I think that:
- you have way too much time on your hands
- charset and pageEncoding define the same thing, so this is at best an issue of
priority

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

2004-03-08 Thread luehe
luehe   2004/03/08 08:51:07

  Modified:jasper2/src/share/org/apache/jasper/compiler
JspRuntimeContext.java
   jasper2/src/share/org/apache/jasper/servlet JspServlet.java
  Log:
  Added JSP monitoring facility.
  Initially, the number of JSPs that have been loaded into a webapp is exposed
  as a monitorable attribute. Additional attributes (e.g., number of JSPs whose
  compilation failed, etc.) may follow.
  
  Revision  ChangesPath
  1.20  +14 -4 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspRuntimeContext.java
  
  Index: JspRuntimeContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspRuntimeContext.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- JspRuntimeContext.java5 Feb 2004 23:02:18 -   1.19
  +++ JspRuntimeContext.java8 Mar 2004 16:51:07 -   1.20
  @@ -243,6 +243,16 @@
   }
   
   /**
  + * Returns the number of JSPs for which JspServletWrappers exist, i.e.,
  + * the number of JSPs that have been loaded into the webapp.
  + *
  + * @return The number of JSPs that have been loaded into the webapp
  + */
  +public int getJspCount() {
  +return jsps.size();
  +}
  +
  +/**
* Get the SecurityManager Policy CodeSource for this web
* applicaiton context.
*
  
  
  
  1.33  +26 -7 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- JspServlet.java   3 Feb 2004 17:31:40 -   1.32
  +++ JspServlet.java   8 Mar 2004 16:51:07 -   1.33
  @@ -72,6 +72,7 @@
   
   import org.apache.commons.logging.Log;
   import org.apache.commons.logging.LogFactory;
  +
   import org.apache.jasper.Constants;
   import org.apache.jasper.EmbeddedServletOptions;
   import org.apache.jasper.Options;
  @@ -104,16 +105,18 @@
   private Options options;
   private JspRuntimeContext rctxt;
   
  -public void init(ServletConfig config)
  - throws ServletException {
  +
  +/*
  + * Initializes this JspServlet.
  + */
  +public void init(ServletConfig config) throws ServletException {
   
super.init(config);
this.config = config;
this.context = config.getServletContext();
  -
  -options = new EmbeddedServletOptions(config, context);
   
   // Initialize the JSP Runtime Context
  +options = new EmbeddedServletOptions(config, context);
   rctxt = new JspRuntimeContext(context,options);
   
if (log.isDebugEnabled()) {
  @@ -125,6 +128,21 @@
   
   
   /**
  + * Returns the number of JSPs for which JspServletWrappers exist, i.e.,
  + * the number of JSPs that have been loaded into the webapp with which
  + * this JspServlet is associated.
  + *
  + * This info may be used for monitoring purposes.
  + *
  + * @return The number of JSPs that have been loaded into the webapp with
  + * which this JspServlet is associated
  + */
  +public int getJspCount() {
  +return this.rctxt.getJspCount();
  +}
  +
  +
  +/**
* pLook for a emprecompilation request/em as described in
* Section 8.4.2 of the JSP 1.2 Specification.  strongWARNING/strong -
* we cannot use coderequest.getParameter()/code for this, because
  @@ -262,6 +280,7 @@
   if (log.isDebugEnabled()) {
   log.debug(JspServlet.destroy());
   }
  +
   rctxt.destroy();
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/users GroupForm.java RoleForm.java UserForm.java

2004-03-08 Thread amyroh
amyroh  2004/03/08 08:51:51

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources
DataSourceForm.java EnvEntryForm.java
MailSessionForm.java ResourceLinkForm.java
UserDatabaseForm.java
   webapps/admin/WEB-INF/classes/org/apache/webapp/admin/users
GroupForm.java RoleForm.java UserForm.java
  Log:
  Fix validation.
  
  Revision  ChangesPath
  1.6   +6 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java
  
  Index: DataSourceForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DataSourceForm.java   20 Jun 2002 22:53:16 -  1.5
  +++ DataSourceForm.java   8 Mar 2004 16:51:50 -   1.6
  @@ -342,7 +342,7 @@
   
   String submit = request.getParameter(submit);
   
  -if (submit != null) {
  +//if (submit != null) {
   
   // url is a required field
   if ((url == null) || (url.length()  1)) {
  @@ -391,7 +391,7 @@
   errors.add(password,
  new ActionError(users.error.quotes));
   }
  - }
  + //}
   return (errors);
   }

  
  
  
  1.8   +6 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/EnvEntryForm.java
  
  Index: EnvEntryForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/EnvEntryForm.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- EnvEntryForm.java 14 Jun 2002 13:29:29 -  1.7
  +++ EnvEntryForm.java 8 Mar 2004 16:51:50 -   1.8
  @@ -307,7 +307,7 @@
   errors = new ActionErrors();
   
   String submit = request.getParameter(submit);
  -if (submit != null) {
  +//if (submit != null) {
   
   // name is a required field
   if ((name == null) || (name.length()  1)) {
  @@ -346,7 +346,7 @@
  errors.add(value,
  new ActionError(resources.error.value.mismatch));
   }
  -}
  +//}
   return (errors);
   }
   
  
  
  
  1.2   +6 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/MailSessionForm.java
  
  Index: MailSessionForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/MailSessionForm.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- MailSessionForm.java  20 Jun 2002 02:31:05 -  1.1
  +++ MailSessionForm.java  8 Mar 2004 16:51:50 -   1.2
  @@ -239,14 +239,14 @@
   
   String submit = request.getParameter(submit);
   
  -if (submit != null) {
  +//if (submit != null) {
   
   // mailSmtpHost is a required field
   if ((mailhost == null) || (mailhost.length()  1)) {
   errors.add(mailhost,
 new ActionError(resources.error.mailhost.required));
   }
  - }
  + //}
   
   return (errors);
   }
  
  
  
  1.3   +6 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/ResourceLinkForm.java
  
  Index: ResourceLinkForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/ResourceLinkForm.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ResourceLinkForm.java 14 Jun 2002 13:29:29 -  1.2
  +++ ResourceLinkForm.java 8 Mar 2004 16:51:50 -   1.3
  @@ -239,7 +239,7 @@
   
   String submit = request.getParameter(submit);
   
  -if (submit != null) {
  +//if (submit != null) {
   
   // name is a required field
   if ((name == null) || (name.length()  1)) {
  @@ -259,7 +259,7 @@
  new ActionError(resources.error.type.required));
   }
   
  - }
  + //}
   
   return (errors);
   
  
  
  
  1.3   +6 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/UserDatabaseForm.java
  
  Index: UserDatabaseForm.java
  ===
  RCS file: 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2004-03-08 Thread luehe
luehe   2004/03/08 08:52:46

  Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
  Log:
  Added JSP monitoring facility.
  Initially, the number of JSPs that have been loaded into a webapp is exposed
  as a monitorable attribute. Additional attributes (e.g., number of JSPs whose
  compilation failed, etc.) may follow.
  
  Revision  ChangesPath
  1.38  +52 -13
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
  
  Index: StandardWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- StandardWrapper.java  27 Feb 2004 14:58:42 -  1.37
  +++ StandardWrapper.java  8 Mar 2004 16:52:46 -   1.38
  @@ -219,6 +219,18 @@
   
   
   /**
  + * True if this StandardWrapper is for the JspServlet
  + */
  +private boolean isJspServlet;
  +
  +
  +/**
  + * The ObjectName of the JSP monitoring mbean
  + */
  +private ObjectName jspMonitorON;
  +
  +
  +/**
* Should we swallow System.out
*/
   private boolean swallowOutput = false;
  @@ -502,7 +514,9 @@
   this.servletClass = servletClass;
   support.firePropertyChange(servletClass, oldServletClass,
  this.servletClass);
  -
  +if (Constants.JSP_SERVLET_CLASS.equals(servletClass)) {
  +isJspServlet = true;
  +}
   }
   
   
  @@ -1571,21 +1585,30 @@
   sequenceNumber++);
   broadcaster.sendNotification(notification);
   }
  +
  +if (isJspServlet  jspMonitorON != null ) {
  +Registry.getRegistry(null, null).unregisterComponent(jspMonitorON);
  +}
  +
   }
   
   protected void registerJMX(StandardContext ctx) {
  +
  +String parentName = ctx.getName();
  +parentName = (.equals(parentName)) ? / : parentName;
  +
  +String hostName = ctx.getParent().getName();
  +hostName = (hostName==null) ? DEFAULT : hostName;
  +
  +String domain = ctx.getDomain();
  +
  +String webMod= // + hostName + parentName;
  +String onameStr = domain + :j2eeType=Servlet,name= + getName() +
  +  ,WebModule= + webMod + ,J2EEApplication= +
  +  ctx.getJ2EEApplication() + ,J2EEServer= +
  +  ctx.getJ2EEServer();
  +
   try {
  -// it should be full name
  -String parentName=ctx.getName();
  -String hostName=ctx.getParent().getName();
  -String webMod= // + ((hostName==null)? DEFAULT :hostName ) +
  -((.equals(parentName) ) ? / : parentName );
  -String onameStr=ctx.getDomain() + 
  -:j2eeType=Servlet,name= + getName() + ,WebModule= +
  -webMod + ,J2EEApplication= +
  -ctx.getJ2EEApplication() + ,J2EEServer= +
  -ctx.getJ2EEServer();
  -
   oname=new ObjectName(onameStr);
   controller=oname;
   Registry.getRegistry(null, null)
  @@ -1602,6 +1625,22 @@
   } catch( Exception ex ) {
   log.info(Error registering servlet with jmx  + this);
   }
  +
  +if (isJspServlet) {
  +// Register JSP monitoring mbean
  +try {
  +jspMonitorON = new ObjectName(domain +
  +   :type=JspMonitor,path= +
  +  parentName + ,host= +
  +  hostName);
  +Registry.getRegistry(null, null)
  +.registerComponent(instance, jspMonitorON, null);
  +} catch( Exception ex ) {
  +log.info(Error registering JSP monitoring with jmx  +
  + instance);
  +}
  +}
  +
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager StatusTransformer.java

2004-03-08 Thread luehe
luehe   2004/03/08 08:53:30

  Modified:webapps/manager/WEB-INF/classes/org/apache/catalina/manager
StatusTransformer.java
  Log:
  Added JSP monitoring facility.
  Initially, the number of JSPs that have been loaded into a webapp is exposed
  as a monitorable attribute. Additional attributes (e.g., number of JSPs whose
  compilation failed, etc.) may follow.
  
  Revision  ChangesPath
  1.14  +34 -1 
jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java
  
  Index: StatusTransformer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- StatusTransformer.java2 Mar 2004 16:24:52 -   1.13
  +++ StatusTransformer.java8 Mar 2004 16:53:30 -   1.14
  @@ -585,6 +585,16 @@
   managerON = (ObjectName) iterator2.next();
   }
   
  +ObjectName queryJspMonitor = new ObjectName
  +(objectName.getDomain() + :type=JspMonitor,path= + contextName 
  + + ,host= + hostName + ,*);
  +Set jspMonitorsON = mBeanServer.queryNames(queryJspMonitor, null);
  +ObjectName jspMonitorON = null;
  +iterator2 = jspMonitorsON.iterator();
  +while (iterator2.hasNext()) {
  +jspMonitorON = (ObjectName) iterator2.next();
  +}
  +
   // Special case for the root context
   if (contextName.equals(/)) {
   contextName = ;
  @@ -605,6 +615,9 @@
   if (managerON != null) {
   writeManager(writer, managerON, mBeanServer, mode);
   }
  +if (jspMonitorON != null) {
  +writeJspMonitor(writer, jspMonitorON, mBeanServer, mode);
  +}
   writer.print(/p);
   
   String onStr = objectName.getDomain() 
  @@ -654,6 +667,26 @@
   // for now we don't write out the wrapper details
   }
   
  +}
  +
  +
  +/**
  + * Write JSP monitoring information.
  + */
  +public static void writeJspMonitor(PrintWriter writer,
  +   ObjectName objectName,
  +   MBeanServer mBeanServer,
  +   int mode)
  +throws Exception {
  +
  +if (mode == 0) {
  +writer.print(br);
  +writer.print( JSPs loaded: );
  +writer.print(mBeanServer.getAttribute
  + (objectName, jspCount));
  +} else if (mode == 1) {
  +// for now we don't write out anything
  +}
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet mbeans-descriptors.xml

2004-03-08 Thread luehe
luehe   2004/03/08 08:54:27

  Added:   jasper2/src/share/org/apache/jasper/servlet
mbeans-descriptors.xml
  Log:
  Added JSP monitoring facility.
  Initially, the number of JSPs that have been loaded into a webapp is exposed
  as a monitorable attribute. Additional attributes (e.g., number of JSPs whose
  compilation failed, etc.) may follow.
  
  Revision  ChangesPath
  1.1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  ?xml version=1.0?
  mbeans-descriptors
  
mbean name=JspMonitor
description=JSP Monitoring
 domain=Catalina
  group=Monitoring
   type=org.apache.jasper.servlet.JspServlet
  
  attribute   name=jspCount
description=The number of JSPs that have been loaded into a webapp
   type=int/
  
/mbean
  
  /mbeans-descriptors
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



^_^ mew-mew (-:

2004-03-08 Thread shachor
VIRUS WARNING.
Contaminated File: Msg.zip
Virus Name: WORM_BAGLE.GEN-1 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Minor   |Major



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 17:19 ---
I don't think so, that pageEncoding and charset define the same thing.

According to chapter JSP.4.1 Page Character Encoding the pageEncoding is for
encoding the page file itself. And according to chapter JSP.4.2 Response
Character Encoding the charset encoding is used for responds. When both
encoding are defined, then they are used for different things.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Minor



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 17:39 ---
Yes, of course. We have a disagreement then (sec 1.10.1). If nobody fixes this
horrible bug for a while, then I will resolve it appropriately.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Behaviour of load-on-startup=0

2004-03-08 Thread Michael Prescott
I stumbled on what I think is a small difference in Tomcat's behaviour from
the Servlet spec.  Looking at the code, it seems to affect both Tomcat 4 and
5.

In short, the servlet specs (2.3 and 2.4) says that a servlet with
load-on-startup value set to 0 should load before those with values of 1
or higher, but Tomcat loads 1+ first, and 0 last.

The load-on-startup element indicates that this servlet should be loaded
(instantiated and have its init() called) on the startup of the web
application. The optional contents of these element must be an integer
indicating the order in which the servlet should be loaded. If the value is
a negative integer, or the element is not present, the container is free to
load the servlet whenever it chooses. If the value is a positive integer or
0, the container must load and initialize the servlet as the application is
deployed. The container must guarantee that servlets marked with lower
integers are loaded before servlets marked with higher integers. The
container may choose the order of loading of servlets with the same
load-on-start-up value.

Here's the first part of loadOnStartup(Container[]). This code is identical
in Tomcat 4.x (StandardContext.java:3398) and 5.x
(StandardContext.java:3930).

public void loadOnStartup(Container children[]) {

  // Collect load on startup servlets that need to be initialized
  TreeMap map = new TreeMap();
  for (int i = 0; i  children.length; i++) {
Wrapper wrapper = (Wrapper) children[i];
int loadOnStartup = wrapper.getLoadOnStartup();
if (loadOnStartup  0)
continue;
if (loadOnStartup == 0) // Arbitrarily put them last
loadOnStartup = Integer.MAX_VALUE;
Integer key = new Integer(loadOnStartup);
ArrayList list = (ArrayList) map.get(key);
if (list == null) {
list = new ArrayList();
map.put(key, list);
}
list.add(wrapper);
  }
...

It appears the problem would be solved by deleting the lines that read:

if (loadOnStartup == 0) // Arbitrarily put them last
  loadOnStartup = Integer.MAX_VALUE;

Michael

--
Michael Prescott
Ingenura Inc.
[EMAIL PROTECTED]
(416) 686-8576
PGP Public Key: http://www.ingenura.com/keys/MichaelPrescott.asc


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 17:55 ---
Hi Petr,

you're right, this is a bug. I'll commit a patch shortly.

For the time being, as a workaround, you may want to collapse the 2 page
directives into a single page directive, like this:

[EMAIL PROTECTED] contentType=text/html;charset=ISO-8859-2 pageEncoding=UTF-8%

Jan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 18:27 ---
Hi Jan,

yes, it's workaround, but people can have some problems during saving or opening
jsp files in the jsp editor in NetBeans IDE. We use jasper-compiler.jar for
obtaining information about a jsp and the encoding is one of them. I'm
appreciate the  promiss of  fixing it.

thanks

Petr

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 27517] -

2004-03-08 Thread ax
This account does not exist



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27520] New: - NullPointerException when using JspC on webapp tree containing unreadable dir

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27520.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27520

NullPointerException when using JspC on webapp tree containing unreadable dir

   Summary: NullPointerException when using JspC on webapp tree
containing unreadable dir
   Product: Tomcat 5
   Version: 5.0.16
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When using JspC, it is possible to get a null pointer exception if the webapp
tree you are attempting to compile contains an unreadable directory. Here are
the lines that cause the stack trace from JspC.java, CVS version 1.61:

 806 if (f.exists()  f.isDirectory()) {
 807 String[] files = f.list();
 808 String ext;
 809 for (int i = 0; i  files.length; i++) {
 810 File f2 = new File(s, files[i]);

There is no check before line 809 to see if File.list() returned a null value.
Therefore, we get the following stack trace from the jspc Ant task:

   [jasper2] java.lang.NullPointerException
  [jasper2] at org.apache.jasper.JspC.scanFiles(JspC.java:809)
  [jasper2] at org.apache.jasper.JspC.execute(JspC.java:856)
  [jasper2] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  [jasper2] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  [jasper2] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  [jasper2] at java.lang.reflect.Method.invoke(Method.java:324)
  [jasper2] at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:157)
  [jasper2] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:306)
  [jasper2] at org.apache.tools.ant.Task.perform(Task.java:401)
  [jasper2] at
org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:102)
  [jasper2] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:306)
  [jasper2] at org.apache.tools.ant.Task.perform(Task.java:401)
  [jasper2] at
org.apache.tools.ant.taskdefs.Parallel$TaskRunnable.run(Parallel.java:457)
  [jasper2] at java.lang.Thread.run(Thread.java:536)

It would be much nicer if the task simply logged a warning or ignored the
unreadable directory.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Email account utilization warning.

2004-03-08 Thread Michael McGrady
What is this about?  I am sure of one thing, I did not improperly use 
anything.  I don't know what you mean about resign[ing my]account 
information either.  Since there was no attached file, I assume my 
security picked up an attempt to pass on a virus.  Anyone else seeing these?

Michael

At 01:07 AM 3/8/2004, you wrote:
Dear user, the  management  of Apache.org  mailing system wants to 
let  you know that,

Your e-mail  account will be  disabled  because  of improper  using in  next
three days, if you are still wishing to  use it,  please, resign your
account  information.
For  more information see the attached file.

Attached file  protected with the password for  security  reasons. 
Password is 46855.

Kind regards,
The Apache.org  team http://www.apache.org
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 27521] New: - java.lang.VerifyError compiling JSTL XML tags

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27521.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27521

java.lang.VerifyError compiling JSTL XML tags

   Summary: java.lang.VerifyError compiling JSTL XML tags
   Product: Tomcat 5
   Version: 5.0.0
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I get the following error trying to compile a JSP that uses certain JSTL XML 
tags (specifically, x:parse and x:transform work fine, everything else fails):

java.lang.VerifyError: Cannot inherit from final class
java.lang.ClassLoader.defineClass0(Native Method)
java.lang.ClassLoader.defineClass(ClassLoader.java:502)
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123)
org.apache.catalina.loader.WebappClassLoader.findClassInternal
(WebappClassLoader.java:1677)
org.apache.catalina.loader.WebappClassLoader.findClass
(WebappClassLoader.java:900)
org.apache.catalina.loader.WebappClassLoader.loadClass
(WebappClassLoader.java:1350)
org.apache.catalina.loader.WebappClassLoader.loadClass
(WebappClassLoader.java:1230)
java.lang.ClassLoader.loadClassInternal(ClassLoader.java:315)
org.apache.taglibs.standard.tag.common.xml.ExprSupport.doStartTag
(ExprSupport.java:101)
org.apache.jsp.jsp.test_jsp._jspx_meth_xstuff_out_0(test_jsp.java:137)
org.apache.jsp.jsp.test_jsp._jspService(test_jsp.java:72)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:133)
javax.servlet.http.HttpServlet.service(HttpServlet.java:856)
org.apache.jasper.servlet.JspServletWrapper.service
(JspServletWrapper.java:311)
org.apache.jasper.servlet.JspServlet.serviceJspFile
(JspServlet.java:301)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:248)
javax.servlet.http.HttpServlet.service(HttpServlet.java:856)

Some sample JSP that causes the error is below:

%@ taglib uri=http://java.sun.com/jsp/jstl/core; prefix=c %
%@ taglib uri=http://java.sun.com/jsp/jstl/xml; prefix=x %
%@ page isELIgnored=false %

c:import var=xmldata url=file:/C:/hipaa/work/xc/data/csa-complete.xml /
x:parse var=harold doc=${xmldata}/
x:out select=$harold/policy/title/

I'm not 100% sure that this is a Jasper problem and not a JSTL bug, but it 
seemed more likely.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Email account utilization warning.

2004-03-08 Thread Schalk
Yes, I have been getting a bunch of them myself.

Kind Regards
Schalk Neethling
Web Developer.Designer.Programmer.President
Volume4.Development.Multimedia.Branding
emotionalize.conceptualize.visualize.realize
Tel: +27125468436
Fax: +27125468436
email:[EMAIL PROTECTED]
web: www.volume4.com
 
This message contains information that is considered to be sensitive or
confidential and may not be forwarded or disclosed to any other party
without the permission of the sender. If you received this message in error,
please notify me immediately so that I can correct and delete the original
email. Thank you. 

:: -Original Message-
:: From: Michael McGrady [mailto:[EMAIL PROTECTED]
:: Sent: Monday, March 08, 2004 8:39 PM
:: To: Tomcat Developers List
:: Subject: Re: Email account utilization warning.
:: 
:: What is this about?  I am sure of one thing, I did not improperly use
:: anything.  I don't know what you mean about resign[ing my]account
:: information either.  Since there was no attached file, I assume my
:: security picked up an attempt to pass on a virus.  Anyone else seeing
these?
:: 
:: Michael
:: 
:: At 01:07 AM 3/8/2004, you wrote:
:: Dear user, the  management  of Apache.org  mailing system wants to
:: let  you know that,
:: 
:: Your e-mail  account will be  disabled  because  of improper  using in
next
:: three days, if you are still wishing to  use it,  please, resign your
:: account  information.
:: 
:: For  more information see the attached file.
:: 
:: Attached file  protected with the password for  security  reasons.
:: Password is 46855.
:: 
:: Kind regards,
::  The Apache.org  team
http://www.apache.org
:: 
:: -
:: To unsubscribe, e-mail: [EMAIL PROTECTED]
:: For additional commands, e-mail: [EMAIL PROTECTED]
:: 
:: 
:: 
:: -
:: To unsubscribe, e-mail: [EMAIL PROTECTED]
:: For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Behaviour of load-on-startup=0

2004-03-08 Thread George Sexton
Load on startup should really be deprecated because it duplicates
functionality available via context event listeners.

As a warning, there is some variance in servlet engines. The spec says 0
starts before 1, logically -1 should load before 0. In fact, some
containers (like Websphere if I remember correctly) don't process
entries with a value less than 0.

My practical advice to you is to look at context event listeners.

-Original Message-
From: Michael Prescott [mailto:[EMAIL PROTECTED] 
Sent: Monday, March 08, 2004 10:44 AM
To: [EMAIL PROTECTED]
Subject: Behaviour of load-on-startup=0


I stumbled on what I think is a small difference in Tomcat's behaviour
from
the Servlet spec.  Looking at the code, it seems to affect both Tomcat 4
and
5.

In short, the servlet specs (2.3 and 2.4) says that a servlet with
load-on-startup value set to 0 should load before those with values of
1
or higher, but Tomcat loads 1+ first, and 0 last.

The load-on-startup element indicates that this servlet should be
loaded
(instantiated and have its init() called) on the startup of the web
application. The optional contents of these element must be an integer
indicating the order in which the servlet should be loaded. If the value
is
a negative integer, or the element is not present, the container is free
to
load the servlet whenever it chooses. If the value is a positive integer
or
0, the container must load and initialize the servlet as the application
is
deployed. The container must guarantee that servlets marked with lower
integers are loaded before servlets marked with higher integers. The
container may choose the order of loading of servlets with the same
load-on-start-up value.

Here's the first part of loadOnStartup(Container[]). This code is
identical
in Tomcat 4.x (StandardContext.java:3398) and 5.x
(StandardContext.java:3930).

public void loadOnStartup(Container children[]) {

  // Collect load on startup servlets that need to be initialized
  TreeMap map = new TreeMap();
  for (int i = 0; i  children.length; i++) {
Wrapper wrapper = (Wrapper) children[i];
int loadOnStartup = wrapper.getLoadOnStartup();
if (loadOnStartup  0)
continue;
if (loadOnStartup == 0) // Arbitrarily put them last
loadOnStartup = Integer.MAX_VALUE;
Integer key = new Integer(loadOnStartup);
ArrayList list = (ArrayList) map.get(key);
if (list == null) {
list = new ArrayList();
map.put(key, list);
}
list.add(wrapper);
  }
...

It appears the problem would be solved by deleting the lines that read:

if (loadOnStartup == 0) // Arbitrarily put them last
  loadOnStartup = Integer.MAX_VALUE;

Michael

--
Michael Prescott
Ingenura Inc.
[EMAIL PROTECTED]
(416) 686-8576
PGP Public Key: http://www.ingenura.com/keys/MichaelPrescott.asc


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Behaviour of load-on-startup=0

2004-03-08 Thread Shapira, Yoav

Hi,

Load on startup should really be deprecated because it duplicates
functionality available via context event listeners.

I wouldn't rush to this conclusion at all.  The Servlet's init and
destroy methods are the appropriate place to configure the servlet.

As a warning, there is some variance in servlet engines. The spec says
0
starts before 1, logically -1 should load before 0. In fact, some
containers (like Websphere if I remember correctly) don't process
entries with a value less than 0.

Yes, there is some variance as you say, but the spec as quoted by Senor
Prescott is clear and doesn't follow your logically statement above.

Yoav Shapira



This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27521] - java.lang.VerifyError compiling JSTL XML tags

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27521.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27521

java.lang.VerifyError compiling JSTL XML tags

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 19:47 ---
The stack trace shows the exception in class loading, from some tag
xstuff:out.  Clearly not from the the test.  This is likely not a Jasper problem.

Please debug your own application, find help elsewhere if you can't.  In any
case, include the complete test case, in .war.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27521] - java.lang.VerifyError compiling JSTL XML tags

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27521.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27521

java.lang.VerifyError compiling JSTL XML tags





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 20:25 ---
Created an attachment (id=10709)
testcase as a war file

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27521] - java.lang.VerifyError compiling JSTL XML tags

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27521.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27521

java.lang.VerifyError compiling JSTL XML tags

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 20:29 ---
I apologize, I had changed the namespace from 'xstuff' to 'x' between the time 
that I captured the stack trace and the time I pasted the test code.  You may 
interpret 'xstuff:' in the output as equivalent to 'x:' in the jsp.  Anyway, I 
put the JSP and an xml file in a WAR, which has been attached.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27521] - java.lang.VerifyError compiling JSTL XML tags

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27521.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27521

java.lang.VerifyError compiling JSTL XML tags





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 20:40 ---
Addtnl Info:
Tomcat 5.0.19
JDK 1.4.1_02
appserv-jstl.jar is installed in tomcat's shared\lib dir.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler ParserController.java

2004-03-08 Thread luehe
luehe   2004/03/08 12:50:47

  Modified:jasper2/src/share/org/apache/jasper/compiler
ParserController.java
  Log:
  Fixed Bugzilla 27517 (The pageEncoding attribute is not used, when charset value is 
set.)
  
  Revision  ChangesPath
  1.51  +56 -23
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java
  
  Index: ParserController.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -r1.50 -r1.51
  --- ParserController.java 9 Feb 2004 23:12:57 -   1.50
  +++ ParserController.java 8 Mar 2004 20:50:47 -   1.51
  @@ -431,15 +431,19 @@
   }
   
   /*
  - * Determines page source encoding for page or tag file in JSP syntax
  + * Determines page source encoding for page or tag file in JSP syntax,
  + * by reading (in this order) the value of the 'pageEncoding' page
  + * directive attribute, or the charset value of the 'contentType' page
  + * directive attribute.
*
* @return The page encoding, or null if not found
*/
   private String getPageEncodingForJspSyntax(JspReader jspReader,
  -  Mark startMark)
  +Mark startMark)
throws JasperException {
   
String encoding = null;
  +String saveEncoding = null;
   
/*
 * Determine page encoding from directive of the form %@ page % or
  @@ -450,12 +454,22 @@
jspReader.skipSpaces();
// compare for tag , so we don't match taglib
if (jspReader.matches(tag ) || jspReader.matches(page)) {
  +
jspReader.skipSpaces();
  - encoding = getPageEncodingFromDirective(
  -Parser.parseAttributes(this, jspReader));
  - if (encoding != null) break;
  +Attributes attrs = Parser.parseAttributes(this, jspReader);
  + encoding = getPageEncodingFromDirective(attrs, pageEncoding);
  +if (encoding != null) {
  +break;
  +}
  + encoding = getPageEncodingFromDirective(attrs, contentType);
  +if (encoding != null) {
  +saveEncoding = encoding;
  +}
}
}
  +if (encoding == null) {
  +encoding = saveEncoding;
  +}
   
if (encoding == null) {
/*
  @@ -465,34 +479,53 @@
jspReader.reset(startMark);
while (jspReader.skipUntil(jsp:directive.page) != null) {
jspReader.skipSpaces();
  - encoding = getPageEncodingFromDirective(
  -Parser.parseAttributes(this, jspReader));
  - if (encoding != null) break;
  +Attributes attrs = Parser.parseAttributes(this, jspReader);
  +
  + encoding = getPageEncodingFromDirective(attrs, pageEncoding);
  +if (encoding != null) {
  +break;
  +}
  + encoding = getPageEncodingFromDirective(attrs, contentType);
  +if (encoding != null) {
  +saveEncoding = encoding;
  +}
}
  +if (encoding == null) {
  +encoding = saveEncoding;
  +}
}
   
return encoding;
   }
   
   /*
  - * Scans the given attributes for the 'pageEncoding' attribute, if present,
  - * or the 'contentType' attribute, and gets the page encoding from them.
  + * Scans the given attributes for the attribute with the given name,
  + * which is either 'pageEncoding' or 'contentType', and returns the
  + * specified page encoding.
  + *
  + * In the case of 'contentType', the page encoding is taken from the
  + * content type's 'charset' component.
*
  - * In the case of the 'contentType' attribute, the page encoding is taken
  - * from its 'charset' component.
  + * @param attrs The page directive attributes
  + * @param attrName The name of the attribute to search for (either
  + * 'pageEncoding' or 'contentType')
*
  - * @param attrs The attributes from which to determine the page encoding
  - * @return The page encoding
  + * @return The page encoding, or null
*/
  -private String getPageEncodingFromDirective(Attributes attrs) {
  - String encoding = attrs.getValue(pageEncoding);
  - if (encoding == null) {
  - String contentType = attrs.getValue(contentType);
  - if (contentType != null) {
  - int loc = contentType.indexOf(CHARSET);
  - if (loc != -1) {
  - 

DO NOT REPLY [Bug 27517] - The pageEncoding attribute is not used, when charset value is set.

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27517.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27517

The pageEncoding attribute is not used, when charset value is set.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27447] - CoyoteReader.readLine() read ahead problems

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27447.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27447

CoyoteReader.readLine() read ahead problems

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 21:16 ---
Thanks for the speedy work, but the problem still exists. I have attached 6 
test files and a simple test servlet. If I send these test files using our http 
client or the curl http client the results are the same. The curl command line 
I use is:

curl -F [EMAIL PROTECTED] http://localhost:8082/Test/TestServlet

Thanks

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27447] - CoyoteReader.readLine() read ahead problems

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27447.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27447

CoyoteReader.readLine() read ahead problems





--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 21:22 ---
Created an attachment (id=10712)
These are some files with text to test. We actually use XML, but these should suffice

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java Generator.java Node.java SmapUtil.java

2004-03-08 Thread kinman
kinman  2004/03/08 13:28:30

  Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Generator.java Node.java SmapUtil.java
  Log:
  - Currently, smap for inner classes are not generated to the correct class
files.  For inner class defined in servlet codes, there is nothing Jasper
can do, since the servlet codes are not parsed.  However, for inner classes
generated by Jasper, such as the helper classes for handling fragments,
the following changes are made to fix this problem:
  
- Add a field in Node to indicate the name of a inner class.  This field
  is set in Generator, and accessed in SmapUtil.
- In SmapUtil.generateSamp(), when scanning the page nodes, if the codes
  are meant for a inner class, the smap is generated to a buffer.  It
  now returns an array, pairing the class file names with their corresponding
  smaps.
- SmapUtil.installSmap() takes the array as an augment, and install the
  smaps into the corresponding class files.
  
  Revision  ChangesPath
  1.78  +5 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
  
  Index: Compiler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
  retrieving revision 1.77
  retrieving revision 1.78
  diff -u -r1.77 -r1.78
  --- Compiler.java 23 Jan 2004 01:50:08 -  1.77
  +++ Compiler.java 8 Mar 2004 21:28:28 -   1.78
  @@ -186,10 +186,10 @@
* @return a smap for the current JSP page, if one is generated,
* null otherwise
*/
  -private String generateJava()
  +private String[] generateJava()
   throws Exception
   {
  - String smapStr = null;
  + String[] smapStr = null;
   
   long t1=System.currentTimeMillis();
   
  @@ -306,7 +306,7 @@
   /** 
* Compile the servlet from .java file to .class file
*/
  -private void generateClass(String smap)
  +private void generateClass(String[] smap)
   throws FileNotFoundException, JasperException, Exception {
   
   long t1=System.currentTimeMillis();
  @@ -426,7 +426,7 @@
   
   // JSR45 Support
   if (! options.isSmapSuppressed()) {
  -SmapUtil.installSmap(ctxt.getClassFileName(), smap);
  +SmapUtil.installSmap(smap);
   }
   }
   
  @@ -453,7 +453,7 @@
   }
   
   try {
  -String smap = generateJava();
  +String[] smap = generateJava();
   if (compileClass) {
   generateClass(smap);
   }
  
  
  
  1.223 +6 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.222
  retrieving revision 1.223
  diff -u -r1.222 -r1.223
  --- Generator.java2 Mar 2004 19:39:12 -   1.222
  +++ Generator.java8 Mar 2004 21:28:28 -   1.223
  @@ -94,6 +94,8 @@
* @author Mandar Raje
* @author Rajiv Mordani
* @author Pierre Delisle
  + *
  + * Tomcat 4.1.x and Tomcat 5:
* @author Kin-man Chung
* @author Jan Luehe
* @author Shawn Bayern
  @@ -3913,6 +3915,7 @@
   Fragment result = new Fragment(fragments.size(), parent);
   fragments.add(result);
   this.used = true;
  +parent.setInnerClassName(className);
   
   ServletWriter out = result.getGenBuffer().getOut();
   out.pushIndent();
  
  
  
  1.80  +18 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java
  
  Index: Node.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
  retrieving revision 1.79
  retrieving revision 1.80
  diff -u -r1.79 -r1.80
  --- Node.java 1 Mar 2004 22:51:34 -   1.79
  +++ Node.java 8 Mar 2004 21:28:29 -   1.80
  @@ -116,6 +116,13 @@
   protected Nodes namedAttributeNodes; // cached for performance
   protected String qName;
   protected String localName;
  +/*
  + * The name of the inner class to which the codes for this node and
  + * its body are generated.  For instance, for jsp:body in foo.jsp,
  + * this is foo_jspHelper.  This is primarily used for communicating
  + * such info from Generator to Smap generator.
  + */
  +protected String innerClassName;
   
   private boolean isDummy;
   
  @@ -398,6 +405,14 @@
n = n.getParent();
}
return (Node.Root) n;
  +}
  +
  +public String 

JkUriSet bug.

2004-03-08 Thread NormW
Good morning All

In Mod_Jk2, jk_UriEnv.c, line 419, there is is a test to determine which end
of a URL template string has the *, to determine if the 'match type' should
be PREFIX or SUFFIX.
 [   if (uri[strlen(uri) - 1] == '*') {  ]

A URL template found in a workers2.properties [uri] section is passed to
jk_UriEnv_init() [line 321] without modification, and everything works as
expected.

URL's passed to jk_UriEnv_init() from Apache's .conf file have a (-nn)
number added to the end of them, thus the test at line 419 always fails, and
so they always default to being flagged as MATCH_TYPE_SUFFIX.

Log entry when using .conf (Location /admin/*) is as follows (the -1 is
the appended number, which increments for each conf url) :

[jk_uriEnv.c (448)]  uriEnv.init()  uri:/admin/*-1  host=*  uri=/admin/*-1
type=2 ctx=(null) prefix=(null) suffix=/admin/*-1

and when using [uri:/admin/*] is as follows:

[jk_uriEnv.c (448)]  uriEnv.init()  uri:/admin/*  host=*  uri=/admin/*
type=1 ctx=(null) prefix=/admin/ suffix=(null)

Additionally, the extra characters on the end of the passed 'template' will
mean suffix_len and prefix_len are incorrectly set also when received from
Apache.

I'm uncertain about why the numbers are added when received from Apache and
not when generated from inside workers2.properties. Can someone comment on
this please?

Norm



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27521] - java.lang.VerifyError compiling JSTL XML tags

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27521.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27521

java.lang.VerifyError compiling JSTL XML tags

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 21:48 ---
OK, the problem was actually with JSTL and Xalan.  The version of Xalan that 
is bundled in rt.jar with Java 1.4.1_02 defines:

public final class VariableStack implements Cloneable { /***/ }

whereas the class XPath with JSTL 1.1 defines the inner class

protected class JstlVariableContext extends org.apache.xpath.VariableStack 
{ /***/ }

hence the Cannot inherit from final class error.  The version of Xalan 
shipped with jstl.jar does not have the final modifier, but because Xalan is 
bundled with Java, you have to drop (the correct version of) Xalan.jar into 
tomcat_home/common/endorsed to get it to take.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Email account utilization warning.

2004-03-08 Thread Mark Roth
Hi Michael,

I think the message itself is from a clever virus that is trying to get 
you to open the attachment.  I thought I saw another such email go by my 
Inbox the other day that was signed The somethingelse.com team.

Fortunately, us Linux and Solaris folk don't have to worry about such 
things :)

---
Mark Roth, Java Software
JSP 2.0 Specification Lead
Sun Microsystems, Inc.
Michael McGrady wrote:
What is this about?  I am sure of one thing, I did not improperly use 
anything.  I don't know what you mean about resign[ing my]account 
information either.  Since there was no attached file, I assume my 
security picked up an attempt to pass on a virus.  Anyone else seeing 
these?

Michael

At 01:07 AM 3/8/2004, you wrote:

Dear user, the  management  of Apache.org  mailing system wants to 
let  you know that,

Your e-mail  account will be  disabled  because  of improper  using 
in  next
three days, if you are still wishing to  use it,  please, resign your
account  information.

For  more information see the attached file.

Attached file  protected with the password for  security  reasons. 
Password is 46855.

Kind regards,
The Apache.org  team 
http://www.apache.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_lb.c

2004-03-08 Thread truk
truk2004/03/08 15:01:07

  Modified:jk/native2/common jk_worker_lb.c
  Log:
  Fix bug 23483
  
  Only add worker to the workerTable if it is not already there.
  Add check for maximum workers too.
  
  Revision  ChangesPath
  1.38  +21 -5 jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c
  
  Index: jk_worker_lb.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- jk_worker_lb.c27 Feb 2004 08:34:18 -  1.37
  +++ jk_worker_lb.c8 Mar 2004 23:01:06 -   1.38
  @@ -448,7 +448,8 @@
   char *name = lb-lbWorkerMap-nameAt( env, lb-lbWorkerMap, i);
   jk_worker_t *w= env-getByName( env, name );
   int level=0;
  -int pos=0;
  +int pos;
  +int workerCnt;
   
   if( w== NULL ) {
   env-l-jkLog(env, env-l, JK_LOG_ERROR,
  @@ -463,12 +464,27 @@
   /* It's like disabled */
   if( level = JK_LB_LEVELS ) continue;
   
  -pos=lb-workerCnt[level]++;
  +/* check if worker is already in the table */
  +workerCnt = lb-workerCnt[level];
  +for(pos = 0 ; pos  workerCnt ; pos++) {
  +if( lb-workerTables[level][pos] == w ) {
  +break;
  +}
  +}
  +
  +if( pos == workerCnt ) {
  +if( pos == JK_LB_MAX_WORKERS ) {
  +env-l-jkLog(env, env-l, JK_LOG_ERROR,
  +  lb_worker.init(): maximum lb workers reached %s\n, 
name);
  +continue;
  +}
  +pos=lb-workerCnt[level]++;
   
  -lb-workerTables[level][pos]=w;
  +lb-workerTables[level][pos]=w;
   
  -w-lb_value = w-lb_factor;
  -w-in_error_state = JK_FALSE;
  +w-lb_value = w-lb_factor;
  +w-in_error_state = JK_FALSE;
  +}
   }
   
   return JK_OK;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_lb.c

2004-03-08 Thread ax
This account does not exist



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 23483] - More than 42 channels causes JK2 to segfault

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=23483.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=23483

More than 42 channels causes JK2 to segfault

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-08 23:02 ---
Fixed in CVS.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_lb.c

2004-03-08 Thread Kurt Miller
Could one of the more senior jtc committers review this for me please?

The problem was that jk_lb_refresh was being called for each channel
parsed and adding all the workers to the workersTable each time. The
result was that the first channel was added to the table n+1 times
(where n = total number of workers), the second channel was added n
times and the third channel n-1, etc. Consequently the table was
getting overrun.

I believe this problem may also account for the first channel(s)
getting more load because of the extra copies in the table.

-Kurt

- Original Message - 
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Monday, March 08, 2004 6:01 PM
Subject: cvs commit: jakarta-tomcat-connectors/jk/native2/common
jk_worker_lb.c


 truk2004/03/08 15:01:07

   Modified:jk/native2/common jk_worker_lb.c
   Log:
   Fix bug 23483

   Only add worker to the workerTable if it is not already there.
   Add check for maximum workers too.

   Revision  ChangesPath
   1.38  +21 -5
jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c

   Index: jk_worker_lb.c

===
   RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c,v
   retrieving revision 1.37
   retrieving revision 1.38
   diff -u -r1.37 -r1.38
   --- jk_worker_lb.c 27 Feb 2004 08:34:18 - 1.37
   +++ jk_worker_lb.c 8 Mar 2004 23:01:06 - 1.38
   @@ -448,7 +448,8 @@
char *name = lb-lbWorkerMap-nameAt( env,
lb-lbWorkerMap, i);
jk_worker_t *w= env-getByName( env, name );
int level=0;
   -int pos=0;
   +int pos;
   +int workerCnt;

if( w== NULL ) {
env-l-jkLog(env, env-l, JK_LOG_ERROR,
   @@ -463,12 +464,27 @@
/* It's like disabled */
if( level = JK_LB_LEVELS ) continue;

   -pos=lb-workerCnt[level]++;
   +/* check if worker is already in the table */
   +workerCnt = lb-workerCnt[level];
   +for(pos = 0 ; pos  workerCnt ; pos++) {
   +if( lb-workerTables[level][pos] == w ) {
   +break;
   +}
   +}
   +
   +if( pos == workerCnt ) {
   +if( pos == JK_LB_MAX_WORKERS ) {
   +env-l-jkLog(env, env-l, JK_LOG_ERROR,
   +  lb_worker.init(): maximum lb
workers reached %s\n, name);
   +continue;
   +}
   +pos=lb-workerCnt[level]++;

   -lb-workerTables[level][pos]=w;
   +lb-workerTables[level][pos]=w;

   -w-lb_value = w-lb_factor;
   -w-in_error_state = JK_FALSE;
   +w-lb_value = w-lb_factor;
   +w-in_error_state = JK_FALSE;
   +}
}

return JK_OK;




 
-
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf ByteChunk.java CharChunk.java

2004-03-08 Thread remm
remm2004/03/08 15:46:37

  Modified:util/java/org/apache/tomcat/util/buf ByteChunk.java
CharChunk.java
  Log:
  - The optimized write (direct writing when data appended is the size of the
buffer and the buffer is empty) works good when we would want to overflow
only when the data is actually bigger than the buffer.
  - Add flag to allow disabling this.
  
  Revision  ChangesPath
  1.19  +6 -1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/ByteChunk.java
  
  Index: ByteChunk.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/ByteChunk.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- ByteChunk.java5 Mar 2004 13:06:13 -   1.18
  +++ ByteChunk.java8 Mar 2004 23:46:37 -   1.19
  @@ -92,6 +92,7 @@
   private ByteOutputChannel out = null;
   
   private boolean isOutput=false;
  +private boolean optimizedWrite=true;
   
   /**
* Creates a new, uninitialized ByteChunk object.
  @@ -158,6 +159,10 @@
isSet=true;
   }
   
  +public void setOptimizedWrite(boolean optimizedWrite) {
  +this.optimizedWrite = optimizedWrite;
  +}
  +
   public void setEncoding( String enc ) {
this.enc=enc;
   }
  @@ -285,7 +290,7 @@
   // If the buffer is empty and the source is going to fill up all the
   // space in buffer, may as well write it directly to the output,
   // and avoid an extra copy
  -if ( len == limit  end == start) {
  +if ( optimizedWrite  len == limit  end == start) {
   out.realWriteBytes( src, off, len );
   return;
   }
  
  
  
  1.13  +7 -1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/CharChunk.java
  
  Index: CharChunk.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/CharChunk.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- CharChunk.java5 Mar 2004 13:08:00 -   1.12
  +++ CharChunk.java8 Mar 2004 23:46:37 -   1.13
  @@ -72,6 +72,8 @@
   private CharInputChannel in = null;
   private CharOutputChannel out = null;
   
  +private boolean optimizedWrite=true;
  +
   /**
* Creates a new, uninitialized CharChunk object.
*/
  @@ -126,6 +128,10 @@
   }
   
   
  +public void setOptimizedWrite(boolean optimizedWrite) {
  +this.optimizedWrite = optimizedWrite;
  +}
  +
   public void setChars( char[] c, int off, int len ) {
recycle();
isSet=true;
  @@ -251,7 +257,7 @@
   // Optimize on a common case.
   // If the source is going to fill up all the space in buffer, may
   // as well write it directly to the output, and avoid an extra copy
  -if ( len == limit  end == start) {
  +if ( optimizedWrite  len == limit  end == start) {
   out.realWriteChars( src, off, len );
   return;
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 InputBuffer.java

2004-03-08 Thread remm
remm2004/03/08 15:48:50

  Modified:catalina/src/share/org/apache/coyote/tomcat5
InputBuffer.java
  Log:
  - Fix bug 27447 (part 2): reading was not correct when completely filling up
the buffer.
  
  Revision  ChangesPath
  1.6   +1 -0  
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/InputBuffer.java
  
  Index: InputBuffer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/InputBuffer.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- InputBuffer.java  5 Mar 2004 13:04:24 -   1.5
  +++ InputBuffer.java  8 Mar 2004 23:48:50 -   1.6
  @@ -171,6 +171,7 @@
   bb.setByteInputChannel(this);
   cb = new CharChunk(size);
   cb.setLimit(size);
  +cb.setOptimizedWrite(false);
   cb.setCharInputChannel(this);
   cb.setCharOutputChannel(this);
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27447] - CoyoteReader.readLine() read ahead problems

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27447.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27447

CoyoteReader.readLine() read ahead problems

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2004-03-08 Thread remm
remm2004/03/08 15:59:12

  Modified:jasper2/src/share/org/apache/jasper JspC.java
  Log:
  - Fix bug 27520: Avoid NPE when folder is not readable.
  
  Revision  ChangesPath
  1.66  +6 -13 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.65
  retrieving revision 1.66
  diff -u -r1.65 -r1.66
  --- JspC.java 18 Feb 2004 21:22:21 -  1.65
  +++ JspC.java 8 Mar 2004 23:59:11 -   1.66
  @@ -796,28 +796,21 @@
   }
   while (!dirs.isEmpty()) {
   String s = dirs.pop().toString();
  -//System.out.println(-- + s);
   File f = new File(s);
   if (f.exists()  f.isDirectory()) {
   String[] files = f.list();
   String ext;
  -for (int i = 0; i  files.length; i++) {
  +for (int i = 0; (files != null)  i  files.length; i++) {
   File f2 = new File(s, files[i]);
  -//System.out.println(: + f2.getPath());
   if (f2.isDirectory()) {
   dirs.push(f2.getPath());
  -//System.out.println(++ + f2.getPath());
   } else {
   String path = f2.getPath();
   String uri = path.substring(uriRoot.length());
  -ext = files[i].substring(files[i].lastIndexOf('.')
  -  + 1);
  +ext = files[i].substring(files[i].lastIndexOf('.') +1);
   if (extensions.contains(ext) ||
  -jspConfig.isJspPage(uri)) {
  -//System.out.println(s + ? + files[i]);
  +jspConfig.isJspPage(uri)) {
   pages.addElement(path);
  -} else {
  - //System.out.println(not done: + ext);
   }
   }
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27520] - NullPointerException when using JspC on webapp tree containing unreadable dir

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27520.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27520

NullPointerException when using JspC on webapp tree containing unreadable dir

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27527] New: - Cannot run under JDK 1.5

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27527.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27527

Cannot run under JDK 1.5

   Summary: Cannot run under JDK 1.5
   Product: Tomcat 5
   Version: 5.0.16
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I compile my javabeans using JDK 1.5 but when I try hitting a JSP file under
Tomcat (also running under JDK 1.5) it fails to compile the JSP with the
following exception:

org.apache.jasper.JasperException: Unable to compile class for JSP

An error occurred at line: -1 in the jsp file: null

Generated servlet error:
[javac] Compiling 1 source file

C:\Program Files\Tomcat
5.0\work\Catalina\localhost\quickstart\org\apache\jsp\index_jsp.java:8: cannot
access java.lang.Object
bad class file: C:\Program Files\Java\j2re1.5.0\lib\rt.jar(java/lang/Object.class)
class file has wrong version 49.0, should be 48.0
Please remove or make sure it appears in the correct subdirectory of the classpath.
public final class index_jsp extends org.apache.jasper.runtime.HttpJspBase
 ^
1 error



org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:127)
org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:351)
org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:415)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:458)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:439)
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:552)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:291)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:301)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:248)
javax.servlet.http.HttpServlet.service(HttpServlet.java:856)

Is there a workaround for this issue? Is there a way to use the external
javac compiler instead of the built-in Jasper one? If not, please leave this
issue as priority CRITICAL, otherwise please provide the workaround and
downgrade the priority to NORMAL.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27527] - Cannot run under JDK 1.5

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27527.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27527

Cannot run under JDK 1.5

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-09 00:38 ---
Please post about this on tomcat-user.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServletWrapper.java

2004-03-08 Thread kinman
kinman  2004/03/08 16:47:10

  Modified:jasper2/src/share/org/apache/jasper/servlet
JspServletWrapper.java
  Log:
  Patch by Torsten Fohrer [EMAIL PROTECTED]
  
  - Fix Bugzilla 16113: removing then replacing a jsp page continues to give
a 404.
  
  Revision  ChangesPath
  1.32  +4 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java
  
  Index: JspServletWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java,v
  retrieving revision 1.31
  retrieving revision 1.32
  diff -u -r1.31 -r1.32
  --- JspServletWrapper.java2 Sep 2003 21:39:59 -   1.31
  +++ JspServletWrapper.java9 Mar 2004 00:47:10 -   1.32
  @@ -331,6 +331,7 @@
ex.getMessage());
   }
   } catch (FileNotFoundException ex) {
  +ctxt.incrementRemoved();
   String includeRequestUri = (String)
   request.getAttribute(javax.servlet.include.request_uri);
   if (includeRequestUri != null) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=16113.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=16113

removing then replacing a jsp page continues to give a 404

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-09 00:48 ---
Patch applied.  Thanks.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Low Hong Ming Jane/OS/HDBCorp is out of the office.

2004-03-08 Thread Low Hong Ming Jane
I will be out of the office starting  09/03/2004 and will not return until
18/03/2004.

As I am overseas, I will not be able to read your message. For any urgent
matters, please contact Ms Ariel Lee, [EMAIL PROTECTED] at tel.:
65-62481423 or Ms Gene Wong at tel.: 65-62481420.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27527] - Cannot run under JDK 1.5

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27527.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27527

Cannot run under JDK 1.5





--- Additional Comments From [EMAIL PROTECTED]  2004-03-09 00:59 ---
Remy,

   I will post to tomcat-user, but it is a good idea to post the solution to
this problem here so when future users try looking up the same bug they'll find
an immediate answer to their question.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[OT] unsubscribe stupid users with auto-replies

2004-03-08 Thread Guenter Knauf
Hi all,
I think that it is only fair for all others that those on the list which are too 
stupid to setup a separate mail account are directly unsubscribed once the list gets 
auto-replies about their absence.

We have already enough spam, and its nearly impossible to filter those senseless mails.
If this continues it will not last long till those who really want to follow the list 
and post useful stuff will leave - but then the problem is also solved because:
no real posts = no stupid auto-replies = dead list.

thanks, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Email account utilization warning.

2004-03-08 Thread Paul Speed
It is a little strange that noone from the apache team has stepped
forward to clarify that these are fake... since they are being sent
to an apache mailing list after all.
The clues I had that it was a fake:
1) Sent to an apache/jakarta mailing list... by apache.org.
2) Really poor grammar in the message. (Ok, who am I kidding? ;)
3) I started getting similar e-mails from my own domain. ;)
But it's probably given more than a few people pause.
-Paul
Mark Roth wrote:
Hi Michael,

I think the message itself is from a clever virus that is trying to get 
you to open the attachment.  I thought I saw another such email go by my 
Inbox the other day that was signed The somethingelse.com team.

Fortunately, us Linux and Solaris folk don't have to worry about such 
things :)

---
Mark Roth, Java Software
JSP 2.0 Specification Lead
Sun Microsystems, Inc.
Michael McGrady wrote:

What is this about?  I am sure of one thing, I did not improperly use 
anything.  I don't know what you mean about resign[ing my]account 
information either.  Since there was no attached file, I assume my 
security picked up an attempt to pass on a virus.  Anyone else seeing 
these?

Michael

At 01:07 AM 3/8/2004, you wrote:

Dear user, the  management  of Apache.org  mailing system wants to 
let  you know that,

Your e-mail  account will be  disabled  because  of improper  using 
in  next
three days, if you are still wishing to  use it,  please, resign your
account  information.

For  more information see the attached file.

Attached file  protected with the password for  security  reasons. 
Password is 46855.

Kind regards,
The Apache.org  team 
http://www.apache.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 27527] - Cannot run under JDK 1.5

2004-03-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27527.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27527

Cannot run under JDK 1.5





--- Additional Comments From [EMAIL PROTECTED]  2004-03-09 04:38 ---
FYI: Upgrading to the latest release (5.0.19 at this time) seems to fix this
problem.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common JkMX.java

2004-03-08 Thread billbarker
billbarker2004/03/08 21:39:15

  Modified:jk/java/org/apache/jk/common JkMX.java
  Log:
  Fix problems with finding the Adapter in TC 5.
  
  In TC 5, jmx.jar is in a different CL than jmx-tools.jar, so you can't use 
createMBean w/o specifying the CL.  TC 3  4 should work much as before.
  
  Revision  ChangesPath
  1.21  +103 -110  jakarta-tomcat-connectors/jk/java/org/apache/jk/common/JkMX.java
  
  Index: JkMX.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/JkMX.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- JkMX.java 24 Feb 2004 08:48:42 -  1.20
  +++ JkMX.java 9 Mar 2004 05:39:14 -   1.21
  @@ -36,96 +36,96 @@
   public class JkMX extends JkHandler
   {
   MBeanServer mserver;
  - private boolean enabled=false;
  - private int httpport=-1;
  - private String httphost=localhost;
  - private int jrmpport=-1;
  - private String jrmphost=localhost;
  +private boolean enabled=false;
  +private int httpport=-1;
  +private String httphost=localhost;
  +private int jrmpport=-1;
  +private String jrmphost=localhost;
   
  -public JkMX()
  -{
  +public JkMX() {
   }
   
   /*  Public methods  */
   
  - /** Enable the MX4J adapters (new way)
  -  */
  - public void setEnabled(boolean b) {
  - enabled=b;
  - }
  - 
  - public boolean getEnabled() {
  - return enabled;
  - }
  - 
  - /** Enable the MX4J adapters (old way, compatible)
  -  */
  - public void setPort(int i) {
  - enabled=(i != -1);
  - }
  - 
  - public int getPort() {
  - return ((httpport != -1) ? httpport : jrmpport);
  - }
  -
  - /** Enable the MX4J HTTP internal adapter
  -  */ 
  - public void setHttpPort( int i ) {
  - httpport=i;
  - }
  -
  - public int getHttpPort() {
  - return httpport;
  - }
  -
  - public void setHttpHost(String host ) {
  - this.httphost=host;
  - }
  -
  - public String getHttpHost() {
  - return httphost;
  - }
  -
  - /** Enable the MX4J JRMP internal adapter
  -  */
  - public void setJrmpPort( int i ) {
  - jrmpport=i;
  - }
  -
  - public int getJrmpPort() {
  - return jrmpport;
  - }
  -
  - public void setJrmpHost(String host ) {
  - this.jrmphost=host;
  - }
  -
  - public String getJrmpHost() {
  - return jrmphost;
  - }
  +/** Enable the MX4J adapters (new way)
  + */
  +public void setEnabled(boolean b) {
  +enabled=b;
  +}
  +
  +public boolean getEnabled() {
  +return enabled;
  +}
  +
  +/** Enable the MX4J adapters (old way, compatible)
  + */
  +public void setPort(int i) {
  +enabled=(i != -1);
  +}
  +
  +public int getPort() {
  +return ((httpport != -1) ? httpport : jrmpport);
  +}
  +
  +/** Enable the MX4J HTTP internal adapter
  + */ 
  +public void setHttpPort( int i ) {
  +httpport=i;
  +}
  +
  +public int getHttpPort() {
  +return httpport;
  +}
  +
  +public void setHttpHost(String host ) {
  +this.httphost=host;
  +}
  +
  +public String getHttpHost() {
  +return httphost;
  +}
  +
  +/** Enable the MX4J JRMP internal adapter
  + */
  +public void setJrmpPort( int i ) {
  +jrmpport=i;
  +}
  +
  +public int getJrmpPort() {
  +return jrmpport;
  +}
  +
  +public void setJrmpHost(String host ) {
  +this.jrmphost=host;
  +}
  +
  +public String getJrmpHost() {
  +return jrmphost;
  +}
   
   /*  Start/stop  */
  - ObjectName httpServerName=null;
  - ObjectName jrmpServerName=null;
  +ObjectName httpServerName=null;
  +ObjectName jrmpServerName=null;
   
   /** Initialize the worker. After this call the worker will be
*  ready to accept new requests.
*/
   public void loadAdapter() throws IOException {
  - boolean httpAdapterLoaded = false;
  - boolean jrmpAdapterLoaded = false;
  -
  +boolean httpAdapterLoaded = false;
  +boolean jrmpAdapterLoaded = false;
  +
   if ((httpport != -1)  classExists(mx4j.adaptor.http.HttpAdaptor)) {
   try {
  - httpServerName = new 
ObjectName(Http:name=HttpAdaptor);
  -mserver.createMBean(mx4j.adaptor.http.HttpAdaptor, 
httpServerName, null);
  +httpServerName = registerObject(mx4j.adaptor.http.HttpAdaptor,
  + 

[GUMP@lsd]: jakarta-tomcat-5/jakarta-tomcat-5 failed

2004-03-08 Thread bobh
To whom it may engage...

This is an automated request, but not an unsolicited one. For help 
understanding the request please visit 
http://gump.apache.org/nagged.html, 
and/or contact [EMAIL PROTECTED]

Project jakarta-tomcat-5 has an issue affecting it's community integration, and has 
been outstanding for 6 runs. The current state is 'Failed', for reason 'Build Failed'

Full details are available at: 
http://lsd.student.utwente.nl/gump/jakarta-tomcat-5/jakarta-tomcat-5.html, however 
some snippets follow:

-  -  -  -  - -- --  G U M P

Gump provided these annotations:

 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/servlets-default.jar] 
identifier set to jar basename: [servlets-default.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/common/lib/naming-common.jar] 
identifier set to jar basename: [naming-common.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/common/lib/naming-resources.jar] 
identifier set to jar basename: [naming-resources.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/catalina.jar] 
identifier set to jar basename: [catalina.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/bin/bootstrap.jar] identifier set 
to jar basename: [bootstrap.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/servlets-common.jar] 
identifier set to jar basename: [servlets-common.jar]
 - Warning - Jar [/data3/gump/jakarta-tomcat-5/dist/server/lib/servlets-invoker.jar] 
identifier set to jar basename: [servlets-invoker.jar]
 - Info - Dependency on javamail exists, no need to add for property mail.jar.
 - Info - Dependency on jaf exists, no need to add for property activation.jar.
 - Info - Dependency on jakarta-servletapi-5-servlet exists, no need to add for 
property servlet-api.jar.
 - Info - Dependency on jakarta-servletapi-5-jsp exists, no need to add for property 
jsp-api.jar.
 - Info - Dependency on xml-xerces exists, no need to add for property xercesImpl.jar.
 - Info - Dependency on xml-xerces exists, no need to add for property 
xmlParserAPIs.jar.
 - Info - Dependency on jakarta-tomcat-util exists, no need to add for property 
tomcat-util.jar.
 - Info - Dependency on commons-el exists, no need to add for property commons-el.jar.
 - Info - Dependency on commons-logging exists, no need to add for property 
commons-logging-api.jar.
 - Info - Dependency on commons-modeler exists, no need to add for property 
commons-modeler.jar.
 - Info - Dependency on ant exists, no need to add for property ant.home.
 - Info - Dependency on jsse exists, no need to add for property jsse.home.
 - Info - Dependency on jmx exists, no need to add for property jmx.home.
 - Info - Dependency on jmx exists, no need to add for property jmx.jar.
 - Info - Dependency on jmx exists, no need to add for property jmx-tools.jar.
 - Info - Dependency on jndi exists, no need to add for property jndi.home.
 - Info - Dependency on jakarta-regexp exists, no need to add for property regexp.home.
 - Info - Dependency on jakarta-regexp exists, no need to add for property regexp.jar.
 - Info - Dependency on javamail exists, no need to add for property mail.home.
 - Info - Dependency on jakarta-tomcat-coyote exists, no need to add for property 
tomcat-coyote.home.
 - Info - Dependency on jakarta-tomcat-jasper_tc5 exists, no need to add for property 
jasper.home.
 - Info - Dependency on jaf exists, no need to add for property activation.home.
 - Info - Dependency on commons-modeler exists, no need to add for property 
commons-modeler.home.
 - Info - Dependency on commons-daemon exists, no need to add for property 
commons-daemon.jsvc.tar.gz.
 - Info - Dependency on jakarta-struts exists, no need to add for property struts.home.
 - Error - Failed with reason build failed


-  -  -  -  - -- --  G U M P
Gump performed this work:

Work Name: build_jakarta-tomcat-5_jakarta-tomcat-5 (Type: Build)
State: Failed
Elapsed: 0 hours, 1 minutes, 7 seconds
Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true 
-Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xmlParserAPIs.jar:/data3/gump/xml-xalan/java/build/xalan-unbundled.jar:/data3/gump/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -verbose 
-Dgump.merge=/data3/gump/gump-install/work/merge.xml -Dbuild.sysclasspath=only 
-Dtomcat33.home=*Unset* 
-Djsp-api.jar=/data3/gump/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar 
-Dtomcat-coyote.home=/data3/gump/jakarta-tomcat-connectors/coyote 
-Djndi.jar=/data3/gump/opt/jndi1_2_1/lib/jndi.jar 
-Dsite2.home=/data3/gump/jakarta-site2 
-DxmlParserAPIs.jar=/data3/gump/xml-xerces2/java/build/xercesImpl.jar 
-Dactivation.home=/data3/gump/opt/jaf-1.0.1 -Djmx.home=/data3/gump/opt/jmx-1_2-ri 
-Djdbc20ext.jar=/data3/gump/opt/jdbc2_0/jdbc2_0-stdext.jar 
-Djmx-tools.jar=/data3/gump/opt/jmx-1_2-ri/lib/jmxtools.jar