Deprecation and JK2

2005-01-11 Thread Remy Maucherat
(Note: I'm talking about the Java code here)
That code is IMO a bit messy. It's fast (it does its job and seems to 
beat HTTP for proxying) and works, but I think a cleanup won't hurt.

Some of the issues:
- Deprecation (ex: JkMain is deprecated, supposedly to be replaced, but 
I don't see anything coming, so I think JkMain should be undeprecated)
- Formatting (I don't quite like this, as it would screw up diffs; 
running some code formetter on that, like Eclipse, wouldn't hurt, though)
- Many strings refer to jk2: I plan to replace these with jk

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Deprecation and JK2

2005-01-11 Thread Henri Gomez
+0

JK / JK2 are also very specific to our current AJP implemtation. 

Maybe they should be called AJP instead ?

PS: Happy New Year to all TC-DEV members :)

On Tue, 11 Jan 2005 10:44:17 +0100, Remy Maucherat [EMAIL PROTECTED] wrote:
 (Note: I'm talking about the Java code here)
 
 That code is IMO a bit messy. It's fast (it does its job and seems to
 beat HTTP for proxying) and works, but I think a cleanup won't hurt.
 
 Some of the issues:
 - Deprecation (ex: JkMain is deprecated, supposedly to be replaced, but
 I don't see anything coming, so I think JkMain should be undeprecated)
 - Formatting (I don't quite like this, as it would screw up diffs;
 running some code formetter on that, like Eclipse, wouldn't hurt, though)
 - Many strings refer to jk2: I plan to replace these with jk
 
 Rémy
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Deprecation and JK2

2005-01-11 Thread Remy Maucherat
Henri Gomez wrote:
+0
JK / JK2 are also very specific to our current AJP implemtation. 

Maybe they should be called AJP instead ?
I thouhgt I had done enough damage with my package renaming and class 
moving ;)
The renaming here is nearly all located in strings which are supposed to 
be displayed to the user when there's an error, and also in comments - 
low impact stuff.

PS: Happy New Year to all TC-DEV members :)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


session unique

2005-01-11 Thread Kieu Huu Dung
Hi all,

I posted a message few day ago about the session in
different webapps, maybe it's not well formulated (no
answer).

I'll try to ask once more : how do I have only one
session (an unique ID) in different webapps?

Please help, thanks,

Huu Dung Kieu.


Yahoo! Messenger - Communicate instantly...Ping 
your friends today! Download Messenger Now 
http://uk.messenger.yahoo.com/download/index.html

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: session unique

2005-01-11 Thread nils . gustafsson
Hej,

Nils Gustafsson har gått i pension. För Jobb-relaterade ärenden kontakta 
Marlene Jegeborn: [EMAIL PROTECTED]

Dear Sir/Madam

Nils Gustafsson has retired. Please contact Marlene Jegeborn: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tomcat Admin

2005-01-11 Thread Slobodan Vujasinovic
I'm Running Tomcat With J2SE Version 1.4 (j2se1.4.2_03) and I've
integrated standalone admin package in existing Tomcat (version 5.5.4)
installation.

Everything seems to work just fine (managed to start and login into
application)! The only problem is that I can't access and administer
Hosts and their Contexts for Catalina Service through present 'Tree
Control Frame'. 

I'm used to this administration feature (previously using Tomcat
5.0.30).

Is this expected behavior for admin application or there is something
else (maybe some additional configuration) to be done?

Regards,
Slobodan



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Some benchmark results

2005-01-11 Thread Leon Gent
What OS on server and client? We found that certain
flavors of Linux did not perform nearly as well as XP,
for instance. In other words, OS has huge influence on
performance.


--- Peter Lin [EMAIL PROTECTED] wrote:

 I've started running a series of benchmarks for
 static files. Here are
 some early results. I plan to write up the results
 once it's all done.
 
 Server:
 AMD 2ghz
 RAM 1Gb
 jdk1.4.2
 tomcat 5.0.x
 
 Client:
 gateway laptop 450
 centrino 1.4ghz
 RAM 1Gb
 
 The basic setup
 Concurrent threads: 5, 10, 15, 20, 25, 30
 page size in KB: 1, 5, 10, 20, 40, 80, 160
 image size KB: 1, 5, 10, 20, 40, 80, 160
 
 
 The results I have so far using JMeter.
 
 peter 
 
 --
 
 1K

---
 protocol | samples | average | median | 90% line |
 min | max | error%
 | throughput | Kb/sec

---
 HTTP Request  50002.4158  0   10  0   231 0.00%   
 1296.7/sec
 1337.20
 HTTP Request  1   3.2866  0   10  0   490 0.00%
 1384.8/sec1428.13
 HTTP Request  15000   3.56353 0   10  0   36260.00%
 1335.0/sec1376.71
 HTTP Request  2   6.3406  0   20  0   120 0.00%
 1352.1/sec1394.33
 HTTP Request  25000   8.27288 0   20  0   281 0.00%
 1309.1/sec1350.02
 HTTP Request  3   4.6102  0   20  0   972 0.00%
 1259.2/sec1298.53
 
 5k
 
 HTTP Request  50002.9246  0   10  0   330 0.00%   
 1044.5/sec
 5314.28
 HTTP Request  1   4.4717  0   10  0   11620.00%
 1002.6/sec5101.15
 HTTP Request  15000   6.7102  0   20  0   23730.00%
 968.9/sec 4929.49
 HTTP Request  2   4.83515 0   10  0   15030.00%
 950.1/sec 4834.10
 HTTP Request  25000   10.3578 0   30  0   19220.00%
 933.6/sec 4749.89
 HTTP Request  3   5.86573 0   20  0   441 0.00%
 939.4/sec 4779.46
 
 10k
 
 HTTP Request  50004.1644  0   10  0   742 0.00%   
 726.7/sec
 7308.61
 HTTP Request  1   8.8132  10  20  0   181 0.00%
 763.5/sec 7678.00
 HTTP Request  15000   7.7906  0   20  0   381 0.00%   
 718.0/sec
 7221.14
 HTTP Request  2   10.8593 10  30  0   420 0.00%
 705.2/sec 7091.88
 HTTP Request  25000   32.2276 30  50  0   110 0.00%
 704.0/sec 7079.95
 HTTP Request  3   19.3326 10  50  0   16530.00%
 686.8/sec 6906.56
 
 20k
 
 HTTP Request  50007.4202  0   10  0   400 0.00%   
 491.9/sec
 9936.63
 HTTP Request  1   14.1984 10  20  0   982 0.00%
 490.9/sec 9917.12
 HTTP Request  15000   17.698  10  40  0   531 0.00%
 472.4/sec 9542.36
 HTTP Request  2   22.9608 20  50  0   471 0.00%
 465.1/sec 9395.46
 HTTP Request  25000   32.8229 40  61  0   14320.00%
 461.3/sec 9318.23
 HTTP Request  3   50.4059 50  90  0   701 0.00%
 429.6/sec 8678.60
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 





__ 
Do you Yahoo!? 
Yahoo! Mail - You care about security. So do we. 
http://promotions.yahoo.com/new_mail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common WorkerDummy.java ChannelSocket.java JniHandler.java HandlerRequest.java ModJkMX.java ChannelUn.java

2005-01-11 Thread remm
remm2005/01/11 05:37:46

  Modified:jk/java/org/apache/jk/server JkMain.java
JkCoyoteHandler.java
   jk/java/org/apache/jk/core JkHandler.java JkChannel.java
   jk/java/org/apache/jk/common WorkerDummy.java
ChannelSocket.java JniHandler.java
HandlerRequest.java ModJkMX.java ChannelUn.java
  Log:
  - Remove most deprecation problems.
  
  Revision  ChangesPath
  1.48  +5 -5  
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkMain.java
  
  Index: JkMain.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkMain.java,v
  retrieving revision 1.47
  retrieving revision 1.48
  diff -u -r1.47 -r1.48
  --- JkMain.java   10 Oct 2004 23:43:20 -  1.47
  +++ JkMain.java   11 Jan 2005 13:37:45 -  1.48
  @@ -68,7 +68,6 @@
*  to see configs based on registry, LDAP, db, etc. ( XML is not necesarily 
better )
* 
* @author Costin Manolache
  - * @deprecated Will be replaced with JMX operations
*/
   public class JkMain implements MBeanRegistration
   {
  @@ -362,7 +361,7 @@
   */
   public void setBeanProperty( Object target, String name, String val ) {
   if( val!=null )
  -val=IntrospectionUtils.replaceProperties( val, props );
  +val=IntrospectionUtils.replaceProperties( val, props, null );
   if( log.isDebugEnabled())
   log.debug( setProperty  + target +   + name + = + val );
   
  @@ -468,7 +467,7 @@
   File outFile= new File(propsF.getParentFile(), 
propsF.getName()+.save);
   log.debug(Saving properties  + outFile );
   try {
  -props.save( new FileOutputStream(outFile), AUTOMATICALLY 
GENERATED );
  +props.store( new FileOutputStream(outFile), AUTOMATICALLY 
GENERATED );
   } catch(IOException ex ){
   log.warn(Unable to save to +outFile,ex);
   }
  @@ -583,8 +582,9 @@
   }
   if( this.domain != null ) {
   try {
  -Registry.getRegistry().registerComponent(handler, 
this.domain, classN,
  -type=JkHandler,name= + fullName);
  +ObjectName handlerOname = new ObjectName
  +(this.domain + : + type=JkHandler,name= + fullName);
  +Registry.getRegistry(null, null).registerComponent(handler, 
handlerOname, classN);
   } catch (Exception e) {
   log.error( Error registering  + fullName, e );
   }
  
  
  
  1.58  +5 -4  
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java
  
  Index: JkCoyoteHandler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java,v
  retrieving revision 1.57
  retrieving revision 1.58
  diff -u -r1.57 -r1.58
  --- JkCoyoteHandler.java  11 Nov 2004 14:55:28 -  1.57
  +++ JkCoyoteHandler.java  11 Jan 2005 13:37:45 -  1.58
  @@ -46,7 +46,6 @@
   import org.apache.jk.core.Msg;
   import org.apache.jk.core.MsgContext;
   import org.apache.jk.core.WorkerEnv;
  -import org.apache.jk.core.JkChannel;
   import org.apache.tomcat.util.buf.ByteChunk;
   import org.apache.tomcat.util.buf.C2BConverter;
   import org.apache.tomcat.util.buf.MessageBytes;
  @@ -189,8 +188,10 @@
   try {
   if( oname != null  getJkMain().getDomain() == null) {
   try {
  -Registry.getRegistry().registerComponent(getJkMain(), 
oname.getDomain(),
  -JkMain, type=JkMain);
  +ObjectName jkmainOname = 
  +new ObjectName(oname.getDomain() + :type=JkMain);
  +Registry.getRegistry(null, null)
  +.registerComponent(getJkMain(), jkmainOname, 
JkMain);
   } catch (Exception e) {
   log.error( Error registering jkmain  + e );
   }
  @@ -356,7 +357,7 @@
   
   MessageBytes mb=(MessageBytes)ep.getNote( tmpMessageBytesNote );
   if( mb==null ) {
  -mb=new MessageBytes();
  +mb=MessageBytes.newInstance();
   ep.setNote( tmpMessageBytesNote, mb );
   }
   String message=res.getMessage();
  
  
  
  1.17  +1 -1  
jakarta-tomcat-connectors/jk/java/org/apache/jk/core/JkHandler.java
  
  Index: JkHandler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/core/JkHandler.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- JkHandler.java24 Feb 2004 08:48:43 -  1.16
  +++ 

DO NOT REPLY [Bug 33042] New: - JSP compilation with / fails

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33042.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33042

   Summary: JSP compilation with /  fails
   Product: Tomcat 5
   Version: 5.0.28
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P3
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


Compiling a JSP ending with 2 characters sequence / (2 characters from
closing tag) fails, although it is a valid JSP. It also fails whenever this
sequence is followed by a space whereever in the JSP.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33043] New: - Failed to install Tomcat5 service

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33043.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33043

   Summary: Failed to install Tomcat5 service
   Product: Tomcat 5
   Version: 5.5.4
  Platform: PC
OS/Version: Windows 98
Status: NEW
  Severity: blocker
  Priority: P1
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


After selecting Minimum installation, Service component NOT selected (becuase 
it's a Win98 system) I got the following error:

Failed to install Tomcat5 service
Check your settings and permissions
[Abort] [Retry] [Ignore]

The permissions can't be a problem because it's a Win98 system.

In the Tomcat strart group there is apparently no icon to start/stop Tomcat, no 
icon in the tray.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33042] - JSP compilation with / fails

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33042.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33042





--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 14:49 ---
Created an attachment (id=13970)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=13970action=view)
Thrown exception

Exceptions of simple 2 characters JSP (of text /) compilation.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33043] - Failed to install Tomcat5 service

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33043.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33043


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|blocker |normal
   Priority|P1  |P2




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 14:59 ---
I don't know if Win9x is still supported at all in the .exe wrapper (and,
therefore, the Windows installer). Apparently not, try using the shell scripts
instead.

I don't know if developers have Win9x development machines anymore, so you may
be on your own. I am not aware of anyone testing recent Tomcat versions on Win9x
either.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33042] - JSP compilation with / fails

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33042.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33042


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 15:00 ---


*** This bug has been marked as a duplicate of 29866 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java StandardHost.java

2005-01-11 Thread remm
remm2005/01/11 06:01:45

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java StandardHost.java
  Log:
  - Fix bad imports.
  
  Revision  ChangesPath
  1.42  +1 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
  
  Index: ApplicationDispatcher.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- ApplicationDispatcher.java22 Nov 2004 16:35:18 -  1.41
  +++ ApplicationDispatcher.java11 Jan 2005 14:01:45 -  1.42
  @@ -50,7 +50,6 @@
   import org.apache.commons.logging.LogFactory;
   import org.apache.tomcat.util.IntrospectionUtils;
   
  -import org.apache.catalina.security.SecurityUtil;
   /**
* Standard implementation of codeRequestDispatcher/code that allows a
* request to be forwarded to a different resource to create the ultimate
  
  
  
  1.38  +1 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHost.java
  
  Index: StandardHost.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHost.java,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- StandardHost.java 27 Dec 2004 09:43:14 -  1.37
  +++ StandardHost.java 11 Jan 2005 14:01:45 -  1.38
  @@ -25,7 +25,6 @@
   import org.apache.catalina.Context;
   import org.apache.catalina.Host;
   import org.apache.catalina.LifecycleException;
  -import org.apache.catalina.Realm;
   import org.apache.catalina.Valve;
   import org.apache.catalina.startup.HostConfig;
   import org.apache.catalina.valves.ValveBase;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-11 Thread remm
remm2005/01/11 06:53:26

  Modified:webapps/docs changelog.xml
  Log:
  - Changelog update.
  
  Revision  ChangesPath
  1.215 +23 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.214
  retrieving revision 1.215
  diff -u -r1.214 -r1.215
  --- changelog.xml 8 Jan 2005 11:15:00 -   1.214
  +++ changelog.xml 11 Jan 2005 14:53:26 -  1.215
  @@ -35,6 +35,10 @@
  add
New store config module for better server.xml saving support (pero)
  /add
  +   update
  + bug32081/bug: Remove the JDK requirement from the Unix scripts, 
submitted
  + by Ben Souther (remm)
  +   /update
   /changelog
 /subsection
   
  @@ -65,6 +69,15 @@
   bug31198/bug: Fix FORM and DIGEST authentication for non-ASCII
   usernames and passwords. (markt)
 /fix
  +  fix
  +Reimplement charset mapper (remm)
  +  /fix
  +  fix
  +Add logging of exception which could occur when retrieving the 
password in JDBCRealm (remm)
  +  /fix
  +  fix
  +bug25889/bug: Don't execute queries twice, submitted by Tom 
Anderson (remm)
  +  /fix
   /changelog
 /subsection
   
  @@ -72,6 +85,16 @@
   changelog
 fix
   bug32708/bug: Better handling of bad encoding with the string 
cache. (remm)
  +  /fix
  +  fix
  +bug32781/bug: Fix bad initialization of the scheme field of 
the request
  +object, which would cause getScheme to return http for the first 
request. (remm)
  +  /fix
  +  fix
  +Content length should be ignored if there is chunking (remm)
  +  /fix
  +  fix
  +Remove most deprecation problems for the AJP connector (remm)
 /fix
   /changelog
 /subsection
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Log rotation

2005-01-11 Thread Ash, Michael L
Because it has never been answered yet, at least not in a way I can
understand. 

Or do you mean something else like your getting it repeated.

-Original Message-
From: Sweet Brandalynn [mailto:[EMAIL PROTECTED] 
Sent: Monday, January 10, 2005 11:58 PM
To: tomcat-dev@jakarta.apache.org
Subject: Re: Log rotation

Why Do I Keep Getting This E Mail?
--- [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
 I have read several threads about rotating logs in
tomcat, however they
 don't seem to cover all of the logs nor do they work when
running as a
 windows service.  
 
 So my question:  Is / has anyone considering actually
making the loggers
 in tomcat rotatable and limit number / size of them?  Or
am I just
 totally misreading the archives.  I do see where the
logger / valve
 combo for access is creating multiple logs yet you can't
limit them by
 size or number.
 
 
  
 
 

-
 To unsubscribe, e-mail:
[EMAIL PROTECTED]
 For additional commands, e-mail:
[EMAIL PROTECTED]
 


=

:kisses: Brandalynn  

www.sweetbrandalynn.com 




 








__
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Log rotation

2005-01-11 Thread Sue Spence
Earlier, I wondered if Sweet Brandalynn was trolling for lonely geeks, 
or just inadvertently found herself* on this list via some sort of 
cack-handed porno spam harvester/autoresponder malfunction.

I have now decided to believe it is the latter, because the idea of a 
spammer whining about getting email they didn't want to receive is 
strangely satisfying.

*assuming that it's a woman
Ash, Michael L wrote:
Because it has never been answered yet, at least not in a way I can
understand. 

Or do you mean something else like your getting it repeated.
-Original Message-
From: Sweet Brandalynn [mailto:[EMAIL PROTECTED] 
Sent: Monday, January 10, 2005 11:58 PM
To: tomcat-dev@jakarta.apache.org
Subject: Re: Log rotation

Why Do I Keep Getting This E Mail?
--- [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
I have read several threads about rotating logs in
tomcat, however they
don't seem to cover all of the logs nor do they work when
running as a
windows service.  

So my question:  Is / has anyone considering actually
making the loggers
in tomcat rotatable and limit number / size of them?  Or
am I just
totally misreading the archives.  I do see where the
logger / valve
combo for access is creating multiple logs yet you can't
limit them by
size or number.



-
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]

=
:kisses: Brandalynn  

www.sweetbrandalynn.com 


 




		
__
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: Log rotation

2005-01-11 Thread Ash, Michael L
Ya, next time I will actually read who sent the email before
responding... 

-Original Message-
From: Sue Spence [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 9:51 AM
To: Tomcat Developers List
Subject: Re: Log rotation

Earlier, I wondered if Sweet Brandalynn was trolling for lonely geeks,
or just inadvertently found herself* on this list via some sort of
cack-handed porno spam harvester/autoresponder malfunction.

I have now decided to believe it is the latter, because the idea of a
spammer whining about getting email they didn't want to receive is
strangely satisfying.

*assuming that it's a woman

Ash, Michael L wrote:
 Because it has never been answered yet, at least not in a way I can 
 understand.
 
 Or do you mean something else like your getting it repeated.
 
 -Original Message-
 From: Sweet Brandalynn [mailto:[EMAIL PROTECTED]
 Sent: Monday, January 10, 2005 11:58 PM
 To: tomcat-dev@jakarta.apache.org
 Subject: Re: Log rotation
 
 Why Do I Keep Getting This E Mail?
 --- [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
 
I have read several threads about rotating logs in
 
 tomcat, however they
 
don't seem to cover all of the logs nor do they work when
 
 running as a
 
windows service.  

So my question:  Is / has anyone considering actually
 
 making the loggers
 
in tomcat rotatable and limit number / size of them?  Or
 
 am I just
 
totally misreading the archives.  I do see where the
 
 logger / valve
 
combo for access is creating multiple logs yet you can't
 
 limit them by
 
size or number.


 



 
 -
 
To unsubscribe, e-mail:
 
 [EMAIL PROTECTED]
 
For additional commands, e-mail:
 
 [EMAIL PROTECTED]
 
 
 
 =
 
 :kisses: Brandalynn
 
 www.sweetbrandalynn.com
 
 
 
 
  
 
 
 
 
 
 
 
   
 __
 Do you Yahoo!? 
 Yahoo! Mail - now with 250MB free storage. Learn more.
 http://info.mail.yahoo.com/mail_250
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Log rotation

2005-01-11 Thread Cindy Brzozowski
REMOVE MY E-MAIL FROM YOUR LIST-

Ash, Michael L [EMAIL PROTECTED] wrote: Because it has never been answered 
yet, at least not in a way I can
understand. 

Or do you mean something else like your getting it repeated.

-Original Message-
From: Sweet Brandalynn [mailto:[EMAIL PROTECTED] 
Sent: Monday, January 10, 2005 11:58 PM
To: tomcat-dev@jakarta.apache.org
Subject: Re: Log rotation

Why Do I Keep Getting This E Mail?
--- [EMAIL PROTECTED] wrote:
 I have read several threads about rotating logs in
tomcat, however they
 don't seem to cover all of the logs nor do they work when
running as a
 windows service. 
 
 So my question: Is / has anyone considering actually
making the loggers
 in tomcat rotatable and limit number / size of them? Or
am I just
 totally misreading the archives. I do see where the
logger / valve
 combo for access is creating multiple logs yet you can't
limit them by
 size or number.
 
 
 
 
 

-
 To unsubscribe, e-mail:
[EMAIL PROTECTED]
 For additional commands, e-mail:
[EMAIL PROTECTED]
 


=

:kisses: Brandalynn 

www.sweetbrandalynn.com 













__
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





RE: Log rotation

2005-01-11 Thread Cindy Brzozowski


Cindy Brzozowski [EMAIL PROTECTED] wrote:REMOVE MY E-MAIL FROM YOUR LIST-

Ash, Michael L wrote: Because it has never been answered yet, at least not in 
a way I can
understand. 

Or do you mean something else like your getting it repeated.

-Original Message-
From: Sweet Brandalynn [mailto:[EMAIL PROTECTED] 
Sent: Monday, January 10, 2005 11:58 PM
To: tomcat-dev@jakarta.apache.org
Subject: Re: Log rotation

Why Do I Keep Getting This E Mail?
--- [EMAIL PROTECTED] wrote:
 I have read several threads about rotating logs in
tomcat, however they
 don't seem to cover all of the logs nor do they work when
running as a
 windows service. 
 
 So my question: Is / has anyone considering actually
making the loggers
 in tomcat rotatable and limit number / size of them? Or
am I just
 totally misreading the archives. I do see where the
logger / valve
 combo for access is creating multiple logs yet you can't
limit them by
 size or number.
 
 
 
 
 

-
 To unsubscribe, e-mail:
[EMAIL PROTECTED]
 For additional commands, e-mail:
[EMAIL PROTECTED]
 


=

:kisses: Brandalynn 

www.sweetbrandalynn.com 













__
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






Re: [INTRODUCE] apr-java

2005-01-11 Thread William A. Rowe, Jr.
Silly Question - doesn't this proposal fit better
in the commons project than Tomcat?

For that matter, I'm rolling the dice that the apr
project itself would entertain the possibilities of
supporting jni / xs / c++ wrappers.  

The reason I suggest this is that we have .pkg and .rpm
folks supporting standardized apr 0.9 / 1.x installs.
To keep these in sync would ultimately become quite
important.  The second reason is that we should truly
adopt consistent OO conventions for all of these varied
extension schemas.

Bill

At 08:25 AM 1/7/2005, Mladen Turk wrote:
Hi,

Here is the work in progress for a new project I named apr-java.

It offers a 'thin' layer using JNI over APR library.
The initial code that I wrote over a year now had
two way api, but I've decided to leave only
Java-APR.

I also have a working set of configure and make files
for unixes, but since this is an overview of the technology,
it's only a small subset of entire project, but you can get
the picture :) .

It will support around 90% of APR API (without things like
strings, etc. that are well done inside java itself).

The API itself on the Java side is done as close to the
APR function call (apr_file_write - File.write) with
almost the same function parameters as well.

You can see that the wrapping code is very thin in most
cases with only a couple of lines for each function,
mostly caused by pointer issues.

I'm sending the gz file (tried zip but failed) so you can see
what the general idea is. Of course the library can be extended
with functions that APR doesn't offer (for now or never will).
One of the things would be setting user and group for a process,
sending data from parent to child process, etc.

The question is:
Is it acceptable (think that previous discussions say it is)
Where to put that in the cvs.


Comments?

Regards,
Mladen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED] 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] JK 1.2.8 Released

2005-01-11 Thread William A. Rowe, Jr.
This isn't targetted at Mladen, but just want the participants
to understand the ramifications.  When the Project votes to
release software, it becomes the problem of the Foundation to
stand behind it.  If you release without following this procedure,
you own all of the liability, which is a very dangerous position.

That said, glad that this got it's +1's (and another +1 here
from the peanut gallery.)  Congratulations especially to Bill,
Jean-Jacques and Mladen for all their efforts!

Bill

At 06:38 AM 12/24/2004, Mladen Turk wrote:
The Apache Jakarta Tomcat team is proud to announce the immediate availability 
of Jakarta Tomcat Connectors 1.2.8.
This new release has passed the very rigorous release process with four beta 
versions released.

Please see the http://jakarta.apache.org/tomcat/connectors-doc/changelog.html
for a full list of changes.

JK 1.2.8 is considered as stable for the following web servers and platforms:
Apache 1.3.33 an up - any Unix or Linux, WIN32.
Apache 2.0.52 an up - any Unix or Linux, WIN32 and Netware.
IIS 5.0 an up - WIN32.
Other web servers like Lotus Domino or Netscape/iPlanet have not been
the focus of this release and it's further development will depend on users 
interest.

You can download sources from:
http://www.apache.org/dist/jakarta/tomcat-connectors/jk/jk-1.2.8/source

The binaries (for WIN32 only at the moment) are available at:
http://www.apache.org/dist/jakarta/tomcat-connectors/jk/binaries/win32/

The Jakarta Tomcat Connectors Team

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [INTRODUCE] apr-java

2005-01-11 Thread Mladen Turk
William A. Rowe, Jr. wrote:
 Silly Question - doesn't this proposal fit better
 in the commons project than Tomcat?

Perhaps, but the guys that are interested in
both c and Java live inside J-T-C :).
And since it will be buildable independent
of any connector code, it could be moved to
commons or even apr.
 The reason I suggest this is that we have .pkg and .rpm
 folks supporting standardized apr 0.9 / 1.x installs.
Well that's OK, but the apr-java consists of two parts:
native library and .jar file, requires Java SDK installed, etc.
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: session unique

2005-01-11 Thread Mark Thomas
You have posted to the wrong list. The tomcat-dev list is for people 
developing Tomcat. The tomcat-user list should be used for questions 
about developing with (ie using) tomcat.

Mark
Kieu Huu Dung wrote:
Hi all,
I posted a message few day ago about the session in
different webapps, maybe it's not well formulated (no
answer).
I'll try to ask once more : how do I have only one
session (an unique ID) in different webapps?
Please help, thanks,
Huu Dung Kieu.

Yahoo! Messenger - Communicate instantly...Ping 
your friends today! Download Messenger Now 
http://uk.messenger.yahoo.com/download/index.html

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Tomcat Admin

2005-01-11 Thread Mark Thomas
You have posted to the wrong list. The tomcat-dev list is for people 
developing Tomcat. The tomcat-user list should be used for questions 
about developing with (ie using) tomcat.

Mark
Slobodan Vujasinovic wrote:
I'm Running Tomcat With J2SE Version 1.4 (j2se1.4.2_03) and I've
integrated standalone admin package in existing Tomcat (version 5.5.4)
installation.
Everything seems to work just fine (managed to start and login into
application)! The only problem is that I can't access and administer
Hosts and their Contexts for Catalina Service through present 'Tree
Control Frame'. 

I'm used to this administration feature (previously using Tomcat
5.0.30).
Is this expected behavior for admin application or there is something
else (maybe some additional configuration) to be done?
Regards,
Slobodan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/webapps/admin/images Context.gif Host.gif

2005-01-11 Thread jfarcand
jfarcand2005/01/11 11:41:57

  Modified:webapps/admin/images Context.gif Host.gif
  Log:
  As pointed by Remy, remove Sun Copyright on those two files.
  
  Revision  ChangesPath
  1.2   +2 -5  jakarta-tomcat-catalina/webapps/admin/images/Context.gif
  
Binary file
  
  
  1.2   +1 -4  jakarta-tomcat-catalina/webapps/admin/images/Host.gif
  
Binary file
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/admin/images Context.gif Host.gif

2005-01-11 Thread jfarcand
jfarcand2005/01/11 11:44:38

  Modified:webapps/admin/images Tag: TOMCAT_5_0 Context.gif Host.gif
  Log:
  As pointed by Remy, remove Sun Copyright on those two files.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.1.1.1.2.1 +2 -5  
jakarta-tomcat-catalina/webapps/admin/images/Context.gif
  
Binary file
  
  
  1.1.1.1.2.1 +1 -4  jakarta-tomcat-catalina/webapps/admin/images/Host.gif
  
Binary file
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/webapps/admin/images Context.gif Host.gif

2005-01-11 Thread jfarcand
jfarcand2005/01/11 11:46:02

  Modified:webapps/admin/images Context.gif Host.gif
  Log:
  As pointed by Remy, remove Sun Copyright on those two files.
  
  Revision  ChangesPath
  1.2   +2 -5  jakarta-tomcat-4.0/webapps/admin/images/Context.gif
  
Binary file
  
  
  1.2   +1 -4  jakarta-tomcat-4.0/webapps/admin/images/Host.gif
  
Binary file
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/webapps/admin/images Context.gif Host.gif

2005-01-11 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
jfarcand2005/01/11 11:41:57
  Modified:webapps/admin/images Context.gif Host.gif
  Log:
  As pointed by Remy, remove Sun Copyright on those two files.
Thanks a lot :)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: session unique

2005-01-11 Thread Kieu Huu Dung
sorry, bye bye.

khdung.

 --- Mark Thomas [EMAIL PROTECTED] wrote: 
 You have posted to the wrong list. The tomcat-dev
 list is for people 
 developing Tomcat. The tomcat-user list should be
 used for questions 
 about developing with (ie using) tomcat.
 
 Mark


Yahoo! Messenger - Communicate instantly...Ping 
your friends today! Download Messenger Now 
http://uk.messenger.yahoo.com/download/index.html

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28871] - StandardHostDeployer throws a NPE when removing a context

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28871.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28871


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 20:50 ---
The install method does not suffer from the same issue.

*** This bug has been marked as a duplicate of 32779 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32779] - NullPointerException when removing webapp with manager

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32779.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32779


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 20:50 ---
*** Bug 28871 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Current State

2005-01-11 Thread Carbone, Adam
Is the current head of the Tomcat 5. building and running? There was a lot
of changes I have been seeing for 5.5.6 that I want but I figured they were
in the Alpha release so I wanted to get the latest when was a good semi
stable nightly build? 

 

Adam Carbone

 



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-11 Thread pero
pero2005/01/11 12:02:14

  Modified:catalina/src/share/org/apache/catalina/core
StandardServer.java
   modules/storeconfig/src/share/org/apache/catalina/storeconfig
StoreConfigLifecycleListener.java
server-registry.xml
   
modules/storeconfig/test/src/share/org/apache/catalina/storeconfig
ManagerSFTest.java
   webapps/docs changelog.xml
  Log:
  Integrate StoreConfig at StandardServer and fix small StoreConfig bugs
  
  Revision  ChangesPath
  1.40  +32 -4 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardServer.java
  
  Index: StandardServer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardServer.java,v
  retrieving revision 1.39
  retrieving revision 1.40
  diff -u -r1.39 -r1.40
  --- StandardServer.java   25 Oct 2004 15:28:23 -  1.39
  +++ StandardServer.java   11 Jan 2005 20:02:13 -  1.40
  @@ -41,6 +41,7 @@
   import javax.management.MBeanServer;
   import javax.management.ObjectName;
   import javax.naming.directory.DirContext;
  +import javax.servlet.http.HttpServletResponse;
   
   import org.apache.catalina.Container;
   import org.apache.catalina.Context;
  @@ -87,6 +88,8 @@
*
* @author Craig R. McClanahan
* @version $Revision$ $Date$
  + * TODO remove useless code
  + * TODO test the new save context backuo saving mode!!
*/
   
   public final class StandardServer
  @@ -675,6 +678,17 @@
*/
   public synchronized void storeConfig() throws Exception {
   
  +ObjectName sname = null;
  +try {
  +   sname = new ObjectName(Catalina:type=StoreConfig);
  +   if(mserver.isRegistered(sname)) {
  +   mserver.invoke(sname, storeConfig, null, null);
  +   } else
  +   log.error(StoreConfig mbean not registered + sname);
  +} catch (Throwable t) {
  +log.error(t);
  +}
  +/*
   // Calculate file objects for the old and new configuration files.
   String configFile = conf/server.xml; // FIXME - configurable?
   File configOld = new File(configFile);
  @@ -761,7 +775,7 @@
 configOld.getAbsolutePath() +  to  +
 configSave.getAbsolutePath());
   }
  -
  +*/
   }
   
   
  @@ -777,7 +791,21 @@
*  by the persistence mechanism
*/
   public synchronized void storeContext(Context context) throws Exception {
  -
  +
  +ObjectName sname = null;
  +try {
  +   sname = new ObjectName(Catalina:type=StoreConfig);
  +   if(mserver.isRegistered(sname)) {
  +   mserver.invoke(sname, store,
  +   new Object[] {context}, 
  +   new String [] { java.lang.String});
  +   } else
  +   log.error(StoreConfig mbean not registered + sname);
  +} catch (Throwable t) {
  +log.error(t);
  +}
  + 
  + /*   
   String configFile = context.getConfigFile();
   
   if (configFile != null) {
  @@ -820,7 +848,7 @@
   throw (e);
   }
   }
  -
  +*/
   }
   
   
  
  
  
  1.2   +1 -1  
jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
  
  Index: StoreConfigLifecycleListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- StoreConfigLifecycleListener.java 8 Jan 2005 11:14:07 -   1.1
  +++ StoreConfigLifecycleListener.java 11 Jan 2005 20:02:13 -  1.2
  @@ -84,7 +84,7 @@
   MBeanServer mserver = MBeanUtils.createServer();
   InputStream descriptor = null;
   try {
  -ObjectName objectName = new 
ObjectName(Catalina:type=StoreConfig,resource=\ 
+loader.getRegistryResource()+ \);
  +ObjectName objectName = new 
ObjectName(Catalina:type=StoreConfig );
   if (!mserver.isRegistered(objectName)) {
   descriptor = this.getClass().getResourceAsStream(
   mbeans-descriptors.xml);
  
  
  
  1.2   +4 -4  
jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/server-registry.xml
  
  Index: server-registry.xml
  ===
  RCS file: 

Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-11 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
pero2005/01/11 12:02:14
  Modified:catalina/src/share/org/apache/catalina/core
StandardServer.java
   modules/storeconfig/src/share/org/apache/catalina/storeconfig
StoreConfigLifecycleListener.java
server-registry.xml
   
modules/storeconfig/test/src/share/org/apache/catalina/storeconfig
ManagerSFTest.java
   webapps/docs changelog.xml
  Log:
  Integrate StoreConfig at StandardServer and fix small StoreConfig bugs
I was thinking all that stuff would be completely removed from 
StandardServer, and the admin would call the right JMX operation directly.

I've yet to try it, though ;)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2005-01-11 Thread luehe
luehe   2005/01/11 12:39:52

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationHttpRequest.java
  Log:
  Fix for 32832 (request.getSession(false) fails to return null).
  
  I believe this bug has been valid: If the session in the foreign
  context has been invalidated, it must not be returned. A comment in
  the code actually stated that the current session be returned if it
  exists and is valid, but the isValid() check on the session was
  missing, and is being added by this commit.
  Also, a session is now created in the foreign context only if 'create' is 
TRUE.
  
  Revision  ChangesPath
  1.23  +9 -6  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
  
  Index: ApplicationHttpRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- ApplicationHttpRequest.java   8 Dec 2004 01:25:52 -   1.22
  +++ ApplicationHttpRequest.java   11 Jan 2005 20:39:52 -  1.23
  @@ -482,8 +482,9 @@
   return (null);
   
   // Return the current session if it exists and is valid
  -if (session != null)
  +if (session != null  session.isValid()) {
   return (session.getSession());
  + }
   
   HttpSession other = super.getSession(false);
   if (create  (other == null)) {
  @@ -500,7 +501,7 @@
   } catch (IOException e) {
   // Ignore
   }
  -if (localSession == null) {
  +if (localSession == null  create) {
   localSession = context.getManager().createEmptySession();
   localSession.setNew(true);
   localSession.setValid(true);
  @@ -509,9 +510,11 @@
   (context.getManager().getMaxInactiveInterval());
   localSession.setId(other.getId());
   }
  -localSession.access();
  -session = localSession;
  -return session.getSession();
  +if (localSession != null) {
  +localSession.access();
  +session = localSession;
  +return session.getSession();
  +}
   }
   return null;
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs manager-howto.xml

2005-01-11 Thread markt
markt   2005/01/11 13:08:11

  Modified:webapps/tomcat-docs manager-howto.xml
  Log:
  Fix bug 28867. Correct manager how to to show correct way
to reference ROOT context.
- Submitted by Stephane Bailliez
  
  Revision  ChangesPath
  1.21  +15 -22jakarta-tomcat-4.0/webapps/tomcat-docs/manager-howto.xml
  
  Index: manager-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/tomcat-docs/manager-howto.xml,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- manager-howto.xml 13 Jan 2003 23:25:45 -  1.20
  +++ manager-howto.xml 11 Jan 2005 21:08:10 -  1.21
  @@ -222,7 +222,7 @@
   ul
   listrongpath/strong - The context path (including the leading slash)
   of the web application you are dealing with.  To select the ROOT web
  -application, specify a zero-length string.  strongNOTE/strong -
  +application, specify /.  strongNOTE/strong -
   It is not possible to perform administrative commands on the
   Manager application itself./li
   listrongwar/strong - URL of a web application archive (WAR) file,
  @@ -312,9 +312,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context path was specified/em
   blockquote
  @@ -488,9 +487,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a / string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemContext path must match the directory or WAR file name:/em
   blockquote
  @@ -563,9 +561,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  @@ -622,9 +619,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  @@ -811,9 +807,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  @@ -854,9 +849,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  @@ -906,9 +900,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml manager-howto.xml

2005-01-11 Thread markt
markt   2005/01/11 13:09:35

  Modified:webapps/docs changelog.xml manager-howto.xml
  Log:
  Fix bug 28867. Correct manager how to to show correct way
to reference ROOT context.
- Submitted by Stephane Bailliez
- Ported from TC4
  
  Also replaced a few tabs with spaces.
  
  Revision  ChangesPath
  1.217 +11 -7 jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.216
  retrieving revision 1.217
  diff -u -r1.216 -r1.217
  --- changelog.xml 11 Jan 2005 20:02:14 -  1.216
  +++ changelog.xml 11 Jan 2005 21:09:35 -  1.217
  @@ -32,13 +32,13 @@
 add
   Add installer for mod_jk on IIS. (mturk)
 /add
  -   add
  - New store config module for better server.xml saving support (pero)
  -   /add
  -   update
  - bug32081/bug: Remove the JDK requirement from the Unix scripts, 
submitted
  - by Ben Souther (remm)
  -   /update
  +  add
  +New store config module for better server.xml saving support (pero)
  +  /add
  +  update
  +bug32081/bug: Remove the JDK requirement from the Unix scripts, 
submitted
  +by Ben Souther (remm)
  +  /update
   /changelog
 /subsection
   
  @@ -141,6 +141,10 @@
 fix
   bug32771/bug: Cannot undeploy/deploy misconfigured app after 
tomcat startup, 
   submitted by Gabriele Garuglieri (remm)
  +  /fix
  +  fix
  +bug28867/bug: Correct manager documentation to document correct 
way to
  +reference the ROOT context. Submitted by Stephane Bailliez. (markt)
 /fix
   /changelog
 /subsection
  
  
  
  1.14  +13 -19jakarta-tomcat-catalina/webapps/docs/manager-howto.xml
  
  Index: manager-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/manager-howto.xml,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- manager-howto.xml 28 Jul 2004 14:49:50 -  1.13
  +++ manager-howto.xml 11 Jan 2005 21:09:35 -  1.14
  @@ -229,7 +229,7 @@
   ul
   listrongpath/strong - The context path (including the leading slash)
   of the web application you are dealing with.  To select the ROOT web
  -application, specify a zero-length string.  strongNOTE/strong -
  +application, specify /.  strongNOTE/strong -
   It is not possible to perform administrative commands on the
   Manager application itself./li
   listrongwar/strong - URL of a web application archive (WAR) file,
  @@ -333,9 +333,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context path was specified/em
   blockquote
  @@ -523,9 +522,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a / string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemContext path must match the directory or WAR file name:/em
   blockquote
  @@ -598,9 +596,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  @@ -796,9 +793,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web application -- in which case the context path
  -must be a zero-length string./p
  +pThe context path must start with a slash character. To reference the
  +ROOT web application use /./p
   /blockquote/li
   liemNo context exists for path /foo/em
   blockquote
  @@ -839,9 +835,8 @@
   /blockquote/li
   liemInvalid context path was specified/em
   blockquote
  -pThe context path must start with a slash character, unless you are
  -referencing the ROOT web 

DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28867


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11 ---
Fixed in CVS for 4.1.x and 5.5.x

Thansk for the report and the patch (I actually committed a variation).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Yoav Shapira
Hi,
I thought the docs were right, path= for the ROOT, not path=/.  And
therefore I thought this was an invalid bug report.  Was I wrong?

Yoav

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:11 PM
To: tomcat-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28867


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11 ---
Fixed in CVS for 4.1.x and 5.5.x

Thansk for the report and the patch (I actually committed a variation).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32832] - request.getSession(false) fails to return null.

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32832.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32832


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32832] - request.getSession(false) fails to return null.

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32832.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32832


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:22 ---
I believe this bug has been valid: If the session in the foreign
context has been invalidated, it must not be returned. A comment in
the code actually stated that the current session be returned if it
exists and is valid, but the isValid() check on the session was
missing, and is being added by this commit.
Also, a session is now created in the foreign context only if 'create' is TRUE.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Mark Thomas
I did a quick test (on TC4 and TC5) before changing the docs.
http://localhost:8080/manager/reload?path=/
returns
OK - Reloaded application at context path /
http://localhost:8080/manager/reload?path=
returns
FAIL - Invalid context path  was specified
Mark
Yoav Shapira wrote:
Hi,
I thought the docs were right, path= for the ROOT, not path=/.  And
therefore I thought this was an invalid bug report.  Was I wrong?
Yoav
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:11 PM
To: tomcat-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867
[EMAIL PROTECTED] changed:
   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11 ---
Fixed in CVS for 4.1.x and 5.5.x
Thansk for the report and the patch (I actually committed a variation).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


communication from jsp to valve

2005-01-11 Thread Paul Moore

I have a valve that does various valve type things, mess with requests,
twiddle cookies, etc.
I need a JSP to be able to communicate with the valve (generate URLS
based on the result of some of the twiddling for example).
The class loaders are doing their best to stonewall me. I have tried
putting my TwiddlyValveInterface instance in
A) thread locals - get null out (different ThreadLocal class with
different static map?)
B) appContext attribute - class cast error (clear sign that I loaded
through different loaders)
What is the recommended way to do this?


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Yoav Shapira
Hi,
IT might be the manager that's wrong.  When editing server.xml or
context.xml files for those Tomcat versions, users should use path= and
not path=/.  The latter leads to significant failures.

Yoav

-Original Message-
From: Mark Thomas [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:30 PM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

I did a quick test (on TC4 and TC5) before changing the docs.

http://localhost:8080/manager/reload?path=/
returns
OK - Reloaded application at context path /

http://localhost:8080/manager/reload?path=
returns
FAIL - Invalid context path  was specified

Mark

Yoav Shapira wrote:
 Hi,
 I thought the docs were right, path= for the ROOT, not path=/.  And
 therefore I thought this was an invalid bug report.  Was I wrong?
 
 Yoav
 
 -Original Message-
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
 Sent: Tuesday, January 11, 2005 4:11 PM
 To: tomcat-dev@jakarta.apache.org
 Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
 string for root context path instead of /
 
 DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
 RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
 http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
 ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
 INSERTED IN THE BUG DATABASE.
 
 http://issues.apache.org/bugzilla/show_bug.cgi?id=28867
 
 
 [EMAIL PROTECTED] changed:
 
What|Removed |Added


  Status|NEW |RESOLVED
  Resolution||FIXED
 
 
 
 
 --- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11
---
 Fixed in CVS for 4.1.x and 5.5.x
 
 Thansk for the report and the patch (I actually committed a variation).
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Mark Thomas
The manager would be wrong if:
a) we had a consistent way of handling the ROOT context
b) the agreed consistent way to reference ROOT was 
I am not aware of a) and from a user perspective / seems to make more 
sense for b)

At least at present the docs agree with the actual behaviour.
Mark
Yoav Shapira wrote:
Hi,
IT might be the manager that's wrong.  When editing server.xml or
context.xml files for those Tomcat versions, users should use path= and
not path=/.  The latter leads to significant failures.
Yoav
-Original Message-
From: Mark Thomas [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:30 PM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

I did a quick test (on TC4 and TC5) before changing the docs.
http://localhost:8080/manager/reload?path=/
returns
OK - Reloaded application at context path /
http://localhost:8080/manager/reload?path=
returns
FAIL - Invalid context path  was specified
Mark
Yoav Shapira wrote:
Hi,
I thought the docs were right, path= for the ROOT, not path=/.  And
therefore I thought this was an invalid bug report.  Was I wrong?
Yoav
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:11 PM
To: tomcat-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867
[EMAIL PROTECTED] changed:
  What|Removed |Added

Status|NEW |RESOLVED
Resolution||FIXED

--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11
---
Fixed in CVS for 4.1.x and 5.5.x
Thansk for the report and the patch (I actually committed a variation).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Yoav Shapira
Hi,
The docs agree with the behavior only for the manager, that's the problem.
Previously the docs agreed with the configuration instructions, e.g. editing
server.xml, and disagreed with the manager.  So we should clarify in the
docs that what the manager reports as / is actually  when you create
context.xml files.

We've gotten easily 1000 times more questions from people putting / in
configuration files (which is wrong) than we have people complaining about
/ in the manager.  If we have to pick one, the former (the way the docs
previously were) is much better.  But we don't have to pick just one
thankfully, we can have docs that cover both the manager display and the
configuration.

This issue comes up often enough on the list that this is worthwhile,
otherwise I wouldn't have said anything...

Yoav

-Original Message-
From: Mark Thomas [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:59 PM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

The manager would be wrong if:

a) we had a consistent way of handling the ROOT context
b) the agreed consistent way to reference ROOT was 

I am not aware of a) and from a user perspective / seems to make more 
sense for b)

At least at present the docs agree with the actual behaviour.

Mark

Yoav Shapira wrote:
 Hi,
 IT might be the manager that's wrong.  When editing server.xml or
 context.xml files for those Tomcat versions, users should use path= and
 not path=/.  The latter leads to significant failures.
 
 Yoav
 
 -Original Message-
 From: Mark Thomas [mailto:[EMAIL PROTECTED] 
 Sent: Tuesday, January 11, 2005 4:30 PM
 To: Tomcat Developers List
 Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
 string for root context path instead of /
 
 I did a quick test (on TC4 and TC5) before changing the docs.
 
 http://localhost:8080/manager/reload?path=/
 returns
 OK - Reloaded application at context path /
 
 http://localhost:8080/manager/reload?path=
 returns
 FAIL - Invalid context path  was specified
 
 Mark
 
 Yoav Shapira wrote:
 
Hi,
I thought the docs were right, path= for the ROOT, not path=/.  And
therefore I thought this was an invalid bug report.  Was I wrong?

Yoav

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:11 PM
To: tomcat-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28867


[EMAIL PROTECTED] changed:

   What|Removed |Added

 


 
 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11
 
 ---
 
Fixed in CVS for 4.1.x and 5.5.x

Thansk for the report and the patch (I actually committed a variation).

 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Yoav Shapira
Hi,
Big duh on my part.  I just realized the bug spoke Only about the manager
docs page.  The patch is fine, my mistake, good job fixing it, and thank you
;)

Yoav

-Original Message-
From: Yoav Shapira [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 5:04 PM
To: 'Tomcat Developers List'
Subject: RE: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

Hi,
The docs agree with the behavior only for the manager, that's the problem.
Previously the docs agreed with the configuration instructions, e.g. editing
server.xml, and disagreed with the manager.  So we should clarify in the
docs that what the manager reports as / is actually  when you create
context.xml files.

We've gotten easily 1000 times more questions from people putting / in
configuration files (which is wrong) than we have people complaining about
/ in the manager.  If we have to pick one, the former (the way the docs
previously were) is much better.  But we don't have to pick just one
thankfully, we can have docs that cover both the manager display and the
configuration.

This issue comes up often enough on the list that this is worthwhile,
otherwise I wouldn't have said anything...

Yoav

-Original Message-
From: Mark Thomas [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:59 PM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

The manager would be wrong if:

a) we had a consistent way of handling the ROOT context
b) the agreed consistent way to reference ROOT was 

I am not aware of a) and from a user perspective / seems to make more 
sense for b)

At least at present the docs agree with the actual behaviour.

Mark

Yoav Shapira wrote:
 Hi,
 IT might be the manager that's wrong.  When editing server.xml or
 context.xml files for those Tomcat versions, users should use path= and
 not path=/.  The latter leads to significant failures.
 
 Yoav
 
 -Original Message-
 From: Mark Thomas [mailto:[EMAIL PROTECTED] 
 Sent: Tuesday, January 11, 2005 4:30 PM
 To: Tomcat Developers List
 Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
 string for root context path instead of /
 
 I did a quick test (on TC4 and TC5) before changing the docs.
 
 http://localhost:8080/manager/reload?path=/
 returns
 OK - Reloaded application at context path /
 
 http://localhost:8080/manager/reload?path=
 returns
 FAIL - Invalid context path  was specified
 
 Mark
 
 Yoav Shapira wrote:
 
Hi,
I thought the docs were right, path= for the ROOT, not path=/.  And
therefore I thought this was an invalid bug report.  Was I wrong?

Yoav

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:11 PM
To: tomcat-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28867


[EMAIL PROTECTED] changed:

   What|Removed |Added

 


 
 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11
 
 ---
 
Fixed in CVS for 4.1.x and 5.5.x

Thansk for the report and the patch (I actually committed a variation).

 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Mark Thomas
Yoav Shapira wrote:
Hi,
The docs agree with the behavior only for the manager, that's the problem.
No. I only changed the manager docs. The config section of the docs 
remains as was - use  for the root context.

Previously the docs agreed with the configuration instructions, e.g. editing
server.xml, and disagreed with the manager.  So we should clarify in the
docs that what the manager reports as / is actually  when you create
context.xml files.
I will put in some additional text in the manager docs to highlight this.
We've gotten easily 1000 times more questions from people putting / in
configuration files (which is wrong) than we have people complaining about
/ in the manager.  If we have to pick one, the former (the way the docs
previously were) is much better.  But we don't have to pick just one
thankfully, we can have docs that cover both the manager display and the
configuration.
This is exactly what we now have.
This issue comes up often enough on the list that this is worthwhile,
otherwise I wouldn't have said anything...
Yoav
-Original Message-
From: Mark Thomas [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:59 PM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

The manager would be wrong if:
a) we had a consistent way of handling the ROOT context
b) the agreed consistent way to reference ROOT was 
I am not aware of a) and from a user perspective / seems to make more 
sense for b)

At least at present the docs agree with the actual behaviour.
Mark
Yoav Shapira wrote:
Hi,
IT might be the manager that's wrong.  When editing server.xml or
context.xml files for those Tomcat versions, users should use path= and
not path=/.  The latter leads to significant failures.
Yoav
-Original Message-
From: Mark Thomas [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:30 PM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

I did a quick test (on TC4 and TC5) before changing the docs.
http://localhost:8080/manager/reload?path=/
returns
OK - Reloaded application at context path /
http://localhost:8080/manager/reload?path=
returns
FAIL - Invalid context path  was specified
Mark
Yoav Shapira wrote:

Hi,
I thought the docs were right, path= for the ROOT, not path=/.  And
therefore I thought this was an invalid bug report.  Was I wrong?
Yoav
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 4:11 PM
To: tomcat-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length
string for root context path instead of /

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG.
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND.
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28867
[EMAIL PROTECTED] changed:
 What|Removed |Added


   Status|NEW |RESOLVED
   Resolution||FIXED

--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 22:11
---

Fixed in CVS for 4.1.x and 5.5.x
Thansk for the report and the patch (I actually committed a variation).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler ParserController.java

2005-01-11 Thread kinman
kinman  2005/01/11 14:14:55

  Modified:jasper2/src/share/org/apache/jasper/compiler
ParserController.java
  Log:
  - Fix 29771: page encoding in a page directive inside a comment should be 
ignored.
  
  Revision  ChangesPath
  1.56  +19 -52
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java
  
  Index: ParserController.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- ParserController.java 23 Sep 2004 06:59:09 -  1.55
  +++ ParserController.java 11 Jan 2005 22:14:55 -  1.56
  @@ -401,40 +401,31 @@
   jspReader.reset(startMark);
   
/*
  -  * Determine page encoding from directive of the form %@ page % or
  -  * %@ tag %
  +  * Determine page encoding from directive of the form %@ page %,
  +  * %@ tag %, jsp:directive.page  or jsp:directive.tag .
 */
   while (true) {
  -Mark current = jspReader.mark();
  -
  -Mark beginDirective = jspReader.skipUntil(%@);
  -if (beginDirective == null) {
  +if (jspReader.skipUntil() == null) {
   break;
   }
  -// Move past the '%@' delimiter
  -Mark beginDirectiveBody = jspReader.mark();
  -
  -// Check to see if directive is nested inside comment
  -jspReader.reset(current);
  -Mark beginComment = jspReader.skipUntil(%--);
  -if (beginComment != null) {
  -Mark endComment = jspReader.skipUntil(--%);
  -if (endComment == null) {
  -err.jspError(beginComment, jsp.error.unterminated,
  - lt;%--);
  -}
  -  
  -if (beginDirective.isGreater(beginComment)
  - endComment.isGreater(beginDirective)) {
  -// Directive is nested inside comment, skip until end of 
  -// comment
  -jspReader.reset(endComment);
  -continue;
  +// If this is a comment, skip until its end
  +if (jspReader.matches(%--)) {
  +if (jspReader.skipUntil(--%) == null) {
  +// error will be caught in Parser
  +break;
   }
  +continue;
  +}
  +boolean isDirective = jspReader.matches(%@);
  +if (isDirective) {
  + jspReader.skipSpaces();
  +}
  +else {
  +isDirective = jspReader.matches(jsp:directive.);
  +}
  +if (!isDirective) {
  +continue;
   }
  -
  -jspReader.reset(beginDirectiveBody);
  - jspReader.skipSpaces();
   
// compare for tag , so we don't match taglib
if (jspReader.matches(tag ) || jspReader.matches(page)) {
  @@ -455,30 +446,6 @@
   if (encoding == null) {
   encoding = saveEncoding;
   }
  -
  - if (encoding == null) {
  - /*
  -  * Determine page encoding from page directive of the form
  -  * jsp:directive.page
  -  */
  - jspReader.reset(startMark);
  - while (jspReader.skipUntil(jsp:directive.page) != null) {
  - jspReader.skipSpaces();
  -Attributes attrs = Parser.parseAttributes(this, jspReader);
  -
  - encoding = getPageEncodingFromDirective(attrs, pageEncoding);
  -if (encoding != null) {
  -break;
  -}
  - encoding = getPageEncodingFromDirective(attrs, contentType);
  -if (encoding != null) {
  -saveEncoding = encoding;
  -}
  - }
  -if (encoding == null) {
  -encoding = saveEncoding;
  -}
  - }
   
return encoding;
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29971] - Commented out page directive is parsed

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29971.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29971


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 23:16 ---
Fixed jan 11, 2005

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of /

2005-01-11 Thread Remy Maucherat
Yoav Shapira wrote:
Hi,
IT might be the manager that's wrong.  When editing server.xml or
context.xml files for those Tomcat versions, users should use path= and
not path=/.  The latter leads to significant failures.
Well, sort of. The only place where you can still use it is server.xml, 
though, so IMO it doesn't matter.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 33027] - catalina.sh - give shutdown some time before killing with -force option

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33027.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33027


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32998] - Error in communication between Apache and Tomcat through AJP

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32998.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32998


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|P2  |P1




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28851] - Undeploy command does not work in ManagerServlet

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28851.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28851


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 23:45 ---
(In reply to comment #0)
 I fail to really understand the subtle difference between the 'undeploy' 
 and 'remove' and their associated use case.

The distinction is a subtle one. 'undeploy' is opposite of 'deploy' and 
'remove' 
is opposite of 'install'. The difference is really between 'deploy' which
uploads a file to the server and 'install' which works with a file/directory
that is already present on the server.
 
 But for instance, the 'undeploy' command does not work as it validates that 
 the context docbase should be inside the manager working directory, which is 
 quite unlikely to half happen if deployed incorrectly due to PR 28830

'deploy' should put put wars in the appbase

 I will send a complete patch within the next days.

Fixing 28830 should fix this since the war will be in the expected place.
Therefore, I am marking this as a duplicate of 28830.

FYI - Remy has made this a lot better in 5.5.x but I don't propose to back port
all his changes.

*** This bug has been marked as a duplicate of 28830 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28830] - ManagerServlet is broken for war upload (deploy)

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28830.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28830





--- Additional Comments From [EMAIL PROTECTED]  2005-01-11 23:45 ---
*** Bug 28851 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 28851] - Undeploy command does not work in ManagerServlet

2005-01-11 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
FYI - Remy has made this a lot better in 5.5.x but I don't propose to back port
all his changes.
And with a lot of shiny new bugs too ;) It should be all ok in 5.5.7, 
though (the last problems being undeployment of webapps which failed on 
deployment).

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-11 Thread Remy Maucherat
Remy Maucherat wrote:
[EMAIL PROTECTED] wrote:
pero2005/01/11 12:02:14
  Modified:catalina/src/share/org/apache/catalina/core
StandardServer.java
   
modules/storeconfig/src/share/org/apache/catalina/storeconfig
StoreConfigLifecycleListener.java
server-registry.xml
   
modules/storeconfig/test/src/share/org/apache/catalina/storeconfig
ManagerSFTest.java
   webapps/docs changelog.xml
  Log:
  Integrate StoreConfig at StandardServer and fix small StoreConfig bugs

I was thinking all that stuff would be completely removed from 
StandardServer, and the admin would call the right JMX operation directly.
I've thought about this more. Actually, maybe it's better to leave an 
indirection (and keep the compatibility as a bonus). Otherwise, we start 
to have to hardcode (or make configurable = more complexity) an 
ObjectName. So I think you probably have made the right choice.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/catalina build.xml

2005-01-11 Thread remm
remm2005/01/11 14:58:54

  Modified:catalina build.xml
  Log:
  - Exclude storeconfig from catalina.jar.
  
  Revision  ChangesPath
  1.79  +1 -0  jakarta-tomcat-catalina/catalina/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
  retrieving revision 1.78
  retrieving revision 1.79
  diff -u -r1.78 -r1.79
  --- build.xml 27 Oct 2004 10:45:05 -  1.78
  +++ build.xml 11 Jan 2005 22:58:54 -  1.79
  @@ -934,6 +934,7 @@
   exclude name=org/apache/catalina/launcher/** /
   exclude name=org/apache/catalina/servlets/** /
   exclude name=org/apache/catalina/startup/Bootstrap.class /
  +exclude name=org/apache/catalina/storeconfig/** /
   exclude name=org/apache/catalina/ssi/** /
   exclude name=org/apache/naming/** /
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-11 Thread luehe
luehe   2005/01/11 15:27:36

  Modified:webapps/docs changelog.xml
  Log:
  Added fix for 32832
  
  Revision  ChangesPath
  1.218 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.217
  retrieving revision 1.218
  diff -u -r1.217 -r1.218
  --- changelog.xml 11 Jan 2005 21:09:35 -  1.217
  +++ changelog.xml 11 Jan 2005 23:27:36 -  1.218
  @@ -81,6 +81,9 @@
 fix
   bug25889/bug: Don't execute queries twice, submitted by Tom 
Anderson (remm)
 /fix
  +  fix
  +bug32832/bug: request.getSession(false) fails to return null 
(luehe)
  +  /fix
   /changelog
 /subsection
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-servletapi-5/jsr152/examples/num numguess.jsp

2005-01-11 Thread kinman
kinman  2005/01/11 15:36:20

  Modified:jsr152/examples/num numguess.jsp
  Log:
  - Fix 32456: Remove extra !--
  
  Revision  ChangesPath
  1.3   +0 -1  jakarta-servletapi-5/jsr152/examples/num/numguess.jsp
  
  Index: numguess.jsp
  ===
  RCS file: /home/cvs/jakarta-servletapi-5/jsr152/examples/num/numguess.jsp,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- numguess.jsp  18 Mar 2004 16:40:31 -  1.2
  +++ numguess.jsp  11 Jan 2005 23:36:20 -  1.3
  @@ -1,5 +1,4 @@
   !--
  -!--
 Copyright 2004 The Apache Software Foundation
   
 Licensed under the Apache License, Version 2.0 (the License);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32456] - SERVLETAPI: Wrong html comment in numguess.jsp

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32456.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32456


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32776] - Jasper allows elements outside default namespace in jsp documents (jspx)

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32776.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32776


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-01-12 01:13 ---
By design, jasper does not validate the use of namespaces in xml documents, as
long as their uses conform to xml syntax.  This is in conformant with JSP spec.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] JK 1.2.8 Stability

2005-01-11 Thread Günter Knauf
Hi,
 JK 1.2.8 has been available for about a week now.
 There has been no bugs reported against this release,
 but we need a vote to make it official.

 So following the usual criteria, JK 1.2.8 is:

 [ ] Alpha
 [ ] Beta
[ X ] Stable
seems to work fine now.

Everyone on NetWare please test the binaries I've build before we move them to 
the final release dir, specially also the Netscape stuff:
http://www.apache.org/~fuankg/mod_jk/

thanks, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Deprecation and JK2

2005-01-11 Thread Costin Manolache
A lot of the code is actually specific to the now-dead Jk2 - if the 
native jk2 is gone, probably you should clean up this side as well.

- org.apache.jk.apr - the not-quite apr jni layer that connects to the 
native objects, as well as 'in-process' launcher ( I doubt it can be 
used by jk1.x ), also common.JniHandler

- ChannelJni, ChannelShm, ChannelUn, Shm - specific to jk2.
Maybe it would be a good idea to rename the remaining files ( but please 
not org.apache.ajp - it would be confusing since this is the name of the 
very old connector package ).

What is the story with in-process ? Is it still supported with jk1.x ?
Costin
Remy Maucherat wrote:
Henri Gomez wrote:
+0
JK / JK2 are also very specific to our current AJP implemtation.
Maybe they should be called AJP instead ?

I thouhgt I had done enough damage with my package renaming and class 
moving ;)
The renaming here is nearly all located in strings which are supposed to 
be displayed to the user when there's an error, and also in comments - 
low impact stuff.

PS: Happy New Year to all TC-DEV members :)

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 32604] - Some httpHeaders can be lost in response

2005-01-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32604.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32604





--- Additional Comments From [EMAIL PROTECTED]  2005-01-12 02:35 ---
I agree with Remy here that response.setContentLength(0) would cause the
response to be closed, because it meets the condition that the amount of content
specified in the setContentLength method of the response (in this case: zero)
has been written to the response.

Julian/Touchard, the reason the response is considered committed from the
implementation point of view is because getContentCount() and getContentLength()
are both zero in:

public boolean isAppCommitted() {
return (this.appCommitted || isCommitted() || isSuspended()
|| ((getContentLength() != -1) 
 (getContentCount() = getContentLength(;
}

Please notice that getContentCount() really only returns the number of bytes
written to the response body (in this case: zero): it does not include any
response header bytes, which - I agree with you - would be wrong.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Deprecation and JK2

2005-01-11 Thread Bill Barker

- Original Message -
From: Costin Manolache [EMAIL PROTECTED]
To: tomcat-dev@jakarta.apache.org
Sent: Wednesday, January 12, 2005 4:14 AM
Subject: Re: Deprecation and JK2


A lot of the code is actually specific to the now-dead Jk2 - if the
native jk2 is gone, probably you should clean up this side as well.

- org.apache.jk.apr - the not-quite apr jni layer that connects to the
native objects, as well as 'in-process' launcher ( I doubt it can be
used by jk1.x ), also common.JniHandler

- ChannelJni, ChannelShm, ChannelUn, Shm - specific to jk2.

I think that proxy_ajp is hoping to be able to use ChannelUn someday.  It's
no more Jk2 specific than ChannelSocket is.


Maybe it would be a good idea to rename the remaining files ( but please
not org.apache.ajp - it would be confusing since this is the name of the
very old connector package ).

What is the story with in-process ? Is it still supported with jk1.x ?

Only the (very) old 3.3 JniHandler at the moment.


Costin


Remy Maucherat wrote:
 Henri Gomez wrote:

 +0

 JK / JK2 are also very specific to our current AJP implemtation.
 Maybe they should be called AJP instead ?


 I thouhgt I had done enough damage with my package renaming and class
 moving ;)
 The renaming here is nearly all located in strings which are supposed to
 be displayed to the user when there's an error, and also in comments -
 low impact stuff.

 PS: Happy New Year to all TC-DEV members :)


 Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication 
in error, please notify us immediately by e-mail and then delete all copies of 
this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through 
the Internet is not secure. Do not send confidential or sensitive information, 
such as social security numbers, account numbers, personal identification 
numbers and passwords, to us via ordinary (unencrypted) e-mail.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Log rotation

2005-01-11 Thread Assist
?


-Original Message-
From: Ash, Michael L [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 9:34 PM
To: Tomcat Developers List
Subject: RE: Log rotation

Ya, next time I will actually read who sent the email before
responding... 

-Original Message-
From: Sue Spence [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 11, 2005 9:51 AM
To: Tomcat Developers List
Subject: Re: Log rotation

Earlier, I wondered if Sweet Brandalynn was trolling for lonely geeks,
or just inadvertently found herself* on this list via some sort of
cack-handed porno spam harvester/autoresponder malfunction.

I have now decided to believe it is the latter, because the idea of a
spammer whining about getting email they didn't want to receive is
strangely satisfying.

*assuming that it's a woman

Ash, Michael L wrote:
 Because it has never been answered yet, at least not in a way I can 
 understand.
 
 Or do you mean something else like your getting it repeated.
 
 -Original Message-
 From: Sweet Brandalynn [mailto:[EMAIL PROTECTED]
 Sent: Monday, January 10, 2005 11:58 PM
 To: tomcat-dev@jakarta.apache.org
 Subject: Re: Log rotation
 
 Why Do I Keep Getting This E Mail?
 --- [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
 
I have read several threads about rotating logs in
 
 tomcat, however they
 
don't seem to cover all of the logs nor do they work when
 
 running as a
 
windows service.  

So my question:  Is / has anyone considering actually
 
 making the loggers
 
in tomcat rotatable and limit number / size of them?  Or
 
 am I just
 
totally misreading the archives.  I do see where the
 
 logger / valve
 
combo for access is creating multiple logs yet you can't
 
 limit them by
 
size or number.


 



 
 -
 
To unsubscribe, e-mail:
 
 [EMAIL PROTECTED]
 
For additional commands, e-mail:
 
 [EMAIL PROTECTED]
 
 
 
 =
 
 :kisses: Brandalynn
 
 www.sweetbrandalynn.com
 
 
 
 
  
 
 
 
 
 
 
 
   
 __
 Do you Yahoo!? 
 Yahoo! Mail - now with 250MB free storage. Learn more.
 http://info.mail.yahoo.com/mail_250
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



The information in this message is confidential and may be legally 
privileged. It is intended solely for the addressee.  Access to this message by 
anyone else is unauthorized.  If you are not the intended recipient, any 
disclosure, copying, or distribution of the message, or any action or omission 
taken by you in reliance on it, is prohibited and may be unlawful.  Please 
immediately contact the sender if you have received this message in error. 
Thank you. Hutchison Max Telecom Limited. 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Deprecation and JK2

2005-01-11 Thread Costin Manolache
Bill Barker wrote:
- Original Message -
From: Costin Manolache [EMAIL PROTECTED]
To: tomcat-dev@jakarta.apache.org
Sent: Wednesday, January 12, 2005 4:14 AM
Subject: Re: Deprecation and JK2

A lot of the code is actually specific to the now-dead Jk2 - if the
native jk2 is gone, probably you should clean up this side as well.
- org.apache.jk.apr - the not-quite apr jni layer that connects to the
native objects, as well as 'in-process' launcher ( I doubt it can be
used by jk1.x ), also common.JniHandler
- ChannelJni, ChannelShm, ChannelUn, Shm - specific to jk2.

I think that proxy_ajp is hoping to be able to use ChannelUn someday.  It's
no more Jk2 specific than ChannelSocket is.
It is using the jk2 'object' - it can be easily rewritten to use the new 
apr library directly, but in the current form I don't see how it could 
be used without jk2 native  (and if you want to add it - it's easier to 
start from channelSocket ).




Maybe it would be a good idea to rename the remaining files ( but please
not org.apache.ajp - it would be confusing since this is the name of the
very old connector package ).
What is the story with in-process ? Is it still supported with jk1.x ?

Only the (very) old 3.3 JniHandler at the moment.
Maybe the new apr library will help improve this too.
BTW, starting in-process java in jdk1.5 ( on linux at least ) it's 
amazing, no longer requires LD_LIBRARY_PATHs and seem to 'just work'.

Costin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]