Re: IP issues
Hi, I don't think we should re-instate the old file: that's too complicated from an IP perspective. Retain Remy's new file with it's easy IP handling, and give Jason a nice thank you (but not copyright, as was made clear in the legal-discuss archives) notice in either the file itself or our NOTICE file. Hopefully that way no one's ego is hurt beyond the pain already inflicted by this whole discussion, and we all move on. Yoav Quoting Remy Maucherat <[EMAIL PROTECTED]>: > Mark Thomas wrote: > > Having raised this in the legal-discuss mailing list, the result was > > that there is actually no issue to worry about here. See > > > http://mail-archives.eu.apache.org/mod_mbox/www-legal-discuss/200501.mbox/[EMAIL PROTECTED] > > > > > for details. > > > > With this in mind we need to consider what, if anything, to do now. I > > see the following options: > > > > TC5 > > - Need to populate o.a.c.util.CharsetMapperDefault.properties > > Options > > 1. Do nothing. Wait for patches to be submitted. > > 2. Re-instate the contents of the properties file based on Jason's > > previous class and include appropriate text in the NOTICE file. > > Something like: > > > > o.a.c.util.CharsetMapperDefault.properties is based on code originally > > written by Jason Hunter [EMAIL PROTECTED] as part of the book "Java > > Servlet Programming" (O'Reilly). See > href="http://www.servlets.com/book";>http://www.servlets.com/book for > > more information. Used with permission under the Apache 1.1 license. > > > > > > TC4 > > - Don't need to do anything > > Options > > 1. Do nothing > > 2. Port Remy's enhancements to o.a.c.util.CharsetMapper > > > > TC3 > > - Uses o.a.t.util.http.LocalToCharSetMap which has been deleted > > Options > > 1. Re-instate the file. > > 2. Work around it as suggested in Bill's previous e-mail > > > > My own views are: > > TC 5 - option 2 > > TC 4 - option 2 > > TC 3 - option 1 (less effort for us) > > I think we're going nowhere. If the ASF doesn't make it clear that there > are no redistribution IP issues because of licensing pollution, then I > don't think my company will feel safe continuing contributing to this > project since our customers will no longer feel confident using our > product. This is a problem ;) It's as simple as that. So we would have > to start maintaining our own branch, which basically means forking. I > suppose every vendor does that, of course, but it's still quite > disppointing (as then, the temptation exists to "add value" to our own > tree) ... > > Tomcat will work perfectly well without this code, so I do not see the > point reintroducing it accompanied with ambiguous legal and advertising > statements. This "code" (it's a set of name value pairs, so it's not > really code actually) was improperly sneaked into the Tomcat codebase, > so I think we should get rid of it. > > Rémy > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
- Original Message - From: "Mark Thomas" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Thursday, January 27, 2005 2:08 PM Subject: Re: IP issues > Having raised this in the legal-discuss mailing list, the result was > that there is actually no issue to worry about here. See > http://mail-archives.eu.apache.org/mod_mbox/www-legal-discuss/200501.mbox/%3 [EMAIL PROTECTED] > for details. > > With this in mind we need to consider what, if anything, to do now. I > see the following options: > > TC5 > - Need to populate o.a.c.util.CharsetMapperDefault.properties > Options > 1. Do nothing. Wait for patches to be submitted. > 2. Re-instate the contents of the properties file based on Jason's > previous class and include appropriate text in the NOTICE file. > Something like: > > o.a.c.util.CharsetMapperDefault.properties is based on code originally > written by Jason Hunter [EMAIL PROTECTED] as part of the book "Java > Servlet Programming" (O'Reilly). See href="http://www.servlets.com/book";>http://www.servlets.com/book for > more information. Used with permission under the Apache 1.1 license. > > > TC4 > - Don't need to do anything > Options > 1. Do nothing > 2. Port Remy's enhancements to o.a.c.util.CharsetMapper > > TC3 > - Uses o.a.t.util.http.LocalToCharSetMap which has been deleted > Options > 1. Re-instate the file. > 2. Work around it as suggested in Bill's previous e-mail > > My own views are: > TC 5 - option 2 > TC 4 - option 2 > TC 3 - option 1 (less effort for us) Nobody follows the j-t commit messages I see ;-). Option 2 has already been implemented in j-t (or Gump would be nagging us about it by now :), so it is now 2 that is less effort. For Remy's peace of mind, option 1 was always to re-instate the file in j-t (where it once lived long ago). > > Mark > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Remy Maucherat wrote: Mark Thomas wrote: - Need to populate o.a.c.util.CharsetMapperDefault.properties Options 1. Do nothing. Wait for patches to be submitted. 2. Re-instate the contents of the properties file based on Jason's previous class and include appropriate text in the NOTICE file. My own views are: TC 5 - option 2 Obviously, I vote option 1 ;) I had forgotten that the 2.4 spec allows this to be specified in web.xml. This makes populating this file less important for TC5 as users can set this in web.xml as required. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Remy Maucherat wrote: I think we're going nowhere. If the ASF doesn't make it clear that there are no redistribution IP issues because of licensing pollution, Isn't this exactly what the posts legal-discuss say? What hasn't been said that needs to be said? ...everything we received from Sun for Tomcat is clear of any IP issues until we are notified by the *author* otherwise. seems unambiguous to me. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Mark Thomas wrote: Having raised this in the legal-discuss mailing list, the result was that there is actually no issue to worry about here. See http://mail-archives.eu.apache.org/mod_mbox/www-legal-discuss/200501.mbox/[EMAIL PROTECTED] for details. With this in mind we need to consider what, if anything, to do now. I see the following options: TC5 - Need to populate o.a.c.util.CharsetMapperDefault.properties Options 1. Do nothing. Wait for patches to be submitted. 2. Re-instate the contents of the properties file based on Jason's previous class and include appropriate text in the NOTICE file. Something like: o.a.c.util.CharsetMapperDefault.properties is based on code originally written by Jason Hunter [EMAIL PROTECTED] as part of the book "Java Servlet Programming" (O'Reilly). See http://www.servlets.com/book";>http://www.servlets.com/book for more information. Used with permission under the Apache 1.1 license. TC4 - Don't need to do anything Options 1. Do nothing 2. Port Remy's enhancements to o.a.c.util.CharsetMapper TC3 - Uses o.a.t.util.http.LocalToCharSetMap which has been deleted Options 1. Re-instate the file. 2. Work around it as suggested in Bill's previous e-mail My own views are: TC 5 - option 2 TC 4 - option 2 TC 3 - option 1 (less effort for us) I think we're going nowhere. If the ASF doesn't make it clear that there are no redistribution IP issues because of licensing pollution, then I don't think my company will feel safe continuing contributing to this project since our customers will no longer feel confident using our product. This is a problem ;) It's as simple as that. So we would have to start maintaining our own branch, which basically means forking. I suppose every vendor does that, of course, but it's still quite disppointing (as then, the temptation exists to "add value" to our own tree) ... Tomcat will work perfectly well without this code, so I do not see the point reintroducing it accompanied with ambiguous legal and advertising statements. This "code" (it's a set of name value pairs, so it's not really code actually) was improperly sneaked into the Tomcat codebase, so I think we should get rid of it. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Mark Thomas wrote: Having raised this in the legal-discuss mailing list, the result was that there is actually no issue to worry about here. See http://mail-archives.eu.apache.org/mod_mbox/www-legal-discuss/200501.mbox/[EMAIL PROTECTED] for details. With this in mind we need to consider what, if anything, to do now. I see the following options: TC5 - Need to populate o.a.c.util.CharsetMapperDefault.properties Options 1. Do nothing. Wait for patches to be submitted. 2. Re-instate the contents of the properties file based on Jason's previous class and include appropriate text in the NOTICE file. Something like: o.a.c.util.CharsetMapperDefault.properties is based on code originally written by Jason Hunter [EMAIL PROTECTED] as part of the book "Java Servlet Programming" (O'Reilly). See http://www.servlets.com/book";>http://www.servlets.com/book for more information. Used with permission under the Apache 1.1 license. TC4 - Don't need to do anything Options 1. Do nothing 2. Port Remy's enhancements to o.a.c.util.CharsetMapper TC3 - Uses o.a.t.util.http.LocalToCharSetMap which has been deleted Options 1. Re-instate the file. 2. Work around it as suggested in Bill's previous e-mail My own views are: TC 5 - option 2 Obviously, I vote option 1 ;) TC 4 - option 2 TC 3 - option 1 (less effort for us) This is not good for me, as this code is included in the Tomcat 5 binary. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Having raised this in the legal-discuss mailing list, the result was that there is actually no issue to worry about here. See http://mail-archives.eu.apache.org/mod_mbox/www-legal-discuss/200501.mbox/[EMAIL PROTECTED] for details. With this in mind we need to consider what, if anything, to do now. I see the following options: TC5 - Need to populate o.a.c.util.CharsetMapperDefault.properties Options 1. Do nothing. Wait for patches to be submitted. 2. Re-instate the contents of the properties file based on Jason's previous class and include appropriate text in the NOTICE file. Something like: o.a.c.util.CharsetMapperDefault.properties is based on code originally written by Jason Hunter [EMAIL PROTECTED] as part of the book "Java Servlet Programming" (O'Reilly). See http://www.servlets.com/book";>http://www.servlets.com/book for more information. Used with permission under the Apache 1.1 license. TC4 - Don't need to do anything Options 1. Do nothing 2. Port Remy's enhancements to o.a.c.util.CharsetMapper TC3 - Uses o.a.t.util.http.LocalToCharSetMap which has been deleted Options 1. Re-instate the file. 2. Work around it as suggested in Bill's previous e-mail My own views are: TC 5 - option 2 TC 4 - option 2 TC 3 - option 1 (less effort for us) Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Re: IP issues
Hej, Nils Gustafsson har gått i pension. För Jobb-relaterade ärenden kontakta Marlene Jegeborn: [EMAIL PROTECTED] Dear Sir/Madam Nils Gustafsson has retired. Please contact Marlene Jegeborn: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Is it all cleared up now?
tia,
.V
Remy Maucherat wrote:
Davanum Srinivas wrote:
+1 to rewrite the code and go past this problem.
Since the consensus was on rewriting/removing, I have done the following:
- removed the locale to encoding list (which will have to be
reconstructed based on contributions); this opens up a relatively
small compatibility issue with some web applications (in particluar,
Servlet 2.3 webapps assuming setLocale would magically set the
encoding, and Servlet 2.4 webapps without proper locale to encoding
declarations)
- replaced the original "algorithm" with this one:
public String getCharset(Locale locale) {
// Match full language_country_variant first, then
language_country,
// then language only
String charset = map.getProperty(locale.toString());
if (charset == null) {
charset = map.getProperty(locale.getLanguage() + "_"
+ locale.getCountry());
if (charset == null) {
charset = map.getProperty(locale.getLanguage());
}
}
return (charset);
}
- removed the other file (LocaleToCharsetMap), which isn't used in
Tomcat 5.x
The old tainted Tomcat 3 version is attached (LocaleToCharsetMap).
The version now used in TC 5.5 is attached as well (CharsetMapper).
The class had been heavily rewritten by Craig already in the Tomcat
4.0 branch, and the locale->encoding list was externalized to a file
(good move by Craig, as usual).
This should hopefully clear the problem.
Rémy
On Wed, 5 Jan 2005 01:40:13 +0100, Oliver Zeigermann
<[EMAIL PROTECTED]> wrote:
On Tue, 4 Jan 2005 18:59:16 -0500 (EST), Henri Yandell
<[EMAIL PROTECTED]> >
If the code is legally intricate, ie) ours but not under his CLA,
then it
seems quite easy for anyone to rewrite the method based on the method
signature and the JDK file.
Looking at the code it really would be hard to rewrite it - not
because it is too complicated, but because it is pretty hard to think
of another way of doing it as it is so obvious.
Oliver
/*
* Copyright 1999-2004 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.tomcat.util.http;
import java.util.*;
/**
* A mapping to determine the (somewhat arbitrarily) preferred charset for
* a given locale. Supports all locales recognized in JDK 1.1.
*
* @author Jason Hunter
*/
public class LocaleToCharsetMap {
private static Hashtable map;
static {
map = new Hashtable();
map.put("ar", "ISO-8859-6");
map.put("be", "ISO-8859-5");
map.put("bg", "ISO-8859-5");
map.put("ca", "ISO-8859-1");
map.put("cs", "ISO-8859-2");
map.put("da", "ISO-8859-1");
map.put("de", "ISO-8859-1");
map.put("el", "ISO-8859-7");
map.put("en", "ISO-8859-1");
map.put("es", "ISO-8859-1");
map.put("et", "ISO-8859-1");
map.put("fi", "ISO-8859-1");
map.put("fr", "ISO-8859-1");
map.put("hr", "ISO-8859-2");
map.put("hu", "ISO-8859-2");
map.put("is", "ISO-8859-1");
map.put("it", "ISO-8859-1");
map.put("iw", "ISO-8859-8");
map.put("ja", "Shift_JIS");
map.put("ko", "EUC-KR"); // Requires JDK 1.1.6
map.put("lt", "ISO-8859-2");
map.put("lv", "ISO-8859-2");
map.put("mk", "ISO-8859-5");
map.put("nl", "ISO-8859-1");
map.put("no", "ISO-8859-1");
map.put("pl", "ISO-8859-2");
map.put("pt", "ISO-8859-1");
map.put("ro", "ISO-8859-2");
map.put("ru", "ISO-8859-5");
map.put("sh", "ISO-8859-5");
map.put("sk", "ISO-8859-2");
map.put("sl", "ISO-8859-2");
map.put("sq", "ISO-8859-2");
map.put("sr", "ISO-8859-5");
map.put("sv", "ISO-8859-1");
map.put("tr", "ISO-8859-9");
map.put("uk", "ISO-8859-5");
map.put("zh", "GB2312");
map.put("zh_TW", "Big5");
}
/**
* Gets the preferred charset for the given locale, or null if the locale
* is not recognized.
*
* @param loc the locale
* @return the preferred charset
*/
public static String getCharset(Locale loc) {
String charset;
// Try for an full name match (may include country)
charset = (String) map.get(loc.toString());
if (charset != null) return charset;
// If a full name didn't match, try just the language
charset = (String) map.get(loc.getLanguage());
return charset; // may be null
}
}
/*
* Copyright 1999,2004 The Apache Softwar
Re: IP issues
Craig McClanahan wrote: On Wed, 22 Dec 2004 18:57:51 -0500, Henri Yandell <[EMAIL PROTECTED]> wrote: [snip] The image copyrights are easy; things need to be copyright to the ASF, not to Sun. So they need fixing somehow. It would be best for someone from Sun to actually do this work. Jean-Francois, could you make sure that happens? ...back from vacation. Yes, I will take care of it. -- Jeanfrancois Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Davanum Srinivas wrote:
+1 to rewrite the code and go past this problem.
Since the consensus was on rewriting/removing, I have done the following:
- removed the locale to encoding list (which will have to be
reconstructed based on contributions); this opens up a relatively small
compatibility issue with some web applications (in particluar, Servlet
2.3 webapps assuming setLocale would magically set the encoding, and
Servlet 2.4 webapps without proper locale to encoding declarations)
- replaced the original "algorithm" with this one:
public String getCharset(Locale locale) {
// Match full language_country_variant first, then
language_country,
// then language only
String charset = map.getProperty(locale.toString());
if (charset == null) {
charset = map.getProperty(locale.getLanguage() + "_"
+ locale.getCountry());
if (charset == null) {
charset = map.getProperty(locale.getLanguage());
}
}
return (charset);
}
- removed the other file (LocaleToCharsetMap), which isn't used in
Tomcat 5.x
The old tainted Tomcat 3 version is attached (LocaleToCharsetMap).
The version now used in TC 5.5 is attached as well (CharsetMapper). The
class had been heavily rewritten by Craig already in the Tomcat 4.0
branch, and the locale->encoding list was externalized to a file (good
move by Craig, as usual).
This should hopefully clear the problem.
Rémy
On Wed, 5 Jan 2005 01:40:13 +0100, Oliver Zeigermann
<[EMAIL PROTECTED]> wrote:
On Tue, 4 Jan 2005 18:59:16 -0500 (EST), Henri Yandell
<[EMAIL PROTECTED]> >
If the code is legally intricate, ie) ours but not under his CLA, then it
seems quite easy for anyone to rewrite the method based on the method
signature and the JDK file.
Looking at the code it really would be hard to rewrite it - not
because it is too complicated, but because it is pretty hard to think
of another way of doing it as it is so obvious.
Oliver
/*
* Copyright 1999-2004 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.tomcat.util.http;
import java.util.*;
/**
* A mapping to determine the (somewhat arbitrarily) preferred charset for
* a given locale. Supports all locales recognized in JDK 1.1.
*
* @author Jason Hunter
*/
public class LocaleToCharsetMap {
private static Hashtable map;
static {
map = new Hashtable();
map.put("ar", "ISO-8859-6");
map.put("be", "ISO-8859-5");
map.put("bg", "ISO-8859-5");
map.put("ca", "ISO-8859-1");
map.put("cs", "ISO-8859-2");
map.put("da", "ISO-8859-1");
map.put("de", "ISO-8859-1");
map.put("el", "ISO-8859-7");
map.put("en", "ISO-8859-1");
map.put("es", "ISO-8859-1");
map.put("et", "ISO-8859-1");
map.put("fi", "ISO-8859-1");
map.put("fr", "ISO-8859-1");
map.put("hr", "ISO-8859-2");
map.put("hu", "ISO-8859-2");
map.put("is", "ISO-8859-1");
map.put("it", "ISO-8859-1");
map.put("iw", "ISO-8859-8");
map.put("ja", "Shift_JIS");
map.put("ko", "EUC-KR"); // Requires JDK 1.1.6
map.put("lt", "ISO-8859-2");
map.put("lv", "ISO-8859-2");
map.put("mk", "ISO-8859-5");
map.put("nl", "ISO-8859-1");
map.put("no", "ISO-8859-1");
map.put("pl", "ISO-8859-2");
map.put("pt", "ISO-8859-1");
map.put("ro", "ISO-8859-2");
map.put("ru", "ISO-8859-5");
map.put("sh", "ISO-8859-5");
map.put("sk", "ISO-8859-2");
map.put("sl", "ISO-8859-2");
map.put("sq", "ISO-8859-2");
map.put("sr", "ISO-8859-5");
map.put("sv", "ISO-8859-1");
map.put("tr", "ISO-8859-9");
map.put("uk", "ISO-8859-5");
map.put("zh", "GB2312");
map.put("zh_TW", "Big5");
}
/**
* Gets the preferred charset for the given locale, or null if the locale
* is not recognized.
*
* @param loc the locale
* @return the preferred charset
*/
public static String getCharset(Locale loc) {
String charset;
// Try for an full name match (may include country)
charset = (String) map.get(loc.toString());
if (charset != null) return charset;
// If a full name didn't match, try just the language
charset = (String) map.get(loc.getLanguage());
return charset; // may be null
}
}
/*
* Copyright 1999,2004 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except
Re: IP issues
On Tue, 04 Jan 2005 19:58:14 -0800, Costin Manolache <[EMAIL PROTECTED]> wrote: > I fully agree. Doesn't matter how small a contribution is ( or looks at > some later time ), keeping the reference to the author and whatever else > the author wants to include is the right thing to do ( if the code is > accepted and used ). > > Too bad what's ethical doesn't matter that much, only copyrights and IP > ownership :-) I'd like to add "Genscape, Inc. Monitoring the world's power. For info, call 502 555 1000" to any bits of code unlucky enough to have had me near them :) Or maybe "All your plant belong to us". Damn. I need to go talk to the marketing drones. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Jason Hunter wrote: nor see why we need an exception for such a such a small amount of code. You need an exception because (a) the code was included from a third party codebase and (b) a lot of research and testing went into compiling the map used by the mapper. I can easily add an @author tag for you in the relevant files, but the comment currently creates a legal doubt. As I wrote in my email and for the archived record, I want the classes to have the recognition that is expected when Apache includes code from a third party library that's under a license that requires attribution (just like Apache's). The files says "copyright ASF" - but it seems that's not completely accurate ( I assume someone mistakenly removed your "Copyright Jason Hunder" ? ). As an author, you should be able to keep any notice that you consider apropriate. If you didn't explicitely assign the coypright to ASF ( or to Sun ), than I don't think it would be right for anyone to remove your name or attribution. If you did assign the rights to ASF - then as you know anything can be removed or changed by the new owner, including @author tags or any mention of previous author ( just make sure your name does gets into whatever obscure file lists all people who contributed something ) :-) Note: Many companies and individuals donated more than these 10 lines of code, Yes, and I too donated plenty of code to the Tomcat codebase. But these classes I donated (to Sun at the time) with attribution because they were from a separate, pre-existing codebase with a life of its own. If you write a book and include a paragraph from someone else's book with permission, you mention it and you point at the source of the original work. You don't just say, "Written by author X" you say, "Written by author X as part of book Y, published by Z." That's why the attribution I put on those classes includes the who, what, and where. I see it as the ethical thing to do. I fully agree. Doesn't matter how small a contribution is ( or looks at some later time ), keeping the reference to the author and whatever else the author wants to include is the right thing to do ( if the code is accepted and used ). Too bad what's ethical doesn't matter that much, only copyrights and IP ownership :-) Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Remy Maucherat wrote: Jason Hunter wrote: I do have a CLA on file. Aren't members required to? :) That code donation happened while Tomcat was still Sun internal and I was helping Sun as a contractor. Those were the good old days before I was burdened with the knowledge about IP rights that I've since acquired (as has Remy obviously). It was even before Jakarta. I'm still fine with the donation. Technically the code wouldn't be covered under the CLA since I didn't take action to donate the code to Apache; it just came over from Sun in the bundle. I'm happy to go on record here as giving it a formal stamp of approval, with the one caveat that I'd like it to retain attribution since the classes have a life of their own separately. I believe Apache has policies for including code with attribution. Our own license requires attribution, so we'd better. :) Jumping back to the thread I started since I'm back from vacation ... And here I thought we put the thread to rest. The comment includes "Used by Sun Microsystems with permission.". I don't see any explicit permission for this item Please see my email above there I answer this. (so AFAIK, we're not covered if we mention we need Sun's permission for that code), Correct. But please see above. nor see why we need an exception for such a such a small amount of code. You need an exception because (a) the code was included from a third party codebase and (b) a lot of research and testing went into compiling the map used by the mapper. I can easily add an @author tag for you in the relevant files, but the comment currently creates a legal doubt. As I wrote in my email and for the archived record, I want the classes to have the recognition that is expected when Apache includes code from a third party library that's under a license that requires attribution (just like Apache's). Note: Many companies and individuals donated more than these 10 lines of code, Yes, and I too donated plenty of code to the Tomcat codebase. But these classes I donated (to Sun at the time) with attribution because they were from a separate, pre-existing codebase with a life of its own. If you write a book and include a paragraph from someone else's book with permission, you mention it and you point at the source of the original work. You don't just say, "Written by author X" you say, "Written by author X as part of book Y, published by Z." That's why the attribution I put on those classes includes the who, what, and where. I see it as the ethical thing to do. -jh- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Jason Hunter wrote: I do have a CLA on file. Aren't members required to? :) That code donation happened while Tomcat was still Sun internal and I was helping Sun as a contractor. Those were the good old days before I was burdened with the knowledge about IP rights that I've since acquired (as has Remy obviously). It was even before Jakarta. I'm still fine with the donation. Technically the code wouldn't be covered under the CLA since I didn't take action to donate the code to Apache; it just came over from Sun in the bundle. I'm happy to go on record here as giving it a formal stamp of approval, with the one caveat that I'd like it to retain attribution since the classes have a life of their own separately. I believe Apache has policies for including code with attribution. Our own license requires attribution, so we'd better. :) Jumping back to the thread I started since I'm back from vacation ... The comment includes "Used by Sun Microsystems with permission.". I don't see any explicit permission for this item (so AFAIK, we're not covered if we mention we need Sun's permission for that code), nor see why we need an exception for such a such a small amount of code. I can easily add an @author tag for you in the relevant files, but the comment currently creates a legal doubt. Note: Many companies and individuals donated more than these 10 lines of code, and they do not get any special treatment besides author tags (which many want to remove). A comment is clearly excessive. Is there an advertising clause in the license you used ? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
On Wed, 22 Dec 2004 18:57:51 -0500, Henri Yandell <[EMAIL PROTECTED]> wrote: [snip] > The image copyrights are easy; things need to be copyright to the ASF, > not to Sun. So they need fixing somehow. It would be best for someone from Sun to actually do this work. Jean-Francois, could you make sure that happens? Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
I do have a CLA on file. Aren't members required to? :) That code donation happened while Tomcat was still Sun internal and I was helping Sun as a contractor. Those were the good old days before I was burdened with the knowledge about IP rights that I've since acquired (as has Remy obviously). It was even before Jakarta. I'm still fine with the donation. Technically the code wouldn't be covered under the CLA since I didn't take action to donate the code to Apache; it just came over from Sun in the bundle. I'm happy to go on record here as giving it a formal stamp of approval, with the one caveat that I'd like it to retain attribution since the classes have a life of their own separately. I believe Apache has policies for including code with attribution. Our own license requires attribution, so we'd better. :) -jh- Henri Yandell wrote: (this is based on assumptions, so let me know if they are wrong Jason) I must admit that I lack the experience to be sure of the correct action here. The image copyrights are easy; things need to be copyright to the ASF, not to Sun. So they need fixing somehow. Jason's code is harder. It doesn't say that it's copyrighted to Jason, just that it's originally from classes by him. As the code in Tomcat is copyright to the ASF, there's no reason why we couldn't remove the comments apart from the politeness aspect that Jason raises. The code isn't licenced to the ASF, it's donated to the ASF and now owned by the ASF (for this instance, Jason owns a duplicate instance). Not knowing the whole story, the whole question is whether we actually own that code or if it was licensed to Sun and then they donated it to Apache, something they did not have the right to do. Does Jason have a CLA, and if not, would we need one? I think we should remove the Sun permission line; it's not important to the existence in Tomcat. Keeping the rest of the comment seems fine to me, provided we're sure we own the code. Hen On Wed, 22 Dec 2004 14:12:43 -0800, Jason Hunter <[EMAIL PROTECTED]> wrote: I think it would be rude to remove the comments about where the source files originated, as they were developed apart from Apache and have a life on their own apart from Apache. Attribution is fair and proper. However I did grant permission for Sun (and of course Apache) to license the code under the Apache license. -jh- Remy Maucherat wrote: Hi, There are apparently a few licensing issues with some files in the Tomcat CVS: > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/catalina/src > > /share/org/apache/catalina/util/CharsetMapper.java > >18: * This class is based on a class originally written > by Jason > > Hunter > >19: * <[EMAIL PROTECTED]> as part of the book "Java Servlet > > Programming" > >20: * (O'Reilly). See http://www.servlets.com/book for more > > information. > >21: * Used by Sun Microsystems with permission. > >22: */ > >23: > >24: package org.apache.catalina.util; > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > n/images/Context.gif > > > 4: ?ycga???wHIL!?OCopyright 2000 by Sun Microsystems, Inc. All > > Rights Reserved. > > 5: JLF GR Ver 1.0 > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > > n/images/Host.gif > > 2: !?OCopyright 2000 by Sun Microsystems, Inc. All Rights > > Reserved. > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-connectors/util/java/ > > org/apache/tomcat/util/http/LocaleToCharsetMap.java > >19: * This class was originally written by Jason Hunter > > <[EMAIL PROTECTED]> > >20: * as part of the book "Java Servlet Programming" > (O'Reilly). > >21: * See http://www.servlets.com/book for more information. > >22: * Used by Sun Microsystems with permission. Fixing the GIFs should be easy. How about the two Java files ? I would need an answer from Jason and Craig to see if I can safely remove the comments (otherwise we would have to reimplement these, right ?). Thanks, Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
Jason is correct, the attributions remain. I'll send along the last set of guidelines I saw regarding attribution and licensing. Brian On Wed, 22 Dec 2004, Jason Hunter wrote: I think it would be rude to remove the comments about where the source files originated, as they were developed apart from Apache and have a life on their own apart from Apache. Attribution is fair and proper. However I did grant permission for Sun (and of course Apache) to license the code under the Apache license. -jh- Remy Maucherat wrote: Hi, There are apparently a few licensing issues with some files in the Tomcat CVS: > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/catalina/src > > /share/org/apache/catalina/util/CharsetMapper.java > >18: * This class is based on a class originally written > by Jason > > Hunter > >19: * <[EMAIL PROTECTED]> as part of the book "Java Servlet > > Programming" > >20: * (O'Reilly). See http://www.servlets.com/book for more > > information. > >21: * Used by Sun Microsystems with permission. > >22: */ > >23: > >24: package org.apache.catalina.util; > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > n/images/Context.gif > > > 4: ?ycga???wHIL!?OCopyright 2000 by Sun Microsystems, Inc. All > > Rights Reserved. > > 5: JLF GR Ver 1.0 > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > > n/images/Host.gif > > 2: !?OCopyright 2000 by Sun Microsystems, Inc. All Rights > > Reserved. > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-connectors/util/java/ > > org/apache/tomcat/util/http/LocaleToCharsetMap.java > >19: * This class was originally written by Jason Hunter > > <[EMAIL PROTECTED]> > >20: * as part of the book "Java Servlet Programming" > (O'Reilly). > >21: * See http://www.servlets.com/book for more information. > >22: * Used by Sun Microsystems with permission. Fixing the GIFs should be easy. How about the two Java files ? I would need an answer from Jason and Craig to see if I can safely remove the comments (otherwise we would have to reimplement these, right ?). Thanks, Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
(this is based on assumptions, so let me know if they are wrong Jason) I must admit that I lack the experience to be sure of the correct action here. The image copyrights are easy; things need to be copyright to the ASF, not to Sun. So they need fixing somehow. Jason's code is harder. It doesn't say that it's copyrighted to Jason, just that it's originally from classes by him. As the code in Tomcat is copyright to the ASF, there's no reason why we couldn't remove the comments apart from the politeness aspect that Jason raises. The code isn't licenced to the ASF, it's donated to the ASF and now owned by the ASF (for this instance, Jason owns a duplicate instance). Not knowing the whole story, the whole question is whether we actually own that code or if it was licensed to Sun and then they donated it to Apache, something they did not have the right to do. Does Jason have a CLA, and if not, would we need one? I think we should remove the Sun permission line; it's not important to the existence in Tomcat. Keeping the rest of the comment seems fine to me, provided we're sure we own the code. Hen On Wed, 22 Dec 2004 14:12:43 -0800, Jason Hunter <[EMAIL PROTECTED]> wrote: > I think it would be rude to remove the comments about where the source > files originated, as they were developed apart from Apache and have a > life on their own apart from Apache. Attribution is fair and proper. > However I did grant permission for Sun (and of course Apache) to license > the code under the Apache license. > > -jh- > > Remy Maucherat wrote: > > > Hi, > > > > There are apparently a few licensing issues with some files in the > > Tomcat CVS: > > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/catalina/src > > > > /share/org/apache/catalina/util/CharsetMapper.java > > > >18: * This class is based on a class originally written > > > by Jason > > > > Hunter > > > >19: * <[EMAIL PROTECTED]> as part of the book "Java Servlet > > > > Programming" > > > >20: * (O'Reilly). See http://www.servlets.com/book for more > > > > information. > > > >21: * Used by Sun Microsystems with permission. > > > >22: */ > > > >23: > > > >24: package org.apache.catalina.util; > > > > > > > > > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > > > n/images/Context.gif > > > > > > > 4: ?ycga???wHIL!?OCopyright 2000 by Sun Microsystems, Inc. All > > > > Rights Reserved. > > > > 5: JLF GR Ver 1.0 > > > > > > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > > > > n/images/Host.gif > > > > 2: !?OCopyright 2000 by Sun Microsystems, Inc. All Rights > > > > Reserved. > > > > > > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-connectors/util/java/ > > > > org/apache/tomcat/util/http/LocaleToCharsetMap.java > > > >19: * This class was originally written by Jason Hunter > > > > <[EMAIL PROTECTED]> > > > >20: * as part of the book "Java Servlet Programming" > > > (O'Reilly). > > > >21: * See http://www.servlets.com/book for more information. > > > >22: * Used by Sun Microsystems with permission. > > > > Fixing the GIFs should be easy. How about the two Java files ? I would > > need an answer from Jason and Craig to see if I can safely remove the > > comments (otherwise we would have to reimplement these, right ?). > > > > Thanks, > > Rémy > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
I think it would be rude to remove the comments about where the source files originated, as they were developed apart from Apache and have a life on their own apart from Apache. Attribution is fair and proper. However I did grant permission for Sun (and of course Apache) to license the code under the Apache license. -jh- Remy Maucherat wrote: Hi, There are apparently a few licensing issues with some files in the Tomcat CVS: > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/catalina/src > > /share/org/apache/catalina/util/CharsetMapper.java > >18: * This class is based on a class originally written > by Jason > > Hunter > >19: * <[EMAIL PROTECTED]> as part of the book "Java Servlet > > Programming" > >20: * (O'Reilly). See http://www.servlets.com/book for more > > information. > >21: * Used by Sun Microsystems with permission. > >22: */ > >23: > >24: package org.apache.catalina.util; > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > n/images/Context.gif > > > 4: ?ycga???wHIL!?OCopyright 2000 by Sun Microsystems, Inc. All > > Rights Reserved. > > 5: JLF GR Ver 1.0 > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > > n/images/Host.gif > > 2: !?OCopyright 2000 by Sun Microsystems, Inc. All Rights > > Reserved. > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-connectors/util/java/ > > org/apache/tomcat/util/http/LocaleToCharsetMap.java > >19: * This class was originally written by Jason Hunter > > <[EMAIL PROTECTED]> > >20: * as part of the book "Java Servlet Programming" > (O'Reilly). > >21: * See http://www.servlets.com/book for more information. > >22: * Used by Sun Microsystems with permission. Fixing the GIFs should be easy. How about the two Java files ? I would need an answer from Jason and Craig to see if I can safely remove the comments (otherwise we would have to reimplement these, right ?). Thanks, Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IP issues
On Wed, 22 Dec 2004 17:40:25 +0100, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > Fixing the GIFs should be easy. How about the two Java files ? I would > need an answer from Jason and Craig to see if I can safely remove the > comments (otherwise we would have to reimplement these, right ?). Sounds right. Let me know if you need any assistance. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
IP issues
Hi, There are apparently a few licensing issues with some files in the Tomcat CVS: > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/catalina/src > > /share/org/apache/catalina/util/CharsetMapper.java > >18: * This class is based on a class originally written > by Jason > > Hunter > >19: * <[EMAIL PROTECTED]> as part of the book "Java Servlet > > Programming" > >20: * (O'Reilly). See http://www.servlets.com/book for more > > information. > >21: * Used by Sun Microsystems with permission. > >22: */ > >23: > >24: package org.apache.catalina.util; > > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > n/images/Context.gif > > > 4: ?ycga???wHIL!?OCopyright 2000 by Sun Microsystems, Inc. All > > Rights Reserved. > > 5: JLF GR Ver 1.0 > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-catalina/webapps/admi > > n/images/Host.gif > > 2: !?OCopyright 2000 by Sun Microsystems, Inc. All Rights > > Reserved. > > > > jakarta-tomcat-5.0.28-src/jakarta-tomcat-connectors/util/java/ > > org/apache/tomcat/util/http/LocaleToCharsetMap.java > >19: * This class was originally written by Jason Hunter > > <[EMAIL PROTECTED]> > >20: * as part of the book "Java Servlet Programming" > (O'Reilly). > >21: * See http://www.servlets.com/book for more information. > >22: * Used by Sun Microsystems with permission. Fixing the GIFs should be easy. How about the two Java files ? I would need an answer from Jason and Craig to see if I can safely remove the comments (otherwise we would have to reimplement these, right ?). Thanks, Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
