RE: http 1.0 timeout patch
I picked 5 minutes because that seemed to be the default timeout for Apache httpd. If I open telnet session to Apache and never enter any data the connection times out after 5 minutes. In Apache this is configured in httpd.conf as # # Timeout: The number of seconds before receives and sends time out. # Timeout 300 -Original Message- From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] Sent: Wednesday, March 21, 2001 4:01 PM To: [EMAIL PROTECTED] Cc: Marc Saegesser Subject: http 1.0 timeout patch Hi, I notice you corrected the patch which is a good thing but settings timeout to 5mn (300s) is a little too high for an http 1.0 connection. The timeout could be as low as 15s. The timeout is activated if you have more that 15s between 2 read() and since connector read stream byte by byte. 300s is valid for http 1.1 connection with keep-alive. I'll commit the patch for 3.3 but with a 15 seconds timeout ;-) Si la fortune vient en dormant, a n'empche pas les emmerdements de venir au rveil. -- Pierre Dac -Original Message- From: Glenn Nielsen [mailto:[EMAIL PROTECTED]] Sent: Wednesday, March 21, 2001 4:14 PM To: [EMAIL PROTECTED] Subject: Re: mod_webapp status? "Pier P. Fumagalli" wrote: jean-frederic clere [EMAIL PROTECTED] wrote: "Eric L. Anderson" wrote: What is the current status of mod_webapp? I have tried building the connector from cvs but the build fails with webapplib. The errors seem to indicate there are some missing source files. wa.c:69: `wa_connections' undeclared (first use in this function) wa.c:69: (Each undeclared identifier is reported only once wa.c:69: for each function it appears in.) wa.c:72: `cb' undeclared (first use in this function) wa.c:73: `wa_callbacks' undeclared (first use in this function) I can not find any trace of an actual definition of "wa_connections" in any of the source files. ? It is in "webapplib/wa_connection.c" -- Eric L. Anderson [EMAIL PROTECTED] I have also problems with mod_webapp. Pier has changed a lot of things, you will have to little. I'm rewriting it using APR... As we speak... Pier (under the snow in Dublin) APR is for Apache 2.0, correct? What about Apache 1.3? What _is_ the status of mod_webapp/WARP, this is a critical componenet for Tocmat 4. Tomcat 4 is useless to me without an Apache connector. Regards, Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | --
RE: http 1.0 timeout patch
I picked 5 minutes because that seemed to be the default timeout for Apache httpd. If I open telnet session to Apache and never enter any data the connection times out after 5 minutes. In Apache this is configured in httpd.conf as # # Timeout: The number of seconds before receives and sends time out. # Timeout 300 Yep, but it's a value for both http 1.0 and 1.1. I really find that 300s is a long period to wait for. I'm waiting for answer for Apache HTTPD gurus and will tell you more later but I'll commit the patch to TC 3.3 with 15s as default and add getter/setter functions to let user set it in server.xml
Re: http 1.0 timeout patch
I'm -1 on the 15 sec. You never know what type of network a client may be traversing. -Casey GOMEZ Henri wrote: Hi, I notice you corrected the patch which is a good thing but settings timeout to 5mn (300s) is a little too high for an http 1.0 connection. The timeout could be as low as 15s. The timeout is activated if you have more that 15s between 2 read() and since connector read stream byte by byte. 300s is valid for http 1.1 connection with keep-alive. I'll commit the patch for 3.3 but with a 15 seconds timeout ;-) Si la fortune vient en dormant, a n'empche pas les emmerdements de venir au rveil. -- Pierre Dac -Original Message- From: Glenn Nielsen [mailto:[EMAIL PROTECTED]] Sent: Wednesday, March 21, 2001 4:14 PM To: [EMAIL PROTECTED] Subject: Re: mod_webapp status? "Pier P. Fumagalli" wrote: jean-frederic clere [EMAIL PROTECTED] wrote: "Eric L. Anderson" wrote: What is the current status of mod_webapp? I have tried building the connector from cvs but the build fails with webapplib. The errors seem to indicate there are some missing source files. wa.c:69: `wa_connections' undeclared (first use in this function) wa.c:69: (Each undeclared identifier is reported only once wa.c:69: for each function it appears in.) wa.c:72: `cb' undeclared (first use in this function) wa.c:73: `wa_callbacks' undeclared (first use in this function) I can not find any trace of an actual definition of "wa_connections" in any of the source files. ? It is in "webapplib/wa_connection.c" -- Eric L. Anderson [EMAIL PROTECTED] I have also problems with mod_webapp. Pier has changed a lot of things, you will have to little. I'm rewriting it using APR... As we speak... Pier (under the snow in Dublin) APR is for Apache 2.0, correct? What about Apache 1.3? What _is_ the status of mod_webapp/WARP, this is a critical componenet for Tocmat 4. Tomcat 4 is useless to me without an Apache connector. Regards, Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | --
Re: http 1.0 timeout patch
What about 33 sec. ? It matches the version :-) ( seriously - does the HTTP spec have any number ? If not, can we use whatever apache is using ? ) In any case - 300s is better than no timeout - and if it's too much we can reduce it later ( and make it configurable anyway ). Costin On Wed, 21 Mar 2001, Casey Lucas wrote: I'm -1 on the 15 sec. You never know what type of network a client may be traversing. -Casey GOMEZ Henri wrote: Hi, I notice you corrected the patch which is a good thing but settings timeout to 5mn (300s) is a little too high for an http 1.0 connection. The timeout could be as low as 15s. The timeout is activated if you have more that 15s between 2 read() and since connector read stream byte by byte. 300s is valid for http 1.1 connection with keep-alive. I'll commit the patch for 3.3 but with a 15 seconds timeout ;-) Si la fortune vient en dormant, a n'empche pas les emmerdements de venir au rveil. -- Pierre Dac -Original Message- From: Glenn Nielsen [mailto:[EMAIL PROTECTED]] Sent: Wednesday, March 21, 2001 4:14 PM To: [EMAIL PROTECTED] Subject: Re: mod_webapp status? "Pier P. Fumagalli" wrote: jean-frederic clere [EMAIL PROTECTED] wrote: "Eric L. Anderson" wrote: What is the current status of mod_webapp? I have tried building the connector from cvs but the build fails with webapplib. The errors seem to indicate there are some missing source files. wa.c:69: `wa_connections' undeclared (first use in this function) wa.c:69: (Each undeclared identifier is reported only once wa.c:69: for each function it appears in.) wa.c:72: `cb' undeclared (first use in this function) wa.c:73: `wa_callbacks' undeclared (first use in this function) I can not find any trace of an actual definition of "wa_connections" in any of the source files. ? It is in "webapplib/wa_connection.c" -- Eric L. Anderson [EMAIL PROTECTED] I have also problems with mod_webapp. Pier has changed a lot of things, you will have to little. I'm rewriting it using APR... As we speak... Pier (under the snow in Dublin) APR is for Apache 2.0, correct? What about Apache 1.3? What _is_ the status of mod_webapp/WARP, this is a critical componenet for Tocmat 4. Tomcat 4 is useless to me without an Apache connector. Regards, Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | --
Re: http 1.0 timeout patch
On Wed, 21 Mar 2001 [EMAIL PROTECTED] wrote: | What about 33 sec. ? It matches the version :-) | | ( seriously - does the HTTP spec have any number ? If not, can we use | whatever apache is using ? ) | | In any case - 300s is better than no timeout - and if it's too much we can | reduce it later ( and make it configurable anyway ). Isn't there an issue with tomcat closing a connection before apache does? At least it seems so to me. If you restart tomcat while the browser is connected to it through apache-mod_jk, then that apache process will use all available CPU right away. I guess this is a bug of some sort, just wanted to mention it, especially now since it seems like you'd want tomcat to close connections before apache does.. Or whatever you're up to! ;) -- Mvh, Endre
RE: http 1.0 timeout patch
What about 33 sec. ? It matches the version :-) ( seriously - does the HTTP spec have any number ? If not, can we use whatever apache is using ? ) In any case - 300s is better than no timeout - and if it's too much we can reduce it later ( and make it configurable anyway ). 300s is really huge number since in http 1.0 connector we read input stream one byte at time. With such timeout, you could let a connection open for more than one hour just to read : GET / HTTP/1.0\r\n So I'll commit the patch with 300s by default but I strongly recommand to adapt this timeout to specific site configuration (intranet, internet) Regards
RE: http 1.0 timeout patch
Isn't there an issue with tomcat closing a connection before apache does? It's not related since we speak here of the native tomcat http connector. At least it seems so to me. If you restart tomcat while the browser is connected to it through apache-mod_jk, then that apache process will use all available CPU right away. I guess this is a bug of some sort, just wanted to mention it, especially now since it seems like you'd want tomcat to close connections before apache does.. Or whatever you're up to! ;) The problem you describe is related to mod_jk and I'm working on a patch (to be released very soon)
