RE: bug? does getRemoteAddr() work in tc3.3-beta 1?

2001-07-26 Thread GOMEZ Henri 

I'm working on the fix, you could assign me the bugs !!!

-Original Message-
From: Mike Anderson [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, July 25, 2001 6:43 PM
To: [EMAIL PROTECTED]
Subject: Re: bug? does getRemoteAddr() work in tc3.3-beta 1?


Clayton,

This does seem to be a bug with the Http10Interceptor (or associated 
classes) :-(  It does work correctly from a webserver :-)

Could you please enter a bug in bugzilla

http://nagoya.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%203

so we can track it for 3.3 release?  I'm sure it's probably a 
fairly easy fix
but I'll have to trace it through the code (unless you wanted to.)

Mike Anderson

 [EMAIL PROTECTED] 07/25/01 09:51AM 
Can someone check this bug? Of all functions to lose temporarily from
version 3.2.2, this one is particularly important to me, as I use the
remote IP address for security issues. 

It's easy to check. Just got to the exampels at localhost:8080/examples
and execute Snoop and check the Remote Host Address for your IP
address.

RE: bug? does getRemoteAddr() work in tc3.3-beta 1?

2001-07-26 Thread GOMEZ Henri 

Corrected in CVS.

hgomez  01/07/26 04:14:11

  Modified:src/share/org/apache/tomcat/modules/server
Http10Interceptor.java
  Log:
  Correct getRemoteAddr() bug in native http 1.0 connector
  Bug report from Clayton Vernon
  
  Revision  ChangesPath
  1.18  +2 -0
jakarta-tomcat/src/share/org/apache/tomcat/modules/server/Http10Interceptor.
java
  
  Index: Http10Interceptor.java
  ===
  RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/modules/server/Http10In
terceptor.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- Http10Interceptor.java2001/06/28 07:29:08 1.17
  +++ Http10Interceptor.java2001/07/26 11:14:11 1.18
  @@ -242,6 +242,8 @@
return;
}
   
  +
this.remoteAddr().setString(socket.getInetAddress().getHostAddress());
  +
// for 0.9, we don't have headers!
if (! protoMB.equals()) {
// all HTTP versions with protocol also have headers

bug? does getRemoteAddr() work in tc3.3-beta 1?

2001-07-25 Thread Vernon, Clayton 

Can someone check this bug? Of all functions to lose temporarily from
version 3.2.2, this one is particularly important to me, as I use the
remote IP address for security issues. 

It's easy to check. Just got to the exampels at localhost:8080/examples
and execute Snoop and check the Remote Host Address for your IP
address.

Re: bug? does getRemoteAddr() work in tc3.3-beta 1?

2001-07-25 Thread Mike Anderson 

Clayton,

This does seem to be a bug with the Http10Interceptor (or associated 
classes) :-(  It does work correctly from a webserver :-)

Could you please enter a bug in bugzilla

http://nagoya.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%203

so we can track it for 3.3 release?  I'm sure it's probably a fairly easy fix
but I'll have to trace it through the code (unless you wanted to.)

Mike Anderson

 [EMAIL PROTECTED] 07/25/01 09:51AM 
Can someone check this bug? Of all functions to lose temporarily from
version 3.2.2, this one is particularly important to me, as I use the
remote IP address for security issues. 

It's easy to check. Just got to the exampels at localhost:8080/examples
and execute Snoop and check the Remote Host Address for your IP
address.