Re: [tor-bugs] #30642 [Core Tor/Tor]: Add an ed25519-identity file to the data directory

2020-05-19 Thread Tor Bug Tracker & Wiki
#30642: Add an ed25519-identity file to the data directory
+
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-relay easy  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  dgoulet |Sponsor:
+

Comment (by teor):

 Replying to [comment:20 dgoulet]:
 > What if we append the ed25519 base64 pubkey to the `fingerprint` file. I
 worry that there will be confusion on "what line should I send you?" when
 someone is asking for a fingerprint. But, also any line should be fine to
 find the relay, maybe that doesn't matter. And I forsee rare occasion
 someone will ask "Oh give me the RSA fingerprint"...

 That will break any tools that read the fingerprint file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

2020-05-19 Thread Tor Bug Tracker & Wiki
#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 `541eb200e06c1c55ab3c8facdfd02a9ae70e` was reviewed as part of the
 review for #33973.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34013 [Applications/Tor Browser]: Bump node version to v10.19

2020-05-19 Thread Tor Bug Tracker & Wiki
#34013: Bump node version to v10.19
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 This one was reviewed as part of the review of #33973.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

2020-05-19 Thread Tor Bug Tracker & Wiki
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by acat):

 Replying to [comment:25 mcs]:
 > One more thing: the patches for #19251 and #19757 are missing from
 acat's 33533+5 branch. They were done as "squash" commits on top of the
 original #30237 patch. Maybe there is already a process we are following
 to pick up such fixes, but I wanted to mention this issue so that the
 patches do not get lost.

 Thanks for the reminder. I was planning (at some point) to start applying
 the changes that came after `6046d1d58280`, which is the last commit I
 used for rebasing. After taking a look at 9.5 branches >= "tor-
 browser-68.5", I think currently these are missing:

 68.5
 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.5.0esr-9.5-1=aed69dc95387429e18b18ad578fb78d4a83d91f2
 squash! Bug 30237: Add v3 onion services client authentication prompt]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.5.0esr-9.5-1=03101bba2cf4a694deec0b7b040d8141f8c7cf20 fixup!
 Bug 23247: Communicating security expectations for .onion]



 68.6
 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.6.0esr-9.5-2=69dfbacfa8b3d6abd6eb5e248fcd24a03c30a962 Bug
 33342: Avoid disconnect search addon error after removal.]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.6.0esr-9.5-1=7306a08365be9212f621b396513352d19549c487 Bug
 28005: Implement .onion alias urlbar rewrites]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.6.0esr-9.5-1=e3b4a8bf4a19cee4838a5216a3ef5af58bea6e62
 squash! Bug 30237: Add v3 onion services client authentication prompt]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.6.0esr-9.5-1=da5513527e50e7f13e3b1c3206ed75ff8fbd76db Bug
 21952: Implement Onion-Location]



 68.7
 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.7.0esr-9.5-1=e09b2deb216910b26f1ade5882d3c3c07af30652 fixup!
 Bug 28005: Implement .onion alias urlbar rewrites]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.7.0esr-9.5-1=dcae22191c42bdb1948a6e55c7c50e0ab97dbf70
 fixup! Bug 23247: Communicating security expectations for .onion]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.7.0esr-9.5-1=5a8128b566fab32fa2d97fe7a1a99e761afe77b0 fixup!
 Bug 10760: Integrate TorButton to TorBrowser core]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.7.0esr-9.5-1=7d0d47db46531a32c88db85323cd771761b8bb5d Revert
 "Bug 30575: Don't allow enterprise policies in Tor Browser"]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.7.0esr-9.5-1=e577d655d2044e3b6636b0bccfbb5bd776148582 Bug
 32418: Allow updates to be disabled via an enterprise policy.]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.7.0esr-9.5-1=0052c74b743756dafa4f3614f559dd8f8d1645c2
 fixup! Bug 28005: Implement .onion alias urlbar rewrites]




 68.8
 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.8.0esr-9.5-1=00f5a4c995a911423e10af5a2bbeceef1ae76be6 Bug
 34196: Update site info URL with the onion name]

 [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-68.8.0esr-9.5-1=052d8a452a92a97b77130e60e28c1c02076d9db3
 fixup! Bug 34196: Update site info URL with the onion name]

 When I start applying these I'll double check with some range-diffs just
 in case I'm missing something between branches. I think I can do this (and
 :comment:24 fixup) either on next rebase (68beta?) or when gk finishes the
 review.

 (BTW, when looking at these I thought [https://gitweb.torproject.org/tor-
 browser.git/commit/?h=tor-
 browser-68.6.0esr-9.5-2=ddef5cd5e970f3e38651e0bb789979d67f74eb2d  Bug
 1626728 - Normalize shutdown. r=perry,jstutte, a=RyanVM] had been backed
 out from central, since that's the chronologically latest commit:
 https://github.com/mozilla/gecko-
 dev/commit/0f9da9eb51280f63b217db92c070ed4456b2fe84. However, there's this
 commit https://github.com/mozilla/gecko-
 dev/commit/064b0f9501ad76802853b43f18e33d8713fd54d3
 which has 1970 (epoch?) date but comes topologically after the backout
 commit. Not sure why this happened, maybe it says something in the bug,
 but I can't see it (sec issue I guess).)

--
Ticket 

Re: [tor-bugs] #34174 [Internal Services/Tor Sysadmin Team]: Update majus errors recipient

2020-05-19 Thread Tor Bug Tracker & Wiki
#34174: Update majus errors recipient
-+-
 Reporter:  antonela |  Owner:  anarcat
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 done. i recommend you somehow simulate a failure to make sure you still
 receive notifications. I can also try to see if we can do that straight
 from nagios if you prefer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34174 [Internal Services/Tor Sysadmin Team]: Update majus errors recipient

2020-05-19 Thread Tor Bug Tracker & Wiki
#34174: Update majus errors recipient
-+-
 Reporter:  antonela |  Owner:  anarcat
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  needs_information => accepted
 * owner:  tpa => anarcat


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

2020-05-19 Thread Tor Bug Tracker & Wiki
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by acat):

 Replying to [comment:24 mcs]:
 > Kathy and I noticed today that there is a bug in the rebased #23247
 patch (5defe271e8919e77267883f8513cf095451fffd2) that causes the Page Info
 window's Security panel to not display all of its content. The root cause
 is that Mozilla removed `hostName` inside `_getSecurityInfo()` within
 browser/base/content/pageinfo/security.js. Here is a fixup patch:
 > {{{
 >  var isBroken = ui.state &
 Ci.nsIWebProgressListener.STATE_IS_BROKEN;
 >  var isMixed =
 >ui.state &
 >(Ci.nsIWebProgressListener.STATE_LOADED_MIXED_ACTIVE_CONTENT |
 >  Ci.nsIWebProgressListener.STATE_LOADED_MIXED_DISPLAY_CONTENT);
 >  var isEV = ui.state &
 Ci.nsIWebProgressListener.STATE_IDENTITY_EV_TOPLEVEL;
 >  var isOnion = false;
 > +const hostName = this.windowInfo.hostName;
 >  if (hostName && hostName.endsWith(".onion")) {
 >isOnion = true;
 >  }
 >
 >  let secInfo = await
 
window.opener.gBrowser.selectedBrowser.browsingContext.currentWindowGlobal.getSecurityInfo();
 >  if (secInfo) {
 >secInfo.QueryInterface(Ci.nsITransportSecurityInfo);
 >let cert = secInfo.serverCert;
 > }}}
 Thanks, that's a nice catch. A simple eslint would have caught this one,
 but unfortunately did not check it this time :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34240 [Internal Services/Tor Sysadmin Team]: Update Metrics CollecTor check to remove Torperf files

2020-05-19 Thread Tor Bug Tracker & Wiki
#34240: Update Metrics CollecTor check to remove Torperf files
-+-
 Reporter:  karsten  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 do you plan on having regular updates of this check? if so, I would work
 more on the deployment mechanisms on our side to make this easier, because
 right now it's a little clunky... but if this is just a one-off thing, it
 wouldn't be worth it...

 anyways, done for now. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34240 [Internal Services/Tor Sysadmin Team]: Update Metrics CollecTor check to remove Torperf files

2020-05-19 Thread Tor Bug Tracker & Wiki
#34240: Update Metrics CollecTor check to remove Torperf files
-+-
 Reporter:  karsten  |  Owner:  anarcat
 Type:  task | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * owner:  tpa => anarcat
 * status:  needs_review => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30642 [Core Tor/Tor]: Add an ed25519-identity file to the data directory

2020-05-19 Thread Tor Bug Tracker & Wiki
#30642: Add an ed25519-identity file to the data directory
+
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-relay easy  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  dgoulet |Sponsor:
+
Changes (by dgoulet):

 * cc: nickm (added)


Comment:

 Ok so this looks great. Works great.

 The only thing I worry is the filename actually. `ed25519-identity` super
 sounds like a "secret key" to me as in the private portion...

 Here are my proposals, not sure what is the best but I also don't want to
 bikeshed this so no strong opinion but this file should really just denote
 the concept of "public" and `ed25519` terminology is _very_ technical and
 probably wont say much to relay operators in general.

 What if we append the ed25519 base64 pubkey to the `fingerprint` file. I
 worry that there will be confusion on "what line should I send you?" when
 someone is asking for a fingerprint. But, also any line should be fine to
 find the relay, maybe that doesn't matter. And I forsee rare occasion
 someone will ask "Oh give me the RSA fingerprint"...

 Creating a second file here, I worry much about confusion and something
 that seems not related to a "relay fingerprint". Because in the end, that
 is just `ed25519_master_id_public_key` file in base64.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33851 [Applications/Tor Browser]: Patch out Parental Controls detection and logging

2020-05-19 Thread Tor Bug Tracker & Wiki
#33851: Patch out Parental Controls detection and logging
--+--
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+--
Changes (by mcs):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202005R
 * status:  assigned => needs_review


Comment:

 It turns out that the only code that assumes that the parental control
 feature is included is that which I mentioned in comment:1. Since we do
 not ship the doh-rollout extension, we can just patch our mozconfig files
 to disable parental controls at build time. Here is a patch:
 https://gitweb.torproject.org/user/brade/tor-browser-
 build.git/commit/?h=bug33851-01=eaf9bbfc8216187c6689360f97478ea0ce2d9724

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33851 [Applications/Tor Browser]: Patch out Parental Controls detection and logging

2020-05-19 Thread Tor Bug Tracker & Wiki
#33851: Patch out Parental Controls detection and logging
--+---
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004  |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by mcs):

 * cc: tbb-team (added)
 * keywords:   => TorBrowserTeam202004
 * owner:  tbb-team => mcs


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

2020-05-19 Thread Tor Bug Tracker & Wiki
#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.35
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Thanks for these patches! And thanks for copying metrics-team; I had not
 seen the earlier updates (oh, Trac...).

 So, I tried out this branch without installing all dependencies via `sudo
 apt install python3-*`, and it starts downloading packages via `pip`. In
 our Java projects we have always avoided using package managers and only
 relied on packages provided by the system. We would give up this principle
 here, but are we sure we want to do that? How are we doing this in other
 Python projects at Tor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

2020-05-19 Thread Tor Bug Tracker & Wiki
#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Low   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:  fixed
 Keywords:  backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34251 [Core Tor/Tor]: Fix edge case handling in Rust protover is supported

2020-05-19 Thread Tor Bug Tracker & Wiki
#34251: Fix edge case handling in Rust protover is supported
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt, rust,|  Actual Points:  0.1
  protover, 042-backport, 043-backport   |
Parent ID:   | Points:  0.5
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by dgoulet):

 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34245 [Core Tor/Tor]: Declare variables in for loops in rend_service_dump_stats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#34245: Declare variables in for loops in rend_service_dump_stats()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34236 [Core Tor/Tor]: Fix spacing in if statement in port_parse_config()

2020-05-19 Thread Tor Bug Tracker & Wiki
#34236: Fix spacing in if statement in port_parse_config()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Fine by me. Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

2020-05-19 Thread Tor Bug Tracker & Wiki
#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Thank you! Looks like CI was unhappy with a minor whitespace issue where
 the types need to go on their own line. I've left a comment on Github.

 Once that is fixed, you can move the ticket back to needs_review and/or
 poke me on IRC.

 Thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33155 [Applications/Tor Browser]: Close cross-origin frame count leak

2020-05-19 Thread Tor Bug Tracker & Wiki
#33155: Close cross-origin frame count leak
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-fingerprinting|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-fingerprinting


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34251 [Core Tor/Tor]: Fix edge case handling in Rust protover is supported

2020-05-19 Thread Tor Bug Tracker & Wiki
#34251: Fix edge case handling in Rust protover is supported
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt, rust,|  Actual Points:  0.1
  protover, 042-backport, 043-backport   |
Parent ID:   | Points:  0.5
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good. We should talk about Rust and backports at an upcoming meeting
 I think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33912 [Internal Services/Tor Sysadmin Team]: migrate pauli to the ganeti cluster

2020-05-19 Thread Tor Bug Tracker & Wiki
#33912: migrate pauli to the ganeti cluster
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:  #32802   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by weasel):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33593 [Circumvention/Snowflake]: Create versions and changelogs for Snowflake pieces

2020-05-19 Thread Tor Bug Tracker & Wiki
#33593: Create versions and changelogs for Snowflake pieces
-+---
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #19409   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by cohosh):

 Thanks for bringing this back up.

 IMO, we are nowhere near being about to move forward on Debian packaging.
 We have too many dependencies that are changing very rapidly. I think we
 should wait and let snowflake development settle down a bit before trying.

 So we can either start using changelogs or decide not to and close this
 ticket. I don't have strong opinions either way. I like the idea of having
 snowflake versions to track major changes but it's not high priority for
 me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

2020-05-19 Thread Tor Bug Tracker & Wiki
#33973: Create fat .aar for geckoview
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Works, and looks good. The output checksum is the same as in v7.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33593 [Circumvention/Snowflake]: Create versions and changelogs for Snowflake pieces

2020-05-19 Thread Tor Bug Tracker & Wiki
#33593: Create versions and changelogs for Snowflake pieces
-+---
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #19409   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by dcf):

 * status:  merge_ready => needs_information


Comment:

 Is the only remaining task under this ticket to write changelogs for the
 two repos? As I understand it, that's a requirement of Debian packaging?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33856 [Applications/Tor Browser]: Set browser.privatebrowsing.forceMediaMemoryCache=true

2020-05-19 Thread Tor Bug Tracker & Wiki
#33856: Set browser.privatebrowsing.forceMediaMemoryCache=true
--+--
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+--
Changes (by mcs):

 * keywords:  TorBrowserTeam202005 => TorBrowserTeam202005R
 * status:  assigned => needs_review


Comment:

 Here is a patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug33856-01=e892c4b9649c2b8c04a87b3d3d7f36700fa47644

 Kathy and I verified that the `media.cache_size` and
 `media.cache_size.cellular` prefs are not used when we force the in-memory
 media cache to be used (so there is no need to change their default
 values).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33856 [Applications/Tor Browser]: Set browser.privatebrowsing.forceMediaMemoryCache=true

2020-05-19 Thread Tor Bug Tracker & Wiki
#33856: Set browser.privatebrowsing.forceMediaMemoryCache=true
--+---
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005  |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by mcs):

 * keywords:   => TorBrowserTeam202005
 * owner:  tbb-team => mcs
 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34124 [Circumvention/Snowflake]: snowflake funktioniert nicht

2020-05-19 Thread Tor Bug Tracker & Wiki
#34124: snowflake funktioniert nicht
-+--
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  user disappeared
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by dcf):

 * status:  needs_information => closed
 * resolution:   => user disappeared


Comment:

 cypherpunks, please reopen the ticket if you have more information to
 provide.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34092 [Circumvention/Snowflake]: Snowflake no longer working on Google Chrome

2020-05-19 Thread Tor Bug Tracker & Wiki
#34092: Snowflake no longer working on Google Chrome
-+---
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by dcf):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34043 [Applications/Tor Browser]: Update snowflake to persist sessions across proxies

2020-05-19 Thread Tor Bug Tracker & Wiki
#34043: Update snowflake to persist sessions across proxies
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm TorBrowserTeam202005R|  Actual Points:
  snowflake turbotunnel  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * keywords:  tbb-rbm TorBrowserTeam202005R snowflake => tbb-rbm
 TorBrowserTeam202005R snowflake turbotunnel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23306 [Core Tor/Tor]: hs: Use the state of a directory connection instead of the HAS_FETCHED purpose

2020-05-19 Thread Tor Bug Tracker & Wiki
#23306: hs: Use the state of a directory connection instead of the HAS_FETCHED
purpose
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #23300   | Points:
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by neel):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23306 [Core Tor/Tor]: hs: Use the state of a directory connection instead of the HAS_FETCHED purpose

2020-05-19 Thread Tor Bug Tracker & Wiki
#23306: hs: Use the state of a directory connection instead of the HAS_FETCHED
purpose
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #23300   | Points:
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by neel):

 * cc: neel (removed)
 * owner:  neel => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

2020-05-19 Thread Tor Bug Tracker & Wiki
#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.35
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * cc: metrics-team (added)
 * actualpoints:  0.25 => 0.35


Comment:

 Adding my 0.1 points to yours, and CC'ing metrics-team!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27105 [Applications/Quality Assurance and Testing]: Fix Tor Browser testsuite

2020-05-19 Thread Tor Bug Tracker & Wiki
#27105: Fix Tor Browser testsuite
-+-
 Reporter:  boklm|  Owner:  acat
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-testsuite,   |  Actual Points:
  TorBrowserTeam202005R, ReleaseTrainMigration   |
Parent ID:  #33654   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by acat):

 I had to fix (again) the bridge test, due to the used bridge not being
 available anymore. This new bridge should keep working for some time.
 Revised in ​https://github.com/acatarineu/tor-browser-bundle-
 testsuite/commits/27105+1.

 Besides, this tor-browser-build branch should be used for testing:
 https://github.com/acatarineu/tor-browser-build/commits/33533+7. I removed
 the `clang9` bump (as it was not working and I had wrongly added it) and
 cherry-picked the patch for #34242.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34084 [Core Tor/Tor]: HSv3: Bug at setup_intro_circ_auth_key at ../src/feature/hs/hs_client.c:739

2020-05-19 Thread Tor Bug Tracker & Wiki
#34084: HSv3: Bug at setup_intro_circ_auth_key at 
../src/feature/hs/hs_client.c:739
--+
 Reporter:  s7r   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.4.0-alpha-dev
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:  #34082| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33848 [Applications/Tor Browser]: Disable Enhanced Tracking Protection (assuming we want it disabled)

2020-05-19 Thread Tor Bug Tracker & Wiki
#33848: Disable Enhanced Tracking Protection (assuming we want it disabled)
--+--
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+--
Changes (by mcs):

 * status:  assigned => needs_review
 * keywords:  TorBrowserTeam202005 => TorBrowserTeam202005R


Comment:

 Here is a fixup for #26345 to remove the about:protections page:

 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug33848-01=29c0d86e25dfbb5d84eed205de0b366e6dbe5ff4

 There are some remaining references to about:protections in the browser
 code, but users should not be able to reach those codepaths (e.g., the ETP
 panel that is hidden in Tor Browser includes a "Show Report" link).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34171 [Core Tor/Tor]: possible single circuit maximum transfer rate regression in 0.3.4

2020-05-19 Thread Tor Bug Tracker & Wiki
#34171: possible single circuit maximum transfer rate regression in 0.3.4
--+---
 Reporter:  starlight |  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.10
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by dgoulet):

 I've seen very rare occurrence of circuit cell queue hitting their maximum
 on all my relays (there is a log in the heartbeat).

 Also, that cell limit is 6.25 times the actual enforced limits by the flow
 control protocol (SENDME) so I don't see how that can affect performance
 :S...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33396 [Metrics/Onionperf]: Automatically compress Onionperf logs

2020-05-19 Thread Tor Bug Tracker & Wiki
#33396: Automatically compress Onionperf logs
-+
 Reporter:  acute|  Owner:  metrics-team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  metrics-team-roadmap-2020Q1  |  Actual Points:  0.3
Parent ID:  #33319   | Points:  1
 Reviewer:   |Sponsor:  Sponsor59-must
-+
Changes (by gaba):

 * sponsor:   => Sponsor59-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by neel):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33927 [Applications/Tor Browser]: Add tor-browser-build project for fenix

2020-05-19 Thread Tor Bug Tracker & Wiki
#33927: Add tor-browser-build project for fenix
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 For starters I've an updated patch which makes some improvements and is
 aligned to the geckoview we are currently building in #33973 to make
 testing the integration easier: `bug_33927_v4`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33927_v4=a8b7186849e1115541e60dfbff0636ea47bf9677).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by neel):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34245 [Core Tor/Tor]: Declare variables in for loops in rend_service_dump_stats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#34245: Declare variables in for loops in rend_service_dump_stats()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by dgoulet):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23306 [Core Tor/Tor]: hs: Use the state of a directory connection instead of the HAS_FETCHED purpose

2020-05-19 Thread Tor Bug Tracker & Wiki
#23306: hs: Use the state of a directory connection instead of the HAS_FETCHED
purpose
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #23300   | Points:
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by neel):

 * cc: neel (added)
 * owner:  (none) => neel
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

2020-05-19 Thread Tor Bug Tracker & Wiki
#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32822 [Core Tor/Tor]: Make authorities add their own IPv6 address to trusted dir servers

2020-05-19 Thread Tor Bug Tracker & Wiki
#32822: Make authorities add their own IPv6 address to trusted dir servers
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, 044-should  |  Actual Points:  0.4
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 This is fine by me tbh. I think we could merge this. Ideal world is unit
 tests but there is just so much we can do I guess.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

2020-05-19 Thread Tor Bug Tracker & Wiki
#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:  0.1
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29659 [Core Tor/Torsocks]: WARNING torsocks[6254]: [syscall] Unsupported syscall number 39. Denying the call (in tsocks_syscall() at syscall.c:605)

2020-05-19 Thread Tor Bug Tracker & Wiki
#29659: WARNING torsocks[6254]: [syscall] Unsupported syscall number 39. Denying
the call (in tsocks_syscall() at syscall.c:605)
---+--
 Reporter:  tu8367 |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor/Torsocks  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by dgoulet):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the suggestion. I pushed my changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33848 [Applications/Tor Browser]: Disable Enhanced Tracking Protection (assuming we want it disabled)

2020-05-19 Thread Tor Bug Tracker & Wiki
#33848: Disable Enhanced Tracking Protection (assuming we want it disabled)
--+---
 Reporter:  pospeselr |  Owner:  mcs
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005  |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by mcs):

 * keywords:   => TorBrowserTeam202005
 * owner:  tbb-team => mcs
 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

2020-05-19 Thread Tor Bug Tracker & Wiki
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by mcs):

 One more thing: the patches for #19251 and #19757 are missing from acat's
 33533+5 branch. They were done as "squash" commits on top of the original
 #30237 patch. Maybe there is already a process we are following to pick up
 such fixes, but I wanted to mention this issue so that the patches do not
 get lost.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34246 [Core Tor/Tor]: Add a link to the formatted architecture docs in src/mainpage.md

2020-05-19 Thread Tor Bug Tracker & Wiki
#34246: Add a link to the formatted architecture docs in src/mainpage.md
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  044-should, easy, doc  |  Actual Points:  .1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Whoops, that was referring to the wrong ticket.

 I merged the fix to master as 400bc46d838e83.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34255 [Core Tor/Tor]: Doxygen warnings on 0.4.3

2020-05-19 Thread Tor Bug Tracker & Wiki
#34255: Doxygen warnings on 0.4.3
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34255 [Core Tor/Tor]: Doxygen warnings on 0.4.3

2020-05-19 Thread Tor Bug Tracker & Wiki
#34255: Doxygen warnings on 0.4.3
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 PR @ https://github.com/torproject/tor/pull/1900 looks fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34238 [Core Tor/Tor]: Space out some function calls in parse_short_policy()

2020-05-19 Thread Tor Bug Tracker & Wiki
#34238: Space out some function calls in parse_short_policy()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34255 [Core Tor/Tor]: Doxygen warnings on 0.4.3

2020-05-19 Thread Tor Bug Tracker & Wiki
#34255: Doxygen warnings on 0.4.3
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 PR at https://github.com/nmathewson/tor/pull/new/ticket34255_043 .

 Branch is `ticket34255_043`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34255 [Core Tor/Tor]: Doxygen warnings on 0.4.3

2020-05-19 Thread Tor Bug Tracker & Wiki
#34255: Doxygen warnings on 0.4.3
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34246 [Core Tor/Tor]: Add a link to the formatted architecture docs in src/mainpage.md

2020-05-19 Thread Tor Bug Tracker & Wiki
#34246: Add a link to the formatted architecture docs in src/mainpage.md
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  044-should, easy, doc  |  Actual Points:  .1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  new => needs_review
 * actualpoints:   => .1


Comment:

 Requesting quick review. `ticket34255_043` with PR at
 https://github.com/torproject/tor/pull/1900

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34255 [Core Tor/Tor]: Doxygen warnings on 0.4.3

2020-05-19 Thread Tor Bug Tracker & Wiki
#34255: Doxygen warnings on 0.4.3
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:  .1|   Reviewer:
  Sponsor:|
--+
 There are some doxygen warnings about unclosed or unbalanced groups.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34236 [Core Tor/Tor]: Fix spacing in if statement in port_parse_config()

2020-05-19 Thread Tor Bug Tracker & Wiki
#34236: Fix spacing in if statement in port_parse_config()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Looks nice! Almost there. Did some reviews on the PR! Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-05-19 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.7
 Severity:  Major | Resolution:  duplicate
 Keywords:  backport? |  Actual Points:
Parent ID:  #33087| Points:
 Reviewer:|Sponsor:
--+

Comment (by tla):

 Yay! Thank you so much for your help!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34254 [Core Tor/Tor]: Jenkins fails with hs_service.c:3118:3: error: comparison of unsigned expression < 0 is always false

2020-05-19 Thread Tor Bug Tracker & Wiki
#34254: Jenkins fails with hs_service.c:3118:3: error: comparison of unsigned
expression < 0 is always false
--+
 Reporter:  asn   |  Owner:  asn, dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.2
Parent ID:| Points:
 Reviewer:  asn, dgoulet  |Sponsor:
--+
Description changed by asn:

Old description:

> {{{
> 11:23:10 ../tor/src/feature/hs/hs_service.c: In function
> 'log_cant_upload_desc':
> 11:23:10 ../tor/src/feature/hs/hs_service.c:3118:3: error: comparison of
> unsigned expression < 0 is always false [-Werror=type-limits]
> }}}
>
> https://jenkins.torproject.org/job/tor-ci-windows-master/659/consoleFull

New description:

 {{{
 11:23:10 ../tor/src/feature/hs/hs_service.c: In function
 'log_cant_upload_desc':
 11:23:10 ../tor/src/feature/hs/hs_service.c:3118:3: error: comparison of
 unsigned expression < 0 is always false [-Werror=type-limits]
 }}}

 https://jenkins.torproject.org/job/tor-ci-windows-master/659/consoleFull

 Seems to be a by-product of #33400.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34254 [Core Tor/Tor]: Jenkins fails with hs_service.c:3118:3: error: comparison of unsigned expression < 0 is always false

2020-05-19 Thread Tor Bug Tracker & Wiki
#34254: Jenkins fails with hs_service.c:3118:3: error: comparison of unsigned
expression < 0 is always false
--+
 Reporter:  asn   |  Owner:  asn, dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-hs
Actual Points:  0.2   |  Parent ID:
   Points:|   Reviewer:  asn, dgoulet
  Sponsor:|
--+
 {{{
 11:23:10 ../tor/src/feature/hs/hs_service.c: In function
 'log_cant_upload_desc':
 11:23:10 ../tor/src/feature/hs/hs_service.c:3118:3: error: comparison of
 unsigned expression < 0 is always false [-Werror=type-limits]
 }}}

 https://jenkins.torproject.org/job/tor-ci-windows-master/659/consoleFull

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34251 [Core Tor/Tor]: Fix edge case handling in Rust protover is supported

2020-05-19 Thread Tor Bug Tracker & Wiki
#34251: Fix edge case handling in Rust protover is supported
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt, rust,|  Actual Points:  0.1
  protover, 042-backport, 043-backport   |
Parent ID:   | Points:  0.5
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-19 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

2020-05-19 Thread Tor Bug Tracker & Wiki
#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:  0.1
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by asn):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33227 [Core Tor/Tor]: Prop 311: 5.1. Update Tor Spec Relay Subprotocols

2020-05-19 Thread Tor Bug Tracker & Wiki
#33227: Prop 311: 5.1. Update Tor Spec Relay Subprotocols
+
 Reporter:  teor|  Owner:  teor
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  prop311, ipv6, torspec  |  Actual Points:  0.1
Parent ID:  #33222  | Points:  0.1
 Reviewer:  nickm   |Sponsor:  Sponsor55-must
+
Changes (by asn):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

2020-05-19 Thread Tor Bug Tracker & Wiki
#33973: Create fat .aar for geckoview
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  merge_ready => needs_review


Comment:

 Replying to [comment:31 ahf]:
 > The proposed changes seems to work. I have been able to build it
 reproducible on two different machines and learned about a hw issue on a
 third machine. It sounds like I got the same results as GeKo, which is
 good. I have not tried to build with _v8, but only with _v7, but it seems
 like _v8 is fixing the one issue I had with 'container-image'.
 >
 > The perl/bash and yaml all seems good to me.

 Thanks! I realized we should probably not just copy the .aar file over but
 the .pom one as well so the dependencies are visible, too. I pushed a
 fixup commit to `bug_33973_v8` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33973_v8=7133b4d9b32008b1c5063681960888fdab1fe498)
 for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33914 [Internal Services/Tor Sysadmin Team]: migrate weissii to the ganeti cluster

2020-05-19 Thread Tor Bug Tracker & Wiki
#33914: migrate weissii to the ganeti cluster
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:  #32802   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by weasel):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 I have migrated weissii to the ganeti cluster.

 As weissii should not be on the public internet, this involved a few
 network related things.

 * We have a new (hetzner) vswitch, exposed as vlan 4002.  This is a
 private/internal network that carries rfc1918 traffic between instances,
 also accross nodes.  It is known to ganeti as `gnt-fsn-int30-137`.

 * Weissii is exclusively on that network.
 * Rouyi is on that network on a secondary network interface (eth1).
 * weissii needs to access the internet, both for security updates and git
 fetch git etc.  For thus purpose I set up a tiny VM, `nat-
 fsn-01.torproject.org`, that serves as a nat gw between `gnt-fsn-
 int30-137` and the internet.  It is fully configured via puppet, no manual
 local configuration.  It also does DNS for hosts on the internal network.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs