Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2019-06-07 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe, 033-backport-unreached,   |
  reviewer-was-teor-20190422 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Hello71):

 well the code was committed, and as far as I can tell it just doesn't
 work. I haven't had time to figure out why, and I doubt I'll have time in
 the near to medium term future.

 I think the systemd service doesn't require any (more) fixing. as far as I
 know, the TimeoutStopSec is sufficient in all distributions now. the
 problem is just that if you increase ShutdownWaitLength (in tor), you may
 need to also increase TimeoutStopSec in systemd. this is really a nice-to-
 have though; the code can be removed and this ticket closed if nobody
 wants to work on it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2019-06-06 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe, 033-backport-unreached,   |
  reviewer-was-teor-20190422 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Is this still a bug? Maybe somebody should open a Debian bug, and the
 systemd script there can get fixed?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2019-02-28 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: 0.3.4.x-final => Tor: unspecified


Comment:

 This ticket still needs changes and testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-12-11 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by Hello71):

 * status:  needs_information => needs_revision


Comment:

 unfortunately it seems that it does not actually work, I still get tor
 killed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-11-07 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by Hello71):

 * status:  merge_ready => needs_information


Comment:

 I use Arch which includes devel files in the standard package. It turns
 out, though, that I either accidentally removed the patch from my local
 list or never included it in the first place, so it would seem that I
 haven't tested this at all. I may have assumed that Travis had systemd-
 devel already. Patch is already applied though, and seems like too much
 work to back it out, so let's say test it for a little while and see if
 anyone complains. :P

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-11-07 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:14 nickm]:
 > Hm. Apparently this broke with systemd-devel installed.
 212bd9778b5c249f02f8fbdc1e8ccbe4c108f03a made it work for me, but I'm a
 little worried about how tested this could be.

 I didn't test with libsystemd-devel, and travis doesn't have libsystemd-
 devel installed.

 So I guess that just leaves any testing that Hello71 did.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-11-07 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by nickm):

 Hm. Apparently this broke with systemd-devel installed.
 212bd9778b5c249f02f8fbdc1e8ccbe4c108f03a made it work for me, but I'm a
 little worried about how tested this could be.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-11-06 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 Merging to 0.3.5, marking for possible backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-11-04 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 I pushed three small commits to your pull request to fix these issues:

 1. If tor's systemd TimeoutStopSec is less than the ShutdownWaitLength,
 plus the time it takes tor to shut down after its ShutdownWaitLength has
 expired, then systemd may terminate Tor abnormally. Let's explain that
 better in the changes file.

 2. Tor's systemd file in dist/ has a TimeoutSec of 30, which is too low:
 https://gitweb.torproject.org/tor.git/tree/contrib/dist/tor.service.in
 Debian has a TimeoutStopSec of 60, which seems like a good change to
 upstream:
 
https://gitweb.torproject.org/debian/tor.git/tree/debian/systemd/tor@default.service

 3. This is a bugfix, so it should get a bugfix changes file

 See my branch ticket28113-029 for the squash and cherry-pick to 0.2.9:
 https://github.com/torproject/tor/pull/474

 This branch merges cleanly all the way to master:
 https://github.com/torproject/tor/pull/475
 (GitHub's pull requests can't do this merge, but git can.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-31 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thanks for these changes.

 Let's fix to changes file, and add an extra comment explaining the default
 systemd timeout.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-31 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by Hello71):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-30 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by Hello71):

 Replying to [comment:6 teor]:
 > Please see my comments on the pull request.

 Replied there.

 > We should test this pull request in an alpha before backporting it.

 Agreed.

 Replying to [comment:7 teor]:
 > (It's pretty safe, because it only extends the systemd timeout. But we
 should check it doesn't extend the timeout too much.)

 As I explained on the PR, it doesn't matter too much if the number sent is
 too high, since systemd will continue immediately as long as tor actually
 exits before the timeout (it's a maximum limit, not a minimum or exact).
 If tor doesn't exit expeditiously, then that's a bug in tor. IMO it's
 worth trying to work around the (still hypothetical AFAIK) bug by waiting
 a little longer, rather than crashing and almost certainly corrupting
 cache files. Also, I figure nobody will care excessively if they set
 ShutdownWaitLength to 2 minutes and tor actually takes 2 minutes 15
 seconds to quit, as long as we don't accidentally make it 20 minutes (but
 again, that would require another separate bug in tor).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-30 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by nickm):

 I'd recommend that if we do backport, we backport no farther than 0.3.5.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-29 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 (It's pretty safe, because it only extends the systemd timeout. But we
 should check it doesn't extend the timeout too much.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-29 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Please see my comments on the pull request.

 We should test this pull request in an alpha before backporting it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-24 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by dgoulet):

 Failing Travis. Easy fix, on the changes file:

 {{{
 ./changes/ticket28113:
 Missing subcategory on 'Minor features'
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-19 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by Hello71):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-18 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 I reviewed the pull request: a minor refactor and a comment would be
 helpful.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-18 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
-+-
 Reporter:  Hello71  |  Owner:  Hello71
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-systemd, 029-backport-maybe, |  Actual Points:
  033-backport-maybe, 034-backport-maybe, 035|
  -backport-maybe|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:   =>
 tor-systemd, 029-backport-maybe, 033-backport-maybe, 034-backport-
 maybe, 035-backport-maybe
 * version:  Tor: unspecified => Tor: 0.2.6.2-alpha
 * milestone:   => Tor: 0.3.5.x-final


Comment:

 This has been a bug since we introduced systemd support in 0.2.6.2-alpha
 (or possibly 0.2.6.3-alpha).

 It's a simple patch, so I think we might want to backport it. Tenatively
 assigning it to 0.3.5.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-18 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
--+--
 Reporter:  Hello71   |  Owner:  Hello71
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by Hello71):

 * status:  assigned => needs_review


Comment:

 https://github.com/torproject/tor/pull/417

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28113 [Core Tor/Tor]: notify systemd if shutdown will be longer than 30 seconds

2018-10-18 Thread Tor Bug Tracker & Wiki
#28113: notify systemd if shutdown will be longer than 30 seconds
--+--
 Reporter:  Hello71   |  Owner:  Hello71
 Type:  defect| Status:  assigned
 Priority:  Medium|  Component:  Core Tor/Tor
  Version:  Tor: unspecified  |   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 currently systemd just kills tor if the user sets ShutdownWaitLength more
 than 30 seconds. we should tell systemd not to kill tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs