Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Reviewed as part of #33559.

 Hashes at https://anubis.0x90.dk/~ahf/android-tb.txt

 Patch looks good.

 It's interesting to review these patches that contain modified patches :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:12 gk]:
 > One thing I still need to think about is:
 > {{{
 > There are some combinations of libraries, or tools and libraries, that
 are incompatible, or can lead to bugs. One such incompatibility is
 compiling with a version of the Android support libraries that is not the
 latest version (or in particular, a version lower than your
 targetSdkVersion).
 > }}}
 > (found at: https://stackoverflow.com/questions/53094716/implementation-
 com-android-supportappcompat-v728-0-0)
 >
 > We do set the `targetSdkVersion` to `29` while we have
 > {{{
 > dependencies {
 > implementation project(':universal')
 > implementation 'net.freehaven.tor.control:jtorctl:0.2'
 > implementation 'org.slf4j:slf4j-api:1.7.25'
 > implementation 'org.slf4j:slf4j-android:1.7.25'
 > implementation 'com.android.support:appcompat-v7:28.0.0'
 > testImplementation 'junit:junit:4.12'
 > androidTestImplementation project(':android_tor_installer')
 > androidTestImplementation 'org.torproject:tor-android-
 binary:0.3.5.8-rc-v2'
 > androidTestImplementation 'com.android.support.test:runner:1.0.1'
 > androidTestImplementation 'com.android.support.test.espresso
 :espresso-core:3.0.1'
 > }
 > }}}
 > I wonder whether that's indeed as problematic for us as the quote
 suggests...

 As a data point: Mozilla seems to be on 28.0.0 for the support library
 while targeting Android 29.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 One thing I still need to think about is:
 {{{
 There are some combinations of libraries, or tools and libraries, that are
 incompatible, or can lead to bugs. One such incompatibility is compiling
 with a version of the Android support libraries that is not the latest
 version (or in particular, a version lower than your targetSdkVersion).
 }}}
 (found at: https://stackoverflow.com/questions/53094716/implementation-
 com-android-supportappcompat-v728-0-0)

 We do set the `targetSdkVersion` to `29` while we have
 {{{
 dependencies {
 implementation project(':universal')
 implementation 'net.freehaven.tor.control:jtorctl:0.2'
 implementation 'org.slf4j:slf4j-api:1.7.25'
 implementation 'org.slf4j:slf4j-android:1.7.25'
 implementation 'com.android.support:appcompat-v7:28.0.0'
 testImplementation 'junit:junit:4.12'
 androidTestImplementation project(':android_tor_installer')
 androidTestImplementation 'org.torproject:tor-android-
 binary:0.3.5.8-rc-v2'
 androidTestImplementation 'com.android.support.test:runner:1.0.1'
 androidTestImplementation 'com.android.support.test.espresso:espresso-
 core:3.0.1'
 }
 }}}
 I wonder whether that's indeed as problematic for us as the quote
 suggests...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-tema (removed)
 * cc: tbb-team (added)
 * status:  assigned => needs_review
 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202005
 => tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202005R


Comment:

 `bug_33558_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33558_v3=496918096fce1c5b23c28727e77f69c530251781)
 has an updated patch, building on top of sisbell's, for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:  sysrqb => sysrqb, ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * owner:  tbb-team => gk
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-tema (added)
 * reviewer:  gk => sysrqb
 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R => tbb-mobile, tbb-
 rbm, GeorgKoppen202005, TorBrowserTeam202005


Comment:

 There is now a `var/android-plugin` which is never used, though. Just
 remove it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  TorBrowserTeam202005R  |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android, TorBrowserTeam202005R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:  .5
  TorBrowserTeam202005R  |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android, TorBrowserTeam202004R => tbb-mobile,
 Android, TorBrowserTeam202005R
 * reviewer:   => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:  .5
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android => tbb-mobile, Android,
 TorBrowserTeam202004R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:  .5
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+
Changes (by sisbell):

 * cc: eighthave (removed)
 * status:  new => needs_review
 * actualpoints:   => .5


Comment:

 I made changes to TOPL project to use latest gradle and android
 dependencies. It required removing the publishing and jar sources section
 (which we don't use). The ttb tor-onion-proxy library uses this branched
 version of TOPL and upgrades gradle version. Regenerated gradle
 dependencies.

 https://github.com/sisbell/tor-browser-build/commits/bug-33558

 https://github.com/sisbell/Tor_Onion_Proxy_Library/commits/bug-33558

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+
Changes (by pili):

 * sponsor:   => Sponsor58-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 We need to upgrade android toolchain to support fenix. This requires
 update to TOPL build as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs