Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  user
 Keywords:  tbb-disk-leak, tbb-usability-|  disappeared
  website, TorBrowserTeam201903R |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Great that you closed it as `user disappeared`, meaning that you couldn't
 fix it. But it's a weird reason to close confirmed bugs anyway.
 What the steps do you need when you have the source code? Memory limit
 means that you get the error with your patch, opening no more than 4 media
 instances on a 1 GB VM. The error instead of no cache, because
 > I also have no idea what cypherpunks meant by that comment. The original
 Mozilla code also returns nullptr on **failure**, so we're not changing
 any logic in that regard. It's even documented in the function comment:
 ​https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l152
 nullptr if **initialization** failed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  user
 Keywords:  tbb-disk-leak, tbb-usability-|  disappeared
  website, TorBrowserTeam201903R |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => user disappeared


Comment:

 Okay, I am closing this again. Please leave it that way. No need to
 clutter this bug with further. If you happen to find _steps to reproduce_
 we can try out, open a new ticket with all the necessary information (like
 operating system, Tor Browser version and the actual steps to reproduce
 you bug).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  user disappeared =>


Comment:

 Replying to [comment:40 gk]:
 > Replying to [comment:39 cypherpunks]:
 > > `user disappeared`, but the bug didn't.
 >
 > Great! Please answer the questions in comment:37 when reopening the bug.
 Think about `media.memory_caches_combined_limit_pc_sysmem`. Sucks that you
 can't explain mozillians that they should fix their bug.
 > So gar we still don't know how we can investigate it.
 Who are we?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  user
 Keywords:  tbb-disk-leak, tbb-usability-|  disappeared
  website, TorBrowserTeam201903R |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => user disappeared


Comment:

 Replying to [comment:39 cypherpunks]:
 > `user disappeared`, but the bug didn't.

 Great! Please answer the questions in comment:37 when reopening the bug.
 So gar we still don't know how we can investigate it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  user disappeared =>


Comment:

 `user disappeared`, but the bug didn't.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  user
 Keywords:  tbb-disk-leak, tbb-usability-|  disappeared
  website, TorBrowserTeam201903R |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  reopened => needs_information


Comment:

 Replying to [comment:36 cypherpunks]:
 > This sucks as expected. But the case that you can't explain to mozilla
 what the bug is, and they wontfixed you, is more hilarious. :)
 > When the cache dies, if you smart enough, you can get:
 > {{{
 > All candidate resources failed to load. Media load paused.
 > TypeError: this.video.error is null videocontrols.xml:1277:1
 > NS_ERROR_NOT_AVAILABLE:   videocontrols.xml:391
 > }}}

 How can we reproduce that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This sucks as expected. But the case that you can't explain to mozilla
 what the bug is, and they wontfixed you, is more hilarious. :)
 When the cache dies, if you smart enough, you can get:
 {{{
 All candidate resources failed to load. Media load paused.
 TypeError: this.video.error is null videocontrols.xml:1277:1
 NS_ERROR_NOT_AVAILABLE:   videocontrols.xml:391
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1532486 and provided
 edited patch without the tor-browser specific pref.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Commit b7c1e2820087e60d019b57d25042a27dc83adc4a on `tor-
 browser-60.5.1esr-8.5-1` has the patch.

 pospeselr: Can you file an upstream ticket and get the patch upstreamed?

 QZw2aBQoPyuEVXYVlBps: thanks again for analyzing the bugs and providing a
 patch, really appreciated!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Don't waste time. Open a ticket on Bugzilla.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201903R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:  tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902 =>
 tbb-disk-leak, tbb-usability-website, TorBrowserTeam201903R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by QZw2aBQoPyuEVXYVlBps):

 * Attachment "MemoryMediaCache5.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Here's the patch with the parentheses fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902R =>
 tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902
 * status:  needs_review => needs_revision


Comment:

 Setting to `needs_revision` to address mcs's concern. We are close! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:28 mcs]:
 >
 > The patch looks good to us. We are a little concerned about portions of
 comment:25, especially the part about `return nullptr;` (because we are do
 not understand cyperpunks' point).
 I also have no idea what cypherpunks meant by that comment. The original
 Mozilla code also returns nullptr on failure, so we're not changing any
 logic in that regard. It's even documented in the function comment:
 https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l152

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:27 gk]:
 > mcs/brade can you have a (second) look on the latest patch? Thanks!

 The patch looks good to us. We are a little concerned about portions of
 comment:25, especially the part about `return nullptr;` (because we are do
 not understand cyperpunks' point).

 It might be worthwhile to add parens around the second part of the `if`
 expression; with the patched code, clang emits a `-Wlogical-op-
 parentheses` warning due to potential confusion when reading the code. The
 following would be better:
 {{{
   if (aIsPrivateBrowsing ||
   (aContentLength > 0 &&
aContentLength <= int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) *
 1024)) {
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 mcs/brade can you have a (second) look on the latest patch? Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:  tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902 =>
 tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:24 QZw2aBQoPyuEVXYVlBps]:
 > Replying to [comment:23 cypherpunks]:
 > > If you want a more sane solution and not "sane" - do not touch that
 Mozilla's `if` code block, it's not broken. Add your own `if
 (aIsPrivateBrowsing)` after it. Never use `int64_t` for something with
 `size` in its name. Never use `int64_t()` in C++. Use spellchecker. What
 happens when you `return nullptr;`?
 > We either use their `if` or copy their code to our own if, I think
 reusing their `if` is better than code duplication.
 That's because you don't see the difference.
 > We want the same exact logic to handle either case, so it makes sense to
 use that block.
 And we don't.
 > `int64_t` is what Mozilla uses, I'm just following their code.
 Heh.
 > I tested what happened on `nullptr` return above, see comment 10.
 Exactly. Now think what's wrong.
 > The next patch includes the preference changes, I removed the
 `media.cache_size` preference override
 Good.
 > and added one for `media.memory_cache_max_size`, doubling the default
 value.
 Not good.

 If you want to write a more sane code, you can try to pass Mozilla's
 review on Bugzilla.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by QZw2aBQoPyuEVXYVlBps):

 * Attachment "MemoryMediaCache4.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:23 cypherpunks]:
 > If you want a more sane solution and not "sane" - do not touch that
 Mozilla's `if` code block, it's not broken. Add your own `if
 (aIsPrivateBrowsing)` after it. Never use `int64_t` for something with
 `size` in its name. Never use `int64_t()` in C++. Use spellchecker. What
 happens when you `return nullptr;`?
 We either use their if or copy their code to our own if, I think reusing
 their if is better than code duplication. We want to same exact logic to
 handle either case, so it makes sense to use that block. `int64_t` is what
 Mozilla uses, I'm just following their code. I tested what happened on
 `nullptr` return above, see comment 10.

 The next patch includes the preference changes, I removed the
 `media.cache_size` preference override and added one for
 `media.memory_cache_max_size`, doubling the default value.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 If you want a more sane solution and not "sane" - do not touch that
 Mozilla's `if` code block, it's not broken. Add your own `if
 (aIsPrivateBrowsing)` after it. Never use `int64_t` for something with
 `size` in its name. Never use `int64_t()` in C++. Use spellchecker. What
 happens when you `return nullptr;`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:20 QZw2aBQoPyuEVXYVlBps]:
 > Replying to [comment:19 gk]:
 > > You have
 > > {{{
 > >  if (aContentLength < 0) {
 > > }}}
 > > in your patch but looking at the original code I think we should take
 care of the case here as well that `aContentLength` is `0`.
 > If you look here: https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l153
 > You'll see that `aContentLength` is `-1` if it is unknown, so an
 `aContentLength` of `0` means that's what the server actually sent.

 Yes. I am a bit wary that we are subtly changing the logic here: right now
 in Firefox esr60 a memory-backed media cache is only used if
 `aContentLength` is larger than `0` and less or equal than the max size as
 determined by a pref. Your patch keeps the latter requirement. However, it
 changes the former exposing the memory cache creation to a content length
 of `0`. While this seems okay for now I am a little bit worried that
 Mozilla changes something under the hood which is not affecting them as
 they have the `>` check while we don't exclude the case where
 `aContentLength` is `0`. So, I guess without making your patch even more
 complicated, one way forward would be to take it in the alpha and try to
 upstream it at the same time, so we are sure we won't get surprised by our
 logic change. That's fine with me.

 > > Additionally, I think we should go back to the default size for
 `media.cache_size` so that users outside of private browsing mode get the
 usual behavior (right now they would still be affected by this bug without
 resetting the pref). (https://gitweb.torproject.org/tor-
 browser.git/tree/browser/app/profile/000-tor-browser.js?h=tor-
 browser-60.5.0esr-8.5-1 is the file to look at)
 > I agree with this, I was going to mention it but it slipped my mind. I
 also suggested above that the default of `media.memory_cache_max_size`
 should be increased to handle buffering longer media content in memory,
 what do you think about this?

 We could do that. But I'd be cautious here. Maybe let's pick twice as the
 default for now? That should not be worse than the status quo and we
 essentially have not heard about the bug you reported before. So, the
 problem might not be that widespread.

 > > QZw2aBQoPyuEVXYVlBps: Thanks for this find and a patch, really
 appreciated. We are close here. Do you want to fix the remaining things up
 or should we? How should we credit you? (I am fine crediting
 QZw2aBQoPyuEVXYVlBps in the commit message :) )
 > It's a little time consuming for me to test my code since compiling
 takes awhile, but since there's only a few changes, I think I should be
 fine completing it.
 > You can credit either "QZw2aBQoPyuEVXYVlBps" or "anonymous", this is
 simply a throwaway account because I wasn't able to get the cypherpunks
 account to work.

 Okay, let's use "cyperpunk" then. :)

 Thanks for you work here and testing, much appreciated. If you could
 change the pref I am happy to merge the patch and test it wider in an
 upcoming alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Here is the result of loading a media file where the server gives a "0" as
 the content length:

 {{{
 [45086:Main Thread]: D/MemoryBlockCache 0x7f6f9075b340 MemoryBlockCache()
 MEMORYBLOCKCACHE_ERRORS='InitUnderuse'
 [45086:Main Thread]: D/MemoryBlockCache 0x7f6f9075b340 Init()
 [45086:Main Thread]: D/MediaCache GetMediaCache(0) -> Memory MediaCache
 0x7f6f99e24870
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 opened
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 feeding reader
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 DataStarted: 0
 aLoadID=1 aLength=0
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 at end of stream
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 at end of stream
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 at end of stream
 [Child 45086, MediaPlayback #1] WARNING: Decoder=7f6f92aa1e00
 state=DECODING_METADATA Decode metadata failed, shutting down decoder:
 file /var/tmp/build/firefox-
 4d0f9fa5fdd5/dom/media/MediaDecoderStateMachine.cpp, line 340
 [Child 45086, MediaPlayback #1] WARNING: Decoder=7f6f92aa1e00 Decode
 error: NS_ERROR_DOM_MEDIA_METADATA_ERR (0x806e0006) - static
 mozilla::MP4Metadata::ResultAndByteBuffer
 mozilla::MP4Metadata::Metadata(mozilla::ByteStream*): Cannot parse
 metadata: file /var/tmp/build/firefox-
 4d0f9fa5fdd5/dom/media/MediaDecoderStateMachine.cpp, line 3118
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 at end of stream
 [45086:MediaCache]: D/MediaCache Stream 0x7f6fa8857040 closed
 [45086:Main Thread]: D/MediaCache
 MediaCacheStream::~MediaCacheStream(this=0x7f6fa8857040)
 MEDIACACHESTREAM_LENGTH_KB=0
 [45086:Main Thread]: D/MediaCache ~MediaCache(Memory-backed MediaCache
 0x7f6f99e24870)
 [45086:Main Thread]: D/MemoryBlockCache 0x7f6f9075b340 ~MemoryBlockCache()
 - destroying buffer of size 0; combined sizes now 0
 }}}

 The end result for the user is a "No video with supported format and MIME
 type found." error message on the video. This result seems sane to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:19 gk]:
 > You have
 > {{{
 >  if (aContentLength < 0) {
 > }}}
 > in your patch but looking at the original code I think we should take
 care of the case here as well that `aContentLength` is `0`.
 If you look here: https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l153
 You'll see that `aContentLength` is `-1` if it is unknown, so an
 `aContentLength` of `0` means that's what the server actually sent.
 I can test whether this plays nicely with the current code or not, but if
 not, what do you suggest we do here?

 > Additionally, I think we should go back to the default size for
 `media.cache_size` so that users outside of private browsing mode get the
 usual behavior (right now they would still be affected by this bug without
 resetting the pref). (https://gitweb.torproject.org/tor-
 browser.git/tree/browser/app/profile/000-tor-browser.js?h=tor-
 browser-60.5.0esr-8.5-1 is the file to look at)
 I agree with this, I was going to mention it but it slipped my mind. I
 also suggested above that the default of `media.memory_cache_max_size`
 should be increased to handle buffering longer media content in memory,
 what do you think about this?
 > QZw2aBQoPyuEVXYVlBps: Thanks for this find and a patch, really
 appreciated. We are close here. Do you want to fix the remaining things up
 or should we? How should we credit you? (I am fine crediting
 QZw2aBQoPyuEVXYVlBps in the commit message :) )
 It's a little time consuming for me to test my code since compiling takes
 awhile, but since there's only a few changes, I think I should be fine
 completing it.
 You can credit either "QZw2aBQoPyuEVXYVlBps" or "anonymous", this is
 simply a throwaway account because I wasn't able to get the cypherpunks
 account to work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201902  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902R =>
 tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902
 * status:  needs_review => needs_revision


Comment:

 You have
 {{{
  if (aContentLength < 0) {
 }}}
 in your patch but looking at the original code I think we should take care
 of the case here as well that `aContentLength` is `0`.

 Additionally, I think we should go back to the default size for
 `media.cache_size` so that users outside of private browsing mode get the
 usual behavior (right now they would still be affected by this bug without
 resetting the pref). (https://gitweb.torproject.org/tor-
 browser.git/tree/browser/app/profile/000-tor-browser.js?h=tor-
 browser-60.5.0esr-8.5-1 is the file to look at)

 QZw2aBQoPyuEVXYVlBps: Thanks for this find and a patch, really
 appreciated. We are close here. Do you want to fix the remaining things up
 or should we? How should we credit you? (I am fine crediting
 QZw2aBQoPyuEVXYVlBps in the commit message :) )

 pospeselr: Could you open a ticket at Mozilla's bug tracker with the
 attached patch and find out whether Mozilla would take it (even somewhat
 modified)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:16 pospeselr]:
 > This patch looks good to me. You confirmed this issue also works in
 vanilla Firefox right? We should probably open up a issue on bugzilla and
 see about getting this uplifted.
 The behavior is present in vanilla Firefox, though it might be considered
 "working as intended" since in vanilla Firefox you probably wouldn't be
 expected to set the file cache size to 0 like we do.

 There is indeed a comment in the source that points towards this behavior
 being known: "The cache can also be overflowing because the
 media.cache_size preference was reduced." (https://hg.mozilla.org/releases
 /mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l1162)

 This patch doesn't change the underlying behavior of the file backed
 cache, so the odd loading behavior would still be encountered if you
 forced the Tor Browser out of private browsing.

 It might still be worth pushing this patch upstream though, since in my
 eyes it makes sense to never write to disk in private browsing mode, even
 in vanilla Firefox.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 This patch looks good to me. You confirmed this issue also works in
 vanilla Firefox right? We should probably open up a issue on bugzilla and
 see about getting this uplifted.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: mcs, brade, pospeselr (added)
 * keywords:  tbb-disk-leak, tbb-usability-website, TorBrowserTeam201901 =>
 tbb-disk-leak, tbb-usability-website, TorBrowserTeam201901R


Comment:

 Thanks, setting this up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by QZw2aBQoPyuEVXYVlBps):

 * Attachment "MemoryMediaCache3.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Alright, I poked around the code a little more and I think I found a
 decent solution.

 I changed {{{GetMediaCache}}} to add a {{{aIsPrivateBrowsing}}} parameter.
 As far as I can tell, {{{GetMediaCache}}} is only ever called from
 {{{MediaCacheStream::Init}}}, so I just changed the call there to pass in
 the stream's {{{mIsPrivateBrowing}}} member.

 The rest of the code is pretty similar to the previous patch, but the new
 logic only applies in private browsing mode now. I added and updated a few
 comments in the code to reflect the new behavior as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:11 gk]:
 > I  have not looked close at the patch but what we should do in my
 opinion is checking whether we are in private browsing mode and use only
 the memory cache in that case and otherwise we leave the logic as is. Does
 that sound reasonable?
 That seems reasonable, I'm not sure what the best way to check if we're in
 private browsing mode from that section of code is though.

 I can see from the source each media stream in the cache exposes
 {{{mIsPrivateBrowsing}}}, but I'm pretty sure there will be no streams in
 the cache during initialization, so that doesn't do us much good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I  have not looked close at the patch but what we should do in my opinion
 is checking whether we are in private browsing mode and use only the
 memory cache in that case and otherwise we leave the logic as is. Does
 that sound reasonable?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by QZw2aBQoPyuEVXYVlBps):

 * Attachment "MemoryMediaCache2.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 I've gone ahead and made another patch with the above changes.

 In testing, it seems to work well, I believe this is a more "sane"
 solution than changing the global cache to a MemoryBlockCache.

 I monitored the debug logs for FileBlockCache and MemoryBlockCache, I
 never observed any FileBlockCache code being called, which is good.

 I also observed all the allocated MemoryBlockCache objects being properly
 destroyed after navigating away from pages with media content, so it seems
 this method doesn't leak any memory.

 I also tested what happens when the cache fails to initialize, it simply
 results it a media error ("No video with supported format and MIME type
 found.").
 I think this is probably acceptable since the only case where this would
 happen is if the user is extremely low on memory or has hit the
 {{{media.memory_caches_combined_limit_kb}}}, which shouldn't happen unless
 they have a large amount of tabs open containing media content. There's
 also really no alternative to it if we're going to be avoiding the disk
 cache at all costs.

 If this patch is used, I would also suggest bumping the default value of
 {{{media.memory_cache_max_size}}} to something slightly higher, as using
 this method also limits the amount of read-ahead buffer that can be stored
 for larger content, which can be slightly detrimental to playback compared
 to the file-backed cache. I would suggest at least doubling it to
 {{{16384}}}, {{{32768}}} is what I tested with though and it worked well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:5 gk]:
 > Thanks for the patch! I wonder what happens if the video is larger than
 the available memory cache (or the latter is already filled up with other
 cached stuff). Does the browser crash then? Or become unusable otherwise?
 I tested using the video in the main ticket post, which is ~30mb (the
 MemoryCache was hardcoded to 8192000 bytes in the patch).

 As far as I can tell, it ''seems'' to properly reuse old memory once it
 hits the cache limit, I could play through the whole video without
 anything unusual happening, if I seeked back to the beginning after
 playing through it, it would make a new HTTP request to fetch that data,
 so it seemed to have properly fallen out of the cache.

 One thing that should be looked into is if the MemoryBlockCache can safely
 be used concurrently by multiple streams (as a "single global cache" like
 the FileBlockCache is), if you look at the code here:
 https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l737

 You'll see that normally, a new MemoryBlockCache object is created for
 each resource below {{{media.memory_cache_max_size}}}, they don't seem to
 be reused across multiple resources like the FileBlockCache is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:8 cypherpunks2]:
 > Replying to [comment:4 QZw2aBQoPyuEVXYVlBps]:
 > > {{{RefPtr bc = new MemoryBlockCache(8192000);}}}
 > {{{RefPtr bc = new MemoryBlockCache(0);}}}
 > https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MemoryBlockCache.cpp#l182
 I don't think the code you linked does what you think it does. If you look
 right before that, you'll see an early return on {{{aContentLength ==
 0}}}. {{{initialLength}}} is based on the size of the internal buffer, so
 that code in the if statement will simply be executed on the first write
 to the cache rather than on initialization, it doesn't change the
 situation very much.

 Another option I thought of while reading the MediaCache source is that
 was can probably get by with just slightly modifying the current code that
 creates MemoryBlockCache objects.
 https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l737

 If you would humor some code, this would be replacing the if statement
 from that linked line:
 {{{
 // The size we will initialize the cache to
 int64_t cacheBytes = 0;

 if (aContentLength <= 0) {
   // Unknown content length, give it a max sized buffer just to be sure.
   cacheBytes = int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024
 } else {
   // If the content length is known, we'll try to initialize a cache that
 will hold it, but only up to the max cache size
   cacheBytes = std::min(aContentLength,
 int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024)
 }

 RefPtr bc = new MemoryBlockCache(cacheBytes);
 nsresult rv = bc->Init();
 if (NS_SUCCEEDED(rv)) {
   RefPtr mc = new MediaCache(bc);
   LOG("GetMediaCache(%" PRIi64 ") -> Memory MediaCache %p",
 aContentLength,
 mc.get());
   return mc;
 }

 // Init() failed...
 // In the MediaCache source, there is a fallback to a file-backed cache
 beyond this point.
 // We don't want that, so something else will have to be done here.
 // In the origial code, the function will return a nullptr (gMediaCache)
 if both caches fail to initialize, but I'm not sure what the consequences
 of that are.
 }}}

 This code would create a new MemoryBlockCache for every request, doing
 away with the content size limit, and instead replacing it with a maximum
 cache size (based on the {{{media.memory_cache_max_size}}} preference).
 This should work since my previous test showed that an undersized cache
 will properly reuse memory as needed.
 I think it should also play nicely with whatever built in mechanism is in
 place to manage the total in-memory cache size, since it's pretty much
 using the original code with just minor modification.

 Let me know what you think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW there are media.memory_cache* preferences as well, which might be
 useful here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks2):

 Replying to [comment:4 QZw2aBQoPyuEVXYVlBps]:
 > {{{RefPtr bc = new MemoryBlockCache(8192000);}}}
 {{{RefPtr bc = new MemoryBlockCache(0);}}}
 https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MemoryBlockCache.cpp#l182

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-disk-leak, tbb-usability-website => tbb-disk-leak, tbb-
 usability-website, TorBrowserTeam201901


Comment:

 Thanks for the patch! I wonder what happens if the video is larger than
 the available memory cache (or the latter is already filled up with other
 cached stuff). Does the browser crash then? Or become unusable otherwise?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by QZw2aBQoPyuEVXYVlBps):

 * Attachment "memorymediacache.patch" added.

 FileBlockCache -> MemoryBlockCache

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by QZw2aBQoPyuEVXYVlBps):

 As a preliminary test, I replaced https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l758
 with
 {{{RefPtr bc = new MemoryBlockCache(8192000);}}}

 This seems to work correctly from my brief testing and fixes both bugs in
 this ticket (the odd media loading behavior and the disk leaking).

 I have only done a small amount of investigation into how the media
 caching code works, so it's likely this requires a closer look, but I
 believe it's a decent starting point.

 I will attached a patch if anyone else would like to test for themselves
 or look into this further.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks3):

 * keywords:   => tbb-disk-leak, tbb-usability-website


Comment:

 https://hg.mozilla.org/releases/mozilla-
 
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l1159

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
--+--
 Reporter:  QZw2aBQoPyuEVXYVlBps  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by QZw2aBQoPyuEVXYVlBps):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
--+--
 Reporter:  QZw2aBQoPyuEVXYVlBps  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by QZw2aBQoPyuEVXYVlBps):

 I've narrowed down the criteria for when this bug happens. It will trigger
 for any video played using the built in media player ({{{}}}) that's filesize is either greater than
 {{{media.memory_cache_max_size}}} (default 8192kb) or unknown (no
 {{{Content-Length}}}).

 I've also established that setting {{{media.cache_size}}} to 0 does
 ''not'' eliminate writing the cache to disk, it simply limits the cache
 file on disk to a few hundred kilobytes and constantly cycles it. Due to
 the nature of how physical storage mediums work, this is likely to be
 functionally equivalent to writing the entire cache to disk without all
 the nonsense inbetween.

 You can observe this yourself with the following command: {{{inotifywait
 -me modify,create,delete,move -r /tmp/ | grep mozilla}}}
 If you open the link in the first post in Tor Browser, you should start
 seeing mozilla temporary files being written to, this is the disk-backed
 MediaCache.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs