[Tracker-discuss] [issue663] Add user to nosy list when PR is attached to issue
New submission from Berker Peksag : Currently, I'm getting this email when I've submitted a PR: -- keywords: +patch pull_requests: +8502 stage: -> patch review I think it would be nice if we could try to add the user to nosy list when attaching a PR to an issue. -- assignedto: berker.peksag messages: 3536 nosy: berker.peksag, ezio.melotti priority: feature status: unread title: Add user to nosy list when PR is attached to issue ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue663> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue660] Find a new bug in Python 3
Berker Peksag added the comment: > In windows, we always give a path using '\' and python 3 can correctly dispose > it just as we using '/' in Linux. But if you offer > a path in windows with a '\' followed as 'r'. Everyting will goes wrong. You need to use raw strings to avoid this. Replace "C:\Program Files (x86)\Graphviz2.38\lib\release\lib" with r"C:\Program Files (x86)\Graphviz2.38\lib\release\lib" See https://blog.lerner.co.il/avoiding-windows-backslash-problems-with-pythons-raw-strings/ for more details about raw strings. This tracker is for issues with bugs.python.org. Please use Stack Overflow or python-list to ask usage questions. -- assignedto: abarnert -> nosy: +berker.peksag status: unread -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue660> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue657] PyGILState_Release FatalError[auto-releasing thread-state, but no thread-state for this thread]
Berker Peksag added the comment: Thanks for the report, but this is not the correct place to report such issues. Please use https://bugs.python.org/ instead. Also, I'd first try getting help on python-list (https://mail.python.org/mailman/listinfo/python-list) or stackoverflow.com as this looks like a problem in the application, not in Python. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue657> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue644] 'Random Issue' Button isn't working
Berker Peksag added the comment: Thanks for the update, John. For future readers, here's a link to the discussion on the roundup-devel list: https://sourceforge.net/p/roundup/mailman/roundup-devel/thread/20180708014103.75EE34C0A5C%40itserver6.localdomain/ ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue644> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue387] Need OpenID login for this tracker
Berker Peksag added the comment: I don't think it's worth to add OpenID login since the level of traffic and active users are pretty low here. -- nosy: +berker.peksag status: unread -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue387> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue156] Have a Core Bug Chaser Create a Bug Reporting Screencast
Berker Peksag added the comment: After 11 years, I think the better place to discuss this is the core-workflow list. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue156> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue404] Personal comment rating
Berker Peksag added the comment: I agree with Serhiy. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue404> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue485] Autoclosing Rietveld issue
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: unread -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue485> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue554] Add special mark to Rietvelds emails
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue554> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue517] Issue Tracker crashes when replying to patch review
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue517> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue382] Bad CC on review
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue382> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue424] Rietveld: AssertionError when trying to reply to comments
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue424> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue435] Rietveld Code Review Tool bugs
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue435> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue432] Rietveld traceback
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue432> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue434] ProgrammingError while deleting patch set
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue434> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue365] No issue exists with that id
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue365> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue439] Email notifictations not received for rietveld review
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue439> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue484] AttributeError 'NoneType' object has no attribute 'issue' when replying to issue
Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue484> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue645] Searching for open bugs sets the button to all
Berker Peksag added the comment: Applied in https://hg.python.org/tracker/python-dev/rev/9c6cedab723d Thanks for the review, Nick. -- status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue645> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue654] Add triager icon
Berker Peksag added the comment: Ezio has just deployed 9363c06cda40 and confirmed that the bug is fixed. Closing as 'resolved' again. -- status: in-progress -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue654> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue654] Add triager icon
Berker Peksag added the comment: Applied issue654_followup.diff in https://hg.python.org/tracker/python-dev/rev/9363c06cda40 ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue654> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue624] bpo emails contain useless non-github pull_request number - users want a link to actual github PR
Berker Peksag added the comment: I just noticed that I probably need to update the clean_ok_message() function in pydevutils.py to remove pull_requests. ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue624> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue645] Searching for open bugs sets the button to all
Berker Peksag added the comment: Good catch, Nick. Fixed in issue645_v2.diff. Thanks! ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue645> ___diff --git a/html/page.html b/html/page.html --- a/html/page.html +++ b/html/page.html @@ -42,20 +42,21 @@ status_all string:-1,1,2,3; open all ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue645] Searching for open bugs sets the button to all
Berker Peksag added the comment: Here's a patch to fix this issue. -- nosy: +berker.peksag, ezio.melotti status: unread -> chatting ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue645> ___diff --git a/html/page.html b/html/page.html --- a/html/page.html +++ b/html/page.html @@ -42,20 +42,21 @@ status_all string:-1,1,2,3; open all ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue603] update the SSL certificate
Berker Peksag added the comment: > * The server supports only older protocols, but not the current best TLS 1.2. > Grade capped to C. There is an open issue for this item: issue 578 I'm not sure whether we should close that as a duplicate of this one. -- nosy: +berker.peksag ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue603> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue654] Add triager icon
Berker Peksag added the comment: Ezio gave his LGTM on #python-dev and I just applied in https://hg.python.org/tracker/python-dev/rev/aac421fdfffb -- status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue654> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue654] Add triager icon
Berker Peksag added the comment:
Addressed Ezio's review comments in issue654_v2.diff.
--
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue654>
___diff --git a/extensions/pydevutils.py b/extensions/pydevutils.py
--- a/extensions/pydevutils.py
+++ b/extensions/pydevutils.py
@@ -16,16 +16,20 @@ def is_history_ok(request):
# currently not used
return True
def is_coordinator(request):
user = request.client.userid
db = request.client.db
return 'Coordinator' in db.user.get(user, 'roles')
+def is_triager(request, userid):
+db = request.client.db
+return 'Developer' in db.user.get(userid, 'roles')
+
def clean_ok_message(ok_message):
"""Remove nosy_count and message_count from the ok_message."""
pattern = '\s*(?:nosy|message)_count,|,\s*(?:nosy|message)_count(?=
edited)'
return ''.join(re.sub(pattern, '', line) for line in ok_message) + ''
def issueid_and_action_from_class(cls):
"""
@@ -86,13 +90,14 @@ class RandomIssueAction(Action):
rand = random.Random()
url = self.db.config.TRACKER_WEB + 'issue' + rand.choice(issue_ids)
raise Redirect(url)
def init(instance):
instance.registerUtil('is_history_ok', is_history_ok)
instance.registerUtil('is_coordinator', is_coordinator)
+instance.registerUtil('is_triager', is_triager)
instance.registerUtil('clean_ok_message', clean_ok_message)
instance.registerUtil('issueid_and_action_from_class',
issueid_and_action_from_class)
instance.registerUtil('clas_as_json', clas_as_json)
instance.registerAction('random', RandomIssueAction)
diff --git a/html/issue.item.html b/html/issue.item.html
--- a/html/issue.item.html
+++ b/html/issue.item.html
@@ -358,16 +358,18 @@
replace="author_name" />
()
*
+
Date:
diff --git a/html/triager.png b/html/triager.png
new file mode 100644
index
..0bcdca6e48e75017037e837b0d6fba8662769fd6
GIT binary patch
literal 477
zc$@*<0V4j1P)Px#0%A)?L;(MXkIcUS000SaNLh0L01FcU01FcV0GgZ_7bV*G`2jT_<7CIt-
z7&3tX00Ci1L_t(2`VkhM(PAxz8gu2ZEPiW0@k5CZ)wex)fRn<_BmKB&{|U
zCLw|RfdmUvNK#mcl{OM9kqd_=ogkXn92N)SNp^0(nQv3<-Wg}Qd7gKsn2568Y-iI}
z_he)u>l-Tw1`rPfn^~(X9wRuGn8X$Hp`a|I7>WmIP%GvMyj#^NAIYX9Qt^z;LXD;?PuzHnhaDi<6%P~p4|^b&{`YU6Th9$8)M+Gx
z{OxZ0>#u8+ob2H7gV%;(Fq|W`ncgF++tY*58V8ymP)#dwCxl=?}8F
z|H+H;^V+>Akd@GY(>;0-js}nDU$zY8YAeqR1^%2Y9&7Q>8|J(Y;G6
zkdlIz;EL5xX$d(Ux+psQMQ={pnHb99Y5OgnzodBbXdvJiXM!___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue644] 'Random Issue' Button isn't working
Berker Peksag added the comment: Implemented Nick's suggestion in https://hg.python.org/tracker/python-dev/rev/ad6158d8414f ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue644> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue644] 'Random Issue' Button isn't working
Berker Peksag added the comment: Ah, I've definitely missed the "You can instantiate your own instances of Random to get generators that don’t share state." part. Thanks! ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue644> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue644] 'Random Issue' Button isn't working
Berker Peksag added the comment: Thank you again for taking a look at this, John. I didn't think about using random.Random() to be honest, thank you Nick! Is there a reason why random.Random() is undocumented in the random module documentation? ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue644> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue593] Small improvements to issue.item.html
Berker Peksag added the comment: > Ezio's suggestion in msg3197 is much better than mine. I will open a new > issue when I have a patch. I've opened issue654. ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue593> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue654] Add triager icon
New submission from Berker Peksag :
Here's patch that implements Ezio's suggestion in msg3197.
--
files: add_triager_icon.diff
messages: 3461
nosy: berker.peksag, ezio.melotti, r.david.murray
priority: feature
status: unread
title: Add triager icon
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue654>
___diff --git a/extensions/pydevutils.py b/extensions/pydevutils.py
--- a/extensions/pydevutils.py
+++ b/extensions/pydevutils.py
@@ -16,16 +16,20 @@ def is_history_ok(request):
# currently not used
return True
def is_coordinator(request):
user = request.client.userid
db = request.client.db
return 'Coordinator' in db.user.get(user, 'roles')
+def is_triager(request, userid):
+db = request.client.db
+return 'Developer' in db.user.get(userid, 'roles')
+
def clean_ok_message(ok_message):
"""Remove nosy_count and message_count from the ok_message."""
pattern = '\s*(?:nosy|message)_count,|,\s*(?:nosy|message)_count(?=
edited)'
return ''.join(re.sub(pattern, '', line) for line in ok_message) + ''
def issueid_and_action_from_class(cls):
"""
@@ -86,13 +90,14 @@ class RandomIssueAction(Action):
random.seed()
url = self.db.config.TRACKER_WEB + 'issue' + random.choice(issue_ids)
raise Redirect(url)
def init(instance):
instance.registerUtil('is_history_ok', is_history_ok)
instance.registerUtil('is_coordinator', is_coordinator)
+instance.registerUtil('is_triager', is_triager)
instance.registerUtil('clean_ok_message', clean_ok_message)
instance.registerUtil('issueid_and_action_from_class',
issueid_and_action_from_class)
instance.registerUtil('clas_as_json', clas_as_json)
instance.registerAction('random', RandomIssueAction)
diff --git a/html/issue.item.html b/html/issue.item.html
--- a/html/issue.item.html
+++ b/html/issue.item.html
@@ -358,16 +358,19 @@
replace="author_name" />
()
*
+
Date:
diff --git a/html/triager.png b/html/triager.png
new file mode 100644
index
..0bcdca6e48e75017037e837b0d6fba8662769fd6
GIT binary patch
literal 477
zc$@*<0V4j1P)Px#0%A)?L;(MXkIcUS000SaNLh0L01FcU01FcV0GgZ_7bV*G`2jT_<7CIt-
z7&3tX00Ci1L_t(2`VkhM(PAxz8gu2ZEPiW0@k5CZ)wex)fRn<_BmKB&{|U
zCLw|RfdmUvNK#mcl{OM9kqd_=ogkXn92N)SNp^0(nQv3<-Wg}Qd7gKsn2568Y-iI}
z_he)u>l-Tw1`rPfn^~(X9wRuGn8X$Hp`a|I7>WmIP%GvMyj#^NAIYX9Qt^z;LXD;?PuzHnhaDi<6%P~p4|^b&{`YU6Th9$8)M+Gx
z{OxZ0>#u8+ob2H7gV%;(Fq|W`ncgF++tY*58V8ymP)#dwCxl=?}8F
z|H+H;^V+>Akd@GY(>;0-js}nDU$zY8YAeqR1^%2Y9&7Q>8|J(Y;G6
zkdlIz;EL5xX$d(Ux+psQMQ={pnHb99Y5OgnzodBbXdvJiXM!___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue599] Strip content when replying to an issue via email
Berker Peksag added the comment: We can use https://github.com/zapier/email-reply-parser to solve this issue. -- nosy: +ezio.melotti status: unread -> chatting ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue599> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue593] Small improvements to issue.item.html
Berker Peksag added the comment: > 1. Add a 't' mark to mark our triagers Ezio's suggestion in msg3197 is much better than mine. I will open a new issue when I have a patch. > 2. List only core developers in the 'assigned to' field It seems too late to change this one. Other core developers already using it with non-core developers. I dropped this idea. > 3. Fix style of the 'Submit Changes' button This seems like the most uncontroversial part of the patch. Applied in https://hg.python.org/tracker/python-dev/rev/0f6adc6f3e55 Here's a screenshot: https://www.dropbox.com/s/y9v00j88240e5p1/bpo.png?dl=0 Closing this one as 'resolved'. -- status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue593> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added
Berker Peksag added the comment: This has already been deployed. Closing as 'resolved'. -- status: chatting -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue615> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue644] 'Random Issue' Button isn't working
Berker Peksag added the comment: Ezio has just deployed 9e1d65b4927c and I've confirmed that it works on bugs.python.org. Closing as 'resolved'. Thanks for the report, Cheryl. -- status: testing -> resolved ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue644> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue644] 'Random Issue' Button isn't working
Berker Peksag added the comment: I've just committed John's suggested approach in https://hg.python.org/tracker/python-dev/rev/9e1d65b4927c but it needs to be deployed by bugs.p.o maintainers. Thank you, again! > I'll keep poking at it to try to figure out why random seems to be > losing state, but I am stumped here. Did you get a chance to look at what was wrong on Roundup's side? -- status: chatting -> testing ___ PSF Meta Tracker <http://psf.upfronthosting.co.za/roundup/meta/issue644> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue649] Intermittent SSL signature issues
Berker Peksag <berker.pek...@gmail.com> added the comment: We may need to set custom rules for caching if we serve bugs.p.o behind Fastly since data needs to be fresh all the time. Otherwise, we would need to purge cache everytime we touch an issue. -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue649> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue634] Only link PR to the bpo that is in the PR title, not the body
Berker Peksag <berker.pek...@gmail.com> added the comment: I agree with Mariatta. We should just look for the PR title. As a fallback, we can check the body if we can't find an issue number in the title. -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue634> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added
Berker Peksag added the comment:
Here's the second patch.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue615>
___diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -195,17 +195,23 @@ class Event(object):
# create a new link
if not title:
title = ""
if not status:
status = ""
newpr = self.db.pull_request.create(number=prid,
title=title.encode('utf-8'), status=status.encode('utf-8'))
prs.append(newpr)
-self.db.issue.set(id, pull_requests=prs)
+patch_keyword = self.db.keyword.lookup('patch')
+keywords = self.db.issue.get(id, 'keywords')
+if patch_keyword not in keywords:
+keywords.append(patch_keyword)
+self.db.issue.set(id, pull_requests=prs,
+ stage=self.db.stage.lookup('patch review'),
+ keywords=keywords)
self.db.commit()
def handle_update(self, prid, title, status, issue_ids):
"""
Helper method for updating GitHub pull request.
"""
# update handles only title changes, for now
if not title:
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue636] 'patch' keyword not being set for PR-only issues
Berker Peksag added the comment: By the way, I can implement this in http://psf.upfronthosting.co.za/roundup/meta/issue615 -- nosy: +berker.peksag status: unread -> chatting ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue636> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue631] Planet Python, https and rendering of the site.
Berker Peksag added the comment: https://github.com/python/planet is probably the better place to report 404 errors. -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue631> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o
Berker Peksag added the comment: I agree with Ned. Thanks, Ezio! ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue613> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue619] Use author's name if committer is set to GitHub on commit notifications
Berker Peksag added the comment: Next time please let me push my own patches. If you have comments please left them in the issue first. Doing your own thing on my patches without even try to communicate is a bit rude. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue619> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o
Berker Peksag added the comment: I think you need to be an administrator on that repo to see the payloads. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue613> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue619] Use author's name if committer is set to GitHub on commit notifications
Berker Peksag added the comment:
Here is a patch.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue619>
___diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -395,19 +395,23 @@ class Push(Event):
for match in matches:
data = match.groupdict()
# check for duplicated issue numbers in the same commit msg
if data['issue_id'] in messages:
continue
close = bool(data.get('verb'))
author=commit.get('author', {}).get('name', '')
committer=commit.get('committer', {}).get('name', '')
-author_line = committer
-if author != committer:
-author_line = u"{} ({})".format(committer, author)
+# sometimes the committer name can be set to 'GitHub' (see #619)
+if committer != u'GitHub':
+author_line = committer
+if author != committer:
+author_line = u"{} ({})".format(committer, author)
+else:
+author_line = author
messages[data['issue_id']] = (COMMENT_TEMPLATE.format(
author=author_line,
branch=branch,
changeset_id=commit.get('id', ''),
changeset_url=commit.get('url', ''),
commit_msg=description.splitlines()[0],
), close)
return messages
diff --git a/test/data/pushevent6.txt b/test/data/pushevent6.txt
new file mode 100644
--- /dev/null
+++ b/test/data/pushevent6.txt
@@ -0,0 +1,11 @@
+POST /python-dev/pull_request HTTP/1.1
+Host: 3ab1787e.ngrok.io
+Accept: */*
+User-Agent: GitHub-Hookshot/6b02022
+X-GitHub-Delivery: 2076d100-0054-11e7-9584-1096a01ee5f0
+X-GitHub-Event: push
+content-type: application/json
+X-Hub-Signature: sha1=f7557283b2cb821aafcbb5b7f44001c237795c96
+Content-Length: 8426
+
+{"ref":"refs/heads/3.6","before":"21ce65aa67f0dc63002ab0a5fb21ef921cf5279e","after":"9d07aceedabcdc9826489f8b9ba056283bb3","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/21ce65aa67f0...9d07aceedabc","commits":[{"id":"9d07aceedabcdc9826489f8b9ba056283bb3","tree_id":"bad6e533cdf6cdf15f9a6f5cda466e52e54d57b4","distinct":true,"message":"bpo-1:
Mention coverage.py in trace module documentation (GH-435)\n\n(cherry picked
from commit
5dfccb06dc513ae67fac5fee66356ad58a4de170)","timestamp":"2017-03-03T12:58:17-08:00","url":"https://github.com/python/cpython/commit/9d07aceedabcdc9826489f8b9ba056283bb3","author":{"name":"Brett
Cannon","email":"brettcan...@users.noreply.github.com","username":"brettcannon"},"committer":{"name":"GitHub","email":"nore...@github.com","username":"web-flow"},"added":[],"removed":[],"modified":["Doc/library/trace.rst"]}],"head_commit":{"id":"9d07aceedabcdc9826489f8b9ba056283b
b3","tree_id":"bad6e533cdf6cdf15f9a6f5cda466e52e54d57b4","distinct":true,"message":"bpo-1:
Mention coverage.py in trace module documentation (GH-435)\n\n(cherry picked
from commit
5dfccb06dc513ae67fac5fee66356ad58a4de170)","timestamp":"2017-03-03T12:58:17-08:00","url":"https://github.com/python/cpython/commit/9d07aceedabcdc9826489f8b9ba056283bb3","author":{"name":"Brett
Cannon","email":"brettcan...@users.noreply.github.com","username":"brettcannon"},"committer":{"name":"GitHub","email":"nore...@github.com","username":"web-flow"},"added":[],"removed":[],"modified":["Doc/library/trace.rst"]},"repository":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"name":"python","email":"","login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url
[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o
Berker Peksag added the comment:
I converted Brett's payload example to a test case and I couldn't be able to
create a failing test case. Here is a patch with a test.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue613>
___diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -41,20 +41,21 @@ class GitHubHandler:
def dispatch(self):
try:
self.verify_request()
self.validate_webhook_secret()
self.extract()
except (Unauthorised, MethodNotAllowed,
UnsupportedMediaType, Reject) as err:
+logging.error(err, exc_info=True)
raise
except Exception as err:
logging.error(err, exc_info=True)
-raise Reject()
+raise Reject(err)
def extract(self):
"""
This method is responsible for extracting information from GitHub event
and decide what to do with it more. Currently it knows how to handle
pull requests and comments.
"""
event = self.get_event()
@@ -77,18 +78,19 @@ class GitHubHandler:
"""
Validates request signature against SECRET_KEY environment variable.
This verification is based on HMAC hex digest calculated from the sent
payload. The value of SECRET_KEY should be exactly the same as the one
configured in GitHub webhook secret field.
"""
key = os.environ.get('SECRET_KEY')
if key is None:
-logging.error('Missing SECRET_KEY environment variable set!')
-raise Reject()
+msg = 'Missing SECRET_KEY environment variable set!'
+logging.error(msg)
+raise Reject(msg)
data = str(self.form.value)
signature = 'sha1=' + hmac.new(key, data,
hashlib.sha1).hexdigest()
header_signature = self.request.headers.get('X-Hub-Signature', '')
if not compare_digest(signature, header_signature):
raise Unauthorised()
def verify_request(self):
@@ -97,17 +99,19 @@ class GitHubHandler:
"""
method = self.env.get('REQUEST_METHOD', None)
if method != 'POST':
raise MethodNotAllowed()
content_type = self.env.get('CONTENT_TYPE', None)
if content_type != 'application/json':
raise UnsupportedMediaType()
if self.get_event() is None:
-raise Reject()
+msg = 'no X-GitHub-Event header found in the request headers'
+logging.error(msg)
+raise Reject(msg)
def get_event(self):
"""
Extracts GitHub event from header field.
"""
return self.request.headers.get('X-GitHub-Event', None)
@@ -352,17 +356,17 @@ class Push(Event):
if issue_id not in messages:
messages[issue_id] = (u'', False)
curr_msg, curr_close = messages[issue_id]
# we append the new message to the other and do binary OR
# on close, so that at least one information will actually
# close the issue
messages[issue_id] = (curr_msg + u'\n' + msg, curr_close or
close)
if not messages:
-return
+return 'zero messages created'
for issue_id, (msg, close) in messages.iteritems():
# add comments to appropriate issues...
id = issue_id.encode('utf-8')
try:
issue_msgs = self.db.issue.get(id, 'messages')
except IndexError:
# See meta issue #613: the commit message might also include
# PR ids that shouldn't be included.
diff --git a/test/data/pushevent6.txt b/test/data/pushevent6.txt
new file mode 100644
--- /dev/null
+++ b/test/data/pushevent6.txt
@@ -0,0 +1,11 @@
+POST /python-dev/pull_request HTTP/1.1
+Host: 3ab1787e.ngrok.io
+Accept: */*
+User-Agent: GitHub-Hookshot/6b02022
+X-GitHub-Delivery: 2076d100-0054-11e7-9584-1096a01ee5f0
+X-GitHub-Event: push
+content-type: application/json
+X-Hub-Signature: sha1=f7557283b2cb821aafcbb5b7f44001c237795c96
+Content-Length: 8426
+
+{"ref":"refs/heads/3.6","before":"21ce65aa67f0dc63002ab0a5fb21ef921cf5279e","after":"9d07aceedabcdc9826489f8b9ba056283bb3","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/21ce65aa67f0...9d07aceedabc","commits":[{"id":"9d07aceedabcdc9826489f
[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o
Berker Peksag added the comment:
Here is a patch that tweaks some exception messages and adds logging.error()
calls in GitHubHandler class.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue613>
___diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -41,20 +41,21 @@ class GitHubHandler:
def dispatch(self):
try:
self.verify_request()
self.validate_webhook_secret()
self.extract()
except (Unauthorised, MethodNotAllowed,
UnsupportedMediaType, Reject) as err:
+logging.error(err, exc_info=True)
raise
except Exception as err:
logging.error(err, exc_info=True)
-raise Reject()
+raise Reject(err)
def extract(self):
"""
This method is responsible for extracting information from GitHub event
and decide what to do with it more. Currently it knows how to handle
pull requests and comments.
"""
event = self.get_event()
@@ -77,18 +78,19 @@ class GitHubHandler:
"""
Validates request signature against SECRET_KEY environment variable.
This verification is based on HMAC hex digest calculated from the sent
payload. The value of SECRET_KEY should be exactly the same as the one
configured in GitHub webhook secret field.
"""
key = os.environ.get('SECRET_KEY')
if key is None:
-logging.error('Missing SECRET_KEY environment variable set!')
-raise Reject()
+msg = 'Missing SECRET_KEY environment variable set!'
+logging.error(msg)
+raise Reject(msg)
data = str(self.form.value)
signature = 'sha1=' + hmac.new(key, data,
hashlib.sha1).hexdigest()
header_signature = self.request.headers.get('X-Hub-Signature', '')
if not compare_digest(signature, header_signature):
raise Unauthorised()
def verify_request(self):
@@ -97,17 +99,19 @@ class GitHubHandler:
"""
method = self.env.get('REQUEST_METHOD', None)
if method != 'POST':
raise MethodNotAllowed()
content_type = self.env.get('CONTENT_TYPE', None)
if content_type != 'application/json':
raise UnsupportedMediaType()
if self.get_event() is None:
-raise Reject()
+msg = 'no X-GitHub-Event header found in the request headers'
+logging.error(msg)
+raise Reject(msg)
def get_event(self):
"""
Extracts GitHub event from header field.
"""
return self.request.headers.get('X-GitHub-Event', None)
@@ -327,17 +331,17 @@ class Push(Event):
"""
Class responsible for handling push events.
"""
def get_github_username(self):
"""
Extract GitHub username from a push event.
"""
-return self.data.get('pusher', []).get('name', '')
+return self.data.get('pusher', {}).get('name', '')
def dispatch(self):
"""
Main method responsible for responding to incoming GitHub event.
"""
self.set_roundup_user()
commits = self.data.get('commits', [])
ref = self.data.get('ref', 'refs/heads/master')
@@ -352,17 +356,17 @@ class Push(Event):
if issue_id not in messages:
messages[issue_id] = (u'', False)
curr_msg, curr_close = messages[issue_id]
# we append the new message to the other and do binary OR
# on close, so that at least one information will actually
# close the issue
messages[issue_id] = (curr_msg + u'\n' + msg, curr_close or
close)
if not messages:
-return
+return 'zero messages created'
for issue_id, (msg, close) in messages.iteritems():
# add comments to appropriate issues...
id = issue_id.encode('utf-8')
try:
issue_msgs = self.db.issue.get(id, 'messages')
except IndexError:
# See meta issue #613: the commit message might also include
# PR ids that shouldn't be included.
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o
Berker Peksag added the comment: I believe the 400 status code comes from one of the "raise Reject()" lines in roundup/github.py. I will try to add some descriptive messages to them to help debug the issue. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue613> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue619] Use author's name if committer is set to GitHub on commit notifications
Berker Peksag added the comment: I might miss some other cases, but for example, when you edit a file on GitHub or when you merge your own PR. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue619> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue618] Allow developers to edit and unlink pull requests
New submission from Berker Peksag: I noticed that developer cannot edit or unlink pull requests. The attached patch should fix this. -- messages: 3272 nosy: berker.peksag, ezio.melotti priority: bug status: unread title: Allow developers to edit and unlink pull requests ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue618> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue611] Update issue with a commit information
Berker Peksag added the comment:
The attached patch should fix the empty date issue.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue611>
___diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -1,15 +1,16 @@
import hashlib
import hmac
import json
import re
import os
import logging
+from roundup.date import Date
from roundup.exceptions import Unauthorised, MethodNotAllowed, \
UnsupportedMediaType, Reject
if hasattr(hmac, 'compare_digest'):
compare_digest = hmac.compare_digest
else:
def compare_digest(a, b):
return a == b
@@ -350,17 +351,20 @@ class Push(Event):
# close the issue
messages[issue_id] = (curr_msg + u'\n' + msg, curr_close|close)
if not messages:
return
for issue_id, (msg, close) in messages.iteritems():
# add comments to appropriate issues...
id = issue_id.encode('utf-8')
issue_msgs = self.db.issue.get(id, 'messages')
-newmsg = self.db.msg.create(content=msg.encode('utf-8'),
author=self.db.getuid())
+newmsg = self.db.msg.create(
+content=msg.encode('utf-8'), author=self.db.getuid(),
+date=Date('.'),
+)
issue_msgs.append(newmsg)
self.db.issue.set(id, messages=issue_msgs)
# ... and close, if needed
if close:
self.db.issue.set(id,
status=self.db.status.lookup('closed'))
self.db.issue.set(id,
resolution=self.db.resolution.lookup('fixed'))
diff --git a/test/test_github.py b/test/test_github.py
--- a/test/test_github.py
+++ b/test/test_github.py
@@ -1,16 +1,17 @@
import unittest
import os
import db_test_base
import cgi
from BaseHTTPServer import BaseHTTPRequestHandler
from StringIO import StringIO
from roundup.cgi import client
from roundup.backends import list_backends
+from roundup.date import Date
from roundup.github import GitHubHandler
from roundup.exceptions import *
NEEDS_INSTANCE = 1
class HTTPRequest(BaseHTTPRequestHandler):
def __init__(self, filename):
@@ -303,16 +304,18 @@ class TestCase(unittest.TestCase):
msgs = self.db.issue.get('1', 'messages')
self.assertEqual(len(msgs), 1)
content = self.db.msg.get(msgs[0], 'content')
self.assertIn("""New changeset
65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1':
#1: fix tests.
https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9
""",
content)
+self.assertIsInstance(self.db.msg.get(msgs[0], 'creation'), Date)
+self.assertIsInstance(self.db.msg.get(msgs[0], 'date'), Date)
# issue status
status = self.db.issue.get('1', 'status')
self.assertNotEqual(self.db.status.get(status, 'name'), 'closed')
self.assertIsNone(self.db.issue.get('1', 'resolution'))
self.assertIsNone(self.db.issue.get('1', 'stage'))
def testPushEventAddsCommentAndClose(self):
dummy_client = self._make_client('pushevent1.txt')
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue595] Set stage to 'resolved' when an issue is closed
Berker Peksag added the comment: I tested this again and addressed David's review comment. Applied in https://hg.python.org/tracker/python-dev/rev/5b89f6f8abd3 -- status: chatting -> testing ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue595> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue611] Update issue with a commit information
Berker Peksag added the comment: Another alternative is to only send notifications for 2.7 and master branches for now [1] For example, see http://bugs.python.org/issue29407 we would only see the latest notification with this approach: http://bugs.python.org/msg286687 Since commit hashes don't change, there shouldn't be much problem with this approach. [1] Since we are going to use "commit to master; cherry-pick to bugfix branches" with git, perhaps we could store these events in a queue, then periodically group them together and send them to bugs.p.o? ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue611> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue610] Hyperlink git hashes of 10 or 11 characters
Berker Peksag added the comment: Looks good to me too. I can do the merging if David or Ezio are busy. -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue610> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue602] automatic redirect to https
Berker Peksag added the comment: This is a duplicate of issue 463. -- nosy: +berker.peksag status: unread -> resolved superseder: +HTTPS only version for login for this tracker ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue602> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue552] Modules and interest no longer displayed in nosy list completion
Berker Peksag added the comment: It's broken because we've deleted the devguide repository from hg.python.org. Here is a patch. -- nosy: +berker.peksag status: unread -> chatting ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue552> ___diff --git a/extensions/jnosy.py b/extensions/jnosy.py --- a/extensions/jnosy.py +++ b/extensions/jnosy.py @@ -7,17 +7,17 @@ of the nosy list: """ import urllib try: import json except ImportError: import simplejson as json -url = 'http://hg.python.org/devguide/raw-file/default/experts.rst' +url = 'https://raw.githubusercontent.com/python/devguide/master/experts.rst' # possible states no_table = 0 # not parsing a table table_header = 1 # parsing the header table_content = 2 # parsing the content table_end = 3 # reached the end of the table def experts_as_json(): ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue592] Show GitHub comments on b.p.o
Berker Peksag added the comment: Maciej, that sounds good to me but I agree with David. This needs to be discussed on the core-workflow list. It would be nice to have a some sort of mockup or flowchart to see what kind of information will be displayed in these combined comments. It's a bit hard to see it from the attached patches. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue592> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page
Berker Peksag added the comment: The API call in my patch was just an example. GitHub does provide a search API. However, the problem with my approach is that it ignores rate limiting of GitHub API: https://api.github.com/rate_limit So Anish's patch might be more reliable than mine. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue586> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page
Berker Peksag added the comment: I don't have an objection to a general purpose webhook (I wrote such webhooks for GitHub before.) Using a webhook for a simple task like this will only make the implementation more complicated. I don't see a reason to store pull request URLs in database. We've also discussed backup pull request data (including review comments) so storing URLs in database won't be needed in long term anyway. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue586> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue590] Show Pull Request status on b.p.o
New submission from Berker Peksag: Do we need a separate issue for this? I think this can be done in issue 586. -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue590> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue592] Show GitHub comments on b.p.o
New submission from Berker Peksag: Thanks for the patches! :) GitHub already spams every single comment made on a pull request and this will make it worse. I'm -1 on this. It's fine if other core developers want to backup review comments, but it shouldn't be shown on bugs.python.org by default. (Also, please attach standalone patches. I think I need some another patch to be able to import and test these patches.) -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue592> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue600] Convert patches to GitHub Pull Request
Berker Peksag added the comment: How do you get the correct author information of the patch? I don't think there is an easy way [1] to extract the author information to use it in the pull requests. [1] You could probably check the GitHub username field of the author but you could have to guess it anyway and I don't think we should guess it. People should convert their patches to pull requests manually. -- nosy: +berker.peksag ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue600> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page
Berker Peksag added the comment: Issue 589 is a different feature and it should be discussed there (by the way it would be really nice if you could give more information about the feature and the patch -- I had to read the whole patch to understand what it does). The problem with this implementation is that I will need to go to bugs.python.org/issue and paste a URL everytime I open a pull request on GitHub. Instead of this manual step, Roundup should automatically look for "Issue #" in all pull request titles and list all matched items by using JavaScript on bugs.python.org/issue. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue586> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page
Berker Peksag added the comment:
+url = newvalues.get('url', '')
You should also return early if there is no 'url' key in newvalues.
i18n:translate="" can be removed. I don't think we are going to support a
non-English language.
I would also prefer a 'remove' link instead of 'edit'.
This is just a nitpick, but it would be nice to not use name 'github' in
schema.py. We may switch to another pull request/merge request based software
in the future.
+
+
+
+
+
The empty can be removed.
--
nosy: +berker.peksag
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue586>
___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue598] Hide retired queries in "Your Queries" sidebar
Berker Peksag added the comment: Or maybe we can have two buttons: Retire (the current behavior) and Delete We can mark retired queries with a different background in the sidebar. ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue598> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue598] Hide retired queries in "Your Queries" sidebar
Berker Peksag added the comment: So does that mean that the current 'Delete' button at query?@template=edit is sort of misnamed (it actually retires the query)? Instead of two steps (retire -> delete) can we just delete the query? ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue598> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue599] Strip content when replying to an issue via email
New submission from Berker Peksag: Here is an example http://bugs.python.org/issue25413#msg268427 -- messages: 3048 nosy: berker.peksag priority: feature status: unread title: Strip content when replying to an issue via email ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue599> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue556] Server error when trying to change homepage
Berker Peksag added the comment: This has been fixed recently. -- nosy: +berker.peksag status: chatting -> resolved ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue556> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue598] Hide retired queries in "Your Queries" sidebar
New submission from Berker Peksag: This is one of my biggest annoyances of the current tracker. We should hide queries if they are marked as 'retired'. -- files: hide_retired_queries.diff messages: 3046 nosy: berker.peksag priority: bug status: unread title: Hide retired queries in "Your Queries" sidebar ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue598> ___diff --git a/html/page.html b/html/page.html --- a/html/page.html +++ b/html/page.html @@ -218,20 +218,22 @@ status_all string:-1,1,2,3; Hello, username Your Details Logout - Your Queries (edit) - -link - + Your Queries (edit) + + + link + + Administration Class List ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue597] Delete now redundant detectors/changes_xml_writer.py
New submission from Berker Peksag:
See https://mail.python.org/pipermail/tracker-discuss/2007-June/000895.html for
discussion. The file can be seen at
http://bugs.python.org/@@file/recent-changes.xml
--
files: delete_changes_xml_writer.diff
messages: 3045
nosy: berker.peksag
priority: wish
status: unread
title: Delete now redundant detectors/changes_xml_writer.py
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue597>
___diff --git a/.hgignore b/.hgignore
--- a/.hgignore
+++ b/.hgignore
@@ -1,9 +1,8 @@
syntax: glob
config.ini
db/files
db/text-index
db/backend_name
-html/recent-changes.xml
**.pyc
**~
*.swp
diff --git a/detectors/changes_xml_writer.py b/detectors/changes_xml_writer.py
deleted file mode 100644
--- a/detectors/changes_xml_writer.py
+++ /dev/null
@@ -1,194 +0,0 @@
-#
-# changes.xml writer detector.
-#
-# Copyright (c) 2007 Michal Kwiatkowski <constant.b...@gmail.com>
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-#
-# * Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# * Neither the name of the author nor the names of his contributors
-# may be used to endorse or promote products derived from this software
-# without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
-# TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
-# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
-# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-#
-
-"""changes.xml writer detector -- save each database change to an XML file.
-
-Root element is called `changes` and it has at most `ChangesXml.max_items`
-children, each called a `change`. Each `change` has the following attributes:
-
-:date: date in RFC2822 format when the change was made
-:id:unique identifier of this change (note: not an integer)
-:type: type of this change (see below)
-
-A structure of a `change` depends on its `type`. Currently implemented
-change types and their formats are listed below.
-
-* type = `file-added`
-
- Describes a new file attached to an existing issue. Child elements:
-
- :file-id: unique integer identifier of the file
- :file-name: name of the uploaded file
- :file-type: MIME type of the file content
- :file-url: permanent URL of the file
- :issue-id: unique integer identifier of an issue this file is attached to
-"""
-
-import os
-import urllib
-from xml.dom import minidom
-from xml.parsers.expat import ExpatError
-from time import gmtime, strftime
-
-# Relative to tracker home directory.
-FILENAME = os.path.join('%(TEMPLATES)s', 'recent-changes.xml')
-
-
-def tracker_url(db):
-return str(db.config.options[('tracker', 'web')])
-
-def changes_xml_path(db):
-return os.path.join(db.config.HOME, FILENAME % db.config.options)
-
-def rfc2822_date():
-return strftime("%a, %d %b %Y %H:%M:%S +", gmtime())
-
-class File(object):
-def __init__(self, db, id, issue_id):
-self.db = db
-self.id = id
-self.issue_id = issue_id
-
-self.name = db.file.get(id, 'name')
-self.type = db.file.get(id, 'type')
-# Based on roundup.cgi.templating._HTMLItem.download_url().
-self.download_url = tracker_url(self.db) +\
-urllib.quote('%s%s/%s' % ('file', self.id, self.name))
-
-class ChangesXml(object):
-# Maximum number of changes stored in a file.
-max_items = 20
-
-def __init__(self, filename):
-self.filename = filename
-self._read_document()
-self.modified = False
-
-def save(self):
-if not self.modified:
-return
-
-self._trim_to_max_items()
-
-fd = open(self.filename, 'w')
-self.document.writexml(fd, encoding="UTF-8")
-fd.close()
-
-def add_file(self, file):
-
[Tracker-discuss] [issue525] OpenID support for Meta Tracker
Berker Peksag added the comment: Duplicate of issue 387. -- nosy: +berker.peksag status: chatting -> resolved superseder: +Need OpenID login for this tracker ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue525> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue571] Make the user form uneditable if current user is not authenticated and is not the owner of the profile
Berker Peksag added the comment: Duplicate of issue 551. -- assignedto: geosim -> nosy: +berker.peksag -geosim status: in-progress -> resolved superseder: +Make the user form uneditable if current user is not authenticated and is not the owner of the profile -"broken form: multiple @action values submitted" on show issue topic: -Exception KeyError: KeyError ___ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue571> ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue595] Set stage to 'resolved' when an issue is closed
New submission from Berker Peksag:
>From https://wiki.python.org/moin/DesiredTrackerFeatures
> When an issue is closed stage should be automatically set to 'resolved'.
--
files: setresolved.diff
messages: 3041
nosy: berker.peksag
priority: feature
status: unread
title: Set stage to 'resolved' when an issue is closed
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue595>
___diff --git a/detectors/setresolved.py b/detectors/setresolved.py
new file mode 100644
--- /dev/null
+++ b/detectors/setresolved.py
@@ -0,0 +1,11 @@
+def setresolved(db, cl, nodeid, newvalues):
+status_change = newvalues.get('status')
+status_close = status_change and newvalues.get('status') ==
db.status.lookup('closed')
+
+if status_close:
+if newvalues.get('stage') is None:
+newvalues['stage'] = db.stage.lookup('resolved')
+
+
+def init(db):
+db.issue.audit('set', setresolved)
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue594] Fix ImportError: cannot import name rndstr in oic_login.py
New submission from Berker Peksag:
I'm getting an import error with the latest version of oic. Here is a patch to
fix this.
--
files: oic.diff
messages: 3040
nosy: berker.peksag
priority: bug
status: unread
title: Fix ImportError: cannot import name rndstr in oic_login.py
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue594>
___diff --git a/extensions/oic_login.py b/extensions/oic_login.py
--- a/extensions/oic_login.py
+++ b/extensions/oic_login.py
@@ -2,22 +2,35 @@
# For Google accounts, also attempt migration from OpenID (until 2017)
from oic.oic.consumer import Consumer
from oic.oic.message import RegistrationResponse
from oic.oic.message import AuthorizationResponse
import hashlib
import hmac
import random
from UserDict import DictMixin
-from oic.oauth2 import rndstr
from oic.utils.authn.client import CLIENT_AUTHN_METHOD
from roundup.cgi.actions import Action
from roundup.cgi.exceptions import *
from roundup import password, hyperdb
+try:
+from oic.oauth2 import rndstr
+except ImportError:
+import string
+
+def rndstr(size=16):
+"""
+Returns a string of random ascii characters or digits
+:param size: The length of the string
+:return: string
+"""
+_basech = string.ascii_letters + string.digits
+return "".join([random.choice(_basech) for _ in range(size)])
+
HOSTNAME='lap-le.pst.beuth-hochschule.de'
consumer_config = {
'debug': True
}
client_config = {
'client_authn_method':CLIENT_AUTHN_METHOD,
}
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
[Tracker-discuss] [issue560] error setup msiexec.exe
Berker Peksag added the comment: Thanks for the report, but please create a new issue at https://bugs.python.org/ or better ask your question at https://mail.python.org/mailman/listinfo/python-list first. This tracker is for development of our Roundup instance. -- nosy: +berker.peksag status: unread - resolved ___ PSF Meta Tracker metatrac...@psf.upfronthosting.co.za http://psf.upfronthosting.co.za/roundup/meta/issue560 ___ ___ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss
