Berker Peksag added the comment:
+ url = newvalues.get('url', '')
You should also return early if there is no 'url' key in newvalues.
i18n:translate="" can be removed. I don't think we are going to support a
non-English language.
I would also prefer a 'remove' link instead of 'edit'.
This is just a nitpick, but it would be nice to not use name 'github' in
schema.py. We may switch to another pull request/merge request based software
in the future.
+ <td>
+
+ </td>
+ </tr>
+</table>
The empty <td></td> can be removed.
----------
nosy: +berker.peksag
_______________________________________________________
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue586>
_______________________________________________________
_______________________________________________
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
