Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

On Wed, Mar 3, 2021 at 7:18 AM Maarten ter Huurne 
wrote:

>
> Yes, as far as I know the intention is to reduce the amount of
> infrastructure that has to be maintained by Twisted developers.
>
> Adi is doing the actual work for the migration; I only contribute
> indirectly by reviewing PRs that make pydoctor integrate better with
> Sphinx.
>
> There are efforts to make the output of pydoctor more user friendly.
> This is mainly done by Tristan, but I occasionally work on it as well.
> In the next major release we should have a clearer presentation of
> parameter types, more navigation links and, if it's ready in time, a
> side bar containing a page outline.
>

Maarten,

Thanks for the detailed explanation of what you, Adi, and Tristan
are working towards.  That is a lot of hard work!

I think that using the type annotations in the code for documentation,
rather than the Epydoc @type markup tag is WAY better than what we have now.

>From what you have described, there are only a few more tasks to go before
this goal is fully completed, and the docs are published with the new
pydoctor.

I'm looking forward to the end result!

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

[Craig Rodrigues]

On Tue, Mar 2, 2021 at 12:12 PM Tobias Oberstein 
wrote:

>
> this fix broke our workaround for the bug now fixed;)
>
>
I had to read that sentence a few times before I fully understood it, and
my mind did a backflip. :)

Is there a quick and dirty way to run Crossbar's CI against a pre-release
version of Twisted?

For Buildbot (a project that I work with a lot), I just tweaked their CI
like this to run against a branch of Twisted:
https://github.com/buildbot/buildbot/pull/5739
When those tests failed, that helped give some info, and helped me isolate
one thing to fix in Twisted before doing the release.
Povilas Kanapickas and Pierre Tardy from the Buildbot project were very
helpful with this.

I did not run the test suite for Matrix Synapse, but Richard van der Hoff
was very helpful in terms of giving feedback.

Twisted's internal test suite is quite good and comprehensive, but it
doesn't catch everything.
I find it useful to do quick tests against existing projects where possible.

Twisted has been around for around 20 years, and is used *all over the
place*!
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted 21.2.0 Release Announcement

[Craig Rodrigues]

Glyph,

The 21.2.0 release branch is ready for review so that it can be merged back
to trunk:

https://github.com/twisted/twisted/pull/1514

Thanks.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Post Release updates

[Craig Rodrigues]

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson  wrote:

>
> Isn't this just because incremental hasn't had a release since 17.5.0?
> I added post= support way back in
> https://github.com/twisted/incremental/pull/37, but that was after
> 17.5.0.
>
> --
> Colin Watson (he/him)  [cjwat...@debian.org]
>
>
Colin,

You are right.  I have released Twisted incremental 21.3.0 which has your
fixes for PEP 440
compliant post release support.

https://pypi.org/project/incremental/

Thanks for submitting those fixes, and sorry it took so long for it to be
released.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

[Craig Rodrigues]

On Mon, Mar 1, 2021 at 4:47 PM Kyle Altendorf  wrote:

>
> My point was that you missed a review and you missed running towncrier
> and depending what release process you are following you missed a tag in
> the branch and a post-release-version-change.  You asked about how to
> release but gave no time for response.
>
>
Ah OK, I see what you are saying.  That makes sense.

hawkowl gave me access to the Twisted incremental pypi,
so I just pushed a release of Twisted Incremental 21.3.0 with all the latest
fixes for post release support.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

[Craig Rodrigues]

On Mon, Mar 1, 2021 at 4:44 PM Amber Brown 
wrote:

>
> The ghost of ADHD present has smiled upon you this day!
>
> I added glyph, JP, and rodrigc as collaborators on the incremental project.
>
>
Wow, thanks!  Nice to see you!

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

[Craig Rodrigues]

On Mon, Mar 1, 2021 at 3:27 PM Kyle Altendorf  wrote:

> On 2021-03-01 14:13, Craig Rodrigues wrote:
>
> > On Mon, Mar 1, 2021 at 9:13 AM Colin Watson 
> > wrote:
> >
> >> Isn't this just because incremental hasn't had a release since 17.5.0?
> >> I added post= support way back in
> >> https://github.com/twisted/incremental/pull/37, but that was after
> >> 17.5.0.
> >
> > Oh wow!  You are right.
> >
> > Can someone help me release a new version of Twisted incremental?
> > I don't know how to do it.
>
> I would have expected the existing PRs could be handled and that the
> release would have a release branch with a towncrier run and review.
>
> https://github.com/twisted/incremental/pull/67
>
>
Kyle,

Yes, I did PR 67 in incremental just now.  I have write access to the
twisted/incremental Git repo.
The thing I don't know is how to publish to
https://pypi.org/project/incremental/ and who has access to do that.
Do you see how we can do this?  I'm not so familiar with Pypi.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Need help releasing new version of Twisted incremental

[Craig Rodrigues]

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson  wrote:

>
> Isn't this just because incremental hasn't had a release since 17.5.0?
> I added post= support way back in
> https://github.com/twisted/incremental/pull/37, but that was after
> 17.5.0.
>
>
Oh wow!  You are right.

Can someone help me release a new version of Twisted incremental?
I don't know how to do it.

According to https://pypi.org/project/incremental/ , the latest release was
done in 2017, which does not have Colin's fix.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Post Release updates

[Craig Rodrigues]

On Mon, Mar 1, 2021 at 2:38 AM Hynek Schlawack  wrote:

>
> FWIW, I think it’s common (aka _I_ do it that way) that .post are indeed
> post-releases like a documentation update that doesn’t warrant a proper
> update. PEP 440 specifies it and RTD has good support for that. E.g.
> https://www.attrs.org/en/17.3.0.post2/
>
> IIRC Twisted doesn’t bump before the release, which makes this whole
> workflow unfeasible? But it’s something to keep in mind when deciding.
>
>
I had some questions about PEP440, so I asked for feedback from Łukasz
Langa who provided it here:

https://github.com/twisted/twisted/pull/1514#issuecomment-788059407

Basically  Łukasz's feedback was that doing this:

21.2.0.rc1
21.2.0 (this is the release)
21.2.0.post0

is OK.   So in PR 1514, I went with that.


Unfortunately, I ran into a bug in Twisted incremental:

File "/tmp/pip-req-build-zvf8johl/src/twisted/__init__.py", line 11, in

  from twisted._version import __version__ as version
File "/tmp/pip-req-build-zvf8johl/src/twisted/_version.py", line 10, in

  __version__ = Version("Twisted", 21, 2, 0, post=0)
  TypeError: __init__() got an unexpected keyword argument 'post'

I might need some help to get a fix into incremental and push that out
later today,
so I can complete PR 1514.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Post Release updates

[Craig Rodrigues]

On Sun, Feb 28, 2021 at 12:43 PM Adi Roiban  wrote:

>
> And we have not yet decided if the trunk should be using `.dev` or .post`
> :(
>
>
According to the Twisted release process, one of the last things I need to
do is bump the Twisted version:
https://github.com/twisted/twisted/blob/trunk/docs/core/development/policy/release-process.rst#post-release

I did not do that yet, for the very reason which you brought up.
I think the instructions for bumping to `dev` are not correct, as per my
interpretation of PEP440.

I asked Glyph for clarification here:
https://github.com/twisted/twisted/pull/1514#issuecomment-787533582

If you or anyone else has good knowledge on PEP440, and what the correct
thing to do here is,
feel free to add feedback in that PR!
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted 21.2.0 Release Announcement

[Craig Rodrigues]

On Sun, Feb 28, 2021 at 1:55 PM Adi Roiban  wrote:

>
>
>
> Hi,
>
> Thanks Craig for managing this release.
>


You are welcome Adi!

I am happy to contribute my efforts to the Twisted community and to push
the project along.

In 2015-2016, unfortunately I lost my job.  While in between jobs, I
contributed a lot to the effort
to port Twisted to Python 3.  It was a very enjoyable experience, and I
learned a lot of Python at the time. :)

I joined the Python 2 porting party late, and there were others who
invested a lot of time and effort into it.
Amber did a heck of a lot of work before me on Python 3 porting, and did a
lot of work after I contributed.
I don't remember who else contributed, but there were a lot of folks
including you, Jean-   , Glyph, and others.

The earliest Python 3 ticket I can find in the Trac is this one from 14
years ago filed by Itamar!!

https://twistedmatrix.com/trac/ticket/2484

Honestly, at the time, when I was working on Python 3 porting in 2016, I
wasn't even sure that Twisted
would survive as a project beyond Python 2.

So it is nice to see that Python 2.7 is history, and the Twisted codebase
is incorporating new language
features, types, etc. and is keeping up with newer Python versions.

Hurray!
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

On Sun, Feb 28, 2021 at 1:50 PM Maarten ter Huurne 
wrote:

> On Sunday, 28 February 2021 22:02:48 CET Craig Rodrigues wrote:
> > That sounds like a good plan.  Thanks for working on this.
> >
> > Keep in mind the points regarding docs raised by Glyph here:
> >
> >
> > https://twistedmatrix.com/pipermail/twisted-python/2021-February/06543
> > 2.html
>
> Those are good points, but I meant API docs specifically and I don't
> think there should be any overlap between the wiki and the API docs. If
> I'm mistaken, please let me know.
>
>
I think the direction that Glyph was mentioning is that if there are
docs in the source tree, and duplicated docs on the wiki, we want to favor
the docs
in the source tree.  Any duplicated docs on the wiki should either be
deleted, or changed to put
pointers to the docs in the source tree.

With respect to API docs, I am not as familiar with the whole process, with
how they are generated
and what are doing with readthedocs vs. docs on twistedmatrix.com.
API docs are generated and don't live in the source tree.

For example: https://twistedmatrix.com/documents/current/api/twisted.html

Is the long term direction to get rid of that, and point everything at
readthedocs?

Since you have done a lot of work in this area, can you shed some light on
what you think the future direction of all this stuff should
be with respect to the API docs?

Thanks.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

That sounds like a good plan.  Thanks for working on this.

Keep in mind the points regarding docs raised by Glyph here:


https://twistedmatrix.com/pipermail/twisted-python/2021-February/065432.html

--
Craig


On Sunday, February 28, 2021, Maarten ter Huurne 
wrote:
>
>
> However, I think that it would be preferable to get new docs out as soon
> as possible, rather than waiting for even better docs. Once those
> improvements are integrated, we could do another pydoctor release and
> update Twisted's API docs without there being a new Twisted release.
>
> Does this sound like a plan?
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted 21.2.0 Release Announcement

[Craig Rodrigues]

On behalf of Twisted Matrix Laboratories, I am honored to announce the
release of Twisted 21.2.0!

There are two major announcements for this release:

- *Python 2.7 support has been dropped*.  Twisted 21.2.0 supports Python
3.5.3 and higher only
- *This will be the last Twisted release to support Python 3.5*.

Twisted 21.2.0 brings the following:
- twist dns --pyzone now works on Python 3
- twisted.web.twcgi now works on Python 3
- all tests pass on all platforms on Python 3.8, including asyncio tests on
Windows
- tests pass on Python 3.9 (thanks to Michał Górny)
- type hints, as specified in PEP 484, are now used in functions throughout
the codebase
- mypy (static type checker) is now run over the codebase during CI to help
detect problems, and help improve the use of types
- code in is now formatted with Black (thanks to Tom Most)
- many CI and automation improvements (thanks to Adi Roiban and Thomas
Grainger)
- many more fixes (225 tickets closed!)


You can install by running this command:

  python -m pip install Twisted==21.2.0

The full tarball is available at:
https://pypi.org/project/Twisted/21.2.0/#files

The full NEWS file with all changes is at:
https://github.com/twisted/twisted/blob/twisted-21.2.0/NEWS.rst
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

[Craig Rodrigues]

On Thu, Feb 25, 2021 at 7:03 PM Craig Rodrigues 
wrote:

>
>
> On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff 
> wrote:
>
>> As it happens, it also fails (for an import of typing.Deque) on Python
>> 3.5.3, as used by Debian oldstable.
>>
>> Craig, what is your intention here? I think it's ok to drop support for
>> these ancient versions of Python 3.5, but please could you make sure that
>> python_requires gets set to 3.5.10 if that's what's been tested against?
>>
>
> Sigh.  I can confirm that typing.Deque does not import on Python 3.5.2.
>
> I took an inventory of our CI, and realized that the minimum version we
> are testing is *3.5.4* on Azure.
>
> Can you review this which bumps the minimum version to Python 3.5.4:
> https://github.com/twisted/twisted/pull/1525
>
> Once I get that in, I will cherry pick it to the release branch and push
> out the 21.2.0 release.
>


Richard,

As you can see by this review comment:
https://github.com/twisted/twisted/pull/1525#issuecomment-786965737

Thomas Grainger and Adi Roiban have worked together to bump up the minimum
Python version to 3.5.3 for this
release ( https://github.com/twisted/twisted/pull/1524 ), and are not
approving the PR that I have submitted
in PR 1525.  Even though you approved PR 1525, I cannot merge it because
only PR reviews by people with
write access to the Twisted repo can be merged to the Twisted repo.

I am going to proceed with the release as-is with Python 3.5.3 as the
minimum version.  I hope that is OK for your needs.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

Thanks for the clarification.

You have provided a lot of useful details.  There are a lot of
interconnected pieces, with
multiple people working on different things.

For now, I am going to proceed to finish the release as-is.

The documentation may not be automatically deployed as part of the release,
but I think that can be done as a follow-on task.
--
Craig

On Sat, Feb 27, 2021 at 4:53 PM Adi Roiban  wrote:

> Hi,
>
> Sorry for the delay.
>
> We did the automation and Read The Docs hosting.
>
> In parallel there was also the work required to host the pydoctor API docs
> on Read The Docs.
>
> --
>
> Note that https://docs.twistedmatrix.com/en/twisted-20.3.0/api  404
>
> That should host the files from
> https://twistedmatrix.com/documents/current/api/
>
> -
>
> For `trunk` we have https://docs.twistedmatrix.com/en/latest/api/
>
> That was the hard work done by Maarten to improve pydoctor and Twisted API
> docs.
>
> -
>
> There was a plan to do a new pydoctor release over the end of the year
> break... but that never happened.
>
> The current PR that is "breaking" API links from narrative docs to API
> docs on Read The Docs version of Twisted docs is
> https://github.com/twisted/twisted/pull/1496
>
> But even before that PR the API docs on Read the Docs were broken, as we
> had too many HTML pages and the build process on RTD
> was interrupted.
>
> This is why I have approved the PR in the first place.
>
> So https://github.com/twisted/twisted/pull/1466 should also be reverted
>
> 
>
> So, if for this release the "official" Twisted documentation is to be
> hosted at https://twistedmatrix.com/documents/current/api/
> then https://twistedmatrix.com/trac/ticket/10068 is not a blocker.
>
> If the plan is to host the full and "official" Twisted documentation on
> Read The Docs, the https://twistedmatrix.com/trac/ticket/10068 is a
> blocker.
>
> And the easiest solution is to do a new pydoctor release.
>
> --
>
> I will try to follow up with Maarten over IRC to see if we can get a new
> pydoctor release.
>
> In theory, the pydoctor release process is automated and any other Twisted
> developer from https://github.com/orgs/twisted/teams/twisted-contributors
> could do a release.
>
> Maarten did the release work in the recent past but if he is busy, in
> theory anyone could step in and help with a new pydoctor release.
>
> Regards
>
> On Sat, 20 Feb 2021 at 17:47, Craig Rodrigues 
> wrote:
>
>> Hi,
>>
>> I am confused.  I thought that you and Thomas Graingert had completed all
>> the automation and had changed the Twisted release scripts to host the
>> documentation on readthedocs and that was all in place right now.
>>
>> Is that not the case?
>>
>> How much more work is necessary to completely host the next Twisted
>> release's docs on readthedocs?
>>
>> --
>> Craig
>>
>> On Saturday, February 20, 2021, Adi Roiban  wrote:
>>
>>> Hi,
>>>
>>> Sorry for the delay.
>>>
>>> This was added as a  blocker due to the changes from
>>> https://github.com/twisted/twisted/pull/1496 and the plan to use Read
>>> The Docs to
>>> host the official docs.
>>>
>>> This is not a blocker if the official documentation for this release
>>> will continue to be hosted on the Twisted own server at
>>> https://twistedmatrix.com/documents/current/
>>>
>>> It's a blocker only if the official documentation is to be hosted on
>>> Read The Docs at docs.twistedmatrix.com
>>>
>>> I have updated the ticket to no longer block the release.
>>>
>>> Cheers
>>>
>>>
>>> On Sat, 20 Feb 2021 at 02:08, Craig Rodrigues 
>>> wrote:
>>>
>>>> Adi,
>>>>
>>>> Is there anything to be done here, or is this still a release blocker?
>>>>
>>>> --
>>>> Craig
>>>>
>>>>
>>>> On Sun, Feb 14, 2021 at 4:15 PM Craig Rodrigues 
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> This ticket: Use latest pydoctor release,
>>>>> https://twistedmatrix.com/trac/ticket/10068
>>>>>
>>>>> is marked as a release blocker.
>>>>>
>>>>> Has that been resolved or is there more work that needs to be done to
>>>>> fix that?
>>>>>
>>>>> --
>>>>> Craig
>>>>>
>>>>
>>>
>>> --
>>> Adi Roiban
>>>
>>
>
> --
> Adi Roiban
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Release instructions: `tox -e towncrier` does not work?

[Craig Rodrigues]

On Saturday, February 27, 2021, Adi Roiban  wrote:

> Hi,
>
> Sorry for the late reply.
>
> Here is a patch  waiting for review https://github.com/twisted/
> twisted/pull/1527
>
>

Thanks.  I have approved that.
That patch won't make it into the 21.2.0 release, but it is not a release
blocker since for now I can run towncrier manually.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

[Craig Rodrigues]

On Monday, February 15, 2021, Kyle Altendorf  wrote:
>
>
> I went ahead and set pip_pre=true in pytest-twisted's tox.ini to try it
> out and got warnings/errors with PyPy 3.7 about use of t.i.d.returnValue
> claiming it should only be used in @inlineCallbacks decorated functions
> even though the location complained about is such. Only PyPy 3.7, not PyPy
> 3.6 nor CPython 3.7. Linux, macOS, and Windows all failed.
>
>
> Ticketed as https://twistedmatrix.com/trac/ticket/10093.
>
>
>
Thanks for providing the fix for this:

https://github.com/twisted/twisted/pull/1516

This fix will make it into the 21.2.0 release.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

[Craig Rodrigues]

On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff 
wrote:

> As it happens, it also fails (for an import of typing.Deque) on Python
> 3.5.3, as used by Debian oldstable.
>
> Craig, what is your intention here? I think it's ok to drop support for
> these ancient versions of Python 3.5, but please could you make sure that
> python_requires gets set to 3.5.10 if that's what's been tested against?
>

Sigh.  I can confirm that typing.Deque does not import on Python 3.5.2.

I took an inventory of our CI, and realized that the minimum version we are
testing is *3.5.4* on Azure.

Can you review this which bumps the minimum version to Python 3.5.4:
https://github.com/twisted/twisted/pull/1525

Once I get that in, I will cherry pick it to the release branch and push
out the 21.2.0 release.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

Hi,

I am confused.  I thought that you and Thomas Graingert had completed all
the automation and had changed the Twisted release scripts to host the
documentation on readthedocs and that was all in place right now.

Is that not the case?

How much more work is necessary to completely host the next Twisted
release's docs on readthedocs?

-- 
Craig

On Saturday, February 20, 2021, Adi Roiban  wrote:

> Hi,
>
> Sorry for the delay.
>
> This was added as a  blocker due to the changes from
> https://github.com/twisted/twisted/pull/1496 and the plan to use Read The
> Docs to
> host the official docs.
>
> This is not a blocker if the official documentation for this release will
> continue to be hosted on the Twisted own server at
> https://twistedmatrix.com/documents/current/
>
> It's a blocker only if the official documentation is to be hosted on Read
> The Docs at docs.twistedmatrix.com
>
> I have updated the ticket to no longer block the release.
>
> Cheers
>
>
> On Sat, 20 Feb 2021 at 02:08, Craig Rodrigues 
> wrote:
>
>> Adi,
>>
>> Is there anything to be done here, or is this still a release blocker?
>>
>> --
>> Craig
>>
>>
>> On Sun, Feb 14, 2021 at 4:15 PM Craig Rodrigues 
>> wrote:
>>
>>> Hi,
>>>
>>> This ticket: Use latest pydoctor release,
>>> https://twistedmatrix.com/trac/ticket/10068
>>>
>>> is marked as a release blocker.
>>>
>>> Has that been resolved or is there more work that needs to be done to
>>> fix that?
>>>
>>> --
>>> Craig
>>>
>>
>
> --
> Adi Roiban
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

Adi,

Is there anything to be done here, or is this still a release blocker?

--
Craig


On Sun, Feb 14, 2021 at 4:15 PM Craig Rodrigues 
wrote:

> Hi,
>
> This ticket: Use latest pydoctor release,
> https://twistedmatrix.com/trac/ticket/10068
>
> is marked as a release blocker.
>
> Has that been resolved or is there more work that needs to be done to fix
> that?
>
> --
> Craig
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

[Craig Rodrigues]

On Monday, February 15, 2021, Kyle Altendorf  wrote:

>
> NonLocalExitTests
> test_returnValueNonLocalDeferred ... [FAIL]
> test_returnValueNonLocalWarning ... [FAIL]
>
> Ticketed as https://twistedmatrix.com/trac/ticket/10093.
>
>
>
>
Thanks for the testing, detailed analysis, and ticket.  If you can come up
with a relatively simple fix in the next week,  I'm ok the cherry-picking
that into the release.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

[Craig Rodrigues]

It's time for another Twisted release!

There are two major announcements for this release:

- *Python 2.7 support has been dropped*.  Twisted 21.2.0 supports Python
3.5 and higher only
- *This will be the last Twisted release to support Python 3.5*.

Twisted 21.2.0rc1 brings the following:
- twist dns --pyzone now works on Python 3
- twisted.web.twcgi now works on Python 3
- all tests pass on all platforms on Python 3.8, including asyncio tests on
Windows
- tests pass on Python 3.9 (thanks to Michał Górny)
- type hints, as specified in PEP 484, are now used in functions throughout
the codebase
- mypy (static type checker) is now run over the codebase during CI to help
detect problems, and help improve the use of types
- code in is now formatted with Black (thanks to Tom Most)
- many CI and automation improvements (thanks to Adi Roiban and Thomas
Grainger)
- many more fixes (225 tickets closed!)


You can install by running this command:

  python -m pip install Twisted==21.2.0rc1

The full tarball is available at:
https://pypi.org/project/Twisted/21.2.0rc1/#files

The full NEWS file with all changes is at:
https://github.com/twisted/twisted/blob/twisted-21.2.0rc1/NEWS.rst

Please test it, and let me know how your applications fare, good or bad!
If nothing comes up, 21.2 will release very soon.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Release instructions: `tox -e towncrier` does not work?

[Craig Rodrigues]

In
https://github.com/twisted/twisted/commit/0ad24679b168370bf0d695825170a7532bf0698f#diff-4fd162cb9fc2878b140dcc9d9d364f9f60d404a76ebda2c10518810ffe63852dL115

Adi Roiban changed one of the steps the release documentation to run a
command:

*tox -e towncrier*

but that tox target does not exist.

Does Adi or someone else have that tox target in a patch lying
around somewhere?

For now I can manually run *towncrier *manually outside of tox.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Release blocker: Use latest pydoctor release ?

[Craig Rodrigues]

Hi,

This ticket: Use latest pydoctor release,
https://twistedmatrix.com/trac/ticket/10068

is marked as a release blocker.

Has that been resolved or is there more work that needs to be done to fix that?

--
Craig

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted trunk and klein?

[Craig Rodrigues]

On Thu, Feb 11, 2021 at 2:29 PM Glyph  wrote:
>
>
> I filed https://github.com/pypa/pip/issues/9601 for this since it seems like 
> it's well outside of our control.  If anyone else can add more information 
> that would be great.
>


Thanks for doing the analysis and filing that bug.  I didn't want to
jump on anything, and wanted to give some breathing room for
folks to look at that and chime in.

Wilfredo has this PR to klein where he is also looking at these
issues: https://github.com/twisted/klein/pull/450

So I think that I will not hold up the Twisted core release based on
this issue.  Hopefully this issue can be resolved outside of Twisted
core.

--
Craig

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

[Craig Rodrigues]

On Wed, Feb 10, 2021 at 2:57 PM Glyph  wrote:
>
>
>
> On Feb 10, 2021, at 6:45 AM, Craig Rodrigues  wrote:
>
>
>
> On Wednesday, February 10, 2021, Glyph  wrote:
>>
>>
>>
>> On Feb 10, 2021, at 12:40 AM, Craig Rodrigues  wrote:
>>
>> How will this patch change for people installing Twisted on Windows?
>>
>> Twisted is still used by a lot of users on Windows, and the IOCP Reactor is
>> still used on this platform.
>>
>>
>> This line is what does the trick:
>>
>> https://github.com/twisted/twisted/pull/1446/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R34
>>
>> Basically, on Windows, you'll automatically get the `twisted-iocpsupport` 
>> module as a hard dependency.  On other platforms, you won't.  Unless you're 
>> using a truly ancient `pip` (which is less likely on Windows, where people 
>> tend to install things themselves rather than getting them from a calcified 
>> platfom) this will just work magically
>>
>
>  Ok, thanks for the clarification.  That is worth calling out in the release 
> announcement, since that is a major change for Windows users.
>
>
> I don't disagree that it's worth calling out, but I might quibble on "major" 
> change - it's a small build-configuration change that mostly affects Twisted 
> contributors (in a positive way), and those with heavily locked-down build 
> environments.  From the perspective of a Twisted user on Windows who wants to 
> make use of the IOCP reactor and is installing with a regular `pip install`, 
> nothing changes except a new line in `pip freeze`.


I think that you are right, and everything will probably just work for
Windows users.

I'm just thinking from the perspective of a user of Twisted on
Windows, who may not be familiar with all the latest
innovations in pip, and may encounter a problem.  But I think that
these issues will be minor/few, and we can handle them post-release if
necessary.


>
> Yep! You can see in the README.rst on the repo, and also on its PyPI page: 
> https://pypi.org/project/twisted-iocpsupport/

Thanks for the clarification.  One unfortunate thing with this move to
another repository is that
version history has been lost, going all the way back to 2008.  It's
not the end of the world, since anyone who really
wants that history can check out an earlier branch of twisted and look
at it, but it is still an extra hop for someone to do.

--
Craig

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted trunk and klein?

[Craig Rodrigues]

Hi,

I quickly asked Wilfredo if Twisted trunk worked with Klein, and he mentioned
that he saw this dependency issue on the Twisted klein side when used
with Twisted trunk:

The conflict is caused by:
The user requested idna==3.1
hyperlink 21.0.0 depends on idna>=2.5
requests 2.25.1 depends on idna<3 and >=2.5


Is that problem purely for klein to deal with, or is there
any issue that should be fixed in Twisted trunk?

--
Craig

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

[Craig Rodrigues]

On Wednesday, February 10, 2021, Glyph  wrote:

>
>
> On Feb 10, 2021, at 12:40 AM, Craig Rodrigues 
> wrote:
>
> How will this patch change for people installing Twisted on Windows?
>
> Twisted is still used by a lot of users on Windows, and the IOCP Reactor is
> still used on this platform.
>
>
> This line is what does the trick:
>
> https://github.com/twisted/twisted/pull/1446/files#diff-
> fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R34
>
> Basically, on Windows, you'll automatically get the `twisted-iocpsupport`
> module as a hard dependency.  On other platforms, you won't.  Unless you're
> using a *truly* ancient `pip` (which is less likely on Windows, where
> people tend to install things themselves rather than getting them from a
> calcified platfom) this will just work ✨ magically
>
>
 Ok, thanks for the clarification.  That is worth calling out in the
release announcement, since that is a major change for Windows users.

Is the https://github.com/twisted/twisted-iocpsupport repository subject to
the same rules as the Twisted core repository such as:
- must have a Trac ticket
- PR can only be merged after review approval from a reviewer with write
access to the https://github.com/twisted/twisted-iocpsupport repository.
etc.?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Getting ready to do a release of Twisted

[Craig Rodrigues]

Thanks to review work by Tom Most,
I have modified and merged https://github.com/twisted/twisted/pull/1502
which addresses test failures encountered against Buildbot's regression
suite.

I would like to proceed with doing a Twisted release.

Does anyone have any PR's that they are working on that they would like
to get into the tree now?

Otherwise, I would request Twisted committers to hold off merging to trunk
for the next few weeks until the release is complete.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

[Craig Rodrigues]

Looking at this PR:

https://github.com/twisted/twisted/pull/1446

I see that iocpsupport was moved to a separate package, in order
to make building wheels on Windows easier.

Before this patch, I was prototyping building binary wheels on Windows
of Twisted core, and I had it working.

It looks like this code has now moved to:
https://github.com/twisted/twisted-iocpsupport

How will this patch change for people installing Twisted on Windows?

Twisted is still used by a lot of users on Windows, and the IOCP Reactor is
still used on this platform.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Developer docs should be updated on wiki when steps changed in code?

[Craig Rodrigues]

On Wednesday, February 3, 2021, Glyph  wrote:
>
>
>
> Docs in the tree always win.
>
> Let's start deleting them now, and replacing them with links to the
> in-tree docs, rather than updating them.  They've been skewing out of date
> for a long time.  When I was looking for information about how to do a
> revert, I found wiki docs about linking to revisions in Subversion which
> didn't mention Github, which gives a flavor for how outdated some of this
> stuff is.
>
> Thomas, would you mind doing the honors for this document?  Links for
> process docs should probably be to https://docs.twistedmatrix.
> com/en/latest/ since, for process information (unlike API information),
> trunk should be authoritative, not the latest release.
>



Glyph,

Thanks for the clarification.

This seems like a reasonable direction to follow moving forward.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Developer docs should be updated on wiki when steps changed in code?

[Craig Rodrigues]

In this PR: https://github.com/twisted/twisted/pull/1461
some changes were made to the Twisted development process
for running the various linters before committing code.

I noticed that the changes in PR 1461 were not reflected
in docs on the wiki, specifically here:
https://twistedmatrix.com/trac/wiki/TwistedDevelopment

which mentions tox environments that have been deleted in PR 1461.

I noticed this, when I recently tried to work on a branch from recent trunk,
and when I tried to run some of the commands on that wiki page
they didn't work, because they were deleted.

In this post-review comment:
https://github.com/twisted/twisted/pull/1461#issuecomment-753695414

I asked Thomas if he could modify the wiki to reflect the changes he made
in trunk,
but this hasn't been done yet.

My impression in the comments in PR 1461 is that Thomas and Adi want
to move all this documentation into the source tree, and delete the stuff
on the wiki?

Is this the long term plan?

Until this is fully completed, what is the correct thing to do when there
is a mismatch between
docs on the wiki, and docs in the tree?

I still refer to a lot of docs on the wiki, especially for process related
things,
so I think it would be nice if the wiki docs were kept up to date, until
the day that
they are fully deleted.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] resolving release management conflict

[Craig Rodrigues]

On Mon, Feb 1, 2021 at 1:00 PM Glyph  wrote:

>
> I believe the proximate cause of the conflict here is that we're dealing
> with this regression incorrectly.  When a regression is introduced, there's
> a process for dealing with it, originally documented here:
> https://twistedmatrix.com/trac/wiki/ReviewProcess#Revertingachange. [1]
>  The principle we need to outline clearly is this: if we have a regression,
> the change that introduced it should be reverted as soon as possible.  If
> we *can't* revert it directly because of changes to trunk in the
> meanwhile that introduce conflicts, ideally the change that we would make
> would be the closest possible thing to reverting it, even if that
> reintroduces a known bug that we have to reopen.
>
> In the case where a lot of work has happened in the interim, and it's *less
> work* to just "fix forward" on top of trunk, it's fine to do a small fix
> as an end run around this process.  The goal of this process is to minimize
> the work required to restore trunk to a releasable state.
>
> Right now we have three competing fixes which have all been flagged as
> incorrect in various ways:
>
>
>- from Tom: https://github.com/twisted/twisted/pull/1499
>   - Craig rejected this one by saying it will break "certain
>   versions" of Python, but I don't understand why it was closed rather 
> than
>   reviewed / reassigned as normal.  (Or for that matter which versions are
>   the problems, or how it breaks them.)
>
>
Yes, that is correct.  Over the summer, while investigating failures on
Azure CI caused by to non-ASCII characters in
a submitter's GitHub user ID.  I spent a lot of time testing in a Windows
environment on Python 3.5, 3.6, 3.7, and 3.8.
I found that there were subtle differences in the default encoding on the
console between each Python version,
and that affected the logic in _checkProcessArgs().
The fix that I did over the summer addressed the problems and fixed all the
CI issues.

There were two corner cases that were uncovered.  One by me, and one by Tom
Most.

CORNER CASE 1:In Buildbot, they patch sys.stdout with io.StringIO in
their tests which affects their tests which call the Twisted Reactor.
   io.StringIO is not a 100% proper
replacement for sys.stdout which is of type _io.TextIOWrapper on Python 3+.
   However, Buildbot's tests have been
around for a long time, so I decided

CORNER CASE 2:In a Windows GUI Application, sys.stdout is None.  So you
cannot get the encoding from sys.stdout.encoding


In https://github.com/twisted/twisted/pull/1502, I have a very small patch
which addresses those two corner cases.
I need to write a good test for it, but I think it is good enough to go
into the release.

Post-release:
(1) I would like to drop Python 3.5
(2)  Look at removing the _checkProcessArgs() function.  The complexity of
bytes/unicode logic in there was more useful
   in the Python 2 days when dealing with the differences between how
Python on Windows handled args/env vs.
   how Python on POSIX handled args/env.  I think this function can
completely go in a Python 3.6+ world, and will greatly simplify the code.
   However, this needs to be carefully tested and reviewed.



>
>- from Adi: https://github.com/twisted/twisted/pull/1501
>   - Craig rejected this one by saying "please stop working on this"
>   but it also doesn't have any technical reason that this solution is
>   incorrect.
>
> Yes, that is correct.  Sorry if that was an aggressive action on my part,
but I did a fix for this, as described above.






>
>- from Craig: https://github.com/twisted/twisted/pull/1502
>   - This was originally given a passing review by Povilas from the
>   Buildbot project, but twm added an additional blocking review shortly
>   thereafter explaining that it introduced an additional regression.  It
>   seems as though this one is now actively being worked on?
>
>
> Craig: you closed two of these issues on the basis that you were "already
> working on a fix", but that's not a valid reason to *close* a PR.  Or,
> for that matter, to give it a failing review.  In the future, please
> comment on PRs that you don't want merged by pointing out their technical
> insufficiency, so that we can take the opportunity to learn for the benefit
> of future maintenance.  In this case, the underlying issue is clearly quite
> nuanced and requires expertise that touches platform differences in
> Python's core APIs, so having multiple people working on different fixes is
> totally fine; this effort is not wasted if everybody learns a little bit
> about the code in question, and it's *definitely* not wasted if we have
> to synthesize our approaches in the end anyway because they address
> different cases.
>

OK, thanks for the feedback, and sorry for any process violations or hurt
feelings from my actions.



>
> All of these fixes have 

Re: [Twisted-Python] Upcoming Twisted Release

[Craig Rodrigues]

On Mon, Feb 1, 2021 at 11:27 AM Adi Roiban  wrote:

> Hi,
>
> So, speaking for myself here and not representing the Twisted community or
> anyone else.
>


Thanks for making this clear that you are speaking for yourself and no one
else.


> * A release blocker bug - https://twistedmatrix.com/trac/ticket/10069
>
>

For this particular bug, I have been working on getting feedback from Tom
Most,
under https://github.com/twisted/twisted/pull/1502 and am working on a fix
to incorporate his feedback.
This some central code is in base.py, and I am proceeding cautiously to
make sure that I fully understand Tom's
concern  and am working on a  fix.

I apologize if I have not been working fast enough on this release to your
satisfaction.

I will attempt to communicate better on this list my progress.

I didn't want to bring this up on the mailing list.
I will take your behavior as enthusiasm for the project, but despite the
e-mail that Glyph sent,
I still find your behavior very aggressive (and unappreciated).  In your
e-mail you are
throwing out timelines, which may be "friendly suggestions" on your part,
but can come across as deadlines/ultimatums.

For now, I am focusing on the final issue, and will proceed with the
release as best as I am able,
and communicate to the Twisted community my progress.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Questions about Project Leadership committee

[Craig Rodrigues]

On Sat, Jan 23, 2021 at 4:54 PM Glyph  wrote:

> At the time the committee was created, I don’t remember if this was
> public, so I don’t feel comfortable sharing identities publicly because it
> wasn’t part of the deal at the time. This is not the way I’d structure
> things now, but given that several members are unresponsive and don’t seem
> to want to be associated with the project any more, I can’t ask them if
> it’s OK with them. If you can find any old public documentation feel free
> to share though; the issue is that I’m not sure it *has* been public. If it
> has, it can by all means remain public.
>
> I can at least share that as I recall there are 6 members and I’m one of
> them. But you’d want to confirm this with the conservancy, so please join
> Adi’s private thread with them for further discussion.
>

Thanks for the clarification.
Have you recently contacted the 5 other committee members to confirm if
they want to remain on the committee or not,
and either received confirmation (or feedback timeout)?

In this e-mail:
https://twistedmatrix.com/pipermail/twisted-python/2020-December/065364.html
, I mentioned that I
tried to look for documentation about this committee at
https://twistedmatrix.com and could not find any.

So if you are not aware of any public documentation regarding this
committee, then I think it is reasonable
to assume that such documentation does not exist.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Questions about Project Leadership committee

[Craig Rodrigues]

Hi,
I asked some questions about the Twisted project leadership committee here:

https://twistedmatrix.com/pipermail/twisted-python/2020-December/065367.html

but it looks like my questions got lost in the thread, and no one aso I
will ask again.
Who are the current members of the committee?
What are the titles/roles/responsibilities of the current committee members?
Is there a mailing list, IRC channel, or some other venue which the current
committee members belong to
so that they can communicate amongst themselves, and also with the outside
world, such as the Software Freedom Conservancy?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Upcoming Twisted Release

[Craig Rodrigues]

On Fri, Jan 15, 2021 at 10:42 AM Glyph  wrote:

>
>
>
> Following up on this, since we are now officially past the "beginning" of
> January: Craig, is a release imminent or can someone else pick up some
> tasks yet?
>
>
I'm close to getting this done, and want to complete this.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Plan/Goal for GitHub Sponsors

[Craig Rodrigues]

On Wed, Dec 23, 2020 at 1:41 PM Adi Roiban  wrote:

> Hi,
>
> I started a separate discussion to confirm the goal for a future
> fundraising.
>
> Top priority - Pay someone to help with the review queue
> Nice to have - Move server/services to Azure VM -  We have at least $100
> monthly allowance for Azure not sure if we still have the huge $2000
> allowance on rackspace.
> Nice to have - Migrate Trac wiki to GitHub Wiki
>
>
Adi,

I am glad that you are enthusiastic about the Twisted project,
but I just want to raise my voice that I disagree with most of what you
recommend as future actions.

I am skeptical about your recommendation when it comes to accepting
donations, spending
money, and hiring people, etc.   If these things are necessary, I would
like to see this as part of
a fully fleshed out plan that is approved by a proper governance structure.

Personally, I'm not convinced that getting more monetary donations and
hiring people will improve the Twisted project.  I could be wrong about
this,
but I need to be convinced.

In this thread:
https://twistedmatrix.com/pipermail/twisted-python/2020-December/065341.html
you raised some valid points about the project leadership committee.  I
would like to see the points in that
thread discussed to completion.
For starters, the people on the existing project leadership committee
should be given the chance
to respond, and hand the baton to the next project leadership committee.

The fact that details of the project committee are not written down in a
place which is available to the public
seems like something that we can fix, without involving discussions about
spending money and hiring people.

Once there is a proper governance structure in place for the Twisted
project,
I think that any discussions about spending money and hiring can be
discussed more easily.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Updating the project leadership committee

[Craig Rodrigues]

Who are the current members of the committee?
What are the titles/roles/responsibilities of the current committee members?
Is there a mailing list, IRC channel, or some other entity which the
current committee members belong to
so that they can communicate amongst themselves, and also with the outside
world, such as the
Software Freedom Conservancy?

--
Craig


On Mon, Dec 28, 2020 at 10:28 PM Glyph  wrote:
>
> It’s never been publicly documented; it was originally an internal
interface between the discussions on this list and the SFC when the project
was much smaller, so it’s probably written down in some internal
conservancy document, maybe. If we’re going to do something new, obviously
it should be a bit more transparent.
>
> On December 28, 2020 at 5:52:08 PM, Craig Rodrigues (
rodr...@crodrigues.org) wrote:
>>
>>
>>
>> On Sat, Dec 26, 2020 at 2:01 PM Glyph  wrote:
>>>
>>>
>>> I am extremely enthusiastic for your future reign on a new and improved
project leadership committee :-). Thank you for working on this!
>>>
>>
>> Where is the documentation for the existing Twisted Project Leadership
Committee?  I couldn't find it on https://twistedmatrix.com.
>> Where are the members for the existing committee listed?
>>
>> --
>> Craig
>> ___
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Upcoming Twisted Release

[Craig Rodrigues]

On Sun, Dec 27, 2020 at 3:59 PM Adi Roiban  wrote:

>
> Is there anything still blocking you ?
> Can I help?
>


I do not need specific help from you at the moment, but when I do, I will
ask.
Thanks.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Updating the project leadership committee

[Craig Rodrigues]

On Sat, Dec 26, 2020 at 2:01 PM Glyph  wrote:

>
> I am *extremely *enthusiastic for your future reign on a new and improved
> project leadership committee :-). Thank you for working on this!
>
>
Where is the documentation for the existing Twisted Project Leadership
Committee?  I couldn't find it on https://twistedmatrix.com.
Where are the members for the existing committee listed?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Upcoming Twisted Release

[Craig Rodrigues]

On Mon, Dec 28, 2020 at 10:04 AM Glyph  wrote:

>
> From what I can see though, this one is a pretty straightforward case of
> us just introducing a bug into a perfectly valid configuration though, just
> not one we happen to have in our test matrix right now.
>
>

I am working on this right now, and am taking my time with the release.
Since this is my first time doing a release,
I am erring on the side of caution, which is why I am working to make sure
that buildbot's tests pass, since they
are a good representative project of a heavy Twisted user.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Upcoming Twisted Release

[Craig Rodrigues]

On Sun, Dec 27, 2020 at 3:59 PM Adi Roiban  wrote:

> Hi Craig,
>
> On Sun, 27 Dec 2020 at 20:10, Craig Rodrigues 
> wrote:
>
>>
>>
>> On Sat, Dec 26, 2020 at 3:50 PM Adi Roiban  wrote:
>>
>>> Hi,
>>>
>>> I plan to act as a release manager for the next release and follow the
>>> plan documented at
>>>
>>>
>>> https://docs.twistedmatrix.com/en/latest/core/development/policy/release-process.html
>>>
>>>
>> I was previously working on releasing Twisted.  I was running into
>> various roadblocks, but was moving forward,
>> and got permission from Glyph to move forward with this.
>> Has this changed?
>>
>
> If you want to do the release, I am more than happy to not have to do the
> release myself :)
>

Well since Glyph gave me permission to do this, I would like to complete
this.



> OK. I closed https://twistedmatrix.com/trac/ticket/10069 as I think it's
> a duplicate.
>
> Do you or Pierre plan to fix that ticket?
>
>

I'm working on this now.

It might take me a few days to complete this, since I am in the middle of
holidays now,
so won't be able to complete a release until the beginning of January.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Upcoming Twisted Release

[Craig Rodrigues]

On Sat, Dec 26, 2020 at 3:50 PM Adi Roiban  wrote:

> Hi,
>
> I plan to act as a release manager for the next release and follow the
> plan documented at
>
>
> https://docs.twistedmatrix.com/en/latest/core/development/policy/release-process.html
>
>
I was previously working on releasing Twisted.  I was running into various
roadblocks, but was moving forward,
and got permission from Glyph to move forward with this.
Has this changed?
Unfortunately, Amber did not respond to any e-mails that I sent to her and
Glyph, so I tried to move forward the
best that I could.



>
>
> So no other tickets are in the blocker queue:
> https://twistedmatrix.com/trac/report/26
>
> --
>
> Do you know any other release blocker issues?
>
>
I filed this:
https://twistedmatrix.com/trac/ticket/10070

which I found with Pierre Tardy's help by running buildbot's test suite
against Twisted trunk.
This looks like a problem on the Twisted side, and should be fixed before a
Twisted release is pushed out.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

[Craig Rodrigues]

On Mon, Oct 12, 2020 at 11:36 AM Wilfredo Sánchez Vega <
wsanc...@wsanchez.net> wrote:

>
>   Craig: this does have to work around non-black output from incremental:
> https://github.com/twisted/klein/blob/master/release.py#L86
>
>
I don't need this klein workaround at the moment.  I can confirm that my
patches to incremental produce output
that is black-compatible, when I run my patched version of incremental in
the Twisted tree.
 I am going to move forward with merging my changes to incremental and
pushing out a new
incremental release.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Re-run Azure tests

[Craig Rodrigues]

On Mon, Oct 12, 2020 at 11:12 AM Adi Roiban  wrote:

>
>> It looks like the re-run feature is broken.
>
>

No, the re-run feature in Azure is not broken.  I've managed to do it
several times successfully.
There might be some issue with your account access, but I don't know enough
about Azure
to know what your account problem might be.

In terms of moving all Azure jobs to GitHub Actions, that is certainly
something we can investigate in future,
but I don't think there is a rush to do that right away.

I have managed to successfully move all CircleCI jobs and Travis jobs to
GitHub Actions, and so far it is working
and holding up.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

[Craig Rodrigues]

On Sunday, October 4, 2020, Craig Rodrigues  wrote:

> On Sat, Oct 3, 2020 at 5:14 PM Glyph  wrote:
>
>>
>>
>>
>> Absolutely OK with me.  More than OK.  Please do this!  I can't wait
>> until we have the level of automation you've been working on for
>> *anybody* to cut the release.  I take it this means you'll officially be
>> the release manager for 20.10.0?
>>
>> Let me know if you need any more permission bits to make progress.
>>
>
>
> If it is OK with Amber and you, then yes, I can officially be the release
> manager for the next Twisted release,
> which will be 20.10.0.
>
> I need help with the following:
>
> *Incremental*
> I'd like to get these patches into Incremental and deploy a new
> Incremental release:
>
>- https://github.com/twisted/incremental/pull/60 , Make the output of
>Incremental compatible with black
>- https://github.com/twisted/incremental/pull/62 , Make dev, rc, post
>releases compatible with PEP440
>
>
> *PyPI*
>
> I used this GitHub Action to push to PyPI:
>
>   uses: pypa/gh-action-pypi-publish@v1.4.1
>   with:
> user: __token__
> password: ${{ secrets.pypi_password }}
> verbose: true
>
> I can confirm that this GitHub Action works, and it tries to push to PyPI:
>
> https://github.com/twisted/twisted/runs/1204812301?check_suite_focus=true
>
> It failed because the token does not exist.
>
> *What I need*
>
>1. a GitHub Secret named pypi_password , which contains a token which
>will allow me to upload to PyPI
>2. a GitHub Secret named test_pypi_password, which contains a token
>which will allow me to upload to test.pypi.org
>
>
> Thanks.
>




Glyph/Amber,

Can you help with this?

1.  Need to merge changes to github.com/twisted/incremental and push out a
new version.
2.  Need to generate a token at https://pypi.org/project/Twisted to permit
uploads
3.  Need to store token from 2. as a GitHub Secret named pypi_password in
github.com/twisted/twisted

I don’t have permissions to do these things.

—
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

[Craig Rodrigues]

On Sat, Oct 3, 2020 at 5:14 PM Glyph  wrote:

>
>
>
> Absolutely OK with me.  More than OK.  Please do this!  I can't wait until
> we have the level of automation you've been working on for *anybody* to
> cut the release.  I take it this means you'll officially be the release
> manager for 20.10.0?
>
> Let me know if you need any more permission bits to make progress.
>


If it is OK with Amber and you, then yes, I can officially be the release
manager for the next Twisted release,
which will be 20.10.0.

I need help with the following:

*Incremental*
I'd like to get these patches into Incremental and deploy a new Incremental
release:

   - https://github.com/twisted/incremental/pull/60 , Make the output of
   Incremental compatible with black
   - https://github.com/twisted/incremental/pull/62 , Make dev, rc, post
   releases compatible with PEP440


*PyPI*

I used this GitHub Action to push to PyPI:

  uses: pypa/gh-action-pypi-publish@v1.4.1
  with:
user: __token__
password: ${{ secrets.pypi_password }}
verbose: true

I can confirm that this GitHub Action works, and it tries to push to PyPI:

https://github.com/twisted/twisted/runs/1204812301?check_suite_focus=true

It failed because the token does not exist.

*What I need*

   1. a GitHub Secret named pypi_password , which contains a token which
   will allow me to upload to PyPI
   2. a GitHub Secret named test_pypi_password, which contains a token
   which will allow me to upload to test.pypi.org


Thanks.

--
Craig


--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

[Craig Rodrigues]

On Wed, Sep 23, 2020 at 10:11 AM Glyph  wrote:

>
>
> On Sep 22, 2020, at 3:42 PM, Craig Rodrigues 
> wrote:
>
> Amber,
>
> Can we have a new Twisted release within the next two months, say in
> Nov./Dec. timeframe, or
> sooner if you'd like?
>
>
> Given that Amber hasn't been super responsive lately, and that I firmly
> believe it should be possible to take breaks from open source (particularly
> amidst the, you know, global collapse of civilization and stuff), I will
> take the opportunity point out yet again that
> http://twisted.readthedocs.org/en/latest/core/development/policy/release-process.html
>  documents
> the release process and any sufficiently-motivated volunteer (with at least
> a *bit* of history & trust within the community) can step forward and
> receive all the permissions necessary to do all of these steps.
>
> I will personally volunteer to fill in the permissions gaps for any
> interested parties, although I don't have much bandwidth for the release
> itself.
>
> Amber, if you want to do it, go ahead and get started, I'm just saying we
> don't need to put this on your shoulders :).
>
>
I haven't heard any response from Amber, so I assume that Amber is busy
(and I hope is OK during all the pandemic).

If it is OK with Glyph and Amber, I can focus on pushing out the next
Twisted release, and hopefully get help from Adi.

I'm working now with Adi to automate more of the release actions via GitHub
Actions, and have gotten pretty far,
such as being able to build wheels of Twisted on GitHub Actions for Linux,
MacOS, and Windows.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted with pypy3 on Ubuntu 20.4, SSL error: 'ee key too small'

[Craig Rodrigues]

Adi,

Thanks for the tip.  Yes, increasing the key size in the tests definitely
eliminated this error:

https://github.com/twisted/twisted/pull/1411

--
Craig

On Tue, Sep 29, 2020 at 3:34 PM Adi Roiban  wrote:

>
>
> On Tue, 29 Sep 2020 at 23:25, Craig Rodrigues 
> wrote:
>
>> Hi,
>>
>> I ran an experiment to run the Twisted tests on Ubuntu 20.4 using this
>> version of using pypy3:
>>
>> *Python 3.6.9 (2ad108f17bdb, Apr 07 2020, 02:29:05*
>> *Pypy 7.3.1 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)*
>>
>>
>> A bunch of the conch tests failed in this Ubuntu environment:
>> https://github.com/twisted/twisted/runs/1173397508
>> like this:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> *===Error:
>> Traceback (most recent call last):  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/test/test_sslverify.py",
>> line 1780, in test_ellipticCurveDiffieHellmanonData=onData,  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/test/test_sslverify.py",
>> line 716, in loopbackself.serverPort = reactor.listenSSL(0,
>> serverFactory, serverCertOpts)  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/internet/posixbase.py",
>> line 593, in listenSSLtlsFactory =
>> tls.TLSMemoryBIOFactory(contextFactory, False, factory)  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/protocols/tls.py",
>> line 748, in __init__contextFactory =
>> _ContextFactoryToConnectionFactory(contextFactory)  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/protocols/tls.py",
>> line 629, in __init__oldStyleContextFactory.getContext()  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/internet/_sslverify.py",
>> line 1636, in getContextself._context = self._makeContext()  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/internet/_sslverify.py",
>> line 1645, in _makeContextctx.use_certificate(self.certificate)  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/OpenSSL/SSL.py",
>> line 960, in use_certificate_raise_current_error()  File
>> "/opt/hostedtoolcache/PyPy/3.6.9/x64/lib_pypy/_functools.py", line 80, in
>> __call__return self._func(*(self._args + fargs), **fkeywords)  File
>> "/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/OpenSSL/_util.py",
>> line 54, in exception_from_error_queueraise
>> exception_type(errors)OpenSSL.SSL.Error: [('SSL routines',
>> 'SSL_CTX_use_certificate', 'ee key too
>> small')]twisted.test.test_sslverify.OpenSSLOptionsECDHIntegrationTests.test_ellipticCurveDiffieHellman===*
>>
>>
>>
>> I'm not sure what the root problem is, but my suspicion is that the SSL
>> library in this particular Ubuntu environment
>> does not permit keys smaller than 2048 bits.
>>
>> Anyone have any other ideas as to the cause of this error?
>>
>>
> Hi,
>
> That is the case.
>
> One work around is append @SECLEVEL=0 to the cipher list but I think
> it's better to update the tests to use 2048 bits key.
>
> --
> Adi Roiban
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted with pypy3 on Ubuntu 20.4, SSL error: 'ee key too small'

[Craig Rodrigues]

Hi,

I ran an experiment to run the Twisted tests on Ubuntu 20.4 using this
version of using pypy3:

*Python 3.6.9 (2ad108f17bdb, Apr 07 2020, 02:29:05*
*Pypy 7.3.1 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)*


A bunch of the conch tests failed in this Ubuntu environment:
https://github.com/twisted/twisted/runs/1173397508
like this:



























*===Error:
Traceback (most recent call last):  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/test/test_sslverify.py",
line 1780, in test_ellipticCurveDiffieHellmanonData=onData,  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/test/test_sslverify.py",
line 716, in loopbackself.serverPort = reactor.listenSSL(0,
serverFactory, serverCertOpts)  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/internet/posixbase.py",
line 593, in listenSSLtlsFactory =
tls.TLSMemoryBIOFactory(contextFactory, False, factory)  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/protocols/tls.py",
line 748, in __init__contextFactory =
_ContextFactoryToConnectionFactory(contextFactory)  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/protocols/tls.py",
line 629, in __init__oldStyleContextFactory.getContext()  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/internet/_sslverify.py",
line 1636, in getContextself._context = self._makeContext()  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/twisted/internet/_sslverify.py",
line 1645, in _makeContextctx.use_certificate(self.certificate)  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/OpenSSL/SSL.py",
line 960, in use_certificate_raise_current_error()  File
"/opt/hostedtoolcache/PyPy/3.6.9/x64/lib_pypy/_functools.py", line 80, in
__call__return self._func(*(self._args + fargs), **fkeywords)  File
"/home/runner/work/twisted/twisted/build/alldeps-withcov-posix/site-packages/OpenSSL/_util.py",
line 54, in exception_from_error_queueraise
exception_type(errors)OpenSSL.SSL.Error: [('SSL routines',
'SSL_CTX_use_certificate', 'ee key too
small')]twisted.test.test_sslverify.OpenSSLOptionsECDHIntegrationTests.test_ellipticCurveDiffieHellman===*



I'm not sure what the root problem is, but my suspicion is that the SSL
library in this particular Ubuntu environment
does not permit keys smaller than 2048 bits.

Anyone have any other ideas as to the cause of this error?

Thanks.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

[Craig Rodrigues]

Adi,

In this Twisted subproject, you implemented something which releases to
Pypi upon creation of a tag:

https://github.com/twisted/twistedchecker/blob/master/.travis.yml#L23

Maybe we can do something similar for the main Twisted project.

GitHub Actions allows you to run a specific workflow in response to a
GitHub Release event:

https://github.com/actions/create-release
https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#release

So maybe we can implement your suggested steps in a new GitHub Actions
workflow specific to doing a release.

--
Craig


On Thu, Sep 24, 2020 at 4:32 PM Adi Roiban  wrote:

>
>
> Maybe the release can be simplified and automated:
>
> * Build the source and binary wheel in GitHub actions as this can be done
> for Linux (Ubuntu), Windows and macOS.
> * Host the download source and wheel files only on PyPi and publish them
> automatically from GitHub action on a new tag is created.
> * Host the documentation only on the Read The Docs.
> * Hos the API documentation on Read The Docs - might need some hacking,
> but at release we can create an API docs package as an artifact which is
> then pulled when Read The Docs documentation is created and copied as extra
> HTML files.
> * Move Twisted blog to GitHub pages... or even read the docs with a
> separate theme like Crate [1] ... if the blog is still required.
>
> --
>
> With the above implemented the release should look like:
>
> * Each time the tests for a PR are executed, pydoctor will run and
> automatically create the API files as an artifact available for download.
> * *Manually* create a new branch in which the version is updated and the
> changelog/news/release note is created and all the news fragment files are
> removed/ . Have the branch reviewed and approved with all the tests passed.
> When the pydoctor tests are executed, the API docs are created.
> * The release branches can have a naming convention line 'release-20.0.0`.
> At first the release branch can have a release candidate version and a
> GitHub can automatically push the release to PyPi.
> * *Manually* send an email to Twisted mailing list to announce the
> pre-release.
> * Once the branch is merged, *manually* push a new tag
> * The new tag should trigger the GitHub action for publishing the release
> on PyPi
> * The new merge in master should trigger the Read The Docs build... which
> now will also include the static API docs pages.
> * Once the release is done, *manually* send a new email to the mailing
> list.
>
> There are still many manual steps, but the only permissions required is
> commit to the repo.
> This will no longer use any of the Twisted own infrastructure.
>
> [1] https://sphinx-themes.org/html/crate-docs-theme/crate/basic.html
>
> --
> Adi Roiban
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Request for new Twisted release?

[Craig Rodrigues]

Amber,

Can we have a new Twisted release within the next two months, say in
Nov./Dec. timeframe, or
sooner if you'd like?

In Twisted trunk, there are a lot of things that would be good to have in a
new release.

Here are some of the high order items:

*Python 3 Fixes*

   - twist dns --pyzone now works on Python 3   (I had a project 6 months
   ago where I would have liked to have this in a release)
   - twisted.web.twcgi now works on Python 3


*Python 3.8 Fixes*

   - all tests pass on all platforms on Python 3.8, including asyncio tests
   on Windows


*Python 3.9 Fixes*

   - all tests pass on Python 3.9.0rc2 (at least on Mac and Linux), (thanks
   to Michał Górny)


*Python 2.7*

   - Python 2.7 support has been dropped in trunk

*Black*

   - black code formatter has been integrated into the CI for Twisted, and
   all Twisted code is now formatted with Black (thanks to Tom Most)

*Mypy*

   - mypy is now run as part of Twisted CI and checks the code for every
   PR.  Type annotations compatible with Python 3.5+ are slowly being added to
   the codebase.


There are a lot of other small fixes and enhancements that people have
contributed since the last Twisted release.

I would like this new release to be the last release supporting Python 3.5,
so that Python 3.5 support can be removed in trunk, and PEP-526 style
variable annotations can be added in trunk.

Thanks for your consideration.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Only run Azure, Travis, or CircleCI if GitHub actions pass

[Craig Rodrigues]

On Sun, Sep 20, 2020 at 9:22 PM Glyph  wrote:

>
>
> On Sep 19, 2020, at 5:27 PM, Adi Roiban  wrote:
>
>
>
> On Sat, 19 Sep 2020 at 21:30, Craig Rodrigues 
> wrote:
>
>> Adi,
>>
>> Is it possible to configure the CI so that
>> Azure, Travis and CircleCI only runs if GitHub actions pass?
>>
>> For example here:
>>
>> https://github.com/twisted/twisted/runs/1137175269
>>
>> *Azure Pipelines* and *Travis* should only run if the GitHub actions
>> pass.
>>
>>
> My question is: why would we want to do this?  It seems like it would just
> make it slower to get feedback for contributors.
>


If some jobs such as lint or mypy fail first quickly, then there is no
point in running the full
test suite.  That would give feedback faster to contributors that they need
to do some minor
fixes, before wasting cycles running the full test suite.

When CI using Azure Pipelines was implemented for Twisted,  Azure Pipelines
offered runners that ran on Windows which seemed to be more reliable than
Appveyor (which was what was used at the time).  Azure Pipelines also
offers runners that run on MacOS X.
If GitHub Actions offers runners for Windows and MacOS X which are reliable
enough,
the existing CI for Azure Pipelines could be moved to GitHub Actions quite
easily.

For CircleCI and Travis, probably those CI's could be moved to GitHub
Actions if we wanted, since those are running on Linux,
and aren't doing anything too sophisticated.

For the free version of GitHub Actions, the limits are 20 concurrent jobs
(I guess on Linux), and 5 concurrent jobs on  MacOS:

https://docs.github.com/en/actions/reference/usage-limits-billing-and-administration#usage-limits

I think that is more than enough for Twisted's CI needs.

There is no rush to move everything to GitHub Actions, but that is
something we can consider over time.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Only run Azure, Travis, or CircleCI if GitHub actions pass

[Craig Rodrigues]

Adi,

Is it possible to configure the CI so that
Azure, Travis and CircleCI only runs if GitHub actions pass?

For example here:

https://github.com/twisted/twisted/runs/1137175269

*Azure Pipelines* and *Travis* should only run if the GitHub actions pass.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

[Craig Rodrigues]

For https://button.flattr.com/flattr-badge-badge-large.png it looks like
this was deprecated in 2017.
In this blog post:
https://blog.flattr.com/2017/10/the-flattr-relaunch-what-to-expect/ :

*As the Flattr button is history you should not add it to your site
anymore.*


For https://www.paypalobjects.com/en_US/i/scr/pixel.gif' , I filed this
bug:

https://github.com/paypal/paypal-checkout-components/issues/1432

--
Craig


On Thu, Sep 17, 2020 at 12:47 PM Craig Rodrigues 
wrote:

> Doing a force refresh in my browser fixed it.  I can now click on
> *Publish/Subscribe* and switch the tab.
>
> I'm still seeing these errors which is causing the Paypal and Flattr gif's
> not to load:
>
> Access to image at 'https://www.paypalobjects.com/en_US/i/scr/pixel.gif'
> from origin 'https://twistedmatrix.com' has been blocked by CORS policy:
> No 'Access-Control-Allow-Origin' header is present on the requested
> resource.
> (Access to image at 'https://button.flattr.com/flattr-badge-large.png'
> from origin 'https://twistedmatrix.com' has been blocked by CORS policy:
> No 'Access-Control-Allow-Origin' header is present on the requested
> resource.
>
> I'm not familiar with CORS, so don't know what the proper fix for this is.
>
> Thanks for fixing this.
> --
> Craig
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

[Craig Rodrigues]

Doing a force refresh in my browser fixed it.  I can now click on
*Publish/Subscribe* and switch the tab.

I'm still seeing these errors which is causing the Paypal and Flattr gif's
not to load:

Access to image at 'https://www.paypalobjects.com/en_US/i/scr/pixel.gif'
from origin 'https://twistedmatrix.com' has been blocked by CORS policy: No
'Access-Control-Allow-Origin' header is present on the requested resource.
(Access to image at 'https://button.flattr.com/flattr-badge-large.png' from
origin 'https://twistedmatrix.com' has been blocked by CORS policy: No
'Access-Control-Allow-Origin' header is present on the requested resource.

I'm not familiar with CORS, so don't know what the proper fix for this is.

Thanks for fixing this.
--
Craig




On Thu, Sep 17, 2020 at 11:55 AM Glyph  wrote:

> This is the JS that I specifically changed, which is no longer being
> served by twistedmatrix.com, so just like… reload harder, or something.
> Clear your cookies, zap your caches, restart your browser, repent of your
> sins, etc.  Maybe repent before clearing the caches so you don't have any
> cached sins either.
>
> If you want to work on this yourself, we do have *something* of a local
> staging infrastructure set up with... vagrant, I think?, but I haven't
> tried it.  If you want to test your changes in developmestuction, check out
> braid, edit the HTML and JS in t-web, push to master, and then `fab
> config.production t-web.update`.
>
> Good luck,
>
> -g
>
> P.S.: braid still requires python2, so anybody enthusiastic about python3
> porting is encouraged to take a look at it :-).
>
> On Sep 17, 2020, at 8:37 AM, Craig Rodrigues 
> wrote:
>
> Thanks for looking into this.  Now I am seeing this error on the
> https://twistedmatrix.com :
>
> jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:136
> Uncaught Error: Must call google.charts.load before
> google.charts.setOnLoadCallback
> at Object.J.R [as setOnLoadCallback]
> (jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:136)
> at twisted.js:92
> jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:141
> Uncaught Error: Module "feeds" is not supported.
> at
> jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:141
>
>
> Where is that coming from?
>
>
> --
> Craig
>
> On Wed, Sep 16, 2020 at 11:28 PM Glyph  wrote:
>
>> We were depending on some Google APIs that were disabled a really long
>> time ago, so I pushed & deployed this commit <
>> https://github.com/twisted-infra/braid/commit/1df63c5d8b44e079487be2f0bf099108a77872e5>
>> to get the front page back to working.
>>
>> -g
>>
>> On Sep 16, 2020, at 2:53 PM, L. Daniel Burr  wrote:
>>
>> Hi Craig,
>>
>> No error is being emitted to the console when you click on a tab.  There
>> are some cross-origin script failures being logged, and Firefox blocked
>> google urchin, which causes some more error messages.
>>
>> As far as I can tell, the JS code that is supposed to hook up the
>> clicking of the tab (an anchor tag with a relative href) is not being
>> executed, either because it is being blocked by the browser, or as a
>> side-effect of other things being blocked.
>>
>> Hope this helps,
>>
>> Daniel
>> --
>> L. Daniel Burr
>> ldanielb...@me.com
>> (312) 656-8387
>>
>> On Sep 16, 2020, at 4:36 PM, Craig Rodrigues 
>> wrote:
>>
>> If I go to https://twistedmatrix.com and click on
>> one of the tabs in the *Code Examples* section,
>> such as *Publish/Subscribe*, the tab does not switch.
>>
>> This looks like a Javascript problem.  Does anyone with knowledge
>> of Javascript have an idea what the problem is?
>>
>> --
>> Craig
>> ___
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>>
>>
>> ___
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>>
>>
>> ___
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

[Craig Rodrigues]

Thanks for looking into this.  Now I am seeing this error on the
https://twistedmatrix.com :

jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:136
Uncaught Error: Must call google.charts.load before
google.charts.setOnLoadCallback
at Object.J.R [as setOnLoadCallback]
(jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:136)
at twisted.js:92
jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:141
Uncaught Error: Module "feeds" is not supported.
at
jsapi?key=ABQIJE-f7vmwI1-jxkmwRe4lUxTAs18ELyhzmLGaHoc1qJwmpJy3zhR3LMRRdwqg5PSY4tnVO684msUklQ:141


Where is that coming from?


--
Craig

On Wed, Sep 16, 2020 at 11:28 PM Glyph  wrote:

> We were depending on some Google APIs that were disabled a really long
> time ago, so I pushed & deployed this commit <
> https://github.com/twisted-infra/braid/commit/1df63c5d8b44e079487be2f0bf099108a77872e5>
> to get the front page back to working.
>
> -g
>
> On Sep 16, 2020, at 2:53 PM, L. Daniel Burr  wrote:
>
> Hi Craig,
>
> No error is being emitted to the console when you click on a tab.  There
> are some cross-origin script failures being logged, and Firefox blocked
> google urchin, which causes some more error messages.
>
> As far as I can tell, the JS code that is supposed to hook up the clicking
> of the tab (an anchor tag with a relative href) is not being executed,
> either because it is being blocked by the browser, or as a side-effect of
> other things being blocked.
>
> Hope this helps,
>
> Daniel
> --
> L. Daniel Burr
> ldanielb...@me.com
> (312) 656-8387
>
> On Sep 16, 2020, at 4:36 PM, Craig Rodrigues 
> wrote:
>
> If I go to https://twistedmatrix.com and click on
> one of the tabs in the *Code Examples* section,
> such as *Publish/Subscribe*, the tab does not switch.
>
> This looks like a Javascript problem.  Does anyone with knowledge
> of Javascript have an idea what the problem is?
>
> --
> Craig
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

[Craig Rodrigues]

If I go to https://twistedmatrix.com and click on
one of the tabs in the *Code Examples* section,
such as *Publish/Subscribe*, the tab does not switch.

This looks like a Javascript problem.  Does anyone with knowledge
of Javascript have an idea what the problem is?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] code contribution/participation policy

[Craig Rodrigues]

On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein  wrote:

>
> Now how do I proceed? What is the convention for Git brach names, etc?
>
>
This document should give you the steps to create a Git branch and proceed
with a PR:

https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Pycodestyle disabled in trunk, time to enable black?

[Craig Rodrigues]

In this PR:
https://github.com/twisted/twisted/pull/1365

pycodestyle was disabled in trunk in order to make it easier to merge
changes
and not have pycodestyle error out, due to the code not meeting existing
Twisted style guidelines.
So this means that the old pycodestyle is not enforced in trunk.

In this PR:
https://github.com/twisted/twisted/pull/1356

a `.git-blame-ignore-revs
`
file was added to the tree.  I guess in future,
if the entire tree is reformatted, then we can add that git SHA for the PR
which reformats
the tree, so that that revision will be ignored during a `git blame`.

There is this pending (over 1 year) PR to add black to CI:

https://github.com/twisted/twisted/pull/1134

There are some comments in there related to documentation changes.
Can the non-documentation changes be pulled out of PR 1134 and merged to
trunk now?

I guess whenever black is merged to trunk, then a follow-up PR to update
`.git-blame-ignore-devs` would be required?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Change Trac /login link to point to /trac/github/login

[Craig Rodrigues]

Where in https://github.com/twisted-infra/braid/ does this change need to
be done?

I'm not familiar with how braid works.

--
Craig

On Sat, Aug 29, 2020 at 11:30 PM Glyph  wrote:

> If you can express this as a PR to Braid, I can promise you I'll merge &
> apply it, but that's probably the maximum energy I can personally afford to
> dedicate to it :).
>
> On Aug 29, 2020, at 10:56 AM, Craig Rodrigues 
> wrote:
>
> If I am not logged in, and click on:
>
> https://twistedmatrix.com/trac/newticket
>
> It takes me to a page:
>
>  You are currently not logged in. You may want to do so
> <https://twistedmatrix.com/trac/login> now.
>
> If I click on *do so*, it takes me to:
>
> No handler matched request to /login
>
> Can this be fixed on the Trac side so that */login* redirects to:
> https://twistedmatrix.com/trac/github/login ?
> Or change *do so* to hyperlink to */trac/github/login*?
>
> This is a stumbling block when new contributors are asked to open a ticket
> in Trac.
>
> --
> Craig
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Change Trac /login link to point to /trac/github/login

[Craig Rodrigues]

If I am not logged in, and click on:

https://twistedmatrix.com/trac/newticket

It takes me to a page:

 You are currently not logged in. You may want to do so
 now.

If I click on *do so*, it takes me to:

No handler matched request to /login

Can this be fixed on the Trac side so that */login* redirects to:
https://twistedmatrix.com/trac/github/login ?
Or change *do so* to hyperlink to */trac/github/login*?

This is a stumbling block when new contributors are asked to open a ticket
in Trac.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] mypy now mandatory for Twisted pull requests

[Craig Rodrigues]

Hi,

In the Twisted trunk branch, I have reduced the number of errors reported
by mypy to *zero!*
You verify this by running:

*tox -e mypy*

In addition, I have worked with Adi to enable CI for Twisted checkins so
that mypy is
run for each pull request.  Adi configured the GitHub repo to  *require*
mypy to pass in order for a Twisted pull request to be merged.

Thanks to Adi, Wilfredo, Tom, and Maarten for helping with various
mypy-related code reviews!
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Running tests with monkeytype

[Craig Rodrigues]

On Sat, Jun 20, 2020 at 4:02 PM Tom Most  wrote:

>
> Let's definitely move to type annotations, since they are much more likely
> to be correct due to validation by MyPy.
>
> To start, we'll need to revise the Twisted coding standard [1] to permit
> type annotations instead of @type lines in the docstring. I think that we
> should suggest, but not require, annotation syntax to start. I filed a
> ticket [2] for this.
>
>
Revising the Twisted coding standard to permit (and even encourage) type
annotations is a great idea.
Using epydoc's @type tags in docstring was OK, but epydoc is not
a tool that is universally used in the Python world.  At the time, using
epydoc tags was the best that could be done.
Type annotations are a first-level language feature, that is part of the
core Python toolchain.  There seems to be growing support for type
annotations from various tools, IDE's,
Python libraries, and the core Python toolchain itself.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] mypy: class ThreadPool has workers redefined

[Craig Rodrigues]

While looking at these mypy logs:

https://dev.azure.com/twistedmatrix/twisted/_build/results?buildId=1904=logs=d78da089-4bf6-58fe-28a5-46635fd5b8d1=45ce7910-c28c-5e9a-4ee7-e041d314a5fc

I found an interesting one:

src/twisted/python/threadpool.py:84:6: error: Name 'workers' already
defined on line 44  [no-redef]


Looking at: 
https://github.com/twisted/twisted/blob/trunk/src/twisted/python/threadpool.py,
I see:

workers = 0

@property
def workers(self):


What is the correct way to fix this?  Is deleting the workers variable correct?

--

Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Question about FileDescriptor.loseConnection() signature found by mypy

[Craig Rodrigues]

twisted.internet.abstract.FileDescriptor.loseConnection() was changed here
in 2004:
https://github.com/twisted/twisted/commit/081d393ab03da92d744d8fb2b5d77705662a0caa

This change was done so long ago, but I think changing the signature like
that was wrong.

I took a guess at how to fix this and submitted this:

https://github.com/twisted/twisted/pull/1292

--
Craig


On Tue, Jun 16, 2020 at 1:52 AM Glyph  wrote:

>
>
> > On Jun 15, 2020, at 8:43 PM, Craig Rodrigues 
> wrote:
> >
> > In twisted.internet.abstract.FileDescriptor.loseConnection, the
> loseConnection method
> > is defined like:
> >
> > def loseConnection(self,
> _connDone=failure.Failure(main.CONNECTION_DONE)):
>
> I think this signature might just be... wrong?  ITransport doesn't include
> it.  Does anything actually use this argument?
>
> -g
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Question about FileDescriptor.loseConnection() signature found by mypy

[Craig Rodrigues]

In twisted.internet.abstract.FileDescriptor.loseConnection, the
loseConnection method
is defined like:

def loseConnection(self,
_connDone=failure.Failure(main.CONNECTION_DONE)):

while in twisted.internet._newtls.ConnectionMixin , we have:

  def loseConnection(self):


If I run *tox -e mypy*  in trunk, mypy complains with this:

src/twisted/internet/tcp.py:204:1: error: Definition of
"loseConnection" in base class "ConnectionMixin" is incompatible with
definition in base class "FileDescriptor"  [misc]

src/twisted/internet/tcp.py:527:1: error: Definition of
"loseConnection" in base class "ConnectionMixin" is incompatible with
definition in base class "FileDescriptor"  [misc]
src/twisted/internet/tcp.py:780:1: error: Definition of
"loseConnection" in base class "ConnectionMixin" is incompatible with
definition in base class "FileDescriptor"  [misc]
src/twisted/internet/tcp.py:789:1: error: Definition of
"loseConnection" in base class "ConnectionMixin" is incompatible with
definition in base class "FileDescriptor"  [misc]

src/twisted/internet/unix.py:243:1: error: Definition of
"loseConnection" in base class "ConnectionMixin" is incompatible with
definition in base class "FileDescriptor"  [misc]
src/twisted/internet/unix.py:431:1: error: Definition of
"loseConnection" in base class "ConnectionMixin" is incompatible with
definition in base class "FileDescriptor"  [misc]


Do the signatures of loseConnection need to match in order for this to
be a valid subclass?

Is there any way to fix the code so that the mypy error goes away, or
do we need to add a comment to turn off the mypy error here?


--

Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

[Craig Rodrigues]

Thanks to Adi and Wilfredo who have reviewed my PR's.  Currently in trunk,
I have eliminated hundreds of mypy
errors through a combination of trivial fixes to code, adding type
annotations, and adding special comments
to turn off mypy errors in a few places.

I have one more pending PR ( https://github.com/twisted/twisted/pull/1290 ) to
turn on a mypy build in an Azure pipeline.
In this run of *tox -e mypy* there are* 437* errors from mypy:

https://dev.azure.com/twistedmatrix/twisted/_build/results?buildId=1904=logs=d78da089-4bf6-58fe-28a5-46635fd5b8d1=45ce7910-c28c-5e9a-4ee7-e041d314a5fc

I think we can gradually whack these down to zero mypy errors, and turn
mypy on as part of default CI for Twisted.

--
Craig

On Wed, Apr 22, 2020 at 12:28 AM Glyph  wrote:

>
> The first step here, however, is to set up the CI infrastructure (tox,
> etc) to run mypy so that we can ensure that as we start writing type hints,
> we don't accidentally get any of them wrong and back ourselves into any
> corners.  Mypy can catch a surprising number of bugs with just the implicit
> type-checking it does on values that come from the standard library.  In
> fact, if we do `mypy src/twisted` right now, and exclude the things that
> would be fixed by adding in https://github.com/Shoobx/mypy-zope ("method
> must have at least one argument" zope.interface definition errors) and
> fixing up some simple type hints (has no attribute "skip") we still have
> almost a thousand type errors that we should figure out a way to start
> correcting or systematically skipping if they're false positives.  I
> guarantee you there's at least one real bug in there though.
>
> As you know, I tend to be pretty cautious about sweeping changes to the
> code that might make it harder to maintain on older versions - type hints
> are an exception where I think it's absolutely worthwhile to go All In
> early on.  But CI infrastructure for this stuff is a must-have and it might
> be tricky to get set up initially.
>
> -glyph
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

[Craig Rodrigues]

I have merged a few PR's to trunk which eliminate hundreds of errors
encountered with:


*tox -e mypy*
I think we can take several passes with more PR's to whack away all these
mypy errors,
and turn on mypy as part of the default CI for Twisted.

I have seen a few errors like:

src/twisted/words/protocols/jabber/sasl_mechanisms.py:47:1: error:
'Anonymous' is missing following 'ISASLMechanism' interface members:
getResponse.  [misc]
class Anonymous(object):
src/twisted/words/protocols/jabber/sasl_mechanisms.py:61:1: error: 'Plain'
is missing following 'ISASLMechanism' interface members: getResponse.
 [misc]
class Plain(object):
src/twisted/internet/_dumbwin32proc.py:110:1: error: 'Process' is missing
following 'twisted.internet.interfaces.ITransport' interface members:
getHost, getPeer.  [misc]
class Process(_pollingfile._PollingTimer, BaseProcess):
src/twisted/internet/process.py:959:1: error: 'PTYProcess' is missing
following 'twisted.internet.interfaces.ITransport' interface members:
getHost, getPeer.  [misc]
class PTYProcess(abstract.FileDescriptor, _BaseProcess):
src/twisted/internet/process.py:959:1: error: 'PTYProcess' is missing
following 'IProcessTransport' interface members: closeChildFD,
writeToChild.  [misc]
class PTYProcess(abstract.FileDescriptor, _BaseProcess):
src/twisted/internet/base.py:504:1: error: 'ReactorBase' is missing
following 'IReactorCore' interface members: run.  [misc]
class ReactorBase(PluggableResolverMixin)


For a class to properly implement a Zope interface, is it mandatory that
it  implement every method in that interface?

If we modify the classes with mypy errors to properly implement these
methods (even with no-ops) is that the correct
way to go?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

[Craig Rodrigues]

Personally, I don't have any dependencies on Python 3.5.
I just suggested once year's notice to give people time to adjust,
but if no one really cares, dropping 3.5 support some time this year is
fine by me.

Maybe it would be OK to do one more release of Twisted and announce that as
the last release supporting Python 3.5, before
dropping support?
--
Craig


On Wed, May 13, 2020 at 10:37 PM Amber Brown 
wrote:

> Xenial's 3.5.1/3.5.2 sucks and doesn't have some asyncio functionality
> (due to it being provisional then?) which means things like Eliot doesn't
> work due to aiocontextvars barfing on missing functionality. There's also
> 20.04 LTS now, making 16.04 old-old-LTS. I don't think it's worth it.
>
> - Amber
>
> On Thu, 14 May 2020, at 15:18, Moshe Zadka wrote:
> > May 2021 seems to be right around when Xenial (Which has 3.5) falls
> > into ESM, so maybe we can wait?
> > I don't have strong feelings, but it is a datapoint.
> >
> > Moshe Z.
> >
> > On Wed, May 13, 2020, at 22:13, Glyph wrote:
> > > On May 13, 2020, at 10:04 PM, Amber Brown (hawkowl) <
> hawk...@atleastfornow.net> wrote:
> > > >
> > > > On 14/5/20 5:10 am, Craig Rodrigues wrote:
> > > >> I would like to propose that Twisted drop support for Python 3.5
> one year from now in 2021.
> > > >
> > > > I was considering proposing dropping it soon (I was thinking when we
> had 3.8 support, that 3.6/3.7/3.8 is a reasonable compatibility matrix).
> > >
> > >
> > > I'm also inclined to say sooner rather than later; I don't know the
> numbers but my impression is that 3.x uptake began for real at 3.4 and in
> earnest at 3.6, so there aren't that many people still on 3.5.
> > >
> > > The lack of variable annotations, in particular, seems like a sticking
> point with 3.5 as we attempt to adopt mypy.
> > >
> > > -g
> > >
> > >
> > > ___
> > > Twisted-Python mailing list
> > > Twisted-Python@twistedmatrix.com
> > > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
> > >
> >
> > ___
> > Twisted-Python mailing list
> > Twisted-Python@twistedmatrix.com
> > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
> >
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

[Craig Rodrigues]

On Wed, May 13, 2020 at 10:05 PM Amber Brown (hawkowl) <
hawk...@atleastfornow.net> wrote:

>
> So, I guess if we have 3.8 support, the next release can announce the
> dropping of 3.5, and then the release after that can be the final one
> with support.
>

In trunk, on Python 3.8, all the tests in CI pass on Mac and Linux.
With Windows and Python 3.8, there are 6 errors due to AyncioReactorTests
failing:
https://dev.azure.com/twistedmatrix/twisted/_build/results?buildId=1771=logs=ea01aad7-d5f3-5f0e-2fda-71d72e596cac=f47a629b-ce24-5ee0-314a-24c887b72299=16071

most likely due to this: https://twistedmatrix.com/trac/ticket/9766

where in Python 3.8, the ProactorEventLoop was made the default on Windows.

So once this is fixed on Windows, I think we are pretty close to having
clean CI runs on Python 3.8 on all platforms.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

[Craig Rodrigues]

I would like to propose that Twisted drop support for Python 3.5 one year
from now in 2021.

Reasons:

1.  Python 3.5.9 will be the final release of Python 3.5, in November 2019
( https://www.python.org/dev/peps/pep-0478/ )
2.  Python 3.6.0 was released in December 2016 (
https://www.python.org/dev/peps/pep-0494/ )
3.  PyPy 7.1.1  introduced Python 3.6 support in April 2019 (
https://morepypy.blogspot.com/2019/04/pypy-711-bug-fix-release.html ).
PyPy 7.3.1 is the latest PyPy version (
https://morepypy.blogspot.com/2020/04/pypy-731-released.html ).

4.  Python 3.6 introduced support for variable annotations (
https://www.python.org/dev/peps/pep-0526/ )
5.  Python 3.6 introduced new string interpolation (f-string) support (
https://www.python.org/dev/peps/pep-0498/ )
6.  Python 3.6 introduced support for asynchronous generators (
https://www.python.org/dev/peps/pep-0525/ ) and asynchronous comprehensions
( https://www.python.org/dev/peps/pep-0530/ )



Based on item 2., Python 3.6.0 has been around for almost 4 years, which is
a reasonable amount of time.
Based on item 3., PyPy supports Python 3.6.

It might be nice to take advantage of some of the language features
introduces in items 4-6.

I think dropping support one year from now in 2021, would give sufficient
notice, and be in line with
the Twisted Compatibility Policy (
https://twistedmatrix.com/documents/current/core/development/policy/compatibility-policy.html
).

None of these items are critial, but I thought I would ask, to get people's
opinions.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

[Craig Rodrigues]

On Wed, Apr 22, 2020 at 12:28 AM Glyph  wrote:

>
>
> On Apr 21, 2020, at 8:57 PM, Craig Rodrigues 
> wrote:
>
> Does anyone else have opinions on
> type hints and mypy?
>
>
> We use them at work, and on some other Twisted projects (Klein) and
> they're absolutely awesome.  Even with type comments, mypy is a huge
> upgrade to how one writes and maintains Python; with annotations, it's a
> major upgrade to the language.
>
> The first step here, however, is to set up the CI infrastructure (tox,
> etc) to run mypy so that we can ensure that as we start writing type hints,
> we don't accidentally get any of them wrong and back ourselves into any
> corners.  Mypy can catch a surprising number of bugs with just the implicit
> type-checking it does on values that come from the standard library.  In
> fact, if we do `mypy src/twisted` right now, and exclude the things that
> would be fixed by adding in https://github.com/Shoobx/mypy-zope ("method
> must have at least one argument" zope.interface definition errors) and
> fixing up some simple type hints (has no attribute "skip") we still have
> almost a thousand type errors that we should figure out a way to start
> correcting or systematically skipping if they're false positives.  I
> guarantee you there's at least one real bug in there though.
>
> As you know, I tend to be pretty cautious about sweeping changes to the
> code that might make it harder to maintain on older versions - type hints
> are an exception where I think it's absolutely worthwhile to go All In
> early on.  But CI infrastructure for this stuff is a must-have and it might
> be tricky to get set up initially.
>



Earlier this week, I merged to trunk a new tox rule for running mypy with
mypy-zope.  You can use it by
running the following command in the top-level Twisted directory:

*tox -e  mypy*

mypy reports a lot of errors, but I think we can take several passes
through the Twisted codebase to clean those up.

Once we clean up the errors, we can integrate the tox rule with Travis or
Azure CI or CircleCI (whatever works best).

I submitted a few PR's to start cleaning up these errors:

   - https://github.com/twisted/twisted/pull/1264  (has no attribute "skip")
   - https://github.com/twisted/twisted/pull/1261 (Too few arguments to
   "makeTestCaseClasses")

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

[Craig Rodrigues]

Hi,

Last week I did some work and updated twistedchecker
so that it uses pylint >= 2.4.4.  Before that, it was using a really old
version
of pylint.

twistedchecker is run over the Twisted code as part of CI, and reports
various style issues.  Now that twistedchecker is using a newer pylint,
it should be compatible with newer Python language features.

Now that Twisted supports Python 3.5+ (with Python 2.7 support being
dropped),
is it OK to start using newer features of the Python language in the
Twisted codebase
such as type hints ( https://docs.python.org/3/library/typing.html )?

I don't have experience with that feature, but it looks like it could be
useful,
when combined with a tool like mypy.  Does anyone else have opinions on
type hints and mypy?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Drop support for Python 3.4?

[Craig Rodrigues]

What do people think of dropping Twisted support for Python 3.4?

According to https://devguide.python.org/#status-of-python-branches

Python 3.4 EOL'd on March 19, 2019.

In the Python 3 world, we have Python 3.4, 3.5, 3.6, 3.7, and at
the end of this year we will have Python 3.8.

That's quite a lot of Python versions to support.

Python 3.5 introduced async/await keywords, which are very relevant to
Twisted:
https://docs.python.org/3.5/whatsnew/3.5.html#whatsnew-pep-492

If it makes sense, it would be nice to use these keywords as first-level
features in Twisted.

Since Amber brought up discussion of dropping Python 2.7 here:
https://twistedmatrix.com/pipermail/twisted-python/2019-March/032234.html

I thought I would raise dropping Python 3.4 also.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] A Proposal for reducing the burden of developing on Twisted by dropping Python 2 support

[Craig Rodrigues]

On Mon, Mar 25, 2019 at 3:15 AM Amber Brown 
wrote:

>
>
>
> You can find the proposal here, in this handy-dandy Google Doc:
>
> https://docs.google.com/document/d/1S4CGgZC09blLIdk3Zo7wBa75A9_JuuH_3akkyjN0lik/edit
>
>
>
Thanks for writing that doc.
I think option 3 of making Twisted 19.4 the last Python 2 release, with
security updates until 2021 is
actually pretty reasonable.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Fix link on trac for logging in

[Craig Rodrigues]

Where is the Twisted Web config for specifying redirects of
twistedmatrix.com?  For this case, adding a redirect seems better than
modifying the Trac code.

--
Craig

On Saturday, August 18, 2018, Glyph  wrote:

>
> (Alternately, maybe just make /trac/login a redirect in the web server?)
>
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Fix link on trac for logging in

[Craig Rodrigues]

Is there someone with access to the twistedmatrix Trac source code
who can fix the text at the place where it says *You are not logged in* aftr
clicking on
https://twistedmatrix.com/trac/newticket ?

--
Craig

On Thu, Jun 14, 2018 at 11:21 AM Craig Rodrigues 
wrote:

> Hi,
>
> If a user clicks on this link:
> https://twistedmatrix.com/trac/newticket
>
> They see this text:
>
> You are currently not logged in. You may want to do so
> <https://twistedmatrix.com/trac/login> now.
>
> The link on "do so" is wrong.
>
> *Can someone fix that link to point to the Github login link?*
>
> Ideally, this link:
> https://twistedmatrix.com/trac/login
>
> should redirect to:
> https://twistedmatrix.com/trac/github/login
>
> Because there seem to be various paths that users are hitting the
> first link and then getting confused when they can't log into Trac.
> --
> Craig
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] subunitreporter 18.7.5

[Craig Rodrigues]

On Mon, Jul 9, 2018 at 12:03 PM Jean-Paul Calderone <
exar...@twistedmatrix.com> wrote:

>
> One useful thing to do with a subunit v2 stream is convert it to junitxml
> and let CircleCI ingest it.  This is precisely the reason I've written this
>

Jenkins also uses junitxml to parse test results.  This is highly useful.
Would it be worth modifying twisted's setup.py to pull in subunitreporter
as an optional module?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Fix link on trac for logging in

[Craig Rodrigues]

Hi,

If a user clicks on this link:
https://twistedmatrix.com/trac/newticket

They see this text:

You are currently not logged in. You may want to do so
 now.

The link on "do so" is wrong.

*Can someone fix that link to point to the Github login link?*

Ideally, this link:
https://twistedmatrix.com/trac/login

should redirect to:
https://twistedmatrix.com/trac/github/login

Because there seem to be various paths that users are hitting the
first link and then getting confused when they can't log into Trac.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

[Craig Rodrigues]

On Thu, Apr 12, 2018 at 10:35 PM, Amber Brown 
wrote:

> It does on master, i think, but unsupported doesn't run on PRs.
>
> I'm happy to move it to supported if we're happy with it! I think since it
> runs all the main reactors plus asyncio, we can be relatively trusting of
> it being green now...
>
>
That build runs select, poll, epoll, and asyncio reactors.  So since there
are about 12,000 tests, running 4 times, that is about 48,000 tests
for this builder.  That took 39 minutes.
That's a bit long, but maybe that's OK.
I don't know if it is worth figuring out any ways to optimize this run by
maybe using "trial -j", or splitting
the run of each reactor into a new builder.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

[Craig Rodrigues]

On Thursday, April 12, 2018, Amber Brown  wrote:

> My work is paying off... :)
>


Thank you!!

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] pypy3 builds passing?

[Craig Rodrigues]

Hi,

I just took a look at this:

https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy3/builds/27

running with:

Python 3.5.3 (3f6eaa010fce, Jan 11 2018, 04:44:35)
[PyPy 5.10.1 with GCC 6.2.0 20160901]


Ran 12268 tests in 455.535s

PASSED (skips=2240, successes=10028)


Is that a fluke, or have we made good progress with pypy?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Problem with osx10.10-py2.7 builder

[Craig Rodrigues]

On Sun, Mar 25, 2018 at 5:01 AM, Adi Roiban <a...@roiban.ro> wrote:

> Hi,
>
>
> On 25 March 2018 at 05:14, Craig Rodrigues <rodr...@crodrigues.org> wrote:
> > Hi,
> >
> > Can someone check this builder:
> >
> > https://buildbot.twistedmatrix.com/builders/osx10.10-py2.7
> >
> > It is failing randomly in weird ways during builds.  For example,
> > in some cases it fails to install tox.  In other cases, the tests
> terminate
> > in
> > some random spot.
>
> I will try and take a look at it.
>
> If someone knows more about the slave running this build, please add
> the info on wiki at:
>
> https://twistedmatrix.com/trac/wiki/ContinuousIntegration/Buildslaves
>


Where is this MacOS builder?  Is it in Rackspace, some cloud provider, or
other?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Problem with osx10.10-py2.7 builder

[Craig Rodrigues]

Hi,

Can someone check this builder:

https://buildbot.twistedmatrix.com/builders/osx10.10-py2.7

It is failing randomly in weird ways during builds.  For example,
in some cases it fails to install tox.  In other cases, the tests terminate
in
some random spot.

This builder is marked as "Required", so it is a bit annoying.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Enable rolling builds for Appveyor

[Craig Rodrigues]

On Sat, Mar 24, 2018 at 5:35 PM, Adi Roiban  wrote:

>
> Mark is fast :)
>
> While the Appveyor is set up under my username, I think that the whole
> Twisted team has admin permissions.
>
> Not sure if automatically, or someone else is manually adding team members.
> I see that Ilya Skriblovsky is onboard :)
>
> Craig, you are registered as admin using the bsd email address.
> Let us know if you are using other email for Appveyor.
>
> I would like to move this to something like
> https://ci.appveyor.com/project/TWISTED/twisted/, but I don't know
> how.
>


Thanks, Mark, for making the change.
Since I didn't set up appveyor and it isn't in my name, I didn't
want to touch anything in it without at least letting folks know on
this list.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] RunningTwisted tests on Windows and SSL

[Craig Rodrigues]

Do not run the tests directly from the source tree.
Instead, you should install Twisted into a virtualenv
and run "trial twisted" from inside the virtualenv and outside the source
tree.
The installer has some logic to omit the installation of certain modules
and tests
which do not work on Python 3.

You can also run the tests by using tox as specified here:

https://github.com/twisted/twisted/blob/trunk/README.rst#unit-tests

because tox takes care of setting up the virtualenv and running the
tests inside the virtualenv.

--
Craig



On Sat, Mar 17, 2018 at 2:58 AM, John Aherne  wrote:

>
>
> twisted.cred.test.test_strcred.SSHCheckerTests.test_isChecker
> 
> ===
> [ERROR]
> Traceback (most recent call last):
>   File "c:\twistedssl\twisted\src\twisted\mail\test\test_mail.py", line
> 12, in 
> import StringIO
> builtins.ModuleNotFoundError: No module named 'StringIO'
>
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Building Python3 wheels for Win32 and releasing to Pypi

[Craig Rodrigues]

On Sun, Jan 7, 2018 at 10:14 PM, Adi Roiban  wrote:

>
> I no longer have time to work on it, but I think that is possible to build
> wheels for py2.7 and py3 on appveyor
>


If during the release process, appveyor could build the Windows wheels on
py2.7 and py3, and then upload
them to pypi, that would be ideal.

Didn't you implement something for one of the Twisted subprojects where if
a git tag was created and pushed to github, then it would build and upload
to pypi?
That would be the ideal thing to implement with appveyor for the main
Twisted project.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Building Python3 wheels for Win32 and releasing to Pypi

[Craig Rodrigues]

At https://pypi.python.org/pypi/Twisted , there is only a Python 2.7 wheel
for Win32.

Since we don't push Python3 wheels to Pypi, people need to pick them up
from: https://www.lfd.uci.edu/~gohlke/pythonlibs/#twisted
which is not ideal.

Since I ported the IOCP reactor to Win32 in 2016, it would be good
to update the Twisted release scripts to push Python3 wheels to Pypi.

Where are these scripts located?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] buildbot.twistedmatrix.com is down?

[Craig Rodrigues]

On Fri, Jan 5, 2018 at 11:35 PM, Glyph  wrote:

>
>
> Thanks for the report; rebooted and security updates applied; it appears
> to be processing the backlog just fine now.
>
>
 Is http://buildbot.twistedmatrix.com/ down again?  I can't seem to access
it.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] buildbot.twistedmatrix.com is down?

[Craig Rodrigues]

Thanks for rebooting it.

The egh-osx-1 node seems to be down though:

https://buildbot.twistedmatrix.com/builders/osx10.10-py2.7

and this node is a blocking requirement for merges to take place.

--
Craig


On Thu, Jan 4, 2018 at 2:58 AM, Glyph <gl...@twistedmatrix.com> wrote:

>
>
> On Jan 3, 2018, at 6:12 PM, Craig Rodrigues <rodr...@crodrigues.org>
> wrote:
>
> Hi,
>
> It looks like buildbot.twistedmatrix.com is down.
> Does anyone know how to bring it back?
>
>
> I've rebooted it, applied security updates, rebooted, purged old kernels,
> rebooted again.  Should be running smoothly now, no idea what the issue was.
>
> Anyone else with access to do this sort of thing should feel free, by the
> way, it was a bit of a fluke that I had a moment of free time to do so
> tonight :-).
>
> -g
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] buildbot.twistedmatrix.com is down?

[Craig Rodrigues]

Hi,

It looks like buildbot.twistedmatrix.com is down.
Does anyone know how to bring it back?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Drop support for Python 3.3

[Craig Rodrigues]

On Wed, Dec 27, 2017 at 1:02 PM, Adi Roiban <a...@roiban.ro> wrote:
>
> On 18 December 2017 at 01:18, Craig Rodrigues <rodr...@crodrigues.org>
wrote:
> > I submitted this patch to drop support for Python 3.3:
> >
> > https://github.com/twisted/twisted/pull/943
> >
> >
> > 1.  Python 3.3 was declared EOL on Sep. 29, 2017
> > 2.  In terms of major Linux distributions, Python 3.4 came with Python
3.4
> > is in Debian 8, Ubuntu 14.04, Fedora 21
> >
> > So after this patch, Twisted would run on:
> >
> > Python 2.7 and Python 3.4+
>
> +1  for removing python 3.3
>
> But as commented in the PR, I would like to see this removed after the
> next release, so that we don't have to change the release notes for
> 17.9.0
> That is 18.X.X should be the last release to support 3.4



When Python 2.6 support was dropped, the NEWS.rst was modified after the
fact in this:

http://twistedmatrix.com/trac/ticket/8651

That's why I modified NEWS.rst in this commit as well.

Since dropping a Python version happens so infrequently, I thought this was
OK to modify NEWS.rst here, since it has been done before.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] failUnlessFailure vs assertFailure

[Craig Rodrigues]

Probably failUnlessFailure as an alias to assertFailure() was done to mimic
some of the deprecations that occurred
in the Python unittest module in Python 2.7:
https://docs.python.org/2/library/unittest.html#deprecated-aliases

It would probably be a good idea to change the usage of failUnlessFailure
in twisted to assertFailure,
and then deprecate failUnlessFailure.

--
Craig

On Wed, Jan 3, 2018 at 6:29 AM, Adi Roiban  wrote:

> Hi,
>
> Do you know why we still have failUnlessFailure is an alias to
> assertFailure? [1]
>
> It looks like pydoctor does not include aliases as I don't see
> failUnlessFailure in the HTML rendering
> http://twistedmatrix.com/documents/current/api/twisted.
> trial.unittest.TestCase.html
>
> Looking at the current code, I see that it is used only in a single
> place in Twisted
> https://github.com/twisted/twisted/search?utf8=%E2%9C%93;
> q=failUnlessFailure=
>
> I see that in the past assertFailure was an alias for failUnlessFailure [2]
>
> Is the plan to continue to have the alias? Maybe we can have a comment
> before the alias.
>
> Can we deprecate it?
>
> Should pydoctor be updated to also show aliases of public methods?
>
> Regards,
>
> [1] https://github.com/twisted/twisted/blob/e38cc25a67747899c6984d6ebaa8d3
> d134799415/src/twisted/trial/_asynctest.py#L77
>
> [2] https://github.com/twisted/twisted/commit/
> ce0b00de026a896b731d8794de2fd61b54a78a98
> --
> Adi Roiban
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Drop support for Python 3.3

[Craig Rodrigues]

I submitted this patch to drop support for Python 3.3:

https://github.com/twisted/twisted/pull/943


1.  Python 3.3 was declared EOL on Sep. 29, 2017
2.  In terms of major Linux distributions, Python 3.4 came with Python 3.4
is in Debian 8, Ubuntu 14.04, Fedora 21

So after this patch, Twisted would run on:

Python 2.7 and Python 3.4+

Thoughts?
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] PyPy 5.9.0 on buildbots

[Craig Rodrigues]

On Wed, Nov 29, 2017 at 3:29 PM, Mark Williams  wrote:

> I just replaced the system PyPy from the PPA with Squeaky's portable
> PyPy 5.9.0:
>
>
Thanks for installing this.

These are the test results before and after your change.

Before your change running PyPy 5.8.0:

FAILED (skips=2200, failures=5, errors=12, successes=9947)


After your change, running PyPy 5.9.0:

https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy5/builds/172/steps/select/logs/stdio

FAILED (skips=2200, failures=1, errors=12, successes=9951)


So with the PyPy upgrade, there is a small improvement in the number of
Twisted tests which now pass with PyPy.

Did you install PyPy3 5.9.0 anywhere on the buildbots?
It would be good to have that running as well.

Thanks.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Need help fixing txkube unit test with latest Twisted

[Craig Rodrigues]

Hi,

I have been submitting patches to txkube (Python-based Kubernetes client)
to work with the latest API changes for the reactor and TLS endpoints.

I am down to only 1 test failing.  I submitted this patch:

https://github.com/LeastAuthority/txkube/pull/152/files

based on changes that I saw in

https://github.com/twisted/twisted/commit/cd75dd82f41b834ec8d53827932cf566116e3c0d

but haven't gotten it to work.

What I am trying to do is to get txkube to the point where I can install it
with Python 2.7, and
then type:

trial txkube.test.test_authentication.AuthenticateWithServiceAccountTests.t
est_https_bearer_token_authorization

and get it to work.


test_https_bearer_token_authorization is pretty much the same as
test_http_bearer_token_authorization, just going over https.

When running the test_https_bearer_token_authorization test, I traced
things down into the ConnectionCompleter class:
https://github.com/twisted/twisted/blob/trunk/src/twisted/test/iosim.py#L515

It looks like the serverFactory is not properly creating a serverProtocol,
so no data is going through.

Can someone familiar with the TLS endpoint changes in Twisted 17.1.0 point
me in the right direction for this?


--

Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] PyPy 5.9.0 on buildbots

[Craig Rodrigues]

Hi,

Can someone update PyPy on the buildbots from PyPy 5.8.0 to PyPy 5.9.0?

This will fix more of the PyPy tests:
https://twistedmatrix.com/trac/ticket/9226

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python