Re: [U-Boot] [PATCH 06/10] AVR32: macb - Search for PHY id
Olav Morken wrote: > This patch adds support for searching through available PHY-addresses in > the macb-driver. This is needed for the ATEVK1100 evaluation board, > where the PHY-address will be initialized to either 1 or 7. > > Signed-off-by: Gunnar Rangoy <[EMAIL PROTECTED]> > Signed-off-by: Paul Driveklepp <[EMAIL PROTECTED]> > Signed-off-by: Olav Morken <[EMAIL PROTECTED]> > --- > drivers/net/macb.c | 28 > 1 files changed, 28 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 4fef374..561669b 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -338,6 +338,27 @@ static void macb_phy_reset(struct macb_device *macb) > netdev->name, status); > } > > +static int macb_phy_find(struct macb_device *macb) > +{ > + int i; > + u16 phy_id; > + > + /* Search for PHY... */ > + for (i = 0; i < 32; i++) { > + macb->phy_addr=i; > + phy_id = macb_mdio_read(macb, MII_PHYSID1); > + if (phy_id != 0x) { > + printf("%s: PHY present at %d\n", macb->netdev.name, i); > + return 1; > + } > + } > + > + /* PHY isn't up to snuff */ > + printf("%s: PHY not found", macb->netdev.name); > + > + return 0; > +} > + > static int macb_phy_init(struct macb_device *macb) > { > struct eth_device *netdev = &macb->netdev; > @@ -346,6 +367,13 @@ static int macb_phy_init(struct macb_device *macb) > int media, speed, duplex; > int i; > > + if (macb->phy_addr == 0xff) { > + /* Auto-detect phy_addr */ > + if (!macb_phy_find(macb)) { > + return 0; > + } > + } > + > /* Check if the PHY is up to snuff... */ > phy_id = macb_mdio_read(macb, MII_PHYSID1); > if (phy_id == 0x) { > Applied to net/testing. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/10] AVR32: macb - Disable 100mbps if clock is slow
Olav Morken wrote: > For 100mbps operation, the ethernet controller requires a 25 MHz clock > in MII mode, and a 50 MHz clock in RMII mode. If the clock is slower, > disable 100mbps mode. > > Signed-off-by: Gunnar Rangoy <[EMAIL PROTECTED]> > Signed-off-by: Paul Driveklepp <[EMAIL PROTECTED]> > Signed-off-by: Olav Morken <[EMAIL PROTECTED]> > --- > drivers/net/macb.c | 23 ++- > 1 files changed, 22 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 08bebf7..4fef374 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -296,8 +296,29 @@ static void macb_phy_reset(struct macb_device *macb) > struct eth_device *netdev = &macb->netdev; > int i; > u16 status, adv; > + int rmii_mode; > + unsigned min_hz; > + > +#ifdef CONFIG_RMII > + rmii_mode = 1; > + min_hz = 5000; > +#else > + rmii_mode = 0; > + min_hz = 2500; > +#endif > + > + adv = ADVERTISE_CSMA | ADVERTISE_ALL ; > + > + if (get_hsb_clk_rate() < min_hz) { > + printf("%s: HSB clock < %u MHz in %s mode - " > +"disabling 100mbit.\n", netdev->name, min_hz / 100, > +(rmii_mode ? "RMII" : "MII")); > + > + adv &= ~ADVERTISE_100FULL; > + adv &= ~ADVERTISE_100HALF; > + adv &= ~ADVERTISE_100BASE4; > + } > > - adv = ADVERTISE_CSMA | ADVERTISE_ALL; > macb_mdio_write(macb, MII_ADVERTISE, adv); > printf("%s: Starting autonegotiation...\n", netdev->name); > macb_mdio_write(macb, MII_BMCR, (BMCR_ANENABLE > Applied to net/testing. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/10] Fix IP alignement problem
Olav Morken wrote: > This patch removes volatile from: > volatile IP_t *ip = (IP_t *)xip; > > Due to a bug, avr32-gcc will assume that ip is aligned on a word boundary when > using volatile, which causes an exception since xip isn't aligned on a word > boundary. > Applied to net/testing. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add simple IP/UDP fragmentation support
Hi Josh, Josh Boyer wrote: > From: Frank Haverkamp <[EMAIL PROTECTED]> > > http://tools.ietf.org/html/rfc2348 describes the TFTP block size option > which allows larger packtes than the 512 byte default. This reduces the > number of TFTP ACKs significantly and improves performance. > > To get the most benefit out of the tftp block size option the support > of defragementation of IP/UDP packet is helpful. The current implemenation > should work even with packets received out of order. To enable the large > packet size the user should set "tftp_block_size" so a value like 16352. > > We experimented with different packet sizes and found that more than those > 16KiB do not contribute much to the performance anymore. Therefor I limited > the defragmentation buffer to 16KiB no too waste memory. > > Signed-off-by: Frank Haverkamp <[EMAIL PROTECTED]> > Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> > I know you guys posted this one a couple of months ago and I apologize for not being more active. I've put this in the net/testing repo with the hope that people will smack it around a bit. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/4] Improve mpc85xx link script rodata section
On Tue, 14 Oct 2008, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: >> >>> This affects *all* boards and should therefore be implemented for >>> *all* boards, not only for 85xx. >> >> The other board's linker scripts are somewhat different. Maybe someone who >> maintains them and knows them better should do it to make sure it's correct. > > I would like to see this in one commit, though, or a small series of > connectred commits. > >> In fact, there's already patches that do this for other boards out there. > > Are there? I'm not aware of this. Do you have a link for me? I've seen them posted internally at Freescale for a couple months now. Some BSPs are using them. I don't think anyone, besides me, has tried to get any rodata fixes committed upstream. Maybe the thought of fixing 500 other boards they know nothing about is scaring them away? Some links: http://www.bitshrine.org/gpp/u-boot-1.1.3-mpc832x-rodata-str-1.patch http://www.bitshrine.org/gpp/u-boot-1.1.3-mpc8349itx-rodata-str-1.patch http://www.bitshrine.org/gpp/u-boot-1.3.2-mpc8272ads-rodata-str-1.patch IMHO, the way I've done it is better. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544
The MPC8544 RM incorrect shows the SEC_CFG bit in PORDEVSR2 as being bit 26, instead it should be bit 28. This caused in incorrect interpretation of the i2c_clk which is the same as the SEC clk on MPC8544. The SEC clk is controlled by cfg_sec_freq that is reported in PORDEVSR2. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- include/asm-ppc/immap_85xx.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/asm-ppc/immap_85xx.h b/include/asm-ppc/immap_85xx.h index 50c9dde..6c81c39 100644 --- a/include/asm-ppc/immap_85xx.h +++ b/include/asm-ppc/immap_85xx.h @@ -1579,7 +1579,7 @@ typedef struct ccsr_gur { #define MPC85xx_PORDEVSR_RIO_DEV_ID0x0007 uintpordbgmsr; /* 0xe0010 - POR debug mode status register */ uintpordevsr2; /* 0xe0014 - POR I/O device status regsiter 2 */ -#define MPC85xx_PORDEVSR2_SEC_CFG 0x0020 +#define MPC85xx_PORDEVSR2_SEC_CFG 0x0080 charres1[8]; uintgpporcr;/* 0xe0020 - General-purpose POR configuration register */ charres2[12]; -- 1.5.5.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2][for v2008.10] Revert "85xx: Using proper I2C source clock divider for MPC8544"
This reverts commit dffd2446fb041f38ef034b0fcf41e51e5e489159. The fix introduced by this patch is not correct. The problem is that the documentation is not correct for the MPC8544 with regards to which bit in PORDEVSR2 is for the SEC_CFG. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- cpu/mpc85xx/speed.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpu/mpc85xx/speed.c b/cpu/mpc85xx/speed.c index 70dfad0..485ba20 100644 --- a/cpu/mpc85xx/speed.c +++ b/cpu/mpc85xx/speed.c @@ -102,9 +102,9 @@ int get_clocks (void) * PORDEVSR2_SEC_CFG bit is 0 on all 85xx boards that are not an 8544. */ if (gur->pordevsr2 & MPC85xx_PORDEVSR2_SEC_CFG) - gd->i2c1_clk = sys_info.freqSystemBus / 2; - else gd->i2c1_clk = sys_info.freqSystemBus / 3; + else + gd->i2c1_clk = sys_info.freqSystemBus / 2; #else /* Most 85xx SOCs use CCB/2, so this is the default behavior. */ gd->i2c1_clk = sys_info.freqSystemBus / 2; -- 1.5.5.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] Added arch_lmb_reserve to allow arch specific memory regions protection
Each architecture has different ways of determine what regions of memory might not be valid to get overwritten when we boot. This provides a hook to allow them to reserve any regions they care about. Currently only ppc, m68k and sparc need/use this. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Updated against latest next tree. - k common/cmd_bootm.c |7 +++ lib_m68k/bootm.c | 29 - lib_ppc/bootm.c| 50 -- lib_sparc/bootm.c | 16 +--- 4 files changed, 60 insertions(+), 42 deletions(-) diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c index 2a9c59f..b02da3e 100644 --- a/common/cmd_bootm.c +++ b/common/cmd_bootm.c @@ -128,6 +128,12 @@ void __board_lmb_reserve(struct lmb *lmb) } void board_lmb_reserve(struct lmb *lmb) __attribute__((weak, alias("__board_lmb_reserve"))); +void __arch_lmb_reserve(struct lmb *lmb) +{ + /* please define platform specific arch_lmb_reserve() */ +} +void arch_lmb_reserve(struct lmb *lmb) __attribute__((weak, alias("__arch_lmb_reserve"))); + #if defined(__ARM__) #define IH_INITRD_ARCH IH_ARCH_ARM #elif defined(__avr32__) @@ -173,6 +179,7 @@ static int bootm_start(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) lmb_add(&images.lmb, (phys_addr_t)mem_start, mem_size); + arch_lmb_reserve(&images.lmb); board_lmb_reserve(&images.lmb); /* get kernel image header, start address and length */ diff --git a/lib_m68k/bootm.c b/lib_m68k/bootm.c index a73f6eb..c52dd2f 100644 --- a/lib_m68k/bootm.c +++ b/lib_m68k/bootm.c @@ -43,22 +43,10 @@ DECLARE_GLOBAL_DATA_PTR; static ulong get_sp (void); static void set_clocks_in_mhz (bd_t *kbd); -int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) +void arch_lmb_reserve(struct lmb *lmb) { ulong sp; - ulong rd_len; - ulong initrd_start, initrd_end; - int ret; - - ulong cmd_start, cmd_end; - ulong bootmap_base; - bd_t *kbd; - void (*kernel) (bd_t *, ulong, ulong, ulong, ulong); - struct lmb *lmb = &images->lmb; - - bootmap_base = getenv_bootm_low(); - /* * Booting a (Linux) kernel image * @@ -74,6 +62,21 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) /* adjust sp by 1K to be safe */ sp -= 1024; lmb_reserve(lmb, sp, (CONFIG_SYS_SDRAM_BASE + gd->ram_size - sp)); +} + +int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) +{ + ulong rd_len; + ulong initrd_start, initrd_end; + int ret; + + ulong cmd_start, cmd_end; + ulong bootmap_base; + bd_t *kbd; + void (*kernel) (bd_t *, ulong, ulong, ulong, ulong); + struct lmb *lmb = &images->lmb; + + bootmap_base = getenv_bootm_low(); /* allocate space and init command line */ ret = boot_get_cmdline (lmb, &cmd_start, &cmd_end, bootmap_base); diff --git a/lib_ppc/bootm.c b/lib_ppc/bootm.c index d498818..1f3501a 100644 --- a/lib_ppc/bootm.c +++ b/lib_ppc/bootm.c @@ -55,30 +55,10 @@ static void set_clocks_in_mhz (bd_t *kbd); #define CONFIG_SYS_LINUX_LOWMEM_MAX_SIZE (768*1024*1024) #endif -__attribute__((noinline)) -int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) +void arch_lmb_reserve(struct lmb *lmb) { - ulong sp; - - ulong initrd_start, initrd_end; - ulong rd_len; - ulong size; phys_size_t bootm_size; - - ulong cmd_start, cmd_end, bootmap_base; - bd_t*kbd; - void(*kernel)(bd_t *, ulong r4, ulong r5, ulong r6, - ulong r7, ulong r8, ulong r9); - int ret; - ulong of_size = images->ft_len; - struct lmb *lmb = &images->lmb; - -#if defined(CONFIG_OF_LIBFDT) - char*of_flat_tree = images->ft_addr; -#endif - - kernel = (void (*)(bd_t *, ulong, ulong, ulong, - ulong, ulong, ulong))images->ep; + ulong size, sp, bootmap_base; bootmap_base = getenv_bootm_low(); bootm_size = getenv_bootm_size(); @@ -116,6 +96,32 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) sp -= 1024; lmb_reserve(lmb, sp, (CONFIG_SYS_SDRAM_BASE + get_effective_memsize() - sp)); + return ; +} + +__attribute__((noinline)) +int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) +{ + ulong initrd_start, initrd_end; + ulong rd_len; + + ulong cmd_start, cmd_end, bootmap_base; + bd_t*kbd; + void(*kernel)(bd_t *, ulong r4, ulong r5, ulong r6, + ulong r7, ulong r8, ulong r9); + int ret; + ulong of_size = images->ft_len; + struct lmb *lmb = &images->lmb; + +#if defined(CONFIG_OF_LIBFDT) + char*of_flat_tree = images->ft_addr; +#en
Re: [U-Boot] [POWERPC] mgcoge: Second Flash on CS5 not on CS1
Dear Heiko, In message <[EMAIL PROTECTED]> you wrote: > > Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> > --- > board/keymile/mgcoge/mgcoge.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Sorry, this patch does not apply: Applying mgcoge: Second Flash on CS5 not on CS1 error: patch failed: board/keymile/mgcoge/mgcoge.c:334 error: board/keymile/mgcoge/mgcoge.c: patch does not apply fatal: sha1 information is lacking or useless (board/keymile/mgcoge/mgcoge.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001. Please fix and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] "Out of register space (ugh)" - vi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [POWERPC] mgcoge: correct init of the UPIOx
Dear Heiko Schocher, In message <[EMAIL PROTECTED]> you wrote: > Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> > --- > board/keymile/mgcoge/mgcoge.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/board/keymile/mgcoge/mgcoge.c b/board/keymile/mgcoge/mgcoge.c > index 31703ab..099e77b 100644 > --- a/board/keymile/mgcoge/mgcoge.c > +++ b/board/keymile/mgcoge/mgcoge.c > @@ -296,7 +296,7 @@ int board_early_init_r (void) > { > /* setup the UPIOx */ > *(char *)(CFG_PIGGY_BASE + 0x02) = 0xc0; > - *(char *)(CFG_PIGGY_BASE + 0x03) = 0x15; > + *(char *)(CFG_PIGGY_BASE + 0x03) = 0x35; > return 0; > } Umm... no. Please change all this code to use the appropriate accesor functions instead (these pointers are not even volatile - shudder...). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] The more we disagree, the more chance there is that at least one of us is right. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [POWERPC] mgcoge: added CONFIG_FIT to support the new u-boot image format
Dear Heiko Schocher, In message <[EMAIL PROTECTED]> you wrote: > > Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> > --- > include/configs/mgcoge.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] I am not now, nor have I ever been, a member of the demigodic party. -- Dennis Ritchie ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][for v2008.10] 85xx: Fix compile warning
Dear Kumar Gala, In message <[EMAIL PROTECTED]> you wrote: > mpc8536ds.c: In function 'is_sata_supported': > mpc8536ds.c:614: warning: unused variable 'devdisr' > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > board/freescale/mpc8536ds/mpc8536ds.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Neckties strangle clear thinking. -- Lin Yutang ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Added arch_lmb_reserve to allow arch specific memory regions protection
Dear Kumar Gala, In message <[EMAIL PROTECTED]> you wrote: > Each architecture has different ways of determine what regions of memory > might not be valid to get overwritten when we boot. This provides a > hook to allow them to reserve any regions they care about. Currently > only ppc, m68k and sparc need/use this. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > > For some reason I had two commits in my tree and the cmd_bootm.c changes > didn't > make it out. > > - k > > common/cmd_bootm.c |7 +++ > lib_m68k/bootm.c | 29 - > lib_ppc/bootm.c| 50 -- > lib_sparc/bootm.c | 16 +--- > 4 files changed, 60 insertions(+), 42 deletions(-) Tried to apply to "next" branch as requested, but this fails with non-trivial merge conflicts: Applying Added arch_lmb_reserve to allow arch specific memory regions protection error: patch failed: lib_m68k/bootm.c:74 error: lib_m68k/bootm.c: patch does not apply error: patch failed: lib_ppc/bootm.c:55 error: lib_ppc/bootm.c: patch does not apply error: patch failed: lib_sparc/bootm.c:124 error: lib_sparc/bootm.c: patch does not apply Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merged common/cmd_bootm.c Auto-merged lib_m68k/bootm.c CONFLICT (content): Merge conflict in lib_m68k/bootm.c Auto-merged lib_ppc/bootm.c Auto-merged lib_sparc/bootm.c CONFLICT (content): Merge conflict in lib_sparc/bootm.c Failed to merge in the changes. Patch failed at 0001. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Program maintenance is an entropy-increasing process, and even its most skilfull execution only delays the subsidence of the system into unfixable obsolescence. - Fred Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix the function conflict in x86emu when DEBUG is on
Dear Jason Jin, In message <[EMAIL PROTECTED]> you wrote: > The function parse_line() in common/main.c was exposed globally by commit > 6636b62a6efc7f14e6e788788631ae7a7fca4537, Result in conflict with the same > name funciton in drivers/bios_emulator/x86emu/debug.c when define the DEBUG. > This patch fix this by renaming the function in the debug.c file. > > Signed-off-by: Jason Jin <[EMAIL PROTECTED]> > --- > drivers/bios_emulator/x86emu/debug.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] [Braddock:] Mr. Churchill, you are drunk. [Churchill:] And you madam, are ugly. But I shall be sober tomorrow. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] 440spe MQ initialization
Dear Stefan, In message <[EMAIL PROTECTED]> Yuri Tikhonov wrote: > > Set the MQ Read Passing & MCIF Cycle limits to the recommended by AMCC > values. This fixes the occasional 440SPe hard locking issues when the 440SPe's > dedicated DMA engines are used (e.g. by the h/w accelerated RAID driver). > > Previously the appropriate initialization had been made in Linux, by the > ppc440spe ADMA driver, which is wrong because modifying the MQ configuration > registers after normal operation has begun is not supported and could > have unpredictable results. > > Signed-off-by: Yuri Tikhonov <[EMAIL PROTECTED]> > --- > cpu/ppc4xx/44x_spd_ddr2.c | 10 ++ > include/asm-ppc/ppc4xx-sdram.h |5 + > 2 files changed, 11 insertions(+), 4 deletions(-) I must admit that I lost track in the discussion following this posting what the real state of affairs is now. Do we need to change anything in U-Boot, or not, and why not? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] The ideal situation is to have massive computing power right at home. Something that dims the streetlights and shrinks the picture on the neighbours' TVs when you boot it up. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
Dear Ron Madrid, In message <[EMAIL PROTECTED]> you wrote: > > BTW, can you get your e-mail client to wrap long lines? > > I've tried. I think there's a problem with yahoo's web mail. So how about hitting "ENTER" every now and than? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] We have found all life forms in the galaxy are capable of superior development. -- Kirk, "The Gamesters of Triskelion", stardate 3211.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [POWERPC] mgcoge, mgsuvd: fix out-of-tree build error.
Dear Heiko Schocher, In message <[EMAIL PROTECTED]> you wrote: > > Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> > --- > board/keymile/mgcoge/Makefile |3 +++ > board/keymile/mgsuvd/Makefile |3 +++ > 2 files changed, 6 insertions(+), 0 deletions(-) Thanks, appied to "next" branch. [Note: I merged this into the "mgsuvd, mgcoge: move this 2 boards in one dir." commit wher eit was actually missing.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Often it is fatal to live too long. - Racine ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
> BTW, can you get your e-mail client to wrap long lines? I've tried. I think there's a problem with yahoo's web mail. Ron ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] add tool to check patch and file for CFG_ presence
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <[EMAIL PROTECTED]> you wrote: > > > I think we should change this into: > > > > grep -l -r * | xargs tools/find_config_errors -f > It will not work with symlinks You don't want to run this in a dirty tree, do you? > when you do not have a git repository you will check compile code, non > use file patch maybe etc... and not ignoring files specified in the > differents gitignore. Hm... why should I run this in a drity tree? > I'll prefer to only activate it when we have a git reprository I don't. There are quite a lot of people out there not using git for their work. Unless really necessary we should not cut them off. And here it seems not really necessary. > otherwise the user will use find_config_errors to check it's patch > before send it as done with checkpatch.pl. > > so I'll propose instead > find_config_errors: > @echo "Search for config errors" > @# Check for git and a git repo. > @if head=`git rev-parse --verify HEAD 2>/dev/null`; then \ > git grep -l CFG_ | sort -u | xargs -I {} > tools/find_config_errors -f {} ;\ > fi Comments - if we do this only when git is available, then: - we must issue an error message and set an error return code if git is missing - I don't see much use for the "| sort -u" part of the pipe ? - I don't see much sense for the "-I {}" and "{}" parts in the xargs command ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] 8 Catfish = 1 Octo-puss ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [POWERPC] mgsuvd: fix compiler warning when using soft_i2c driver
Dear Heiko Schocher, In message <[EMAIL PROTECTED]> you wrote: > following patch solves the compiler warning for the > mgsuvd board, using the soft_i2c driver: > > [EMAIL PROTECTED] u-boot]$ ./MAKEALL mgsuvd > Configuring for mgsuvd board... > soft_i2c.c: In function 'write_byte': > soft_i2c.c:209: warning: implicit declaration of function 'i2c_soft_read_pin' >textdata bss dec hex filename > 1746089712 28436 212756 33f14 ./u-boot > [EMAIL PROTECTED] u-boot]$ > > Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> > --- > drivers/i2c/soft_i2c.c |2 ++ > include/configs/mgsuvd.h |1 + > include/i2c.h|4 > 3 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/soft_i2c.c b/drivers/i2c/soft_i2c.c > index 0a9feb6..346125e 100644 > --- a/drivers/i2c/soft_i2c.c > +++ b/drivers/i2c/soft_i2c.c > @@ -41,6 +41,8 @@ > #endif > #include > > +CONFIG_I2C_SOFT_EXTERN > + > /* #define DEBUG_I2C */ > > #ifdef DEBUG_I2C > diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h > index 4ecaeac..2171115 100644 > --- a/include/configs/mgsuvd.h > +++ b/include/configs/mgsuvd.h > @@ -356,6 +356,7 @@ > > #define I2C_ACTIVE do {} while (0) > #define I2C_TRISTATE do {} while (0) > +#define CONFIG_I2C_SOFT_EXTERN extern int i2c_soft_read_pin (void); > #define I2C_READ i2c_soft_read_pin () > #define I2C_SDA(bit) if(bit) { \ > *(unsigned short *)(I2C_BASE_DIR) &= > ~SDA_CONF; \ > diff --git a/include/i2c.h b/include/i2c.h > index 9f771dd..24d535f 100644 > --- a/include/i2c.h > +++ b/include/i2c.h > @@ -76,6 +76,10 @@ > # define I2C_SOFT_DECLARATIONS > # endif > #endif > + > +#ifndef CONFIG_I2C_SOFT_EXTERN > +#define CONFIG_I2C_SOFT_EXTERN > +#endif > /* > * Initialization, must be called once on start up, may be called > * repeatedly to change the speed and slave addresses. NAK. This is really ugly. Please make i2c_soft_read_pin () an inline function so it's sufficient to change the I2C_READ definition in include/configs/mgsuvd.h Umm... while we are at it - there is a lot of code in "board/keymile/mgsuvd/mgsuvd.c" that needs to be cleaned up: 24 #if 0 25 #define DEBUG 26 #endif Please remove. 167 memory_data[0] = cpu_to_be32(bd->bi_memstart); 168 memory_data[1] = cpu_to_be32(bd->bi_memsize); 169 170 nodeoffset = fdt_path_offset (blob, "/memory"); 171 if (nodeoffset >= 0) { 172 ret = fdt_setprop(blob, nodeoffset, "reg", memory_data, 173 sizeof(memory_data)); Indentation is wrong here. 177 } 178 else { make this "} else {" 180 printf("ft_blob_update(): cannot find /memory node " 181 "err:%s\n", fdt_strerror(nodeoffset)); Indentation. 187 if (nodeoffset >= 0) { 188 ret = fdt_setprop(blob, nodeoffset, "ranges", flash_data, 189 sizeof(flash_data)); 190 if (ret < 0) 191 printf("ft_blob_update(): cannot set /localbus/ranges " 192 "property err:%s\n", fdt_strerror(ret)); 193 } 194 else { Bad indentation and "} else {" again. 202 if (nodeoffset >= 0) { 203 ret = fdt_setprop(blob, nodeoffset, "brg-frequency", brg_data, 204 sizeof(brg_data)); 205 if (ret < 0) 206 printf("ft_blob_update(): cannot set /soc/cpm/brg-frequency " 207 "property err:%s\n", fdt_strerror(ret)); 208 } 209 else { Bad indentation and "} else {" again. Oops. This is the third time you repeat the same code? And yet another time follows below? Please turn this into a function. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] I often quote myself; it adds spice to my conversation. - G. B. Shaw ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [83xx] Removed #ifdef CONFIG_MPC834X dependency on upmconfig function
On Thu, 16 Oct 2008 13:49:42 -0400 richardretanubun <[EMAIL PROTECTED]> wrote: Hi Richard, > Removed #ifdef CONFIG_MPC834X dependency on upmconfig function. please elaborate your commit messages to include /why/ this change is needed, not only what it does (in this particular case we can easily see what it does). Adding material from your prior mail will achieve most of this. > Signed-off-by: Richard Retanubun <[EMAIL PROTECTED]> I'm guessing s/ggg/gg/? I've seen this before; please edit your git configuration/environment to fix this once and for all (it conflicts with the commit's author (From:) and comes into play whenever commit statistics are generated). > /* Set the OP field in the MxMR to "normal" and the MAD field to > 00 */ biggest problem is it looks like this is line wrapped anyway: Applying: Removed #ifdef CONFIG_MPC834X dependency on upmconfig function fatal: corrupt patch at line 20 other than that, looks good ;) Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] add tool to check patch and file for CFG_ presence
On 22:18 Thu 16 Oct , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <[EMAIL PROTECTED]> you wrote: > > > > +find_config_errors: > > + @echo "Search for config errors" > > + @git-grep CFG_ | cut -d: -f1 | sort -u | xargs -I {} > > tools/find_config_errors -f {} > > + > > Hm... should we not just use "grep -r *" so this will also work when > we don't have a full git repository? > > And instead of running another process with "cut", a "-l" argument to > grep (or even git-grep) would do the same? [Also note that "git-grep" > is deprecated, "git grep" should be used instead.] > > I think we should change this into: > > grep -l -r * | xargs tools/find_config_errors -f It will not work with symlinks when you do not have a git repository you will check compile code, non use file patch maybe etc... and not ignoring files specified in the differents gitignore. I'll prefer to only activate it when we have a git reprository otherwise the user will use find_config_errors to check it's patch before send it as done with checkpatch.pl. so I'll propose instead find_config_errors: @echo "Search for config errors" @# Check for git and a git repo. @if head=`git rev-parse --verify HEAD 2>/dev/null`; then \ git grep -l CFG_ | sort -u | xargs -I {} tools/find_config_errors -f {} ;\ fi Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
Ron Madrid wrote: > So is there a particular convention for which bytes should be used > within the OOB area for an ECC? I've looked for information on this > but haven't been able to come up with anything. The 8313 manual says that when booting from NAND, it expects ECCM 0 on small page and ECCM 1 on large page. BTW, can you get your e-mail client to wrap long lines? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
So is there a particular convention for which bytes should be used within the OOB area for an ECC? I've looked for information on this but haven't been able to come up with anything. --- On Thu, 10/16/08, Scott Wood <[EMAIL PROTECTED]> wrote: > From: Scott Wood <[EMAIL PROTECTED]> > Subject: Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page > devices > To: "Ron Madrid" <[EMAIL PROTECTED]> > Cc: u-boot@lists.denx.de > Date: Thursday, October 16, 2008, 12:17 PM > On Tue, Oct 14, 2008 at 01:24:09PM -0700, Ron Madrid wrote: > > 1. I don't see anywhere that the AL (address > length, or number of > > address cycles) can be set to anything other than 2. > It appears to be > > hard coded in both files. > > Correct. AFAICT, setting AL to anything less than 2 is > just an > optimization for small flashes. Linux will make that > optimization, but > the way NAND devices are currently probed in u-boot makes > that awkward > (no opportunity to run code after size is known, but before > nand_scan_tail). > > > 2. nand_boot_fsl_elbc.c uses ECCM = 1 for large page > devices, but I > > don't see a place where fsl_elbc_nand.c sets ECCM > to 1 for similar > > devices. > > That looks like a bug. > > -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] add tool to check patch and file for CFG_ presence
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <[EMAIL PROTECTED]> you wrote: > > +find_config_errors: > + @echo "Search for config errors" > + @git-grep CFG_ | cut -d: -f1 | sort -u | xargs -I {} > tools/find_config_errors -f {} > + Hm... should we not just use "grep -r *" so this will also work when we don't have a full git repository? And instead of running another process with "cut", a "-l" argument to grep (or even git-grep) would do the same? [Also note that "git-grep" is deprecated, "git grep" should be used instead.] I think we should change this into: grep -l -r * | xargs tools/find_config_errors -f What do you think? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] There are three ways to get something done: do it yourself, hire someone, or forbid your kids to do it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/1] add tool to check patch and file for CFG_ presence
run make find_config_errors to performed it. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> --- Makefile |4 ++ tools/find_config_errors | 87 ++ 2 files changed, 91 insertions(+), 0 deletions(-) create mode 100755 tools/find_config_errors diff --git a/Makefile b/Makefile index c711df6..e91cb18 100644 --- a/Makefile +++ b/Makefile @@ -3236,4 +3236,8 @@ backup: F=`basename $(TOPDIR)` ; cd .. ; \ gtar --force-local -zcvf `date "+$$F-%Y-%m-%d-%T.tar.gz"` $$F +find_config_errors: + @echo "Search for config errors" + @git-grep CFG_ | cut -d: -f1 | sort -u | xargs -I {} tools/find_config_errors -f {} + # diff --git a/tools/find_config_errors b/tools/find_config_errors new file mode 100755 index 000..168e7e1 --- /dev/null +++ b/tools/find_config_errors @@ -0,0 +1,87 @@ +#!/usr/bin/perl +# +# (C) Copyright 2008 +# Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# +use Getopt::Std; +my $num = 1; +my $mode_patch = 0; +my $opt_string = 'hpf:'; + +getopts( "$opt_string", \%opt ) or usage(); +usage() if $opt{h}; + +if ($opt{p}) { + $mode_patch = 1; +} + +sub usage() +{ + print STDERR << "EOF"; +This program does... +usage: $0 [-hp] [-f file] + -h: this (help) message + -p: mode patch + -f file : file to work on +EOF +exit; +} + +my $file = $opt{f}; + +if ($file =~ m/\.patch$/) { + $mode_patch = 1; +} + +if ($file =~ m/(config_deprecated\.h$|^CHANGELOG)/) { + exit 0 +} + +if ($file) { + open FILE, $file or die $!; +} else { + open FILE, "<&STDIN" or die $!; +} + +while (chomp($line = )) +{ + if ((( $mode_patch == 1 ) && ( $line =~ m/^\+/)) || $mode_patch == 0) { + + my @matches = $line =~ m/[\s\(\)+-\/\*{}<>=,;&~#\!'"\[](CFG_[A-Z0-9_a-z]+)/; + + push (@matches, $line =~ m/^(CFG_[A-Z0-9_a-z]+)/); + + push (@matches, $line =~ m/-D(CFG_[A-Z0-9_a-z]+)/); + + my $sz = scalar(@matches); + + for (my $i=0; $i < $sz; $i++) { + $cfg = $matches[$i]; + print $file.":".$num." "; + print "#error \"".$cfg." renamed! Use "; + $cfg =~ s/CFG_/CONFIG_SYS_/g; + print $cfg." or new config instead!\"\n"; + print $line."\n"; + } + } + $num++; +} +close FILE; -- 1.5.6.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Healthcare Industry Directory
Currently in Practice: Medical Doctors in the United States Data for the many various medical specialties Sort by over a dozen different fields Price for this week only = $398 {}{}{} Order this week and get the additional data below for free {}{}{} <> Optometrists <> Visiting Nurses & RN's <> Massage Therapists <> Acupuncturists send email to:: [EMAIL PROTECTED] valid thru Oct 17 ~~ stop these emails by looking here please email [EMAIL PROTECTED] ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.
Dear Ben Warren, In message <[EMAIL PROTECTED]> you wrote: > > > You are right (as I wrote in the help text ...) > > > > Is "i2c reinit" as commandname ok? Please stick with "i2c reset" Nad, Heiko: in English, it's "command name". > I don't have a problem with 'i2c reset' or 'i2c reinit' as commands, > since it's best to not have punctuation symbols in commands, but in the > help text we should use proper words, either 'reset', 're-init' or > 're-initialize'. ACK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] 1000 pains = 1 Megahertz ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] add tool to check patch and file for CFG_ presence
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <[EMAIL PROTECTED]> you wrote: > add same check on all board at MAKEALL start > it can be disable by CHECK=no as > $ CHECK=no ./MAKEALL NAK. As discussed before, please remove the CHECK stuff from MAKEALL. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Anyone who isn't confused here doesn't really know what's going on. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
On Tue, Oct 14, 2008 at 01:24:09PM -0700, Ron Madrid wrote: > 1. I don't see anywhere that the AL (address length, or number of > address cycles) can be set to anything other than 2. It appears to be > hard coded in both files. Correct. AFAICT, setting AL to anything less than 2 is just an optimization for small flashes. Linux will make that optimization, but the way NAND devices are currently probed in u-boot makes that awkward (no opportunity to run code after size is known, but before nand_scan_tail). > 2. nand_boot_fsl_elbc.c uses ECCM = 1 for large page devices, but I > don't see a place where fsl_elbc_nand.c sets ECCM to 1 for similar > devices. That looks like a bug. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] [83xx] Removed #ifdef CONFIG_MPC834X dependency on upmconfig function
Removed #ifdef CONFIG_MPC834X dependency on upmconfig function. Signed-off-by: Richard Retanubun <[EMAIL PROTECTED]> --- cpu/mpc83xx/cpu.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c index 99ab216..848b8fd 100644 --- a/cpu/mpc83xx/cpu.c +++ b/cpu/mpc83xx/cpu.c @@ -147,7 +147,6 @@ int checkcpu(void) */ void upmconfig (uint upm, uint *table, uint size) { -#if defined(CONFIG_MPC834X) volatile immap_t *immap = (immap_t *) CFG_IMMR; volatile lbus83xx_t *lbus = &immap->lbus; volatile uchar *dummy = NULL; @@ -181,10 +180,6 @@ void upmconfig (uint upm, uint *table, uint size) /* Set the OP field in the MxMR to "normal" and the MAD field to 00 */ *mxmr &= 0xCFC0; -#else -printf("Error: %s() not defined for this configuration.\n", __FUNCTION__); -hang(); -#endif } -- 1.5.5.GIT ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [POWERPC] mgcoge: Second Flash on CS5 not on CS1
Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- board/keymile/mgcoge/mgcoge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/board/keymile/mgcoge/mgcoge.c b/board/keymile/mgcoge/mgcoge.c index 099e77b..5931f17 100644 --- a/board/keymile/mgcoge/mgcoge.c +++ b/board/keymile/mgcoge/mgcoge.c @@ -334,7 +334,7 @@ void ft_blob_update (void *blob, bd_t *bd) /* update Flash addr, size */ flash_data[2] = cpu_to_be32 (CFG_FLASH_BASE); flash_data[3] = cpu_to_be32 (CFG_FLASH_SIZE); - flash_data[4] = cpu_to_be32 (1); + flash_data[4] = cpu_to_be32 (5); flash_data[5] = cpu_to_be32 (0); flash_data[6] = cpu_to_be32 (CFG_FLASH_BASE_1); flash_data[7] = cpu_to_be32 (CFG_FLASH_SIZE_1); -- 1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 13/16] I2C: adding new "i2c bus" Command to the I2C Subsystem.
Hi Heiko, Heiko Schocher wrote: > Hello Ben, > > Ben Warren wrote: > >> Heiko Schocher wrote: >> >>> With this Command it is possible to add new I2C Busses, >>> which are behind 1 .. n I2C Muxes. Details see README. >>> >>> >> While this is pretty cool, I'm curious what circumstances lead to >> needing to add I2C buses at run-time via command line. Presumably you >> have a real business need for this in a bootloader? >> > > Yes. This boardmanufacturer has a lot of hardwareversions with > different I2C bus wirings, but has for example always one EEProm > with configdata. Now, he can use one u-boot image for all this > boards and has just to define in the environment, in which way > he can reach this EEprom. > > bye > Heiko > Interesting. Thank you. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [POWERPC] mgsuvd: fix compiler warning when using soft_i2c driver
following patch solves the compiler warning for the mgsuvd board, using the soft_i2c driver: [EMAIL PROTECTED] u-boot]$ ./MAKEALL mgsuvd Configuring for mgsuvd board... soft_i2c.c: In function 'write_byte': soft_i2c.c:209: warning: implicit declaration of function 'i2c_soft_read_pin' textdata bss dec hex filename 1746089712 28436 212756 33f14 ./u-boot [EMAIL PROTECTED] u-boot]$ Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- drivers/i2c/soft_i2c.c |2 ++ include/configs/mgsuvd.h |1 + include/i2c.h|4 3 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/soft_i2c.c b/drivers/i2c/soft_i2c.c index 0a9feb6..346125e 100644 --- a/drivers/i2c/soft_i2c.c +++ b/drivers/i2c/soft_i2c.c @@ -41,6 +41,8 @@ #endif #include +CONFIG_I2C_SOFT_EXTERN + /* #define DEBUG_I2C */ #ifdef DEBUG_I2C diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h index 4ecaeac..2171115 100644 --- a/include/configs/mgsuvd.h +++ b/include/configs/mgsuvd.h @@ -356,6 +356,7 @@ #define I2C_ACTIVE do {} while (0) #define I2C_TRISTATE do {} while (0) +#define CONFIG_I2C_SOFT_EXTERN extern int i2c_soft_read_pin (void); #define I2C_READ i2c_soft_read_pin () #define I2C_SDA(bit) if(bit) { \ *(unsigned short *)(I2C_BASE_DIR) &= ~SDA_CONF; \ diff --git a/include/i2c.h b/include/i2c.h index 9f771dd..24d535f 100644 --- a/include/i2c.h +++ b/include/i2c.h @@ -76,6 +76,10 @@ # define I2C_SOFT_DECLARATIONS # endif #endif + +#ifndef CONFIG_I2C_SOFT_EXTERN +#define CONFIG_I2C_SOFT_EXTERN +#endif /* * Initialization, must be called once on start up, may be called * repeatedly to change the speed and slave addresses. -- 1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.
Hello Ben, Ben Warren wrote: > Heiko Schocher wrote: >> Hello Ben, >> >> Ben Warren wrote: >> >>> Heiko Schocher wrote: >>> >> [...] >> "i2c probe - show devices on the I2C bus\n" +"i2c reset - reinit the I2C Controller\n" >>> re-init or re-initialize would be better. >>> >> >> You are right (as I wrote in the help text ...) >> >> Is "i2c reinit" as commandname ok? >> >> bye >> Heiko >> > I don't have a problem with 'i2c reset' or 'i2c reinit' as commands, > since it's best to not have punctuation symbols in commands, but in the > help text we should use proper words, either 'reset', 're-init' or > 're-initialize'. Ah, okay. Then I fix just the help text, thanks. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.
Hi Heiko, Heiko Schocher wrote: > Hello Ben, > > Ben Warren wrote: > >> Heiko Schocher wrote: >> > [...] > >>> "i2c probe - show devices on the I2C bus\n" >>> +"i2c reset - reinit the I2C Controller\n" >>> >>> >> re-init or re-initialize would be better. >> > > You are right (as I wrote in the help text ...) > > Is "i2c reinit" as commandname ok? > > bye > Heiko > I don't have a problem with 'i2c reset' or 'i2c reinit' as commands, since it's best to not have punctuation symbols in commands, but in the help text we should use proper words, either 'reset', 're-init' or 're-initialize'. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [POWERPC] mgcoge, mgsuvd: fix out-of-tree build error.
Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- board/keymile/mgcoge/Makefile |3 +++ board/keymile/mgsuvd/Makefile |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/board/keymile/mgcoge/Makefile b/board/keymile/mgcoge/Makefile index cbf7129..0cad821 100644 --- a/board/keymile/mgcoge/Makefile +++ b/board/keymile/mgcoge/Makefile @@ -22,6 +22,9 @@ # include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +endif LIB= $(obj)lib$(BOARD).a diff --git a/board/keymile/mgsuvd/Makefile b/board/keymile/mgsuvd/Makefile index 0326608..b2145f9 100644 --- a/board/keymile/mgsuvd/Makefile +++ b/board/keymile/mgsuvd/Makefile @@ -22,6 +22,9 @@ # include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +endif LIB= $(obj)lib$(BOARD).a -- 1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] add tool to check patch and file for CFG_ presence
add same check on all board at MAKEALL start it can be disable by CHECK=no as $ CHECK=no ./MAKEALL Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> --- MAKEALL |5 +++ Makefile |4 ++ tools/find_config_errors | 87 ++ 3 files changed, 96 insertions(+), 0 deletions(-) create mode 100755 tools/find_config_errors diff --git a/MAKEALL b/MAKEALL index 9ccb9ac..a4ce135 100755 --- a/MAKEALL +++ b/MAKEALL @@ -22,6 +22,11 @@ fi LIST="" +if [ "${CHECK}" != "no" ] ; then +#find config errors as incorrectly used old variable names +make find_config_errors +fi + # ## MPC5xx Systems # diff --git a/Makefile b/Makefile index c711df6..e91cb18 100644 --- a/Makefile +++ b/Makefile @@ -3236,4 +3236,8 @@ backup: F=`basename $(TOPDIR)` ; cd .. ; \ gtar --force-local -zcvf `date "+$$F-%Y-%m-%d-%T.tar.gz"` $$F +find_config_errors: + @echo "Search for config errors" + @git-grep CFG_ | cut -d: -f1 | sort -u | xargs -I {} tools/find_config_errors -f {} + # diff --git a/tools/find_config_errors b/tools/find_config_errors new file mode 100755 index 000..168e7e1 --- /dev/null +++ b/tools/find_config_errors @@ -0,0 +1,87 @@ +#!/usr/bin/perl +# +# (C) Copyright 2008 +# Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# +use Getopt::Std; +my $num = 1; +my $mode_patch = 0; +my $opt_string = 'hpf:'; + +getopts( "$opt_string", \%opt ) or usage(); +usage() if $opt{h}; + +if ($opt{p}) { + $mode_patch = 1; +} + +sub usage() +{ + print STDERR << "EOF"; +This program does... +usage: $0 [-hp] [-f file] + -h: this (help) message + -p: mode patch + -f file : file to work on +EOF +exit; +} + +my $file = $opt{f}; + +if ($file =~ m/\.patch$/) { + $mode_patch = 1; +} + +if ($file =~ m/(config_deprecated\.h$|^CHANGELOG)/) { + exit 0 +} + +if ($file) { + open FILE, $file or die $!; +} else { + open FILE, "<&STDIN" or die $!; +} + +while (chomp($line = )) +{ + if ((( $mode_patch == 1 ) && ( $line =~ m/^\+/)) || $mode_patch == 0) { + + my @matches = $line =~ m/[\s\(\)+-\/\*{}<>=,;&~#\!'"\[](CFG_[A-Z0-9_a-z]+)/; + + push (@matches, $line =~ m/^(CFG_[A-Z0-9_a-z]+)/); + + push (@matches, $line =~ m/-D(CFG_[A-Z0-9_a-z]+)/); + + my $sz = scalar(@matches); + + for (my $i=0; $i < $sz; $i++) { + $cfg = $matches[$i]; + print $file.":".$num." "; + print "#error \"".$cfg." renamed! Use "; + $cfg =~ s/CFG_/CONFIG_SYS_/g; + print $cfg." or new config instead!\"\n"; + print $line."\n"; + } + } + $num++; +} +close FILE; -- 1.5.6.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] rename CFG_ macros to CONFIG_SYS
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> --- Makefile | 52 +- README | 334 README.nios_CONFIG_SYS_NIOS_CPU| 140 api/api_storage.c |8 +- board/AtmarkTechno/suzaku/flash.c |2 +- board/BuS/EB+MCF-EV123/EB+MCF-EV123.c | 30 +- board/BuS/EB+MCF-EV123/VCxK.c |2 +- board/BuS/EB+MCF-EV123/cfm_flash.c | 16 +- board/BuS/EB+MCF-EV123/cfm_flash.h |2 +- board/BuS/EB+MCF-EV123/flash.c | 20 +- board/BuS/EB+MCF-EV123/mii.c | 12 +- board/LEOX/elpt860/elpt860.c | 52 +- board/LEOX/elpt860/flash.c | 30 +- board/MAI/AmigaOneG3SE/cmd_boota.c |2 +- board/MAI/AmigaOneG3SE/flash.c |4 +- board/MAI/AmigaOneG3SE/flash_new.c | 30 +- board/MAI/AmigaOneG3SE/i8259.h | 28 +- board/MAI/AmigaOneG3SE/interrupts.c|4 +- board/MAI/AmigaOneG3SE/ps2kbd.c| 10 +- board/MAI/AmigaOneG3SE/serial.c|6 +- board/MAI/AmigaOneG3SE/usb_uhci.c |2 +- board/Marvell/common/flash.c | 22 +- board/Marvell/common/i2c.c |8 +- board/Marvell/common/intel_flash.c |4 +- board/Marvell/common/intel_flash.h |2 +- board/Marvell/common/misc.S| 18 +- board/Marvell/common/ns16550.c |6 +- board/Marvell/common/ns16550.h |2 +- board/Marvell/common/serial.c | 22 +- board/Marvell/db64360/db64360.c| 140 ++-- board/Marvell/db64360/mpsc.c |6 +- board/Marvell/db64360/pci.c| 20 +- board/Marvell/db64360/sdram_init.c | 28 +- board/Marvell/db64460/db64460.c| 140 ++-- board/Marvell/db64460/mpsc.c |6 +- board/Marvell/db64460/pci.c| 20 +- board/Marvell/db64460/sdram_init.c | 28 +- board/MigoR/migo_r.c |6 +- board/RPXClassic/RPXClassic.c | 16 +- board/RPXClassic/eccx.c|2 +- board/RPXClassic/flash.c | 18 +- board/RPXlite/RPXlite.c| 14 +- board/RPXlite/flash.c | 24 +- board/RPXlite_dw/RPXlite_dw.c | 16 +- board/RPXlite_dw/flash.c | 18 +- board/RRvision/RRvision.c | 26 +- board/RRvision/flash.c | 24 +- board/a3000/a3000.c|2 +- board/a3000/flash.c| 30 +- . all board are touched due to ML limitation patch available here http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=c52cc1840cf8fe7136a83926ce175228901a8e38 Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] IBAT and DBAT question
Hi all, If Im not going to use PCI in U-Boot (just in linux kernel), do I have to set IBAT and DBAT in the board configuration file? Or linux kernel sets them again in arch/powerpc/mm/ppc_mmu_32.c ? Thanks in advance ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.
Hello Ben, Ben Warren wrote: > Heiko Schocher wrote: [...] >> "i2c probe - show devices on the I2C bus\n" >> +"i2c reset - reinit the I2C Controller\n" >> > re-init or re-initialize would be better. You are right (as I wrote in the help text ...) Is "i2c reinit" as commandname ok? bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 13/16] I2C: adding new "i2c bus" Command to the I2C Subsystem.
Hello Ben, Ben Warren wrote: > Heiko Schocher wrote: >> With this Command it is possible to add new I2C Busses, >> which are behind 1 .. n I2C Muxes. Details see README. >> > While this is pretty cool, I'm curious what circumstances lead to > needing to add I2C buses at run-time via command line. Presumably you > have a real business need for this in a bootloader? Yes. This boardmanufacturer has a lot of hardwareversions with different I2C bus wirings, but has for example always one EEProm with configdata. Now, he can use one u-boot image for all this boards and has just to define in the environment, in which way he can reach this EEprom. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [POWERPC] mgcoge: correct init of the UPIOx
Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- board/keymile/mgcoge/mgcoge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/board/keymile/mgcoge/mgcoge.c b/board/keymile/mgcoge/mgcoge.c index 31703ab..099e77b 100644 --- a/board/keymile/mgcoge/mgcoge.c +++ b/board/keymile/mgcoge/mgcoge.c @@ -296,7 +296,7 @@ int board_early_init_r (void) { /* setup the UPIOx */ *(char *)(CFG_PIGGY_BASE + 0x02) = 0xc0; - *(char *)(CFG_PIGGY_BASE + 0x03) = 0x15; + *(char *)(CFG_PIGGY_BASE + 0x03) = 0x35; return 0; } -- 1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [POWERPC] mgcoge: added CONFIG_FIT to support the new u-boot image format
Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- include/configs/mgcoge.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h index ecf93e9..10da6b6 100644 --- a/include/configs/mgcoge.h +++ b/include/configs/mgcoge.h @@ -386,6 +386,7 @@ #defineCFG_RESET_ADDRESS 0xFDFC/* "bad" address */ /* pass open firmware flat tree */ +#define CONFIG_FIT 1 #define CONFIG_OF_LIBFDT 1 #define CONFIG_OF_BOARD_SETUP 1 -- 1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule
From: schardt <[EMAIL PROTECTED]> this patch adds support for the avnet fx12 minimodul it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo Signed-off-by: schardt <[EMAIL PROTECTED]> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- MAINTAINERS |4 + MAKEALL |1 + Makefile | 18 + board/avnet/fx12mm/.gitignore|1 + board/avnet/fx12mm/Makefile | 27 +++ board/avnet/fx12mm/config.mk | 26 +++ board/avnet/fx12mm/fx12mm.c | 52 + board/avnet/fx12mm/init.S| 32 board/avnet/fx12mm/u-boot.lds| 149 ++ board/avnet/fx12mm/xparameters.h | 51 + include/configs/fx12mm.h | 70 ++ 11 files changed, 431 insertions(+), 0 deletions(-) create mode 100644 board/avnet/fx12mm/.gitignore create mode 100644 board/avnet/fx12mm/Makefile create mode 100644 board/avnet/fx12mm/config.mk create mode 100644 board/avnet/fx12mm/fx12mm.c create mode 100644 board/avnet/fx12mm/init.S create mode 100644 board/avnet/fx12mm/u-boot.lds create mode 100644 board/avnet/fx12mm/xparameters.h create mode 100644 include/configs/fx12mm.h diff --git a/MAINTAINERS b/MAINTAINERS index dfc3b56..00fa071 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -366,6 +366,10 @@ Travis Sawyer ([EMAIL PROTECTED]> METROBOXPPC440GX XPEDITE1K PPC440GX +Georg Schardt <[EMAIL PROTECTED]> + + fx12mm PPC405 + Heiko Schocher <[EMAIL PROTECTED]> ids8247 MPC8247 diff --git a/MAKEALL b/MAKEALL index aa602b7..1f56ac5 100755 --- a/MAKEALL +++ b/MAKEALL @@ -186,6 +186,7 @@ LIST_4xx=" \ ebony \ ERIC\ EXBITGEN\ + fx12mm \ G2000 \ glacier \ haleakala \ diff --git a/Makefile b/Makefile index 06ba2c6..cd4e14c 100644 --- a/Makefile +++ b/Makefile @@ -1291,6 +1291,24 @@ ERIC_config: unconfig EXBITGEN_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx exbitgen +fx12mm_flash_config: unconfig + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic + @mkdir -p $(obj)include $(obj)board/avnet/fx12mm + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-rom.lds"\ + > $(obj)board/avnet/fx12mm/config.tmp + @echo "TEXT_BASE := 0xFFCB" \ + >> $(obj)board/avnet/fx12mm/config.tmp + @$(MKCONFIG) fx12mm ppc ppc4xx fx12mm avnet + +fx12mm_config: unconfig + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic + @mkdir -p $(obj)include $(obj)board/avnet/fx12mm + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-ram.lds"\ + > $(obj)board/avnet/fx12mm/config.tmp + @echo "TEXT_BASE := 0x0300" \ + >> $(obj)board/avnet/fx12mm/config.tmp + @$(MKCONFIG) fx12mm ppc ppc4xx fx12mm avnet + G2000_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx g2000 diff --git a/board/avnet/fx12mm/.gitignore b/board/avnet/fx12mm/.gitignore new file mode 100644 index 000..b644f59 --- /dev/null +++ b/board/avnet/fx12mm/.gitignore @@ -0,0 +1 @@ +config.tmp diff --git a/board/avnet/fx12mm/Makefile b/board/avnet/fx12mm/Makefile new file mode 100644 index 000..f943781 --- /dev/null +++ b/board/avnet/fx12mm/Makefile @@ -0,0 +1,27 @@ +# +# (C) Copyright 2008 +# Ricardo Ribalda,Universidad Autonoma de Madrid, [EMAIL PROTECTED] +# This work has been supported by: Qtechnology http://qtec.com/ +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +COBJS += $(BOARD).o + +include $(SRCTREE)/board/xilinx/ppc405-generic/Makefile diff --git a/board/avnet/fx12mm/config.mk b/board/avnet/fx12mm/config.mk new file mode 100644 index 000..f5a6039 --- /dev/null +++ b/board/avnet/fx12mm/config.mk @@ -0,0 +1,26 @@ +# +# (C) Copyright 2008 +# Ricardo Ribalda-Universidad Autonoma de [EMAIL PROTECTED] +# Work supported by Qtechnology http://www.qtec.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is f
Re: [U-Boot] [PATCH] ppc4xx: Generic architecture for xilinx ppc405
Hello Stefan Thanks for your comments. I have just uploaded v2 of the patch. > How about the existing Xilinx PPC405 boards like ml300? Should they somehow > use this new infrastructure? Yes, that is the idea, adapt them to use this. So we have less work to support them in the future. This should be done step by step... Right now there is one board incoming for this infrastructure (by Georg Schardt) Best regards -- Ricardo Ribalda http://www.eps.uam.es/~rribalda/ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ppc4xx: Generic architecture for xilinx ppc405 (v2)
As "ppc44x: Unification of virtex5 pp440 boards" did for the xilinx ppc440 boards, this patch presents a common architecture for all the xilinx ppc405 boards. Any custom xilinx ppc405 board can be added very easily with no code duplicity. This patch also adds a simple generic board, that can be used on almost any design with xilinx ppc405 replacing the file ppc405-generic/xparameters.h This patch is prepared to work with the latest version of EDK (10.1) Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- Includes changes propossed by Stefan Roese -Remove unneeded init.S -PPC404 ->PPC405 CREDITS|1 + MAINTAINERS|1 + Makefile | 16 ++ board/xilinx/ppc405-generic/.gitignore |1 + board/xilinx/ppc405-generic/Makefile | 60 board/xilinx/ppc405-generic/config.mk | 25 board/xilinx/ppc405-generic/u-boot-ram.lds | 134 ++ board/xilinx/ppc405-generic/u-boot-rom.lds | 144 .../xilinx/ppc405-generic/xilinx_ppc405_generic.c | 59 board/xilinx/ppc405-generic/xparameters.h | 36 + cpu/ppc4xx/start.S |3 +- include/configs/xilinx-ppc405-generic.h| 58 include/configs/xilinx-ppc405.h| 123 + 13 files changed, 660 insertions(+), 1 deletions(-) create mode 100644 board/xilinx/ppc405-generic/.gitignore create mode 100644 board/xilinx/ppc405-generic/Makefile create mode 100644 board/xilinx/ppc405-generic/config.mk create mode 100644 board/xilinx/ppc405-generic/u-boot-ram.lds create mode 100644 board/xilinx/ppc405-generic/u-boot-rom.lds create mode 100644 board/xilinx/ppc405-generic/xilinx_ppc405_generic.c create mode 100644 board/xilinx/ppc405-generic/xparameters.h create mode 100644 include/configs/xilinx-ppc405-generic.h create mode 100644 include/configs/xilinx-ppc405.h diff --git a/CREDITS b/CREDITS index 3767322..9ddf0d2 100644 --- a/CREDITS +++ b/CREDITS @@ -407,6 +407,7 @@ N: Ricardo Ribalda Delgado E: [EMAIL PROTECTED] D: PPC440x5 (Virtex5), ML507 Board, eeprom_simul, adt7460, v5fx30teval D: Virtex ppc440 generic architecture +D: Virtex ppc405 generic architecture W: http://www.ii.uam.es/~rribalda N: Stefan Roese diff --git a/MAINTAINERS b/MAINTAINERS index 0f9b213..f2f72df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -320,6 +320,7 @@ Ricardo Ribalda <[EMAIL PROTECTED]> ml507 PPC440x5 v5fx30teval PPC440x5 xilinx-pp440-genericPPC440x5 + xilinx-pp405-genericPPC405 Stefan Roese <[EMAIL PROTECTED]> diff --git a/Makefile b/Makefile index dc0a896..06ba2c6 100644 --- a/Makefile +++ b/Makefile @@ -1516,6 +1516,22 @@ sycamore_config: unconfig WUH405_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx wuh405 esd +xilinx-ppc405-generic_flash_config: unconfig + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-rom.lds"\ + > $(obj)board/xilinx/ppc405-generic/config.tmp + @echo "TEXT_BASE := 0xFE36" \ + >> $(obj)board/xilinx/ppc405-generic/config.tmp + @$(MKCONFIG) xilinx-ppc405-generic ppc ppc4xx ppc405-generic xilinx + +xilinx-ppc405-generic_config: unconfig + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-ram.lds"\ + > $(obj)board/xilinx/ppc405-generic/config.tmp + @echo "TEXT_BASE := 0x0400" \ + >> $(obj)board/xilinx/ppc405-generic/config.tmp + @$(MKCONFIG) xilinx-ppc405-generic ppc ppc4xx ppc405-generic xilinx + xilinx-ppc440-generic_flash_config: unconfig @mkdir -p $(obj)include $(obj)board/xilinx/ppc440-generic @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc440-generic/u-boot-rom.lds"\ diff --git a/board/xilinx/ppc405-generic/.gitignore b/board/xilinx/ppc405-generic/.gitignore new file mode 100644 index 000..b644f59 --- /dev/null +++ b/board/xilinx/ppc405-generic/.gitignore @@ -0,0 +1 @@ +config.tmp diff --git a/board/xilinx/ppc405-generic/Makefile b/board/xilinx/ppc405-generic/Makefile new file mode 100644 index 000..b56bb49 --- /dev/null +++ b/board/xilinx/ppc405-generic/Makefile @@ -0,0 +1,60 @@ +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# (C) Copyright 2008 +# Ricardo Ribalda-Universidad Autonoma de [EMAIL PROTECTED] +# Work supported by Qtechnology http://www.qtec.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Fo
Re: [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code
Ilya Yanok said the following: > Hi Wolfgang, > > Wolfgang Denk wrote: >>> here is a set of changes we made to improve U-Boot JFFS2 code >>> performance. We still can't reach Linux's performance but improvements >>> are significant. >>> >>> Any comments are welcome. >>> >> >> Are these patches independent of each other, or are all of them >> needed, and if so, is there any specific order in which they have to >> be applied? >> > Argh... I forgot to create patches with xxx/nnn notation... > Here is the order of patches: > 0001-jffs2-add-sector_size-field-to-part_info-structure.patch > 0002-jffs2-rewrite-jffs2-scanning-code-based-on-Linux-on.patch > 0003-jffs2-summary-support.patch > 0004-jffs2-fix-searching-for-latest-version-in-jffs2_1pa.patch > 0005-jffs2-add-buffer-to-cache-flash-accesses.patch > 0006-jffs2-cache-data_crc-results.patch > > It's the order of changes in my tree and thus it's the simplest way to > apply this patches. But actual dependencies are as follows: > 0001 and 0004 don't depend on anything > 0002 depends on 0001 > 0003, 0005 and 0006 depend on 0002 > > Regards, Ilya. I have put these patches to our board (MPC8548, NOR Flash, MTD partition size 48MB). a) performance has improved (execution time of 'ls' reduced from ~16s to ~1.5s) b) there is a bug in the patch 0005-jffs2-add-buffer-to-cache-flash-accesses: The passage @@ -724,12 +731,14 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest) latestVersion = jNode->version; } } - put_fl_mem(jNode); + if (pL->readbuf == NULL) + put_fl_mem(jNode); } #endif should be @@ -724,12 +731,14 @@ jffs2_1pass_read_inode(struct b_lists *pL, u32 inode, char *dest) latestVersion = jNode->version; } } - put_fl_mem(jNode); + if (pL->readbuf == NULL) + put_fl_mem(jNode, NULL); } #endif c) I found no improvement with CFG_JFFS2_SORT_FRAGMENTS set (the way I detected b) ;-) d) output of 'ls' is corrupted: no date and access right output, directories in / are shown multiple times. -- Michael Lawnick Software Design Engineer Lise-Meitner-Str. 7/1 89081 Ulm Tel: +49 731 9533 2066 [EMAIL PROTECTED] http://www.nokiasiemensnetworks.com/global/ Think before you print ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc4xx: Generic architecture for xilinx ppc405
Hi Ricardo, On Thursday 16 October 2008, Ricardo Ribalda Delgado wrote: > As "ppc44x: Unification of virtex5 pp440 boards" did for the xilinx > ppc440 boards, this patch presents a common architecture for all the > xilinx ppc405 boards. > > Any custom xilinx ppc405 board can be added very easily with no code > duplicity. > > This patch also adds a simple generic board, that can be used on almost > any design with xilinx ppc405 replacing the file > ppc405-generic/xparameters.h > > This patch is prepared to work with the latest version of EDK (10.1) How about the existing Xilinx PPC405 boards like ml300? Should they somehow use this new infrastructure? Please find some more comments below. > Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> > --- > > Please patch it against ppc4xx/next > > > CREDITS|1 + > MAINTAINERS|1 + > Makefile | 16 ++ > board/xilinx/ppc405-generic/.gitignore |1 + > board/xilinx/ppc405-generic/Makefile | 62 + > board/xilinx/ppc405-generic/config.mk | 25 > board/xilinx/ppc405-generic/init.S | 32 + > board/xilinx/ppc405-generic/u-boot-ram.lds | 134 > ++ board/xilinx/ppc405-generic/u-boot-rom.lds | > 144 .../xilinx/ppc405-generic/xilinx_ppc405_generic.c > | 59 board/xilinx/ppc405-generic/xparameters.h | 36 > + > include/configs/xilinx-ppc405-generic.h| 58 > include/configs/xilinx-ppc405.h| 123 > + 13 files changed, 692 insertions(+), 0 deletions(-) > create mode 100644 board/xilinx/ppc405-generic/.gitignore > create mode 100644 board/xilinx/ppc405-generic/Makefile > create mode 100644 board/xilinx/ppc405-generic/config.mk > create mode 100644 board/xilinx/ppc405-generic/init.S > create mode 100644 board/xilinx/ppc405-generic/u-boot-ram.lds > create mode 100644 board/xilinx/ppc405-generic/u-boot-rom.lds > create mode 100644 board/xilinx/ppc405-generic/xilinx_ppc405_generic.c > create mode 100644 board/xilinx/ppc405-generic/xparameters.h > create mode 100644 include/configs/xilinx-ppc405-generic.h > create mode 100644 include/configs/xilinx-ppc405.h > > diff --git a/CREDITS b/CREDITS > index 3767322..9ddf0d2 100644 > --- a/CREDITS > +++ b/CREDITS > @@ -407,6 +407,7 @@ N: Ricardo Ribalda Delgado > E: [EMAIL PROTECTED] > D: PPC440x5 (Virtex5), ML507 Board, eeprom_simul, adt7460, v5fx30teval > D: Virtex ppc440 generic architecture > +D: Virtex ppc405 generic architecture > W: http://www.ii.uam.es/~rribalda > > N: Stefan Roese > diff --git a/MAINTAINERS b/MAINTAINERS > index 0f9b213..dfc3b56 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -320,6 +320,7 @@ Ricardo Ribalda <[EMAIL PROTECTED]> > ml507 PPC440x5 > v5fx30teval PPC440x5 > xilinx-pp440-genericPPC440x5 > + xilinx-pp405-genericPPC404 PPC405! > Stefan Roese <[EMAIL PROTECTED]> > > diff --git a/Makefile b/Makefile > index dc0a896..06ba2c6 100644 > --- a/Makefile > +++ b/Makefile > @@ -1516,6 +1516,22 @@ sycamore_config: unconfig > WUH405_config: unconfig > @$(MKCONFIG) $(@:_config=) ppc ppc4xx wuh405 esd > > +xilinx-ppc405-generic_flash_config: unconfig > + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic > + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-rom.lds"\ > + > $(obj)board/xilinx/ppc405-generic/config.tmp > + @echo "TEXT_BASE := 0xFE36" \ > + >> $(obj)board/xilinx/ppc405-generic/config.tmp > + @$(MKCONFIG) xilinx-ppc405-generic ppc ppc4xx ppc405-generic xilinx > + > +xilinx-ppc405-generic_config: unconfig > + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic > + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-ram.lds"\ > + > $(obj)board/xilinx/ppc405-generic/config.tmp > + @echo "TEXT_BASE := 0x0400" \ > + >> $(obj)board/xilinx/ppc405-generic/config.tmp > + @$(MKCONFIG) xilinx-ppc405-generic ppc ppc4xx ppc405-generic xilinx > + > xilinx-ppc440-generic_flash_config: unconfig > @mkdir -p $(obj)include $(obj)board/xilinx/ppc440-generic > @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc440-generic/u-boot-rom.lds"\ > diff --git a/board/xilinx/ppc405-generic/.gitignore > b/board/xilinx/ppc405-generic/.gitignore new file mode 100644 > index 000..b644f59 > --- /dev/null > +++ b/board/xilinx/ppc405-generic/.gitignore > @@ -0,0 +1 @@ > +config.tmp > diff --git a/board/xilinx/ppc405-generic/Makefile > b/board/xilinx/ppc405-generic/Makefile new file mode 100644 > index 000..bda22e4 > --- /dev/null > +++ b/board/xilinx/ppc405-generic/Makefile > @@ -0,0 +1,62 @@ > +# > +# (C) Copyright 2000-2006 > +# Wolfgang Denk, DENX Software Engineering,
[U-Boot] [PATCH] ppc4xx: Generic architecture for xilinx ppc405
As "ppc44x: Unification of virtex5 pp440 boards" did for the xilinx ppc440 boards, this patch presents a common architecture for all the xilinx ppc405 boards. Any custom xilinx ppc405 board can be added very easily with no code duplicity. This patch also adds a simple generic board, that can be used on almost any design with xilinx ppc405 replacing the file ppc405-generic/xparameters.h This patch is prepared to work with the latest version of EDK (10.1) Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- Please patch it against ppc4xx/next CREDITS|1 + MAINTAINERS|1 + Makefile | 16 ++ board/xilinx/ppc405-generic/.gitignore |1 + board/xilinx/ppc405-generic/Makefile | 62 + board/xilinx/ppc405-generic/config.mk | 25 board/xilinx/ppc405-generic/init.S | 32 + board/xilinx/ppc405-generic/u-boot-ram.lds | 134 ++ board/xilinx/ppc405-generic/u-boot-rom.lds | 144 .../xilinx/ppc405-generic/xilinx_ppc405_generic.c | 59 board/xilinx/ppc405-generic/xparameters.h | 36 + include/configs/xilinx-ppc405-generic.h| 58 include/configs/xilinx-ppc405.h| 123 + 13 files changed, 692 insertions(+), 0 deletions(-) create mode 100644 board/xilinx/ppc405-generic/.gitignore create mode 100644 board/xilinx/ppc405-generic/Makefile create mode 100644 board/xilinx/ppc405-generic/config.mk create mode 100644 board/xilinx/ppc405-generic/init.S create mode 100644 board/xilinx/ppc405-generic/u-boot-ram.lds create mode 100644 board/xilinx/ppc405-generic/u-boot-rom.lds create mode 100644 board/xilinx/ppc405-generic/xilinx_ppc405_generic.c create mode 100644 board/xilinx/ppc405-generic/xparameters.h create mode 100644 include/configs/xilinx-ppc405-generic.h create mode 100644 include/configs/xilinx-ppc405.h diff --git a/CREDITS b/CREDITS index 3767322..9ddf0d2 100644 --- a/CREDITS +++ b/CREDITS @@ -407,6 +407,7 @@ N: Ricardo Ribalda Delgado E: [EMAIL PROTECTED] D: PPC440x5 (Virtex5), ML507 Board, eeprom_simul, adt7460, v5fx30teval D: Virtex ppc440 generic architecture +D: Virtex ppc405 generic architecture W: http://www.ii.uam.es/~rribalda N: Stefan Roese diff --git a/MAINTAINERS b/MAINTAINERS index 0f9b213..dfc3b56 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -320,6 +320,7 @@ Ricardo Ribalda <[EMAIL PROTECTED]> ml507 PPC440x5 v5fx30teval PPC440x5 xilinx-pp440-genericPPC440x5 + xilinx-pp405-genericPPC404 Stefan Roese <[EMAIL PROTECTED]> diff --git a/Makefile b/Makefile index dc0a896..06ba2c6 100644 --- a/Makefile +++ b/Makefile @@ -1516,6 +1516,22 @@ sycamore_config: unconfig WUH405_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx wuh405 esd +xilinx-ppc405-generic_flash_config: unconfig + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-rom.lds"\ + > $(obj)board/xilinx/ppc405-generic/config.tmp + @echo "TEXT_BASE := 0xFE36" \ + >> $(obj)board/xilinx/ppc405-generic/config.tmp + @$(MKCONFIG) xilinx-ppc405-generic ppc ppc4xx ppc405-generic xilinx + +xilinx-ppc405-generic_config: unconfig + @mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic + @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-ram.lds"\ + > $(obj)board/xilinx/ppc405-generic/config.tmp + @echo "TEXT_BASE := 0x0400" \ + >> $(obj)board/xilinx/ppc405-generic/config.tmp + @$(MKCONFIG) xilinx-ppc405-generic ppc ppc4xx ppc405-generic xilinx + xilinx-ppc440-generic_flash_config: unconfig @mkdir -p $(obj)include $(obj)board/xilinx/ppc440-generic @echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc440-generic/u-boot-rom.lds"\ diff --git a/board/xilinx/ppc405-generic/.gitignore b/board/xilinx/ppc405-generic/.gitignore new file mode 100644 index 000..b644f59 --- /dev/null +++ b/board/xilinx/ppc405-generic/.gitignore @@ -0,0 +1 @@ +config.tmp diff --git a/board/xilinx/ppc405-generic/Makefile b/board/xilinx/ppc405-generic/Makefile new file mode 100644 index 000..bda22e4 --- /dev/null +++ b/board/xilinx/ppc405-generic/Makefile @@ -0,0 +1,62 @@ +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# (C) Copyright 2008 +# Ricardo Ribalda-Universidad Autonoma de [EMAIL PROTECTED] +# Work supported by Qtechnology http://www.qtec.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free S
Re: [U-Boot] code for DDR
On Wed, Oct 15, 2008 at 7:35 AM, Fabio Estevam <[EMAIL PROTECTED]>wrote: > Kishore, > > --- On Wed, 10/15/08, kishore choudhari <[EMAIL PROTECTED]> wrote: > > > From: kishore choudhari <[EMAIL PROTECTED]> > > Subject: [U-Boot] code for DDR > > To: u-boot@lists.denx.de > > Date: Wednesday, October 15, 2008, 9:26 AM > > Hi all, > > Can i have the bootloader code for DDR ram for > > ARM926EJS > > (ARM9). > > > > thanks in advance. > > You should mention which ARM926EJS device and DDR memory you want to use. > > Regards, > > Fabio Estevam > > > > --- Hi Fabio, Thanks for ur reply. Actually Iam using the samsung s3c2416 board with smdk2416 bootloader for this i want the DDR2 sdram driver in bootloader and kernel also if possible. anyhow thanks once again . Thanks & Regards, kishore. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] GPIO configuration on 460EX
Hi, Stefan Stefan Roese wrote: > Hi Felix, > > On Thursday 16 October 2008, Felix Radensky wrote: > >> I'm looking at GPIO setup code for Canyonlands, and >> it looks like some initializations mentioned in the 460EX >> manual are missing. When pin is configured as alternate >> input, the corresponding bits in TSRL/H registers should >> be set. U-Boot code sets TSRL/H registers only for output >> pins. >> >> Am I missing something ? >> > > Looking again at the users manual I can't find that the TSR register should > be > set for input functionality. Take a look at figure 35-1. Here you will see > that TSR is only involved for output functionality. > > I was looking at section 35.5.3 and Table 35-9 in user manual (Version 1.14) TSR is involved in both input and output functionality. This indeed contradicts the description you were referring to. Maybe AMCC guys reading this list can clarify ? > I assume that you are asking because of your Linux IRQ problem with the > external interrupt, correct? I'll take a look at the Linux thread and try to > give another answer there. > Thanks a lot. Your suggestion in this thread indeed helped. I was using wrong IRQ number in device tree. > And feel free to test with TSR configured for input as well. If this gets > your > interrupt working then this we need to change this GPIO config code of > course. > > I've tried that, but it didn't help. Thanks a lot for you help. Felix. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 3/6] i.MX31: Add basic support for Freescale's i.MX31 PDK board.
On 14:44 Wed 15 Oct , Alan Carvalho de Assis wrote: > Hi Jean-Christophe, > > On Wed, Oct 15, 2008 at 2:04 PM, Jean-Christophe PLAGNIOL-VILLARD > <[EMAIL PROTECTED]> wrote: > > On 08:51 Wed 15 Oct , Alan Carvalho de Assis wrote: > >> Hi Jean-Christophe, > >> > >> On Mon, Oct 13, 2008 at 5:49 AM, Jean-Christophe PLAGNIOL-VILLARD > >> <[EMAIL PROTECTED]> wrote: > >> >> Is there any special reason it was not added to the master branch > >> >> yet? > >> > > >> >> > >> > As we discuss on IRC this board will be merge when it can boot from a > >> > storage > >> > > >> > >> Using some patches I sent we can boot it from storage, even without > >> the MTD NAND driver. > > Could you specify which one? pease > > > > Please check the following thread: > http://lists.denx.de/pipermail/u-boot/2008-October/041355.html > > I can boot from NAND Flash on iMX31PDK board after applying this > series of patches. Thanks, I've seen this patch I put some comment on it asap Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Flex-OneNAND driver
Hi Kyungmin, Thank you for the comments. Kyungmin Park wrote: >> diff --git a/common/env_onenand.c b/common/env_onenand.c >> --- a/common/env_onenand.c >> +++ b/common/env_onenand.c >> @@ -58,11 +58,14 @@ >> >> void env_relocate_spec(void) >> { >> + struct onenand_chip *this = &onenand_chip; >>unsigned long env_addr; >>int use_default = 0; >>size_t retlen; >> >>env_addr = CONFIG_ENV_ADDR; >> + if (FLEXONENAND(this)) >> + env_addr = CONFIG_ENV_ADDR_FLEX; >> > > Umm do you have more fancy method to determine the environment address > whatever it's OneNAND or not. > We can just double CONFIG_ENV_ADDR for Flex-OneNAND, so CONFIG_ENV_ADDR_FLEX is not needed. Otherwise, we can just set env_addr to 1 block size as bootloader is always limited to block 0. >> int saveenv(void) >> { >> + struct onenand_chip *this = &onenand_chip; >>unsigned long env_addr = CONFIG_ENV_ADDR; >>struct erase_info instr = { >>.callback = NULL, >> @@ -96,6 +100,12 @@ >>size_t retlen; >> >>instr.len = CONFIG_ENV_SIZE; >> + if (FLEXONENAND(this)) { >> + env_addr = CONFIG_ENV_ADDR_FLEX; >> + instr.len = CONFIG_ENV_SIZE_FLEX; >> + instr.len <<= onenand_mtd.eraseregions[0].numblocks == 1 ? >> + 1 : 0; >> + } >> > > Ditto. > I don't get alternative than to use CONFIG_ENV_SIZE_FLEX to store size of environment variables partition. Can you please elaborate. Regards, Rohit ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] GPIO configuration on 460EX
Hi Felix, On Thursday 16 October 2008, Felix Radensky wrote: > I'm looking at GPIO setup code for Canyonlands, and > it looks like some initializations mentioned in the 460EX > manual are missing. When pin is configured as alternate > input, the corresponding bits in TSRL/H registers should > be set. U-Boot code sets TSRL/H registers only for output > pins. > > Am I missing something ? Looking again at the users manual I can't find that the TSR register should be set for input functionality. Take a look at figure 35-1. Here you will see that TSR is only involved for output functionality. I assume that you are asking because of your Linux IRQ problem with the external interrupt, correct? I'll take a look at the Linux thread and try to give another answer there. And feel free to test with TSR configured for input as well. If this gets your interrupt working then this we need to change this GPIO config code of course. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot