[U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Hello, While building uboot-2010.03 for any arm board, with USE_PRIVATE_LIBGCC=yes is throwing the following errors. Any help would be appriciated net/libnet.a(net.o): In function `ip_to_string': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/net/net.c:1886: undefined reference to `__bswapsi2' net/libnet.a(nfs.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byteorder/swab.h:113: undefined reference to `__bswapsi2' net/libnet.a(bootp.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byteorder/swab.h:113: undefined reference to `__bswapsi2' common/libcommon.a(cmd_bootm.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byteorder/swab.h:113: undefined reference to `__bswapsi2' common/libcommon.a(cmd_nand.o): In function `nand_load_image': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/common/cmd_nand.c:542: undefined reference to `__bswapsi2' common/libcommon.a(cmd_nvedit.o):/data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/common/cmd_nvedit.c:369: more undefined references to `__bswapsi2' follow lib/libgeneric.a(display_options.o): In function `print_size': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_options.c:66: undefined reference to `__aeabi_uldivmod' /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_options.c:69: undefined reference to `__aeabi_uldivmod' /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_options.c:70: undefined reference to `__aeabi_uldivmod' lib/libgeneric.a(net_utils.o): In function `string_to_ip': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/net_utils.c:40: undefined reference to `__bswapsi2' make: *** [u-boot] Error 1 Thanks in advance Regards Vipin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mkconfig arch link generation
Wolfgang Denk wrote: Dear Matteo Facchinetti, In message 4c3d83f3.1040...@sirius-es.it you wrote: I'm updating my uboot to mainline and I have a question about a link generate from mkconfig (with mpc5121_config). Which code are you talkign about? There is no target mpc5121_config supported in mainline... yes, I've started from mpc5121ads_config but mpc5121ads_rev2_config is the same. U-boot head mainline version. ( 54841ab50c20d6fa6c9cc3eb826989da3a22d934 ) In practice: $ make distclean $ ls -l include/asm/arch ls: cannot access include/asm/arch: No such file or directory $ make mpc5121ads_config Configuring for mpc5121ads board... $ ls -l include/asm/arch lrwxrwxrwx 1 teox teox 12 2010-07-15 09:02 include/asm/arch - arch-mpc512x Regards, Matteo Facchinetti ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Ciao Vipin, ok, so the only way is to select the source file containing the fuction from libgcc and include at source level into your source u-boot tree. I did the same but I started from the lib dir of linux kernel Regards In data giovedì 15 luglio 2010 10:59:52, Vipin KUMAR ha scritto: : Ciao Fabio, On 7/15/2010 1:45 PM, Fabio Giovagnini wrote: I had a similar problem with sh2a 7203 based board and gcc version 4.4.1 (Sourcery G++ Lite 4.4-206) Verify if the undefined symbols are of libgcc. They must be, because I can compile the source without USE_PRIVATE_LIBGCC=yes option But due to a few constraints, I have to compile the code with USE_PRIVATE_LIBGCC=yes option enabled Regards Vipin Regards In data giovedì 15 luglio 2010 09:01:43, Vipin KUMAR ha scritto: : Hello, While building uboot-2010.03 for any arm board, with USE_PRIVATE_LIBGCC=yes is throwing the following errors. Any help would be appriciated net/libnet.a(net.o): In function `ip_to_string': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/net/net.c:1886: undefined reference to `__bswapsi2' net/libnet.a(nfs.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byt eor der/swab.h:113: undefined reference to `__bswapsi2' net/libnet.a(bootp.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byt eor der/swab.h:113: undefined reference to `__bswapsi2' common/libcommon.a(cmd_bootm.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byt eor der/swab.h:113: undefined reference to `__bswapsi2' common/libcommon.a(cmd_nand.o): In function `nand_load_image': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/common/cmd_nand.c :54 2: undefined reference to `__bswapsi2' common/libcommon.a(cmd_nvedit.o):/data/csd_sw/spear/drives_os/vipink/spe ar /uboot/u-boot/common/cmd_nvedit.c:369: more undefined references to `__bswapsi2' follow lib/libgeneric.a(display_options.o): In function `print_size': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_optio ns. c:66: undefined reference to `__aeabi_uldivmod' /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_optio ns .c:69: undefined reference to `__aeabi_uldivmod' /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_optio ns .c:70: undefined reference to `__aeabi_uldivmod' lib/libgeneric.a(net_utils.o): In function `string_to_ip': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/net_utils.c:4 0: undefined reference to `__bswapsi2' make: *** [u-boot] Error 1 Thanks in advance Regards Vipin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Fabio Giovagnini Aurion s.r.l. P.I e C.F. 00885711200 skype: aurion.giovagnini Tel. +39.051.594.78.24 Cell. +39.335.83.50.919 www.aurion-tech.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 8/8] powerpc/85xx: Add memory test feature for mpc85xx.
Dear Timur Tabi, In message aanlktim6yjf6orogtqe0vqivqzqxu-ekkuhdtmjmg...@mail.gmail.com you wrote: NAK. Please do not reinvent the wheel and add yet another meory test. Use one of the existing memory tests we already have - post/drivers/memory.c comes to mind. That code is not capable of testing more than 2GB of RAM. It assumes that memory has already been initialized, but on PowerPC parts, we only ever map 2GB of DDR. We need a memory test that covers all of DDR, but that requries PowerPC-specific code to create sliding TLB windows during the memory test. Then please extend the existing code and add the missing features. We already have too many different implementations of a memory test in U-Boot, and I will not accept adding yet another one. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Programmer's Lament: (Shakespeare, Macbeth, Act I, Scene vii) That we but teach bloody instructions, which, being taught, return to plague the inventor... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
On 7/15/2010 2:34 PM, Fabio Giovagnini wrote: Ciao Vipin, Ciao Again, ok, so the only way is to select the source file containing the fuction from libgcc and include at source level into your source u-boot tree. I did the same but I started from the lib dir of linux kernel Hmmm, I was just avoiding it thinking that maybe someone somewhere would have already done that. May be that patch can also be sent to the community Regards Vipin Regards In data giovedì 15 luglio 2010 10:59:52, Vipin KUMAR ha scritto: : Ciao Fabio, On 7/15/2010 1:45 PM, Fabio Giovagnini wrote: I had a similar problem with sh2a 7203 based board and gcc version 4.4.1 (Sourcery G++ Lite 4.4-206) Verify if the undefined symbols are of libgcc. They must be, because I can compile the source without USE_PRIVATE_LIBGCC=yes option But due to a few constraints, I have to compile the code with USE_PRIVATE_LIBGCC=yes option enabled Regards Vipin Regards In data giovedì 15 luglio 2010 09:01:43, Vipin KUMAR ha scritto: : Hello, While building uboot-2010.03 for any arm board, with USE_PRIVATE_LIBGCC=yes is throwing the following errors. Any help would be appriciated net/libnet.a(net.o): In function `ip_to_string': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/net/net.c:1886: undefined reference to `__bswapsi2' net/libnet.a(nfs.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byt eor der/swab.h:113: undefined reference to `__bswapsi2' net/libnet.a(bootp.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byt eor der/swab.h:113: undefined reference to `__bswapsi2' common/libcommon.a(cmd_bootm.o): In function `__fswab32': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/include/linux/byt eor der/swab.h:113: undefined reference to `__bswapsi2' common/libcommon.a(cmd_nand.o): In function `nand_load_image': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/common/cmd_nand.c :54 2: undefined reference to `__bswapsi2' common/libcommon.a(cmd_nvedit.o):/data/csd_sw/spear/drives_os/vipink/spe ar /uboot/u-boot/common/cmd_nvedit.c:369: more undefined references to `__bswapsi2' follow lib/libgeneric.a(display_options.o): In function `print_size': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_optio ns. c:66: undefined reference to `__aeabi_uldivmod' /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_optio ns .c:69: undefined reference to `__aeabi_uldivmod' /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/display_optio ns .c:70: undefined reference to `__aeabi_uldivmod' lib/libgeneric.a(net_utils.o): In function `string_to_ip': /data/csd_sw/spear/drives_os/vipink/spear/uboot/u-boot/lib/net_utils.c:4 0: undefined reference to `__bswapsi2' make: *** [u-boot] Error 1 Thanks in advance Regards Vipin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mkconfig arch link generation
Dear Matteo Facchinetti, In message 4c3eb5b4.1050...@sirius-es.it you wrote: Which code are you talkign about? There is no target mpc5121_config supported in mainline... yes, No. I've started from mpc5121ads_config but mpc5121ads_rev2_config is the same. U-boot head mainline version. ( 54841ab50c20d6fa6c9cc3eb826989da3a22d934 ) Note that there is a difference between mpc5121ads_config and mpc5121_config - please make sure to be precise in your statements. In practice: $ make distclean $ ls -l include/asm/arch ls: cannot access include/asm/arch: No such file or directory $ make mpc5121ads_config Configuring for mpc5121ads board... $ ls -l include/asm/arch lrwxrwxrwx 1 teox teox 12 2010-07-15 09:02 include/asm/arch - arch-mpc512x Yes, so what? This doesn't seem to hurt for any of the existing boards? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Artificial Intelligence is no match for natural stupidity. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Dear Vipin KUMAR, In message 4c3ed008.1080...@st.com you wrote: ok, so the only way is to select the source file containing the fuction from libgcc and include at source level into your source u-boot tree. I did the same but I started from the lib dir of linux kernel Hmmm, I was just avoiding it thinking that maybe someone somewhere would have already done that. May be that patch can also be sent to the community Feel free to go on - we're looking forward to seeing your patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Your csh still thinks true is false. Write to your vendor today and tell them that next year Configure ought to rm /bin/csh unless they fix their blasted shell. :-) - Larry Wall in Configure from the perl distribution ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Support for SD/MMC for davinci boards ?
Paulraj, Sandeep wrote: Hi Sandeep, Any plan to merge SD/MMC support patches [1] for davinci boards? I dont see these patches in u-boot-ti. git tree [2], Please correct me if I am wrong or I have missed any discussions on these patches. [1] http://lists.denx.de/pipermail/u-boot/2010-May/071434.html [2] git://git.denx.de/u-boot-ti.git http://git.denx.de/u-boot-ti.git -- Regards, Rupesh Gujare Some time back there was an OMAP MMC patch which was ACKED but not applied. So I went ahead and added it to u-boot-ti. I had some days back agreed to take the DaVinci driver into u-boot ti but when I had a look at this entire set of patches for DaVinci MMC support, I realized that It is a set of some 9 patches. This not only adds davinci specific stuff but also modifies MMC and ARM lib code. Further more it seems from the post below http://lists.denx.de/pipermail/u-boot/2010-May/071498.html that it was supposed to be applied to u-boot-mmc but in reality was not really applied making this case synonymous to OMAP MMC patch where the patch was ACKED but not really applied. The best course of action would be to respin the patches(against u-boot-ti) and send it to the list after a round of testing. We can then discuss how to go about adding this to u-boot if nobody objects or adds comments. To be frank adding most of this code is not under my “jurisdiction” and will probably get sent back by Wolfgang even if I add it to u-boot-ti. Regards, Sandeep Hi Sandeep, The patches can be applied as a standalone davinci patch, independent of the other common MMC add-ons. Thats why we have around 9 patches. Let me know if you would like us to regenerate the patch in a different format. We can make the changes, test it and submit again. Best Regards, Alagu Sankar ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Just for my info. I did USE_PRIVATE_LIBGCC=yes modifing directly the makfile. Is iot possible to specify this in board dependent config file? I'll send my patches as soon as i'll finish the porting on my boadl called mlcd7203 Regards In data giovedì 15 luglio 2010 11:13:08, Wolfgang Denk ha scritto: : Dear Vipin KUMAR, In message 4c3ed008.1080...@st.com you wrote: ok, so the only way is to select the source file containing the fuction from libgcc and include at source level into your source u-boot tree. I did the same but I started from the lib dir of linux kernel Hmmm, I was just avoiding it thinking that maybe someone somewhere would have already done that. May be that patch can also be sent to the community Feel free to go on - we're looking forward to seeing your patch. Best regards, Wolfgang Denk -- Fabio Giovagnini Aurion s.r.l. P.I e C.F. 00885711200 skype: aurion.giovagnini Tel. +39.051.594.78.24 Cell. +39.335.83.50.919 www.aurion-tech.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Nor Flash SST39VF6402B cfi compliant support
Hi all, In my experience the SST39VF6402B has become full compliant with CFI mtd interface just few linux kernel ago. In linux 2.6.17 it was not. I'm developing on U-Boot 2010.06-rc2-07985-g53f7677-dirty (lug 15 2010 - 11:41:21) is it compliant with SST39VF6402B Is among of you other people using on their own board such a flash? Thanks a lot -- Fabio Giovagnini Aurion s.r.l. P.I e C.F. 00885711200 skype: aurion.giovagnini Tel. +39.051.594.78.24 Cell. +39.335.83.50.919 www.aurion-tech.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Dear Fabio Giovagnini, In message 201007151151.58747.fabio.giovagn...@aurion-tech.com you wrote: I did USE_PRIVATE_LIBGCC=yes modifing directly the makfile. Is iot possible to specify this in board dependent config file? Why? Just pass it on the command line, or set it as envrionment variable. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are very few personal problems that cannot be solved through a suitable application of high explosives. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
On 7/15/2010 2:43 PM, Wolfgang Denk wrote: Dear Vipin KUMAR, Dear Wolfgang, In message 4c3ed008.1080...@st.com you wrote: ok, so the only way is to select the source file containing the fuction from libgcc and include at source level into your source u-boot tree. I did the same but I started from the lib dir of linux kernel Hmmm, I was just avoiding it thinking that maybe someone somewhere would have already done that. May be that patch can also be sent to the community Feel free to go on - we're looking forward to seeing your patch. The problem why I was looking for this is that the tool-chain I am using only supports -mhard-float option and this toolchain is specifically meant for armv7 (basically Cortex-A9 with FPU enabled). Since this option -msoft-float is passed from arch/arm/cpu/config.mk, and it is common for all arm configurations. Is there a good way to pass -mhard-float.. Regards Vipin Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-boot and AT91SAM9263-EK
Hello Alexander, i made a mistake in configuration (i did'n run mkconfig), uBoot 2010-06 works correctly. Sorry for the confusion. Best regards Radiovan Vapenik Původní zpráva Od: Alexander Stein alexander.st...@systec-electronic.com Předmět: Re: [U-Boot] U-boot and AT91SAM9263-EK Datum: 14.7.2010 17:57:41 Hello, Am Mittwoch, 14. Juli 2010, 17:05:47 schrieb Radovan Vápeník: i have compiled new u-boot (2010-06) for at91sam9263-ek and I have problem with access and save environment variables to NAND Flash. When I set any environment variable and save it to Nand (saveenv), uBoot shows me Saving Environment to NAND... and after it shows the command prompt. The saved variable is not set after reset. The last version, where saving works correctly, is uBoot-2009-11. The variable CONFIG_SYS_USE_NANDFLASH is set in config.h, so variables should be saved to NandFlash. What has been changed in the new uBoot / what i am doing wrong? Last time I build u-boot for 9263-ek was also 2009.11. You may want to git bisect into this problem to find the commit where the problem starts. But don't forget to distclean before. Best regards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Does u-boot support CFI for NOR flash interleaving?
Hello, I checked the linux mtd drivers and found handling of interleaving. But I couldn't figure out any related or similar code in u-boot. So does u-boot support NOR flash interleaving when using CFI? Best regards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] (imp) uboot image size
i am working on Powerpc. sorry for the late response. -SAgar On Wed, Jul 14, 2010 at 6:37 PM, Albert ARIBAUD albert.arib...@free.frwrote: Le 15/07/2010 00:35, Albert ARIBAUD a écrit : Le 14/07/2010 23:49, Wolfgang Denk a écrit : Dear Albert ARIBAUD, why not keeping the list on Cc:? Wrong and unintended action on my part, sorry: I hit the wrong reply button (maybe there's a Thunderbird plugin that helps avoiding this?). As I don't know if you meant this reply of yours to be made public eventually, I'm replying in private. If you want to switch back to the list, no problem for me. Argh. Seems like I'm cursed :( -- Apologies for going back to the list when I say I don't. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Question on non-muxed eLBC at Freescale PQ II/III
All, during schematic design of a MPC8377 based board I stumbled over an issue with the local bus holding various Nor-/Nand-Flash and SRAM devices. Freescale's eLBC Controller supports muxed and non-muxed addressing modes. All FSL reference schematics are using muxed mode utilizing an address latch and bi-directional data buffer controlled by LBCTRL signal. The non-muxed mode doesn't need this latching stuff but is limited to 21 address signals ... which would enough for me. Has anybody done this before or is actively using a system with that kind of eLBC config ? Are there any known issues with non-muxed mode ? Any hints are welcome. Regards, André Schwarz MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Unable to save environment variable in NOR Flash
Dne Čt 15. července 2010 14:20:04 StephenPaulraj Chinnadurai-ERS,HCLTech napsal(a): Hi, I am having a board which is using PXA270 controller and connected to the PC48F4400P0VT00 flash. I am using the u-boot which is in the devel branch (version: PXA: Toradex Colibri PXA270 supporthttp://git.denx.de/?p=u-boot/u-boot-pxa.git;a=commit;h=4cca3cf3041 c2257cfaf0b4f664c43d68e13a0d1). I am getting the following error message while saving the environment variable. saveenv Saving Environment to Flash... . done Un-Protected 1 sectors . done Un-Protected 1 sectors Unable to save the rest of sector (245760) . done Protected 1 sectors . done Protected 1 sectors $ I need your help to save the environment variable in the flash. Also openpxa is for pxa3xx, pxa2xx stuff goes only through u-boot mailing list (CCed). Cheers Thanks and Regards Stephen Paulraj C HCL Technologies Ltd. D-12, Sidco Industrial Estate, Ambattur, Chennai -58 Tel: +91 44 42004800 Extn: 2319 Mob:+91 9962583934 www.hcl.infile:///C:\Documents%20and%20Settings\stephenpaulrajc\Applicatio n%20Data\Microsoft\Signatures\www.hcl.in [cid:image001.jpg@01CB2446.27A6E1F0] DISCLAIMER: --- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or HCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any mail and attachments please check them for viruses and defect. --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Support for SD/MMC for davinci boards ?
-- Regards, Rupesh Gujare Some time back there was an OMAP MMC patch which was ACKED but not applied. So I went ahead and added it to u-boot-ti. I had some days back agreed to take the DaVinci driver into u-boot ti but when I had a look at this entire set of patches for DaVinci MMC support, I realized that It is a set of some 9 patches. This not only adds davinci specific stuff but also modifies MMC and ARM lib code. Further more it seems from the post below http://lists.denx.de/pipermail/u-boot/2010-May/071498.html that it was supposed to be applied to u-boot-mmc but in reality was not really applied making this case synonymous to OMAP MMC patch where the patch was ACKED but not really applied. The best course of action would be to respin the patches(against u-boot-ti) and send it to the list after a round of testing. We can then discuss how to go about adding this to u-boot if nobody objects or adds comments. To be frank adding most of this code is not under my jurisdiction and will probably get sent back by Wolfgang even if I add it to u-boot-ti. Regards, Sandeep Hi Sandeep, The patches can be applied as a standalone davinci patch, independent of the other common MMC add-ons. Thats why we have around 9 patches. Let me know if you would like us to regenerate the patch in a different format. We can make the changes, test it and submit again. Just submit the entire series again to the list. Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc/p4080: Add support for CPC(Corenet platform cache) on CoreNet platforms
The CoreNet style platforms can have a L3 cache that fronts the memory
controllers. Enable that cache as well as add information into the
device tree about it.
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
Signed-off-by: Dave Liu dave...@freescale.com
Signed-off-by: Becky Bruce bec...@kernel.crashing.org
Signed-off-by: Roy Zang tie-fei.z...@freescale.com
Signed-off-by: Timur Tabi ti...@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/cpu/mpc85xx/cpu_init.c | 45 ++-
arch/powerpc/cpu/mpc85xx/fdt.c | 24 ++
2 files changed, 68 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c
b/arch/powerpc/cpu/mpc85xx/cpu_init.c
index e957677..b257a0f 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu_init.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c
@@ -127,6 +127,44 @@ void config_8560_ioports (volatile ccsr_cpm_t * cpm)
}
#endif
+#ifdef CONFIG_SYS_FSL_CPC
+static void enable_cpc(void)
+{
+ int i;
+ u32 size = 0;
+
+ cpc_corenet_t *cpc = (cpc_corenet_t *)CONFIG_SYS_FSL_CPC_ADDR;
+
+ for (i = 0; i CONFIG_SYS_NUM_CPC; i++, cpc++) {
+ u32 cpccfg0 = in_be32(cpc-cpccfg0);
+ size += CPC_CFG0_SZ_K(cpccfg0);
+
+ out_be32(cpc-cpccsr0, CPC_CSR0_CE | CPC_CSR0_PE);
+ /* Read back to sync write */
+ in_be32(cpc-cpccsr0);
+
+ }
+
+ printf(Corenet Platform Cache: %d KB enabled\n, size);
+}
+
+void invalidate_cpc(void)
+{
+ int i;
+ cpc_corenet_t *cpc = (cpc_corenet_t *)CONFIG_SYS_FSL_CPC_ADDR;
+
+ for (i = 0; i CONFIG_SYS_NUM_CPC; i++, cpc++) {
+ /* Flash invalidate the CPC and clear all the locks */
+ out_be32(cpc-cpccsr0, CPC_CSR0_FI | CPC_CSR0_LFC);
+ while (in_be32(cpc-cpccsr0) (CPC_CSR0_FI | CPC_CSR0_LFC))
+ ;
+ }
+}
+#else
+#define enable_cpc()
+#define invalidate_cpc()
+#endif /* CONFIG_SYS_FSL_CPC */
+
/*
* Breathe some life into the CPU...
*
@@ -242,6 +280,9 @@ void cpu_init_f (void)
corenet_tb_init();
#endif
init_used_tlb_cams();
+
+ /* Invalidate the CPC before DDR gets enabled */
+ invalidate_cpc();
}
@@ -252,7 +293,6 @@ void cpu_init_f (void)
* use the same bit-encoding as the older 8555, etc, parts.
*
*/
-
int cpu_init_r(void)
{
#ifdef CONFIG_SYS_LBC_LCRR
@@ -373,6 +413,9 @@ int cpu_init_r(void)
#else
puts(disabled\n);
#endif
+
+ enable_cpc();
+
#ifdef CONFIG_QE
uint qe_base = CONFIG_SYS_IMMR + 0x0008; /* QE immr base */
qe_init(qe_base);
diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
index 932466e..6c5fb36 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -28,6 +28,7 @@
#include fdt_support.h
#include asm/processor.h
#include linux/ctype.h
+#include asm/io.h
#ifdef CONFIG_FSL_ESDHC
#include fsl_esdhc.h
#endif
@@ -80,7 +81,30 @@ void ft_fixup_cpu(void *blob, u64 memory_limit)
}
#endif
+#ifdef CONFIG_SYS_FSL_CPC
+static inline void ft_fixup_l3cache(void *blob, int off)
+{
+ u32 line_size, num_ways, size, num_sets;
+ cpc_corenet_t *cpc = (void *)CONFIG_SYS_FSL_CPC_ADDR;
+ u32 cfg0 = in_be32(cpc-cpccfg0);
+
+ size = CPC_CFG0_SZ_K(cfg0) * 1024 * CONFIG_SYS_NUM_CPC;
+ num_ways = CPC_CFG0_NUM_WAYS(cfg0);
+ line_size = CPC_CFG0_LINE_SZ(cfg0);
+ num_sets = size / (line_size * num_ways);
+
+ fdt_setprop(blob, off, cache-unified, NULL, 0);
+ fdt_setprop_cell(blob, off, cache-block-size, line_size);
+ fdt_setprop_cell(blob, off, cache-size, size);
+ fdt_setprop_cell(blob, off, cache-sets, num_sets);
+ fdt_setprop_cell(blob, off, cache-level, 3);
+#ifdef CONFIG_SYS_CACHE_STASHING
+ fdt_setprop_cell(blob, off, cache-stash-id, 1);
+#endif
+}
+#else
#define ft_fixup_l3cache(x, y)
+#endif
#if defined(CONFIG_L2_CACHE)
/* return size in kilobytes */
--
1.6.0.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARMV7: Add basic gpmc initialization for OMAP4
This patch adds a gpmc_init function for OMAP4 and adds calls to gpmc_init for existing OMAP4 boards: panda and sdp4430 Signed-off-by: Steve Sakoman st...@sakoman.com --- arch/arm/cpu/armv7/omap4/Makefile |1 + arch/arm/cpu/armv7/omap4/mem.c | 45 + arch/arm/include/asm/arch-omap4/cpu.h | 48 +++ arch/arm/include/asm/arch-omap4/omap4.h |2 +- arch/arm/include/asm/arch-omap4/sys_proto.h |1 + board/ti/panda/panda.c |2 + board/ti/sdp4430/sdp.c |2 + 7 files changed, 100 insertions(+), 1 deletions(-) create mode 100644 arch/arm/cpu/armv7/omap4/mem.c ERROR: trailing whitespace #43: FILE: arch/arm/cpu/armv7/omap4/mem.c:4: + * $ WARNING: please, no space before tabs #114: FILE: arch/arm/include/asm/arch-omap4/cpu.h:55: +^Iu32 timeout_control; ^I/* 0x40 */$ total: 1 errors, 1 warnings, 143 lines checked please fix the above checkpatch errors Regards, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Unable to save environment variable in NOR Flash
Hi, I am having a board which is using PXA270 controller and connected to the PC48F4400P0VT00 Intel Strataflash. I am using the u-boot which is in the devel branch (version: PXA: Toradex Colibri PXA270 supporthttp://git.denx.de/?p=u-boot/u-boot-pxa.git;a=commit;h=4cca3cf3041c2257cfaf0b4f664c43d68e13a0d1). I am getting the following error message while saving the environment variable. saveenv Saving Environment to Flash... . done Un-Protected 1 sectors . done Un-Protected 1 sectors Unable to save the rest of sector (245760) . done Protected 1 sectors . done Protected 1 sectors $ I need your help to save the environment variable in the flash. Whether drivers/mtd/cfi_flash.c file is a correct one or I need use board\g2000\strataflash.c file to interact with the flash? Kindly someone suggest me the solution. Thanks and Regards Stephen Paulraj C Thanks and Regards Stephen Paulraj C HCL Technologies Ltd. D-12, Sidco Industrial Estate, Ambattur, Chennai -58 Tel: +91 44 42004800 Extn: 2319 Mob:+91 9962583934 www.hcl.infile:///C:\Documents%20and%20Settings\stephenpaulrajc\Application%20Data\Microsoft\Signatures\www.hcl.in [cid:image001.jpg@01CB246D.4D092030] DISCLAIMER: --- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or HCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any mail and attachments please check them for viruses and defect. --- inline: image001.jpg___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc/85xx: Add support to initialize LIODN registers and portals
On the new QorIQ/CoreNet based platforms we need to initialize the
portals as access into the Data Path subystem as well as Logical IO
Device Numbers (LIODN) that are used for the IOMMU (PAMU).
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
Signed-off-by: Scott Wood scottw...@freescale.com
Signed-off-by: Kim Phillips kim.phill...@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/cpu/mpc85xx/Makefile |6 +
arch/powerpc/cpu/mpc85xx/fdt.c | 15 ++
arch/powerpc/cpu/mpc85xx/liodn.c | 187 +
arch/powerpc/cpu/mpc85xx/p4080_ids.c | 115 +++
arch/powerpc/cpu/mpc85xx/portals.c | 238
arch/powerpc/include/asm/fsl_liodn.h | 142 +++
arch/powerpc/include/asm/fsl_portals.h | 59
7 files changed, 762 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/cpu/mpc85xx/liodn.c
create mode 100644 arch/powerpc/cpu/mpc85xx/p4080_ids.c
create mode 100644 arch/powerpc/cpu/mpc85xx/portals.c
create mode 100644 arch/powerpc/include/asm/fsl_liodn.h
create mode 100644 arch/powerpc/include/asm/fsl_portals.h
diff --git a/arch/powerpc/cpu/mpc85xx/Makefile
b/arch/powerpc/cpu/mpc85xx/Makefile
index 4d52ebe..b6456fc 100644
--- a/arch/powerpc/cpu/mpc85xx/Makefile
+++ b/arch/powerpc/cpu/mpc85xx/Makefile
@@ -64,9 +64,15 @@ COBJS-$(CONFIG_PPC_P5020)+= ddr-gen3.o
COBJS-$(CONFIG_CPM2) += ether_fcc.o
COBJS-$(CONFIG_OF_LIBFDT) += fdt.o
+COBJS-$(CONFIG_FSL_CORENET) += liodn.o
COBJS-$(CONFIG_MP) += mp.o
COBJS-$(CONFIG_MPC8536) += mpc8536_serdes.o
COBJS-$(CONFIG_PCI)+= pci.o
+COBJS-$(CONFIG_FSL_CORENET) += portals.o
+
+# various SoC specific assignments
+COBJS-$(CONFIG_PPC_P4080) += p4080_ids.o
+
COBJS-$(CONFIG_QE) += qe_io.o
COBJS-$(CONFIG_CPM2) += serial_scc.o
diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
index 6c5fb36..8e7b827 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -29,6 +29,7 @@
#include asm/processor.h
#include linux/ctype.h
#include asm/io.h
+#include asm/fsl_portals.h
#ifdef CONFIG_FSL_ESDHC
#include fsl_esdhc.h
#endif
@@ -446,4 +447,18 @@ void ft_cpu_setup(void *blob, bd_t *bd)
#endif
ft_fixup_dpaa_clks(blob);
+
+#if defined(CONFIG_SYS_BMAN_MEM_PHYS)
+ fdt_portal(blob, fsl,bman-portal, bman-portals,
+ (u64)CONFIG_SYS_BMAN_MEM_PHYS,
+ CONFIG_SYS_BMAN_MEM_SIZE);
+#endif
+
+#if defined(CONFIG_SYS_QMAN_MEM_PHYS)
+ fdt_portal(blob, fsl,qman-portal, qman-portals,
+ (u64)CONFIG_SYS_QMAN_MEM_PHYS,
+ CONFIG_SYS_QMAN_MEM_SIZE);
+
+ fdt_fixup_qportals(blob);
+#endif
}
diff --git a/arch/powerpc/cpu/mpc85xx/liodn.c b/arch/powerpc/cpu/mpc85xx/liodn.c
new file mode 100644
index 000..bd19094
--- /dev/null
+++ b/arch/powerpc/cpu/mpc85xx/liodn.c
@@ -0,0 +1,187 @@
+/*
+ * Copyright 2008-2010 Freescale Semiconductor, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include libfdt.h
+#include fdt_support.h
+
+#include asm/immap_85xx.h
+#include asm/io.h
+#include asm/processor.h
+#include asm/fsl_portals.h
+#include asm/fsl_liodn.h
+
+int get_dpaa_liodn(enum fsl_dpaa_dev dpaa_dev, u32 *liodns, int liodn_offset)
+{
+ liodns[0] = liodn_bases[dpaa_dev].id[0] + liodn_offset;
+
+ if (liodn_bases[dpaa_dev].num_ids == 2)
+ liodns[1] = liodn_bases[dpaa_dev].id[1] + liodn_offset;
+
+ return liodn_bases[dpaa_dev].num_ids;
+}
+
+static void set_liodn(struct liodn_id_table *tbl, int size)
+{
+ int i;
+
+ for (i = 0; i size; i++) {
+ u32 liodn;
+ if (tbl[i].num_ids == 2) {
+ liodn = (tbl[i].id[0] 16) | tbl[i].id[1];
+ } else {
+ liodn = tbl[i].id[0];
+ }
+
+ out_be32((volatile u32 *)(tbl[i].reg_offset), liodn);
+ }
+}
+
+static void setup_sec_liodn_base(void)
+{
+ ccsr_sec_t *sec = (void *)CONFIG_SYS_FSL_SEC_ADDR;
+ u32 base;
+
+ if (!IS_E_PROCESSOR(get_svr()))
+ return;
+
+ /*
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Dear Vipin KUMAR, In message 4c3eecdb.7000...@st.com you wrote: Since this option -msoft-float is passed from arch/arm/cpu/config.mk, and it is common for all arm configurations. Is there a good way to pass -mhard-float.. Why would you want to do that? We don't use any FP code in U-Boot anyway. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When you say I wrote a program that crashed Windows, people just stare at you blankly and say Hey, I got those with the system, *for free*.- Linus Torvalds in 3itc77$...@ninurta.fer.uni-lj.si ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot- boun...@lists.denx.de] On Behalf Of Wolfgang Denk Sent: Thursday, July 15, 2010 10:58 AM To: Vipin KUMAR Cc: u-boot@lists.denx.de; Shiraz HASHIM Subject: Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option Dear Vipin KUMAR, In message 4c3eecdb.7000...@st.com you wrote: Since this option -msoft-float is passed from arch/arm/cpu/config.mk, and it is common for all arm configurations. Is there a good way to pass - mhard-float.. Why would you want to do that? We don't use any FP code in U-Boot anyway. We have actually seen issues with the post memory tests using the -mfpu=neon and -ftree-vectorize under gcc 4.4.1. So, I would be very careful with FP flags until someone figures out how to fix the 64-bit access operators that the memory test uses. DaR Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When you say I wrote a program that crashed Windows, people just stare at you blankly and say Hey, I got those with the system, *for free*.- Linus Torvalds in 3itc77$...@ninurta.fer.uni-lj.si ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] u-boot-2010.03 build errors with USE_PRIVATE_LIBGCC=yes option
Dear Dennis Ruffer, In message 00ba01cb244a$629a4b90$27cee2...@com you wrote: Why would you want to do that? We don't use any FP code in U-Boot anyway. We have actually seen issues with the post memory tests using the -mfpu=neon and -ftree-vectorize under gcc 4.4.1. So, I would be very careful with FP flags until someone figures out how to fix the 64-bit access operators that the memory test uses. Well, there _is_ a reason for using -msoft-float as we are doing in U-Boot. Thanks for confirming this again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Often it is fatal to live too long. - Racine ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
What is the status of this patch for getting MCI working on SAM9 CPUs? I am working on a new AT91SAM9G45 board and would like to incorporate it if it is ready for prime time. It is not clear to me who should be signing off on this patch and if they have done so. If there is work to be done on this and I could help, please let me know. I intend to submit the patches to get my 9G45 board mainlined and this might be a good way for me to start learning the intricacies of making and submitting a proper patch. Any suggestions will be appreciated. Thanks, Bill Landolina Technology Atlanta Corporation w...@techatl.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
William C. Landolina wrote: What is the status of this patch for getting MCI working on SAM9 CPUs? I am working on a new AT91SAM9G45 board and would like to incorporate it if it is ready for prime time. It is not clear to me who should be signing off on this patch and if they have done so. The Patch is ready and working for 9260/9XE, I signed it off. Next step is for Eric(Hong) Xu to add it to the at91 custodian git, and finally it to be pulled into mainstream. If there is work to be done on this and I could help, please let me know. I intend to submit the patches to get my 9G45 board mainlined and this might be a good way for me to start learning the intricacies of making and submitting a proper patch. For other than 9260/9XE SoCs it should work fine, maybe some defines have to be added to their at91x.h header files, you'll find that out if you try to use ATMEL_MCI there. Any suggestions will be appreciated. Soon I will be working on support for more than 4 GB cards. Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ubifsmount fails after booting linux
On 07/09/2010 05:21 PM, Karl Krach wrote: Hello, Just for documentation: U-boot/mtdparts detected only the first 512Mb of the dual component flash chip while Linux (through the device tree) used the full 1024Mb. It seems that mounting a 1024Mb mtd device, which was created as 512Mb partition works better, than mounting a 512Mb mtd device which was mounted as 1024Mb before. Charly Problem: After booting linux once, I cannot mount my ubifs from uboot any more. (But: On linux it is still working fine...) I receive once again: UBIFS error (pid 0): ubifs_read_node: bad node type (255 but expected 6) UBIFS error (pid 0): ubifs_read_node: bad node at LEB 0:0 Error reading superblock on volume 'ubi:rootfs'! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Confirm...
Your email id has won ￡2,500,000.00 GBP.For claims,FullName, Address, Tel, Age, Occupation. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARMV7: Add basic gpmc initialization for OMAP4
This patch adds a gpmc_init function for OMAP4 and adds calls to gpmc_init for existing OMAP4 boards: panda and sdp4430 Signed-off-by: Steve Sakoman st...@sakoman.com --- arch/arm/cpu/armv7/omap4/Makefile |1 + arch/arm/cpu/armv7/omap4/mem.c | 45 + arch/arm/include/asm/arch-omap4/cpu.h | 48 +++ arch/arm/include/asm/arch-omap4/omap4.h |2 +- arch/arm/include/asm/arch-omap4/sys_proto.h |1 + board/ti/panda/panda.c |2 + board/ti/sdp4430/sdp.c |2 + 7 files changed, 100 insertions(+), 1 deletions(-) create mode 100644 arch/arm/cpu/armv7/omap4/mem.c ERROR: trailing whitespace #43: FILE: arch/arm/cpu/armv7/omap4/mem.c:4: + * $ WARNING: please, no space before tabs #114: FILE: arch/arm/include/asm/arch-omap4/cpu.h:55: +^Iu32 timeout_control; ^I/* 0x40 */$ total: 1 errors, 1 warnings, 143 lines checked please fix the above checkpatch errors I fixed them myself Pushed to u-boot-ti ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] da830 evm: Fix checkpatch error on 'pinmux' macro
Existing code returns checkpatch error on pinmux macro definition for not enclosing the definition in parenthesis. The error can be observed in the patch generated from commit id bdc9c6c7f77a9a63349ecb9f54b20ad34033a2ae. So macro implementation is modified to fix the error. Signed-off-by: Prakash PM prakash...@ti.com --- board/davinci/da8xxevm/da830evm.c | 68 ++-- Pushed to u-boot-ti ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] musb: fix compilation warning
Fixes below compilation warning omap3.c: In function 'musb_platform_init': omap3.c:123: warning: implicit declaration of function 'omap3_evm_need_extvbus' CC: Remy Bohmer li...@bohmer.net Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- Got an ACK from Remy offline Pushed to u-boot-ti ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] da850 evm: Fix definition of 'pinmux' macro
Usage of parenthesis in pinmux macro definition changes the definition of the macro and raises the precedence of '' operator inadvertently over '[]'. Signed-off-by: Prakash PM prakash...@ti.com --- board/davinci/da8xxevm/da850evm.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/board/davinci/da8xxevm/da850evm.c b/board/davinci/da8xxevm/da850evm.c index 959b2c6..eeb456c 100644 --- a/board/davinci/da8xxevm/da850evm.c +++ b/board/davinci/da8xxevm/da850evm.c Pushed to u-boot-ti ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please Pull u-boot-ti master
Wolfgang, Please pull u-boot-ti/master I ran MAKEALL and saw no issues. Regards, Sandeep The following changes since commit dce6538f5d21a0def8a4df5328d536abed3e136a: Nick Thompson (1): Davinci: SPI: add the missing v2 patch changes are available in the git repository at: git://git.denx.de/u-boot-ti.git master Ajay Kumar Gupta (1): musb: fix compilation warning Prakash PM (2): da830 evm: Fix checkpatch error on 'pinmux' macro da850 evm: Fix definition of 'pinmux' macro Steve Sakoman (1): ARMV7: Add basic gpmc initialization for OMAP4 arch/arm/cpu/armv7/omap4/Makefile |1 + arch/arm/cpu/armv7/omap4/mem.c | 45 ++ arch/arm/include/asm/arch-omap4/cpu.h | 48 +++ arch/arm/include/asm/arch-omap4/omap4.h |2 +- arch/arm/include/asm/arch-omap4/sys_proto.h |1 + board/davinci/da8xxevm/da830evm.c | 68 +- board/davinci/da8xxevm/da850evm.c | 22 board/ti/panda/panda.c |2 + board/ti/sdp4430/sdp.c |2 + drivers/usb/musb/omap3.h|2 +- 10 files changed, 146 insertions(+), 47 deletions(-) create mode 100644 arch/arm/cpu/armv7/omap4/mem.c ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PULL] U-Boot-pxa
Dear Marek Vasut, In message 201007142341.38179.marek.va...@gmail.com you wrote: Please merge into -master. The following changes since commit d6f324d03d7829a1da1dee8b60f91b173a3976f0: Merge branch 'next' of git://git.denx.de/u-boot-nios (2010-07-14 22:07:41 +0200) are available in the git repository at: git://git.denx.de/u-boot-pxa.git master Marek Vasut (9): Enable PXAFB for PXA27X and PXA3XX PXA: Add hardware init helper macros PXA: Add PWM2 and PWM3 regs to pxa-regs.h PXA: Add OneNAND booting support to start.S Voipac PXA270 LCD Support PXA: Add support for LMS285GF05 into pxafb PXA: Voipac PXA270 Support PXA: Toradex Colibri PXA270 support PXA: ZipitZ2 support MAKEALL |4 + Makefile |9 + arch/arm/cpu/pxa/pxafb.c | 76 ++- arch/arm/cpu/pxa/start.S | 48 - arch/arm/include/asm/arch-pxa/macro.h| 324 ++ arch/arm/include/asm/arch-pxa/pxa-regs.h | 10 +- board/colibri_pxa270/Makefile| 45 board/colibri_pxa270/colibri_pxa270.c| 118 ++ board/colibri_pxa270/config.mk |1 + board/colibri_pxa270/lowlevel_init.S | 36 +++ board/vpac270/Makefile | 48 board/vpac270/config.mk |1 + board/vpac270/lowlevel_init.S| 40 board/vpac270/u-boot.lds | 55 + board/vpac270/vpac270.c | 127 ++ board/zipitz2/Makefile | 54 + board/zipitz2/config.mk |1 + board/zipitz2/lowlevel_init.S| 40 board/zipitz2/u-boot.lds | 56 + board/zipitz2/zipitz2.c | 213 + boards.cfg |2 + common/lcd.c | 12 +- include/configs/colibri_pxa270.h | 278 ++ include/configs/vpac270.h| 323 + include/configs/zipitz2.h| 259 include/lcd.h|2 +- onenand_ipl/board/vpac270/Makefile | 83 +++ onenand_ipl/board/vpac270/config.mk |1 + onenand_ipl/board/vpac270/lowlevel_init.S| 34 +++ onenand_ipl/board/vpac270/u-boot.onenand.lds | 51 onenand_ipl/board/vpac270/vpac270.c | 42 31 files changed, 2379 insertions(+), 14 deletions(-) create mode 100644 arch/arm/include/asm/arch-pxa/macro.h create mode 100644 board/colibri_pxa270/Makefile create mode 100644 board/colibri_pxa270/colibri_pxa270.c create mode 100644 board/colibri_pxa270/config.mk create mode 100644 board/colibri_pxa270/lowlevel_init.S create mode 100644 board/vpac270/Makefile create mode 100644 board/vpac270/config.mk create mode 100644 board/vpac270/lowlevel_init.S create mode 100644 board/vpac270/u-boot.lds create mode 100644 board/vpac270/vpac270.c create mode 100644 board/zipitz2/Makefile create mode 100644 board/zipitz2/config.mk create mode 100644 board/zipitz2/lowlevel_init.S create mode 100644 board/zipitz2/u-boot.lds create mode 100644 board/zipitz2/zipitz2.c create mode 100644 include/configs/colibri_pxa270.h create mode 100644 include/configs/vpac270.h create mode 100644 include/configs/zipitz2.h create mode 100644 onenand_ipl/board/vpac270/Makefile create mode 100644 onenand_ipl/board/vpac270/config.mk create mode 100644 onenand_ipl/board/vpac270/lowlevel_init.S create mode 100644 onenand_ipl/board/vpac270/u-boot.onenand.lds create mode 100644 onenand_ipl/board/vpac270/vpac270.c Pulled into u-boot-arm #master. Thanks Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de An Ada exception is when a routine gets in trouble and says 'Beam me up, Scotty'. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PULL] U-Boot-pxa
Dear Marek Vasut, In message 201007142341.38179.marek.va...@gmail.com you wrote: Please merge into -master. The following changes since commit d6f324d03d7829a1da1dee8b60f91b173a3976f0: Merge branch 'next' of git://git.denx.de/u-boot-nios (2010-07-14 22:07:41 +0200) are available in the git repository at: git://git.denx.de/u-boot-pxa.git master Marek Vasut (9): Enable PXAFB for PXA27X and PXA3XX PXA: Add hardware init helper macros PXA: Add PWM2 and PWM3 regs to pxa-regs.h PXA: Add OneNAND booting support to start.S Voipac PXA270 LCD Support PXA: Add support for LMS285GF05 into pxafb PXA: Voipac PXA270 Support PXA: Toradex Colibri PXA270 support PXA: ZipitZ2 support Pulled into u-boot-arm #master. Thanks Best regards, Wolfgang Denk Just curious to know Who will send the ARM pull request? Regards, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] 8xx, kup4: minor configuration changes
Dear Heiko Schocher,
In message 4c348537.4010...@denx.de you wrote:
- nfs-options removed
- hda-sda changed
- mtd parts added
- loadaddress changed
- cmd-line length increased
- lcd stuff removed
- code cleanup
Signed-off-by: Klaus Heydeck heyd...@kieback-peter.de
...
+ clrbits_be16 (immap-im_ioport.iop_padat, PA_RS485);
+ clrbits_be16 (immap-im_ioport.iop_papar, PA_RS485);
+ clrbits_be16 (immap-im_ioport.iop_paodr, PA_RS485);
+ setbits_be16 (immap-im_ioport.iop_padir, PA_RS485);
No space after function names; please fix globally.
- if (immap-im_ioport.iop_pcdat (PC_SWITCH1))
+ clrbits_be16 (immap-im_ioport.iop_pcpar, PC_SWITCH1);
+ clrbits_be16 (immap-im_ioport.iop_pcdir, PC_SWITCH1);
+ if (in_be16 (immap-im_ioport.iop_pcdat) (PC_SWITCH1))
Please insert blank line above the if for readability.
setenv (key1, off);
else
setenv (key1, on);
}
+
Please do not add trailing empty lines.
+#define PA_8 0x0080
+#define PA_9 0x0040
+#define PA_100x0020
+#define PA_110x0010
+#define PA_120x0008
+
+#define PB_140x0002
+#define PB_150x0001
+#define PB_160x8000
+#define PB_170x4000
+
+#define PC_4 0x0800
+#define PC_5 0x0400
+#define PC_9 0x0040
It would make sense to add these defines (using a more generic name)
to include/mpc8xx.h (but note that I don't insist on this, as 8xx is
prettymuch dead).
+extern void poweron_key(void);
extern void load_sernum_ethaddr(void);
#endif /* __KUP_H */
+
No trailing blank lines, please fix globally!
...
+ if (read_diag())
+ gd-flags = ~GD_FLG_SILENT;
+ printf (Board: KUP4K Rev %d.%d AK:,rev,mod);
Argh!! Either this is badly indented, or a bug. Please fix!
+ /*
+ * TI Application report: Before using the IO as an input,
+ * a high must be written to the IO first
+ */
+ pcf = 0xFF;
+ i2c_write (0x21, 0, 0 , pcf, 1);
+ if (i2c_read (0x21, 0, 0, pcf, 1)) {
+ puts (n/a\n);
+ }
+ else {
Incorrect brace style - make } else {
...
+ /* no refresh yet */
+ if(rev = 7)
+ out_be32 (memctl-memc_mamr,
+ CONFIG_SYS_MAMR_9COL (~(MAMR_PTAE)));
+ else
+ out_be32 (memctl-memc_mamr,
+ CONFIG_SYS_MAMR_8COL (~(MAMR_PTAE)));
Braces needed for multiline statements.
/* Configure PA8 as output port */
...
+ setbits_be16 (immap-im_ioport.iop_padir, 0x80);
+ setbits_be16 (immap-im_ioport.iop_paodr, 0x80);
+ clrbits_be16 (immap-im_ioport.iop_papar, 0x80);
+ setbits_be16 (immap-im_ioport.iop_padat, 0x80); /* turn it off */
Why don't you use the #defines you added above (PA_8) ? Please check
and fix globally.
...
+ out_be32 (memctl-memc_or1, 0xFF000A00);
+ out_be32 (memctl-memc_br1, 0x0081);
+ out_be32 (memctl-memc_or2, 0xFE000A00);
+ out_be32 (memctl-memc_br2, 0x0181);
+ out_be32 (memctl-memc_or3, 0xFD000A00);
+ out_be32 (memctl-memc_br3, 0x0281);
+ out_be32 (memctl-memc_or6, 0xFC000A00);
+ out_be32 (memctl-memc_br6, 0x0381);
udelay (1);
-
- return (size_b0 + size_b1 + size_b2 + size_b3);
+ return (4 * 16 * 1024 * 1024);
Normally I insist on using get_ram_size() to auto-size and test the
RAM...
#define CONFIG_BOOTCOMMAND \
-run slot_a_boot;run slot_b_boot;run nfs_boot;run panic_boot
+run fat_boot; run slot_b_boot;run slot_a_boot;run nfs_boot;run
panic_boot
Are you absolutely sure you want this behaviour? I would expect you
mean
run fat_boot slot_b_boot slot_a_boot nfs_boot panic_boot
instead?
+/*---
+ * Dynamic MTD partition support
+ */
Incorrect multiline comment style.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Sometimes, too long is too long. - Joe Crowe
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] 8xx, kup4: add FDT support
Dear Heiko Schocher,
In message 4c34853d.3060...@denx.de you wrote:
Signed-off-by: Heiko Schocher h...@denx.de
---
board/kup/kup4k/kup4k.c | 59
+++
include/configs/KUP4K.h |4 +++
2 files changed, 63 insertions(+), 0 deletions(-)
...
+int fdt_set_node_and_value (void *blob,
+ char *nodename,
+ char *regname,
+ void *var,
+ int size)
...
+ ret = fdt_setprop (blob, nodeoffset, regname, var,
+ size);
+ if (ret 0) {
+ printf(ft_blob_update():
+ cannot set %s/%s property; err: %s\n,
+ nodename, regname, fdt_strerror (ret));
+ }
+ } else {
+ printf(ft_blob_update():
+ cannot find %s node err:%s\n,
+ nodename, fdt_strerror (nodeoffset));
Where is the ft_blob_update() in these messages coming from? It
seems unrelated to the functions actually called?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A committee is a group that keeps the minutes and loses hours.
-- Milton Berle
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Usage of bi_env ?
Dear Dirk Behme, In message 4c349814.2000...@googlemail.com you wrote: With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives: ... env_t = 0x ... The code in common/cmd_bdinfo.c for this is bd_t *bd = gd-bd; ... print_num (env_t, (ulong)bd-bi_env); While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here? You missed sending a patch that cleans this up :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The trouble with our times is that the future is not what it used to be. - Paul Valery ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] at91: Defined main clock frequency on esd at91 boards
Dear Daniel Gorsulowski, In message 12785794721539-git-send-email-daniel.gorsulow...@esd.eu you wrote: Autodetection is undesired now Signed-off-by: Daniel Gorsulowski daniel.gorsulow...@esd.eu --- include/configs/meesc.h |9 + include/configs/otc570.h |1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/configs/meesc.h b/include/configs/meesc.h index e085f4a..d3cc582 100644 --- a/include/configs/meesc.h +++ b/include/configs/meesc.h @@ -1,12 +1,12 @@ /* + * (C) Copyright 2010 + * Daniel Gorsulowski daniel.gorsulow...@esd.eu + * esd electronic system design gmbh www.esd.eu + * * (C) Copyright 2007-2008 * Stelian Pop stelian@leadtechdesign.com * Lead Tech Design www.leadtechdesign.com * - * (C) Copyright 2009 - * Daniel Gorsulowski daniel.gorsulow...@esd.eu - * esd electronic system design gmbh www.esd.eu - * * Configuation settings for the esd MEESC board. * * See file CREDITS for list of people who contributed to this @@ -38,6 +38,7 @@ #define CONFIG_MEESC 1 /* Board is esd MEESC */ #define CONFIG_ARM926EJS 1 /* This is an ARM926EJS Core */ #define CONFIG_AT91SAM9263 1 /* It's an AT91SAM9263 SoC */ +#define CONFIG_SYS_AT91_MAIN_CLOCK 1600/* 16.0 MHz crystal */ #define CONFIG_DISPLAY_BOARDINFO 1 #define CONFIG_DISPLAY_CPUINFO 1 /* display cpu info and speed */ #define CONFIG_PREBOOT /* enable preboot variable */ Please feel free to change the year (2009 = 2009-2010), but please do not start a major reordering of copyrighjt information for a single line addition! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de More software projects have gone awry for lack of calendar time than for all other causes combined. - Fred Brooks, Jr., _The Mythical Man Month_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] at91: Update meesc board to new SoC access
Dear Daniel Gorsulowski, In message 12785794723562-git-send-email-daniel.gorsulow...@esd.eu you wrote: * convert meesc board to use c stucture SoC access * change gpio access to at91_gpio syntax * moved CONFIG_SYS_HZ below board and cpu defines (purely cosmetic) Signed-off-by: Daniel Gorsulowski daniel.gorsulow...@esd.eu --- board/esd/meesc/meesc.c | 118 --- include/configs/meesc.h |9 ++-- 2 files changed, 65 insertions(+), 62 deletions(-) diff --git a/board/esd/meesc/meesc.c b/board/esd/meesc/meesc.c index a1b66cb..1477fab 100644 --- a/board/esd/meesc/meesc.c +++ b/board/esd/meesc/meesc.c @@ -1,12 +1,12 @@ /* + * (C) Copyright 2010 + * Daniel Gorsulowski daniel.gorsulow...@esd.eu + * esd electronic system design gmbh www.esd.eu + * * (C) Copyright 2007-2008 * Stelian Pop stelian@leadtechdesign.com * Lead Tech Design www.leadtechdesign.com * - * (C) Copyright 2009 - * Daniel Gorsulowski daniel.gorsulow...@esd.eu - * esd electronic system design gmbh www.esd.eu - * Are you really sure that the 2009 copyright should be removed? that looks strange to me! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I have yet to add the ESP-driver to the kernel to read the mind of the user... - Linus Torvalds in pine.lnx.3.91.960426110644.24860i-100...@linux.cs.helsinki.fi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/28] SPEAr : macb driver support added for spear310 and spear320
Dear Vipin KUMAR, In message 1279084204-3263-8-git-send-email-vipin.ku...@st.com you wrote: From: Vipin KUMAR vipin.ku...@st.com SPEAr310 and SPEAr320 SoCs have an extra ethernet controller. The driver for this device is already supported by u-boot, so configuring board configuration file and defining base addresses etc to make use of the common driver Signed-off-by: Vipin Kumar vipin.ku...@st.com --- arch/arm/include/asm/arch-spear/clk.h | 27 +++ arch/arm/include/asm/arch-spear/hardware.h |7 +++ board/spear/spear310/spear310.c| 25 ++--- board/spear/spear320/spear320.c| 12 +--- include/configs/spear3xx.h | 13 + 5 files changed, 78 insertions(+), 6 deletions(-) create mode 100644 arch/arm/include/asm/arch-spear/clk.h ... +#if defined(CONFIG_MACB) + if (macb_eth_initialize(0, (void *)CONFIG_SYS_MACB0_BASE, + CONFIG_MACB0_PHY) 0) + ret += -1; + + if (macb_eth_initialize(1, (void *)CONFIG_SYS_MACB1_BASE, + CONFIG_MACB1_PHY) 0) + ret += -1; + + if (macb_eth_initialize(2, (void *)CONFIG_SYS_MACB2_BASE, + CONFIG_MACB2_PHY) 0) + ret += -1; + + if (macb_eth_initialize(3, (void *)CONFIG_SYS_MACB3_BASE, + CONFIG_MACB3_PHY) 0) + ret += -1; We need braces for multiline statements. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Infidels in all ages have battled for the rights of man, and have at all times been the fearless advocates of liberty and justice. - Robert Green Ingersoll ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/28] SPEAr : FSMC driver support added
Dear Vipin KUMAR,
In message 1279084204-3263-9-git-send-email-vipin.ku...@st.com you wrote:
From: Vipin KUMAR vipin.ku...@st.com
Flexible static memory controller is a peripheral provided by ST,
which controls the access to NAND chips along with many other
memory device chips eg NOR, SRAM.
This patch adds the driver support for FSMC controller interfacing
with NAND memory.
Signed-off-by: Vipin Kumar vipin.ku...@st.com
...
+static void fsmc_nand_hwcontrol(struct mtd_info *mtd, int cmd, uint ctrl)
+{
+ struct nand_chip *this = mtd-priv;
+ ulong IO_ADDR_W;
We don't allow for CAPITAL C identifiers - these are reserved for
macros.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Bus error -- please leave by the rear door.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/28] SPEAr : Supporting various configurations for spear3xx and spear6xx boards
Dear Vipin KUMAR,
In message 1279084204-3263-14-git-send-email-vipin.ku...@st.com you wrote:
From: Vipin KUMAR vipin.ku...@st.com
spear3xx and 6xx boards can be compiled in following configurations
1. Environment placed in NAND
2. console on usb device
3. console on usb device with environment placed in NAND
Also, renaming the include/configs/spearxxx.h files to spear3xx_evb.h,
spear6xx_evb.h etc to depict evaluation board configuration.
Signed-off-by: Vipin Kumar vipin.ku...@st.com
---
Makefile | 25 +++
board/spear/spear300/config.mk | 11
board/spear/spear310/config.mk | 11
board/spear/spear320/config.mk | 11
board/spear/spear600/config.mk | 11
doc/README.spear | 31
+---
include/configs/{spear3xx.h = spear3xx_evb.h} | 10 +++
include/configs/{spear6xx.h = spear6xx_evb.h} | 10 +++
8 files changed, 62 insertions(+), 58 deletions(-)
rename include/configs/{spear3xx.h = spear3xx_evb.h} (95%)
rename include/configs/{spear6xx.h = spear6xx_evb.h} (88%)
diff --git a/Makefile b/Makefile
index 1d87f37..e264c50 100644
--- a/Makefile
+++ b/Makefile
@@ -2088,12 +2088,27 @@ omap730p2_cs3boot_config :unconfig
@$(MKCONFIG) -n $@ -a omap730p2 arm arm926ejs omap730p2 ti omap
spear300_config \
+spear300_nand_config \
+spear300_usbtty_config \
+spear300_usbtty_nand_config \
spear310_config \
-spear320_config :unconfig
- @$(MKCONFIG) -n $@ -t $@ spear3xx arm arm926ejs $(@:_config=) spear
spear
-
-spear600_config :unconfig
- @$(MKCONFIG) -n $@ -t $@ spear6xx arm arm926ejs $(@:_config=) spear
spear
+spear310_nand_config \
+spear310_usbtty_config \
+spear310_usbtty_nand_config \
+spear320_config \
+spear320_nand_config \
+spear320_usbtty_config \
+spear320_usbtty_nand_config :unconfig
+ @$(MKCONFIG) -n $@ -t $@ spear3xx_evb arm arm926ejs $(@:_config=) spear
spear
+
+spear600_config \
+spear600_nand_config \
+spear600_usbtty_config \
+spear600_usbtty_nand_config :unconfig
+ @$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs $(@:_config=) spear
spear
+
+suen3_config:unconfig
+ @$(MKCONFIG) $(@:_config=) arm arm926ejs km_arm keymile kirkwood
NAK.
I don't want to have such stuff in the Makefile any more. Please try
to find a way how to do this using boards.cfg instead.
[I know that tis is non-trivial; you may want to talk to Detlev about
this - he was thinking about the same issue, but I don;t know if he
came to any conclusions.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I have the simplest tastes. I am always satisfied with the best.
-- Oscar Wilde
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 14/28] SPEAr : Basic spear1300 architecture support added
Dear Vipin KUMAR, In message 1279084204-3263-15-git-send-email-vipin.ku...@st.com you wrote: From: Vipin KUMAR vipin.ku...@st.com SPEAr1300 is an ARMCortexA9 dual core based SoC which supports multiple peripherals such as ... + printf(System is going to reboot ...\n); + + /* + * This 1 second delay will allow the above message + * to be printed before reset + */ + udelay((1000 * 1000)); udelay() is not designed to provide such long delays. This may or may not work - it's bad style in any case. Also, do we really need one second to print 30 characters? And hey, why do you print this at all? Please remove the printf() _and_ the delay. ... +/* load related definitions */ +#define FREE_RUNNING (0x) + +#define CONFIG_SPEARCA9_HZ_CLK (25000) No parens needed in these #defines (please check and fix globally). ... --- /dev/null +++ b/arch/arm/include/asm/arch-spear13xx/sys_proto.h @@ -0,0 +1,34 @@ Drop that header file, and move the prototypes to some other suitable header. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Quote from the Boss... I didn't say it was your fault. I said I was going to blame it on you. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4] [U-BOOT] Zoom3: Add support for OMAP3630 Zoom3 board.
From: Aldo Brett Cedillo Martinez aldo.cedi...@ti.com This patch gives basic functionality to OMAP3630 Zoom3 board. This version has been rebased againts u-boot-ti Signed-off-by: Aldo Brett Cedillo Martinez aldo.cedi...@ti.com --- MAINTAINERS|4 + MAKEALL|1 + board/logicpd/zoom3/Makefile | 54 +++ board/logicpd/zoom3/config.mk | 33 + board/logicpd/zoom3/debug_board.c | 66 + board/logicpd/zoom3/led.c | 133 + board/logicpd/zoom3/zoom3.c| 201 ++ board/logicpd/zoom3/zoom3.h| 164 + board/logicpd/zoom3/zoom3_serial.c | 132 + board/logicpd/zoom3/zoom3_serial.h | 76 ++ boards.cfg |1 + common/serial.c|2 + include/configs/omap3_zoom3.h | 274 include/serial.h |7 + 14 files changed, 1148 insertions(+), 0 deletions(-) create mode 100644 board/logicpd/zoom3/Makefile create mode 100644 board/logicpd/zoom3/config.mk create mode 100644 board/logicpd/zoom3/debug_board.c create mode 100644 board/logicpd/zoom3/led.c create mode 100644 board/logicpd/zoom3/zoom3.c create mode 100644 board/logicpd/zoom3/zoom3.h create mode 100644 board/logicpd/zoom3/zoom3_serial.c create mode 100644 board/logicpd/zoom3/zoom3_serial.h create mode 100644 include/configs/omap3_zoom3.h diff --git a/MAINTAINERS b/MAINTAINERS index 1520312..260fda3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -813,6 +813,10 @@ Alex Z lartSA1100 dnp1110 SA1110 +Aldo Brett Cedillo Martinez aldo.cedi...@ti.com + + omap3_zoom3 ARM CORTEX-A8 (OMAP3xx SoC) + - Unknown / orphaned boards: diff --git a/MAKEALL b/MAKEALL index 2e98b6c..4254a5c 100755 --- a/MAKEALL +++ b/MAKEALL @@ -657,6 +657,7 @@ LIST_ARMV7=\ omap3_sdp3430 \ omap3_zoom1 \ omap3_zoom2 \ + omap3_zoom3 \ omap4_panda \ omap4_sdp4430 \ s5p_goni\ diff --git a/board/logicpd/zoom3/Makefile b/board/logicpd/zoom3/Makefile new file mode 100644 index 000..79c02ab --- /dev/null +++ b/board/logicpd/zoom3/Makefile @@ -0,0 +1,54 @@ +# +# (C) Copyright 2000, 2001, 2002 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# Aldo Cedillo aldo.cedi...@ti.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS-y := $(BOARD).o +COBJS-y += debug_board.o +COBJS-y += zoom3_serial.o +COBJS-$(CONFIG_STATUS_LED) += led.o + +COBJS := $(sort $(COBJS-y)) +SRCS := $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) + +$(LIB):$(obj).depend $(OBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) + +clean: + rm -f $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +#defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/logicpd/zoom3/config.mk b/board/logicpd/zoom3/config.mk new file mode 100644 index 000..33f394b --- /dev/null +++ b/board/logicpd/zoom3/config.mk @@ -0,0 +1,33 @@ +# +# (C) Copyright 2009 +# Texas Instruments, www.ti.com +# +# Zoom II uses OMAP3 (ARM-CortexA8) CPU +# see http://www.ti.com/ for more information on Texas Instruments +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +#
Re: [U-Boot] [PATCH 15/28] SPEAr : spear1300 SoC support added
Dear Vipin KUMAR,
In message 1279084204-3263-16-git-send-email-vipin.ku...@st.com you wrote:
From: Vipin KUMAR vipin.ku...@st.com
SPEAr1300 SoC support contains basic spear1300 support along with the
usage of following drivers
Are you here adding support for a SoC or for a board??? Looks more
like board support to me...
...
--- a/Makefile
+++ b/Makefile
@@ -2107,6 +2107,12 @@ spear600_usbtty_config \
spear600_usbtty_nand_config :unconfig
@$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs $(@:_config=) spear
spear
+spear1300_config \
+spear1300_nand_config \
+spear1300_usbtty_config \
+spear1300_usbtty_nand_config : unconfig
+ @$(MKCONFIG) -n $@ -t $(@:_config=) spear13xx_evb arm arm_cortexa8
spear1300 spear spear13xx
NAK.
Please use boards.cfg instead.
...
+int misc_init_r(void)
+{
+ setenv(verify, n);
NAK.
Please don't mess with things a user might want to do differently.
You can add this as default settingin your environment, but please
allow the user to dicede otherwise.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I paid too much for it, but its worth it.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 21/28] Enable high speed support for usb device framework and usbtty
Dear Vipin KUMAR, In message 1279084204-3263-22-git-send-email-vipin.ku...@st.com you wrote: From: Vipin KUMAR vipin.ku...@st.com This patch adds the support for high speed in usb device framework and usbtty driver. This feature has been kept within a macro CONFIG_USBD_HS, so the board configuration files have to define this macro to enable high speed support. Along with that specific peripheral drivers also need to define a function to let the framework know that the enumeration has happened at high speed. This function prototype is int is_usbd_high_speed(void) Signed-off-by: Vipin Kumar vipin.ku...@st.com --- Makefile | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index ffd4fc1..870207d 100644 --- a/Makefile +++ b/Makefile @@ -2090,22 +2090,26 @@ omap730p2_cs3boot_config :unconfig spear300_config \ spear300_nand_config \ spear300_usbtty_config \ -spear300_usbtty_nand_config \ +spear300_usbtty_nand_config :unconfig + @$(MKCONFIG) -n $@ -t $(@:_config=) spear3xx_evb arm arm926ejs spear300 spear spear + spear310_config \ spear310_nand_config \ spear310_usbtty_config \ -spear310_usbtty_nand_config \ +spear310_usbtty_nand_config :unconfig + @$(MKCONFIG) -n $@ -t $(@:_config=) spear3xx_evb arm arm926ejs spear310 spear spear + spear320_config \ spear320_nand_config \ spear320_usbtty_config \ spear320_usbtty_nand_config :unconfig - @$(MKCONFIG) -n $@ -t $@ spear3xx_evb arm arm926ejs $(@:_config=) spear spear + @$(MKCONFIG) -n $@ -t $@ spear3xx_evb arm arm926ejs spear320 spear spear spear600_config \ spear600_nand_config \ spear600_usbtty_config \ spear600_usbtty_nand_config :unconfig - @$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs $(@:_config=) spear spear + @$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs spear600 spear spear spear1300_config \ spear1300_nand_config \ -- NAK. Please move to boards.cfg instead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Never underestimate the power of human stupidity when it comes to using technology they don't understand. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 24/28] SPEAr : Network support configuration
Dear Vipin KUMAR, In message 1279084204-3263-25-git-send-email-vipin.ku...@st.com you wrote: From: Vipin KUMAR vipin.ku...@st.com This patch implements the review feedbacks provided by Ben according to which board_eth_init routine should not return -1. Instead, it should handle the errors itself (by printing error banner / somethign else) For more info http://lists.denx.de/pipermail/u-boot/2010-May/071357.html Please squash into the patch that adds this code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe contains any amount of horrible ways to be woken up, such as the noise of the mob breaking down the front door, the scream of fire engines, or the realization that today is the Monday which on Friday night was a comfortably long way off. - Terry Pratchett, _Moving Pictures_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 25/28] SPEAr : Enabling GPT clock explicitly
Dear Vipin KUMAR, In message 1279084204-3263-26-git-send-email-vipin.ku...@st.com you wrote: From: Vipin KUMAR vipin.ku...@st.com uboot needs gpt for timer operations. This clock was enabled from previous level booting software until now. This patch enables it in uboot explicitly Please note: the correct spelling is U-Boot. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The majority of the stupid is invincible and guaranteed for all time. The terror of their tyranny, however, is alleviated by their lack of consistency. - Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 27/28] SPEAr : Ethernet issue workaround is not needed when uboot is acting as flashing
Dear Vipin KUMAR, In message 1279084204-3263-28-git-send-email-vipin.ku...@st.com you wrote: From: Vipin KUMAR vipin.ku...@st.com Ethernet/UHC issue workaround which resets the SoC has an unexpected effect while using uboot as flashing utils firmware. So, excluding the changes for uboot built as usbtty firmware Sorry, but I don't understand what you're trying to tell us here. Please re-formulate so everybody understands this. Enable overwriting of env variables. The env variables ethaddr, serial# etc support a feture of being written only once. Though this feature is bypassed using this patch This is not a good idea, it seems to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There was no difference between the behavior of a god and the operations of pure chance... - Thomas Pynchon, _Gravity's Rainbow_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 28/28] SPEAr1310 : spear1310 support added
Dear Vipin KUMAR, In message 1279084204-3263-29-git-send-email-vipin.ku...@st.com you wrote: This patch adds the support for spear1310 SoC. Currently spear1310 uses the following drivers - UART (PL011) - designware i2c - st smi (Serial Memory Interface) - designware usb device - designware ethernet Is this adding a SoC or a board? Looks more like a board to me! diff --git a/Makefile b/Makefile index 870207d..fb0ad0f 100644 --- a/Makefile +++ b/Makefile @@ -2117,6 +2117,12 @@ spear1300_usbtty_config \ spear1300_usbtty_nand_config : unconfig @$(MKCONFIG) -n $@ -t $(@:_config=) spear13xx_evb arm arm_cortexa8 spear1300 spear spear13xx +spear1310_config \ +spear1310_nand_config \ +spear1310_usbtty_config \ +spear1310_usbtty_nand_config : unconfig + @$(MKCONFIG) -n $@ -t $(@:_config=) spear13xx_evb arm arm_cortexa8 spear1310 spear spear13xx NAK. Please move to boards.cfg instead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What's the sound a name makes when it's dropped? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/4] powerpc/p4080: Add workaround for erratum CPU22
Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- arch/powerpc/cpu/mpc85xx/cmd_errata.c |4 +++- arch/powerpc/cpu/mpc85xx/cpu_init.c |7 +++ arch/powerpc/cpu/mpc85xx/release.S|6 ++ arch/powerpc/include/asm/processor.h |1 + 4 files changed, 17 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c b/arch/powerpc/cpu/mpc85xx/cmd_errata.c index 01c462c..d73f3d7 100644 --- a/arch/powerpc/cpu/mpc85xx/cmd_errata.c +++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c @@ -44,7 +44,9 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) #if defined(CONFIG_SYS_P4080_ERRATUM_SERDES8) puts(Work-around for Erratum SERDES8 enabled\n); #endif - +#if defined(CONFIG_SYS_P4080_ERRATUM_CPU22) + puts(Work-around for Erratum CPU22 enabled\n); +#endif return 0; } diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c b/arch/powerpc/cpu/mpc85xx/cpu_init.c index a90ebb1..2c3be6d 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c +++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c @@ -32,6 +32,7 @@ #include ioports.h #include sata.h #include asm/io.h +#include asm/cache.h #include asm/mmu.h #include asm/fsl_law.h #include asm/fsl_serdes.h @@ -245,6 +246,12 @@ int cpu_init_r(void) volatile fsl_lbc_t *lbc = LBC_BASE_ADDR; #endif +#if defined(CONFIG_SYS_P4080_ERRATUM_CPU22) + flush_dcache(); + mtspr(L1CSR2, (mfspr(L1CSR2) | L1CSR2_DCWS)); + sync(); +#endif + puts (L2:); #if defined(CONFIG_L2_CACHE) diff --git a/arch/powerpc/cpu/mpc85xx/release.S b/arch/powerpc/cpu/mpc85xx/release.S index 0b5b9da..53cefaf 100644 --- a/arch/powerpc/cpu/mpc85xx/release.S +++ b/arch/powerpc/cpu/mpc85xx/release.S @@ -136,6 +136,12 @@ __secondary_start_page: mtspr L1CSR2,r8 #endif +#if defined(CONFIG_SYS_P4080_ERRATUM_CPU22) + mfspr r8,L1CSR2 + orisr8,r8,(L1CSR2_DCWS)@h + mtspr L1CSR2,r8 +#endif + #ifdef CONFIG_BACKSIDE_L2_CACHE /* Enable/invalidate the L2 cache */ msync diff --git a/arch/powerpc/include/asm/processor.h b/arch/powerpc/include/asm/processor.h index 89f283a..84a1e2e 100644 --- a/arch/powerpc/include/asm/processor.h +++ b/arch/powerpc/include/asm/processor.h @@ -495,6 +495,7 @@ #define L1CSR1_ICFI 0x0002 /* Instruction Cache Flash Invalidate */ #define L1CSR1_ICE 0x0001 /* Instruction Cache Enable */ #define SPRN_L1CSR20x25e /* L1 Data Cache Control and Status Register 2 */ +#define L1CSR2_DCWS 0x4000 /* Data Cache Write Shadow */ #define SPRN_L2CSR00x3f9 /* L2 Data Cache Control and Status Register 0 */ #define L2CSR0_L2E 0x8000 /* L2 Cache Enable */ #define L2CSR0_L2PE 0x4000 /* L2 Cache Parity/ECC Enable */ -- 1.6.0.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/4] powerpc/p4080: Add workaround for errata SERDES8
Signed-off-by: Scott Wood scottw...@freescale.com
Signed-off-by: Emil Medve emilian.me...@freescale.com
Signed-off-by: Ed Swarthout ed.swarth...@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/cpu/mpc85xx/cmd_errata.c |4 +
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c | 283 +
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.h |4 +
arch/powerpc/cpu/mpc85xx/p4080_serdes.c |4 +
4 files changed, 295 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
index d7835c8..01c462c 100644
--- a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
+++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
@@ -41,6 +41,10 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc,
char * const argv[])
}
#endif
+#if defined(CONFIG_SYS_P4080_ERRATUM_SERDES8)
+ puts(Work-around for Erratum SERDES8 enabled\n);
+#endif
+
return 0;
}
diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
index 1c03061..5bcf91a 100644
--- a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
+++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
@@ -21,10 +21,14 @@
*/
#include common.h
+#ifdef CONFIG_SYS_P4080_ERRATUM_SERDES8
+#include hwconfig.h
+#endif
#include asm/fsl_serdes.h
#include asm/immap_85xx.h
#include asm/io.h
#include asm/processor.h
+#include asm/fsl_law.h
#include fsl_corenet_serdes.h
static u32 serdes_prtcl_map;
@@ -102,6 +106,13 @@ int serdes_lane_enabled(int lane)
if (in_be32(regs-bank[bank].rstctl) SRDS_RSTCTL_SDPD)
return 0;
+#ifdef CONFIG_SYS_P4080_ERRATUM_SERDES8
+ if (!IS_SVR_REV(get_svr(), 1, 0))
+ if (bank 0)
+ return !(srds_lpd_b[bank]
+ (8 (lane - (6 + 4 * bank;
+#endif
+
return !(in_be32(gur-rcwsr[word]) (0x8000 bit));
}
@@ -116,6 +127,140 @@ int is_serdes_configured(enum srds_prtcl device)
return (1 device) serdes_prtcl_map;
}
+#ifndef CONFIG_SYS_DCSRBAR_PHYS
+#define CONFIG_SYS_DCSRBAR_PHYS0x8000 /* Must be 1GB-aligned for
rev1.0 */
+#define CONFIG_SYS_DCSRBAR 0x8000
+#define __DCSR_NOT_DEFINED_BY_CONFIG
+#endif
+
+#ifdef CONFIG_SYS_P4080_ERRATUM_SERDES8
+static void enable_bank(ccsr_gur_t *gur, int bank)
+{
+ u32 rcw5;
+
+ /*
+* Enable the lanes SRDS_LPD_Bn. The RCW bits are read-only in
+* CCSR, and read/write in DSCR.
+*/
+ rcw5 = in_be32(gur-rcwsr + 5);
+ if (bank == FSL_SRDS_BANK_2) {
+ rcw5 = ~FSL_CORENET_RCWSRn_SRDS_LPD_B2;
+ rcw5 |= srds_lpd_b[bank] 26;
+ } else if (bank == FSL_SRDS_BANK_3) {
+ rcw5 = ~FSL_CORENET_RCWSRn_SRDS_LPD_B3;
+ rcw5 |= srds_lpd_b[bank] 18;
+ } else {
+ printf(SERDES: enable_bank: bad bank %d\n, bank + 1);
+ return;
+ }
+
+ /* See similar code in cpu/mpc85xx/cpu_init.c for an explanation
+* of the DCSR mapping.
+*/
+ {
+#ifdef __DCSR_NOT_DEFINED_BY_CONFIG
+ struct law_entry law = find_law(CONFIG_SYS_DCSRBAR_PHYS);
+ int law_index;
+ if (law.index == -1)
+ law_index = set_next_law(CONFIG_SYS_DCSRBAR_PHYS,
+LAW_SIZE_1M, LAW_TRGT_IF_DCSR);
+ else
+ set_law(law.index, CONFIG_SYS_DCSRBAR_PHYS, LAW_SIZE_1M,
+ LAW_TRGT_IF_DCSR);
+#endif
+ u32 *p = (void *)CONFIG_SYS_DCSRBAR + 0x20114;
+ out_be32(p, rcw5);
+#ifdef __DCSR_NOT_DEFINED_BY_CONFIG
+ if (law.index == -1)
+ disable_law(law_index);
+ else
+ set_law(law.index, law.addr, law.size, law.trgt_id);
+#endif
+ }
+}
+
+/*
+ * To avoid problems with clock jitter, rev 2 p4080 uses the pll from
+ * bank 3 to clock banks 2 and 3, as well as a limited selection of
+ * protocol configurations. This requires that banks 2 and 3's lanes be
+ * disabled in the RCW, and enabled with some fixup here to re-enable
+ * them, and to configure bank 2's clock parameters in bank 3's pll in
+ * cases where they differ.
+ */
+static void p4080_erratum_serdes8(serdes_corenet_t *regs, ccsr_gur_t *gur,
+ u32 devdisr, u32 devdisr2, int cfg)
+{
+ int srds_ratio_b2;
+ int rfck_sel;
+
+ /*
+* The disabled lanes of bank 2 will cause the associated
+* logic blocks to be disabled in DEVDISR. We reverse that here.
+*
+* Note that normally it is not permitted to clear DEVDISR bits
+* once the device has been disabled, but the hardware people
+* say that this special case is OK.
+*/
+ clrbits_be32(gur-devdisr, devdisr);
+
[U-Boot] [PATCH 1/4] powerpc/p4080: Add support for initializing SERDES
Add support for initializing the SERDES blocks on CoreNet style QoriQ
devices and the p4080 specific SERDES tables to know which actual
componetns are enabled.
Additionally, split out the Frame Manger (FMAN) into its specific ethernet
ports instead of gross level of the full FMAN.
Signed-off-by: Li Yang le...@freescale.com
Signed-off-by: Roy Zang tie-fei.z...@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/cpu/mpc85xx/Makefile |2 +
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c | 212 +
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.h | 40 +
arch/powerpc/cpu/mpc85xx/p4080_serdes.c | 94 +++
arch/powerpc/include/asm/fsl_serdes.h | 11 +-
5 files changed, 357 insertions(+), 2 deletions(-)
create mode 100644 arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
create mode 100644 arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.h
create mode 100644 arch/powerpc/cpu/mpc85xx/p4080_serdes.c
diff --git a/arch/powerpc/cpu/mpc85xx/Makefile
b/arch/powerpc/cpu/mpc85xx/Makefile
index 6ae113a..b7c0272 100644
--- a/arch/powerpc/cpu/mpc85xx/Makefile
+++ b/arch/powerpc/cpu/mpc85xx/Makefile
@@ -76,6 +76,8 @@ COBJS-$(CONFIG_PPC_P4080) += p4080_ids.o
COBJS-$(CONFIG_QE) += qe_io.o
COBJS-$(CONFIG_CPM2) += serial_scc.o
+COBJS-$(CONFIG_FSL_CORENET) += fsl_corenet_serdes.o
+COBJS-$(CONFIG_PPC_P4080) += p4080_serdes.o
COBJS = $(COBJS-y)
COBJS += cpu.o
diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
new file mode 100644
index 000..1c03061
--- /dev/null
+++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
@@ -0,0 +1,212 @@
+/*
+ * Copyright 2009-2010 Freescale Semiconductor, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include asm/fsl_serdes.h
+#include asm/immap_85xx.h
+#include asm/io.h
+#include asm/processor.h
+#include fsl_corenet_serdes.h
+
+static u32 serdes_prtcl_map;
+
+#ifdef DEBUG
+static const char *serdes_prtcl_str[] = {
+ [NONE] = NA,
+ [PCIE1] = PCIE1,
+ [PCIE2] = PCIE2,
+ [PCIE3] = PCIE3,
+ [PCIE4] = PCIE4,
+ [SATA1] = SATA1,
+ [SATA2] = SATA2,
+ [SRIO1] = SRIO1,
+ [SRIO2] = SRIO2,
+ [SGMII_FM1_DTSEC1] = SGMII_FM1_DTSEC1,
+ [SGMII_FM1_DTSEC2] = SGMII_FM1_DTSEC2,
+ [SGMII_FM1_DTSEC3] = SGMII_FM1_DTSEC3,
+ [SGMII_FM1_DTSEC4] = SGMII_FM1_DTSEC4,
+ [SGMII_FM1_DTSEC5] = SGMII_FM1_DTSEC5,
+ [SGMII_FM2_DTSEC1] = SGMII_FM2_DTSEC1,
+ [SGMII_FM2_DTSEC2] = SGMII_FM2_DTSEC2,
+ [SGMII_FM2_DTSEC3] = SGMII_FM2_DTSEC3,
+ [SGMII_FM2_DTSEC4] = SGMII_FM2_DTSEC4,
+ [XAUI_FM1] = XAUI_FM1,
+ [XAUI_FM2] = XAUI_FM2,
+ [AURORA] = DEBUG,
+};
+#endif
+
+static const struct {
+ int idx;
+ unsigned int lpd; /* RCW lane powerdown bit */
+ int bank;
+} lanes[SRDS_MAX_LANES] = {
+ { 0, 152, FSL_SRDS_BANK_1 },
+ { 1, 153, FSL_SRDS_BANK_1 },
+ { 2, 154, FSL_SRDS_BANK_1 },
+ { 3, 155, FSL_SRDS_BANK_1 },
+ { 4, 156, FSL_SRDS_BANK_1 },
+ { 5, 157, FSL_SRDS_BANK_1 },
+ { 6, 158, FSL_SRDS_BANK_1 },
+ { 7, 159, FSL_SRDS_BANK_1 },
+ { 8, 160, FSL_SRDS_BANK_1 },
+ { 9, 161, FSL_SRDS_BANK_1 },
+ { 16, 162, FSL_SRDS_BANK_2 },
+ { 17, 163, FSL_SRDS_BANK_2 },
+ { 18, 164, FSL_SRDS_BANK_2 },
+ { 19, 165, FSL_SRDS_BANK_2 },
+ { 20, 170, FSL_SRDS_BANK_3 },
+ { 21, 171, FSL_SRDS_BANK_3 },
+ { 22, 172, FSL_SRDS_BANK_3 },
+ { 23, 173, FSL_SRDS_BANK_3 },
+};
+
+int serdes_get_lane_idx(int lane)
+{
+ return lanes[lane].idx;
+}
+
+int serdes_get_bank(int lane)
+{
+ return lanes[lane].bank;
+}
+
+int serdes_lane_enabled(int lane)
+{
+ ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
+ serdes_corenet_t *regs = (void *)CONFIG_SYS_FSL_CORENET_SERDES_ADDR;
+
+ int bank = lanes[lane].bank;
+ int word = lanes[lane].lpd / 32;
+ int bit = lanes[lane].lpd % 32;
+
+ if (in_be32(regs-bank[bank].rstctl) SRDS_RSTCTL_SDPD)
+ return 0;
+
+ return !(in_be32(gur-rcwsr[word]) (0x8000 bit));
+}
+
[U-Boot] [PATCH 4/4] powerpc/p4080: Add support for the P4080DS board
Add support for the P4080DS board, with the following features: * 36-bit only * Boots from NOR flash * FMAN drivers NOT supported * SPD fixed sdram DDR Signed-off-by: Ed Swarthout ed.swarth...@freescale.com Signed-off-by: Emil Medve emilian.me...@freescale.com Signed-off-by: Becky Bruce bec...@kernel.crashing.org Signed-off-by: Ashish Kalra ashish.ka...@freescale.com Signed-off-by: Stuart Yoder stuart.yo...@freescale.com Signed-off-by: Dave Liu dave...@freescale.com Signed-off-by: Lan Chunhe-B25806 b25...@freescale.com Signed-off-by: Scott Wood scottw...@freescale.com Signed-off-by: Kim Phillips kim.phill...@freescale.com Signed-off-by: Roy Zang tie-fei.z...@freescale.com Signed-off-by: Timur Tabi ti...@freescale.com Signed-off-by: Andy Fleming aflem...@freescale.com Signed-off-by: York Sun york...@freescale.com Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- MAKEALL |1 + board/freescale/common/Makefile |1 + board/freescale/corenet_ds/Makefile | 55 +++ board/freescale/corenet_ds/config.mk| 30 ++ board/freescale/corenet_ds/corenet_ds.c | 365 + board/freescale/corenet_ds/ddr.c| 176 board/freescale/corenet_ds/law.c| 40 ++ board/freescale/corenet_ds/pci.c| 127 ++ board/freescale/corenet_ds/tlb.c| 104 + boards.cfg |1 + include/configs/P4080DS.h | 36 ++ include/configs/corenet_ds.h| 673 +++ 12 files changed, 1609 insertions(+), 0 deletions(-) create mode 100644 board/freescale/corenet_ds/Makefile create mode 100644 board/freescale/corenet_ds/config.mk create mode 100644 board/freescale/corenet_ds/corenet_ds.c create mode 100644 board/freescale/corenet_ds/ddr.c create mode 100644 board/freescale/corenet_ds/law.c create mode 100644 board/freescale/corenet_ds/pci.c create mode 100644 board/freescale/corenet_ds/tlb.c create mode 100644 include/configs/P4080DS.h create mode 100644 include/configs/corenet_ds.h diff --git a/MAKEALL b/MAKEALL index e495b93..f0da775 100755 --- a/MAKEALL +++ b/MAKEALL @@ -427,6 +427,7 @@ LIST_85xx= \ P2020RDB_NAND \ P2020RDB_SDCARD \ P2020RDB_SPIFLASH \ + P4080DS \ PM854 \ PM856 \ sbc8540 \ diff --git a/board/freescale/common/Makefile b/board/freescale/common/Makefile index 2d48d7e..f93045f 100644 --- a/board/freescale/common/Makefile +++ b/board/freescale/common/Makefile @@ -46,6 +46,7 @@ COBJS-$(CONFIG_MPC8536DS) += ics307_clk.o COBJS-$(CONFIG_MPC8572DS) += ics307_clk.o COBJS-$(CONFIG_P1022DS)+= ics307_clk.o COBJS-$(CONFIG_P2020DS)+= ics307_clk.o +COBJS-$(CONFIG_P4080DS)+= ics307_clk.o SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) OBJS := $(addprefix $(obj),$(COBJS-y)) diff --git a/board/freescale/corenet_ds/Makefile b/board/freescale/corenet_ds/Makefile new file mode 100644 index 000..8aa7255 --- /dev/null +++ b/board/freescale/corenet_ds/Makefile @@ -0,0 +1,55 @@ +# +# Copyright 2007-2009 Freescale Semiconductor, Inc. +# (C) Copyright 2001-2006 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS-y+= $(BOARD).o +COBJS-$(CONFIG_DDR_SPD)+= ddr.o +COBJS-$(CONFIG_PCI)+= pci.o +COBJS-y+= law.o +COBJS-y+= tlb.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) + +clean: + rm -f $(OBJS) $(SOBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/freescale/corenet_ds/config.mk b/board/freescale/corenet_ds/config.mk new file mode 100644 index
Re: [U-Boot] [PULL] U-Boot-pxa
Dear Paulraj, Sandeep, In message 0554bef07d437848af01b9c9b5f0bc5d9f3e6...@dlee01.ent.ti.com you wrote: Just curious to know Who will send the ARM pull request? The officiating ARM custodian,of course :-) [i. e. me] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Morality is one thing. Ratings are everything. - A Network 23 executive on Max Headroom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] [U-BOOT] Zoom3: Add support for OMAP3630 Zoom3 board.
Dear Aldo Cedillo,
In message 1279231344-16448-1-git-send-email-aldo.cedi...@ti.com you wrote:
From: Aldo Brett Cedillo Martinez aldo.cedi...@ti.com
This patch gives basic functionality to OMAP3630 Zoom3 board.
This version has been rebased againts u-boot-ti
Signed-off-by: Aldo Brett Cedillo Martinez aldo.cedi...@ti.com
---
MAINTAINERS|4 +
MAKEALL|1 +
board/logicpd/zoom3/Makefile | 54 +++
board/logicpd/zoom3/config.mk | 33 +
board/logicpd/zoom3/debug_board.c | 66 +
board/logicpd/zoom3/led.c | 133 +
board/logicpd/zoom3/zoom3.c| 201 ++
board/logicpd/zoom3/zoom3.h| 164 +
board/logicpd/zoom3/zoom3_serial.c | 132 +
board/logicpd/zoom3/zoom3_serial.h | 76 ++
boards.cfg |1 +
common/serial.c|2 +
include/configs/omap3_zoom3.h | 274
include/serial.h |7 +
14 files changed, 1148 insertions(+), 0 deletions(-)
create mode 100644 board/logicpd/zoom3/Makefile
create mode 100644 board/logicpd/zoom3/config.mk
create mode 100644 board/logicpd/zoom3/debug_board.c
create mode 100644 board/logicpd/zoom3/led.c
create mode 100644 board/logicpd/zoom3/zoom3.c
create mode 100644 board/logicpd/zoom3/zoom3.h
create mode 100644 board/logicpd/zoom3/zoom3_serial.c
create mode 100644 board/logicpd/zoom3/zoom3_serial.h
create mode 100644 include/configs/omap3_zoom3.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 1520312..260fda3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -813,6 +813,10 @@ Alex Z
lartSA1100
dnp1110 SA1110
+Aldo Brett Cedillo Martinez aldo.cedi...@ti.com
+
+ omap3_zoom3 ARM CORTEX-A8 (OMAP3xx SoC)
+
Please keep list sorted. Martinez goes between Lapin and Menon,
it seems.
+static void zoom3_debug_board_detect(void)
+{
+ int val = 0;
+
+ /*
+ * TODO gpio 158 is UART1_RX, should we make a macro of this
+ * instead of the raw number?
+ */
What a question - yes, you should!
...
+#include common.h
+#include netdev.h
+#ifdef CONFIG_STATUS_LED
+#include status_led.h
+#endif
Would it hurt to include status_led.h unconditionally?
+int misc_init_r(void)
+{
+ zoom3_identify();
+ #if (CONFIG_TWL4030_POWER)
+ twl4030_power_init();
+ twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
+ #endif
Please unindent the preprocessor statements. Check and fix globally,
please.
...
+#define CONFIG_SYS_TIMERBASE (OMAP36XX_GPT2)
+#define CONFIG_SYS_PTV 7 /* 2^(PTV+1) */
+#define CONFIG_SYS_HZ((V_SCLK) / (2
CONFIG_SYS_PTV))
NAK!!!
CONFIG_SYS_HZ is a constant and must always be 1000.
...
diff --git a/include/serial.h b/include/serial.h
index 6513d8e..236e5d1 100644
--- a/include/serial.h
+++ b/include/serial.h
@@ -66,6 +66,13 @@ extern struct serial_device zoom2_serial_device2;
extern struct serial_device zoom2_serial_device3;
#endif
+#if defined(CONFIG_OMAP3_ZOOM3)
+extern struct serial_device zoom3_serial_device0;
+extern struct serial_device zoom3_serial_device1;
+extern struct serial_device zoom3_serial_device2;
+extern struct serial_device zoom3_serial_device3;
+#endif
+
extern struct serial_device serial_ffuart_device;
extern struct serial_device serial_btuart_device;
extern struct serial_device serial_stuart_device;
This is becoming a serious mess. Isn't there a way to avoid this?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
People are always a lot more complicated than you think. It's very
important to remember that. - Terry Pratchett, _Truckers_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] common: add a grepenv command
u-boot environments, esp. when boards are shared across multiple users,
can get pretty large and time consuming to visually parse.
The grepenv command this patch adds can be used in lieu of printenv
to facilitate searching. grepenv works like printenv but limits its output
only to environment strings (variable name and value pairs) that match the
user specified substring.
Signed-off-by: Kim Phillips kim.phill...@freescale.com
---
common/cmd_nvedit.c | 55 ++-
common/command.c|1 +
2 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 13325bc..c4bde27 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -4,7 +4,9 @@
*
* (C) Copyright 2001 Sysgo Real-Time Solutions, GmbH www.elinos.com
* Andreas Heppel ahep...@sysgo.de
-
+ *
+ * Copyright 2010 Freescale Semiconductor, Inc.
+ *
* See file CREDITS for list of people who contributed to this
* project.
*
@@ -139,6 +141,50 @@ static int printenv(char *name, int state)
return i;
}
+int do_grepenv (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+ char buf[CONFIG_SYS_CBSIZE], *searchstr;
+ int i = 0, j = 0, k = 0;
+ int rcode = 1;
+
+ if (argc != 2) {
+ cmd_usage(cmdtp);
+ return 1;
+ }
+
+ searchstr = argv[1];
+
+ /* find and print matching env vars */
+ do {
+ buf[j] = env_get_char(i);
+ if (buf[j] == searchstr[k]) {
+ k++;
+ if (searchstr[k] == '\0') {
+ /* match complete */
+ rcode = 0;
+ do {
+ i++; j++;
+ buf[j] = env_get_char(i);
+ } while (buf[j] != '\0');
+ puts(buf); puts(\n);
+ j = 0; k = 0;
+ } else
+ j++;
+ } else {
+ k = 0;
+ if (buf[j] == '\0') {
+ j = 0;
+ if (ctrlc())
+ return -1;
+ } else
+ j++;
+ }
+ i++;
+ } while (!(j == 0 env_get_char(i) == '\0'));
+
+ return rcode;
+}
+
int do_printenv (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
int i;
@@ -634,6 +680,13 @@ U_BOOT_CMD(
);
U_BOOT_CMD(
+ grepenv, 2, 0, do_grepenv,
+ search environment,
+ fixed-string\n
+ - list environment name and value pairs matching 'fixed-string'
+);
+
+U_BOOT_CMD(
setenv, CONFIG_SYS_MAXARGS, 0, do_setenv,
set environment variables,
name value ...\n
diff --git a/common/command.c b/common/command.c
index a1fc592..305bda0 100644
--- a/common/command.c
+++ b/common/command.c
@@ -191,6 +191,7 @@ void install_auto_complete(void)
#if defined(CONFIG_CMD_EDITENV)
install_auto_complete_handler(editenv, var_complete);
#endif
+ install_auto_complete_handler(grepenv, var_complete);
install_auto_complete_handler(printenv, var_complete);
install_auto_complete_handler(setenv, var_complete);
#if defined(CONFIG_CMD_RUN)
--
1.7.1.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/28] SPEAr : spear1300 SoC support added
On 7/16/2010 3:34 AM, Wolfgang Denk wrote:
Dear Vipin KUMAR,
Dear Wolfgang,
In message 1279084204-3263-16-git-send-email-vipin.ku...@st.com you wrote:
From: Vipin KUMAR vipin.ku...@st.com
SPEAr1300 SoC support contains basic spear1300 support along with the
usage of following drivers
Are you here adding support for a SoC or for a board??? Looks more
like board support to me...
Yes, it is a board support. I would change this comment here
...
--- a/Makefile
+++ b/Makefile
@@ -2107,6 +2107,12 @@ spear600_usbtty_config \
spear600_usbtty_nand_config : unconfig
@$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs $(@:_config=) spear
spear
+spear1300_config \
+spear1300_nand_config \
+spear1300_usbtty_config \
+spear1300_usbtty_nand_config : unconfig
+@$(MKCONFIG) -n $@ -t $(@:_config=) spear13xx_evb arm arm_cortexa8
spear1300 spear spear13xx
NAK.
Please use boards.cfg instead.
OK.
...
+int misc_init_r(void)
+{
+setenv(verify, n);
NAK.
Please don't mess with things a user might want to do differently.
You can add this as default settingin your environment, but please
allow the user to dicede otherwise.
OK. I would add this in default environments in patch-set v2
Thanks for your valuable inputs. I would incorporate these and send a patch-set
v2
Thanks and Regards
Vipin
Best regards,
Wolfgang Denk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4 v2] AM35X: Add musb support
These patches add support for musb in AM35x. Changes from v1: - Moved SCM definitions to am35x specific file am35x_def.h Patches have been created against uboot-ti/master tree (as on 9th July) but they also apply cleanly to both denx/master and uboot-usb/master as there is no interdependent changes. Remy, Any comment on this patch set ? Regards, Ajay Regards, Ajay Ajay Kumar Gupta (4): AM35x: Adding SCM general register definitions musb: MSC host support for AM35x musb: am35x: Workaround for fifo read issue AM3517EVM: musb: add usb config arch/arm/include/asm/arch-omap3/am35x_def.h | 52 + drivers/usb/musb/Makefile |1 + drivers/usb/musb/am35x.c| 150 +++ drivers/usb/musb/am35x.h| 94 + drivers/usb/musb/musb_core.c|6 + drivers/usb/musb/musb_udc.c |2 + include/configs/am3517_evm.h| 38 +++ include/usb.h |2 +- 8 files changed, 344 insertions(+), 1 deletions(-) create mode 100644 arch/arm/include/asm/arch-omap3/am35x_def.h create mode 100644 drivers/usb/musb/am35x.c create mode 100644 drivers/usb/musb/am35x.h ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
