RE: [PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible mezzanine cards

2020-04-27 Thread Ioana Ciornei 
[snip]

> > >diff --git a/arch/arm/dts/fsl-lx2160a-qds.dtsi
> > >b/arch/arm/dts/fsl-lx2160a- qds.dtsi new file mode 100644 index
> > >..129cf82a8f37
> > >--- /dev/null
> > >+++ b/arch/arm/dts/fsl-lx2160a-qds.dtsi
> > 
> >
> > Is there any particular reason of adding dpmac related changes in one
> > file in previous patch And then putting in another fie in next patch.
> > Cant we squash this change with the previous patch?
> >
> 
> Not a particular strong reason, I was just thinking that it's cleaner.
> 
> I'll squash them.
> 

On a second look, I would prefer to keep them as is because one could easily 
see what DTS changes are needed to add support for a new protocol and the 
changes in patch 3/6 are an example of that.

Ioana

> Thanks,
> Ioana
> 
> > Regards
> > Priyanka

RE: [PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible mezzanine cards

2020-04-27 Thread Ioana Ciornei 
> Subject: RE: [PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible
> mezzanine cards
> 
> >-Original Message-
> >From: U-Boot  On Behalf Of Ioana Ciornei
> >Sent: Wednesday, April 22, 2020 10:39 PM
> >To: Priyanka Jain ; u-boot@lists.denx.de
> >Cc: Alexandru Marginean ; Madalin Bucur
> >; Florin Laurentiu Chiculita
> >; Razvan Ionut Cirjan
> >; Ioana Ciornei 
> >Subject: [PATCH 3/6] arm: dts: lx2160aqds: add nodes describing
> >possible mezzanine cards
> >
> >Add device trees describing possible uses of mezzanine cards depending
> >on the SERDES protocol employed.
> >
> >Each SERDES block has a different device tree file per protocol
> >supported, where the IO SLOTs used are enabled and PHYs located on the
> >mezzanine cards are described. Also, dpmac nodes are edited and their
> >associated phy- connection-type and phy-handle are added.
> >
> >Top DTS files are also added for each combination of protocol on the 3
> >SERDES blocks.
> Please mention serdes protocols list for which you are adding the support

Sure, I'll add that in v2.

> >
> >Signed-off-by: Ioana Ciornei 
> >---
> > arch/arm/dts/Makefile|  10 +-
> > arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts |  19 +++  arch/arm/dts/fsl-
> >lx2160a-qds-19-x-x.dts  |  17 +++
> >arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts |
> >19 +++  arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts  |  17 +++
> >arch/arm/dts/fsl- lx2160a-qds-3-11-x.dts  |  19 +++
> > arch/arm/dts/fsl-lx2160a-qds-3-x-x.dts   |  17 +++
> > arch/arm/dts/fsl-lx2160a-qds-7-11-x.dts  |  19 +++
> > arch/arm/dts/fsl-lx2160a-qds-7-x-x.dts   |  17 +++
> > arch/arm/dts/fsl-lx2160a-qds-sd1-19.dtsi |  75 ++
> >arch/arm/dts/fsl- lx2160a-qds-sd1-20.dtsi |  39 +
> >arch/arm/dts/fsl-lx2160a-qds-sd1-3.dtsi
> >|  55 +++  arch/arm/dts/fsl-lx2160a-qds-sd1-7.dtsi  | 100
> >| +
> >arch/arm/dts/fsl-lx2160a-qds-sd2-11.dtsi |  76 ++
> > arch/arm/dts/fsl-lx2160a-qds.dts | 180 +--
> > arch/arm/dts/fsl-lx2160a-qds.dtsi| 169 +
> > 16 files changed, 670 insertions(+), 178 deletions(-)  create mode
> >100644 arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-3-11-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-3-x-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-7-11-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-7-x-x.dts
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-19.dtsi
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-20.dtsi
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-3.dtsi
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-7.dtsi
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd2-11.dtsi
> > create mode 100644 arch/arm/dts/fsl-lx2160a-qds.dtsi
> >
> >diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> >6d1e8668e7ee..4fe042dbd7ee 100644
> >--- a/arch/arm/dts/Makefile
> >+++ b/arch/arm/dts/Makefile
> >@@ -377,7 +377,15 @@ dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
> > fsl-ls1028a-rdb.dtb \
> > fsl-ls1028a-qds.dtb \
> > fsl-lx2160a-rdb.dtb \
> >-fsl-lx2160a-qds.dtb
> >+fsl-lx2160a-qds.dtb \
> >+fsl-lx2160a-qds-3-x-x.dtb \
> >+fsl-lx2160a-qds-3-11-x.dtb \
> >+fsl-lx2160a-qds-7-x-x.dtb \
> >+fsl-lx2160a-qds-7-11-x.dtb \
> >+fsl-lx2160a-qds-19-x-x.dtb \
> >+fsl-lx2160a-qds-19-11-x.dtb \
> >+fsl-lx2160a-qds-20-x-x.dtb \
> >+fsl-lx2160a-qds-20-11-x.dtb
> > dtb-$(CONFIG_FSL_LSCH2) += fsl-ls1043a-qds-duart.dtb \
> > fsl-ls1043a-qds-lpuart.dtb \
> > fsl-ls1043a-rdb.dtb \
> >diff --git a/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
> >b/arch/arm/dts/fsl- lx2160a-qds-19-11-x.dts new file mode 100644 index
> >..585759162f6c
> >--- /dev/null
> >+++ b/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
> >@@ -0,0 +1,19 @@
> >+// SPDX-License-Identifier: GPL-2.0+ OR X11
> >+/*
> >+ * NXP LX2160AQDS device tree source for SERDES protocol 19.11.x
> >+ *
> >+ * Copyright 2020 NXP
> >+ *
> >+ */
> >+
> >+/dts-v1/;
> >+
> >+#include "fsl-lx2160a-qds-sd1-19.dtsi"
> >+
> >+#include "fsl-lx2160a-qds-sd2-11.dtsi"
> >+

RE: [PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible mezzanine cards

2020-04-24 Thread Priyanka Jain (OSS) 
>-Original Message-
>From: U-Boot  On Behalf Of Ioana Ciornei
>Sent: Wednesday, April 22, 2020 10:39 PM
>To: Priyanka Jain ; u-boot@lists.denx.de
>Cc: Alexandru Marginean ; Madalin Bucur
>; Florin Laurentiu Chiculita
>; Razvan Ionut Cirjan
>; Ioana Ciornei 
>Subject: [PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible
>mezzanine cards
>
>Add device trees describing possible uses of mezzanine cards depending on
>the SERDES protocol employed.
>
>Each SERDES block has a different device tree file per protocol supported,
>where the IO SLOTs used are enabled and PHYs located on the mezzanine
>cards are described. Also, dpmac nodes are edited and their associated phy-
>connection-type and phy-handle are added.
>
>Top DTS files are also added for each combination of protocol on the 3
>SERDES blocks.
Please mention serdes protocols list for which you are adding the support
>
>Signed-off-by: Ioana Ciornei 
>---
> arch/arm/dts/Makefile|  10 +-
> arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts |  19 +++  arch/arm/dts/fsl-
>lx2160a-qds-19-x-x.dts  |  17 +++  arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts |
>19 +++  arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts  |  17 +++  arch/arm/dts/fsl-
>lx2160a-qds-3-11-x.dts  |  19 +++
> arch/arm/dts/fsl-lx2160a-qds-3-x-x.dts   |  17 +++
> arch/arm/dts/fsl-lx2160a-qds-7-11-x.dts  |  19 +++
> arch/arm/dts/fsl-lx2160a-qds-7-x-x.dts   |  17 +++
> arch/arm/dts/fsl-lx2160a-qds-sd1-19.dtsi |  75 ++  arch/arm/dts/fsl-
>lx2160a-qds-sd1-20.dtsi |  39 +  arch/arm/dts/fsl-lx2160a-qds-sd1-3.dtsi
>|  55 +++  arch/arm/dts/fsl-lx2160a-qds-sd1-7.dtsi  | 100 +
>arch/arm/dts/fsl-lx2160a-qds-sd2-11.dtsi |  76 ++
> arch/arm/dts/fsl-lx2160a-qds.dts | 180 +--
> arch/arm/dts/fsl-lx2160a-qds.dtsi| 169 +
> 16 files changed, 670 insertions(+), 178 deletions(-)  create mode 100644
>arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-3-11-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-3-x-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-7-11-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-7-x-x.dts
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-19.dtsi
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-20.dtsi
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-3.dtsi
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-7.dtsi
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd2-11.dtsi
> create mode 100644 arch/arm/dts/fsl-lx2160a-qds.dtsi
>
>diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
>6d1e8668e7ee..4fe042dbd7ee 100644
>--- a/arch/arm/dts/Makefile
>+++ b/arch/arm/dts/Makefile
>@@ -377,7 +377,15 @@ dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
>   fsl-ls1028a-rdb.dtb \
>   fsl-ls1028a-qds.dtb \
>   fsl-lx2160a-rdb.dtb \
>-  fsl-lx2160a-qds.dtb
>+  fsl-lx2160a-qds.dtb \
>+  fsl-lx2160a-qds-3-x-x.dtb \
>+  fsl-lx2160a-qds-3-11-x.dtb \
>+  fsl-lx2160a-qds-7-x-x.dtb \
>+  fsl-lx2160a-qds-7-11-x.dtb \
>+  fsl-lx2160a-qds-19-x-x.dtb \
>+  fsl-lx2160a-qds-19-11-x.dtb \
>+  fsl-lx2160a-qds-20-x-x.dtb \
>+  fsl-lx2160a-qds-20-11-x.dtb
> dtb-$(CONFIG_FSL_LSCH2) += fsl-ls1043a-qds-duart.dtb \
>   fsl-ls1043a-qds-lpuart.dtb \
>   fsl-ls1043a-rdb.dtb \
>diff --git a/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts b/arch/arm/dts/fsl-
>lx2160a-qds-19-11-x.dts
>new file mode 100644
>index ..585759162f6c
>--- /dev/null
>+++ b/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
>@@ -0,0 +1,19 @@
>+// SPDX-License-Identifier: GPL-2.0+ OR X11
>+/*
>+ * NXP LX2160AQDS device tree source for SERDES protocol 19.11.x
>+ *
>+ * Copyright 2020 NXP
>+ *
>+ */
>+
>+/dts-v1/;
>+
>+#include "fsl-lx2160a-qds-sd1-19.dtsi"
>+
>+#include "fsl-lx2160a-qds-sd2-11.dtsi"
>+
>+/ {
>+  model = "NXP Layerscape LX2160AQDS Board (DTS 19.11.x)";
>+  compatible = "fsl,lx2160aqds", "fsl,lx2160a";
>+
>+};
>diff --git a/arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts b/arch/arm/dts/fsl-
>lx2160a-qds-19-x-x.dts
>new file mode 100644
>index ..ebe11396a6cb
>--- /dev/null
>+++ b/arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts
>@@ -0,0 +1,17 @@
>+// SPDX-License-Identifier: GPL-2.0+ OR X11
>+/*
>+ * NXP LX2160AQDS device tree source for SERDES protocol 19.x.x
>+ *
>+ * Copyright 2020 NXP
>+ *
>+ */
>+
>+/dts-v

[PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible mezzanine cards

2020-04-22 Thread Ioana Ciornei 
Add device trees describing possible uses of mezzanine cards depending
on the SERDES protocol employed.

Each SERDES block has a different device tree file per protocol
supported, where the IO SLOTs used are enabled and PHYs located on the
mezzanine cards are described. Also, dpmac nodes are edited and their
associated phy-connection-type and phy-handle are added.

Top DTS files are also added for each combination of protocol on the 3
SERDES blocks.

Signed-off-by: Ioana Ciornei 
---
 arch/arm/dts/Makefile|  10 +-
 arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts |  19 +++
 arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts  |  17 +++
 arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts |  19 +++
 arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts  |  17 +++
 arch/arm/dts/fsl-lx2160a-qds-3-11-x.dts  |  19 +++
 arch/arm/dts/fsl-lx2160a-qds-3-x-x.dts   |  17 +++
 arch/arm/dts/fsl-lx2160a-qds-7-11-x.dts  |  19 +++
 arch/arm/dts/fsl-lx2160a-qds-7-x-x.dts   |  17 +++
 arch/arm/dts/fsl-lx2160a-qds-sd1-19.dtsi |  75 ++
 arch/arm/dts/fsl-lx2160a-qds-sd1-20.dtsi |  39 +
 arch/arm/dts/fsl-lx2160a-qds-sd1-3.dtsi  |  55 +++
 arch/arm/dts/fsl-lx2160a-qds-sd1-7.dtsi  | 100 +
 arch/arm/dts/fsl-lx2160a-qds-sd2-11.dtsi |  76 ++
 arch/arm/dts/fsl-lx2160a-qds.dts | 180 +--
 arch/arm/dts/fsl-lx2160a-qds.dtsi| 169 +
 16 files changed, 670 insertions(+), 178 deletions(-)
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-3-11-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-3-x-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-7-11-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-7-x-x.dts
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-19.dtsi
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-20.dtsi
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-3.dtsi
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd1-7.dtsi
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds-sd2-11.dtsi
 create mode 100644 arch/arm/dts/fsl-lx2160a-qds.dtsi

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 6d1e8668e7ee..4fe042dbd7ee 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -377,7 +377,15 @@ dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
fsl-ls1028a-rdb.dtb \
fsl-ls1028a-qds.dtb \
fsl-lx2160a-rdb.dtb \
-   fsl-lx2160a-qds.dtb
+   fsl-lx2160a-qds.dtb \
+   fsl-lx2160a-qds-3-x-x.dtb \
+   fsl-lx2160a-qds-3-11-x.dtb \
+   fsl-lx2160a-qds-7-x-x.dtb \
+   fsl-lx2160a-qds-7-11-x.dtb \
+   fsl-lx2160a-qds-19-x-x.dtb \
+   fsl-lx2160a-qds-19-11-x.dtb \
+   fsl-lx2160a-qds-20-x-x.dtb \
+   fsl-lx2160a-qds-20-11-x.dtb
 dtb-$(CONFIG_FSL_LSCH2) += fsl-ls1043a-qds-duart.dtb \
fsl-ls1043a-qds-lpuart.dtb \
fsl-ls1043a-rdb.dtb \
diff --git a/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts 
b/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
new file mode 100644
index ..585759162f6c
--- /dev/null
+++ b/arch/arm/dts/fsl-lx2160a-qds-19-11-x.dts
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * NXP LX2160AQDS device tree source for SERDES protocol 19.11.x
+ *
+ * Copyright 2020 NXP
+ *
+ */
+
+/dts-v1/;
+
+#include "fsl-lx2160a-qds-sd1-19.dtsi"
+
+#include "fsl-lx2160a-qds-sd2-11.dtsi"
+
+/ {
+   model = "NXP Layerscape LX2160AQDS Board (DTS 19.11.x)";
+   compatible = "fsl,lx2160aqds", "fsl,lx2160a";
+
+};
diff --git a/arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts 
b/arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts
new file mode 100644
index ..ebe11396a6cb
--- /dev/null
+++ b/arch/arm/dts/fsl-lx2160a-qds-19-x-x.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * NXP LX2160AQDS device tree source for SERDES protocol 19.x.x
+ *
+ * Copyright 2020 NXP
+ *
+ */
+
+/dts-v1/;
+
+#include "fsl-lx2160a-qds-sd1-19.dtsi"
+
+/ {
+   model = "NXP Layerscape LX2160AQDS Board (DTS 19.x.x)";
+   compatible = "fsl,lx2160aqds", "fsl,lx2160a";
+
+};
diff --git a/arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts 
b/arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts
new file mode 100644
index ..d9f091896746
--- /dev/null
+++ b/arch/arm/dts/fsl-lx2160a-qds-20-11-x.dts
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * NXP LX2160AQDS device tree source for SERDES protocol 20.11.x
+ *
+ * Copyright 2020 NXP
+ *
+ */
+
+/dts-v1/;
+
+#include "fsl-lx2160a-qds-sd1-20.dtsi"
+
+#include "fsl-lx2160a-qds-sd2-11.dtsi"
+
+/ {
+   model = "NXP Layerscape LX2160AQDS Board (DTS 20.11.x)";
+   compatible = "fsl,lx2160aqds", "fsl,lx2160a";
+
+};
diff --git a/arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts 
b/arch/arm/dts/fsl-lx2160a-qds-20-x-x.dts
new file mode 100644
index