RE: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes

2020-04-24 Thread Priyanka Jain (OSS)
>-Original Message-
>From: U-Boot  On Behalf Of Ioana Ciornei
>Sent: Wednesday, April 22, 2020 6:43 PM
>To: Priyanka Jain ; joe.hershber...@ni.com; u-
>b...@lists.denx.de
>Cc: Florin Laurentiu Chiculita 
>Subject: RE: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY
>nodes
>
>> Subject: RE: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY
>> nodes
>>
>> >-Original Message-
>> >From: Ioana Ciornei 
>> >Sent: Wednesday, March 18, 2020 8:18 PM
>> >To: Priyanka Jain ; joe.hershber...@ni.com; u-
>> >b...@lists.denx.de
>> >Cc: Florin Laurentiu Chiculita ;
>> >Ioana Ciornei 
>> >Subject: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY
>> >nodes
>> >
>> >In order to maintain compatibility with the Linux DTS, the entire
>> >fsl-mc node is added but instead of being probed by a dedicated bus
>> >driver it will be a simple-mfd.
>> >
>> >Also, annotate the external MDIO nodes and describe the PHYs (4 x
>> >AQR405 and 4 x CS4340). Also, add phy-handles for the dpmacs to their
>> >associated PHY.
>> >
>> >Signed-off-by: Ioana Ciornei 
>> >---
>> >Changes in v2:
>> > - none
>> >
>> > arch/arm/dts/fsl-ls2080a.dtsi | 75 +--
>> > arch/arm/dts/fsl-ls2088a-rdb-qspi.dts | 88
>> > +++
>> > 2 files changed, 157 insertions(+), 6 deletions(-)
>> >
>> >diff --git a/arch/arm/dts/fsl-ls2080a.dtsi
>> >b/arch/arm/dts/fsl-ls2080a.dtsi index
>> >7ff854caecd5..fb5777e268e4 100644
>> >--- a/arch/arm/dts/fsl-ls2080a.dtsi
>> >+++ b/arch/arm/dts/fsl-ls2080a.dtsi
>> >@@ -50,12 +50,6 @@
>> >interrupts = <0 32 0x1>; /* edge triggered */
>> >};
>> >
>> >-   fsl_mc: fsl-mc@80c00 {
>> >-   compatible = "fsl,qoriq-mc";
>> >-   reg = <0x0008 0x0c00 0 0x40>,/* MC portal
>> >base */
>> >- <0x 0x0834 0 0x4>; /* MC control reg */
>> >-   };
>> >-
>> >i2c0: i2c@200 {
>> >status = "disabled";
>> >compatible = "fsl,vf610-i2c";
>> >@@ -200,6 +194,75 @@
>> >status = "disabled";
>> >};
>> >
>> >+   fsl_mc: fsl-mc@80c00 {
>> >+   compatible = "fsl,qoriq-mc", "simple-mfd";
>> >+   reg = <0x0008 0x0c00 0 0x40>,/* MC portal base
>> >*/
>> >+ <0x 0x0834 0 0x4>; /* MC control reg */
>> >+   #address-cells = <3>;
>> >+   #size-cells = <1>;
>> >+
>> >+   /*
>> >+* Region type 0x0 - MC portals
>> >+* Region type 0x1 - QBMAN portals
>> >+*/
>> >+   ranges = <0x0 0x0 0x0 0x8 0x0c00 0x400
>> >+   0x1 0x0 0x0 0x8 0x1800 0x800>;
>> >+
>> >+   dpmacs {
>> >+   compatible = "simple-mfd";
>> >+   #address-cells = <1>;
>> >+   #size-cells = <0>;
>> >+
>> >+   dpmac1: dpmac@1 {
>> >+   compatible = "fsl,qoriq-mc-dpmac";
>> >+   reg = <0x1>;
>> >+   status = "disabled";
>> >+   };
>> >+
>> >+   dpmac2: dpmac@2 {
>> >+   compatible = "fsl,qoriq-mc-dpmac";
>> >+   reg = <0x2>;
>> >+   status = "disabled";
>> >+   };
>> >+
>> >+   dpmac3: dpmac@3 {
>> >+   compatible = "fsl,qoriq-mc-dpmac";
>> >+   reg = <0x3>;
>> >+   status = "disabled";
>> >+   };
>> >+
>> >+   dpmac4: dpmac@4 {
>> >+   compatible = "fsl,qoriq-mc-dpmac";
>> >+   reg = <0x4>;
>> >+   status = "disabled";
>> >+   };
>> >+
>> >+

RE: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes

2020-04-22 Thread Ioana Ciornei
> Subject: RE: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes
> 
> >-Original Message-
> >From: Ioana Ciornei 
> >Sent: Wednesday, March 18, 2020 8:18 PM
> >To: Priyanka Jain ; joe.hershber...@ni.com; u-
> >b...@lists.denx.de
> >Cc: Florin Laurentiu Chiculita ;
> >Ioana Ciornei 
> >Subject: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes
> >
> >In order to maintain compatibility with the Linux DTS, the entire
> >fsl-mc node is added but instead of being probed by a dedicated bus
> >driver it will be a simple-mfd.
> >
> >Also, annotate the external MDIO nodes and describe the PHYs (4 x
> >AQR405 and 4 x CS4340). Also, add phy-handles for the dpmacs to their
> >associated PHY.
> >
> >Signed-off-by: Ioana Ciornei 
> >---
> >Changes in v2:
> > - none
> >
> > arch/arm/dts/fsl-ls2080a.dtsi | 75 +--
> > arch/arm/dts/fsl-ls2088a-rdb-qspi.dts | 88 +++
> > 2 files changed, 157 insertions(+), 6 deletions(-)
> >
> >diff --git a/arch/arm/dts/fsl-ls2080a.dtsi
> >b/arch/arm/dts/fsl-ls2080a.dtsi index
> >7ff854caecd5..fb5777e268e4 100644
> >--- a/arch/arm/dts/fsl-ls2080a.dtsi
> >+++ b/arch/arm/dts/fsl-ls2080a.dtsi
> >@@ -50,12 +50,6 @@
> > interrupts = <0 32 0x1>; /* edge triggered */
> > };
> >
> >-fsl_mc: fsl-mc@80c00 {
> >-compatible = "fsl,qoriq-mc";
> >-reg = <0x0008 0x0c00 0 0x40>,/* MC portal
> >base */
> >-  <0x 0x0834 0 0x4>; /* MC control reg */
> >-};
> >-
> > i2c0: i2c@200 {
> > status = "disabled";
> > compatible = "fsl,vf610-i2c";
> >@@ -200,6 +194,75 @@
> > status = "disabled";
> > };
> >
> >+fsl_mc: fsl-mc@80c00 {
> >+compatible = "fsl,qoriq-mc", "simple-mfd";
> >+reg = <0x0008 0x0c00 0 0x40>,/* MC portal base
> >*/
> >+  <0x 0x0834 0 0x4>; /* MC control reg */
> >+#address-cells = <3>;
> >+#size-cells = <1>;
> >+
> >+/*
> >+ * Region type 0x0 - MC portals
> >+ * Region type 0x1 - QBMAN portals
> >+ */
> >+ranges = <0x0 0x0 0x0 0x8 0x0c00 0x400
> >+0x1 0x0 0x0 0x8 0x1800 0x800>;
> >+
> >+dpmacs {
> >+compatible = "simple-mfd";
> >+#address-cells = <1>;
> >+#size-cells = <0>;
> >+
> >+dpmac1: dpmac@1 {
> >+compatible = "fsl,qoriq-mc-dpmac";
> >+reg = <0x1>;
> >+status = "disabled";
> >+};
> >+
> >+dpmac2: dpmac@2 {
> >+compatible = "fsl,qoriq-mc-dpmac";
> >+reg = <0x2>;
> >+status = "disabled";
> >+};
> >+
> >+dpmac3: dpmac@3 {
> >+compatible = "fsl,qoriq-mc-dpmac";
> >+reg = <0x3>;
> >+status = "disabled";
> >+};
> >+
> >+dpmac4: dpmac@4 {
> >+compatible = "fsl,qoriq-mc-dpmac";
> >+reg = <0x4>;
> >+status = "disabled";
> >+};
> >+
> >+dpmac5: dpmac@5 {
> >+compatible = "fsl,qoriq-mc-dpmac";
> >+reg = <0x5>;
> >+status = "disabled";
> >+};
> >+
> >+dpmac6: dpmac@6 {
> >+compatible = "fsl,qoriq-mc-dpmac";
> >+reg = <0x6>;
> >+status = "disabled";
> >+};
> >+
> >+dpmac7: dpmac@7 {
> >+

RE: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes

2020-04-15 Thread Priyanka Jain
>-Original Message-
>From: Ioana Ciornei 
>Sent: Wednesday, March 18, 2020 8:18 PM
>To: Priyanka Jain ; joe.hershber...@ni.com; u-
>b...@lists.denx.de
>Cc: Florin Laurentiu Chiculita ; Ioana
>Ciornei 
>Subject: [PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes
>
>In order to maintain compatibility with the Linux DTS, the entire fsl-mc node 
>is
>added but instead of being probed by a dedicated bus driver it will be a
>simple-mfd.
>
>Also, annotate the external MDIO nodes and describe the PHYs (4 x AQR405
>and 4 x CS4340). Also, add phy-handles for the dpmacs to their associated
>PHY.
>
>Signed-off-by: Ioana Ciornei 
>---
>Changes in v2:
> - none
>
> arch/arm/dts/fsl-ls2080a.dtsi | 75 +--
> arch/arm/dts/fsl-ls2088a-rdb-qspi.dts | 88 +++
> 2 files changed, 157 insertions(+), 6 deletions(-)
>
>diff --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi 
>index
>7ff854caecd5..fb5777e268e4 100644
>--- a/arch/arm/dts/fsl-ls2080a.dtsi
>+++ b/arch/arm/dts/fsl-ls2080a.dtsi
>@@ -50,12 +50,6 @@
>   interrupts = <0 32 0x1>; /* edge triggered */
>   };
>
>-  fsl_mc: fsl-mc@80c00 {
>-  compatible = "fsl,qoriq-mc";
>-  reg = <0x0008 0x0c00 0 0x40>,/* MC portal
>base */
>-<0x 0x0834 0 0x4>; /* MC control reg */
>-  };
>-
>   i2c0: i2c@200 {
>   status = "disabled";
>   compatible = "fsl,vf610-i2c";
>@@ -200,6 +194,75 @@
>   status = "disabled";
>   };
>
>+  fsl_mc: fsl-mc@80c00 {
>+  compatible = "fsl,qoriq-mc", "simple-mfd";
>+  reg = <0x0008 0x0c00 0 0x40>,/* MC portal base
>*/
>+<0x 0x0834 0 0x4>; /* MC control reg */
>+  #address-cells = <3>;
>+  #size-cells = <1>;
>+
>+  /*
>+   * Region type 0x0 - MC portals
>+   * Region type 0x1 - QBMAN portals
>+   */
>+  ranges = <0x0 0x0 0x0 0x8 0x0c00 0x400
>+  0x1 0x0 0x0 0x8 0x1800 0x800>;
>+
>+  dpmacs {
>+  compatible = "simple-mfd";
>+  #address-cells = <1>;
>+  #size-cells = <0>;
>+
>+  dpmac1: dpmac@1 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x1>;
>+  status = "disabled";
>+  };
>+
>+  dpmac2: dpmac@2 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x2>;
>+  status = "disabled";
>+  };
>+
>+  dpmac3: dpmac@3 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x3>;
>+  status = "disabled";
>+  };
>+
>+  dpmac4: dpmac@4 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x4>;
>+  status = "disabled";
>+  };
>+
>+  dpmac5: dpmac@5 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x5>;
>+  status = "disabled";
>+  };
>+
>+  dpmac6: dpmac@6 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x6>;
>+  status = "disabled";
>+  };
>+
>+  dpmac7: dpmac@7 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x7>;
>+  status = "disabled";
>+  };
>+
>+  dpmac8: dpmac@8 {
>+  compatible = "fsl,qoriq-mc-dpmac";
>+  reg = <0x8>;
>+  status = "disabled";
>+  };
>+  };
>+  };

[PATCH v2 10/14] arm: dts: ls2088ardb: add DPMAC and PHY nodes

2020-03-18 Thread Ioana Ciornei
In order to maintain compatibility with the Linux DTS, the entire fsl-mc
node is added but instead of being probed by a dedicated bus driver it
will be a simple-mfd.

Also, annotate the external MDIO nodes and describe the PHYs (4 x AQR405
and 4 x CS4340). Also, add phy-handles for the dpmacs to their
associated PHY.

Signed-off-by: Ioana Ciornei 
---
Changes in v2:
 - none

 arch/arm/dts/fsl-ls2080a.dtsi | 75 +--
 arch/arm/dts/fsl-ls2088a-rdb-qspi.dts | 88 +++
 2 files changed, 157 insertions(+), 6 deletions(-)

diff --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi
index 7ff854caecd5..fb5777e268e4 100644
--- a/arch/arm/dts/fsl-ls2080a.dtsi
+++ b/arch/arm/dts/fsl-ls2080a.dtsi
@@ -50,12 +50,6 @@
interrupts = <0 32 0x1>; /* edge triggered */
};
 
-   fsl_mc: fsl-mc@80c00 {
-   compatible = "fsl,qoriq-mc";
-   reg = <0x0008 0x0c00 0 0x40>,/* MC portal base */
- <0x 0x0834 0 0x4>; /* MC control reg */
-   };
-
i2c0: i2c@200 {
status = "disabled";
compatible = "fsl,vf610-i2c";
@@ -200,6 +194,75 @@
status = "disabled";
};
 
+   fsl_mc: fsl-mc@80c00 {
+   compatible = "fsl,qoriq-mc", "simple-mfd";
+   reg = <0x0008 0x0c00 0 0x40>,/* MC portal base */
+ <0x 0x0834 0 0x4>; /* MC control reg */
+   #address-cells = <3>;
+   #size-cells = <1>;
+
+   /*
+* Region type 0x0 - MC portals
+* Region type 0x1 - QBMAN portals
+*/
+   ranges = <0x0 0x0 0x0 0x8 0x0c00 0x400
+   0x1 0x0 0x0 0x8 0x1800 0x800>;
+
+   dpmacs {
+   compatible = "simple-mfd";
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   dpmac1: dpmac@1 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x1>;
+   status = "disabled";
+   };
+
+   dpmac2: dpmac@2 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x2>;
+   status = "disabled";
+   };
+
+   dpmac3: dpmac@3 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x3>;
+   status = "disabled";
+   };
+
+   dpmac4: dpmac@4 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x4>;
+   status = "disabled";
+   };
+
+   dpmac5: dpmac@5 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x5>;
+   status = "disabled";
+   };
+
+   dpmac6: dpmac@6 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x6>;
+   status = "disabled";
+   };
+
+   dpmac7: dpmac@7 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x7>;
+   status = "disabled";
+   };
+
+   dpmac8: dpmac@8 {
+   compatible = "fsl,qoriq-mc-dpmac";
+   reg = <0x8>;
+   status = "disabled";
+   };
+   };
+   };
+
emdio1: mdio@8B96000 {
compatible = "fsl,ls-mdio";
reg = <0x0 0x8B96000 0x0 0x1000>;
diff --git a/arch/arm/dts/fsl-ls2088a-rdb-qspi.dts 
b/arch/arm/dts/fsl-ls2088a-rdb-qspi.dts
index 72b2177b70d9..16b9aeec966c 100644
--- a/arch/arm/dts/fsl-ls2088a-rdb-qspi.dts
+++ b/arch/arm/dts/fsl-ls2088a-rdb-qspi.dts
@@ -21,6 +21,94 @@
};
 };
 
+ {
+   status = "okay";
+   phy-handle = <_phy1>;
+   phy-connection-type = "xfi";
+};
+
+ {
+   status = "okay";
+   phy-handle = <_phy2>;
+   phy-connection-type = "xfi";
+};
+
+ {
+   status = "okay";
+   phy-handle = <_phy3>;
+   phy-connection-type = "xfi";
+};
+
+ {
+   status = "okay";
+   phy-handle = <_phy4>;
+   phy-connection-type = "xfi";
+};
+
+ {
+   status = "okay";
+   phy-handle = <_phy1>;
+   phy-connection-type = "xfi";
+};
+
+ {
+   status = "okay";
+   phy-handle = <_phy2>;
+   phy-connection-type = "xfi";
+};
+
+ {
+   status = "okay";
+