RE: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
> Subject: Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to
> OF_UPSTREAM
>
> On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS)
> wrote:
>
> > + {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <40>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <_lpi2c2>;
> > + pinctrl-1 = <_lpi2c2>;
> > + status = "okay";
> > +
> > + pmic@25 {
>
> > + adp5585gpio: gpio@34 {
> > + compatible = "adp5585";
> > + reg = <0x34>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
>
> Please add a comment saying these nodes are already available in 6.9-rc1.
Just gave a check on linux-next/master, the nodes are not there.
Thanks,
Peng
>
> > --- a/arch/arm/mach-imx/imx9/Kconfig
> > +++ b/arch/arm/mach-imx/imx9/Kconfig
> > @@ -31,6 +31,7 @@ choice
> > config TARGET_IMX93_11X11_EVK
> > bool "imx93_11x11_evk"
> > select IMX93
> > + imply OF_UPSTREAM
>
> Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this
> one.
>
> Please don't ignore review comments.
RE: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
> Subject: Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to > OF_UPSTREAM > > Hi Peng, > > On Wed, Mar 27, 2024 at 9:40 PM Peng Fan wrote: > > > I could help convert all imx93 boards, but I could only test nxp > > imx93 boards, not able to test others. > > Just copy the board maintainers in your patch and they could help test the > conversion to OF_UPSTREAM. ok, I need use v6.9-rc1-dts for the dts upstream. Some dts not in v6.8-dts. Thanks, Peng. > > Thanks!
Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
Hi Peng, On Wed, Mar 27, 2024 at 9:40 PM Peng Fan wrote: > I could help convert all imx93 boards, but I could only test nxp > imx93 boards, not able to test others. Just copy the board maintainers in your patch and they could help test the conversion to OF_UPSTREAM. Thanks!
RE: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
> Subject: Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to
> OF_UPSTREAM
>
> On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS)
> wrote:
>
> > + {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <40>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <_lpi2c2>;
> > + pinctrl-1 = <_lpi2c2>;
> > + status = "okay";
> > +
> > + pmic@25 {
>
> > + adp5585gpio: gpio@34 {
> > + compatible = "adp5585";
> > + reg = <0x34>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
>
> Please add a comment saying these nodes are already available in 6.9-rc1.
>
> > --- a/arch/arm/mach-imx/imx9/Kconfig
> > +++ b/arch/arm/mach-imx/imx9/Kconfig
> > @@ -31,6 +31,7 @@ choice
> > config TARGET_IMX93_11X11_EVK
> > bool "imx93_11x11_evk"
> > select IMX93
> > + imply OF_UPSTREAM
>
> Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this
> one.
I could help convert all imx93 boards, but I could only test nxp
imx93 boards, not able to test others.
Thanks,
Peng.
>
> Please don't ignore review comments.
Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS) wrote:
> + {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clock-frequency = <40>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <_lpi2c2>;
> + pinctrl-1 = <_lpi2c2>;
> + status = "okay";
> +
> + pmic@25 {
> + adp5585gpio: gpio@34 {
> + compatible = "adp5585";
> + reg = <0x34>;
> + gpio-controller;
> + #gpio-cells = <2>;
Please add a comment saying these nodes are already available in 6.9-rc1.
> --- a/arch/arm/mach-imx/imx9/Kconfig
> +++ b/arch/arm/mach-imx/imx9/Kconfig
> @@ -31,6 +31,7 @@ choice
> config TARGET_IMX93_11X11_EVK
> bool "imx93_11x11_evk"
> select IMX93
> + imply OF_UPSTREAM
Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this one.
Please don't ignore review comments.
[PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
From: Peng Fan
Convert to OF_UPSTREAM for i.MX93 11x11 EVK.
Signed-off-by: Peng Fan
---
arch/arm/dts/Makefile| 1 -
arch/arm/dts/imx93-11x11-evk-u-boot.dtsi | 118 +++
arch/arm/dts/imx93-11x11-evk.dts | 322 ---
arch/arm/dts/imx93-u-boot.dtsi | 15 ++
arch/arm/mach-imx/imx9/Kconfig | 1 +
configs/imx93_11x11_evk_defconfig| 2 +-
configs/imx93_11x11_evk_ld_defconfig | 2 +-
7 files changed, 136 insertions(+), 325 deletions(-)
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index d85a33055c9..71c2facfb5e 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1115,7 +1115,6 @@ dtb-$(CONFIG_ARCH_IMX8M) += \
imx8mq-librem5-r4.dtb
dtb-$(CONFIG_ARCH_IMX9) += \
- imx93-11x11-evk.dtb \
imx93-var-som-symphony.dtb \
imx93-phyboard-segin.dtb
diff --git a/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi
b/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi
index a99ba99bfb4..408e601bc90 100644
--- a/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi
@@ -26,6 +26,111 @@
bootph-pre-ram;
};
+ {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clock-frequency = <40>;
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <_lpi2c2>;
+ pinctrl-1 = <_lpi2c2>;
+ status = "okay";
+
+ pmic@25 {
+ compatible = "nxp,pca9451a";
+ reg = <0x25>;
+ interrupt-parent = <>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ buck1: BUCK1 {
+ regulator-name = "BUCK1";
+ regulator-min-microvolt = <65>;
+ regulator-max-microvolt = <2237500>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <3125>;
+ };
+
+ buck2: BUCK2 {
+ regulator-name = "BUCK2";
+ regulator-min-microvolt = <60>;
+ regulator-max-microvolt = <2187500>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <3125>;
+ };
+
+ buck4: BUCK4{
+ regulator-name = "BUCK4";
+ regulator-min-microvolt = <60>;
+ regulator-max-microvolt = <340>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck5: BUCK5{
+ regulator-name = "BUCK5";
+ regulator-min-microvolt = <60>;
+ regulator-max-microvolt = <340>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck6: BUCK6 {
+ regulator-name = "BUCK6";
+ regulator-min-microvolt = <60>;
+ regulator-max-microvolt = <340>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1: LDO1 {
+ regulator-name = "LDO1";
+ regulator-min-microvolt = <160>;
+ regulator-max-microvolt = <330>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo4: LDO4 {
+ regulator-name = "LDO4";
+ regulator-min-microvolt = <80>;
+ regulator-max-microvolt = <330>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo5: LDO5 {
+ regulator-name = "LDO5";
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <330>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ };
+
+ pcal6524: gpio@22 {
+ compatible = "nxp,pcal6524";
+ pinctrl-names = "default";
+ pinctrl-0 = <_pcal6524>;
+ reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
