Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On Thu, 2019-03-07 at 09:33 -0600, Dinh Nguyen wrote: > > On 3/7/19 2:24 AM, Chee, Tien Fong wrote: > > > > On Tue, 2019-03-05 at 22:52 -0600, Dinh Nguyen wrote: > > > > > > > > > On 3/5/19 10:23 AM, tien.fong.c...@intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee > > > > > > > > After some series of patches to maximise reusable of memory > > > > pool, > > > > here come > > > > to result of reasonable size required for whole SDMMC boot > > > > working > > > > on A10 > > > > SoCDK. Size required come from default max cluster(0x1) + > > > > others(0x2000) + additional memory for headroom(0x3000). > > > This commit log is really confusing. What "series of patches"? > > There are few patches for optimization the vfat needed to result > > this > > calculation. For previous records, you can check from here [v7]: > > https: > > //www.mail-archive.com/u-boot@lists.denx.de/msg314511.html. > Ok. Please state these facts in the commit log. I have no idea what > "series of patches" you were referring to. Sure. > > > > > > > > > > > I think > > > you're just needing a bigger malloc pool. Can you just say that > > > and > > > explain why you need it? > > I put this details because Marek asked this before, so i think > > others > > also intrested to know. > > > That's fine! Just that the details wasn't very clear. Okay, i will improve it. > > Dinh ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On 3/7/19 2:24 AM, Chee, Tien Fong wrote: > On Tue, 2019-03-05 at 22:52 -0600, Dinh Nguyen wrote: >> >> On 3/5/19 10:23 AM, tien.fong.c...@intel.com wrote: >>> >>> From: Tien Fong Chee >>> >>> After some series of patches to maximise reusable of memory pool, >>> here come >>> to result of reasonable size required for whole SDMMC boot working >>> on A10 >>> SoCDK. Size required come from default max cluster(0x1) + >>> others(0x2000) + additional memory for headroom(0x3000). >> This commit log is really confusing. What "series of patches"? > There are few patches for optimization the vfat needed to result this > calculation. For previous records, you can check from here [v7]: https: > //www.mail-archive.com/u-boot@lists.denx.de/msg314511.html. Ok. Please state these facts in the commit log. I have no idea what "series of patches" you were referring to. > >> I think >> you're just needing a bigger malloc pool. Can you just say that and >> explain why you need it? > I put this details because Marek asked this before, so i think others > also intrested to know. > That's fine! Just that the details wasn't very clear. Dinh ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On Thu, 2019-03-07 at 09:10 +0100, Simon Goldschmidt wrote: > On Thu, Mar 7, 2019 at 8:08 AM Chee, Tien Fong com> wrote: > > > > > > On Tue, 2019-03-05 at 21:05 +0100, Simon Goldschmidt wrote: > > > > > > Am 05.03.2019 um 17:23 schrieb tien.fong.c...@intel.com: > > > > > > > > > > > > From: Tien Fong Chee > > > > > > > > After some series of patches to maximise reusable of memory > > > > pool, > > > > here come > > > > to result of reasonable size required for whole SDMMC boot > > > > working > > > > on A10 > > > > SoCDK. Size required come from default max cluster(0x1) + > > > > others(0x2000) + additional memory for headroom(0x3000). > > > > > > > > Signed-off-by: Tien Fong Chee > > > > > > > > --- > > > > > > > > changes for v7 > > > > - Added 0x3000 for memory headroom. > > > > --- > > > > include/configs/socfpga_common.h | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/configs/socfpga_common.h > > > > b/include/configs/socfpga_common.h > > > > index 4551cb29bc..548b458e78 100644 > > > > --- a/include/configs/socfpga_common.h > > > > +++ b/include/configs/socfpga_common.h > > > > @@ -1,6 +1,6 @@ > > > > /* SPDX-License-Identifier: GPL-2.0+ */ > > > > /* > > > > - * Copyright (C) 2012 Altera Corporation > > > > + * Copyright (C) 2012-2019 Altera Corporation > > > > */ > > > > #ifndef __CONFIG_SOCFPGA_COMMON_H__ > > > > #define __CONFIG_SOCFPGA_COMMON_H__ > > > > @@ -258,7 +258,7 @@ unsigned int > > > > cm_get_qspi_controller_clk_hz(void); > > > > #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) > > > > /* SPL memory allocation configuration, this is for FAT > > > > implementation */ > > > > #ifndef CONFIG_SYS_SPL_MALLOC_START > > > > -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x0001 > > > > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00015000 > > > This will clash with my series here: > > > https://patchwork.ozlabs.org/patch/1051451/ > > > > > > Any chance you could test that on A10? I only have a cyclone 5. > > > > > I have tested the series, and checking the failure from the codes, > > SPL_SYS_MALLOC_SIMPLE and SPL_SYS_MALLOC_F_LEN are not working in > > A10, > > because FPGA loading and distro boot from FAT FS require full > > malloc > > mechanism. > OK, thanks for testing. Seems like I was missing that the difference > between > CONFIG_SYS_SPL_MALLOC_START/_SIZE and SYS_MALLOC_F_LEN is > full malloc vs. simple malloc. > > I'll work on that. Great!! Thanks a lot. TF. > > > > > > > Thanks, > > TF. > > > > > > > > > > > > > > > > > > > > > #define > > > > CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_S > > > > IZE - \ > > > > CONFIG_SYS_SPL_MALLOC_SI > > > > ZE + \ > > > > CONFIG_SYS_INIT_RAM_ADDR > > > > ) > > > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On Tue, 2019-03-05 at 22:52 -0600, Dinh Nguyen wrote: > > On 3/5/19 10:23 AM, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > After some series of patches to maximise reusable of memory pool, > > here come > > to result of reasonable size required for whole SDMMC boot working > > on A10 > > SoCDK. Size required come from default max cluster(0x1) + > > others(0x2000) + additional memory for headroom(0x3000). > This commit log is really confusing. What "series of patches"? There are few patches for optimization the vfat needed to result this calculation. For previous records, you can check from here [v7]: https: //www.mail-archive.com/u-boot@lists.denx.de/msg314511.html. > I think > you're just needing a bigger malloc pool. Can you just say that and > explain why you need it? I put this details because Marek asked this before, so i think others also intrested to know. TF. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On Thu, Mar 7, 2019 at 8:08 AM Chee, Tien Fong wrote: > > On Tue, 2019-03-05 at 21:05 +0100, Simon Goldschmidt wrote: > > Am 05.03.2019 um 17:23 schrieb tien.fong.c...@intel.com: > > > > > > From: Tien Fong Chee > > > > > > After some series of patches to maximise reusable of memory pool, > > > here come > > > to result of reasonable size required for whole SDMMC boot working > > > on A10 > > > SoCDK. Size required come from default max cluster(0x1) + > > > others(0x2000) + additional memory for headroom(0x3000). > > > > > > Signed-off-by: Tien Fong Chee > > > > > > --- > > > > > > changes for v7 > > > - Added 0x3000 for memory headroom. > > > --- > > > include/configs/socfpga_common.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/configs/socfpga_common.h > > > b/include/configs/socfpga_common.h > > > index 4551cb29bc..548b458e78 100644 > > > --- a/include/configs/socfpga_common.h > > > +++ b/include/configs/socfpga_common.h > > > @@ -1,6 +1,6 @@ > > > /* SPDX-License-Identifier: GPL-2.0+ */ > > > /* > > > - * Copyright (C) 2012 Altera Corporation > > > + * Copyright (C) 2012-2019 Altera Corporation > > >*/ > > > #ifndef __CONFIG_SOCFPGA_COMMON_H__ > > > #define __CONFIG_SOCFPGA_COMMON_H__ > > > @@ -258,7 +258,7 @@ unsigned int > > > cm_get_qspi_controller_clk_hz(void); > > > #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) > > > /* SPL memory allocation configuration, this is for FAT > > > implementation */ > > > #ifndef CONFIG_SYS_SPL_MALLOC_START > > > -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x0001 > > > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00015000 > > This will clash with my series here: > > https://patchwork.ozlabs.org/patch/1051451/ > > > > Any chance you could test that on A10? I only have a cyclone 5. > > > I have tested the series, and checking the failure from the codes, > SPL_SYS_MALLOC_SIMPLE and SPL_SYS_MALLOC_F_LEN are not working in A10, > because FPGA loading and distro boot from FAT FS require full malloc > mechanism. OK, thanks for testing. Seems like I was missing that the difference between CONFIG_SYS_SPL_MALLOC_START/_SIZE and SYS_MALLOC_F_LEN is full malloc vs. simple malloc. I'll work on that. Regards, Simon > > Thanks, > TF. > > > > > > > > > > #define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_S > > > IZE - \ > > > CONFIG_SYS_SPL_MALLOC_SI > > > ZE + \ > > > CONFIG_SYS_INIT_RAM_ADDR > > > ) > > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On Tue, 2019-03-05 at 21:05 +0100, Simon Goldschmidt wrote: > Am 05.03.2019 um 17:23 schrieb tien.fong.c...@intel.com: > > > > From: Tien Fong Chee > > > > After some series of patches to maximise reusable of memory pool, > > here come > > to result of reasonable size required for whole SDMMC boot working > > on A10 > > SoCDK. Size required come from default max cluster(0x1) + > > others(0x2000) + additional memory for headroom(0x3000). > > > > Signed-off-by: Tien Fong Chee > > > > --- > > > > changes for v7 > > - Added 0x3000 for memory headroom. > > --- > > include/configs/socfpga_common.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/configs/socfpga_common.h > > b/include/configs/socfpga_common.h > > index 4551cb29bc..548b458e78 100644 > > --- a/include/configs/socfpga_common.h > > +++ b/include/configs/socfpga_common.h > > @@ -1,6 +1,6 @@ > > /* SPDX-License-Identifier: GPL-2.0+ */ > > /* > > - * Copyright (C) 2012 Altera Corporation > > + * Copyright (C) 2012-2019 Altera Corporation > > */ > > #ifndef __CONFIG_SOCFPGA_COMMON_H__ > > #define __CONFIG_SOCFPGA_COMMON_H__ > > @@ -258,7 +258,7 @@ unsigned int > > cm_get_qspi_controller_clk_hz(void); > > #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) > > /* SPL memory allocation configuration, this is for FAT > > implementation */ > > #ifndef CONFIG_SYS_SPL_MALLOC_START > > -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x0001 > > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00015000 > This will clash with my series here: > https://patchwork.ozlabs.org/patch/1051451/ > > Any chance you could test that on A10? I only have a cyclone 5. > I have tested the series, and checking the failure from the codes, SPL_SYS_MALLOC_SIMPLE and SPL_SYS_MALLOC_F_LEN are not working in A10, because FPGA loading and distro boot from FAT FS require full malloc mechanism. Thanks, TF. > > > > > > #define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_S > > IZE - \ > > CONFIG_SYS_SPL_MALLOC_SI > > ZE + \ > > CONFIG_SYS_INIT_RAM_ADDR > > ) > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On 3/5/19 10:23 AM, tien.fong.c...@intel.com wrote: > From: Tien Fong Chee > > After some series of patches to maximise reusable of memory pool, here come > to result of reasonable size required for whole SDMMC boot working on A10 > SoCDK. Size required come from default max cluster(0x1) + > others(0x2000) + additional memory for headroom(0x3000). This commit log is really confusing. What "series of patches"? I think you're just needing a bigger malloc pool. Can you just say that and explain why you need it? Thanks, Dinh ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
On Tue, 2019-03-05 at 21:05 +0100, Simon Goldschmidt wrote: > Am 05.03.2019 um 17:23 schrieb tien.fong.c...@intel.com: > > > > From: Tien Fong Chee > > > > After some series of patches to maximise reusable of memory pool, > > here come > > to result of reasonable size required for whole SDMMC boot working > > on A10 > > SoCDK. Size required come from default max cluster(0x1) + > > others(0x2000) + additional memory for headroom(0x3000). > > > > Signed-off-by: Tien Fong Chee > > > > --- > > > > changes for v7 > > - Added 0x3000 for memory headroom. > > --- > > include/configs/socfpga_common.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/configs/socfpga_common.h > > b/include/configs/socfpga_common.h > > index 4551cb29bc..548b458e78 100644 > > --- a/include/configs/socfpga_common.h > > +++ b/include/configs/socfpga_common.h > > @@ -1,6 +1,6 @@ > > /* SPDX-License-Identifier: GPL-2.0+ */ > > /* > > - * Copyright (C) 2012 Altera Corporation > > + * Copyright (C) 2012-2019 Altera Corporation > > */ > > #ifndef __CONFIG_SOCFPGA_COMMON_H__ > > #define __CONFIG_SOCFPGA_COMMON_H__ > > @@ -258,7 +258,7 @@ unsigned int > > cm_get_qspi_controller_clk_hz(void); > > #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) > > /* SPL memory allocation configuration, this is for FAT > > implementation */ > > #ifndef CONFIG_SYS_SPL_MALLOC_START > > -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x0001 > > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00015000 > This will clash with my series here: > https://patchwork.ozlabs.org/patch/1051451/ > > Any chance you could test that on A10? I only have a cyclone 5. Okay, let me trying to test your series. > Thanks, TF > > > > > > #define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_S > > IZE - \ > > CONFIG_SYS_SPL_MALLOC_SI > > ZE + \ > > CONFIG_SYS_INIT_RAM_ADDR > > ) > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
Am 05.03.2019 um 17:23 schrieb tien.fong.c...@intel.com: From: Tien Fong Chee After some series of patches to maximise reusable of memory pool, here come to result of reasonable size required for whole SDMMC boot working on A10 SoCDK. Size required come from default max cluster(0x1) + others(0x2000) + additional memory for headroom(0x3000). Signed-off-by: Tien Fong Chee --- changes for v7 - Added 0x3000 for memory headroom. --- include/configs/socfpga_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 4551cb29bc..548b458e78 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* - * Copyright (C) 2012 Altera Corporation + * Copyright (C) 2012-2019 Altera Corporation */ #ifndef __CONFIG_SOCFPGA_COMMON_H__ #define __CONFIG_SOCFPGA_COMMON_H__ @@ -258,7 +258,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void); #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) /* SPL memory allocation configuration, this is for FAT implementation */ #ifndef CONFIG_SYS_SPL_MALLOC_START -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x0001 +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00015000 This will clash with my series here: https://patchwork.ozlabs.org/patch/1051451/ Any chance you could test that on A10? I only have a cyclone 5. Regards, Simon #define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_SYS_SPL_MALLOC_SIZE + \ CONFIG_SYS_INIT_RAM_ADDR) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
From: Tien Fong Chee After some series of patches to maximise reusable of memory pool, here come to result of reasonable size required for whole SDMMC boot working on A10 SoCDK. Size required come from default max cluster(0x1) + others(0x2000) + additional memory for headroom(0x3000). Signed-off-by: Tien Fong Chee --- changes for v7 - Added 0x3000 for memory headroom. --- include/configs/socfpga_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 4551cb29bc..548b458e78 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* - * Copyright (C) 2012 Altera Corporation + * Copyright (C) 2012-2019 Altera Corporation */ #ifndef __CONFIG_SOCFPGA_COMMON_H__ #define __CONFIG_SOCFPGA_COMMON_H__ @@ -258,7 +258,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void); #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) /* SPL memory allocation configuration, this is for FAT implementation */ #ifndef CONFIG_SYS_SPL_MALLOC_START -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x0001 +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00015000 #define CONFIG_SYS_SPL_MALLOC_START(CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_SYS_SPL_MALLOC_SIZE + \ CONFIG_SYS_INIT_RAM_ADDR) -- 2.13.0 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
