subject:"\[U\-Boot\] \[PATCH v2 00\/18\] spi\: mpc8xxx\: DM conversion"

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-09-04 Thread Mario Six

Hi Jagan, Heiko,

On Tue, Sep 4, 2018 at 8:10 AM Jagan Teki  wrote:
>
> Hi Mario/Kim/Heiko,
>
> On Tue, Aug 21, 2018 at 8:42 PM, Christophe LEROY
>  wrote:
> > Hi Mario,
> >
> >
> > Le 10/08/2018 à 09:57, Mario Six a écrit :
> >>
> >> Hi Christophe,
> >>
> >> On Fri, Aug 10, 2018 at 9:35 AM Christophe LEROY
> >>  wrote:
> >>>
> >>>
> >>> Hello Mario,
> >>>
> >>> Le 26/04/2018 à 10:36, Mario Six a écrit :
> 
>  Hi Joakim,
> 
>  On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
>   wrote:
> >
> > On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
> >>
> >> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six 
> >> wrote:
> >>>
> >>> Hi Jagan,
> >>>
> >>> On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki
> >>>  wrote:
> 
>  On Thu, Apr 19, 2018 at 6:06 PM, Mario Six 
>  wrote:
> >
> > This is v2 of a patch series that adds support for DM to the
> > MPC8XXX SPI
> > driver, cleans up the driver code, fixes a few minor problems.
> >
> > Some TODOs are left over for later, such as proper SPI speed
> > setting,
> > and support for SPI mode setting. These would be enhancements to
> > the
> > original functionality, and can come later.
> >
> > The legacy functionality is removed in this version, so old boards
> > in
> > the tree might end up with broken SPI functionality.
> >
> > Mario Six (18):
> > spi: mpc8xxx: Use short type names
> > spi: mpc8xxx: Fix comments
> > spi: mpc8xxx: Rename camel-case variables
> > spi: mpc8xxx: Fix space after cast
> > spi: mpc8xxx: Fix function names in strings
> > spi: mpc8xxx: Replace defines with enums
> > spi: mpc8xxx: Use IO accessors
> > spi: mpc8xxx: Simplify if
> > spi: mpc8xxx: Get rid of is_read
> > spi: mpc8xxx: Simplify logic a bit
> > spi: mpc8xxx: Reduce scope of loop variables
> > spi: mpc8xxx: Make code more readable
> > spi: mpc8xxx: Rename variable
> > spi: mpc8xxx: Document LEN setting better
> > spi: mpc8xxx: Re-order transfer setup
> > spi: mpc8xxx: Fix if check
> > spi: mpc8xxx: Use get_timer
> > spi: mpc8xxx: Convert to DM
> 
> 
>  Boards with
>  - configs/MPC8349EMDS_defconfig
>  - configs/ids8313_defconfig
>
> Can you convert this boards to use DM_SPI, we have build issue[2]
>

Heiko, if you agree, I'd say we disable the SPI support for this board for now
(and possibly permanently), since really supporting the SPI multiplexer would
entail writing a DM driver for it, which would entail creating a SPI mux
uclass, and similar inconveniences (and I think putting that much work in a
board that old is at least dubious). As far as I can tell, this is the only
board with the multiplexer mechanism.

I have two more larger conversion series in my queue, which will hopefully make
it easier to convert the MPC83xx boards to DM (including SPI), but since I'm
busy working on non-U-Boot-related things right now, I won't be able to
finalize the first this week; hopefully next week.

>
> [2] https://travis-ci.org/openedev/u-boot-amarula/jobs/412956049
>

Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-09-04 Thread Jagan Teki

Hi Mario/Kim/Heiko,

On Tue, Aug 21, 2018 at 8:42 PM, Christophe LEROY
 wrote:
> Hi Mario,
>
>
> Le 10/08/2018 à 09:57, Mario Six a écrit :
>>
>> Hi Christophe,
>>
>> On Fri, Aug 10, 2018 at 9:35 AM Christophe LEROY
>>  wrote:
>>>
>>>
>>> Hello Mario,
>>>
>>> Le 26/04/2018 à 10:36, Mario Six a écrit :

 Hi Joakim,

 On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
  wrote:
>
> On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
>>
>> CAUTION: This email originated from outside of the organization. Do
>> not click links or open attachments unless you recognize the sender and 
>> know
>> the content is safe.
>>
>>
>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six 
>> wrote:
>>>
>>> Hi Jagan,
>>>
>>> On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki
>>>  wrote:

 On Thu, Apr 19, 2018 at 6:06 PM, Mario Six 
 wrote:
>
> This is v2 of a patch series that adds support for DM to the
> MPC8XXX SPI
> driver, cleans up the driver code, fixes a few minor problems.
>
> Some TODOs are left over for later, such as proper SPI speed
> setting,
> and support for SPI mode setting. These would be enhancements to
> the
> original functionality, and can come later.
>
> The legacy functionality is removed in this version, so old boards
> in
> the tree might end up with broken SPI functionality.
>
> Mario Six (18):
> spi: mpc8xxx: Use short type names
> spi: mpc8xxx: Fix comments
> spi: mpc8xxx: Rename camel-case variables
> spi: mpc8xxx: Fix space after cast
> spi: mpc8xxx: Fix function names in strings
> spi: mpc8xxx: Replace defines with enums
> spi: mpc8xxx: Use IO accessors
> spi: mpc8xxx: Simplify if
> spi: mpc8xxx: Get rid of is_read
> spi: mpc8xxx: Simplify logic a bit
> spi: mpc8xxx: Reduce scope of loop variables
> spi: mpc8xxx: Make code more readable
> spi: mpc8xxx: Rename variable
> spi: mpc8xxx: Document LEN setting better
> spi: mpc8xxx: Re-order transfer setup
> spi: mpc8xxx: Fix if check
> spi: mpc8xxx: Use get_timer
> spi: mpc8xxx: Convert to DM


 Boards with
 - configs/MPC8349EMDS_defconfig
 - configs/ids8313_defconfig

Can you convert this boards to use DM_SPI, we have build issue[2]


[2] https://travis-ci.org/openedev/u-boot-amarula/jobs/412956049
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-08-21 Thread Christophe LEROY


Hi Mario,

Le 10/08/2018 à 09:57, Mario Six a écrit :

Hi Christophe,

On Fri, Aug 10, 2018 at 9:35 AM Christophe LEROY
 wrote:


Hello Mario,

Le 26/04/2018 à 10:36, Mario Six a écrit :

Hi Joakim,

On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
 wrote:

On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:

CAUTION: This email originated from outside of the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe.


On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:

Hi Jagan,

On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  wrote:

On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:

This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
driver, cleans up the driver code, fixes a few minor problems.

Some TODOs are left over for later, such as proper SPI speed setting,
and support for SPI mode setting. These would be enhancements to the
original functionality, and can come later.

The legacy functionality is removed in this version, so old boards in
the tree might end up with broken SPI functionality.

Mario Six (18):
spi: mpc8xxx: Use short type names
spi: mpc8xxx: Fix comments
spi: mpc8xxx: Rename camel-case variables
spi: mpc8xxx: Fix space after cast
spi: mpc8xxx: Fix function names in strings
spi: mpc8xxx: Replace defines with enums
spi: mpc8xxx: Use IO accessors
spi: mpc8xxx: Simplify if
spi: mpc8xxx: Get rid of is_read
spi: mpc8xxx: Simplify logic a bit
spi: mpc8xxx: Reduce scope of loop variables
spi: mpc8xxx: Make code more readable
spi: mpc8xxx: Rename variable
spi: mpc8xxx: Document LEN setting better
spi: mpc8xxx: Re-order transfer setup
spi: mpc8xxx: Fix if check
spi: mpc8xxx: Use get_timer
spi: mpc8xxx: Convert to DM


Boards with
- configs/MPC8349EMDS_defconfig
- configs/ids8313_defconfig

are using this driver, so Kim, Heiko please convert enable DM_SPI for the same.

Use below tree for respective changes and update on top of this.
http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next



I have a few series in the making that will enable DM on the MPC83xx platform
(I'm doing a respin on the first right now). If there is still interests in the
boards, I could push it to the MPC83xx repository (but mind that the work
required per board is quite extensive).

Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
hardware, so I can't really maintain it.


It's up to you, look like this board maintained by Kim is not
available with freescale e-mail (or may be changed) if none can't
maintain, it better to drop the board.


we use custom 832x boards so please don't remove 83xx from u-boot.



I'm not planning to do that; on the contrary: I'm trying to update the platform
to fully support DM (I hope to get a fully converted board in after the next
release).

The problem is that we only use MPC8308 SoCs, so I can only vouche for the
correctness of that specific SoC. Everything else is a bit up in the air, since
I'm changing code blindly pretty much.


I have a MPC8321 board so I may test it on it if it helps.



That would be very much appreciated! Thanks.


Indeed, your driver implements SPI in CPU Mode AFAIU

In the MPC8321 Reference Manual this state that 'SPI in CPU Mode applies 
to MPC8360E and MPC8568E only'.


And as the driver doesn't implement QUICC Engine Mode, I won't use it 
for the 8xx yet. I'll port the mpc8xx driver to DM and see later if we 
can implement QE Mode in mpc8xxx and merge it with the mpc8xx once we 
have generic GPIOs on the 8xx.


Christophe




In the meantime, I was thinking about using your converted driver and
see if I can adapt it to support MPC8xx as well, instead of converting
the mpc8xx_spi driver to DM, however I've not been able to find your
patches in the master tree allthough they are flagged as accepted in
patchwork.

Are they on another branch somewhere ?


Hmm, indeed. I thought they would be in the SPI custodian repository, but
apparently they are not?

@Jagan: Were those patches forgotten somehow?


Thanks
Christophe


Best regards,
Mario


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-08-10 Thread Jagan Teki

On Fri, Aug 10, 2018 at 1:27 PM, Mario Six  wrote:
> Hi Christophe,
>
> On Fri, Aug 10, 2018 at 9:35 AM Christophe LEROY
>  wrote:
>>
>> Hello Mario,
>>
>> Le 26/04/2018 à 10:36, Mario Six a écrit :
>> > Hi Joakim,
>> >
>> > On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
>> >  wrote:
>> >> On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
>> >>> CAUTION: This email originated from outside of the organization. Do not 
>> >>> click links or open attachments unless you recognize the sender and know 
>> >>> the content is safe.
>> >>>
>> >>>
>> >>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:
>>  Hi Jagan,
>> 
>>  On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  
>>  wrote:
>> > On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
>> >> This is v2 of a patch series that adds support for DM to the MPC8XXX 
>> >> SPI
>> >> driver, cleans up the driver code, fixes a few minor problems.
>> >>
>> >> Some TODOs are left over for later, such as proper SPI speed setting,
>> >> and support for SPI mode setting. These would be enhancements to the
>> >> original functionality, and can come later.
>> >>
>> >> The legacy functionality is removed in this version, so old boards in
>> >> the tree might end up with broken SPI functionality.
>> >>
>> >> Mario Six (18):
>> >>spi: mpc8xxx: Use short type names
>> >>spi: mpc8xxx: Fix comments
>> >>spi: mpc8xxx: Rename camel-case variables
>> >>spi: mpc8xxx: Fix space after cast
>> >>spi: mpc8xxx: Fix function names in strings
>> >>spi: mpc8xxx: Replace defines with enums
>> >>spi: mpc8xxx: Use IO accessors
>> >>spi: mpc8xxx: Simplify if
>> >>spi: mpc8xxx: Get rid of is_read
>> >>spi: mpc8xxx: Simplify logic a bit
>> >>spi: mpc8xxx: Reduce scope of loop variables
>> >>spi: mpc8xxx: Make code more readable
>> >>spi: mpc8xxx: Rename variable
>> >>spi: mpc8xxx: Document LEN setting better
>> >>spi: mpc8xxx: Re-order transfer setup
>> >>spi: mpc8xxx: Fix if check
>> >>spi: mpc8xxx: Use get_timer
>> >>spi: mpc8xxx: Convert to DM
>> >
>> > Boards with
>> > - configs/MPC8349EMDS_defconfig
>> > - configs/ids8313_defconfig
>> >
>> > are using this driver, so Kim, Heiko please convert enable DM_SPI for 
>> > the same.
>> >
>> > Use below tree for respective changes and update on top of this.
>> > http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
>> >
>> 
>>  I have a few series in the making that will enable DM on the MPC83xx 
>>  platform
>>  (I'm doing a respin on the first right now). If there is still 
>>  interests in the
>>  boards, I could push it to the MPC83xx repository (but mind that the 
>>  work
>>  required per board is quite extensive).
>> 
>>  Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
>>  hardware, so I can't really maintain it.
>> >>>
>> >>> It's up to you, look like this board maintained by Kim is not
>> >>> available with freescale e-mail (or may be changed) if none can't
>> >>> maintain, it better to drop the board.
>> >>
>> >> we use custom 832x boards so please don't remove 83xx from u-boot.
>> >>
>> >
>> > I'm not planning to do that; on the contrary: I'm trying to update the 
>> > platform
>> > to fully support DM (I hope to get a fully converted board in after the 
>> > next
>> > release).
>> >
>> > The problem is that we only use MPC8308 SoCs, so I can only vouche for the
>> > correctness of that specific SoC. Everything else is a bit up in the air, 
>> > since
>> > I'm changing code blindly pretty much.
>>
>> I have a MPC8321 board so I may test it on it if it helps.
>>
>
> That would be very much appreciated! Thanks.
>
>> In the meantime, I was thinking about using your converted driver and
>> see if I can adapt it to support MPC8xx as well, instead of converting
>> the mpc8xx_spi driver to DM, however I've not been able to find your
>> patches in the master tree allthough they are flagged as accepted in
>> patchwork.
>>
>> Are they on another branch somewhere ?
>>
> Hmm, indeed. I thought they would be in the SPI custodian repository, but
> apparently they are not?
>
> @Jagan: Were those patches forgotten somehow?

http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/spi-dm-migrate

If all the boards which are using this driver enabled DM_SPI, then I
will pick the same.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-08-10 Thread Mario Six

Hi Christophe,

On Fri, Aug 10, 2018 at 9:35 AM Christophe LEROY
 wrote:
>
> Hello Mario,
>
> Le 26/04/2018 à 10:36, Mario Six a écrit :
> > Hi Joakim,
> >
> > On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
> >  wrote:
> >> On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
> >>> CAUTION: This email originated from outside of the organization. Do not 
> >>> click links or open attachments unless you recognize the sender and know 
> >>> the content is safe.
> >>>
> >>>
> >>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:
>  Hi Jagan,
> 
>  On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  
>  wrote:
> > On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
> >> This is v2 of a patch series that adds support for DM to the MPC8XXX 
> >> SPI
> >> driver, cleans up the driver code, fixes a few minor problems.
> >>
> >> Some TODOs are left over for later, such as proper SPI speed setting,
> >> and support for SPI mode setting. These would be enhancements to the
> >> original functionality, and can come later.
> >>
> >> The legacy functionality is removed in this version, so old boards in
> >> the tree might end up with broken SPI functionality.
> >>
> >> Mario Six (18):
> >>spi: mpc8xxx: Use short type names
> >>spi: mpc8xxx: Fix comments
> >>spi: mpc8xxx: Rename camel-case variables
> >>spi: mpc8xxx: Fix space after cast
> >>spi: mpc8xxx: Fix function names in strings
> >>spi: mpc8xxx: Replace defines with enums
> >>spi: mpc8xxx: Use IO accessors
> >>spi: mpc8xxx: Simplify if
> >>spi: mpc8xxx: Get rid of is_read
> >>spi: mpc8xxx: Simplify logic a bit
> >>spi: mpc8xxx: Reduce scope of loop variables
> >>spi: mpc8xxx: Make code more readable
> >>spi: mpc8xxx: Rename variable
> >>spi: mpc8xxx: Document LEN setting better
> >>spi: mpc8xxx: Re-order transfer setup
> >>spi: mpc8xxx: Fix if check
> >>spi: mpc8xxx: Use get_timer
> >>spi: mpc8xxx: Convert to DM
> >
> > Boards with
> > - configs/MPC8349EMDS_defconfig
> > - configs/ids8313_defconfig
> >
> > are using this driver, so Kim, Heiko please convert enable DM_SPI for 
> > the same.
> >
> > Use below tree for respective changes and update on top of this.
> > http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
> >
> 
>  I have a few series in the making that will enable DM on the MPC83xx 
>  platform
>  (I'm doing a respin on the first right now). If there is still interests 
>  in the
>  boards, I could push it to the MPC83xx repository (but mind that the work
>  required per board is quite extensive).
> 
>  Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
>  hardware, so I can't really maintain it.
> >>>
> >>> It's up to you, look like this board maintained by Kim is not
> >>> available with freescale e-mail (or may be changed) if none can't
> >>> maintain, it better to drop the board.
> >>
> >> we use custom 832x boards so please don't remove 83xx from u-boot.
> >>
> >
> > I'm not planning to do that; on the contrary: I'm trying to update the 
> > platform
> > to fully support DM (I hope to get a fully converted board in after the next
> > release).
> >
> > The problem is that we only use MPC8308 SoCs, so I can only vouche for the
> > correctness of that specific SoC. Everything else is a bit up in the air, 
> > since
> > I'm changing code blindly pretty much.
>
> I have a MPC8321 board so I may test it on it if it helps.
>

That would be very much appreciated! Thanks.

> In the meantime, I was thinking about using your converted driver and
> see if I can adapt it to support MPC8xx as well, instead of converting
> the mpc8xx_spi driver to DM, however I've not been able to find your
> patches in the master tree allthough they are flagged as accepted in
> patchwork.
>
> Are they on another branch somewhere ?
>
Hmm, indeed. I thought they would be in the SPI custodian repository, but
apparently they are not?

@Jagan: Were those patches forgotten somehow?

> Thanks
> Christophe
>
Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-08-10 Thread Christophe LEROY


Hello Mario,

Le 26/04/2018 à 10:36, Mario Six a écrit :

Hi Joakim,

On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
 wrote:

On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:

CAUTION: This email originated from outside of the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe.


On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:

Hi Jagan,

On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  wrote:

On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:

This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
driver, cleans up the driver code, fixes a few minor problems.

Some TODOs are left over for later, such as proper SPI speed setting,
and support for SPI mode setting. These would be enhancements to the
original functionality, and can come later.

The legacy functionality is removed in this version, so old boards in
the tree might end up with broken SPI functionality.

Mario Six (18):
   spi: mpc8xxx: Use short type names
   spi: mpc8xxx: Fix comments
   spi: mpc8xxx: Rename camel-case variables
   spi: mpc8xxx: Fix space after cast
   spi: mpc8xxx: Fix function names in strings
   spi: mpc8xxx: Replace defines with enums
   spi: mpc8xxx: Use IO accessors
   spi: mpc8xxx: Simplify if
   spi: mpc8xxx: Get rid of is_read
   spi: mpc8xxx: Simplify logic a bit
   spi: mpc8xxx: Reduce scope of loop variables
   spi: mpc8xxx: Make code more readable
   spi: mpc8xxx: Rename variable
   spi: mpc8xxx: Document LEN setting better
   spi: mpc8xxx: Re-order transfer setup
   spi: mpc8xxx: Fix if check
   spi: mpc8xxx: Use get_timer
   spi: mpc8xxx: Convert to DM


Boards with
- configs/MPC8349EMDS_defconfig
- configs/ids8313_defconfig

are using this driver, so Kim, Heiko please convert enable DM_SPI for the same.

Use below tree for respective changes and update on top of this.
http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next



I have a few series in the making that will enable DM on the MPC83xx platform
(I'm doing a respin on the first right now). If there is still interests in the
boards, I could push it to the MPC83xx repository (but mind that the work
required per board is quite extensive).

Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
hardware, so I can't really maintain it.


It's up to you, look like this board maintained by Kim is not
available with freescale e-mail (or may be changed) if none can't
maintain, it better to drop the board.


we use custom 832x boards so please don't remove 83xx from u-boot.



I'm not planning to do that; on the contrary: I'm trying to update the platform
to fully support DM (I hope to get a fully converted board in after the next
release).

The problem is that we only use MPC8308 SoCs, so I can only vouche for the
correctness of that specific SoC. Everything else is a bit up in the air, since
I'm changing code blindly pretty much.


I have a MPC8321 board so I may test it on it if it helps.

In the meantime, I was thinking about using your converted driver and 
see if I can adapt it to support MPC8xx as well, instead of converting 
the mpc8xx_spi driver to DM, however I've not been able to find your 
patches in the master tree allthough they are flagged as accepted in 
patchwork.


Are they on another branch somewhere ?

Thanks
Christophe



Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-04-26 Thread Mario Six

Hi Joakim,

On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
 wrote:
> On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
>> CAUTION: This email originated from outside of the organization. Do not 
>> click links or open attachments unless you recognize the sender and know the 
>> content is safe.
>>
>>
>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:
>> > Hi Jagan,
>> >
>> > On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  
>> > wrote:
>> > > On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
>> > > > This is v2 of a patch series that adds support for DM to the MPC8XXX 
>> > > > SPI
>> > > > driver, cleans up the driver code, fixes a few minor problems.
>> > > >
>> > > > Some TODOs are left over for later, such as proper SPI speed setting,
>> > > > and support for SPI mode setting. These would be enhancements to the
>> > > > original functionality, and can come later.
>> > > >
>> > > > The legacy functionality is removed in this version, so old boards in
>> > > > the tree might end up with broken SPI functionality.
>> > > >
>> > > > Mario Six (18):
>> > > >   spi: mpc8xxx: Use short type names
>> > > >   spi: mpc8xxx: Fix comments
>> > > >   spi: mpc8xxx: Rename camel-case variables
>> > > >   spi: mpc8xxx: Fix space after cast
>> > > >   spi: mpc8xxx: Fix function names in strings
>> > > >   spi: mpc8xxx: Replace defines with enums
>> > > >   spi: mpc8xxx: Use IO accessors
>> > > >   spi: mpc8xxx: Simplify if
>> > > >   spi: mpc8xxx: Get rid of is_read
>> > > >   spi: mpc8xxx: Simplify logic a bit
>> > > >   spi: mpc8xxx: Reduce scope of loop variables
>> > > >   spi: mpc8xxx: Make code more readable
>> > > >   spi: mpc8xxx: Rename variable
>> > > >   spi: mpc8xxx: Document LEN setting better
>> > > >   spi: mpc8xxx: Re-order transfer setup
>> > > >   spi: mpc8xxx: Fix if check
>> > > >   spi: mpc8xxx: Use get_timer
>> > > >   spi: mpc8xxx: Convert to DM
>> > >
>> > > Boards with
>> > > - configs/MPC8349EMDS_defconfig
>> > > - configs/ids8313_defconfig
>> > >
>> > > are using this driver, so Kim, Heiko please convert enable DM_SPI for 
>> > > the same.
>> > >
>> > > Use below tree for respective changes and update on top of this.
>> > > http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
>> > >
>> >
>> > I have a few series in the making that will enable DM on the MPC83xx 
>> > platform
>> > (I'm doing a respin on the first right now). If there is still interests 
>> > in the
>> > boards, I could push it to the MPC83xx repository (but mind that the work
>> > required per board is quite extensive).
>> >
>> > Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
>> > hardware, so I can't really maintain it.
>>
>> It's up to you, look like this board maintained by Kim is not
>> available with freescale e-mail (or may be changed) if none can't
>> maintain, it better to drop the board.
>
> we use custom 832x boards so please don't remove 83xx from u-boot.
>

I'm not planning to do that; on the contrary: I'm trying to update the platform
to fully support DM (I hope to get a fully converted board in after the next
release).

The problem is that we only use MPC8308 SoCs, so I can only vouche for the
correctness of that specific SoC. Everything else is a bit up in the air, since
I'm changing code blindly pretty much.

Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-04-26 Thread Joakim Tjernlund

On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
> CAUTION: This email originated from outside of the organization. Do not click 
> links or open attachments unless you recognize the sender and know the 
> content is safe.
> 
> 
> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:
> > Hi Jagan,
> > 
> > On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  
> > wrote:
> > > On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
> > > > This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
> > > > driver, cleans up the driver code, fixes a few minor problems.
> > > > 
> > > > Some TODOs are left over for later, such as proper SPI speed setting,
> > > > and support for SPI mode setting. These would be enhancements to the
> > > > original functionality, and can come later.
> > > > 
> > > > The legacy functionality is removed in this version, so old boards in
> > > > the tree might end up with broken SPI functionality.
> > > > 
> > > > Mario Six (18):
> > > >   spi: mpc8xxx: Use short type names
> > > >   spi: mpc8xxx: Fix comments
> > > >   spi: mpc8xxx: Rename camel-case variables
> > > >   spi: mpc8xxx: Fix space after cast
> > > >   spi: mpc8xxx: Fix function names in strings
> > > >   spi: mpc8xxx: Replace defines with enums
> > > >   spi: mpc8xxx: Use IO accessors
> > > >   spi: mpc8xxx: Simplify if
> > > >   spi: mpc8xxx: Get rid of is_read
> > > >   spi: mpc8xxx: Simplify logic a bit
> > > >   spi: mpc8xxx: Reduce scope of loop variables
> > > >   spi: mpc8xxx: Make code more readable
> > > >   spi: mpc8xxx: Rename variable
> > > >   spi: mpc8xxx: Document LEN setting better
> > > >   spi: mpc8xxx: Re-order transfer setup
> > > >   spi: mpc8xxx: Fix if check
> > > >   spi: mpc8xxx: Use get_timer
> > > >   spi: mpc8xxx: Convert to DM
> > > 
> > > Boards with
> > > - configs/MPC8349EMDS_defconfig
> > > - configs/ids8313_defconfig
> > > 
> > > are using this driver, so Kim, Heiko please convert enable DM_SPI for the 
> > > same.
> > > 
> > > Use below tree for respective changes and update on top of this.
> > > http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
> > > 
> > 
> > I have a few series in the making that will enable DM on the MPC83xx 
> > platform
> > (I'm doing a respin on the first right now). If there is still interests in 
> > the
> > boards, I could push it to the MPC83xx repository (but mind that the work
> > required per board is quite extensive).
> > 
> > Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
> > hardware, so I can't really maintain it.
> 
> It's up to you, look like this board maintained by Kim is not
> available with freescale e-mail (or may be changed) if none can't
> maintain, it better to drop the board.

we use custom 832x boards so please don't remove 83xx from u-boot.

 Jocke
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-04-26 Thread Jagan Teki

On Thu, Apr 26, 2018 at 11:24 AM, Mario Six  wrote:
> Hi Jagan,
>
> On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  wrote:
>> On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
>>> This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
>>> driver, cleans up the driver code, fixes a few minor problems.
>>>
>>> Some TODOs are left over for later, such as proper SPI speed setting,
>>> and support for SPI mode setting. These would be enhancements to the
>>> original functionality, and can come later.
>>>
>>> The legacy functionality is removed in this version, so old boards in
>>> the tree might end up with broken SPI functionality.
>>>
>>> Mario Six (18):
>>>   spi: mpc8xxx: Use short type names
>>>   spi: mpc8xxx: Fix comments
>>>   spi: mpc8xxx: Rename camel-case variables
>>>   spi: mpc8xxx: Fix space after cast
>>>   spi: mpc8xxx: Fix function names in strings
>>>   spi: mpc8xxx: Replace defines with enums
>>>   spi: mpc8xxx: Use IO accessors
>>>   spi: mpc8xxx: Simplify if
>>>   spi: mpc8xxx: Get rid of is_read
>>>   spi: mpc8xxx: Simplify logic a bit
>>>   spi: mpc8xxx: Reduce scope of loop variables
>>>   spi: mpc8xxx: Make code more readable
>>>   spi: mpc8xxx: Rename variable
>>>   spi: mpc8xxx: Document LEN setting better
>>>   spi: mpc8xxx: Re-order transfer setup
>>>   spi: mpc8xxx: Fix if check
>>>   spi: mpc8xxx: Use get_timer
>>>   spi: mpc8xxx: Convert to DM
>>
>> Boards with
>> - configs/MPC8349EMDS_defconfig
>> - configs/ids8313_defconfig
>>
>> are using this driver, so Kim, Heiko please convert enable DM_SPI for the 
>> same.
>>
>> Use below tree for respective changes and update on top of this.
>> http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
>>
>
> I have a few series in the making that will enable DM on the MPC83xx platform
> (I'm doing a respin on the first right now). If there is still interests in 
> the
> boards, I could push it to the MPC83xx repository (but mind that the work
> required per board is quite extensive).
>
> Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
> hardware, so I can't really maintain it.

It's up to you, look like this board maintained by Kim is not
available with freescale e-mail (or may be changed) if none can't
maintain, it better to drop the board.

Jagan.

-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-04-25 Thread Mario Six

Hi Jagan,

On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki  wrote:
> On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
>> This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
>> driver, cleans up the driver code, fixes a few minor problems.
>>
>> Some TODOs are left over for later, such as proper SPI speed setting,
>> and support for SPI mode setting. These would be enhancements to the
>> original functionality, and can come later.
>>
>> The legacy functionality is removed in this version, so old boards in
>> the tree might end up with broken SPI functionality.
>>
>> Mario Six (18):
>>   spi: mpc8xxx: Use short type names
>>   spi: mpc8xxx: Fix comments
>>   spi: mpc8xxx: Rename camel-case variables
>>   spi: mpc8xxx: Fix space after cast
>>   spi: mpc8xxx: Fix function names in strings
>>   spi: mpc8xxx: Replace defines with enums
>>   spi: mpc8xxx: Use IO accessors
>>   spi: mpc8xxx: Simplify if
>>   spi: mpc8xxx: Get rid of is_read
>>   spi: mpc8xxx: Simplify logic a bit
>>   spi: mpc8xxx: Reduce scope of loop variables
>>   spi: mpc8xxx: Make code more readable
>>   spi: mpc8xxx: Rename variable
>>   spi: mpc8xxx: Document LEN setting better
>>   spi: mpc8xxx: Re-order transfer setup
>>   spi: mpc8xxx: Fix if check
>>   spi: mpc8xxx: Use get_timer
>>   spi: mpc8xxx: Convert to DM
>
> Boards with
> - configs/MPC8349EMDS_defconfig
> - configs/ids8313_defconfig
>
> are using this driver, so Kim, Heiko please convert enable DM_SPI for the 
> same.
>
> Use below tree for respective changes and update on top of this.
> http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
>

I have a few series in the making that will enable DM on the MPC83xx platform
(I'm doing a respin on the first right now). If there is still interests in the
boards, I could push it to the MPC83xx repository (but mind that the work
required per board is quite extensive).

Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
hardware, so I can't really maintain it.

> Jagan.
>

Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-04-25 Thread Jagan Teki

On Thu, Apr 19, 2018 at 6:06 PM, Mario Six  wrote:
> This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
> driver, cleans up the driver code, fixes a few minor problems.
>
> Some TODOs are left over for later, such as proper SPI speed setting,
> and support for SPI mode setting. These would be enhancements to the
> original functionality, and can come later.
>
> The legacy functionality is removed in this version, so old boards in
> the tree might end up with broken SPI functionality.
>
> Mario Six (18):
>   spi: mpc8xxx: Use short type names
>   spi: mpc8xxx: Fix comments
>   spi: mpc8xxx: Rename camel-case variables
>   spi: mpc8xxx: Fix space after cast
>   spi: mpc8xxx: Fix function names in strings
>   spi: mpc8xxx: Replace defines with enums
>   spi: mpc8xxx: Use IO accessors
>   spi: mpc8xxx: Simplify if
>   spi: mpc8xxx: Get rid of is_read
>   spi: mpc8xxx: Simplify logic a bit
>   spi: mpc8xxx: Reduce scope of loop variables
>   spi: mpc8xxx: Make code more readable
>   spi: mpc8xxx: Rename variable
>   spi: mpc8xxx: Document LEN setting better
>   spi: mpc8xxx: Re-order transfer setup
>   spi: mpc8xxx: Fix if check
>   spi: mpc8xxx: Use get_timer
>   spi: mpc8xxx: Convert to DM

Boards with
- configs/MPC8349EMDS_defconfig
- configs/ids8313_defconfig

are using this driver, so Kim, Heiko please convert enable DM_SPI for the same.

Use below tree for respective changes and update on top of this.
http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next

Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

2018-04-19 Thread Mario Six

This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
driver, cleans up the driver code, fixes a few minor problems.

Some TODOs are left over for later, such as proper SPI speed setting,
and support for SPI mode setting. These would be enhancements to the
original functionality, and can come later.

The legacy functionality is removed in this version, so old boards in
the tree might end up with broken SPI functionality.

Mario Six (18):
  spi: mpc8xxx: Use short type names
  spi: mpc8xxx: Fix comments
  spi: mpc8xxx: Rename camel-case variables
  spi: mpc8xxx: Fix space after cast
  spi: mpc8xxx: Fix function names in strings
  spi: mpc8xxx: Replace defines with enums
  spi: mpc8xxx: Use IO accessors
  spi: mpc8xxx: Simplify if
  spi: mpc8xxx: Get rid of is_read
  spi: mpc8xxx: Simplify logic a bit
  spi: mpc8xxx: Reduce scope of loop variables
  spi: mpc8xxx: Make code more readable
  spi: mpc8xxx: Rename variable
  spi: mpc8xxx: Document LEN setting better
  spi: mpc8xxx: Re-order transfer setup
  spi: mpc8xxx: Fix if check
  spi: mpc8xxx: Use get_timer
  spi: mpc8xxx: Convert to DM

 drivers/spi/mpc8xxx_spi.c | 279 +++---
 1 file changed, 188 insertions(+), 91 deletions(-)

--
2.16.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Re: [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

[U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

12 matches

Site Navigation

Mail list logo

Footer information