Re: [U-Boot] [PATCH v2 2/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

[Sandy Patterson]

On Sun, Aug 28, 2016 at 10:01 PM, Ziyuan Xu  wrote:

> Hi,
>
>
> On 2016年08月28日 03:39, Sandy Patterson wrote:
>
>> Rock2 has been tested with back to brom feature. The tricky part is that
>> with this feature the default environment is inside u-boot, and it's
>> defined for every rk3288 board independetly. So I just changed it for
>> rock2 here.
>>
>> Solve by moving environment after u-boot before 1M boundary
>>
>> Signed-off-by: Sandy Patterson 
>> ---
>>
>
> According to your change, I think your commit message is not match.
> Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board???


Oops. It looks like my change to the rock2_defconfig ended up in the other
patch. I'll resubmit with the defconfig in this patch.

>
>
>
>> Changes in v2: None
>>
>>   include/configs/rock2.h | 8 
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/configs/rock2.h b/include/configs/rock2.h
>> index ee924c3..946367f 100644
>> --- a/include/configs/rock2.h
>> +++ b/include/configs/rock2.h
>> @@ -16,11 +16,11 @@
>> #define CONFIG_ENV_IS_IN_MMC
>>   #define CONFIG_SYS_MMC_ENV_DEV 0
>> -/* SPL @ 32k for ~36k
>> - * ENV @ 96k
>> - * u-boot @ 128K
>> +/* SPL @ 32k for 34k
>> + * u-boot directly after @ 68k for 400k or so
>> + * ENV @ 992k
>>*/
>> -#define CONFIG_ENV_OFFSET (96 * 1024)
>> +#define CONFIG_ENV_OFFSET ((1024-32) * 1024)
>> #define CONFIG_SYS_WHITE_ON_BLACK
>>   #define CONFIG_CONSOLE_SCROLL_LINES   10
>>
>
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

[Ziyuan Xu]

Hi,


On 2016年08月28日 03:39, Sandy Patterson wrote:

Rock2 has been tested with back to brom feature. The tricky part is that
with this feature the default environment is inside u-boot, and it's
defined for every rk3288 board independetly. So I just changed it for
rock2 here.

Solve by moving environment after u-boot before 1M boundary

Signed-off-by: Sandy Patterson 
---


According to your change, I think your commit message is not match.
Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board???



Changes in v2: None

  include/configs/rock2.h | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/configs/rock2.h b/include/configs/rock2.h
index ee924c3..946367f 100644
--- a/include/configs/rock2.h
+++ b/include/configs/rock2.h
@@ -16,11 +16,11 @@
  
  #define CONFIG_ENV_IS_IN_MMC

  #define CONFIG_SYS_MMC_ENV_DEV 0
-/* SPL @ 32k for ~36k
- * ENV @ 96k
- * u-boot @ 128K
+/* SPL @ 32k for 34k
+ * u-boot directly after @ 68k for 400k or so
+ * ENV @ 992k
   */
-#define CONFIG_ENV_OFFSET (96 * 1024)
+#define CONFIG_ENV_OFFSET ((1024-32) * 1024)
  
  #define CONFIG_SYS_WHITE_ON_BLACK

  #define CONFIG_CONSOLE_SCROLL_LINES   10



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 2/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

[Sandy Patterson]

Rock2 has been tested with back to brom feature. The tricky part is that
with this feature the default environment is inside u-boot, and it's
defined for every rk3288 board independetly. So I just changed it for
rock2 here.

Solve by moving environment after u-boot before 1M boundary

Signed-off-by: Sandy Patterson 
---

Changes in v2: None

 include/configs/rock2.h | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/configs/rock2.h b/include/configs/rock2.h
index ee924c3..946367f 100644
--- a/include/configs/rock2.h
+++ b/include/configs/rock2.h
@@ -16,11 +16,11 @@
 
 #define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV 0
-/* SPL @ 32k for ~36k
- * ENV @ 96k
- * u-boot @ 128K
+/* SPL @ 32k for 34k
+ * u-boot directly after @ 68k for 400k or so
+ * ENV @ 992k
  */
-#define CONFIG_ENV_OFFSET (96 * 1024)
+#define CONFIG_ENV_OFFSET ((1024-32) * 1024)
 
 #define CONFIG_SYS_WHITE_ON_BLACK
 #define CONFIG_CONSOLE_SCROLL_LINES10
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot