Re: [U-Boot] [Patch v3] Consolidate bool type

[Allen Martin]

On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
 On 01/23/2013 02:02 PM, Scott Wood wrote:
  On 01/23/2013 04:01:49 PM, York Sun wrote:
  On 01/23/2013 01:52 PM, Scott Wood wrote:
   On 01/23/2013 03:46:04 PM, York Sun wrote:
   On 01/23/2013 01:41 PM, York Sun wrote:
   I should put RFC in the subject as I am not able to compile all ARCH
   myself.
  
   So how do you see this patch becoming non-RFC?  I think most people
   don't have every single toolchain.  You should at least get a toolchain
   for a couple major architectures such as ARM.  Usually RFC is for when
   you know the patch has issues, and don't want it applied yet even if
   nobody else finds fault with it.
  
 
  I know this version has problem. I am hoping more people get involved
  and test what they can. I tried the arm toolchain you pointed to me. I
  couldn't run MAKEALL for arm.
  
  Even before your patch, using USE_PRIVATE_LIBGCC?  How many boards failed?
  
 I don't know. Wolfgang brought it. Allen kindly offered help to verify
 on tegra which uses USE_PRIVATE_LIBGCC.
 

Built and tested on tegra, no problems.  I'm still seeing a lot of
references to  TRUE/FALSE even after this patch though:

$ git grep -e FALSE -e TRUE | awk 'BEGIN {FS = :} {print $1}' | sort | uniq
arch/arm/cpu/arm926ejs/spear/spear600.c
arch/arm/cpu/arm926ejs/spear/spl_boot.c
arch/m68k/lib/interrupts.c
arch/nds32/lib/interrupts.c
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c
arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c
arch/powerpc/cpu/ppc4xx/denali_spd_ddr2.c
Binary file tools/easylogo/linux_logo.tga matches
board/amcc/bamboo/bamboo.c
board/amcc/yucca/yucca.h
board/bf533-ezkit/flash.c
board/bf537-stamp/ide-cf.c
board/esd/common/lcd.c
board/esd/dasa_sim/cmd_dasa_sim.c
board/esd/pmc440/fpga.c
board/evb64260/eth_addrtbl.c
board/gen860t/fpga.c
board/matrix_vision/mvblx/mvblx.c
board/mousse/flash.c
board/mpl/common/isa.c
board/mpl/mip405/mip405.c
board/mpl/pip405/pip405.c
board/sacsng/clkinit.c
board/spear/x600/fpga.c
board/teejet/mt_ventoux/mt_ventoux.c
board/xilinx/common/xbasic_types.c
board/xilinx/common/xdma_channel.c
board/xilinx/common/xdma_channel_sg.c
board/xilinx/common/xipif_v1_23_b.h
board/xilinx/common/xpacket_fifo_v1_00_b.h
board/xilinx/common/xversion.c
common/bedbug.c
common/cmd_bedbug.c
common/cmd_fdc.c
common/cmd_scsi.c
drivers/bios_emulator/x86emu/debug.c
drivers/block/ahci.c
drivers/block/sata_dwc.c
drivers/block/sym53c8xx.c
drivers/dma/MCD_dmaApi.c
drivers/fpga/ACEX1K.c
drivers/fpga/altera.c
drivers/fpga/cyclon2.c
drivers/fpga/lattice.c
drivers/fpga/spartan2.c
drivers/fpga/spartan3.c
drivers/fpga/virtex2.c
drivers/fpga/xilinx.c
drivers/net/armada100_fec.c
drivers/net/e1000.c
drivers/net/e1000.h
drivers/net/e1000_spi.c
drivers/net/npe/include/IxAtmdAccCtrl.h
drivers/net/npe/include/IxEthAcc_p.h
drivers/net/npe/include/IxEthDB.h
drivers/net/npe/include/IxEthDB_p.h
drivers/net/npe/include/IxEthMii.h
drivers/net/npe/include/IxFeatureCtrl.h
drivers/net/npe/include/IxHssAcc.h
drivers/net/npe/include/IxNpeDl.h
drivers/net/npe/include/IxNpeDlNpeMgr_p.h
drivers/net/npe/include/IxNpeDlNpeMgrUtils_p.h
drivers/net/npe/include/IxNpeMhConfig_p.h
drivers/net/npe/include/IxOsal.h
drivers/net/npe/include/IxOsalTypes.h
drivers/net/npe/include/IxPerfProfAcc.h
drivers/net/npe/include/IxQMgrAqmIf_p.h
drivers/net/npe/include/IxTimeSyncAcc.h
drivers/net/npe/IxEthAcc.c
drivers/net/npe/IxEthAccCommon.c
drivers/net/npe/IxEthAccDataPlane.c
drivers/net/npe/IxEthAccMac.c
drivers/net/npe/IxEthDBAPI.c
drivers/net/npe/IxEthDBAPISupport.c
drivers/net/npe/IxEthDBCore.c
drivers/net/npe/IxEthDBEvents.c
drivers/net/npe/IxEthDBFeatures.c
drivers/net/npe/IxEthDBFirewall.c
drivers/net/npe/IxEthDBLearning.c
drivers/net/npe/IxEthDBNPEAdaptor.c
drivers/net/npe/IxEthDBPortUpdate.c
drivers/net/npe/IxEthDBReports.c
drivers/net/npe/IxEthDBSearch.c
drivers/net/npe/IxEthDBSpanningTree.c
drivers/net/npe/IxEthDBUtil.c
drivers/net/npe/IxEthDBVlan.c
drivers/net/npe/IxEthMii.c
drivers/net/npe/IxFeatureCtrl.c
drivers/net/npe/IxNpeDl.c
drivers/net/npe/IxNpeDlImageMgr.c
drivers/net/npe/IxNpeDlNpeMgr.c
drivers/net/npe/IxNpeMh.c
drivers/net/npe/IxNpeMhConfig.c
drivers/net/npe/IxNpeMhSend.c
drivers/net/npe/IxOsalOsSemaphore.c
drivers/net/npe/IxQMgrDispatcher.c
drivers/net/npe/IxQMgrInit.c
drivers/net/npe/IxQMgrQCfg.c
drivers/net/npe/npe.c
drivers/rtc/ds1374.c
drivers/serial/usbtty.c
drivers/video/da8xx-fb.c
drivers/video/mxc_ipuv3_fb.c
fs/ext4/ext4_journal.c
include/configs/bf537-stamp.h
include/dp83848.h
include/linux/fb.h
include/linux/mtd/nand.h
include/linux/types.h
include/MCD_dma.h
include/pcmcia/ti113x.h
include/radeon.h
include/sym53c8xx.h
include/usb_cdc_acm.h
include/usbdevice.h
README
tools/bddb/defs.php


-Allen
-- 
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/24/2013 09:34 AM, Allen Martin wrote:
 On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
 On 01/23/2013 02:02 PM, Scott Wood wrote:
 On 01/23/2013 04:01:49 PM, York Sun wrote:
 On 01/23/2013 01:52 PM, Scott Wood wrote:
 On 01/23/2013 03:46:04 PM, York Sun wrote:
 On 01/23/2013 01:41 PM, York Sun wrote:
 I should put RFC in the subject as I am not able to compile all ARCH
 myself.

 So how do you see this patch becoming non-RFC?  I think most people
 don't have every single toolchain.  You should at least get a toolchain
 for a couple major architectures such as ARM.  Usually RFC is for when
 you know the patch has issues, and don't want it applied yet even if
 nobody else finds fault with it.


 I know this version has problem. I am hoping more people get involved
 and test what they can. I tried the arm toolchain you pointed to me. I
 couldn't run MAKEALL for arm.

 Even before your patch, using USE_PRIVATE_LIBGCC?  How many boards failed?

 I don't know. Wolfgang brought it. Allen kindly offered help to verify
 on tegra which uses USE_PRIVATE_LIBGCC.

 
 Built and tested on tegra, no problems.  I'm still seeing a lot of
 references to  TRUE/FALSE even after this patch though:
 
 $ git grep -e FALSE -e TRUE | awk 'BEGIN {FS = :} {print $1}' | sort | uniq
 
Thanks, Allen. A long way to go.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/24/2013 09:54 AM, York Sun wrote:
 On 01/24/2013 09:34 AM, Allen Martin wrote:
 On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
 On 01/23/2013 02:02 PM, Scott Wood wrote:
 On 01/23/2013 04:01:49 PM, York Sun wrote:
 On 01/23/2013 01:52 PM, Scott Wood wrote:
 On 01/23/2013 03:46:04 PM, York Sun wrote:
 On 01/23/2013 01:41 PM, York Sun wrote:
 I should put RFC in the subject as I am not able to compile all ARCH
 myself.

 So how do you see this patch becoming non-RFC?  I think most people
 don't have every single toolchain.  You should at least get a toolchain
 for a couple major architectures such as ARM.  Usually RFC is for when
 you know the patch has issues, and don't want it applied yet even if
 nobody else finds fault with it.


 I know this version has problem. I am hoping more people get involved
 and test what they can. I tried the arm toolchain you pointed to me. I
 couldn't run MAKEALL for arm.

 Even before your patch, using USE_PRIVATE_LIBGCC?  How many boards failed?

 I don't know. Wolfgang brought it. Allen kindly offered help to verify
 on tegra which uses USE_PRIVATE_LIBGCC.


 Built and tested on tegra, no problems.  I'm still seeing a lot of
 references to  TRUE/FALSE even after this patch though:

 $ git grep -e FALSE -e TRUE | awk 'BEGIN {FS = :} {print $1}' | sort | uniq

 Thanks, Allen. A long way to go.
 

I thought I have replaced all #define, enum, typedef. I have left alone
those FALSE, False, false but add define like this

+#include stdbool.h
+#define TRUE true
+#define FALSE false
+#define True true
+#define False false

Isn't that enough?

I did miss the #if TRUE != 1 part, as pointed out by Scott. Will fix in
next rev.

York


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Scott Wood]

On 01/24/2013 12:03:49 PM, York Sun wrote:

On 01/24/2013 09:54 AM, York Sun wrote:
 On 01/24/2013 09:34 AM, Allen Martin wrote:
 On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
 On 01/23/2013 02:02 PM, Scott Wood wrote:
 On 01/23/2013 04:01:49 PM, York Sun wrote:
 On 01/23/2013 01:52 PM, Scott Wood wrote:
 On 01/23/2013 03:46:04 PM, York Sun wrote:
 On 01/23/2013 01:41 PM, York Sun wrote:
 I should put RFC in the subject as I am not able to compile  
all ARCH

 myself.

 So how do you see this patch becoming non-RFC?  I think most  
people
 don't have every single toolchain.  You should at least get a  
toolchain
 for a couple major architectures such as ARM.  Usually RFC is  
for when
 you know the patch has issues, and don't want it applied yet  
even if

 nobody else finds fault with it.


 I know this version has problem. I am hoping more people get  
involved
 and test what they can. I tried the arm toolchain you pointed  
to me. I

 couldn't run MAKEALL for arm.

 Even before your patch, using USE_PRIVATE_LIBGCC?  How many  
boards failed?


 I don't know. Wolfgang brought it. Allen kindly offered help to  
verify

 on tegra which uses USE_PRIVATE_LIBGCC.


 Built and tested on tegra, no problems.  I'm still seeing a lot of
 references to  TRUE/FALSE even after this patch though:

 $ git grep -e FALSE -e TRUE | awk 'BEGIN {FS = :} {print $1}' |  
sort | uniq


 Thanks, Allen. A long way to go.


I thought I have replaced all #define, enum, typedef. I have left  
alone

those FALSE, False, false but add define like this

+#include stdbool.h
+#define TRUE true
+#define FALSE false
+#define True true
+#define False false

Isn't that enough?


It's enough to make it build, but it would be better to fix the users.

-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/24/2013 10:14 AM, Scott Wood wrote:
 

 I thought I have replaced all #define, enum, typedef. I have left alone
 those FALSE, False, false but add define like this

 +#include stdbool.h
 +#define TRUE true
 +#define FALSE false
 +#define True true
 +#define False false

 Isn't that enough?
 
 It's enough to make it build, but it would be better to fix the users.
 

Let me try to run a script to replace all of them to false and true.

York


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Allen Martin]

On Thu, Jan 24, 2013 at 10:14:37AM -0800, Scott Wood wrote:
 On 01/24/2013 12:03:49 PM, York Sun wrote:
  On 01/24/2013 09:54 AM, York Sun wrote:
   On 01/24/2013 09:34 AM, Allen Martin wrote:
   On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
   On 01/23/2013 02:02 PM, Scott Wood wrote:
   On 01/23/2013 04:01:49 PM, York Sun wrote:
   On 01/23/2013 01:52 PM, Scott Wood wrote:
   On 01/23/2013 03:46:04 PM, York Sun wrote:
   On 01/23/2013 01:41 PM, York Sun wrote:
   I should put RFC in the subject as I am not able to compile  
  all ARCH
   myself.
  
   So how do you see this patch becoming non-RFC?  I think most  
  people
   don't have every single toolchain.  You should at least get a  
  toolchain
   for a couple major architectures such as ARM.  Usually RFC is  
  for when
   you know the patch has issues, and don't want it applied yet  
  even if
   nobody else finds fault with it.
  
  
   I know this version has problem. I am hoping more people get  
  involved
   and test what they can. I tried the arm toolchain you pointed  
  to me. I
   couldn't run MAKEALL for arm.
  
   Even before your patch, using USE_PRIVATE_LIBGCC?  How many  
  boards failed?
  
   I don't know. Wolfgang brought it. Allen kindly offered help to  
  verify
   on tegra which uses USE_PRIVATE_LIBGCC.
  
  
   Built and tested on tegra, no problems.  I'm still seeing a lot of
   references to  TRUE/FALSE even after this patch though:
  
   $ git grep -e FALSE -e TRUE | awk 'BEGIN {FS = :} {print $1}' |  
  sort | uniq
  
   Thanks, Allen. A long way to go.
  
  
  I thought I have replaced all #define, enum, typedef. I have left  
  alone
  those FALSE, False, false but add define like this
  
  +#include stdbool.h
  +#define TRUE true
  +#define FALSE false
  +#define True true
  +#define False false
  
  Isn't that enough?
 
 It's enough to make it build, but it would be better to fix the users.
 

For code consistency I think it would be better to force everything to
use the lower case true/false.  Otherwise this patch does nothing to
force new code to use the standardized version.

There may be some exception we want to make for unmodified 3rd party
libraries that are checked in, like lib/bzlib which uses True/False,
otherwise it makes it hard to take new code drops of those things.

-Allen
-- 
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Wolfgang Denk]

Dear York Sun,

In message 51017785.9060...@freescale.com you wrote:

 I thought I have replaced all #define, enum, typedef. I have left alone
 those FALSE, False, false but add define like this
 
 +#include stdbool.h
 +#define TRUE true
 +#define FALSE false
 +#define True true
 +#define False false

Arghh..

 Isn't that enough?

Please remove all such occurrences.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
1 1 was a race-horse, 2 2 was 1 2. When 1 1 1 1 race, 2 2 1 1 2.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Allen Martin]

On Thu, Jan 24, 2013 at 10:23:21AM -0800, York Sun wrote:
 On 01/24/2013 10:14 AM, Scott Wood wrote:
  
 
  I thought I have replaced all #define, enum, typedef. I have left alone
  those FALSE, False, false but add define like this
 
  +#include stdbool.h
  +#define TRUE true
  +#define FALSE false
  +#define True true
  +#define False false
 
  Isn't that enough?
  
  It's enough to make it build, but it would be better to fix the users.
  
 
 Let me try to run a script to replace all of them to false and true.
 
 York
 
 

Try this:

$ find . -type f -name \*.h -print | xargs perl -pi -e 
's/(\b)FALSE(\b)/$1false$2/g'
$ find . -type f -name \*.h -print | xargs perl -pi -e 
's/(\b)TRUE(\b)/$1true$2/g'
$ find . -type f -name \*.c -print | xargs perl -pi -e 
's/(\b)FALSE(\b)/$1false$2/g'
$ find . -type f -name \*.c -print | xargs perl -pi -e 
's/(\b)TRUE(\b)/$1true$2/g'
$ find . -type f -name \*.h -print | xargs perl -pi -e 
's/(\b)False(\b)/$1false$2/g'
$ find . -type f -name \*.h -print | xargs perl -pi -e 
's/(\b)True(\b)/$1true$2/g'
$ find . -type f -name \*.c -print | xargs perl -pi -e 
's/(\b)False(\b)/$1false$2/g'
$ find . -type f -name \*.c -print | xargs perl -pi -e 
's/(\b)True(\b)/$1true$2/g'

-Allen
-- 
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/24/2013 10:28 AM, Allen Martin wrote:
 On Thu, Jan 24, 2013 at 10:23:21AM -0800, York Sun wrote:
 On 01/24/2013 10:14 AM, Scott Wood wrote:


 I thought I have replaced all #define, enum, typedef. I have left alone
 those FALSE, False, false but add define like this

 +#include stdbool.h
 +#define TRUE true
 +#define FALSE false
 +#define True true
 +#define False false

 Isn't that enough?

 It's enough to make it build, but it would be better to fix the users.


 Let me try to run a script to replace all of them to false and true.

 York


 
 Try this:
 
 $ find . -type f -name \*.h -print | xargs perl -pi -e 
 's/(\b)FALSE(\b)/$1false$2/g'
 $ find . -type f -name \*.h -print | xargs perl -pi -e 
 's/(\b)TRUE(\b)/$1true$2/g'
 $ find . -type f -name \*.c -print | xargs perl -pi -e 
 's/(\b)FALSE(\b)/$1false$2/g'
 $ find . -type f -name \*.c -print | xargs perl -pi -e 
 's/(\b)TRUE(\b)/$1true$2/g'
 $ find . -type f -name \*.h -print | xargs perl -pi -e 
 's/(\b)False(\b)/$1false$2/g'
 $ find . -type f -name \*.h -print | xargs perl -pi -e 
 's/(\b)True(\b)/$1true$2/g'
 $ find . -type f -name \*.c -print | xargs perl -pi -e 
 's/(\b)False(\b)/$1false$2/g'
 $ find . -type f -name \*.c -print | xargs perl -pi -e 
 's/(\b)True(\b)/$1true$2/g'
 

Thanks. I used xargs sed -i s/\bTrue\b/true/g following your git grep.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [Patch v3] Consolidate bool type

[York Sun]

'bool' is defined in random places. This patch consolidates them into a
single header file include/linux/types.h, using stdbool.h.

All other #define, typedef and enum are removed. They are all consistent with
true = 1, false = 0.

Signed-off-by: York Sun york...@freescale.com
---
Change since v1:
 Move 'false' and 'true' to the common header file.

Change since v2:
 Use stdbool.h
 Consolidate all TRUE, FALSE, True, False, true, false

Need help to test on all ARCHs with differnt toolchains as well as 
USE_PRIVATE_LIBGCC.

 arch/arm/cpu/arm926ejs/spear/spear600.c   |3 ---
 arch/blackfin/include/asm/posix_types.h   |3 ---
 arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c |2 --
 arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c|7 ---
 arch/powerpc/cpu/ppc4xx/denali_spd_ddr2.c |7 ---
 board/Marvell/db64360/mv_eth.h|7 ---
 board/Marvell/db64460/mv_eth.h|7 ---
 board/Marvell/include/core.h  |5 -
 board/amcc/bamboo/bamboo.h|3 ---
 board/amcc/yucca/yucca.c  |3 ---
 board/bf533-ezkit/flash-defines.h |2 --
 board/bf533-stamp/video.h |3 ---
 board/esd/common/lcd.h|5 -
 board/esd/cpci750/mv_eth.h|7 ---
 board/esd/dasa_sim/cmd_dasa_sim.c |4 
 board/evb64260/eth_addrtbl.c  |3 ---
 board/mpl/common/isa.c|7 ---
 board/mpl/mip405/mip405.c |2 --
 board/mpl/pip405/pip405.c |3 ---
 board/prodrive/p3mx/mv_eth.h  |7 ---
 board/sacsng/clkinit.h|5 -
 board/xilinx/common/xbasic_types.h|8 
 common/cmd_fdc.c  |7 ---
 drivers/bios_emulator/atibios.c   |4 
 drivers/block/sata_dwc.h  |7 ---
 drivers/mtd/nand/mxc_nand.c   |2 --
 drivers/net/armada100_fec.h   |7 ---
 drivers/net/ne2000_base.h |4 
 drivers/net/npe/include/IxOsalTypes.h |8 
 drivers/rtc/ds1374.c  |7 ---
 drivers/usb/musb-new/linux-compat.h   |2 --
 fs/ext4/ext4_common.h |2 --
 include/at91rm9200_net.h  |4 
 include/bedbug/ppc.h  |5 -
 include/fpga.h|8 
 include/galileo/core.h|5 -
 include/linux/types.h |5 +
 include/scsi.h|8 
 include/sym53c8xx.h   |7 ---
 include/xyzModem.h|8 
 lib/bzlib_private.h   |3 ---
 lib/lzma/Types.h  |3 ---
 42 files changed, 5 insertions(+), 204 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/spear/spear600.c 
b/arch/arm/cpu/arm926ejs/spear/spear600.c
index ff52131..ab9c6bd 100644
--- a/arch/arm/cpu/arm926ejs/spear/spear600.c
+++ b/arch/arm/cpu/arm926ejs/spear/spear600.c
@@ -28,9 +28,6 @@
 #include asm/arch/spr_misc.h
 #include asm/arch/spr_defs.h
 
-#define FALSE  0
-#define TRUE   (!FALSE)
-
 static void sel_1v8(void)
 {
struct misc_regs *misc_p = (struct misc_regs *)CONFIG_SPEAR_MISCBASE;
diff --git a/arch/blackfin/include/asm/posix_types.h 
b/arch/blackfin/include/asm/posix_types.h
index 000ffe5..1f28b36 100644
--- a/arch/blackfin/include/asm/posix_types.h
+++ b/arch/blackfin/include/asm/posix_types.h
@@ -61,9 +61,6 @@ typedef unsigned int __kernel_gid32_t;
 typedef unsigned short __kernel_old_uid_t;
 typedef unsigned short __kernel_old_gid_t;
 
-#define BOOL_WAS_DEFINED
-typedef enum { false = 0, true = 1 } bool;
-
 #ifdef __GNUC__
 typedef long long __kernel_loff_t;
 #endif
diff --git a/arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c 
b/arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c
index 8a20a2b..7d151e1 100644
--- a/arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c
+++ b/arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c
@@ -88,8 +88,6 @@ void spd_ddr_init_hang (void) __attribute__((weak, 
alias(__spd_ddr_init_hang))
 #define NUMMEMTESTS8
 #define NUMMEMWORDS8
 #define MAXBXCR4
-#define TRUE   1
-#define FALSE  0
 
 /*
  * This DDR2 setup code can dynamically setup the TLB entries for the DDR2 
memory
diff --git a/arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c 
b/arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c
index 85217ea..bd7e0ac 100644
--- a/arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c
+++ b/arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c
@@ -241,13 +241,6 @@ void board_add_ram_info(int use_default)
 
/*-+
  * Defines
  
*-*/
-#ifndefTRUE
-#define TRUE   

Re: [U-Boot] [Patch v3] Consolidate bool type

[Scott Wood]

On 01/23/2013 03:46:04 PM, York Sun wrote:

On 01/23/2013 01:41 PM, York Sun wrote:
 'bool' is defined in random places. This patch consolidates them  
into a

 single header file include/linux/types.h, using stdbool.h.

 All other #define, typedef and enum are removed. They are all  
consistent with

 true = 1, false = 0.

 Signed-off-by: York Sun york...@freescale.com
 ---
 Change since v1:
  Move 'false' and 'true' to the common header file.

 Change since v2:
  Use stdbool.h
  Consolidate all TRUE, FALSE, True, False, true, false

 Need help to test on all ARCHs with differnt toolchains as well as  
USE_PRIVATE_LIBGCC.



I should put RFC in the subject as I am not able to compile all ARCH  
myself.


So how do you see this patch becoming non-RFC?  I think most people  
don't have every single toolchain.  You should at least get a toolchain  
for a couple major architectures such as ARM.  Usually RFC is for when  
you know the patch has issues, and don't want it applied yet even if  
nobody else finds fault with it.


-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Scott Wood]

On 01/23/2013 03:41:47 PM, York Sun wrote:
diff --git a/drivers/net/npe/include/IxOsalTypes.h  
b/drivers/net/npe/include/IxOsalTypes.h

index a190a70..0168902 100644
--- a/drivers/net/npe/include/IxOsalTypes.h
+++ b/drivers/net/npe/include/IxOsalTypes.h
@@ -107,18 +107,10 @@ typedef volatile INT32 VINT32;
  */
 #define IX_OSAL_BILLION (10)

-#ifndef TRUE
-#define TRUE   1L
-#endif
-
 #if TRUE != 1
 #error TRUE is not defined to 1
 #endif

-#ifndef FALSE
-#define FALSE  0L
-#endif
-
 #if FALSE != 0
 #error FALSE is not defined to 0
 #endif


I imagine at least one of these #error statements will kick in now.   
All of the users of non-standard capitalizations must be fixed (I only  
see the definitions affected by this patch), and tests like these  
should just be dropped.


-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/23/2013 01:41 PM, York Sun wrote:
 'bool' is defined in random places. This patch consolidates them into a
 single header file include/linux/types.h, using stdbool.h.
 
 All other #define, typedef and enum are removed. They are all consistent with
 true = 1, false = 0.
 
 Signed-off-by: York Sun york...@freescale.com
 ---
 Change since v1:
  Move 'false' and 'true' to the common header file.
 
 Change since v2:
  Use stdbool.h
  Consolidate all TRUE, FALSE, True, False, true, false
 
 Need help to test on all ARCHs with differnt toolchains as well as 
 USE_PRIVATE_LIBGCC.
 

I should put RFC in the subject as I am not able to compile all ARCH myself.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/23/2013 01:52 PM, Scott Wood wrote:
 On 01/23/2013 03:46:04 PM, York Sun wrote:
 On 01/23/2013 01:41 PM, York Sun wrote:
  'bool' is defined in random places. This patch consolidates them into a
  single header file include/linux/types.h, using stdbool.h.
 
  All other #define, typedef and enum are removed. They are all
 consistent with
  true = 1, false = 0.
 
  Signed-off-by: York Sun york...@freescale.com
  ---
  Change since v1:
   Move 'false' and 'true' to the common header file.
 
  Change since v2:
   Use stdbool.h
   Consolidate all TRUE, FALSE, True, False, true, false
 
  Need help to test on all ARCHs with differnt toolchains as well as
 USE_PRIVATE_LIBGCC.
 
 
 I should put RFC in the subject as I am not able to compile all ARCH
 myself.
 
 So how do you see this patch becoming non-RFC?  I think most people
 don't have every single toolchain.  You should at least get a toolchain
 for a couple major architectures such as ARM.  Usually RFC is for when
 you know the patch has issues, and don't want it applied yet even if
 nobody else finds fault with it.
 

I know this version has problem. I am hoping more people get involved
and test what they can. I tried the arm toolchain you pointed to me. I
couldn't run MAKEALL for arm.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Scott Wood]

On 01/23/2013 04:01:49 PM, York Sun wrote:

On 01/23/2013 01:52 PM, Scott Wood wrote:
 On 01/23/2013 03:46:04 PM, York Sun wrote:
 On 01/23/2013 01:41 PM, York Sun wrote:
 I should put RFC in the subject as I am not able to compile all  
ARCH

 myself.

 So how do you see this patch becoming non-RFC?  I think most people
 don't have every single toolchain.  You should at least get a  
toolchain
 for a couple major architectures such as ARM.  Usually RFC is for  
when

 you know the patch has issues, and don't want it applied yet even if
 nobody else finds fault with it.


I know this version has problem. I am hoping more people get involved
and test what they can. I tried the arm toolchain you pointed to me. I
couldn't run MAKEALL for arm.


Even before your patch, using USE_PRIVATE_LIBGCC?  How many boards  
failed?


-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/23/2013 01:53 PM, Scott Wood wrote:
 On 01/23/2013 03:41:47 PM, York Sun wrote:
 diff --git a/drivers/net/npe/include/IxOsalTypes.h
 b/drivers/net/npe/include/IxOsalTypes.h
 index a190a70..0168902 100644
 --- a/drivers/net/npe/include/IxOsalTypes.h
 +++ b/drivers/net/npe/include/IxOsalTypes.h
 @@ -107,18 +107,10 @@ typedef volatile INT32 VINT32;
   */
  #define IX_OSAL_BILLION (10)

 -#ifndef TRUE
 -#define TRUE   1L
 -#endif
 -
  #if TRUE != 1
  #error TRUE is not defined to 1
  #endif

 -#ifndef FALSE
 -#define FALSE  0L
 -#endif
 -
  #if FALSE != 0
  #error FALSE is not defined to 0
  #endif
 
 I imagine at least one of these #error statements will kick in now.  All
 of the users of non-standard capitalizations must be fixed (I only see
 the definitions affected by this patch), and tests like these should
 just be dropped.
 


Agreed. Will drop in next version (v5).

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[Allen Martin]

On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
 On 01/23/2013 02:02 PM, Scott Wood wrote:
  On 01/23/2013 04:01:49 PM, York Sun wrote:
  On 01/23/2013 01:52 PM, Scott Wood wrote:
   On 01/23/2013 03:46:04 PM, York Sun wrote:
   On 01/23/2013 01:41 PM, York Sun wrote:
   I should put RFC in the subject as I am not able to compile all ARCH
   myself.
  
   So how do you see this patch becoming non-RFC?  I think most people
   don't have every single toolchain.  You should at least get a toolchain
   for a couple major architectures such as ARM.  Usually RFC is for when
   you know the patch has issues, and don't want it applied yet even if
   nobody else finds fault with it.
  
 
  I know this version has problem. I am hoping more people get involved
  and test what they can. I tried the arm toolchain you pointed to me. I
  couldn't run MAKEALL for arm.
  
  Even before your patch, using USE_PRIVATE_LIBGCC?  How many boards failed?
  
 I don't know. Wolfgang brought it. Allen kindly offered help to verify
 on tegra which uses USE_PRIVATE_LIBGCC.

I actually have a script to build all 1000+ boards in every
architecture, but I think a few of my toolchains are broken (openrisc
and blackfin come to mind).  I've been thinking about incorporating
that functionality into MAKEALL as a set of patches.

In the meantime I can build and test on tegra, which as York says uses
USE_PRIVATE_LIBGCC. 

-Allen
-- 
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch v3] Consolidate bool type

[York Sun]

On 01/23/2013 02:02 PM, Scott Wood wrote:
 On 01/23/2013 04:01:49 PM, York Sun wrote:
 On 01/23/2013 01:52 PM, Scott Wood wrote:
  On 01/23/2013 03:46:04 PM, York Sun wrote:
  On 01/23/2013 01:41 PM, York Sun wrote:
  I should put RFC in the subject as I am not able to compile all ARCH
  myself.
 
  So how do you see this patch becoming non-RFC?  I think most people
  don't have every single toolchain.  You should at least get a toolchain
  for a couple major architectures such as ARM.  Usually RFC is for when
  you know the patch has issues, and don't want it applied yet even if
  nobody else finds fault with it.
 

 I know this version has problem. I am hoping more people get involved
 and test what they can. I tried the arm toolchain you pointed to me. I
 couldn't run MAKEALL for arm.
 
 Even before your patch, using USE_PRIVATE_LIBGCC?  How many boards failed?
 
I don't know. Wolfgang brought it. Allen kindly offered help to verify
on tegra which uses USE_PRIVATE_LIBGCC.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot