Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Westergreen, Dalon]

On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote:
> On 2/24/20 3:26 AM, Ang, Chee Hong wrote:
> > > On 2/21/20 7:15 PM, Ang, Chee Hong wrote:
> > > > > On 2/20/20 6:04 PM, Westergreen, Dalon wrote:
> > > > > 
> > > > > Please fix your mailer, it makes your reply completely unreadable.
> > > > > 
> > > > > > On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:
> > > > > > 
> > > > > > On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
> > > > > > 
> > > > > > On 2/19/20 1:25 PM,
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > chee.hong@intel.com
> > > > > > 
> > > > > >  wrote:
> > > > > > 
> > > > > > From: Chee Hong Ang <
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > chee.hong@intel.com
> > > > > > 
> > > > > > 
> > > > > > CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
> > > > > > 
> > > > > > file requirements.  Since this option now produces a warning during
> > > > > > 
> > > > > > build, and the spl hex can be created using alternate methods,
> > > > > > 
> > > > > > CONFIG_OF_EMBED is no longer needed.
> > > > > 
> > > > > OK, so this patch removes functionality.
> > > > > Can that functionality be retained ? Or what can be done here?
> > > > The functionality is no longer required.
> > > 
> > > Because you always depend on ATF now ?
> > No. We have 2 different defconfigs in the patchset, one use ATF one without
> > ATF. Both no longer using CONFIG_OF_EMBED and they worked fine.
> 
> OK. So how is the .hex file generated now ?

Sorry, re-installed my OS and neglected to turn off HTML for my email default...

In our tree the patch i submitted to generate the hex file via objcopy is being
used. I can resubmit this?

Otherwise, people are just manually calling objcopy to convert the cat'ed spl-
dtb.bin to a hex file offset
to the appropriate address.

--dalon

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Marek Vasut]

On 2/25/20 7:26 PM, Westergreen, Dalon wrote:
> 
> 
> On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote:
> 
> On 2/24/20 3:26 AM, Ang, Chee Hong wrote:
> 
> On 2/21/20 7:15 PM, Ang, Chee Hong wrote:
> 
> On 2/20/20 6:04 PM, Westergreen, Dalon wrote:
> 
> 
> Please fix your mailer, it makes your reply completely unreadable.

Sorry, I'm not reading further, your reply is again completely
unreadable :-(

[...]

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Westergreen, Dalon]

On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote:

On 2/24/20 3:26 AM, Ang, Chee Hong wrote:

On 2/21/20 7:15 PM, Ang, Chee Hong wrote:

On 2/20/20 6:04 PM, Westergreen, Dalon wrote:


Please fix your mailer, it makes your reply completely unreadable.


On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:


On 2/20/20 3:12 AM, Ang, Chee Hong wrote:


On 2/19/20 1:25 PM,


mailto:chee.hong@intel.com>

chee.hong@intel.com

>




chee.hong@intel.com



 wrote:


From: Chee Hong Ang <


mailto:chee.hong@intel.com>

chee.hong@intel.com

>




chee.hong@intel.com






CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex


file requirements.  Since this option now produces a warning during


build, and the spl hex can be created using alternate methods,


CONFIG_OF_EMBED is no longer needed.


OK, so this patch removes functionality.

Can that functionality be retained ? Or what can be done here?

The functionality is no longer required.


Because you always depend on ATF now ?

No. We have 2 different defconfigs in the patchset, one use ATF one without

ATF. Both no longer using CONFIG_OF_EMBED and they worked fine.


OK. So how is the .hex file generated now ?

In our tree the patch i submitted to generate the hex file via objcopy is being 
used. I can resubmit this?

Otherwise, people are just manually calling objcopy to convert the cat'ed 
spl-dtb.bin to a hex file offset
to the appropriate address.

--dalon

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Marek Vasut]

On 2/24/20 3:26 AM, Ang, Chee Hong wrote:
>> On 2/21/20 7:15 PM, Ang, Chee Hong wrote:
 On 2/20/20 6:04 PM, Westergreen, Dalon wrote:

 Please fix your mailer, it makes your reply completely unreadable.

> On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:
>
> On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
>
> On 2/19/20 1:25 PM,
>
> 
>
> chee.hong@intel.com
>
>  wrote:
>
> From: Chee Hong Ang <
>
> 
>
> chee.hong@intel.com
>
>>
>
>
> CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
>
> file requirements.  Since this option now produces a warning during
>
> build, and the spl hex can be created using alternate methods,
>
> CONFIG_OF_EMBED is no longer needed.

 OK, so this patch removes functionality.
 Can that functionality be retained ? Or what can be done here?
>>> The functionality is no longer required.
>>
>> Because you always depend on ATF now ?
> No. We have 2 different defconfigs in the patchset, one use ATF one without
> ATF. Both no longer using CONFIG_OF_EMBED and they worked fine.

OK. So how is the .hex file generated now ?

RE: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Ang, Chee Hong]

> On 2/21/20 7:15 PM, Ang, Chee Hong wrote:
> >> On 2/20/20 6:04 PM, Westergreen, Dalon wrote:
> >>
> >> Please fix your mailer, it makes your reply completely unreadable.
> >>
> >>> On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:
> >>>
> >>> On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
> >>>
> >>> On 2/19/20 1:25 PM,
> >>>
> >>> 
> >>>
> >>> chee.hong@intel.com
> >>>
> >>>  wrote:
> >>>
> >>> From: Chee Hong Ang <
> >>>
> >>> 
> >>>
> >>> chee.hong@intel.com
> >>>
> 
> >>>
> >>>
> >>> CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
> >>>
> >>> file requirements.  Since this option now produces a warning during
> >>>
> >>> build, and the spl hex can be created using alternate methods,
> >>>
> >>> CONFIG_OF_EMBED is no longer needed.
> >>
> >> OK, so this patch removes functionality.
> >> Can that functionality be retained ? Or what can be done here?
> > The functionality is no longer required.
> 
> Because you always depend on ATF now ?
No. We have 2 different defconfigs in the patchset, one use ATF one without
ATF. Both no longer using CONFIG_OF_EMBED and they worked fine.

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Marek Vasut]

On 2/21/20 7:15 PM, Ang, Chee Hong wrote:
>> On 2/20/20 6:04 PM, Westergreen, Dalon wrote:
>>
>> Please fix your mailer, it makes your reply completely unreadable.
>>
>>> On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:
>>>
>>> On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
>>>
>>> On 2/19/20 1:25 PM,
>>>
>>> 
>>>
>>> chee.hong@intel.com
>>>
>>>  wrote:
>>>
>>> From: Chee Hong Ang <
>>>
>>> 
>>>
>>> chee.hong@intel.com
>>>

>>>
>>>
>>> CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
>>>
>>> file requirements.  Since this option now produces a warning during
>>>
>>> build, and the spl hex can be created using alternate methods,
>>>
>>> CONFIG_OF_EMBED is no longer needed.
>>
>> OK, so this patch removes functionality.
>> Can that functionality be retained ? Or what can be done here?
> The functionality is no longer required.

Because you always depend on ATF now ?

RE: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Ang, Chee Hong]

> On 2/20/20 6:04 PM, Westergreen, Dalon wrote:
> 
> Please fix your mailer, it makes your reply completely unreadable.
> 
> > On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:
> >
> > On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
> >
> > On 2/19/20 1:25 PM,
> >
> > 
> >
> > chee.hong@intel.com
> >
> >  wrote:
> >
> > From: Chee Hong Ang <
> >
> > 
> >
> > chee.hong@intel.com
> >
> >>
> >
> >
> > CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
> >
> > file requirements.  Since this option now produces a warning during
> >
> > build, and the spl hex can be created using alternate methods,
> >
> > CONFIG_OF_EMBED is no longer needed.
> 
> OK, so this patch removes functionality.
> Can that functionality be retained ? Or what can be done here?
The functionality is no longer required.
> 
> [...]

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Marek Vasut]

On 2/20/20 6:04 PM, Westergreen, Dalon wrote:

Please fix your mailer, it makes your reply completely unreadable.

> On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:
> 
> On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
> 
> On 2/19/20 1:25 PM,
> 
> 
> 
> chee.hong@intel.com
> 
>  wrote:
> 
> From: Chee Hong Ang <
> 
> 
> 
> chee.hong@intel.com
> 
>>
> 
> 
> CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
> 
> file requirements.  Since this option now produces a warning during
> 
> build, and the spl hex can be created using alternate methods,
> 
> CONFIG_OF_EMBED is no longer needed.

OK, so this patch removes functionality.
Can that functionality be retained ? Or what can be done here?

[...]

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Westergreen, Dalon]

On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote:

On 2/20/20 3:12 AM, Ang, Chee Hong wrote:

On 2/19/20 1:25 PM,



chee.hong@intel.com

 wrote:

From: Chee Hong Ang <



chee.hong@intel.com

>


CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex

file requirements.  Since this option now produces a warning during

build, and the spl hex can be created using alternate methods,

CONFIG_OF_EMBED is no longer needed.


Signed-off-by: Chee Hong Ang <



chee.hong@intel.com

>


If I apply just this patch, is the platform still bootable ?

Yes. I tested on the platform.

There is a similar patch from Dalon for Stratix10 and it still yet to be applied

to mainline:



https://lists.denx.de/pipermail/u-boot/2019-September/384906.html



I hope the patch from Dalon get applied to mainline before these patchsets.


In fact, this "CONFIG_OF_EMBED" produce warning during build.

Better get rid of this.


If you just remove OF_EMBED, will the DT still be correctly passed in ?

The warning is there for a reason and just removing OF_EMBED to silence

the warning isn't the right approach. But if this works on Agilex, fine.

Yes, it is fine, the u-boot binary and dtb are just cat'ed together instead.

--dalon

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Marek Vasut]

On 2/20/20 3:12 AM, Ang, Chee Hong wrote:
>> On 2/19/20 1:25 PM, chee.hong@intel.com wrote:
>>> From: Chee Hong Ang 
>>>
>>> CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
>>> file requirements.  Since this option now produces a warning during
>>> build, and the spl hex can be created using alternate methods,
>>> CONFIG_OF_EMBED is no longer needed.
>>>
>>> Signed-off-by: Chee Hong Ang 
>>
>> If I apply just this patch, is the platform still bootable ?
> Yes. I tested on the platform.
> There is a similar patch from Dalon for Stratix10 and it still yet to be 
> applied
> to mainline:
> https://lists.denx.de/pipermail/u-boot/2019-September/384906.html
> 
> I hope the patch from Dalon get applied to mainline before these patchsets.
> 
> In fact, this "CONFIG_OF_EMBED" produce warning during build.
> Better get rid of this.

If you just remove OF_EMBED, will the DT still be correctly passed in ?
The warning is there for a reason and just removing OF_EMBED to silence
the warning isn't the right approach. But if this works on Agilex, fine.

RE: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Ang, Chee Hong]

> On 2/19/20 1:25 PM, chee.hong@intel.com wrote:
> > From: Chee Hong Ang 
> >
> > CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex
> > file requirements.  Since this option now produces a warning during
> > build, and the spl hex can be created using alternate methods,
> > CONFIG_OF_EMBED is no longer needed.
> >
> > Signed-off-by: Chee Hong Ang 
> 
> If I apply just this patch, is the platform still bootable ?
Yes. I tested on the platform.
There is a similar patch from Dalon for Stratix10 and it still yet to be applied
to mainline:
https://lists.denx.de/pipermail/u-boot/2019-September/384906.html

I hope the patch from Dalon get applied to mainline before these patchsets.

In fact, this "CONFIG_OF_EMBED" produce warning during build.
Better get rid of this.

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

[Marek Vasut]

On 2/19/20 1:25 PM, chee.hong@intel.com wrote:
> From: Chee Hong Ang 
> 
> CONFIG_OF_EMBED was primarily enabled to support the agilex
> spl hex file requirements.  Since this option now produces a
> warning during build, and the spl hex can be created using
> alternate methods, CONFIG_OF_EMBED is no longer needed.
> 
> Signed-off-by: Chee Hong Ang 

If I apply just this patch, is the platform still bootable ?