Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
Hi Fabio, > Hi Fabio, > > > On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam > > wrote: > > > > > > Hi Lukasz, > > > > > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski > > > wrote: > > > > +serverip=10.8.217.79 > > > > +nfs_serverip=10.8.218.113 > > > > +gatewayip=10.8.209.250 > > > > > > These IP addresses should not be hardcoded here. > > > > > > They were not present in xea.h originally. Please remove them. > > > > One more thing: xea.h had: > > "dtbfile=imx28-xea.dtb\0" > > > > but I don't see dtbfile declared inside the new xea.env. > > Thanks for spotting it - I've forgotten to remove it after moving > forward to fitImage. > > I will remove it. > This will be added not removed... > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Erika Unter > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lu...@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgptER0uzTE22.pgp Description: OpenPGP digital signature
Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
Hi Fabio, > On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam > wrote: > > > > Hi Lukasz, > > > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski > > wrote: > > > +serverip=10.8.217.79 > > > +nfs_serverip=10.8.218.113 > > > +gatewayip=10.8.209.250 > > > > These IP addresses should not be hardcoded here. > > > > They were not present in xea.h originally. Please remove them. > > One more thing: xea.h had: > "dtbfile=imx28-xea.dtb\0" > > but I don't see dtbfile declared inside the new xea.env. Thanks for spotting it - I've forgotten to remove it after moving forward to fitImage. I will remove it. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpbgm3mhQ6P0.pgp Description: OpenPGP digital signature
Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
Hi Fabio, > Hi Lukasz, > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski wrote: > > > +serverip=10.8.217.79 > > +nfs_serverip=10.8.218.113 > > +gatewayip=10.8.209.250 > > These IP addresses should not be hardcoded here. > > They were not present in xea.h originally. Please remove them. Those are the IP's for customer's production setup. In that way I could just point to mainline SHA1 and just use the sources without any further adjustments. I can agree, that on "common devel board" (like e.g. beaglebone) it would be problematic to have it hardcoded, but as this one is customer specific HW ... Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpzWpSNKl7oN.pgp Description: OpenPGP digital signature
Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam wrote: > > Hi Lukasz, > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski wrote: > > > +serverip=10.8.217.79 > > +nfs_serverip=10.8.218.113 > > +gatewayip=10.8.209.250 > > These IP addresses should not be hardcoded here. > > They were not present in xea.h originally. Please remove them. One more thing: xea.h had: "dtbfile=imx28-xea.dtb\0" but I don't see dtbfile declared inside the new xea.env.
Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
Hi Lukasz, On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski wrote: > +serverip=10.8.217.79 > +nfs_serverip=10.8.218.113 > +gatewayip=10.8.209.250 These IP addresses should not be hardcoded here. They were not present in xea.h originally. Please remove them.
