Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
Am Fr., 16. Nov. 2018, 18:25 hat Simon Glass geschrieben: > Hi, > > On 16 November 2018 at 09:04, Simon Goldschmidt > wrote: > > > > > > Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt > > geschrieben: > >> > >> On 03.11.2018 07:08, Simon Glass wrote: > >> > On 2 November 2018 at 14:28, Simon Goldschmidt > >> > wrote: > >> >> Add possibility to update the serial parity used. > >> >> > >> >> Signed-off-by: Simon Goldschmidt > >> >> --- > >> >> > >> >> drivers/serial/ns16550.c | 43 > >> >> ++-- > >> >> 1 file changed, 41 insertions(+), 2 deletions(-) > >> >> > >> > Reviewed-by: Simon Glass > >> > > >> > Ideally we should call this from sandbox (or a test) somewhere. > >> > >> Hmm, I'm a bit lost there. I haven't really used the tests so far and > >> grep'ing through test/ does not show any reference to ns16550 either > >> (where I could easily add a test). > >> > >> Did you mean adding a test for this specific driver (ns16550) or for the > >> call to 'setconfig' in general? (Because I thought Patrice had already > >> done that.) > > > > > > Simon, any input on this? Does your comment somehow hold back this from > > being pushed? > > No, I added my review tag. > > It looks like serial_setconfig() is written without a struct udevice > parameter. I think that should be fixed, since new functionality > should use DM. > Right, that would be good. I just saw we're calling the operation by directly accessing the struct... I would change and test that but I'm still having trouble in getting the tests to run... Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
Hi, On 16 November 2018 at 09:04, Simon Goldschmidt wrote: > > > Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt > geschrieben: >> >> On 03.11.2018 07:08, Simon Glass wrote: >> > On 2 November 2018 at 14:28, Simon Goldschmidt >> > wrote: >> >> Add possibility to update the serial parity used. >> >> >> >> Signed-off-by: Simon Goldschmidt >> >> --- >> >> >> >> drivers/serial/ns16550.c | 43 >> >> ++-- >> >> 1 file changed, 41 insertions(+), 2 deletions(-) >> >> >> > Reviewed-by: Simon Glass >> > >> > Ideally we should call this from sandbox (or a test) somewhere. >> >> Hmm, I'm a bit lost there. I haven't really used the tests so far and >> grep'ing through test/ does not show any reference to ns16550 either >> (where I could easily add a test). >> >> Did you mean adding a test for this specific driver (ns16550) or for the >> call to 'setconfig' in general? (Because I thought Patrice had already >> done that.) > > > Simon, any input on this? Does your comment somehow hold back this from > being pushed? No, I added my review tag. It looks like serial_setconfig() is written without a struct udevice parameter. I think that should be fixed, since new functionality should use DM. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
Am Fr., 16. Nov. 2018, 18:09 hat Tom Rini geschrieben: > On Fri, Nov 16, 2018 at 06:04:40PM +0100, Simon Goldschmidt wrote: > > Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt < > > simon.k.r.goldschm...@gmail.com> geschrieben: > > > > > On 03.11.2018 07:08, Simon Glass wrote: > > > > On 2 November 2018 at 14:28, Simon Goldschmidt > > > > wrote: > > > >> Add possibility to update the serial parity used. > > > >> > > > >> Signed-off-by: Simon Goldschmidt > > > >> --- > > > >> > > > >> drivers/serial/ns16550.c | 43 > ++-- > > > >> 1 file changed, 41 insertions(+), 2 deletions(-) > > > >> > > > > Reviewed-by: Simon Glass > > > > > > > > Ideally we should call this from sandbox (or a test) somewhere. > > > > > > Hmm, I'm a bit lost there. I haven't really used the tests so far and > > > grep'ing through test/ does not show any reference to ns16550 either > > > (where I could easily add a test). > > > > > > Did you mean adding a test for this specific driver (ns16550) or for > the > > > call to 'setconfig' in general? (Because I thought Patrice had already > > > done that.) > > > > > > > Simon, any input on this? Does your comment somehow hold back this from > > being pushed? > > I'm testing this now, btw. > Oh, cool, thanks for the info. I tested this on socfpga gen5 only, but the registers should be portable... Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
On Fri, Nov 16, 2018 at 06:04:40PM +0100, Simon Goldschmidt wrote: > Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt < > simon.k.r.goldschm...@gmail.com> geschrieben: > > > On 03.11.2018 07:08, Simon Glass wrote: > > > On 2 November 2018 at 14:28, Simon Goldschmidt > > > wrote: > > >> Add possibility to update the serial parity used. > > >> > > >> Signed-off-by: Simon Goldschmidt > > >> --- > > >> > > >> drivers/serial/ns16550.c | 43 ++-- > > >> 1 file changed, 41 insertions(+), 2 deletions(-) > > >> > > > Reviewed-by: Simon Glass > > > > > > Ideally we should call this from sandbox (or a test) somewhere. > > > > Hmm, I'm a bit lost there. I haven't really used the tests so far and > > grep'ing through test/ does not show any reference to ns16550 either > > (where I could easily add a test). > > > > Did you mean adding a test for this specific driver (ns16550) or for the > > call to 'setconfig' in general? (Because I thought Patrice had already > > done that.) > > > > Simon, any input on this? Does your comment somehow hold back this from > being pushed? I'm testing this now, btw. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt < simon.k.r.goldschm...@gmail.com> geschrieben: > On 03.11.2018 07:08, Simon Glass wrote: > > On 2 November 2018 at 14:28, Simon Goldschmidt > > wrote: > >> Add possibility to update the serial parity used. > >> > >> Signed-off-by: Simon Goldschmidt > >> --- > >> > >> drivers/serial/ns16550.c | 43 ++-- > >> 1 file changed, 41 insertions(+), 2 deletions(-) > >> > > Reviewed-by: Simon Glass > > > > Ideally we should call this from sandbox (or a test) somewhere. > > Hmm, I'm a bit lost there. I haven't really used the tests so far and > grep'ing through test/ does not show any reference to ns16550 either > (where I could easily add a test). > > Did you mean adding a test for this specific driver (ns16550) or for the > call to 'setconfig' in general? (Because I thought Patrice had already > done that.) > Simon, any input on this? Does your comment somehow hold back this from being pushed? Simon > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
> Betreff: [PATCH] serial: ns16550: add setconfig support > > Add possibility to update the serial parity used. > > Signed-off-by: Simon Goldschmidt > --- > > drivers/serial/ns16550.c | 43 ++-- > 1 file changed, 41 insertions(+), 2 deletions(-) Reviewed-by: Hannes Schmelzer ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
On 03.11.2018 07:08, Simon Glass wrote: On 2 November 2018 at 14:28, Simon Goldschmidt wrote: Add possibility to update the serial parity used. Signed-off-by: Simon Goldschmidt --- drivers/serial/ns16550.c | 43 ++-- 1 file changed, 41 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass Ideally we should call this from sandbox (or a test) somewhere. Hmm, I'm a bit lost there. I haven't really used the tests so far and grep'ing through test/ does not show any reference to ns16550 either (where I could easily add a test). Did you mean adding a test for this specific driver (ns16550) or for the call to 'setconfig' in general? (Because I thought Patrice had already done that.) Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: ns16550: add setconfig support
On 2 November 2018 at 14:28, Simon Goldschmidt wrote: > Add possibility to update the serial parity used. > > Signed-off-by: Simon Goldschmidt > --- > > drivers/serial/ns16550.c | 43 ++-- > 1 file changed, 41 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass Ideally we should call this from sandbox (or a test) somewhere. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
