Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Shinya Kuribayashi
Wolfgang Denk wrote:
 * U-Boot mailing list traffic:
  2858  05/27 wangjiankun820624  [U-Boot-Users] MIPS: about the function of 
 the octeon_twsi_set_addr8
   - for MIPS custodian

I'm happy to know there is Octeon port, but I guess that's a local
version provided from Cavium Networks to their customers.  We don't have
it in upstream, and dont' have any comments on that.

  3512  06/08 Jason McMullan [U-Boot-Users] [PATCH] mips: When booting 
 Linux images, add 'ethaddr' and 'eth1addr' to the env
   - for MIPS custodian

Hm, I don't see any strong needs to have this.  Will reply to Jason on
ML, thanks.


  Shinya

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Ben Warren
Hi Wolfgang,

welcome back...

Wolfgang Denk wrote:
 In message [EMAIL PROTECTED] you wrote:
   
 Replace COBJS-y with appropriate driver config names.

 Signed-off-by: Shinya Kuribayashi [EMAIL PROTECTED]
 ---

 Changes v2:

  * Kill more CONFIG_CMD_NET and CONFIG_NET_MULTI defines from
- fsl_mcdmafec.c
- mcffec.c
- netarm_eth.c

  * Revised DM9000 part against the net repo.
 

 Hm... Are you absolutely sure your changes, especially the
 CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not
 cause any trouble on any systems?

 Let's for example check the E1000 network driver. with your changes,
 it will be built (and enabled), if...

 ...
   
 +COBJS-$(CONFIG_E1000) += e1000.o
 
 ...

 ... if CONFIG_E1000 is set.

 However, the old code:

 ...
   
 -#if defined(CONFIG_CMD_NET) \
 - defined(CONFIG_NET_MULTI)  defined(CONFIG_E1000)
 -
 

 ...*also* required that CONFIG_CMD_NET *AND* CONFIG_NET_MULTI were
 set, too. 

 [For the E1000 driver this is easy to  verify,  as  only  few  boards
 enable this option, but you are changing this for many drivers, so it
 affects many boards...]


 It seems not obvious to me that your change is  really  harmless,  or
 tested.

 Could you please comment?

 [Note that I like your patch and would like to apply it (or  ask  Ben
 to do that), but it seems kind of risly to me...]

   
I decided to accept this and push it upstream because it's definitely a 
step in the right direction.  Addressing your concerns, for any driver:

if CONFIG_CMD_NET isn't defined, networking isn't enabled, and at worst 
your image is bigger than necessary because of libnet.a

if CONFIG_NET_MULTI isn't defined, but CONFIG_CMD_NET is, networking 
will use the 'old-school' API and if the driver doesn't export 
eth_init() etc., you'll get a compile error.

So, IMHO the worst case scenario is a bit of code bloat or compile 
error, which aren't disastrous.  Run-time errors bad, compile-time, not 
so much.

Personally, I want to merge the two networking APIs so this MULTI 
business goes away.  Baby steps are necessary here.
 Best regards,

 Wolfgang Denk

   
regards,
Ben

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] (no subject)

2008-07-06 Thread David Saada
Kumar Gala-3 wrote:

 This is a series of patches that are a work-in-progress towards a new
 DDR initialization for the Freescale 8{3,5,6}xxx devices that have a
 common DDR controller.


Kumar,
Does this RFC also include support for identifying and initializing more than 
one DDR module?
David.
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Ben Warren
Hi Wolfgang,

Wolfgang Denk wrote:
 Hi everybody,

 here is a summary of the current state of my processing of patches
 that have been submitted for the upcoming 1.3.4 release.

 As you might have noticed, I've been on vacation for the last two
 weeks, and I spent this time (intentionally) completely offline. So
 please apologize if parts of the following comments / questions have
 been obsoleted by recent events - I will try to catch up as soon as
 possible, but I think it is better to send out this summary now,
 i. e. _before_ I start reading he backlog of the last two weeks.


 Here is a list of patches I had marked as open in my list, with
 comments about their state, including comments who I consider to be
 responsible for further progress:

   
snip

  3645  06/11 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH v2] net: sh: Renesas 
 SH7763 Ethernet device support
   - for net custodian

   
Didn't pick this up because it was after what I thought was the cut-off 
of 6/10.  It still has issues, so I'll ask NobuHiro to re-submit.  
Should it go in this release when OK?
snip
  3812  06/13 Ben Warren [PATCH V4] Add mechanisms for CPU and 
 board-specific Ethernet initialization
   - for net custodian.

   
Again, thought it was too late.  I'll send a pull request soon that will 
include this one.
snip
  3901  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH] net: ne2000: Move 
 dev_addr variable from grobal to local.
  3902  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH] net: ne2000: Fix 
 compile error of NE2000
   - for net custodian

   
These are good ones, and will be in my pull request.  Same deal with the 
date.
snip
  3984  06/18 Hugo Villeneuve[U-Boot-Users] [PATCH 1/2] Remove duplicate 
 definitions in include/lxt971a.h.
  3985  06/18 Hugo Villeneuve[U-Boot-Users] [PATCH 2/2] Remove duplicate 
 code in cpu/arm926ejs/davinci/lxt972.c.
   - for net custodian

   
Missed these completely, since no clues in title about networking...


regards,
Ben

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Wolfgang Denk
Dear Ben,

in message [EMAIL PROTECTED] you wrote:
 
   3645  06/11 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH v2] net: sh: Renesas 
  SH7763 Ethernet device support
  - for net custodian
 

 Didn't pick this up because it was after what I thought was the cut-off 
 of 6/10.  It still has issues, so I'll ask NobuHiro to re-submit.  
 Should it go in this release when OK?

Yes, please.

   3812  06/13 Ben Warren [PATCH V4] Add mechanisms for CPU and 
  board-specific Ethernet initialization
  - for net custodian.

 Again, thought it was too late.  I'll send a pull request soon that will 
 include this one.

Thanks.

   3984  06/18 Hugo Villeneuve[U-Boot-Users] [PATCH 1/2] Remove duplicate 
  definitions in include/lxt971a.h.
   3985  06/18 Hugo Villeneuve[U-Boot-Users] [PATCH 2/2] Remove duplicate 
  code in cpu/arm926ejs/davinci/lxt972.c.
  - for net custodian

 Missed these completely, since no clues in title about networking...

Well, LXT97x means PHY means net custodian for me :-)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
I usually tell my classes if you are using @ and [] together in this
class, you will almost certainly NOT get what you want. That's  going
down  the wrong tunnel. There's no cheese at the end of that tunnel.
 -- Randal L. Schwartz in [EMAIL PROTECTED]

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] add 'unzip' command to u-boot commandline

2008-07-06 Thread Harald Welte
[PATCH] add new 'unzip' command to u-boot commandline

common/cmd_mem.c: new command unzip srcaddr dstaddr [dstsize] to unzip from
memory to memory, and option CONFIG_CMD_UNZIP to enable it

Signed-off-by: Werner Almesberger [EMAIL PROTECTED]
Signed-off-by: Harald Welte [EMAIL PROTECTED]

diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index d6d7a5b..656f519 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -1191,6 +1191,34 @@ int do_mem_crc (cmd_tbl_t *cmdtp, int flag, int argc, 
char *argv[])
 }
 #endif /* CONFIG_CRC32_VERIFY */
 
+
+#ifdef CONFIG_CMD_UNZIP
+int  gunzip (void *, int, unsigned char *, unsigned long *);
+
+int do_unzip ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+   unsigned long src, dst;
+   unsigned long src_len = ~0UL, dst_len = ~0UL;
+   int err;
+
+   switch (argc) {
+   case 4:
+   dst_len = simple_strtoul(argv[3], NULL, 16);
+   /* fall through */
+   case 3:
+   src = simple_strtoul(argv[1], NULL, 16);
+   dst = simple_strtoul(argv[2], NULL, 16);
+   break;
+   default:
+   printf (Usage:\n%s\n, cmdtp-usage);
+   return 1;
+   }
+
+   return !!gunzip((void *) dst, dst_len, (void *) src, src_len);
+}
+#endif /* CONFIG_CMD_UNZIP */
+
+
 /**/
 #if defined(CONFIG_CMD_MEMORY)
 U_BOOT_CMD(
@@ -1294,5 +1322,13 @@ U_BOOT_CMD(
 );
 #endif /* CONFIG_MX_CYCLIC */
 
+#ifdef CONFIG_CMD_UNZIP
+U_BOOT_CMD(
+   unzip,  4,  1,  do_unzip,
+   unzip - unzip a memory region\n,
+   srcaddr dstaddr [dstsize]\n
+);
+#endif /* CONFIG_CMD_UNZIP */
+
 #endif
 #endif
diff --git a/include/config_cmd_all.h b/include/config_cmd_all.h
index c2bb094..2cb2f67 100644
--- a/include/config_cmd_all.h
+++ b/include/config_cmd_all.h
@@ -77,6 +77,7 @@
 #define CONFIG_CMD_SPI /* SPI utility  */
 #define CONFIG_CMD_TERMINAL/* built-in Serial Terminal */
 #define CONFIG_CMD_UNIVERSE/* Tundra Universe Support  */
+#define CONFIG_CMD_UNZIP   /* unzip from memory to memory  */
 #define CONFIG_CMD_USB /* USB Support  */
 #define CONFIG_CMD_VFD /* VFD support (TRAB)   */
 #define CONFIG_CMD_XIMG/* Load part of Multi Image */
-- 
- Harald Welte [EMAIL PROTECTED]   http://laforge.gnumonks.org/

Privacy in residential applications is a desirable marketing option.
  (ETSI EN 300 175-7 Ch. A6)


signature.asc
Description: Digital signature
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [RFC][FSL DDR 0/8] Freescale DDR rewrit

2008-07-06 Thread David Saada


Kumar Gala-3 wrote:

 This is a series of patches that are a work-in-progress towards a new
 DDR initialization for the Freescale 8{3,5,6}xxx devices that have a
 common DDR controller.

(Sorry for the previous no subject message - hit the send too soon...)
Kumar,
Does this RFC also include support for identifying and initializing more than 
one DDR module?
David.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] make creation of nand bad block table optional

2008-07-06 Thread Harald Welte
[PATCH] add new NAND_DONT_CRATE_BBT flag

This patch makes creation of the BBT optional.

It adds a new platform-independent NAND-wide flag NAND_DONT_CREATE_BBT

This flag can be used by the board_nand_init function of a board.  It is used
by the soon-to-be-submitted board support code for various openmoko products.

Signed-off-by: Werner Almesberger [EMAIL PROTECTED]
Signed-off-by: Harald Welte [EMAIL PROTECTED]

---

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index 748b266..27d5988 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -678,7 +678,8 @@ static int check_create (struct mtd_info *mtd, uint8_t 
*buf, struct nand_bbt_des
}
 create:
/* Create the bad block table by scanning the device ? */
-   if (!(td-options  NAND_BBT_CREATE))
+   if (!(td-options  NAND_BBT_CREATE) ||
+ (this-options  NAND_DONT_CREATE_BBT))
continue;
 
/* Create the table in memory by scanning the chip(s) */
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 4cc4a7d..698ab2b 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -187,7 +187,8 @@ extern int nand_read_raw (struct mtd_info *mtd, uint8_t 
*buf, loff_t from, size_
  * This can only work if we have the ecc bytes directly behind the
  * data bytes. Applies for DOC and AG-AND Renesas HW Reed Solomon generators */
 #define NAND_HWECC_SYNDROME0x0002
-
+/* Do not create an BBT if none is found. Overrides NAND_BBT_CREATE. */
+#define NAND_DONT_CREATE_BBT   0x0004
 
 /* Options set by nand scan */
 /* Nand scan has allocated oob_buf */

-- 
- Harald Welte [EMAIL PROTECTED]   http://laforge.gnumonks.org/

Privacy in residential applications is a desirable marketing option.
  (ETSI EN 300 175-7 Ch. A6)


signature.asc
Description: Digital signature
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] add explicit bbt creation to commandline

2008-07-06 Thread Harald Welte
[PATCH] add explicit bbt creation to commandline (nand createbbt command)

This patch adds user-requested BBT creation. It includes the following changes:

- common/cmd_nand.c: move yes/no decision to separate function
- do_nand: ask for confirmation for nand erase
- do_nand: add command nand createbbt to erase NAND and create a new BBT

Signed-off-by: Werner Almesberger [EMAIL PROTECTED]
Signed-off-by: Harald Welte [EMAIL PROTECTED]

---

diff --git a/common/cmd_nand.c b/common/cmd_nand.c
index bb46f34..2f41157 100644
--- a/common/cmd_nand.c
+++ b/common/cmd_nand.c
@@ -162,6 +162,17 @@ out:
return 0;
 }
 
+static int yes(void)
+{
+   char c;
+
+   c = getc();
+   if (c != 'y'  c != 'Y')
+   return 0;
+   c = getc();
+   return c == '\r' || c == '\n';
+}
+
 int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 {
int i, dev, ret;
@@ -231,7 +242,8 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char 
*argv[])
strncmp(cmd, read, 4) != 0  strncmp(cmd, write, 5) != 0 
strcmp(cmd, scrub) != 0  strcmp(cmd, markbad) != 0 
strcmp(cmd, biterr) != 0 
-   strcmp(cmd, lock) != 0  strcmp(cmd, unlock) != 0 )
+   strcmp(cmd, lock) != 0  strcmp(cmd, unlock) != 0 
+   strcmp(cmd, createbbt) != 0 )
goto usage;
 
/* the following commands operate on the current device */
@@ -286,13 +298,23 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char 
*argv[])
 are sure of what you are doing!\n
 \nReally scrub this NAND flash? y/N\n);
 
-   if (getc() == 'y'  getc() == '\r') {
+   if (yes()) {
opts.scrub = 1;
} else {
puts(scrub aborted\n);
return -1;
}
}
+   else {
+   if (opts.length == nand-size) {
+   puts(Really erase everything ? y/N\n);
+   if (!yes()) {
+   puts(erase aborted\n);
+   return -1;
+   }
+   }
+   }
+
ret = nand_erase_opts(nand, opts);
printf(%s\n, ret ? ERROR : OK);
 
@@ -461,6 +483,33 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char 
*argv[])
return 0;
}
 
+   if (strcmp(cmd, createbbt) == 0) {
+   struct nand_chip *nand_chip = nand-priv;
+   nand_erase_options_t opts;
+
+   puts(Create BBT and erase everything ? y/N\n);
+   if (!yes()) {
+   puts(createbbt aborted\n);
+   return -1;
+   }
+   memset(opts, 0, sizeof(opts));
+   opts.length = nand-size;
+   if (nand_erase_opts(nand, opts)) {
+   puts(Erase failed\n);
+   return 1;
+   }
+   nand_chip-options = ~NAND_DONT_CREATE_BBT;
+   puts(Creating BBT. Please wait ...);
+   if (nand_default_bbt(nand)) {
+   puts(\nFailed\n);
+   return 1;
+   }
+   else {
+   puts(\n);
+   return 0;
+   }
+   }
+
 usage:
printf(Usage:\n%s\n, cmdtp-usage);
return 1;
@@ -481,7 +530,8 @@ U_BOOT_CMD(nand, 5, 1, do_nand,
nand markbad off - mark bad block at offset (UNSAFE)\n
nand biterr off - make a bit error at offset (UNSAFE)\n
nand lock [tight] [status] - bring nand to lock state or display 
locked pages\n
-   nand unlock [offset] [size] - unlock section\n);
+   nand unlock [offset] [size] - unlock section\n
+   nand createbbt - create bad block table\n);
 
 static int nand_load_image(cmd_tbl_t *cmdtp, nand_info_t *nand,
   ulong offset, ulong addr, char *cmd)
diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index 27d5988..3fdc25a 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -795,7 +795,8 @@ int nand_scan_bbt (struct mtd_info *mtd, struct 
nand_bbt_descr *bd)
 
len = mtd-size  (this-bbt_erase_shift + 2);
/* Allocate memory (2bit per block) */
-   this-bbt = kmalloc (len, GFP_KERNEL);
+   if (!this-bbt)
+   this-bbt = kmalloc (len, GFP_KERNEL);
if (!this-bbt) {
printk (KERN_ERR nand_scan_bbt: Out of memory\n);
return -ENOMEM;
-- 
- Harald Welte [EMAIL PROTECTED]   http://laforge.gnumonks.org/

Privacy in residential applications is a desirable marketing 

[U-Boot-Users] [PATCH, resend] FDT memory and pci node fixes for MPC8260ADS

2008-07-06 Thread Matvejchikov Ilya
Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED]
---
 board/freescale/mpc8260ads/mpc8260ads.c |   27 +++
 cpu/mpc8260/pci.c   |   12 
 include/configs/MPC8260ADS.h|7 +++
 3 files changed, 46 insertions(+), 0 deletions(-)

diff --git a/board/freescale/mpc8260ads/mpc8260ads.c
b/board/freescale/mpc8260ads/mpc8260ads.c
index 6f683f0..8ab7d35 100644
--- a/board/freescale/mpc8260ads/mpc8260ads.c
+++ b/board/freescale/mpc8260ads/mpc8260ads.c
@@ -46,6 +46,10 @@
 #ifdef CONFIG_PCI
 #include pci.h
 #endif
+#ifdef CONFIG_OF_LIBFDT
+#include libfdt.h
+#include fdt_support.h
+#endif

 /*
  * I/O Port configuration table
@@ -544,3 +548,26 @@ void pci_init_board(void)
pci_mpc8250_init(hose);
 }
 #endif
+
+#if defined(CONFIG_OF_LIBFDT)  defined(CONFIG_OF_BOARD_SETUP)
+void ft_blob_update(void *blob, bd_t *bd)
+{
+   int ret;
+
+   ret = fdt_fixup_memory(blob, (u64)bd-bi_memstart, (u64)bd-bi_memsize);
+
+   if (ret  0) {
+   printf(ft_blob_update(): cannot set /memory/reg 
+   property err:%s\n, fdt_strerror(ret));
+   }
+}
+
+void ft_board_setup(void *blob, bd_t *bd)
+{
+   ft_cpu_setup(blob, bd);
+#ifdef CONFIG_PCI
+   ft_pci_setup(blob, bd);
+#endif
+   ft_blob_update(blob, bd);
+}
+#endif
diff --git a/cpu/mpc8260/pci.c b/cpu/mpc8260/pci.c
index 75c6ab2..940f5c0 100644
--- a/cpu/mpc8260/pci.c
+++ b/cpu/mpc8260/pci.c
@@ -33,6 +33,10 @@
 #include mpc8260.h
 #include asm/m8260_pci.h
 #include asm/io.h
+#ifdef CONFIG_OF_LIBFDT
+#include libfdt.h
+#include fdt_support.h
+#endif

 #if defined CONFIG_MPC8266ADS || defined CONFIG_MPC8272 || defined CONFIG_PM826
 DECLARE_GLOBAL_DATA_PTR;
@@ -449,4 +453,12 @@ void pci_mpc8250_init (struct pci_controller *hose)
immap-im_pci.pci_emr |= cpu_to_le32 (PCI_ERROR_PCI_NO_RSP);
 }

+#if defined(CONFIG_OF_LIBFDT)
+void ft_pci_setup(void *blob, bd_t *bd)
+{
+   do_fixup_by_prop_u32(blob, device_type, pci, 4,
+   clock-frequency, bd-pci_clk, 1);
+}
+#endif
+
 #endif /* CONFIG_PCI */
diff --git a/include/configs/MPC8260ADS.h b/include/configs/MPC8260ADS.h
index 23508f9..59d0bdb 100644
--- a/include/configs/MPC8260ADS.h
+++ b/include/configs/MPC8260ADS.h
@@ -197,6 +197,13 @@

 #define CONFIG_BAUDRATE115200

+#define CONFIG_OF_LIBFDT   1
+#define CONFIG_OF_BOARD_SETUP  1
+#if defined(CONFIG_OF_LIBFDT)
+#define OF_CPU [EMAIL PROTECTED]
+#define OF_TBCLK   (bd-bi_busfreq / 4)
+#endif
+
 /*
  * BOOTP options
  */
-- 
1.5.6.1

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot commandline

2008-07-06 Thread Wolfgang Denk
Dear Harald,

in message [EMAIL PROTECTED] you wrote:
 
 [PATCH] add 'license' command to u-boot command line
 
 The 'license' command includes the u-boot license (GPLv2) into the actual
 bootloader binary.  The license text can be shown interactively at the u-boot
 commandline.

When we started working on this boot loader (by then still under  the
name  8xxrom  or  maybe already PPCBoot, I don't remember exactly any
more) we decided not to implement such a feature because  of  (flash)
memory footprint reasons.

I still feel this is pretty heavy in terms of memory footprint versus
benefit ratio.

 For products where the commandline can actually be accessed by the end user,
 this helps to prevent inadvertent GPL violations, since the GPLv2 license text
 can no longer be 'forgotten' to be included into the product.
 
 The 'license' command can be enabled by CONFIG_CMD_LICENSE.

Well, I bet 9:1 that some vendors (and I guess you and me know a  few
of   them   pretty   well)   may   simply   forget  to  enable  the
CONFIG_CMD_LICENSE option, or they ship  U-Boot  in  a  configuration
where access to an interactive console interface is difficult or even
impossible (completely unintentionally, of course).

So the benefit in such cases is really small,  especially  since  the
License  text  cannot  be  found  easily in the binary image (as it's
compressed).


So I have to admit that I'm realy biased here. Let's see what other's
say.

...
 diff --git a/include/license.h b/include/license.h
 new file mode 100644
 index 000..7a638eb
 --- /dev/null
 +++ b/include/license.h
 @@ -0,0 +1,583 @@
 +/* bin2header converting 'gpl.gz' */
 +unsigned char gpl_gz[] = {
 + 0x1f, 0x8b, 0x08, 0x08, 0xb2, 0x10, 0x0d, 0x46, 0x00, 0x03,
 + 0x67, 0x70, 0x6c, 0x00, 0x9d, 0x5b, 0x5d, 0x77, 0xdb, 0x46,
 + 0x92, 0x7d, 0x4e, 0xff, 0x8a, 0x3e, 0x7e, 0x89, 0x74, 0x0e,
...
 + 0xed, 0x4e, 0x3f, 0xa2, 0x44, 0x9f, 0x3f, 0xb3, 0xbd, 0x6f,
 + 0xfe, 0x17, 0x84, 0xf3, 0x1b, 0xef, 0x12, 0x3b, 0x00, 0x00,
 +};

But I definitely object against such a binary, i. e. unreadable copy
of some license which nobody can check, and which quickly gets out of
sync with the COPYING file included with the source code.

If we add such a command, I insist  that  the  included  (compressed)
licenzse  text  must  be  generated on the fly from the COPYING file,
i. e. I will reject all attempts that cause two (probably  different)
copies of the license text included with U-Boot.

Um... while we are at it - maybe we should  clean  up  /  update  the
license headers a bit...

Um... thinking more about this I guess we should create a ToDo page
in the U-Boot wiki listing things that need to be done - some of them
are pure janitor work and could be picked up by volunteers even  with
limited experience with U-Boot but with free resources?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Anarchy may not be the best form of government, but it's better  than
no government at all.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Magnus Lilja
Wolfgang,

  4000  06/18 Magnus Lilja   [U-Boot-Users] i.MX31: mx31_gpio_mux() problem
- do nothing; waiting for resubmit


I submitted  patches to this problem in two posts with the following subjects:
[PATCH 1/2] i.MX31: Fix IOMUX related typos (June 23:rd)
[PATCH 2/2] i.MX31: Fix mx31_gpio_mux() function and MUX_-macros.  (June 23:rd)

http://www.nabble.com/-PATCH-1-2--i.MX31%3A-Fix-IOMUX-related-typos.-to18073906.html
http://www.nabble.com/-PATCH-2-2--i.MX31%3A-Fix-mx31_gpio_mux%28%29-function-and-MUX_-macros.-to18073932.html


Thanks, Magnus

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH, resend] Some copy-n-paste fixes in printf usage

2008-07-06 Thread Matvejchikov Ilya
Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED]
---
 board/cm5200/cm5200.c   |2 +-
 board/ids8247/ids8247.c |2 +-
 board/mgcoge/mgcoge.c   |6 +++---
 board/mgsuvd/mgsuvd.c   |8 
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/board/cm5200/cm5200.c b/board/cm5200/cm5200.c
index 3e952d8..24e8db0 100644
--- a/board/cm5200/cm5200.c
+++ b/board/cm5200/cm5200.c
@@ -275,7 +275,7 @@ static void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_fixup_memory(blob, (u64)bd-bi_memstart, (u64)bd-bi_memsize);

if (ret  0) {
-   printf(ft_blob_update): cannot set /memory/reg 
+   printf(ft_blob_update(): cannot set /memory/reg 
property err:%s\n, fdt_strerror(ret));
}
 }
diff --git a/board/ids8247/ids8247.c b/board/ids8247/ids8247.c
index 8ec4cd7..44fc79c 100644
--- a/board/ids8247/ids8247.c
+++ b/board/ids8247/ids8247.c
@@ -334,7 +334,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_fixup_memory(blob, (u64)bd-bi_memstart, (u64)bd-bi_memsize);

if (ret  0) {
-   printf(ft_blob_update): cannot set /memory/reg 
+   printf(ft_blob_update(): cannot set /memory/reg 
property err:%s\n, fdt_strerror(ret));
}
 }
diff --git a/board/mgcoge/mgcoge.c b/board/mgcoge/mgcoge.c
index 89ced1e..51b6dc6 100644
--- a/board/mgcoge/mgcoge.c
+++ b/board/mgcoge/mgcoge.c
@@ -307,7 +307,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, reg, memory_data,
sizeof(memory_data));
if (ret  0)
-   printf(ft_blob_update): cannot set /memory/reg 
+   printf(ft_blob_update(): cannot set /memory/reg 
property err:%s\n, fdt_strerror(ret));
}
else {
@@ -327,7 +327,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, ranges, flash_data,
sizeof(flash_data));
if (ret  0)
-   printf(ft_blob_update): cannot set /localbus/ranges 
+   printf(ft_blob_update(): cannot set /localbus/ranges 
property err:%s\n, fdt_strerror(ret));
}
else {
@@ -341,7 +341,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, mac-address, 
bd-bi_enetaddr,
sizeof(uchar) * 6);
if (ret  0)
-   printf(ft_blob_update): cannot set 
/soc/cpm/ethernet/mac-address 
+   printf(ft_blob_update(): cannot set 
/soc/cpm/ethernet/mac-address 
property err:%s\n, fdt_strerror(ret));
}
else {
diff --git a/board/mgsuvd/mgsuvd.c b/board/mgsuvd/mgsuvd.c
index d81cafb..c51ea7e 100644
--- a/board/mgsuvd/mgsuvd.c
+++ b/board/mgsuvd/mgsuvd.c
@@ -164,7 +164,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, reg, memory_data,
sizeof(memory_data));
if (ret  0)
-   printf(ft_blob_update): cannot set /memory/reg 
+   printf(ft_blob_update(): cannot set /memory/reg 
property err:%s\n, fdt_strerror(ret));
}
else {
@@ -180,7 +180,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, ranges, flash_data,
sizeof(flash_data));
if (ret  0)
-   printf(ft_blob_update): cannot set /localbus/ranges 
+   printf(ft_blob_update(): cannot set /localbus/ranges 
property err:%s\n, fdt_strerror(ret));
}
else {
@@ -195,7 +195,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, brg-frequency, brg_data,
sizeof(brg_data));
if (ret  0)
-   printf(ft_blob_update): cannot set /soc/cpm/brg-frequency 
+   printf(ft_blob_update(): cannot set /soc/cpm/brg-frequency 
property err:%s\n, fdt_strerror(ret));
}
else {
@@ -209,7 +209,7 @@ void ft_blob_update(void *blob, bd_t *bd)
ret = fdt_setprop(blob, nodeoffset, mac-address, 
bd-bi_enetaddr,
sizeof(uchar) * 6);
if (ret  0)
-   printf(ft_blob_update): cannot set /soc/cpm/scc/mac-address 
+   printf(ft_blob_update(): cannot set /soc/cpm/scc/mac-address 
property err:%s\n, fdt_strerror(ret));
}
else {
-- 
1.5.6.1

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your 

Re: [U-Boot-Users] [PATCH]: Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.

2008-07-06 Thread Joakim Tjernlund

On Sun, 2008-07-06 at 00:32 +0200, Wolfgang Denk wrote:
 In message [EMAIL PROTECTED] you wrote:
  
   So what *is* the state of this?
   
   If nobody responds soon, I will indeed re-apply that patch, andthen I
   will not revert this commit again. So if you think this bytes you,
   please speak up *now*.
   
   Jock, would you please send me a reminder in a week or so? Thanks.
  
  About week has passed so here is the reminder :)
 
 Unfortunately, the original patch does not apply any more; could you
 please rebase and resubmit it?  Thanks in advance.

From ba9ae2fb5f10f2a6c2b7635d27e70c77f7b068cb Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund [EMAIL PROTECTED]
Date: Sun, 6 Jul 2008 12:24:18 +0200
Subject: [PATCH] Change env_get_char from a global function ptr to a function

This avoids an early global data reference

Signed-off-by: Joakim Tjernlund [EMAIL PROTECTED]
---

OK, here it is again. I am on vacation now so I have only compile tested
this version.

 common/env_common.c   |   19 +--
 include/environment.h |4 ++--
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/common/env_common.c b/common/env_common.c
index e6df9a5..5ac14e8 100644
--- a/common/env_common.c
+++ b/common/env_common.c
@@ -50,7 +50,6 @@ extern void env_relocate_spec (void);
 extern uchar env_get_char_spec(int);
 
 static uchar env_get_char_init (int index);
-uchar (*env_get_char)(int) = env_get_char_init;
 
 /
  * Default settings to be used when no valid environment is found
@@ -183,6 +182,19 @@ uchar env_get_char_memory (int index)
 }
 #endif
 
+uchar env_get_char (int index)
+{
+   uchar c;
+
+   /* if relocated to RAM */
+   if (gd-flags  GD_FLG_RELOC)
+   c = env_get_char_memory(index);
+   else
+   c = env_get_char_init(index);
+
+   return (c);
+}
+
 uchar *env_get_addr (int index)
 {
if (gd-env_valid) {
@@ -216,11 +228,6 @@ void env_relocate (void)
DEBUGF (%s[%d] malloced ENV at %p\n, __FUNCTION__,__LINE__,env_ptr);
 #endif
 
-   /*
-* After relocation to RAM, we can always use the memory functions
-*/
-   env_get_char = env_get_char_memory;
-
if (gd-env_valid == 0) {
 #if defined(CONFIG_GTH)|| defined(CFG_ENV_IS_NOWHERE)  /* Environment 
not changable */
puts (Using default environment\n\n);
diff --git a/include/environment.h b/include/environment.h
index bf9f669..dcb7c5a 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -107,8 +107,8 @@ typedef struct environment_s {
unsigned char   data[ENV_SIZE]; /* Environment data */
 } env_t;
 
-/* Pointer to function that returns a character from the environment */
-extern unsigned char (*env_get_char)(int);
+/* Function that returns a character from the environment */
+unsigned char env_get_char (int);
 
 /* Function that returns a pointer to a value from the environment */
 unsigned char *env_get_addr(int);
-- 
1.5.6.1



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot commandline

2008-07-06 Thread Harald Welte
Hi Wolfgang!

On Sun, Jul 06, 2008 at 12:11:05PM +0200, Wolfgang Denk wrote:

 in message [EMAIL PROTECTED] you wrote:
  
  [PATCH] add 'license' command to u-boot command line
  
  The 'license' command includes the u-boot license (GPLv2) into the actual
  bootloader binary.  The license text can be shown interactively at the 
  u-boot
  commandline.
 
 When we started working on this boot loader (by then still under  the
 name  8xxrom  or  maybe already PPCBoot, I don't remember exactly any
 more) we decided not to implement such a feature because  of  (flash)
 memory footprint reasons.

Well, the same argument holds true for many other of u-boot's features.
However, they still get implemented, and the compilation/inclusion in
the (flash) image therefore is optional.  Users who don't want it, get
zero additional benefit.

 I still feel this is pretty heavy in terms of memory footprint versus
 benefit ratio.

that is probably from your point of view.

While I was working for OpenMoko, from a vendor perspective of a company
that wants to make 100% sure that the GPL is always followed, this kind
of feature makes a lot of sense.  Even if you just put a u-boot binary
on some ftp server (without the GPL text next to it) you still don't
risk any GPL infringement.

  For products where the commandline can actually be accessed by the end user,
  this helps to prevent inadvertent GPL violations, since the GPLv2 license 
  text
  can no longer be 'forgotten' to be included into the product.
  
  The 'license' command can be enabled by CONFIG_CMD_LICENSE.
 
 Well, I bet 9:1 that some vendors (and I guess you and me know a  few
 of   them   pretty   well)   may   simply   forget  to  enable  the
 CONFIG_CMD_LICENSE option, or they ship  U-Boot  in  a  configuration
 where access to an interactive console interface is difficult or even
 impossible (completely unintentionally, of course).

this is perfectly true.  I'm not saying that this patch is a
fire-and-forget solution for all device manufacturers.  I'm simply
saying that this solved a practical problem for OpenMoko.  It's a
straight-forward patch that doesn't impact any existing code or files,
and it comes at zero footprint impact if you don't want it.

 So the benefit in such cases is really small,  especially  since  the
 License  text  cannot  be  found  easily in the binary image (as it's
 compressed).

well, it's supposed to offer the license text at the command line, not
in the memory image..

 So I have to admit that I'm realy biased here. Let's see what other's
 say.

Ok.  I'm also waiting for the feedback of others.  Please keep in mind
tha this is a zero-maintenance patch that doesn't affect any existing
code.  So even while you might think the feature is esoteric, it is a
very painless feature to add.

 But I definitely object against such a binary, i. e. unreadable copy
 of some license which nobody can check, and which quickly gets out of
 sync with the COPYING file included with the source code.
 
 If we add such a command, I insist  that  the  included  (compressed)
 licenzse  text  must  be  generated on the fly from the COPYING file,
 i. e. I will reject all attempts that cause two (probably  different)
 copies of the license text included with U-Boot.

Ok, I agree.  Let's wait for the further comments on the list.  If I
have the feeling that such a feature would be accepted, I'll re-work the
patch to include a script and makefile hooks to generate the header file
with the compressed license text on-the-fly while compiling u-boot.

Regards,
-- 
- Harald Welte [EMAIL PROTECTED]   http://laforge.gnumonks.org/

Privacy in residential applications is a desirable marketing option.
  (ETSI EN 300 175-7 Ch. A6)


signature.asc
Description: Digital signature
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:42 Sun 06 Jul , Shinya Kuribayashi wrote:
 Wolfgang Denk wrote:
  Hm... Are you absolutely sure your changes, especially the
  CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not
  cause any trouble on any systems?
 
 [...]
 
  It seems not obvious to me that your change is  really  harmless,  or
  tested.
  
  Could you please comment?
 
 Carefully reviewed as much as I could, but yes it's not fully tested.
 I only did some build tests before patch submission.
 
 I expect all board config files, which have one of the existing ethernet
 driver config, already have CONFIG_CMD_NET and CONFIG_NET_MULTI, too.
 But even if that is the case, there still might be some build breakage.
 
I've found an error on ARM, I'll send a patch about it soon.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] add explicit bbt creation to commandline

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:04 Sun 06 Jul , Harald Welte wrote:
 [PATCH] add explicit bbt creation to commandline (nand createbbt command)
 
 This patch adds user-requested BBT creation. It includes the following 
 changes:
 
 - common/cmd_nand.c: move yes/no decision to separate function
 - do_nand: ask for confirmation for nand erase
 - do_nand: add command nand createbbt to erase NAND and create a new BBT
 
 Signed-off-by: Werner Almesberger [EMAIL PROTECTED]
 Signed-off-by: Harald Welte [EMAIL PROTECTED]
 
 ---
 
 diff --git a/common/cmd_nand.c b/common/cmd_nand.c
 index bb46f34..2f41157 100644
 --- a/common/cmd_nand.c
 +++ b/common/cmd_nand.c
 @@ -162,6 +162,17 @@ out:
   return 0;
  }
  
 +static int yes(void)
 +{
 + char c;
 +
 + c = getc();
 + if (c != 'y'  c != 'Y')
 + return 0;
 + c = getc();
 + return c == '\r' || c == '\n';
 +}
 +
It will be good to have it in a re-usable header as inline.

And why not name it as ask_confirm()?

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 0/3] Move atmel_mci driver into drivers/mmc

2008-07-06 Thread Haavard Skinnemoen
On Sun, 06 Jul 2008 00:32:03 +0200
Wolfgang Denk [EMAIL PROTECTED] wrote:

 Will you apply this in your repo and send me a pull request, or do you
 want me to pick this up directly?

Please pick it up directly. I'm on vacation, so it may take some time
before I get around to pushing it anywhere.

Haavard

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 04/10] [ARM] TQMA31: add new board with i.MX31 processor

2008-07-06 Thread Magnus Lilja
Hi again

 diff --git a/board/tqc/tqma31/Makefile b/board/tqc/tqma31/Makefile
 new file mode 100644
 index 000..ed403e8
 --- /dev/null
 +++ b/board/tqc/tqma31/Makefile
 @@ -0,0 +1,48 @@
 +#
 +# Copyright (C) 2008, Guennadi Liakhovetski [EMAIL PROTECTED]
 +# Copyright (C) 2008, Jens Gehrlein [EMAIL PROTECTED]
 +#
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB= $(obj)lib$(BOARD).a
 +
 +COBJS  := tqma31.o
 +SOBJS  := lowlevel_init.o
 +
 +SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 +OBJS   := $(addprefix $(obj),$(COBJS))
 +SOBJS  := $(addprefix $(obj),$(SOBJS))
 +
 +$(LIB):$(obj).depend $(OBJS) $(SOBJS)
 +   $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
 +
 +clean:
 +   rm -f $(SOBJS) $(OBJS)
 +
 +distclean: clean
 +   rm -f $(LIB) core *.bak .depend

The .depend file needs a $(obj)-prefix here (Wolfgang recenty
corrected this in a number of Makefiles):
rm -f $(LIB) core *.bak $(obj).depend

Regards, Magnus

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 01:05 Sun 06 Jul , Wolfgang Denk wrote:
 Hi everybody,
 
 here is a summary of the current state of my processing of patches
 that have been submitted for the upcoming 1.3.4 release.
 
 As you might have noticed, I've been on vacation for the last two
 weeks, and I spent this time (intentionally) completely offline. So
 please apologize if parts of the following comments / questions have
 been obsoleted by recent events - I will try to catch up as soon as
 possible, but I think it is better to send out this summary now,
 i. e. _before_ I start reading he backlog of the last two weeks.
 
 
 Here is a list of patches I had marked as open in my list, with
 comments about their state, including comments who I consider to be
 responsible for further progress:

Thanks about it.
  2536  05/20 Sergey Lapin   [U-Boot-Users] [PATCH] DataFlash AT45DB021 
 support
  2618  05/21 Sergey Lapin Re: [U-Boot-Users] [PATCH] DataFlash 
 AT45DB021 support
  2836  05/26 Sergey Lapin   [U-Boot-Users] [AT91] Re: [PATCH] DataFlash 
 AT45DB021 support
  2840  05/26 Matt Gessner Re: [U-Boot-Users] [AT91] Re: [PATCH] 
 DataFlash AT45DB021 support
  2945  05/29 Sergey Lapin   Re: [U-Boot-Users] [AT91] Re: [PATCH] 
 DataFlash AT45DB021 support
  3371  06/05 Sergey Lapin   [U-Boot-Users] [PATCH][AT91][Re-submit] 
 DataFlash AT45DB021 support
  3923  06/17 Sergey Lapin   Re: [U-Boot-Users] [PATCH][AT91][Re-submit] 
 DataFlash AT45DB021 support
   - for AT91 custodian
  2629  05/21 Christian Eggers  [U-Boot-Users] [Patch] Configure SMC for a 
 second flash device if required
   - for AT91 custodian
 
  2649  05/22 Stelian Pop[U-Boot-Users] [PATCH] Fix boot from NOR due 
 to incorrect reset delay.
   - for AT91 custodian
Already send a pull-request about it
 
  2660  05/22 Haavard Skinnemoe  [PATCH v2] MMC: Consolidate MMC/SD command 
 definitions
   - applied
 
  2663  05/22 Haavard Skinnemoe  [U-Boot-Users] [PATCH] avr32: Fix wrong error 
 flags in atmel_mci driver
   - already applied
 
  2664  05/22 Sergey Lapin   [U-Boot-Users] [PATCH][Re-Submit] DataFlash 
 AT45DB021 support
   - for AT91 custodian
I've plan to add it for the 1.3.5 but I will do it for the 1.3.4
 
  2688  05/22 Jean-Christophe P  Re: [U-Boot-Users] [PATCH 18/26] Make 
 nand_init() return the detected NAND size
  2694  05/22 Scott Wood Re: [U-Boot-Users] [PATCH 18/26] Make 
 nand_init() return the detected NAND size
   - for AT91 custodian
drop by the author
 
 
  2786  05/24 Jean-Christophe P  [U-Boot-Users] [PATCH] MAKEALL: add at91 list
   - asked submitter for fixes / cleanup
I will send a fix patch
 
  2802  05/24 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 06/18] avr32: Add 
 support for the ATSTK1006 board
  2803  05/24 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 05/18] avr32: Get 
 rid of the .flashprog section
  2831  05/26 Haavard Skinnemoe  [U-Boot-Users] [PATCH] avr32: Fix theoretical 
 race in udelay()
  2833  05/26 Haavard Skinnemoe  [PATCH v4 1/3] Move definition of 
 container_of() to common.h
  2834  05/26 Haavard Skinnemoe  [PATCH v4 2/3] SPI API improvements
  2835  05/26 Haavard Skinnemoe  [PATCH v4 3/3] atmel_spi: Driver for the 
 Atmel SPI controller
   - already applied
 
  2853  05/27 Jean-Christophe P  [U-Boot-Users] [PATCH] [AT91SAM9] Fix NAND 
 FLASH timings
   - for AT91 custodian
Already send a pull-request
 
  2858  05/27 wangjiankun820624  [U-Boot-Users] MIPS: about the function of 
 the octeon_twsi_set_addr8
   - for MIPS custodian
 
  3652  06/11 Antonio R. Costa  [U-Boot-Users] [PATCH 5/6] AT572D940HF-EB 
 Support
  3653  06/11 Antonio R. Costa  [U-Boot-Users] [PATCH 6/6] AT572D940HF-EB 
 Support
  3654  06/11 Antonio R. Costa  [U-Boot-Users] [PATCH 1/3] SDHC Support for 
 AT572d940HF-EB
  3733  06/12 Ulf Samuelsson   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3735  06/12 COSTA, Antonio   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3737  06/12 Ulf Samuelsson   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3739  06/12 Jerry Van BarenRe: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3859  06/15 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3897  06/16 [EMAIL PROTECTED]  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3899  06/17 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3740  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 1/6] AT572D940HF-EB 
 Support v2 (board folder)
  3741  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 2/2] AT572D940HF-EB 
 Support v2 (SDHC support part 2)
  3742  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB 
 Support v2 (SDHC support part 1)
  3743  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 3/6] AT572D940HF-EB 
 Support v2 (include files part 1)
  3744  06/12 Antonio R. Costa  [U-Boot-Users] 

Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Nobuhiro Iwamatsu
Hi, Wolfgang.

On Sun, 06 Jul 2008 01:05:40 +0200
Wolfgang Denk [EMAIL PROTECTED] wrote:

  3910  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 1/9] sh: Cleanup source 
 code of MS7720SE
  3911  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 2/9] sh: Cleanup source 
 code of MS7722SE
  3912  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 4/9] sh: Cleanup source 
 code of R2DPlus
  3913  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 3/9] sh: Cleanup source 
 code of R7780MP
  3914  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 5/9] sh: Cleanup source 
 code of SH7763RDP
  3915  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 6/9] sh: Update Hitachi 
 MS7722SE board
  3916  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 7/9] sh: Update Renesas 
 Migo-R board
  3917  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 8/9] sh: Update Renesas 
 R7780MP board
  3918  06/17 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH 9/9] sh: Update Renesas 
 R2DPlus board
   - for SH custodian
Already applied.
I plan to request-pull later.

Best regards,
 Nobuhiro

-- 
Nobuhiro Iwamatsu

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [AT91] Re: [PATCH] DataFlash AT45DB021 support

2008-07-06 Thread Matt Gessner
On Sat, Jul 5, 2008 at 6:32 PM, Wolfgang Denk [EMAIL PROTECTED] wrote:

 In message [EMAIL PROTECTED] you wrote:
  I added code to handle the 011 chip, but I really didn't think anyone
  would be interested in it.

 I think all such changes should get added to the public repository.

  If someone wants it, I can post it.

 Please do.

When I get to work on Monday, I will have to synch to the latest
u-boot, and then I'll post a patch for the 011 chip.  It's really
quite trivial.

Regards,

Matt Gessner

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] 85xx: extended cpu identification

2008-07-06 Thread Kumar Gala

On Jul 5, 2008, at 5:32 PM, Wolfgang Denk wrote:

 In message Pine.LNX. 
 [EMAIL PROTECTED] you wrote:
 The current cpu identification code is used just to return the name
 of the processor at boot.  There are some other locations that the  
 name
 is useful (device tree setup).

 Also, we add a feature field to convey useful attributes of the  
 processor.

 (for 85xx we have a single feature to tell if the processor has a  
 crypto
 engine or not).

 Signed-off-by: Kumar Gala [EMAIL PROTECTED]
 ---
 cpu/mpc85xx/cpu.c   |   77 + 
 +
 include/asm-ppc/processor.h |   13 +++
 2 files changed, 53 insertions(+), 37 deletions(-)

 There was some discussion about this patch, but I don't see an updated
 version posted, nor was it picked up (and fixed) by the custodian.

 So what's the state of this patch?

this was reworked and accepted by Andy and in both mainline and his  
85xx tree.

- k

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH, resend] Support dynamic/patched NAND ENV offset

2008-07-06 Thread Harald Welte
Hi!

I've first sent this on Feb 17, 2007.  Unfortunately no reply was
received.  I think this is a quite useful feature, since a compile time
offset into the NAND flash for the environment just doesn't work well
with bad blocks ;)

This is the current version of the patch.  I'd love to see it included.
Thanks!

---

This patch adds support for CFG_ENV_OFFSET_PATCHED and 
CFG_ENV_OFFSET_OOB.

Both try to solve the problem of fixing the environment location in NAND flash
at compile time, which doesn't work well if the NAND flash has a bad block at
exactly that location.

CFG_ENV_OFFSET_PATCHED puts the environment in a global variable.  You can then
use the linker script to put that variable to a fixed location in the u-boot
image.  Then you can use bianry patching during the production flash process.

The idea of CFG_ENV_OFFSET_OOB is to store the environment offset in the NAND
OOB data of block 0.  We can do this in case the vendor makes a guarantee that
block 0 never is a factory-default bad block. 

Signed-off-by: Harald Welte [EMAIL PROTECTED]

Index: u-boot/common/Makefile
===
--- u-boot.orig/common/Makefile
+++ u-boot/common/Makefile
@@ -55,6 +55,7 @@
 COBJS-$(CONFIG_CMD_DISPLAY) += cmd_display.o
 COBJS-$(CONFIG_CMD_DOC) += cmd_doc.o
 COBJS-$(CONFIG_CMD_DTT) += cmd_dtt.o
+COBJS-y += cmd_dynenv.o
 COBJS-y += cmd_eeprom.o
 COBJS-$(CONFIG_CMD_ELF) += cmd_elf.o
 COBJS-$(CONFIG_CMD_EXT2) += cmd_ext2.o
Index: u-boot/common/cmd_dynenv.c
===
--- /dev/null
+++ u-boot/common/cmd_dynenv.c
@@ -0,0 +1,106 @@
+/*
+ * (C) Copyright 2006-2007 OpenMoko, Inc.
+ * Author: Harald Welte [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include command.h
+#include malloc.h
+#include environment.h
+#include nand.h
+#include asm/errno.h
+#include cmd_nand.h
+
+#if defined(CFG_ENV_OFFSET_OOB)
+
+int do_dynenv(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+   struct mtd_info *mtd = nand_info[0];
+   int ret, size = 8;
+   uint8_t *buf;
+
+   char *cmd = argv[1];
+
+   buf = malloc(mtd-oobsize);
+   if (!buf)
+   return -ENOMEM;
+
+   ret = mtd-read_oob(mtd, 8, size, (size_t *) size, (u_char *) buf);
+   if (!strcmp(cmd, get)) {
+
+   if (buf[0] == 'E'  buf[1] == 'N' 
+   buf[2] == 'V'  buf[3] == '0')
+   printf(0x%08x\n, *((u_int32_t *) buf[4]));
+   else
+   printf(No dynamic environment marker in OOB block 
0\n);
+
+   } else if (!strcmp(cmd, set)) {
+   unsigned long addr, dummy;
+
+   if (argc  3)
+   goto usage;
+
+   buf[0] = 'E';
+   buf[1] = 'N';
+   buf[2] = 'V';
+   buf[3] = '0';
+
+   if (arg_off_size(argc-2, argv+2, mtd, addr, dummy)  0) {
+   printf(Offset or partition name expected\n);
+   goto fail;
+   }
+   if (!ret) {
+   uint8_t tmp[4];
+   int i;
+
+   memcpy(tmp, addr, 4);
+   for (i = 0; i != 4; i++)
+   if (tmp[i]  ~buf[i+4]) {
+   printf(ERROR: erase OOB block to 
+ write this value\n);
+   goto fail;
+   }
+   }
+   memcpy(buf+4, addr, 4);
+
+   printf(%02x %02x %02x %02x - %02x %02x %02x %02x\n,
+   buf[0], buf[1], buf[2], buf[3],
+   buf[4], buf[5], buf[6], buf[7]);
+
+   ret = mtd-write_oob(mtd, 8, size, (size_t *) size, (u_char *) 
buf);
+   if (!ret)
+   CFG_ENV_OFFSET = addr;
+   } else
+   goto usage;
+
+   free(buf);
+   return ret;
+
+usage:
+   printf(Usage:\n%s\n, cmdtp-usage);
+fail:
+   free(buf);
+   return 1;
+}
+
+U_BOOT_CMD(dynenv, 3, 1, do_dynenv,
+   dynenv  - dynamically placed (NAND) environment\n,
+   dynenv set off - set enviromnent 

Re: [U-Boot-Users] [RFC][FSL DDR 0/8] Freescale DDR rewrit

2008-07-06 Thread Kumar Gala

On Jul 6, 2008, at 3:04 AM, David Saada wrote:



 Kumar Gala-3 wrote:

 This is a series of patches that are a work-in-progress towards a  
 new
 DDR initialization for the Freescale 8{3,5,6}xxx devices that have a
 common DDR controller.

 (Sorry for the previous no subject message - hit the send too  
 soon...)
 Kumar,
 Does this RFC also include support for identifying and initializing  
 more than one DDR module?

I'm not sure I follow exactly what you are asking?  Do you mean using  
different DDR modules on different chip selects of the same  
controller?  or something else?

- k

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Request: s3c24xx getting its own start.S file ?

2008-07-06 Thread Harald Welte
I meanwhile realized that the entire makefile system doesn't really cope
with the fact.  So what I'm left with is something along the lines of
the attached patch, where the cpu/arm920t/start.S #includes a
cpu/arm920t/s3c24x0/start.S file.

It's not really nice, but otherwise I assure you anyone touching the
arm920t start.S file again will find itself in #ifdef/endif hell, once
all my s3c24xx related patches would be merged...


Index: u-boot/cpu/arm920t/s3c24x0/start.S
===
--- /dev/null
+++ u-boot/cpu/arm920t/s3c24x0/start.S
@@ -0,0 +1,155 @@
+/*
+ *  armboot - Startup Code for S3C24xx CPU-cores
+ *
+ *  
+ */
+
+
+/* the actual start code */
+
+start_code:
+   /*
+* set the cpu to SVC32 mode
+*/
+   mrs r0,cpsr
+   bic r0,r0,#0x1f
+   orr r0,r0,#0xd3
+   msr cpsr,r0
+
+   bl coloured_LED_init
+   bl red_LED_on
+
+   /* turn off the watchdog */
+
+# if defined(CONFIG_S3C2400)
+#  define pWTCON   0x1530
+#  define INTMSK   0x1448  /* Interupt-Controller base 
addresses */
+#  define CLKDIVN  0x14800014  /* clock divisor register */
+#else
+#  define pWTCON   0x5300
+#  define INTMSK   0x4A08  /* Interupt-Controller base 
addresses */
+#  define INTSUBMSK0x4A1C
+#  define CLKDIVN  0x4C14  /* clock divisor register */
+# endif
+
+   ldr r0, =pWTCON
+   mov r1, #0x0
+   str r1, [r0]
+
+   /*
+* mask all IRQs by setting all bits in the INTMR - default
+*/
+   mov r1, #0x
+   ldr r0, =INTMSK
+   str r1, [r0]
+# if defined(CONFIG_S3C2410)
+   ldr r1, =0x3ff
+   ldr r0, =INTSUBMSK
+   str r1, [r0]
+# endif
+
+   /* FCLK:HCLK:PCLK = 1:2:4 */
+   /* default FCLK is 120 MHz ! */
+   ldr r0, =CLKDIVN
+   mov r1, #3
+   str r1, [r0]
+
+   /*
+* we do sys-critical inits only at reboot,
+* not when booting from ram!
+*/
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+   bl  cpu_init_crit
+#endif
+
+
+#ifndef CONFIG_SKIP_RELOCATE_UBOOT
+relocate:  /* relocate U-Boot to RAM   */
+   adr r0, _start  /* r0 - current position of code   */
+   ldr r1, _TEXT_BASE  /* test if we run from flash or RAM */
+   cmp r0, r1  /* don't reloc during debug */
+   beq stack_setup
+
+   ldr r2, _armboot_start
+   ldr r3, _bss_start
+   sub r2, r3, r2  /* r2 - size of armboot*/
+   add r2, r0, r2  /* r2 - source end address */
+
+copy_loop:
+   ldmia   r0!, {r3-r10}   /* copy from source address [r0]*/
+   stmia   r1!, {r3-r10}   /* copy to   target address [r1]*/
+   cmp r0, r2  /* until source end addreee [r2]*/
+   ble copy_loop
+#endif /* CONFIG_SKIP_RELOCATE_UBOOT */
+
+   /* Set up the stack */
+stack_setup:
+   ldr r0, _TEXT_BASE  /* upper 128 KiB: relocated uboot   */
+   sub r0, r0, #CFG_MALLOC_LEN /* malloc area  */
+   sub r0, r0, #CFG_GBL_DATA_SIZE /* bdinfo*/
+#ifdef CONFIG_USE_IRQ
+   sub r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ)
+#endif
+   sub sp, r0, #12 /* leave 3 words for abort-stack*/
+
+clear_bss:
+   ldr r0, _bss_start  /* find start of bss segment*/
+   ldr r1, _bss_end/* stop here*/
+   mov r2, #0x /* clear*/
+
+clbss_l:strr2, [r0]/* clear loop...*/
+   add r0, r0, #4
+   cmp r0, r1
+   ble clbss_l
+
+   ldr pc, _start_armboot
+
+_start_armboot:.word start_armboot
+
+
+/*
+ *
+ *
+ * CPU_init_critical registers
+ *
+ * setup important registers
+ * setup memory timing
+ *
+ *
+ */
+
+
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+cpu_init_crit:
+   /*
+* flush v4 I/D caches
+*/
+   mov r0, #0
+   mcr p15, 0, r0, c7, c7, 0   /* flush v3/v4 cache */
+   mcr p15, 0, r0, c8, c7, 0   /* flush v4 TLB */
+
+   /*
+* disable MMU stuff and caches
+*/
+   mrc p15, 0, r0, c1, c0, 0
+   bic r0, r0, #0x2300 @ clear bits 13, 9:8 (--V- --RS)
+   bic r0, r0, #0x0087 @ clear bits 7, 2:0 (B--- -CAM)
+   orr r0, r0, #0x0002 @ set bit 2 (A) Align
+   orr r0, r0, #0x1000 @ set bit 

[U-Boot-Users] Request: s3c24xx getting its own start.S file ?

2008-07-06 Thread Harald Welte
Hi!

I'm spending the better part of this day to finally put quite a number
of the s3c24xx related patches from my various trees into the s3c24xx
custodian tree.

Merging the code in start.S is particularly cumbersome, since this file
has already exceeded any reasonable number of #ifdef/endif clauses[1] and
even while looking long and hard at it, I simply cannot make reasonably
sure that I don't break non-s3c codepaths.

This will get significantly worse when I start to add code for s3c2440,
s3c2442, s3c2443 and maybe even 2412, 24a0, 2460 and/or others.  They
all have their subtle differences in low-level initialization, and they
all support various booting modes (NOR, NAND, OneNAND, ...).

I know code duplication is really bad.  But then, having unreadable code
that even experienced developers have a hard time understanding is also
not the best choice.

What are your thoughts on this?

[1] = 
http://git.denx.de/?p=u-boot/u-boot-s3c24xx.git;a=blob;f=cpu/arm920t/start.S;h=3c542d43fb2a2907bd6043c99e5f071dde29844b;hb=HEAD
-- 
- Harald Welte [EMAIL PROTECTED]   http://laforge.gnumonks.org/

Privacy in residential applications is a desirable marketing option.
  (ETSI EN 300 175-7 Ch. A6)


signature.asc
Description: Digital signature
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] fix USB devices with multiple configurations

2008-07-06 Thread Harald Welte
This patch fixes bugs in usbdcore*.c related to the use of devices
with multiple configurations.

The original code made mistakes about the meaning of configuration value and
configuration index, and the resulting off-by-one errors resulted in:

* SET_CONFIGURATION always selected the first configuration, no matter what
  wValue is being passed.
* GET_DESCRIPTOR/CONFIGURATION always returned the descriptor for the first
  configuration (index 0).

Signed-off-by: Harald Welte [EMAIL PROTECTED]

diff --git a/drivers/usb/usbdcore.c b/drivers/usb/usbdcore.c
index 65a5724..a2e6711 100644
--- a/drivers/usb/usbdcore.c
+++ b/drivers/usb/usbdcore.c
@@ -147,12 +147,9 @@ struct usb_string_descriptor *usbd_get_string (__u8 index)
 static struct usb_configuration_instance *usbd_device_configuration_instance 
(struct usb_device_instance *device,
unsigned int port, unsigned int configuration)
 {
-   /* XXX */
-   configuration = configuration ? configuration - 1 : 0;
-
-   if (configuration = device-configurations) {
+   if (configuration = device-configurations)
return NULL;
-   }
+
return device-configuration_instance_array + configuration;
 }
 
diff --git a/drivers/usb/usbdcore_ep0.c b/drivers/usb/usbdcore_ep0.c
index 2c89304..d9808f9 100644
--- a/drivers/usb/usbdcore_ep0.c
+++ b/drivers/usb/usbdcore_ep0.c
@@ -237,8 +237,8 @@ static int ep0_get_descriptor (struct usb_device_instance 
*device,
return -1;
}
/*dbg_ep0(2, %d %d, index, 
device_descriptor-bNumConfigurations); */
-   if (index  device_descriptor-bNumConfigurations) {
-   dbg_ep0 (0, index too large: %d  %d, index,
+   if (index = device_descriptor-bNumConfigurations) {
+   dbg_ep0 (0, index too large: %d = %d, index,
 device_descriptor-
 bNumConfigurations);
return -1;
@@ -612,14 +612,8 @@ int ep0_recv_setup (struct urb *urb)
 
case USB_REQ_SET_CONFIGURATION:
/* c.f. 9.4.7 - the top half of wValue is reserved */
-   /* */
-   if ((device-configuration =
-   le16_to_cpu (request-wValue)  0xFF80) != 0) {
-   /* c.f. 9.4.7 - zero is the default or 
addressed state, in our case this */
-   /* is the same is configuration zero */
-   serial_printf(error setting dev-config to 
zero!\n);
-   device-configuration = 0;  /* TBR - ?? 
*/
-   }
+   device-configuration = le16_to_cpu(request-wValue)  
0xff;
+
/* reset interface and alternate settings */
device-interface = device-alternate = 0;
 
-- 
- Harald Welte [EMAIL PROTECTED]   http://laforge.gnumonks.org/

Privacy in residential applications is a desirable marketing option.
  (ETSI EN 300 175-7 Ch. A6)


signature.asc
Description: Digital signature
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Request: s3c24xx getting its own start.S file ?

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 
 I meanwhile realized that the entire makefile system doesn't really cope
 with the fact.  So what I'm left with is something along the lines of

Please explain what's the problem...

 the attached patch, where the cpu/arm920t/start.S #includes a
 cpu/arm920t/s3c24x0/start.S file.
 
 It's not really nice, but otherwise I assure you anyone touching the
 arm920t start.S file again will find itself in #ifdef/endif hell, once
 all my s3c24xx related patches would be merged...

I really dislike the code duplication.

 +/*
 + *  armboot - Startup Code for S3C24xx CPU-cores

You're posting this on the wrong mailing list, then. Did you mean
[EMAIL PROTECTED] ? ;-)

...
 +#ifndef CONFIG_SKIP_RELOCATE_UBOOT
 +relocate:/* relocate U-Boot to RAM   */
 + adr r0, _start  /* r0 - current position of code   */
 + ldr r1, _TEXT_BASE  /* test if we run from flash or RAM */
 + cmp r0, r1  /* don't reloc during debug */
 + beq stack_setup
 +
 + ldr r2, _armboot_start

armboot? 

 + ldr pc, _start_armboot
 +
 +_start_armboot:  .word start_armboot

?

 --- u-boot.orig/cpu/arm920t/start.S
 +++ u-boot/cpu/arm920t/start.S
 @@ -103,6 +103,10 @@
  #endif
  
  
 +#if defined(CONFIG_S3C24xx)
 +#include s3c24x0/start.S
 +#else

Why cannot we handle this on a Makefile level?

 --- u-boot.orig/include/configs/VCMA9.h
 +++ u-boot/include/configs/VCMA9.h
 @@ -35,6 +35,7 @@
   */
  #define CONFIG_ARM920T   1   /* This is an ARM920T Core  
 */
  #define  CONFIG_S3C2410  1   /* in a SAMSUNG S3C2410 SoC 
 */
 +#define  CONFIG_S3C24xx  1   /* in a SAMSUNG S3C24xx family  
 */

Is  this  really  needed?  Should  not  CONFIG_S3C2410  automatically
include setting CONFIG_S3C24xx ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A complex system that works is invariably found to have evolved from
a simple system that worked. - John Gall, _Systemantics_

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] framebuffer drivers without modesetting support?

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 
 I was wondering if u-boot would also accept the merge of a framebuffer
 driver that doesn't allow runtime mode-setting.

What makes you think that would be a problem?

 Even inside the Linux kernel e.g. the s3c2410 framebuffer is configured
 by board-specific platform data.

And in U-Boot there are some frame buffer drivers that are completely
fixed for a specific configuration, too.

What exactly was your problem?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Die meisten Menschen pflegen im Kindesalter vom Zeigen auf Gegenstän-
de (Mausbewegung) und ga sagen  (Mausklick)  abzukommen,  zugunsten
eines  mächtigeren  und langwierig zu erlernenden Tools (Sprache).
 -- Achim Linder in de.comp.os.linux.misc

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] ppc4xx: Rename CONFIG_XILINX_ML300 to CONFIG_XILINX_405

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 From: Michal Simek [EMAIL PROTECTED]
 
 This change helps with better handling with others
 Xilinx based platform.
 
 Signed-off-by: Michal Simek [EMAIL PROTECTED]
 ---
  common/cmd_bdinfo.c |8 
  cpu/ppc4xx/speed.c  |2 +-
  include/configs/ml300.h |1 +
  lib_ppc/board.c |2 +-
  4 files changed, 7 insertions(+), 6 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A fractal is by definition a set for which the Hausdorff Besicovitch
dimension strictly exceeds the topological dimension.
- Mandelbrot, _The Fractal Geometry of Nature_

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] ppc4xx: Rename CONFIG_XILINX_ML300 to CONFIG_XILINX_405

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:

 Acked-by: Stefan Roese [EMAIL PROTECTED]
 
 Wolfgang, please apply this directly, since it doesn't fit into one
 of the custodian repositories.

Done, but pulling this into the ppc4xx repo would have been fine with
me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
When a woman marries again it is because she detested her first  hus-
band.  When  a  man  marries again, it is because he adored his first
wife.  -- Oscar Wilde

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 2/2] Update the RRvision port to a modern version of u-boot.

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:

  In message [EMAIL PROTECTED] you wrote:
vidinfo_t panel_info = {
640, 480, 212, 158, CFG_HIGH, CFG_HIGH, CFG_LOW, CFG_LOW, CFG_HIGH,
   -3, 0, 0, 1, 1, 144, 2, 0, 33
   +3, 0, 0, 1, 1, 88, 2, 0, 33
  
  Indentation by TABs, please (here and everywhere else).
  
   +vidinfo_t panel_info = {
   +800,/* Number of columns (i.e. 640) */
  ...
  
  Ditto. etc. etc.
  
 
 None of the entries in this file are indented using TABS.  I merely
 followed the existing formatting (4 spaces).

Well, since you change the file anyway, maybe you could  be  so  kind
and help and clean it up?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Common sense and a sense of humor  are  the  same  thing,  moving  at
different speeds.  A sense of humor is just common sense, dancing.
- Clive James

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN support (2nd rev)

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:

  Is there any reason not to enable this unconditionally?
 
 Don't really know. I've used config option just to provide old behavior.

I vote for adding this unconditionally, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
O Staat!   Wie tief dir alle Besten fluchen!  Du bist kein Ziel.  Der
Mensch muß weiter suchen. - Christian Morgenstern

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] fs: make the static array to dynamic allocation

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Current fat.c have three 64KB static array, it makes
 the BSS section larger.
 Change the static to dynamic allocation.

So what's the benefit? BSS size doesn't matter - itr comes for free.
It get's initialized automatically.

You add more than 30 lines of code instead, plus a lot of string
space, plus a new failure mode (malloc failed) that didn't exist
before.

Looks like a pessimizing patch to me, but maybe you just did not
describe which problem you are trying to fix?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Remember, there's a big difference between kneeling down and  bending
over.   - Frank Zappa

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] PATCH: drivers/mtd/jedec_flash.c (typo)

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:

 I noticed that the device id for AMD flash part AM29DL800BB is wrong.
 
 Attached patch corrects it.
...
 -#define AM29DL800BB  0x22C8
 +#define AM29DL800BB  0x22CB

H... I have but an old data sheet (Nov 2000) for this chip, which
indeed says 22CB. But then, even the current Linux kernel tree has
22C8.

Can anybody with access to  real  hardware  /  current  documentation
comment?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
We, the unwilling, led by the unknowing, are doing the impossible for
the ungrateful. We have done so much, for so long, with so little, we
are now qualified to do anything with nothing.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] TQM823L flash recognition problem

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] Jens Gehrlein wrote:
 
 Could you please change TQM823L.h:
 
 -#define CFG_FLASH_BANKS_LIST   { CFG_FLASH_BASE }
 +#define CFG_FLASH_BANKS_LIST   { CFG_FLASH_BASE, CFG_FLASH_BASE + 
 0x40 }

Note that a proper patch (and without line wrapping) would have  been
much more useful.

 There was a switch-over to use the CFI driver (see git history of file 
 TQM823L.h). AFAIK the CFI driver needs a list with fix start addresses 
 of each bank to start the CFI query on.

Thanks for pointing this out.


The big disadvantage of above code is that it requires a static
mapping of the second flash bank, i. e. it works only correctly for
fixed flash sizes. This may be not a big problem for the boards in
question here, but we use autoconfiguration everywhere else so this
doesn't fit in style.

The following patch tries to fix this in a more general way,  but  it
requires slight modification of the CFI driver to support this.


From 53abac832029696e47fdd2bcc36a079419076b4a Mon Sep 17 00:00:00 2001
From: Wolfgang Denk [EMAIL PROTECTED]
Date: Sun, 6 Jul 2008 23:54:34 +0200
Subject: [PATCH] TQM8xxL: fix support for second flash bank

When switching the TQM8xxL modules to use the CFI flash driver,
support for the second flash bank was broken. This gets fixed now.

One problem was that the CFI driver allows only for static initia-
lizers in the CFG_FLASH_BANKS_LIST definition, i. e. it did not allow
to map several flash banks contiguously if the bank sizes were not
known in advance, which kind of violates U-Boot's design philosophy.

Now we can refer to dynamically determined flash sizes and addresses.

Signed-off-by: Wolfgang Denk [EMAIL PROTECTED]
---

Note that the whole CFG_MAX_FLASH_BANKS_DETECT stuff is a big mess and
should be cleaned up, too, but that's another story. Any volunteers?

 drivers/mtd/cfi_flash.c   |   14 --
 include/configs/TQM823L.h |2 +-
 include/configs/TQM850L.h |2 +-
 include/configs/TQM855L.h |2 +-
 include/configs/TQM860L.h |2 +-
 include/configs/TQM862L.h |2 +-
 6 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index c0ea97b..1ed92b1 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -158,13 +158,13 @@ static uint flash_offset_cfi[2] = { FLASH_OFFSET_CFI, 
FLASH_OFFSET_CFI_ALT };
 
 /* use CFG_MAX_FLASH_BANKS_DETECT if defined */
 #ifdef CFG_MAX_FLASH_BANKS_DETECT
-static ulong bank_base[CFG_MAX_FLASH_BANKS_DETECT] = CFG_FLASH_BANKS_LIST;
-flash_info_t flash_info[CFG_MAX_FLASH_BANKS_DETECT];   /* FLASH chips info */
+# define CFI_MAX_FLASH_BANKS   CFG_MAX_FLASH_BANKS_DETECT
 #else
-static ulong bank_base[CFG_MAX_FLASH_BANKS] = CFG_FLASH_BANKS_LIST;
-flash_info_t flash_info[CFG_MAX_FLASH_BANKS];  /* FLASH chips info */
+# define CFI_MAX_FLASH_BANKS   CFG_MAX_FLASH_BANKS
 #endif
 
+flash_info_t flash_info[CFI_MAX_FLASH_BANKS];  /* FLASH chips info */
+
 /*
  * Check if chip width is defined. If not, start detecting with 8bit.
  */
@@ -1909,12 +1909,14 @@ unsigned long flash_init (void)
char *s = getenv(unlock);
 #endif
 
+#define BANK_BASE(i)   (((unsigned long 
[CFI_MAX_FLASH_BANKS])CFG_FLASH_BANKS_LIST)[i])
+
/* Init: no FLASHes known */
for (i = 0; i  CFG_MAX_FLASH_BANKS; ++i) {
flash_info[i].flash_id = FLASH_UNKNOWN;
 
-   if (!flash_detect_legacy (bank_base[i], i))
-   flash_get_size (bank_base[i], i);
+   if (!flash_detect_legacy (BANK_BASE(i), i))
+   flash_get_size (BANK_BASE(i), i);
size += flash_info[i].size;
if (flash_info[i].flash_id == FLASH_UNKNOWN) {
 #ifndef CFG_FLASH_QUIET_TEST
diff --git a/include/configs/TQM823L.h b/include/configs/TQM823L.h
index 100be7c..3871722 100644
--- a/include/configs/TQM823L.h
+++ b/include/configs/TQM823L.h
@@ -196,7 +196,7 @@
 /* use CFI flash driver */
 #define CFG_FLASH_CFI  1   /* Flash is CFI conformant */
 #define CFG_FLASH_CFI_DRIVER   1   /* Use the common driver */
-#define CFG_FLASH_BANKS_LIST   { CFG_FLASH_BASE }
+#define CFG_FLASH_BANKS_LIST   { CFG_FLASH_BASE, 
CFG_FLASH_BASE+flash_info[0].size }
 #define CFG_FLASH_EMPTY_INFO
 #define CFG_FLASH_USE_BUFFER_WRITE 1
 #define CFG_MAX_FLASH_BANKS2   /* max number of memory banks */
diff --git a/include/configs/TQM850L.h b/include/configs/TQM850L.h
index 3097bc3..17afa89 100644
--- a/include/configs/TQM850L.h
+++ b/include/configs/TQM850L.h
@@ -183,7 +183,7 @@
 /* use CFI flash driver */
 #define CFG_FLASH_CFI  1   /* Flash is CFI conformant */
 #define CFG_FLASH_CFI_DRIVER   1   /* Use the common driver */
-#define CFG_FLASH_BANKS_LIST   { CFG_FLASH_BASE }
+#define CFG_FLASH_BANKS_LIST   { CFG_FLASH_BASE, 
CFG_FLASH_BASE+flash_info[0].size }
 #define CFG_FLASH_EMPTY_INFO
 #define CFG_FLASH_USE_BUFFER_WRITE 1
 #define CFG_MAX_FLASH_BANKS2   /* max number 

Re: [U-Boot-Users] [PATCH] net: smc911x: Fix can not compile smc911x

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 When enable CONFIG_DRIVER_SMC911X_16_BIT in smc911x, can not compile it.
 I revised it from elif preprocessor to elif defined.
 
 Signed-off-by: Nobuhiro Iwamatsu [EMAIL PROTECTED]
 ---
  drivers/net/smc911x.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
We do not colonize. We conquer. We rule. There is no  other  way  for
us.
-- Rojan, By Any Other Name, stardate 4657.5

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] net: smc911x: Fix can not compile smc911x

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Nobuhiro,
 
 Nice catch!  Thanks.
 
 Wolfgang/Detlev,
 
 Please pull directly.

Done.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Wherever you go...There you are.- Buckaroo Banzai

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Fix printf errors.

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 The compiler will help find mismatches between printf formats and
 arguments if you let it.  This patch adds the necessary attributes to
 declarations in include/common.h, then corrects the resulting compiler
 warnings in several files.  Some of these were bugs, e.g., $d
 instead of %d and incorrect arguments in common/cmd_fdt.c.  Others
 were just annoying, like int-long mismatches on a system where both
 are 32 bits.  It's worth fixing the annoying errors to catch the real
 ones.
 
 I can only compile for ppc architecture so have not tested much of the
 source code for further warnings.

Very good. Thanks a lot - but could you please add your signed-off-by
line, and clean up the commit message (move commnets for the posting
that are not intended for the commit message _below_ the --- line).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Der Irrtum wiederholt sich immerfort in der Tat.  Deshalb muß man das
Wahre unermüdlich in Worten wiederholen. - Goethe

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] update mvBL-M7 board config

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 This is a multi-part message in MIME format.
 --070905020504060509080209
 Content-Type: text/plain; charset=ISO-8859-15
 Content-Transfer-Encoding: 7bit
 
 update mvBL-M7 config file to use UBOOT_VERSION and define
 CONFIG_HIGH_BATS.
 
 Signed-off-by: Andre Schwarz [EMAIL PROTECTED]

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A failure will not appear until a unit has passed final inspection.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] net: smc911x: Fix typo output of the version check

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Signed-off-by: Nobuhiro Iwamatsu [EMAIL PROTECTED]
 ---
  drivers/net/smc911x.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Everyting looks interesting until you do it. Then you find it's  just
another job. - Terry Pratchett, _Moving Pictures_

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Please pull u-boot-mpc83xx.git

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 WD/Detlev,
 
 please pull mostly MVBLM7 board fixes:
 
 The following changes since commit 914f58c5766860373a7d232e961cee5a4b54a55b:
   Wolfgang Denk (1):
 Merge branch 'master' of git://www.denx.de/git/u-boot-cfi-flash
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-mpc83xx.git
 
 Andre Schwarz (3):
   fix system config overwrite @ MPC834x and MPC8313
   fix non-working mvBL-M7
   update mvBL-M7 board config
 
 Kim Phillips (1):
   mpc83xx: move CPU_TYPE_ENTRY over to processor.h

Merged, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
There are bugs and then there are bugs.  And then there are bugs.
- Karl Lehenbauer

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 00/10] [ARM] TQMA31: new board

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Jens Gehrlein schrieb:
 
  Who will pick up this patch series (if there are no complaints)? Peter?
 
 Of course, we could put them into the TQ custodian tree.
 Awkward, that I forgot this.

But it still has to go through the respective custodian.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
2000 pounds of chinese soup   = 1 Won Ton

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 00/10] [ARM] TQMA31: new board

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
  
  Of course, we could put them into the TQ custodian tree.
  Awkward, that I forgot this.
 
 So I'm assuming I need take no u-boot-arm actions

But please do. It's ARM specific code, and needs to be reviewed and
confirmed by an independent ARM expert.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
It is surely a great calamity for  a  human  being  to  have  no  ob-
sessions.- Robert Bly

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] SH: fix out of tree building

2008-07-06 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk [EMAIL PROTECTED]
---
 Makefile |   25 ++---
 1 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/Makefile b/Makefile
index 845b564..ac3f98f 100644
--- a/Makefile
+++ b/Makefile
@@ -2913,43 +2913,46 @@ atngw100_config :   unconfig
 ## sh3 (Renesas SuperH)
 #
 mpr2_config: unconfig
-   @ include/config.h
-   @echo #define CONFIG_MPR2 1  include/config.h
+   @mkdir -p $(obj)include
+   @echo #define CONFIG_MPR2 1  $(obj)include/config.h
@$(MKCONFIG) -a $(@:_config=) sh sh3 mpr2
 
 ms7720se_config: unconfig
-   @echo #define CONFIG_MS7720SE 1  include/config.h
+   @mkdir -p $(obj)include
+   @echo #define CONFIG_MS7720SE 1  $(obj)include/config.h
@$(MKCONFIG) -a $(@:_config=) sh sh3 ms7720se
 
 #
 ## sh4 (Renesas SuperH)
 #
 ms7750se_config: unconfig
+   @mkdir -p $(obj)include
@echo #define CONFIG_MS7750SE 1  $(obj)include/config.h
@$(MKCONFIG) -a $(@:_config=) sh sh4 ms7750se
 
 ms7722se_config :  unconfig
+   @mkdir -p $(obj)include
@echo #define CONFIG_MS7722SE 1  $(obj)include/config.h
@$(MKCONFIG) -a $(@:_config=) sh sh4 ms7722se
 
 MigoR_config :   unconfig
-   @ include/config.h
-   @echo #define CONFIG_MIGO_R 1  include/config.h
+   @mkdir -p $(obj)include
+   @echo #define CONFIG_MIGO_R 1  $(obj)include/config.h
@./mkconfig -a $(@:_config=) sh sh4 MigoR
 
 r7780mp_config: unconfig
-   @ include/config.h
-   @echo #define CONFIG_R7780MP 1  include/config.h
+   @mkdir -p $(obj)include
+   @echo #define CONFIG_R7780MP 1  $(obj)include/config.h
@./mkconfig -a $(@:_config=) sh sh4 r7780mp
 
 r2dplus_config  :   unconfig
-   @ include/config.h
-   @echo #define CONFIG_R2DPLUS 1  include/config.h
+   @mkdir -p $(obj)include
+   @echo #define CONFIG_R2DPLUS 1  $(obj)include/config.h
@./mkconfig -a $(@:_config=) sh sh4 r2dplus
 
 sh7763rdp_config  :   unconfig
-   @ include/config.h
-   @echo #define CONFIG_SH7763RDP 1  include/config.h
+   @mkdir -p $(obj)include
+   @echo #define CONFIG_SH7763RDP 1  $(obj)include/config.h
@./mkconfig -a $(@:_config=) sh sh4 sh7763rdp
 
 #
-- 
1.5.4.2


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] sh: ms7750se: Fix make O= builds

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 When compiling ms7750se board with make O=some dir, I got some errors.
 I tuned some makefiles.

Thanks for pointing this out; but you fix only one board, leaving all
the others that have the same problem unfixed. Other parts of your
patch were already fixed in the current code.

Please have a look at the posting [PATCH] SH: fix out of tree
building which I just submitted.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Man did not weave the web of life; he  is  merely  a  strand  in  it.
Whatever he does to the web, he does to himself. - Seattle [1854]

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] AT91 Pull request

2008-07-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Please pull
 
 The following changes since commit a524e112b424c6843800ea2f19d3a8cf01d0aa94:
   Detlev Zundel (1):
 Merge branch 'master' of git://www.denx.de/git/u-boot-ppc4xx
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-at91.git master
 
 Patrice Vilchez (1):
   [AT91SAM9] Fix NAND FLASH timings
 
 Stelian Pop (1):
   Fix boot from NOR due to incorrect reset delay.
 
  board/atmel/at91cap9adk/at91cap9adk.c |7 ++-
  board/atmel/at91sam9260ek/at91sam9260ek.c |8 
  board/atmel/at91sam9261ek/at91sam9261ek.c |   12 ++--
  board/atmel/at91sam9263ek/at91sam9263ek.c |   11 ---
  board/atmel/at91sam9rlek/at91sam9rlek.c   |   12 ++--
  5 files changed, 30 insertions(+), 20 deletions(-)

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
You're dead, Jim.
-- McCoy, The Tholian Web, stardate unknown

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Shinya Kuribayashi
Jean-Christophe PLAGNIOL-VILLARD wrote:
 But even if that is the case, there still might be some build breakage.

 I've found an error on ARM, I'll send a patch about it soon.

Sorry, and thanks in advance.

 Best Regards,
 J.

-- 
Shinya Kuribayashi
NEC Electronics

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] sh: Fix SH-boards compile error

2008-07-06 Thread Nobuhiro Iwamatsu
By Cleanup out-or-tree building for some boards (.depend)
(commit:c8a3b109f07f02342d097b30908965f7261d9f15)
because filse ware changed, some SH-boards have compile error.
I revised this problem.

Signed-off-by: Nobuhiro Iwamatsu [EMAIL PROTECTED]
---
 MAKEALL  |2 +-
 board/MigoR/Makefile |2 +-
 board/mpr2/Makefile  |2 +-
 board/ms7720se/Makefile  |2 +-
 board/ms7722se/Makefile  |2 +-
 board/ms7750se/Makefile  |2 +-
 board/r2dplus/Makefile   |2 +-
 board/r7780mp/Makefile   |2 +-
 board/sh7763rdp/Makefile |2 +-
 cpu/sh3/Makefile |2 +-
 cpu/sh4/Makefile |2 +-
 lib_sh/Makefile  |2 +-
 lib_sh/board.c   |4 +++-
 lib_sh/time.c|2 +-
 14 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index 9f80b3d..e00bb9c 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -749,7 +749,7 @@ LIST_sh3=  \
 LIST_sh4= \
ms7750se\
ms7722se\
-   Migo-R  \
+   MigoR   \
r7780mp \
r2dplus \
sh7763rdp   \
diff --git a/board/MigoR/Makefile b/board/MigoR/Makefile
index bced511..661b59d 100644
--- a/board/MigoR/Makefile
+++ b/board/MigoR/Makefile
@@ -26,7 +26,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := migo_r.o
+COBJS  := migo_r.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/mpr2/Makefile b/board/mpr2/Makefile
index 080476b..9f8fb80 100644
--- a/board/mpr2/Makefile
+++ b/board/mpr2/Makefile
@@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := mpr2.o
+COBJS  := mpr2.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/ms7720se/Makefile b/board/ms7720se/Makefile
index 545889f..18745ec 100644
--- a/board/ms7720se/Makefile
+++ b/board/ms7720se/Makefile
@@ -29,7 +29,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := ms7720se.o
+COBJS  := ms7720se.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/ms7722se/Makefile b/board/ms7722se/Makefile
index 744744e..b203b6d 100644
--- a/board/ms7722se/Makefile
+++ b/board/ms7722se/Makefile
@@ -26,7 +26,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := ms7722se.o
+COBJS  := ms7722se.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/ms7750se/Makefile b/board/ms7750se/Makefile
index d806101..01ddf69 100644
--- a/board/ms7750se/Makefile
+++ b/board/ms7750se/Makefile
@@ -21,7 +21,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := ms7750se.o
+COBJS  := ms7750se.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/r2dplus/Makefile b/board/r2dplus/Makefile
index 8529857..e96a8aa 100644
--- a/board/r2dplus/Makefile
+++ b/board/r2dplus/Makefile
@@ -21,7 +21,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := r2dplus.o
+COBJS  := r2dplus.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/r7780mp/Makefile b/board/r7780mp/Makefile
index 0ab6d1d..c100e7e 100644
--- a/board/r7780mp/Makefile
+++ b/board/r7780mp/Makefile
@@ -22,7 +22,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := r7780mp.o
+COBJS  := r7780mp.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/sh7763rdp/Makefile b/board/sh7763rdp/Makefile
index 8a04477..62a683d 100644
--- a/board/sh7763rdp/Makefile
+++ b/board/sh7763rdp/Makefile
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk

 LIB= $(obj)lib$(BOARD).a

-OBJS   := sh7763rdp.o
+COBJS  := sh7763rdp.o
 SOBJS  := lowlevel_init.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/cpu/sh3/Makefile b/cpu/sh3/Makefile
index a7eb1e2..587413d 100644
--- a/cpu/sh3/Makefile
+++ b/cpu/sh3/Makefile
@@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk
 LIB= $(obj)lib$(CPU).a

 SOBJS  = start.o
-OBJS   = cpu.o interrupts.o watchdog.o time.o cache.o
+COBJS  = cpu.o interrupts.o watchdog.o time.o cache.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS   := $(addprefix $(obj),$(COBJS))
diff --git a/cpu/sh4/Makefile b/cpu/sh4/Makefile
index e38e04f..d3c5eef 100644
--- a/cpu/sh4/Makefile
+++ b/cpu/sh4/Makefile
@@ -29,7 +29,7 @@ include $(TOPDIR)/config.mk
 LIB= $(obj)lib$(CPU).a

 SOBJS  = start.o
-OBJS   = cpu.o interrupts.o watchdog.o time.o cache.o
+COBJS  = cpu.o interrupts.o watchdog.o time.o cache.o

 SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS   := $(addprefix $(obj),$(COBJS))
diff --git a/lib_sh/Makefile b/lib_sh/Makefile
index 0e4fdee..4034381 100644
--- a/lib_sh/Makefile
+++ b/lib_sh/Makefile
@@ -26,7 +26,7 @@ SOBJS-y   +=

 COBJS-y+= board.o
 COBJS-y+= bootm.o
-#COBJS-y   += time.o
+# COBJS-y  += time.o

 SRCS   := $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
 OBJS   := 

Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Nobuhiro Iwamatsu
Hi Ben.

2008/7/6 Ben Warren [EMAIL PROTECTED]:

  3645  06/11 Nobuhiro Iwamatsu  [U-Boot-Users] [PATCH v2] net: sh: Renesas
 SH7763 Ethernet device support
- for net custodian



 Didn't pick this up because it was after what I thought was the cut-off of
 6/10.  It still has issues, so I'll ask NobuHiro to re-submit.  Should it go
 in this release when OK?
 snip
II reflected your comment as this and contributed it again.
Could you apply this patch?

Best regards,
 Nobuhiro

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users