[Bug 1113166]
Created attachment 725732 If available, use SO_VERSION from configure env to set DLL_SUFFIX Here's what i have in my wip port - same as what's in m-c. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1113166 Title: update to new mozjs-17 library To manage notifications about this bug go to: https://bugs.launchpad.net/mozjs/+bug/1113166/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Finally \o/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 620274 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported That also works. New patch which only removes the #else #error from ExecutableAllocator.h, tested working here on ppc. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Cameron Kaiser from comment #113) Can you change the ifsef WTF_CPU_PPC to defined(WTF_CPU_PPC) !defined(JS_CPU_PPC_OSX) around cacheFlush? Sure, no problem. I've sent the current patch to try here : https://tbpl.mozilla.org/?tree=Tryrev=ec2fff3441e3 I'm not an expert for deciphering the logs, but it looks most of the failures there are either already known or due to infrastructure issues and unrelated to the diff itself. js shell builds on sparc64 too, firefox is still building on powerpc i'll post an updated patch (need to fix indentation in Makefile.in) and ask for review when i've tested firefox on ppc. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 620233 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported So with this smaller patch (and also patches from 750447, 750620 750853..) i have a working firefox (Mozilla/5.0 (X11; OpenBSD macppc; rv:15.0) Gecko/15.0 Firefox/15.0a1), browsed hg.m.o/w.m.o for a while, gmail, google maps... So let's try to get this reviewed and hope this time it sticks. Only change from att 619876 is indentation fixed in Makefile.in (use tabs) and (defined(WTF_CPU_PPC) !defined(JS_CPU_PPC_OSX)) for using the dummy cacheFlush. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
So that'd mean replacing :
#error The cacheFlush support is missing on this platform.
by
static void cacheFlush(void*, size_t)
{
#warning Using dummy generic empty cacheFlush for this platform.
}
Do you think that'll work out ? Since from my understanding of the
previous comments cacheFlush() is only called if there's a JIT..
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/908508
Title:
Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Cameron Kaiser from comment #110) Landry, how close are you to a patch for this? I'd like to get bug 731110 revised and landed with the next train so that downstreamers can get it and I can stop schlepping it around in our own changesets. It may actually simplify your work. If you have a new patch imminent, I'll wait, but if not I'd like to get the PPC mjit in first. Please go ahead, that issue depresses me :) I'll see what your patch breaks for me ! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 619876 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported Fwiw here's the (simpler) patch i'm working on (no, i didn't gave up..) : - it doesnt touch the ENABLE_ASSEMBLER hell - shouldnt affect tier1 archs - it uses the dummy empty cacheFlush implem for PPC in ExecutableAllocator.h - adds ExecutableAllocator.cpp/ExecutableAllocatorPosix.cpp to CPPSRCS in !YARR_JIT case (i didnt do the ifdef WIN/OS2 dance, as i doubt win/os2 might fall in the !YARR_JIT case someday.. prove me wrong :) - inconditionally includes ExecutableAllocator.h in wtfbridge.h so that the definition of ExecutableAllocator class is available everywhere It currently builds a working shell on ppc (regress tests passes except testConservativeGC but that seems related to #750620), i've yet to confirm it produces a working firefox. I'll also see if it fixes the build on sparc64, and then i'll send it to try to see if it breaks anything else. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to David Mandelin from comment #102) This is getting really confusing--I feel like I need to back up a few steps. Yes, i'm also confused. 1. First off, do you still need to leave out the executableAllocators in jscntxt.h? If you have the JITs now, then it seems like you don't even need to patch jscntxt.h. I'm going to assume you do, and continue, but if we don't need to do anything, that would be great. There are platforms where there's no JIT (and hence no ExecutableAllocator), for example sparc64 macppc/sysv abi. So we have to #ifdef ENABLE_ASSEMBLER out the execAlloc uses. 2. Second, if possible, it'd be nice to do something small and simple that just fixes the immediate problem. The immediate problem, IIUC, is that you can't have the executableAllocators in JSContext, and #ifdef ENABLE_ASSEMBLER in jscntxt.h doesn't work. So, what about just providing a dummy class for ExecutableAllocator on SPARC? Would that work? You could put it in a .cpp file guarded by !ENABLE_ASSEMBLER. To me, the immediate problem is that i've a diff that works, but it breaks some tests in subtle ways just because ENABLE_ASSEMBLER=1 is not propagated anymore under shell/ with my diff. ExecutableAllocator.h has the arch-dependant machinery, and it #errors out on the archs we care about in this bug report.. because (at least!) there's no implementation for 'cacheFlush', which seems to require writing some low-level asm, and i have no idea if it can be made a nop. x86/x86_64 provides an empty implementation, but iirc i tried adding ppc to also use that empty implem and it failed to build. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
I've tried a slightly different approach in https://tbpl.mozilla.org/?tree=Tryrev=49b9616807cc but looking at the results it wasnt working 100%.. The idea (https://hg.mozilla.org/try/rev/96ce117be086) was to set ENABLE_ASSEMBLER=1 through configure.in + config/autoconf.mk so that it got applied all under js/src (including shell/) but it seems i have failed at it. not sure it's the right place to set a -D flag, but i'm not comfortable adding a 'too anonymous and not JS_ prefixed' ENABLE_ASSEMBLER #define to js-config.h. Thougths ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to David Mandelin from comment #99) I would suggest making the minimal change that actually works and doesn't make things more confusing. Exactly what that would be, I don't know without trying things out. My *guess* would be that adding JS_ENABLE_JIT to Makefile.in and using it only in the places you need here would be it. I'm Erm... you lost me here. I though we aimed at removing those *ENABLE* being set in Makefile.in and moving them to configure.in/js-config.h. If i add a new JS_ENABLE_JIT only overlapping with the others without removing them from Makefile.in that'll only confuse things. Remember that the issue we're trying to fix is getting ENABLE_ASSEMBLER known under shell/ so that the test failures are fixed. not sure exactly what blocks you are talking about in comment 98, but it sounds like a good idea. The list of archs where METHODJIT is enabled is the same as the list of archs where YARR_JIT is enabled, the former being set in configure.in and the latter being set in Makefile.in. I dont know if they will be always the same, and if so we could merge the two defines.. http://mxr.mozilla.org/mozilla-central/source/js/src/Makefile.in#262 - ifdef ENABLE_METHODJIT block http://mxr.mozilla.org/mozilla-central/source/js/src/Makefile.in#344 - list of ENABLE_YARR_JIT archs -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to David Mandelin from comment #95) Landry, it's definitely a maze. Sorting it out proper would be a lot of work so I definitely don't expect you to fix everything as part of this patch. It seems important to make sure ENABLE_ASSEMBLER is consistent, though, so combined with Mike's point about Platform.h not being public, it seems that we shouldn't try to set ENABLE_ASSEMBLER, ENABLE_YARR_JIT or ENABLE_JIT in the Makefile, and we shouldn't use them in public header files. One idea is to create a new thing that is set on the same conditions when ENABLE_ASSEMBLER is set and put that in js-config.h. Then you could use that in jscntxt.h without causing any problems. Then we could use macros to check that the two are consistent on one of the other files, like YarrJIT.cpp. Getting back to that bug.. I'm a bit lost, since ENABLE_JIT, ENABLE_YARR_JIT and ENABLE_ASSEMBLER are #defined in wtf/Platform.h (depending on tons of conditions), and also set in Makefile.in. Is it wise to keep the same conflicting names ? If i add a single variable (say JS_HAS_ASSEMBLER or JS_HAS_JIT.. gah, speak about meaningful names..) set arch-dependant (the ones with yarr jit : arm% sparc %86 x86_64 mips%) in configure.in js-config.h where should that variable be used ? - replace all #ifdef ENABLE_ASSEMBLER/#ifdef ENABLE_JIT/#ifdef ENABLE_YARR_JIT, since they seem to overlap ? - or i should just use it in the chunks i'm #ifdef'ing in my attempts to fix powerpc ? - in the same patch, should i also remove all ENABLE_ASSEMBLER/ENABLE_JIT/ENABLE_YARR_JIT=1 from Makefile.in ? Just askin', before wrapping a patch... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
And looking at Makefile.in, the list of archs is really the same as ENABLE_METHODJIT, so i'd be tempted to replace ifeq (,$(filter arm% sparc %86 x86_64 mips%,$(TARGET_CPU))) by ifdef ENABLE_METHODJIT, or even better merge the two blocks with the ENABLE_METHODJIT above. Thoughs ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Sidenote : https://tbpl.mozilla.org/?tree=Tryrev=88122a478851 with inclusion of jit/ExecutableAllocator.h in jscntxt.h is all green, so we're definitely on the right track. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to David Mandelin from comment #91) (In reply to Mike Hommey [:glandium] from comment #90) Yes. That these things are in Makefile.in is a mistake anyways. JSC sets those flags in what we imported as assembler/wtf/Platform.h, which seems reasonable. In fact, I see they set ENABLE_ASSEMBLER in there depending on various conditions, which is maybe why the patch works on most platforms already. Erm... looking at Platform.h, ENABLE_ASSEMBLER is set : - #if WTF_PLATFORM_WX - wxWidgets ? Seriously ? - #if WTF_CPU_SH4 WTF_PLATFORM_QT - does it concern mozilla ? - #if ENABLE_JIT || ENABLE_YARR_JIT - so enabling yarr jit sets ENABLE_ASSEMBLER. Given that, why bothering setting ENABLE_ASSEMBLER at all in Makefile.in ? Are there cases where METHODJIT is enabled and YARR JIT is not ? What a #define maze.. js-config.h also seems like a reasonable place, although since there is already ENABLE_ASSEMBLER and ENABLE_JIT stuff in Platform.h, maybe it will be easier to keep consistent if we do it there. Wait, so what should move where ? ENABLE_YARR_JIT ENABLE_ASSEMBLER to js-config.h configure.in ? ENABLE_YARR_JIT to Platform.h ? Do we keep the list of yarr jit architectures in Makefile.in ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
I've looked at try logs, and yes ENABLE_ASSEMBLER=1 is not set on the commandline when building under shell/ with the patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to David Mandelin from comment #82) Landry, following up on a hint from billm, I got your patch to work on Linux with this addition: diff -r e7bbcbb6c24a js/src/jscntxt.h --- a/js/src/jscntxt.hTue Mar 13 17:42:33 2012 -0700 +++ b/js/src/jscntxt.hTue Mar 13 18:32:46 2012 -0700 @@ -64,6 +64,7 @@ #include js/HashTable.h #include js/Vector.h #include vm/Stack.h +#include assembler/jit/ExecutableAllocator.h #ifdef _MSC_VER #pragma warning(push) I'm not quite sure what's going on, but it kind of seems like ENABLE_ASSEMBLER=1 is not being set for all the files in the build, and so different object files get different definitions of JSRuntime, which causes the trc field to get overwritten with junk, and then you crash. Your patch does modify how ENABLE_ASSEMBLER is set, so it seems vaguely plausible that could be the problem. Aha. Very interesting... a shroedingbug. The strange thing is that it seems like js.cpp is the file that doesn't get ENABLE_ASSEMBLER=1, but I do see it being set on the command line to build js.o. And it also doesn't make much sense that the patch above would solve the problem. If i look at old build logs on amd64, i don't see ENABLE_ASSEMBLER=1 in the js.o build line, maybe because it's set in js/src/Makefile.in and not in js/src/shell/Makefile.in ? I'll recheck with a clean tip and only that patch. I've also pushed the corresponding patchset to https://tbpl.mozilla.org/?tree=Tryrev=88122a478851 For me that change make sense, since that brings ExecutableAllocator definition to jscntxt.h where as of now, it's used without knowing how it's defined. Bug 731110 might just make things easy: if you don't have to make execAlloc_ conditional on ENABLE_ASSEMBLER (because you'll have the assembler), then you won't have to modify jscntxt.h and the Makefile.in, and it should just work. Yes, as cameron points out it's also needed for other archs (sparc64, broken anyway, but i try to keep it in a compilable state with that patch, ia64, see #729447, and maybe others..) Unfortunately i'm not in a position to write the ppc assembler for sysV ABI. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Mike Hommey [:glandium] from comment #86) (In reply to Landry Breuil from comment #85) (In reply to David Mandelin from comment #82) Landry, following up on a hint from billm, I got your patch to work on Linux with this addition: diff -r e7bbcbb6c24a js/src/jscntxt.h --- a/js/src/jscntxt.hTue Mar 13 17:42:33 2012 -0700 +++ b/js/src/jscntxt.hTue Mar 13 18:32:46 2012 -0700 @@ -64,6 +64,7 @@ #include js/HashTable.h #include js/Vector.h #include vm/Stack.h +#include assembler/jit/ExecutableAllocator.h #ifdef _MSC_VER #pragma warning(push) I'm not quite sure what's going on, but it kind of seems like ENABLE_ASSEMBLER=1 is not being set for all the files in the build, and so different object files get different definitions of JSRuntime, which causes the trc field to get overwritten with junk, and then you crash. Your patch does modify how ENABLE_ASSEMBLER is set, so it seems vaguely plausible that could be the problem. Aha. Very interesting... a shroedingbug. The strange thing is that it seems like js.cpp is the file that doesn't get ENABLE_ASSEMBLER=1, but I do see it being set on the command line to build js.o. And it also doesn't make much sense that the patch above would solve the problem. If i look at old build logs on amd64, i don't see ENABLE_ASSEMBLER=1 in the js.o build line, maybe because it's set in js/src/Makefile.in and not in js/src/shell/Makefile.in ? I'll recheck with a clean tip and only that patch. I've also pushed the corresponding patchset to https://tbpl.mozilla.org/?tree=Tryrev=88122a478851 For me that change make sense, since that brings ExecutableAllocator definition to jscntxt.h where as of now, it's used without knowing how it's defined. Except iirc, including that header leads to a failure to build on various architectures. So you'd fix what the patch here broke, but you break what the patch was supposed to fix. Well, not sure, since the patch removes #if ENABLE_YARR_JIT around the inclusion of assembler/jit/ExecutableAllocator.h and it doesnt seem to break that much things. But i agree it should be included _only_ if ENABLE_ASSEMBLER is set. It makes more sense, and the rest of the patch makes the presence of this header unneeded if ENABLE_ASSEMBLER is not set. The right solution is probably to define ENABLE_ASSEMBLER elsewhere than js/src/Makefile.in. Righto.. but ENABLE_YARR_JIT is not known when you're creating js- config.h, since it's in Makefile.in. and ENABLE_YARR_JIT is needed to know if we need to define ENABLE_ASSEMBLER. So ENABLE_YARR_JIT definition would have to go to configure too ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Trying to find a common denominator in the failing 9 tests : some tests fail for all 9 combinaisons of jit_test.py arguments : tests/basic/bug708805.js, bug713226.js, bug716013.js, bug728609.js, bug729364.js some fail for only 7 combinaisons out of 9, and goes into 2 classes : the ones that fail in all combinaisons but the ones where '-a -m -n' is used : bug722028.js, bug706316.js the ones that fail in all combinaisons but the ones where '-a -m' (but NOT -n!) is used : bug708228.js, bug707750.js Don't really see what the arguments mean.. -m = methodjit, but -a is also methodjit through 'mjitalways' ? -n is nitro ? A common denominator : all those tests (but bug729364.js) use 'gczeal(4)', but some not failing-tests use it too : bug734196.js, bug704795.js, bug710947.js, bug734196.js Other than that, i have no idea what can be the common thing between those tests, and why do they fail only on linux debug builds. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Re-read the diff, and a bit out of ideas i've pushed a similar changeset
with s/#if ENABLE_ASSEMBLER/#ifdef ENABLE_ASSEMBLER/, but i doubt it'll
change anything.
https://tbpl.mozilla.org/?tree=Tryrev=ff2bd33b8476
To me, JS_METHODJIT includes ENABLE_YARR_JIT, so that chunk in
js/src/vm/RegExpObject.cpp could go away.. :
-#ifdef JS_METHODJIT
+#if ENABLE_YARR_JIT defined(JS_METHODJIT)
if (isJITRuntimeEnabled(cx) !yarrPattern.m_containsBackreferences) {
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/908508
Title:
Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Try build still fails the same on debug builds only. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Review ping ? :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Set checkin-needed, carrying forward dmandelin's r+ on attachement 600506. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
So, what's needed to fix this ? Sorry, i have no idea why it changes behaviour for linux debug builds, since it's only shuffling ifdefs around... and the testsuite log isnt really verbose, besides saying there's a failure. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
patch #603183 reads good, applies fine on m-c. Doing a testbuild before setting checkin-needed, results in ~6h. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 603278 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported And here's a proper hg changeset, applied on top of m-c, running fine as Mozilla/5.0 (X11; OpenBSD macppc; rv:13.0) Gecko/20120306 Firefox/13.0a1 I took the liberty of removing the now useless comment in js/src/Makefile.in as Cameron said in comment #27. -# For architectures without YARR JIT, PCRE is faster than the YARR -# interpreter (bug 684559). I suppose we should let the dust settle before reopening the bug removing pcre... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Mike Hommey [:glandium] from comment #71) Well, if it's breaking linux debug builds, it means it's *not* only shuffling ifdefs around. So you should start by checking that. It shuffles ENABLER_YARR_JIT, adds #if ENABLE_ASSEMBLER around execAlloc, ENABLE_ASSEMBLER is set on tier1 archs, as is ENABLE_YARR_JIT. And i don't have a linux box anyway to try this on... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
The try builds on linux64 failed due to hg errors, i've asked the rebuild but the linux debug build shows the same failure. - what is the difference between debug and non debug builds in terms of JIT ? ENABLE_ASSEMBLER and ENABLE_YARR_JIT are set in both on linux, from what i can tell. - the patch doesnt touch anything under jsgcmark.cpp, and gCurrentCompartment is still initialized to null in jsapi.cpp:JSRuntime::JSRuntime(). The next (and only) initialization of cCurrentCompartment i could find is in jsgc.cpp:AutoGCSession::AutoGCSession(), called from GCCycle() in the same file. Anyway, from your debug session it even seems JSRuntime::JSRuntime() isnt called, since it's not defined to a viable value. - Any idea why those codepaths seems not used only in debug builds, and only with my changes ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Just to make sure, i've pushed the offending diff to try with -b do -p linux,linux64 : https://tbpl.mozilla.org/?tree=Tryrev=d77a3095728e -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Landry Breuil from comment #55) Created attachment 600506 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) That was it, with this new patch the build goes past js/. Changes from last patch : - update after landing of #700822, ie enclose use of execAlloc_ withing #if ENABLE_ASSEMBLER in jscntxt.cpp/setJitHardening() - remove #if ENABLE_YARR_JIT in checkSyntax - don't readd Assertions.cpp to CPPSRCS in !ENABLE_YARR_JIT case - include YarrSyntaxChecker.h inconditionally in js/src/vm/RegExpObject.h Results of the build in ~10h at http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/61 That particular build failed for other reasons (repository in a mixed state) but i've built successfully with that patch, and m-c works fine on OpenBSD/ppc. Chris, can you review it ? i see no reason to wait for 661974, and it would fix the build for exotic architectures. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Mike Hommey [:glandium] from comment #49) Yes, except that YarrSyntaxChecker.cpp is in CPPSRCS only in ENABLE_YARR_JIT case.. Both your patch and my older patch add YarrSyntaxChecker.cpp to CPPSRCS in the non-ENABLE_YARR_JIT case Yep, but YarrSyntaxChecker.h is only included within #ifdef ENABLE_YARR_JIT.. and even with that 'fixed', i'm now seeing the same error as Emmanuel Chourdakis. See bottom of http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/60/steps/build/logs/stdio for the full log error. # nm objdir/dist/lib/libjs_static.a | grep MOZ_ 0028 T MOZ_Assert T MOZ_Crash # nm objdir/dist/lib/libmozglue.a Assertions.o: F Assertions.cpp 0004 ? MOZ_Assert ? MOZ_Crash I sense something related to your last blog post and related to something which landed recently... any clue ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
ok i think i figured it out.. the patch readded Assertions.cpp to CPPSRCS, which was gone from the ENABLE_YARR_JIT case in https://hg.mozilla.org/mozilla- central/diff/71d144fbd53e/js/src/Makefile.in. The breakage might be because mfbt/ is in the search path, and it's that mfbt/Assertions.cpp that was included.. Testing a fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 600506 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) That was it, with this new patch the build goes past js/. Changes from last patch : - update after landing of #700822, ie enclose use of execAlloc_ withing #if ENABLE_ASSEMBLER in jscntxt.cpp/setJitHardening() - remove #if ENABLE_YARR_JIT in checkSyntax - don't readd Assertions.cpp to CPPSRCS in !ENABLE_YARR_JIT case - include YarrSyntaxChecker.h inconditionally in js/src/vm/RegExpObject.h Results of the build in ~10h at http://buildbot.rhaalovely.net/builders /mozilla-central-macppc/builds/61 So, now that the patch looks clean, can it be considered for inclusion ? bug 661974 can still be built on top of that.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Most likely fallout of #717540, maybe because of the support (supposedly, yes) of __attribute__((weak)) in our gcc.. Emmanueel, what's your compiler ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Yes, except that YarrSyntaxChecker.cpp is in CPPSRCS only in ENABLE_YARR_JIT case.. i'll wrap up a patch removing that #ifdef, and adding that cpp file to CPPSRCS in the !ENABLE_YARR_JIT case to see if it helps. Patch has to be updated anyway since landing of #700822 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Will that mean that !yarr-jit will become part of the 'regular testsuite', so that build breakage are detected on tbpl ? Ill monitor #661974, when you have something ready i'll try-compile it on ppc.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
And the build was successful, browsing maps.google.fr from my iBook G4 with http://buildbot.rhaalovely.net/builds/firefox-13.0a1.en- US.openbsd5.1-powerpc.tar.bz2. Apart checkSyntax, it should be okay. Chris, any idea what to do about that, and would it be so wrong to return true, given that it worksforme ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
in bug #684559 comment 34, cameron kaiser talks about the possibility of 'unless simply trying to build it (+/- throwing away the result) is acceptable.' to check syntax on !yarr_jit platforms, how would it be achievable ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 596748 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Same patch, updated. Build results in a few hours (if anything else didn't broke on exotic archs..) in http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/54 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 596771 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Grr mishmashed patch.. here's a correct one that at least should build js/. Results in http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/55 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Comment on attachment 594798 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Doesn't apply anymore since landing of bug #724748, since code was shuffled a bit. I'll try to come up with a new patch. Sigh. Can someone care a bit about that issue so that we get something commited, instead of chasing a moving target ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
how are you trying to build it jit-free ? those codepaths are not really tested.. and armv7 falls in the case where ENABLE_ASSEMBLER should be set, which builds ExecutablePool/Allocator code.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 594798 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) And here's a new updated patch after last commits to that area, which allows me to build m-c on sparc64 and ppc, i've run dromaeo kraken tests on ppc for a bunch of hours without issues (can post results if needed), and i'm posting the patch from 'Mozilla/5.0 (X11; OpenBSD macppc; rv:13.0a1) Gecko/20120206 Firefox/13.0a1'. It adds #if ENABLE_ASSEMBLER around execAlloc_ uses, which seems enough for it to run. Of course this stills unconditionally returns true in checkSyntax(), which i suppose is deeply wrong, but at least it fixes the build for those platforms. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Since landing of bug #688069, previous patch (#591376) doesn't apply anymore (regExpPrivateCode disappeared/was renamed ?). I have a bad feeling about fighting for a lost cause, and chasing a moving target i don't know the code nor how it works, and blindly adding #ifdefs while trying to 'backport' the patch depresses me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 591376 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) And here's the corresponding patch, ie porting mike's patch to -current, adds #if ENABLE_ASSEMBLER around ExecutableAllocator definitions/uses (instead of pulling assembler/ExecutableAllocator.cpp in the build), and still ugly return true in checkSyntax, for which i don't know what to do.. m-c builds and starts on ppc with that patch, but i've not really tested it (only ssh -X..). Would really appreciate things going forward. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Mike Hommey [:glandium] from comment #29) Yes, but for sparc, it's more subtle: ENABLE_ASSEMBLER needs to be set for the normal non YARR JIT. Man, what a mess. How is it a problem, since sparc is on the ENABLE_YARR_JIT side ? And even if it wasn't, that wouldnt be an issue if we use your part of the js/src/Makefile.in patch, it sets ENABLE_ASSEMBLER for sparc too, since it has ENABLE_METHODJIT set to 1 in js/src/configure.in. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Mike Hommey [:glandium] from comment #26)
That's why ENABLE_ASSEMBLER needs to be off.
But if ENABLE_ASSEMBLER is conditional to
ENABLE_YARR_JIT|ENABLE_METHODJIT in Makefile.in, build fails in
jscntxt.{cpp,h}/jsprvtd.h due to missing def of struct
JSC::ExecutableAllocator (see comment #18). All those uses are
inconditional right now, so do you mean they should be made conditional
to ENABLE_ASSEMBLER (or ENABLE_YARR_JIT) too ?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/908508
Title:
Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Chris Leary [:cdleary] from comment #19) (In reply to Landry Breuil from comment #18) Another annoyance was the landing of bug #673188, which right now #errors out if ENABLE_YARR_JIT is unset (see RegExpObject.cpp, function checkSyntax()), pretty unfriendly. So far i've replaced it by a return true, but it's of course ugly. It's required for lazy regular expression compilation -- you have to detect errors in the syntax immediately for error reporting purposes. Continuing to use the YARR parser to report errors when you're using the PCRE backend could result in a mismatch where the PCRE parser believes there to be an error in the pattern that YARR did not detect, which would result in incorrect semantics (because you have no way of reporting the error when you're doing the lazy compilation). Sorry, I should have put a comment in if I didn't! The patch we're working on aims to replace PCRE interpreter by YARR interpreter.. if i get it right, we wouldn't use the PCRE parser anymore, so there would be no mismatch ? Of course, i don't see how to do syntax checking with YARR interpreter without YARR JIT, as JSC::Yarr::checkSyntax() isn't defined when !ENABLE_YARR_JIT. Help appreciated... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Cameron Kaiser from comment #10) I'm good with that. We're using YARR JIT in PowerPC now anyway. Can you detail how you achieved that (in TenFourFox i suppose), how related is it to nanojit on ppc (#624164), and if the corresponding code is commited to m-c, or candidate to be ? I'm trying to understand all the inter-relations... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 589953 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Here's the patch updated to m-c, with the following changes wrt previous patch against beta : - return true instead of #error'ing in syntaxCheck. (no idea what to do for that) - assembler/jit added to VPATH in js/src/Makefile.in (for !yarr_jit) - ExecutableAllocator.cpp/ExecutableAllocatorPosix.cpp added to CPPSRCS (for !yarr_jit) This allows me to build m-c on sparc64. I'm now trying to build on ppc to see if it actually runs, but it seems bug #703534 is back, as of now i'm getting again the #error about missing cacheFlush (which for now i'll define as empty..). Not setting any review, but i'd like feedback... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
For the record, the build failure on sparc64/ppc/!YARR_JIT is now on m-c : c++ -o jsanalyze.o -c -fvisibility=hidden -DOSTYPE=\OpenBSD5\ -DOSARCH=OpenBSD -DEXPORT_JS_API -DIMPL_MFBT -DJS_HAS_CTYPES -DDLL_PREFIX=\lib\ -DDLL_SUFFIX=\.so.1.0\ -DNO_NSPR_10_SUPPORT -Ictypes/libffi/include -I. -I/var/buildslave/mozilla-central-sparc64/build/js/src -I. -I./../../dist/include -I./../../dist/include/nsprpub -I/var/buildslave/mozilla-central-sparc64/build/obj-sparc64-unknown-openbsd5.1/dist/include/nspr -I/var/buildslave/mozilla-central-sparc64/build/js/src -I/var/buildslave/mozilla-central-sparc64/build/js/src/assembler -I/var/buildslave/mozilla-central-sparc64/build/js/src/yarr -fPIC -fno-rtti -pedantic -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -pthread -pipe -DNDEBUG -DTRIMMED -g -O -fomit-frame-pointer -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/jsanalyze.pp /var/buildslave/mozilla-central-sparc64/build/js/src/jsanalyze.cpp In file included from /var/buildslave/mozilla-central-sparc64/build/js/src/vm/RegExpObject.h:56, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsscriptinlines.h:53, from /var/buildslave/mozilla-central-sparc64/build/js/src/vm/Stack-inl.h:50, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsinferinlines.h:50, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsanalyze.cpp:45: /var/buildslave/mozilla-central-sparc64/build/js/src/yarr/pcre/pcre.h:49:18: error: jstl.h: No such file or directory In file included from /var/buildslave/mozilla-central-sparc64/build/js/src/jsscriptinlines.h:53, from /var/buildslave/mozilla-central-sparc64/build/js/src/vm/Stack-inl.h:50, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsinferinlines.h:50, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsanalyze.cpp:45: /var/buildslave/mozilla-central-sparc64/build/js/src/vm/RegExpObject.h:290:3: error: #error Syntax checking not implemented for !ENABLE_YARR_JIT In file included from /var/buildslave/mozilla-central-sparc64/build/js/src/jsscriptinlines.h:53, from /var/buildslave/mozilla-central-sparc64/build/js/src/vm/Stack-inl.h:50, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsinferinlines.h:50, from /var/buildslave/mozilla-central-sparc64/build/js/src/jsanalyze.cpp:45: /var/buildslave/mozilla-central-sparc64/build/js/src/vm/RegExpObject.h: In static member function 'static bool js::detail::RegExpPrivateCode::checkSyntax(JSContext*, js::TokenStream*, JSLinearString*)': /var/buildslave/mozilla-central-sparc64/build/js/src/vm/RegExpObject.h:292: error: no return statement in function returning non-void -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
I started updating the patch from comment #13 to hg tip, but so far on sparc64 it fails with : js/src/jscntxt.cpp: In member function 'void js::ThreadData::sizeOfExcludingThis(size_t (*)(const void*, size_t), size_t*, size_t*, size_t*, size_t*)': js/src/jscntxt.cpp:163: error: invalid use of incomplete type 'struct JSC::ExecutableAllocator' js/src/jsprvtd.h:335: error: forward declaration of 'struct JSC::ExecutableAllocator' js/src/jscntxt.h: In member function 'void JSRuntime::delete_(T*) [with T = JSC::ExecutableAllocator]': js/src/jscntxt.cpp:125: instantiated from here js/src/jscntxt.h:712: error: invalid use of incomplete type 'struct JSC::ExecutableAllocator' js/src/jsprvtd.h:335: error: forward declaration of 'struct JSC::ExecutableAllocator' js/src/jscntxt.h: In member function 'T* JSRuntime::new_() [with T = JSC::ExecutableAllocator]': js/src/jscntxt.cpp:201: instantiated from here js/src/jscntxt.h:711: error: invalid application of 'sizeof' to incomplete type 'JSC::ExecutableAllocator' js/src/jscntxt.h:711: error: invalid use of incomplete type 'struct JSC::ExecutableAllocator' js/src/jsprvtd.h:335: error: forward declaration of 'struct JSC::ExecutableAllocator' Of course, it makes sense to me, since JSC::ExecutableAllocator is defined only if ENABLE_ASSEMBLER is set, and the chunk in js/src/Makefile.in makes it unset if ENABLE_YARR_JIT is not set. I'm now trying with that chunk out on sparc64 and will try various hacks. if i get something that builds i'll post the patch for actual testing on ppc. I really wonder how m-c builds on ppc right now, what changed recently in that regard, and how TenFourFox does to build Another annoyance was the landing of bug #673188, which right now #errors out if ENABLE_YARR_JIT is unset (see RegExpObject.cpp, function checkSyntax()), pretty unfriendly. So far i've replaced it by a return true, but it's of course ugly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Comment on attachment 588391 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported I can confirm that this patch allows me to build start firefox 10.0b4 on OpenBSD/powerpc... now, to see what to do for m-c. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Just to clarify.. is your patch in debian a build fix for fx 10.0beta on ppc sparc, or only sparc ? currently 10.0b4 as is fails to build for me on ppc, since it doesn't support yarr jit and !ENABLE_YARR_JIT is not really maintained. I have a simple build fix, but i don't know yet if it allows fx to run fine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 740815]
Interested in this aswell for OpenBSD, i was planning to do an update to our old spidermonkey 1.7.0 port from firefox 4 source tarball until i saw that bug report. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to gwt in Ubuntu. https://bugs.launchpad.net/bugs/740815 Title: [FFe] Updates to enable us to drop xulrunner from main -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 740815]
Interested in this aswell for OpenBSD, i was planning to do an update to our old spidermonkey 1.7.0 port from firefox 4 source tarball until i saw that bug report. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740815 Title: [FFe] Updates to enable us to drop xulrunner from main -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
