[Bug 1809206]

2020-05-02 Thread jwrdegoede
I see that you have already filed:
https://bugzilla.redhat.com/show_bug.cgi?id=1830475

Can you please attach full dmesg output and an acpidump ("sudo acpidump
-o acpidump.txt") there ?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1809206

Title:
  Amd ACPI Error

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1809206/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1809206]

2020-05-02 Thread jwrdegoede
(In reply to Jeffrey Walton from comment #18)
> Add a mee too. Hardware is ProLiant DL360 G5. Software is Fedora Server 32
> released Apeil 2020. Machine is fully patched.

You are still seeing this with a Fedora 32? This should be fixed at
least on HP laptops. I guess we still hve some work to do for the
servers.

Can you file a bug against Fedora (bugzilla.redhat.com, component
kernel) and attach an acpidump and dmesg output from Fedora 32 there
please?

And please provide a link to the filed bug here, then I will take a look
as time permits.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1809206

Title:
  Amd ACPI Error

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1809206/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1861573]

2020-05-02 Thread jwrdegoede
I see that you have already filed:
https://bugzilla.redhat.com/show_bug.cgi?id=1830475

Can you please attach full dmesg output and an acpidump ("sudo acpidump
-o acpidump.txt") there ?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1861573

Title:
  Mutliple ACPI errors on HP Omen 15 2019 with hp-wmi module

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1861573/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1861573]

2020-05-02 Thread jwrdegoede
(In reply to Jeffrey Walton from comment #18)
> Add a mee too. Hardware is ProLiant DL360 G5. Software is Fedora Server 32
> released Apeil 2020. Machine is fully patched.

You are still seeing this with a Fedora 32? This should be fixed at
least on HP laptops. I guess we still hve some work to do for the
servers.

Can you file a bug against Fedora (bugzilla.redhat.com, component
kernel) and attach an acpidump and dmesg output from Fedora 32 there
please?

And please provide a link to the filed bug here, then I will take a look
as time permits.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1861573

Title:
  Mutliple ACPI errors on HP Omen 15 2019 with hp-wmi module

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1861573/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1809206]

2019-12-03 Thread jwrdegoede
The fixes for this have landed upstream, closing.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1809206

Title:
  Amd ACPI Error

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1809206/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1809206]

2019-11-27 Thread jwrdegoede
I've recently hit this seem issue, this is caused by the hp-wmi driver
passing a buffer which is not big enough when making WMI related ACPI
calls. I've submitted a patch-series which fixes this upstream:

https://lore.kernel.org/patchwork/project/lkml/list/?series=419906

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1809206

Title:
  Amd ACPI Error

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/1809206/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-12-16 Thread jwrdegoede
(In reply to Seth Shelnutt from comment #106)
> I've just updated to 4.19.9, verified the patch was included, and I'm now
> getting:
> 
> cmi: probe of SMB0001:00 failed with error -5

That error can be safely ignored, the CMI device is not used on your
laptop, 4.20 will have a patch silencing this error.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-30 Thread jwrdegoede
(In reply to Bram Coenen from comment #99)
> First of all thank you helping out Hans. I got the same problem with "irq 7:
> nobody cared" and made a bug report over here:
> https://bugzilla.kernel.org/show_bug.cgi?id=201817 . I'm new to bug
> reporting, so I hope I did it right!

Thanks, lets continue this in the new bug.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-28 Thread jwrdegoede
(In reply to Addie Morrison from comment #96)
> Is anyone else seeing the issue where the touchscreen/pen don't work when
> the computer is first powered on (needs to be rebooted at least once)? If
> so, was this supposed to be fixed by this or should that be a separate bug
> report?

When this happens do you see any relevant messages in dmesg ?

In: https://bugzilla.redhat.com/show_bug.cgi?id=1644013

There is a report of the machine sometimes reporting:

[5.739281] irq 7: nobody cared (try booting with the "irqpoll" option)
[5.739284] CPU: 5 PID: 0 Comm: swapper/5 Tainted: G C
4.19.2-301.hdg1.fc29.x86_64 #1
[5.739285] Hardware name: HP HP ENVY x360 Convertible 15-cp0xxx/8497, BIOS 
F.21 10/19/2018
[5.739285] Call Trace:
[5.739288]  
[5.739294]  dump_stack+0x5c/0x80
[5.739297]  __report_bad_irq+0x37/0xae
[5.739298]  note_interrupt.cold.9+0xa/0x69
[5.739300]  handle_irq_event_percpu+0x6a/0x80
[5.739301]  handle_irq_event+0x27/0x44
[5.739302]  handle_fasteoi_irq+0x7f/0x120
[5.739305]  handle_irq+0xbf/0x100
[5.739307]  do_IRQ+0x49/0xd0
[5.739308]  common_interrupt+0xf/0xf
[5.739309]  

After which the kernel disables IRQ 7 causing the touchscreen to not
work again.

If you're seeing this too, please open a new bug for the "irq 7: nobody
cared" problem.

The patch fixing the IRQ not being assigned to the GPIO controller has
been merged upstream now, so I'm closing this bug.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-25 Thread jwrdegoede
(In reply to Maxime from comment #92)
> What do you mean with a HID component in this case? A stylus?

I mean the Product and Component fields in bugzilla, for the new bug.
E.g. this bug has Product set the ACPI and Component set to Config-
Tables.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-21 Thread jwrdegoede
(In reply to Maxime from comment #87)
> I applied the latest patch, it works but it makes my touchscreen show up as
> having a battery that's at 0%. The previous patch had the same behaviour on
> my system.

Good to hear that this patch works for you to.

The battery at 0% is an unrelated issue, please file a new bug against
product Drivers component HID (or input if there is no HID component)
for this.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
(In reply to Marc from comment #79)
> Created attachment 279541 [details]
> Output of dmesg after booting kernel 4.19.2 with new patch v2 (touchscreen
> works)
> 
> Congratulations, this work!

Great and the "ACPI: IRQ 7 override to edge, high" message is gone. So
you've proven my theory.

Now I need to improve the commit message and then this patch can be
submitted upstream.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
p.s.

I plan to add the following to the commit msg, please let me know if
you've objections against this:

Reported-by: Lukas Kahnert 
Tested-by: Marc 

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
First if all thank you Lukas, for pinpointing the problem. I don't see
any really obvious nice answer here.

So I believe it is best to override the IRQ type manually in the AMD
gpio driver to correct the acpi_get_override_irq() results from the ACPI
core.

I've attached a patch doing this to bug 199523.

If someone who is seeing this issue can build and test a kernel with
that patch (replacing Lukas patch) that would be great. To be clear
please drop Lukas' patch  when testing mine!

If you test my patch, please provide the output of "dmesg" directly
after boot and let me know if the patch fixes things (makes/keeps the
touchscreen working).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
(In reply to Lukas Kahnert from comment #76)
> This error happens because your patch only fixes the mis-detection of the
> IRQ. There ist still https://bugzilla.kernel.org/show_bug.cgi?id=199529
> which needs also bei fixed to get the touchscreen work.

Right, I figured that out now, actually I believe that with your hack to
drivers/acpi/resource.c the changes you made to drivers/base/platform.c
should no longer be necessary.

We've been looking at the wrong part of the DSDT the culprit is not:

Interrupt (ResourceConsumer, Level, ActiveLow, Shared, ,, )
{
0x0007,
}

This uses an extended interrupt syntax, so acpi_dev_get_irqresource() gets 
called with legacy == false and the troublesome acpi_get_override_irq()
never happens.

I believe the real culprit is:

Scope (_SB.PCI0)
{
Device (SMBD)
{
Name (_HID, "SMB0001")  // _HID: Hardware ID
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
IO (Decode16,
0x0B20, // Range Minimum
0x0B20, // Range Maximum
0x20,   // Alignment
0x20,   // Length
)
IRQ (Level, ActiveLow, Shared, )
{7}
})
}
}

Which does use a legacy style IRQ resource, this causes
acpi_dev_get_irqresource() to be called with legacy == true and then the
troublesome acpi_get_override_irq() happens.

I believe that this troublesome node gets parsed before the AMDI0030
node and then by the time the AMDI0030 node happens, inside
acpi_dev_get_irqresource() we hit the else of:

irq = acpi_register_gsi(NULL, gsi, triggering, polarity);
if (irq >= 0) {
res->start = irq;
res->end = irq;
} else {
acpi_dev_irqresource_disabled(res, gsi);
}

Which sets the DISABLED flag, which is causing the issue in
drivers/base/platform.c . The reason we hit the else path is because of
the earlier enumeration of the same interrupt with conflicting trigger /
polarity settings so the second one fails with -EBUSY (it would work if
the flags would match).

My new attempt deals with this by adding the "SMB0001" HID to the
blacklist for creating platform devices, so that
acpi_dev_get_resources() does not get called on it at all, avoiding the
call of acpi_dev_get_irqresource() with legacy == false.

The not creating of a platform_device for the "SMB0001" HID is not an
issue since the driver for it is an acpi bus driver not a platform bus
driver.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
Created attachment 279539
[PATCH] ACPI / platform: Add SMB0001 HID to forbidden_id_list

Ok second attempt, a completely different patch which I think actually
is better (if it works).

Please give this one a try (without any other patches for this same
issue).

Again please attach dmesg output.

If this patch does not fix things, then also please attach the output
of:

ls /sys/bus/platform/devices

I would like the output of that command for both a kernel without the
patch as well as for one with the patch.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
(In reply to Marc from comment #70)
> I would test the patch but can't find it.

My bad, I was updating the 3 different bugs about this all at the same
time and I actually forgot to attach the patch, it is attached to bug
199523 now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1752437]

2018-11-19 Thread jwrdegoede
(In reply to Marc from comment #73)
> Unfortunately the new patch does not work on my ENVY 15-bq102ng.
> 
> I used linux kernel 4.19.2 from kernel.org, patched it with the ubuntu
> mainline patches and on top your patch (instead of Lukas patch).

Thank you for testing. These 2 lines in the log seem to be the problem,
these happen before my patch even comes into play:

[1.445982] amd_gpio AMDI0030:00: Failed to get gpio IRQ: -22
[1.446019] amd_gpio: probe of AMDI0030:00 failed with error -22

With -22 being -EINVAL.

Taking a closer look at things here I think I know what is going on
here.

To be continued.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1752437

Title:
  [HP ENVY x360 - 15-bq102ng] Touchscreen does not work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kernel/+bug/1752437/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs