[Bug 1479014] Re: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section
** Changed in: ubuntu-gnome Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section
This has been fixed in wily, I don't think its a good idea to sru 7 different patches into vivid at this late stage in the cycle (it will be EOL in a few months). For the most part these are largely cosmetic fixes and clearly some of these patches caused regressions, hence the large number of patches, so its not clear if other patches have been missed. ** Changed in: gnome-shell (Ubuntu Vivid) Status: Triaged => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section
This bug was fixed in the package gnome-shell - 3.16.4-0ubuntu1 --- gnome-shell (3.16.4-0ubuntu1) wily; urgency=medium * New upstream release - fixes issues with gdm Auth prompt LP: #1479014 -- Tim LunnSun, 18 Oct 2015 08:43:05 +1100 ** Changed in: gnome-shell (Ubuntu Wily) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section
** Also affects: gnome-shell (Ubuntu Wily) Importance: Low Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section
** Patch removed: "lp1479014_vivid_v1.debdiff" https://bugs.launchpad.net/ubuntu/vivid/+source/gnome-shell/+bug/1479014/+attachment/4437034/+files/lp1479014_vivid_v1.debdiff ** Patch removed: "lp1479014_vivid_v2.debdiff" https://bugs.launchpad.net/ubuntu/vivid/+source/gnome-shell/+bug/1479014/+attachment/4443022/+files/lp1479014_vivid_v2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
** Description changed: [Impact] There are five patches in this one fix. So there are five bugs which are fixed: - Bug [1]: If the Next button ever gets set to Sign In, it won't get reset to next until the next question asked by pam. - Bug [2]: Normally the user isn't allowed to proceed passed the username question until they've filled it in. To ensure this, the authprompt code desensitizes the next button when the number of characters change to zero. Unfortunately it fails to desensitize the next button up front when the entry starts out empty. - Bug [3]: Users are not allowed to cancel if the verification has not started yet and they are typing in their username. - Bug [4]: If the authPrompt gets reset for some other reason in the interim, this would mean that we don't fade the authentication prompt back in when it is needed. - Bug [5]: The user session will crash when the login screen is reactivated due to the fact that the previous the user verifier has not been cleared. + - Bug [6]: (LP: #752220) We currently only cancel the user verifier on + reset if verifying, but that means we don't properly cancel it when + asking for a username at the Not Listed screen. + These are rather important things to be fixed as they make the login process more confusing and difficult. How the bugs are fixed: - Bug [1] fix: Reset Next button to Next when asking for username. - Bug [2] fix: Disallow the user to press Next when the username field is empty up front. - Bug [3] fix: authPrompt no longer ignores the request to cancel before a user has started verification and is still typing in their username. - Bug [4] fix: loginDialog now only skips the fade-in if we have already - fadded-in. It now also only skips resetting if we have already reset. + faded-in. It now also only skips resetting if we have already reset. - Bug [5] fix: We now make sure that once the user verifier has completed its job (of user verification) that it gets cleared so that it does not get in the way later. + + - Bug [6] fix: We now unconditionally cancel if the user verifier has + been reset. [Test Case] - Reproduce Bug [1]: On the first login screen (or log out - not lock), click Sign In?, then before doing anything else click Sign In, if the button allows you to press it and is not greyed out, then you have successfully reproduced this bug. - Reproduce Bug [2]: On the locked screen click Sign In?, then before doing anything else press Cancel. If nothing happens, you have successfully reproduced this bug. - Reproduce Bug [3]: On the locked screen click Sign In?, then in the username field, start entering your username (or any text), then instead of pressing Next, press Cancel, if nothing happens then you have successfully reproduced this bug. - Reproduce Bug [4]: Go to the login screen (or locked screen), reset the authentication prompt before you have reached VERIFICATION_SUCCEEDED, and if you see that the prompt does not fade back in, then you have successfully reproduced this bug. - - Reproduce Bug [5]: + - Reproduce Bug [5]: After you have logged in, go back to the login screen, if the user session crashes, then you have successfully reproduced this bug. + + - Reproduce Bug [6]: + + On the login screen go to the Not Listed section, and then attempt to + cancel. If it does not let you, then you have successfully reproduced + this bug. [Regression Potential] As these patches have already been put to practical use in the upstream version, and the patches which have been put to use in this version, have originated from those patches, I would say that the risk of regression is minimal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
** Patch added: lp1479014_vivid_v3.debdiff https://bugs.launchpad.net/ubuntu/vivid/+source/gnome-shell/+bug/1479014/+attachment/4443308/+files/lp1479014_vivid_v3.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim, ok, I have applied that patch, and created a new debdiff with all 6 patches in it and attached it here. Let me know if you need anything else. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim, ok, I did not see that one, but I would be happy to add it in and I should be able to give you a new debdiff with it included by the end of the day if not sooner. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
see https://bugzilla.gnome.org/show_bug.cgi?id=752438, that is what caused bug 753181 ** Bug watch added: GNOME Bug Tracker #752438 https://bugzilla.gnome.org/show_bug.cgi?id=752438 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
How should I get them to do that? Do I just file a new bug report or try and get in contact with them? Also, does this mean that the debdiff will be scrapped, or will that still go in? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
email gnome-shell list. For vivid it will need backport so 6 patches, not sure thats worth but if you want to prepare ok, can push though On 11/08/15 19:41, The Unknown wrote: How should I get them to do that? Do I just file a new bug report or try and get in contact with them? Also, does this mean that the debdiff will be scrapped, or will that still go in? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
Ok, I'll make the debdiff, also you refer to 6 patches, but I only see 5, as we have the 3 I have already done, and then 2 in the new bug report, so where's the 6th one? Or are there only 5? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim, ok, I'll make the debdiff, also you refer to 6 patches, but I only see 5, as we have the 3 I have already done, and then 2 in the new bug report, so where's the 6th one? Or are there only 5? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
As I could not find the 3rd patch you said you wanted me to add in, I have added the two in the bug report: https://bugzilla.gnome.org/show_bug.cgi?id=753181 There seem to only be 2 extra patches needed to fix the bugs. If there is another patch which needs to be included, please let me know and I'd be happy to do so. I have generated a new debdiff with all 5 patches in it. And also updated the description, although my information on reproducing the last 2 bugs is a little vague because I have not actually experienced them as I would need to test the other patches in a testing environment to get the 2 other new bugs, and I have not. I have now also attached the new debdiff. ** Description changed: [Impact] - There are three patches in this one fix. So there are three bugs which - are fixed: + There are five patches in this one fix. So there are five bugs which are + fixed: - Bug [1]: If the Next button ever gets set to Sign In, it won't get reset to next until the next question asked by pam. - Bug [2]: Normally the user isn't allowed to proceed passed the username question until they've filled it in. To ensure this, the authprompt code desensitizes the next button when the number of characters change to zero. Unfortunately it fails to desensitize the next button up front when the entry starts out empty. - Bug [3]: Users are not allowed to cancel if the verification has not started yet and they are typing in their username. + - Bug [4]: If the authPrompt gets reset for some other reason in the + interim, this would mean that we don't fade the authentication prompt + back in when it is needed. + + - Bug [5]: The user session will crash when the login screen is + reactivated due to the fact that the previous the user verifier has not + been cleared. + These are rather important things to be fixed as they make the login process more confusing and difficult. How the bugs are fixed: - Bug [1] fix: Reset Next button to Next when asking for username. - Bug [2] fix: Disallow the user to press Next when the username field is empty up front. - Bug [3] fix: authPrompt no longer ignores the request to cancel before a user has started verification and is still typing in their username. + + - Bug [4] fix: loginDialog now only skips the fade-in if we have already + fadded-in. It now also only skips resetting if we have already reset. + + - Bug [5] fix: We now make sure that once the user verifier has + completed its job (of user verification) that it gets cleared so that it + does not get in the way later. [Test Case] - Reproduce Bug [1]: On the first login screen (or log out - not lock), click Sign In?, then before doing anything else click Sign In, if the button allows you to press it and is not greyed out, then you have successfully reproduced this bug. - Reproduce Bug [2]: On the locked screen click Sign In?, then before doing anything else press Cancel. If nothing happens, you have successfully reproduced this bug. - Reproduce Bug [3]: On the locked screen click Sign In?, then in the username field, start entering your username (or any text), then instead of pressing Next, press Cancel, if nothing happens then you have successfully reproduced this bug. + - Reproduce Bug [4]: + + Go to the login screen (or locked screen), reset the authentication + prompt before you have reached VERIFICATION_SUCCEEDED, and if you see + that the prompt does not fade back in, then you have successfully + reproduced this bug. + + - Reproduce Bug [5]: + + After you have logged in, go back to the login screen, if the user + session crashes, then you have successfully reproduced this bug. + [Regression Potential] - 1. You may notice that we only fade the authentication prompt back in if - the auth prompt status is VERIFICATION_SUCCEEDED. It's possible for it - to be NOT_VERIFYING if the authprompt gets reset for some other reason - in the interim. - - 2. You may also notice that the user session crashes when the login - screen is reactivated. + As these patches have already been put to practical use in the upstream + version, and the patches which have been put to use in this version, + have originated from those patches, I would say that the risk of + regression is minimal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
** Patch added: lp1479014_vivid_v2.debdiff https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1479014/+attachment/4443022/+files/lp1479014_vivid_v2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
** Description changed: [Impact] There are three patches in this one fix. So there are three bugs which are fixed: - Bug [1]: If the Next button ever gets set to Sign In, it won't get reset to next until the next question asked by pam. - Bug [2]: Normally the user isn't allowed to proceed passed the username question until they've filled it in. To ensure this, the authprompt code desensitizes the next button when the number of characters change to zero. Unfortunately it fails to desensitize the next button up front when the entry starts out empty. - Bug [3]: Users are not allowed to cancel if the verification has not started yet and they are typing in their username. These are rather important things to be fixed as they make the login process more confusing and difficult. How the bugs are fixed: - Bug [1] fix: Reset Next button to Next when asking for username. - Bug [2] fix: Disallow the user to press Next when the username field is empty up front. - Bug [3] fix: authPrompt no longer ignores the request to cancel before a user has started verification and is still typing in their username. [Test Case] - Reproduce Bug [1]: On the first login screen (or log out - not lock), click Sign In?, then before doing anything else click Sign In, if the button allows you to press it and is not greyed out, then you have successfully reproduced this bug. - Reproduce Bug [2]: On the locked screen click Sign In?, then before doing anything else press Cancel. If nothing happens, you have successfully reproduced this bug. - Reproduce Bug [3]: On the locked screen click Sign In?, then in the username field, start entering your username (or any text), then instead of pressing Next, press Cancel, if nothing happens then you have successfully reproduced this bug. - [Regression potential] + [Regression Potential] - As these patches have already been put to practical use in the upstream - version, and the patches which have been put to use in this version, - have originated from those patches, I would say that the risk of - regression is minimal. + 1. You may notice that we only fade the authentication prompt back in if + the auth prompt status is VERIFICATION_SUCCEEDED. It's possible for it + to be NOT_VERIFYING if the authprompt gets reset for some other reason + in the interim. + + 2. You may also notice that the user session crashes when the login + screen is reactivated. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim, or would you prefer to deal with it? Although I would be happy to if you want? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim, I was recently alerted to the fact that those patches also cause this bug: https://bugzilla.gnome.org/show_bug.cgi?id=753181 There are patches available to fix the bug caused by the other patches, what do you want me to do? Create a new debdiff? Add to the old? Or would this be for a different bug report with a new debdiff applying the patches? As this is the sort of thing that I would assume goes in the regression potential section, I have included details of it there. ** Bug watch added: GNOME Bug Tracker #753181 https://bugzilla.gnome.org/show_bug.cgi?id=753181 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
At this point I would suggest you try and get upstream to make a new point release (i.e. 3.16.4) that would be more preferable than pulling in the 6 odd patches that are required to fix this bug! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim (darkxst) ACK on that. Note that he *did* have to backport the patches and adjust them, as they didn't cleanly apply apparently, from what he told me in other chats, so I'm not sure the git headers would survive that process. The Unknown also has said that he's also unsure of regression potentials. Note that that I try and avoid desktop packages like the plague, usually, and triage thereof, I'm hesitant about the procedure here. Also, I'm not actually subscribed to this bug, as I already get server team bugs and several other packages' bugs, as well as USNs and DSAs, and security updates from other sources, so my emails and bug attentiveness levels are already innundated. I'll remember what you said in the future though. -- Thomas -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
@Tim, Ok, well I have tried my best to do the regressions potential section, although I understand that it may not be up to standards, but at least I found something to put in there. ** Description changed: [Impact] There are three patches in this one fix. So there are three bugs which are fixed: - Bug [1]: If the Next button ever gets set to Sign In, it won't get reset to next until the next question asked by pam. - Bug [2]: Normally the user isn't allowed to proceed passed the username question until they've filled it in. To ensure this, the authprompt code desensitizes the next button when the number of characters change to zero. Unfortunately it fails to desensitize the next button up front when the entry starts out empty. - Bug [3]: Users are not allowed to cancel if the verification has not started yet and they are typing in their username. These are rather important things to be fixed as they make the login process more confusing and difficult. How the bugs are fixed: - Bug [1] fix: Reset Next button to Next when asking for username. - Bug [2] fix: Disallow the user to press Next when the username field is empty up front. - Bug [3] fix: authPrompt no longer ignores the request to cancel before a user has started verification and is still typing in their username. [Test Case] - Reproduce Bug [1]: On the first login screen (or log out - not lock), click Sign In?, then before doing anything else click Sign In, if the button allows you to press it and is not greyed out, then you have successfully reproduced this bug. - Reproduce Bug [2]: On the locked screen click Sign In?, then before doing anything else press Cancel. If nothing happens, you have successfully reproduced this bug. - Reproduce Bug [3]: On the locked screen click Sign In?, then in the username field, start entering your username (or any text), then instead of pressing Next, press Cancel, if nothing happens then you have successfully reproduced this bug. + + [Regression potential] + + As these patches have already been put to practical use in the upstream + version, and the patches which have been put to use in this version, + have originated from those patches, I would say that the risk of + regression is minimal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1479014] Re: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section
** Summary changed: - Cancel button does not work at first when selecting user that is not listed on login screen + Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1479014 Title: Cancel, Next, and Sign In functioning incorrectly on login or locked screen in Sign In? section To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs