[Bug 1594585] Re: [needs packaging] budgie-wallpapers
** Package changed: ubuntu => budgie-wallpapers (Ubuntu) ** Changed in: budgie-wallpapers (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/budgie-wallpapers/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
Thanks. Uploaded to yakkety. I didn't realize what unsplash was until now. It might be worth pointing to https://unsplash.com/license in your debian/copyright in a future update, because I couldn't find a license mentioned directly on any of the unsplash URLs you listed. My comment about the rotating wallpapers was just a suggestion, definitely not mandatory or anything. It is of course possible for people using other desktop environments to install those wallpapers too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
thanks Jeremy for your review 1 + 4. Debian/Copyright Files * moved to the first position and added the additional copyright holders 2 + 3. Separated each of the wallpaper copyright holders and added a comment linking to the source URL optionals - 1. rules - done 2. regenerated the .pot 3. yep - did see the contest folder. Happy to do so if you want me to - however for budgie-desktop it does not support rotating wallpapers just yet (https://github.com/solus-project/budgie-desktop/issues/261) ** Bug watch added: github.com/solus-project/budgie-desktop/issues #261 https://github.com/solus-project/budgie-desktop/issues/261 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
Thank you for updating the package! A native package is fine here. I have one thing I'd like you to fix before I'll upload: Your debian/copyright doesn't quite follow the format. 1. "The last paragraph that matches a particular file applies to it. More general paragraphs should therefore be given first, followed by more specific overrides." In other words, the Files: * section should be the first section not the last. 2. If you downloaded the file from a particular URL that lists the copyright, it might be nice to include it in a Comment section so that it's easier for someone that wanted to verify the file's license. 3. The names of Files in d/copyright need to match the actual file names. Therefore a section could look something like: Files: beauty_of_mandarins_by_erwan_hesry.jpg Copyright: Erwan Hesry Comment: http://... License: CC0 4. I think you should keep the Files: * copyright holders from ubuntu- wallpapers (Nathan McCallum, etc.) since they originally wrote the scripts included in the source but feel free to add your name to the list. Here's a few optional notes: 1. In debian/rules, the export DPKG_GENSYMBOLS_CHECK_LEVEL=4 is unnecessary since this package doesn't contain any shared libraries so it doesn't use symbols. (Yes I see that the ubuntu-wallpapers package does this and #1 above.) 2. Maybe you should regenerate po/budgie-wallpapers.pot 3. Did you see the contest/ folder in ubuntu-wallpapers? It adds a special wallpaper (identified in the GNOME Settings app by a small clock in the bottom right corner) that automatically rotates the listed wallpapers every 30 min. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
Hi Jeremy, finally found some time to revisit this - sorry for the delay (was busy with the 16.04.1 release of budgie-remix) The team have chosen brand-new wallpapers for 16.04.1 - all under the CC0 license which according to debian & freedesktop is a nice license - completely public domain and allows commercial use (https://creativecommons.org/publicdomain/zero/1.0/). I've linked that in the debian/copyright I had a look at the ubuntu-gnome-wallpapers package version - it was 16.04.1 so I hope you don't mind, I made this package a native package and called it 16.04.1 The .xml.in I regenerated and like ubuntu-gnome-wallpapers simplified the names field to one word. The structure I know understand and have rejigged to support user upgrades without wiping their current wallpaper; so when we come to 16.10 we'll change the main "budgie-wallpapers" package to recommend the yakkety package and add a Suggests for the xenial package. Unusually ubuntu-gnome-wallpapers didnt seem to have a standard wallpaper named for all releases - so I've used the ubuntu-wallpapers approach (warty) - so our standard name will be Xplo for all releases. David -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
Hi, I took a look at this and there are some issues. First, the version number for an Ubuntu package is wrong. I would suggest you follow Ubuntu's example and use 16.04.0-0ubuntu1. - The 16.04 is because you wrote in your intro that these are actually the xenial wallpapers. - The .0 is because you cannot change the original tarball but have to use a different version number each time. -1 would be the first Debian release. -2 would be the 2nd. -0ubuntu1 is a Ubuntu package where there wasn't a Debian release for that version or the Debian release wasn't used. Second and most importantly, according to your debian/copyright, you have images which are *not* redistributable in Ubuntu. You cannot use any Creative Commons *Non-Commercial* license. The Debian wiki is unclear about the status of CC version 2 licenses. Versions 3 and 4 are fine. Version 1 is not. It's commonly believed in Debian that the version 2 licenses aren't good enough. See bug 1588938 for instance where the Debian maintainers reported the issue to GNOME developers who replaced the version 2 pictures. Therefore, I recommend you try to find images that don't use CC version 2 licenses either just to be safe and it would be a huge headache to try to replace them once they are in use on people's computers. Third, I recommend you look at the ubuntu-wallpapers packaging how they have separate packages for each Ubuntu release. So Ubuntu 16.04 (xenial) users have ubuntu-wallpapers installed which depends on ubuntu- wallpapers-xenial. If they upgraded from 15.10, they'll also have ubuntu-wallpapers-wily installed. They can optionally install wallpapers from any or all releases going back to karmic. Fourth, in your .xml.in files you can use spaces in the name field. The name is for wallpaper choosers that show a name for each photo. The names are in that file so translators can translate them into other languages. I'm unsubscribing ~ubuntu-sponsors. Feel free to re-subscribe -sponsors when you're ready for sponsorship again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
** Tags added: needs-packaging ** Changed in: ubuntu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1594585] Re: [needs packaging] budgie-wallpapers
** Changed in: ubuntu Assignee: (unassigned) => fossfreedom (fossfreedom) ** Changed in: ubuntu Status: New => In Progress ** Description changed: As part of applying for official status for "Ubuntu Budgie", the technical board has requested that the team add our packages to the Ubuntu repos (universe). "Ubuntu Budgie" will initially consist of eight 16.10 packages listed here in the PPA description - - https://launchpad.net/~budgie-remix/+archive/ubuntu/yakkety-proposed + - https://launchpad.net/~budgie-remix/+archive/ubuntu/yakkety-proposed budgie-wallpapers contains the wallpapers for Ubuntu Budgie. This is a Ubuntu only package and is not appropriate for wider distribution through Debian. The package is based upon the same structure and debian packaging as the ubuntu-wallpapers package. The package initially contains the wallpapers for xenial. Within the 16.10 development cycle we will be updating with yakkety specific wallpapers as well. - [add link] + https://launchpad.net/~budgie-remix/+archive/ubuntu/yakkety- + proposed/+sourcepub/6556353/+listing-archive-extra -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1594585 Title: [needs packaging] budgie-wallpapers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1594585/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
