[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Mathew Hodson]

** No longer affects: iscsitarget (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/trusty/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Kellen Renshaw]

Hello,

Ran into this bug with iscsitarget 1.4.20.3+svn499-0ubuntu2.3, DKMS
failed to build.

The module built successfully with:

root@fleet-bunny:~# dpkg -l | grep iscsitarget-dkms
ii  iscsitarget-dkms  1.4.20.3+svn499-0ubuntu2.5

root@fleet-bunny:~# dkms status
iscsitarget, 1.4.20.3+svn499, 3.13.0-143-generic, x86_64: installed
iscsitarget, 1.4.20.3+svn499, 4.4.0-116-generic, x86_64: installed
iscsitarget, 1.4.20.3+svn499, 4.4.0-83-generic, x86_64: installed

** Tags removed: verification-needed-trusty
** Tags added: verification-done-trusty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Brian Murray]

Hello Kleber, or anyone else affected,

Accepted iscsitarget into trusty-proposed. The package will build now
and be available at
https://launchpad.net/ubuntu/+source/iscsitarget/1.4.20.3+svn499-0ubuntu2.4
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-trusty to verification-done-trusty. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-trusty. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: iscsitarget (Ubuntu Trusty)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-trusty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Mathew Hodson]

** Changed in: iscsitarget (Ubuntu)
   Importance: Undecided => Medium

** Changed in: iscsitarget (Ubuntu Xenial)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Thadeu Lima de Souza Cascardo]

** Changed in: iscsitarget (Ubuntu Trusty)
   Status: Triaged => In Progress

** Changed in: iscsitarget (Ubuntu Trusty)
   Importance: Undecided => Medium

** Patch added: "iscsitarget_1.4.20.3+svn499-0ubuntu2.4.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+attachment/5012430/+files/iscsitarget_1.4.20.3+svn499-0ubuntu2.4.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Thadeu Lima de Souza Cascardo]

** Description changed:

+ [Impact]
+ iscsitarget-dkms will fail to build for 4.4.0 kernels on trusty, when their 
ABI start with 1, like in -100 or -101.
+ 
+ [Test Case]
+ Install different kernels, including 3.13, and 4.4, and 4.4.0-78, 4.4.0-81 
and 4.4.0-101. That means different kernel base versions, different ABIs, 
including the offending one (that starts with 1), and the one that had not have 
the sock_recvmsg signature changed. All build successfully.
+ 
+ [Regression Potential]
+ Builds could fail with a future kernel or an old kernel we haven't tested 
with. A similar solution has already been applied to xenial. Some other way of 
calling dkms could make the build fail. Different ways have been tested in this 
case.
+ 
+ 
  iscsitarget ADT tests are failing on Trusty with linux-meta-lts-xenial
  4.4.0-101.124~14.04.1 due to iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3
  compilation failure.
  
  amd64:
  
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac
  /autopkgtest-
  trusty/trusty/amd64/i/iscsitarget/20171115_174514_4fc3d@/log.gz
  
  i386:
  
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac
  /autopkgtest-
  trusty/trusty/i386/i/iscsitarget/20171115_174142_4fc3d@/log.gz
  
  ppc64el:
  
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac
  /autopkgtest-
  trusty/trusty/ppc64el/i/iscsitarget/20171115_174421_4fc3d@/log.gz

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

Ok cascardo, that means it is fixed in Xenial and you'll take Trusty by
moving your existing fix there then - thanks for the info - updating
tasks.

** Changed in: iscsitarget (Ubuntu)
   Status: Triaged => Fix Released

** Changed in: iscsitarget (Ubuntu Xenial)
   Status: Incomplete => Fix Released

** Changed in: iscsitarget (Ubuntu Trusty)
 Assignee: (unassigned) => Thadeu Lima de Souza Cascardo (cascardo)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Thadeu Lima de Souza Cascardo]

It happens that the match was no good, and we replaced it with a grep
for the source that we uploaded for xenial. For some reason, we forgot
about trusty, so I am applying the same fix we added in xenial which
explains why linux-4.4.0-101-generic didn't hit the issue.

Cascardo.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[Ubuntu Foundations Team Bug Bot]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

Hmm, bug 1701697 lists Xenial - I'd wait for Cascardos comment but would
expect the same breakage there.

** Changed in: iscsitarget (Ubuntu)
 Assignee: (unassigned) => Thadeu Lima de Souza Cascardo (cascardo)

** Also affects: iscsitarget (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: iscsitarget (Ubuntu Trusty)
   Importance: Undecided
   Status: New

** Changed in: iscsitarget (Ubuntu Trusty)
   Status: New => Triaged

** Changed in: iscsitarget (Ubuntu Xenial)
   Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

it worked in my local tests, but @cascardo since you wrote the initial
patch - could you give that a review?

Also I haven't checked but if you brought the same change to Xenial it
will need the same fix there.

** Patch added: "fix-lp1732746-trusty.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+attachment/5010433/+files/fix-lp1732746-trusty.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

So the problem came in with:
iscsitarget (1.4.20.3+svn499-0ubuntu2.3) trusty; urgency=medium 



  * d/p/(porting|compat|enable)-4.4.0-84.patch: 

Add compat code to build with Ubuntu 4.4.0-84 (LP: #1701697)

··  

 -- Thadeu Lima de Souza Cascardo   Wed, 12 Jul 2017 
20:13:41 +


Per [1] this is applied if PATCH_MATCH matches.
But it is applied to 101 as that applies to "4\.4\.0-([1-7])"
Note: There is an implicit .* following

We would have to fix the rule to not patch it if >4.4.0.100

[1]: http://manpages.ubuntu.com/manpages/xenial/man8/dkms.8.html


** Changed in: iscsitarget (Ubuntu)
   Status: Confirmed => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

Really the prototype of sock_recvmsg changed ??
I don't think so, but we need to find what is going on.  ? (insert a little bit 
of WTF here)

One odd thing - I see only in the bad case
applying patch compat-4.4.0-84.patch...patching file kernel/nthread.c

That is from:
/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/patches/compat-4.4.0-84.patch

And here comes an interesting bit:
-   res = sock_recvmsg(conn->sock, , MSG_DONTWAIT | MSG_NOSIGNAL);
+   res = sock_recvmsg(conn->sock, , len, MSG_DONTWAIT | MSG_NOSIGNAL);


So the package already carries a compat patch (from where that comes from I 
don't know yet).
That patch is only applied to the new kernel in proposed.
And that makes it fail.


investigating ...

** Changed in: iscsitarget (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

Iniital checks on testbed setup

1. dkms build against Trusty base kernel 3.13.0-135-generic - ok
2. dkms build against current Trusty HWE kernel 4.4.0-98-generic - ok
3. build against proposed Trusty HWE kernel 4.4.0-101-generic - the reported 
error


In detail it is:
/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c: In function 
‘do_recv’:
/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c:129:2: error: 
too many arguments to function ‘sock_recvmsg’
  res = sock_recvmsg(conn->sock, , len, MSG_DONTWAIT | MSG_NOSIGNAL);
  ^
In file included from include/linux/skbuff.h:29:0,
 from include/linux/if_ether.h:23,
 from include/uapi/linux/ethtool.h:17,
 from include/linux/ethtool.h:17,
 from include/linux/netdevice.h:42,
 from include/net/sock.h:51,
 from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/iscsi.h:19,
 from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c:16:
include/linux/net.h:220:5: note: declared here
 int sock_recvmsg(struct socket *sock, struct msghdr *msg, int flags);
 ^
=> http://paste.ubuntu.com/25979971/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1732746] Re: [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on linux-lts-xenial kernel

[ChristianEhrhardt]

I'm so glad we removed that later due to being unmaintained :-/
See bug 1613758

But for this lets take a look at what recent stable updates trigger ...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732746

Title:
  [Trusty] iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.3 fails to build on
  linux-lts-xenial kernel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/1732746/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs