[Bug 1846947] Re: No profiling support
** Changed in: samba (Ubuntu) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1846947 Title: No profiling support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/netdata/+bug/1846947/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1846947] Re: No profiling support
Hi, I come by retriaging old bugs that have been dormant for too long giving them a second change. Right now is IMHO the right time (well again, the original report was as well) to give this a shot. We are just after an LTS could try it out and revert later if needed. I see fixes applied for profiling by upstream every now and then, so it isn't dead. If the performance overhead while disabled is indeed negligible then why not enabling it. But as outlined before we'd want to do so together with Debian, so next steps (for us): 1. To be safe - kick off a discussion with upstream why it never has been default enabled 2. Prep a change that enables this at build time (and tests it) 3. Submit that (plus a bug if needed) for discussion with Debian Bonus: In openvswitch when we were unsure about the supportability of DPDK enabled for non DPDK environments we ended up building openvswitch twice - not sure if that is feasible with the many libs and packages of samba - but it is one more option to consider (make an extra opt-in profile enabled binary). Adding server-todo (not do do it, but to give it a bit more time to evaluate what would happen and dirve the #1 discussion of above) ** Tags added: server-todo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1846947 Title: No profiling support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/netdata/+bug/1846947/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1846947] Re: No profiling support
Thanks for the explanations, now one can much better follow what this is about! ** Changed in: samba (Ubuntu) Status: Expired => Confirmed ** Also affects: netdata (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1846947 Title: No profiling support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/netdata/+bug/1846947/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1846947] Re: No profiling support
ad 1,2) Ubuntu provides both Netdata and Samba. Unfortunately the integration between the two is missing and therefor Netdata is currently unable to monitor Samba resources. For Netdata to monitor Samba it runs 'smbstatus -P', however this option is only available when Samba is compiled with support for profiling and when the option 'smbd profiling level = on' is specified in smb.conf ad 3) This issue can indeed be solved by Debian, indeed the most logical way to go forward is to create an upstream issue. ad 4) From Samba 2.2.5 release notes (18th June 2002): With samba compiled for profile data collection, you may see a very slight degradation in performance even with profiling collection turned off. On initial tests with NetBench on an SGI Origin 200 server, this degradation was not measurable with profile collection off compared to no profile collection compiled into samba. With count profile collection enabled on all clients, the degradation was less than 2%. With full profile collection enabled on all clients, the degradation was about 8.5%. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1846947 Title: No profiling support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1846947/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1846947] Re: No profiling support
[Expired for samba (Ubuntu) because there has been no activity for 60 days.] ** Changed in: samba (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1846947 Title: No profiling support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1846947/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1846947] Re: no profiling support in (at least) 19.10 - breaks netdata
Thank you for taking the time to report this bug and helping to make Ubuntu better. It would help if you could could please explain if and why compiling with profiling support is important to the majority of Ubuntu users. I'm also curious as to why upstream doesn't enable profiling in the build by default. Is there a downside to enabling profiling, such as any performance degradation? I would not be happy enabling a compile-time option, against upstream defaults, without a report examining any potential downsides. It might be easier to get upstream to enable profiling in the build by default - then all distributions will get this feature. Before this feature can be enabled, I think we need: 1) A full explanation of the use cases this would enable 2) An explanation as to why this is appropriate for Ubuntu to enable by default when it isn't enabled by default upstream 3) An explanation as to why this is appropriate for Ubuntu to enable by default when it isn't enabled by default in Debian 4) A report explaining the outcome of an investigation of any potential downsides of making this change Once those four things are explained, and assuming that following the explanation it still makes sense to do this in Ubuntu, please change the bug status back to New. If, following investigation, it is no longer appropriate to make the change in Ubuntu, then please comment and then change the bug status to Invalid. ** Changed in: samba (Ubuntu) Status: New => Incomplete ** Changed in: samba (Ubuntu) Importance: Undecided => Wishlist ** Summary changed: - no profiling support in (at least) 19.10 - breaks netdata + No profiling support -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1846947 Title: No profiling support To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1846947/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
