[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
This bug was fixed in the package wireguard - 1.0.20200513-1~16.04.2 --- wireguard (1.0.20200513-1~16.04.2) xenial; urgency=medium * Switch alternative dependency order for the wireguard-modules, wireguard-dkms alternative. Whichever is first is deemed the preferred installation candidate when neither is present. When this is wireguard-modules this is satisfied by installation of a random kernel which claims support for wireguard regardless of its applicability. Repeat after me, do not ever depend on a kernel. (LP: #1890201) -- Andy Whitcroft Tue, 04 Aug 2020 09:33:42 +0100 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
This bug was fixed in the package wireguard - 1.0.20200513-1~18.04.2 --- wireguard (1.0.20200513-1~18.04.2) bionic; urgency=medium * Switch alternative dependency order for the wireguard-modules, wireguard-dkms alternative. Whichever is first is deemed the preferred installation candidate when neither is present. When this is wireguard-modules this is satisfied by installation of a random kernel which claims support for wireguard regardless of its applicability. Repeat after me, do not ever depend on a kernel. (LP: #1890201) -- Andy Whitcroft Tue, 04 Aug 2020 09:29:13 +0100 ** Changed in: wireguard (Ubuntu Bionic) Status: Fix Committed => Fix Released ** Changed in: wireguard (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
This bug was fixed in the package wireguard - 1.0.20200513-1~20.04.2 --- wireguard (1.0.20200513-1~20.04.2) focal; urgency=medium * Switch alternative dependency order for the wireguard-modules, wireguard-dkms alternative. Whichever is first is deemed the preferred installation candidate when neither is present. When this is wireguard-modules this is satisfied by installation of a random kernel which claims support for wireguard regardless of its applicability. Repeat after me, do not ever depend on a kernel. (LP: #1890201) -- Andy Whitcroft Tue, 04 Aug 2020 08:50:04 +0100 ** Changed in: wireguard (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
Super! Sounds like a big improvement. Thanks for rolling this out so quickly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
Testing on bionic, with linux-oem 4.15.0.1093.96 installed and the old wireguard available, we do indeed try and install a linux-gke kernel to fill the dependency: $ sudo apt-get install wireguard Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: linux-image-5.3.0-1032-gke linux-image-gke-5.3 linux-modules-5.3.0-1032-gke wireguard-tools Suggested packages: fdutils linux-gke-5.3-doc-5.3.0 | linux-gke-5.3-source-5.3.0 linux-gke-5.3-tools linux-headers-5.3.0-1032-gke openresolv | resolvconf The following NEW packages will be installed linux-image-5.3.0-1032-gke linux-image-gke-5.3 linux-modules-5.3.0-1032-gke wireguard wireguard-tools 0 to upgrade, 5 to newly install, 0 to remove and 37 not to upgrade. Need to get 22.8 MB of archives. After this operation, 76.8 MB of additional disk space will be used. Do you want to continue? [Y/n] With just the updates wireguard packages available we no longer install the linux-gke and will install wireguard-dkms: $ sudo apt-get install wireguard Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: dkms fakeroot libfakeroot wireguard-dkms wireguard-tools Suggested packages: menu openresolv | resolvconf The following NEW packages will be installed dkms fakeroot libfakeroot wireguard wireguard-dkms wireguard-tools 0 to upgrade, 6 to newly install, 0 to remove and 37 not to upgrade. Need to get 500 kB of archives. After this operation, 2,708 kB of additional disk space will be used. Do you want to continue? [Y/n] With just the new linux-image-oem packages available we will upgrade those in preference to installing linux-gke: $ sudo apt-get install wireguard Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: linux-headers-oem linux-image-oem linux-oem wireguard-tools Suggested packages: openresolv | resolvconf The following NEW packages will be installed wireguard wireguard-tools The following packages will be upgraded: linux-headers-oem linux-image-oem linux-oem 3 to upgrade, 2 to newly install, 0 to remove and 37 not to upgrade. Need to get 93.3 kB/100 kB of archives. After this operation, 284 kB of additional disk space will be used. Do you want to continue? [Y/n] With both available an explicit installation of wireguard will install wireguard-dkms: $ sudo apt-get install wireguard Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: dkms fakeroot libfakeroot wireguard-dkms wireguard-tools Suggested packages: menu openresolv | resolvconf The following NEW packages will be installed dkms fakeroot libfakeroot wireguard wireguard-dkms wireguard-tools 0 to upgrade, 6 to newly install, 0 to remove and 40 not to upgrade. Need to get 500 kB of archives. After this operation, 2,708 kB of additional disk space will be used. Do you want to continue? [Y/n] -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
Great that this is going through the various levels of approval for SRU, but I do hope the actual bug -- Provides: being missing -- is fixed with this same level of urgency. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
Installed and confirmed the new dependencies are correct. ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
The real issue here with _this_ package is that the dependencies are wrong for Ubuntu. The Provides are missing on the linux-image-oem package yes, and it exposes this bug. But the bug is real and the point of _this_ bug is to fix that bug. ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic ** Changed in: wireguard (Ubuntu Focal) Importance: Undecided => High ** Changed in: wireguard (Ubuntu Bionic) Importance: Undecided => High ** Changed in: wireguard (Ubuntu Xenial) Importance: Undecided => High ** Changed in: wireguard (Ubuntu Focal) Assignee: (unassigned) => Andy Whitcroft (apw) ** Changed in: wireguard (Ubuntu Bionic) Assignee: (unassigned) => Andy Whitcroft (apw) ** Changed in: wireguard (Ubuntu Xenial) Assignee: (unassigned) => Andy Whitcroft (apw) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
Hello Andy, or anyone else affected, Accepted wireguard into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard/1.0.20200513-1~20.04.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: wireguard (Ubuntu Focal) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-focal ** Changed in: wireguard (Ubuntu Bionic) Status: New => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
This bug was fixed in the package wireguard - 1.0.20200513-1ubuntu1 --- wireguard (1.0.20200513-1ubuntu1) groovy; urgency=medium * Switch alternative dependency order for the wireguard-modules, wireguard-dkms alternative. Whichever is first is deemed the preferred installation candidate when neither is present. When this is wireguard-modules this is satisfied by installation of a random kernel which claims support for wireguard regardless of its applicability. Repeat after me, do not ever depend on a kernel. (LP: #1890201) -- Andy Whitcroft Mon, 03 Aug 2020 22:24:05 +0100 ** Changed in: wireguard (Ubuntu Groovy) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
https://salsa.debian.org/debian/wireguard/-/merge_requests/4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
** Description changed: - wireguard depends on wireguard-modules | wqireguard-dkms. This is - inverted. This will default to installing wireguard-modules in - preference to wireguard-dkms when neither is installed. In Ubuntu this - leads us to install an unrelated kernel to resolve the lack. We should - in that case install wireguard-dkms. + [Impact] + + * An explanation of the effects of the bug on users and + + * justification for backporting the fix to the stable release. + + * In addition, it is helpful, but not required, to include an +explanation of how the upload fixes this bug. + + [Test Case] + + * detailed instructions how to reproduce the bug + + * these should allow someone who is not familiar with the affected +package to reproduce the bug and verify that the updated package fixes +the problem. + + [Regression Potential] + + * discussion of how regressions are most likely to manifest as a result + of this change. + + * It is assumed that any SRU candidate patch is well-tested before +upload and has a low overall risk of regression, but it's important +to make the effort to think about what ''could'' happen in the +event of a regression. + + * This both shows the SRU team that the risks have been considered, +and provides guidance to testers in regression-testing the SRU. + + [Other Info] + + * Anything else you think is useful to include + * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board + * and address these questions in advance + + === 8< === 8< === + wireguard depends on wireguard-modules | wqireguard-dkms. This is inverted. This will default to installing wireguard-modules in preference to wireguard-dkms when neither is installed. In Ubuntu this leads us to install an unrelated kernel to resolve the lack. We should in that case install wireguard-dkms. ** Description changed: [Impact] - * An explanation of the effects of the bug on users and - - * justification for backporting the fix to the stable release. - - * In addition, it is helpful, but not required, to include an -explanation of how the upload fixes this bug. + Removal of the previously official PPA package can lead to installation + of an unrelated (and unbootable) kernel in preference to the official + DKMS package. [Test Case] - * detailed instructions how to reproduce the bug - - * these should allow someone who is not familiar with the affected -package to reproduce the bug and verify that the updated package fixes -the problem. + Install wireguard from a old kernel (or a kernel such as linux-oem-osp1 + which does not yet have builtin modules) and note that linux-gke or + similar is an installation candidate. [Regression Potential] - * discussion of how regressions are most likely to manifest as a result - of this change. - - * It is assumed that any SRU candidate patch is well-tested before -upload and has a low overall risk of regression, but it's important -to make the effort to think about what ''could'' happen in the -event of a regression. - - * This both shows the SRU team that the risks have been considered, -and provides guidance to testers in regression-testing the SRU. + Watch out for installation of the wireguard-dkms package when a kernel + which does support wireguard natively is installed. [Other Info] - - * Anything else you think is useful to include - * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board - * and address these questions in advance + + Wishing to expedite release of these packages as we are hitting this in + the wild. + === 8< === 8< === wireguard depends on wireguard-modules | wqireguard-dkms. This is inverted. This will default to installing wireguard-modules in preference to wireguard-dkms when neither is installed. In Ubuntu this leads us to install an unrelated kernel to resolve the lack. We should in that case install wireguard-dkms. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
The real issue here is that Andy forgot to add `Provides: wireguard- modules` to the linux-meta-oem package, and maybe some others here: - https://lists.zx2c4.com/pipermail/wireguard/2020-August/005743.html - https://lists.zx2c4.com/pipermail/wireguard/2020-August/005746.html - https://lists.zx2c4.com/pipermail/wireguard/2020-August/005747.html - https://lists.zx2c4.com/pipermail/wireguard/2020-August/005752.html I'd recommend that any fix here prioritize fixing the root cause issue - the missing Provides:. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890201] Re: Depends on wireguard-modules | wireguard-dkms are inverted
Should it turn out that Debian (where this order comes from) needs foo- modules | foo-dkms for their own internal ordering then we should invent a new keyword and switch to that: Depends: foo-modules | foo-dkms | foo-builtin Then we can provides wireguard-builtin instead. ** Changed in: wireguard (Ubuntu) Status: New => In Progress ** Changed in: wireguard (Ubuntu) Importance: Undecided => High ** Changed in: wireguard (Ubuntu) Assignee: (unassigned) => Andy Whitcroft (apw) ** Also affects: wireguard (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: wireguard (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: wireguard (Ubuntu Groovy) Importance: High Assignee: Andy Whitcroft (apw) Status: In Progress ** Also affects: wireguard (Ubuntu Focal) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890201 Title: Depends on wireguard-modules | wireguard-dkms are inverted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1890201/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
