[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-09-30 Thread Mathew Hodson
** Changed in: cloud-archive
   Status: New => Fix Released

** Tags removed: verification-queens-needed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-07-06 Thread James Page
This bug was fixed in the package ceph - 12.2.13-0ubuntu0.18.04.8~cloud0
---

 ceph (12.2.13-0ubuntu0.18.04.8~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 ceph (12.2.13-0ubuntu0.18.04.8) bionic; urgency=medium
 .
   * d/p/lp1908375*.patch: remove blkid calls from ceph-volume lvm list
 to improve performance/experience in systems with large numbers of
 slow disks (LP: #1908375).


** Changed in: cloud-archive/queens
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-07-05 Thread James Page
==
Totals
==
Ran: 99 tests in 1202.9744 sec.
 - Passed: 89
 - Skipped: 9
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 1
Sum of execute time for each test: 486.3905 sec.

Failed test is expected.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-21 Thread Dariusz Gadomski
Sorry for not stating that explicitly - yes, I have tested the -proposed 
version (
12.2.13-0ubuntu0.18.04.8).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-21 Thread Launchpad Bug Tracker
This bug was fixed in the package ceph - 12.2.13-0ubuntu0.18.04.8

---
ceph (12.2.13-0ubuntu0.18.04.8) bionic; urgency=medium

  * d/p/lp1908375*.patch: remove blkid calls from ceph-volume lvm list
to improve performance/experience in systems with large numbers of
slow disks (LP: #1908375).

 -- Dariusz Gadomski   Mon, 07 Jun 2021 16:39:26
+0200

** Changed in: ceph (Ubuntu Bionic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-21 Thread Łukasz Zemczak
I assume you were testing the -proposed packages! I trust your
verification, but for paperwork reasons please always include the
package version number in the comment.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-19 Thread Dariusz Gadomski
I have verified the package in 2 ways:
* manually (no traces of blkid calls in the log)
* automated - by using juju charms to set up a ceph deployment

In both cases there were no issues, no regressions noticed.

Verification is successful.

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-11 Thread Łukasz Zemczak
Looking much more crisp, thank you!

** Changed in: ceph (Ubuntu Bionic)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-10 Thread Chris MacNaughton
With the latest details and test-plan, I'm more comfortable with this
change, thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-10 Thread Dariusz Gadomski
** Description changed:

  [Impact]
  
   * Every ceph-volume list lvm  call invokes blkid for numerous 
PARTUUIDs. For some setups with many slower IO devices this can make this call 
to run for minutes without any actual justification for that.
  In fact, the upstream ceph approach changed in this matter and post-bionic 
releases already have ceph-volume that does not invoke blkid at all in this 
context making the call much faster.
  
  Please examine the attached ceph-volume.log fragment for a ceph-volume
  call, the accumulated blkid calls take around 1 min 7 s.
  
  [Test Case]
  
   * Setup a ceph-osd with numerous block devices with long access time for 
blkid. Preferably use automation tools like juju (with ceph charm) or ansible 
to make sure ceph-volume calls work well when automated.
   * Run
  time ceph-volume --log-path ceph-volume.log --log-level debug lvm list 

  on one of them and check the log to see if the execution time is not wasted 
on numerous blkid calls.
  
  [Where problems could occur]
  
-  * Although a potential fix does not introduce any changes to how ceph-
- volume is used any automation depending on ceph-volume log parsing may
- notice a change.
+  * The output format of does not change. The only noticeable change will
+ be visible in the (created on request with the --log-level --log-path
+ switched) log file. Such log will also be missing the blkid calls. I
+ don't see a reason for parsing that log file, but if any system (like
+ CI) is doing that it may need a manual intervention to update its
+ expected result.
  
  [Other Info]
  
   * The fix to this is available for Focal and beyond.
   * Xenial is not affected due to lack of ceph-volume in its ceph release.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-10 Thread James Page
Thanks Dariusz - not quite sure where the garbage came from as the
ubuntu/bionic branch in the git repo does not contain it.

This may have been my error when I uploaded the first one.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-10 Thread Dariusz Gadomski
I have reuploaded the patch removing unnecessary entries (debdiff
attached for reference).

** Patch added: "bionic.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+attachment/5503781/+files/bionic.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-07 Thread Edward Hope-Morley
upload to bionic unapproved queue on 11th May -
https://launchpadlibrarian.net/538166201/ceph_12.2.13-0ubuntu0.18.04.8_source.changes
and still awaiting sru team approval.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-06-07 Thread Edward Hope-Morley
** Also affects: cloud-archive
   Importance: Undecided
   Status: New

** Also affects: cloud-archive/queens
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-04-16 Thread Dariusz Gadomski
** Description changed:

  [Impact]
  
   * Every ceph-volume list lvm  call invokes blkid for numerous 
PARTUUIDs. For some setups with many slower IO devices this can make this call 
to run for minutes without any actual justification for that.
  In fact, the upstream ceph approach changed in this matter and post-bionic 
releases already have ceph-volume that does not invoke blkid at all in this 
context making the call much faster.
  
  Please examine the attached ceph-volume.log fragment for a ceph-volume
  call, the accumulated blkid calls take around 1 min 7 s.
  
  [Test Case]
  
   * Setup a ceph-osd with numerous block devices with long access time for 
blkid. Preferably use automation tools like juju (with ceph charm) or ansible 
to make sure ceph-volume calls work well when automated.
   * Run
  time ceph-volume --log-path ceph-volume.log --log-level debug lvm list 

- on one of them and check the log to see that most of the execution time is 
consumed by blkid calls.
+ on one of them and check the log to see if the execution time is not wasted 
on numerous blkid calls.
  
  [Where problems could occur]
  
   * Although a potential fix does not introduce any changes to how ceph-
  volume is used any automation depending on ceph-volume log parsing may
  notice a change.
  
  [Other Info]
  
   * The fix to this is available for Focal and beyond.
   * Xenial is not affected due to lack of ceph-volume in its ceph release.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-04-15 Thread Dariusz Gadomski
** Description changed:

  [Impact]
  
-  * Every ceph-volume list lvm  call invokes blkid for numerous 
PARTUUIDs. For some setups with many slower IO devices this can make this call 
to run for minutes without any actual justification for that.
+  * Every ceph-volume list lvm  call invokes blkid for numerous 
PARTUUIDs. For some setups with many slower IO devices this can make this call 
to run for minutes without any actual justification for that.
  In fact, the upstream ceph approach changed in this matter and post-bionic 
releases already have ceph-volume that does not invoke blkid at all in this 
context making the call much faster.
  
  Please examine the attached ceph-volume.log fragment for a ceph-volume
  call, the accumulated blkid calls take around 1 min 7 s.
  
- 
  [Test Case]
  
-  * Setup a ceph-osd with numerous block devices with long access time for 
blkid.
-  * Run
+  * Setup a ceph-osd with numerous block devices with long access time for 
blkid. Preferably use automation tools like juju (with ceph charm) or ansible 
to make sure ceph-volume calls work well when automated.
+  * Run
  time ceph-volume --log-path ceph-volume.log --log-level debug lvm list 

  on one of them and check the log to see that most of the execution time is 
consumed by blkid calls.
  
  [Where problems could occur]
  
-  * Although a potential fix does not introduce any changes to how ceph-
+  * Although a potential fix does not introduce any changes to how ceph-
  volume is used any automation depending on ceph-volume log parsing may
  notice a change.
  
  [Other Info]
-  
-  * The fix to this is available for Focal and beyond.
-  * Xenial is not affected due to lack of ceph-volume in its ceph release.
+ 
+  * The fix to this is available for Focal and beyond.
+  * Xenial is not affected due to lack of ceph-volume in its ceph release.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-04-02 Thread Dariusz Gadomski
ceph-volume.log from a node with 20 volumes.

** Attachment added: "charms-20-volumes-ceph-volume.log"
   
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+attachment/5483569/+files/charms-20-volumes-ceph-volume.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-04-02 Thread Dariusz Gadomski
I have successfully tested the patched version with a 3 ceph-osd nodes
setup, each with 10 or 20 OSDs. This setup has been deployed with juju
charms.

No problems were observed nor differences compared to a vanilla version.

Attaching ceph-volume.logs from an example node with 10 and 20 volumes.

** Attachment added: "charms-10-volumes-ceph-volume.log"
   
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+attachment/5483568/+files/charms-10-volumes-ceph-volume.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-03-16 Thread Dariusz Gadomski
I have also made an attempt to run tasks.ceph_deploy test suite with
vstart as this seems to be the only one that makes use of `ceph-volume`,
but I have failed due to Python2/Python3 syntax issues.

I have set up venv with Python2 (since qa/tasks/vstart_runner.py is not
Python3 compatible) with teuthology (pip install
git+https://github.com/ceph/teuthology@luminous#egg=teuthology[test]).

Test run result:
Traceback (most recent call last):
  File "../qa/tasks/vstart_runner.py", line 1086, in 
exec_test()
  File "../qa/tasks/vstart_runner.py", line 893, in exec_test
args=["ps", "-u"+str(os.getuid())]
  File "../qa/tasks/vstart_runner.py", line 296, in run
proc.wait()
  File "../qa/tasks/vstart_runner.py", line 164, in wait
self.stdout.write(out)
TypeError: unicode argument expected, got 'str'

I'm not sure how to successfully run the suite, but I'll keep trying.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-03-16 Thread Dariusz Gadomski
tox log for patched ceph-volume

** Attachment added: "ceph-volume-patched.tox.log"
   
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+attachment/5477101/+files/ceph-volume-patched.tox.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-03-16 Thread Dariusz Gadomski
I have performed a basic set of sanity testing on the patched ceph-
volume - no issues noticed nor difference in the output format.

I have also run ceph-volume tests with tox (logs attached: ceph-volume-
vanilla.tox.log - the unpatched version, ceph-volume-patched.tox.log -
patched version). In both cases status is identical:

grep -w passed *.tox.log
ceph-volume-patched.tox.log:= 1829 passed in 3.91 
seconds ==
ceph-volume-patched.tox.log:=== 1828 passed, 1 skipped in 
2.99s 
ceph-volume-vanilla.tox.log:= 1829 passed in 4.04 
seconds ==
ceph-volume-vanilla.tox.log:=== 1828 passed, 1 skipped in 
2.97s 

** Attachment added: "ceph-volume-vanilla.tox.log"
   
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+attachment/5477100/+files/ceph-volume-vanilla.tox.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-02-09 Thread Chris MacNaughton
The code in this change looks OK, but it's also a lot of change to
propose backporting to a stable release. Unfortunately, Luminous is EoL
upstream or we could push to land it upstream and bring it in via an
upstream point release which would be a bit safer for us.

Because this is fairly large of a change, I'd like to see a more
comprehensive test case for the SRU to ensure that we aren't regressing
other things by removing the blkid calls. As called out in the
regression potential, things that read the output of ceph-volume may be
impacted, so I'd like to see that covered as well in the test case.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-01-27 Thread Launchpad Bug Tracker
** Merge proposal linked:
   
https://code.launchpad.net/~dgadomski/ubuntu/+source/ceph/+git/ceph/+merge/397034

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-01-13 Thread Dariusz Gadomski
SRU proposal available as this branch:
https://code.launchpad.net/~dgadomski/ubuntu/+source/ceph/+git/ceph/+ref/lp1908375

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2021-01-11 Thread Dan Hill
** Also affects: ceph (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Also affects: ceph (Ubuntu Groovy)
   Importance: Undecided
   Status: New

** Changed in: ceph (Ubuntu Groovy)
   Status: New => Fix Released

** Changed in: ceph (Ubuntu Focal)
   Status: New => Fix Released

** Changed in: ceph (Ubuntu)
   Importance: Undecided => Medium

** Changed in: ceph (Ubuntu Groovy)
   Importance: Undecided => Medium

** Changed in: ceph (Ubuntu Focal)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1908375] Re: ceph-volume lvm list calls blkid numerous times for differrent devices

2020-12-16 Thread Dariusz Gadomski
** Attachment added: "ceph-volume.log snippet"
   
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+attachment/5444141/+files/ceph-volume.log

** Also affects: ceph (Ubuntu Bionic)
   Importance: Undecided
   Status: New

** Changed in: ceph (Ubuntu)
   Status: New => Fix Released

** Changed in: ceph (Ubuntu Bionic)
   Status: New => In Progress

** Changed in: ceph (Ubuntu Bionic)
   Importance: Undecided => Medium

** Changed in: ceph (Ubuntu Bionic)
 Assignee: (unassigned) => Dariusz Gadomski (dgadomski)

** Changed in: ceph (Ubuntu)
 Assignee: Dariusz Gadomski (dgadomski) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list  calls blkid numerous times for
  differrent devices

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs